Photos e2e: empty-state upload assertion matches two actions #1253

Open
opened 2026-10-06 23:36:58 +00:00 by kayg · 1 comment
Owner

Steps to reproduce:

  1. Build the production SPA and local server.
  2. Run bun e2e/photos.mjs --screenshots artifacts/bash-files/photos.
  3. Open the newly registered User's empty Photos view.

Expected: The e2e check confirms the empty-state upload action is available and continues.

Actual: The unscoped exact role query at apps/web/e2e/photos.mjs:948 resolves two visible buttons: the empty-state CTA and the top-row Upload action. Playwright strict mode stops the suite before any later Photos flows execute. Both controls are present and named; this report does not establish a product interaction failure.

Evidence: artifacts/bash-files/photos-empty-state-selector-failure.txt. The two matches and classes are included in the test runner error.

Severity: minor (e2e selector ambiguity; no user-facing failure established).

Steps to reproduce: 1. Build the production SPA and local server. 2. Run `bun e2e/photos.mjs --screenshots artifacts/bash-files/photos`. 3. Open the newly registered User's empty Photos view. Expected: The e2e check confirms the empty-state upload action is available and continues. Actual: The unscoped exact role query at `apps/web/e2e/photos.mjs:948` resolves two visible buttons: the empty-state CTA and the top-row Upload action. Playwright strict mode stops the suite before any later Photos flows execute. Both controls are present and named; this report does not establish a product interaction failure. Evidence: `artifacts/bash-files/photos-empty-state-selector-failure.txt`. The two matches and classes are included in the test runner error. Severity: minor (e2e selector ambiguity; no user-facing failure established).
Author
Owner

Fixed on job/bash-files in commit 0f53cde29. The assertion now scopes the centered CTA to the “No photos” region and separately verifies the top-row action. Both controls open the real picker (pointer and Enter) and cancellation leaves the empty state. Existing accessible names and expectations are unchanged.

Fixed on `job/bash-files` in commit `0f53cde29`. The assertion now scopes the centered CTA to the “No photos” region and separately verifies the top-row action. Both controls open the real picker (pointer and Enter) and cancellation leaves the empty state. Existing accessible names and expectations are unchanged.
Commenting is not possible because the repository is archived.
No labels
No milestone
No project
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kayg/calternal-v0#1253
No description provided.