Photos Quick Look E2E waits for obsolete title selector #1260

Open
opened 2026-10-06 23:52:37 +00:00 by kayg · 2 comments
Owner

Steps

  1. Run the Photos E2E flow against the local production SPA and server.
  2. Upload/seed the suite's photo fixture set and open the first photo in Quick Look.
  3. Wait for .ql-title h2, as apps/web/e2e/photos.mjs currently does.

Expected

The test reads the Quick Look title and continues its viewer checks.

Actual

Quick Look opens and displays IMG_1008.JPG (1 of 45), but the test times out because the title is exposed as an accessible role=heading with aria-level=2, not as an h2 beneath .ql-title.

Evidence

artifacts/bash-files/photos/photos-viewer-title-timeout.png

Severity: minor (test selector mismatch; no user-facing viewer failure observed).

## Steps 1. Run the Photos E2E flow against the local production SPA and server. 2. Upload/seed the suite's photo fixture set and open the first photo in Quick Look. 3. Wait for `.ql-title h2`, as `apps/web/e2e/photos.mjs` currently does. ## Expected The test reads the Quick Look title and continues its viewer checks. ## Actual Quick Look opens and displays `IMG_1008.JPG` (1 of 45), but the test times out because the title is exposed as an accessible `role=heading` with `aria-level=2`, not as an `h2` beneath `.ql-title`. ## Evidence `artifacts/bash-files/photos/photos-viewer-title-timeout.png` Severity: minor (test selector mismatch; no user-facing viewer failure observed).
Author
Owner

The same obsolete .ql-title h2 selector appears in the Files Quick Look E2E paths (keyboard, touch Recent, long names, and deep links). I am updating the app-owned E2E checks in both Files and Photos to use the accessible heading, keeping all filename assertions intact.

The same obsolete `.ql-title h2` selector appears in the Files Quick Look E2E paths (keyboard, touch Recent, long names, and deep links). I am updating the app-owned E2E checks in both Files and Photos to use the accessible heading, keeping all filename assertions intact.
Author
Owner

Fixed on job/bash-files in commit 44179feb8. Files and Photos E2E checks use a shared helper that locates the accessible level-two heading in Quick Look; existing filename/text assertions remain unchanged. The Photos flow passed both the first viewer title and direct-link title checks; Files' PDF accessibility flow passed the new heading lookup.

Fixed on `job/bash-files` in commit `44179feb8`. Files and Photos E2E checks use a shared helper that locates the accessible level-two heading in Quick Look; existing filename/text assertions remain unchanged. The Photos flow passed both the first viewer title and direct-link title checks; Files' PDF accessibility flow passed the new heading lookup.
Commenting is not possible because the repository is archived.
No labels
No milestone
No project
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kayg/calternal-v0#1260
No description provided.