Photos screenshot E2E does not install user storage theme seam #1285

Open
opened 2026-10-07 00:46:08 +00:00 by kayg · 1 comment
Owner

Steps

  1. Run bun e2e/photos.mjs --screenshots-only --screenshots <dir> against the current production build.
  2. Let the first extensionless Files/Photos screenshots finish.
  3. Continue to the next theme setup in captureContentTypeEvidence.

Expected

The screenshot-only path saves the User-scoped theme preference and continues capturing all widths and themes.

Actual

storeEvidenceThemePreference throws because window.__userStorageTest is undefined. The Photos E2E context does not install the existing installUserStorageTestSeam helper before navigating.

Evidence

artifacts/bash-files/photos/photos-screenshot-theme-seam-failure.txt

Severity: minor (screenshot-only E2E harness stops; no production UI failure observed).

## Steps 1. Run `bun e2e/photos.mjs --screenshots-only --screenshots <dir>` against the current production build. 2. Let the first extensionless Files/Photos screenshots finish. 3. Continue to the next theme setup in `captureContentTypeEvidence`. ## Expected The screenshot-only path saves the User-scoped theme preference and continues capturing all widths and themes. ## Actual `storeEvidenceThemePreference` throws because `window.__userStorageTest` is undefined. The Photos E2E context does not install the existing `installUserStorageTestSeam` helper before navigating. ## Evidence `artifacts/bash-files/photos/photos-screenshot-theme-seam-failure.txt` Severity: minor (screenshot-only E2E harness stops; no production UI failure observed).
Author
Owner

Fixed on branch in commit 0c61c0ed3: the existing installUserStorageTestSeam helper now runs in the desktop, tablet and phone contexts before theme evidence writes User-scoped preferences. A focused Playwright check passed in all three contexts. The screenshot-only rerun advanced beyond the missing-seam error but timed out while Photos paired an extensionless HEIC/MOV under slow DB load; that pairing passed in the earlier run.

Fixed on branch in commit `0c61c0ed3`: the existing `installUserStorageTestSeam` helper now runs in the desktop, tablet and phone contexts before theme evidence writes User-scoped preferences. A focused Playwright check passed in all three contexts. The screenshot-only rerun advanced beyond the missing-seam error but timed out while Photos paired an extensionless HEIC/MOV under slow DB load; that pairing passed in the earlier run.
Commenting is not possible because the repository is archived.
No labels
No milestone
No project
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kayg/calternal-v0#1285
No description provided.