Files gate: isolate password worker contention and busy-host deadlines #1342

Open
opened 2026-10-07 08:37:48 +00:00 by kayg · 0 comments
Owner

Found while verifying #1295 on job/journaldup (source head b50bdfffa). The Journal regressions pass. No existing assertion or fixture was changed to make these cases pass.

Command: CARGO_PROFILE_DEV_DEBUG=line-tables-only CARGO_INCREMENTAL=0 CARGO_BUILD_JOBS=4 cargo test -p calternal-plugin-files -- --test-threads=4.

test result: FAILED. 267 passed; 4 failed; 4 ignored; 0 measured; 0 filtered out; finished in 760.86s

Failures:

  • public_password_is_checked_once_then_parallel_requests_pass: link creation returned 429, expected 200. public.rs documents a process-wide two-worker/sixteen-admission Argon2 budget with a five-second queue bound. This test passes in an isolated serial run.
  • public_password_attempts_are_reserved_before_parallel_checks: responses [401, 401, 429, 429, 429, 401, 401, 429]; four unauthorized instead of five. The test counts all 429 replies as spent guesses, while worker admission also uses 429. It passes in an isolated serial run.
  • public_password_rejection_does_not_wait_for_data_mutation_lock: the unchanged two-second timeout returned Elapsed(()), both in the suite and in isolation. The timeout includes Argon2 verification, not only lock wait.
  • internal_temp_paths_never_enter_index_during_atomic_write_reconcile_storm: the unchanged five-minute timeout returned Elapsed(()) for the existing 1,000 writes/four scans/watcher. No temp-path leak assertion was reported.

Isolated executable command: calternal_plugin_files-b8b96acb0f0e9812 public_password_ --test-threads=1.

test result: FAILED. 3 passed; 1 failed; 0 ignored; 0 measured; 271 filtered out; finished in 50.91s

Please review deterministic worker/fixture isolation and how the tests distinguish admission throttling from password-attempt throttling. Keep their security and confinement assertions. The #1295 job does not modify public-password behavior or raise any deadline. Logs remain in its worktree under artifacts/jd4-files-test.log and artifacts/jd4-password-isolated.log.

Found while verifying #1295 on job/journaldup (source head b50bdfffa). The Journal regressions pass. No existing assertion or fixture was changed to make these cases pass. Command: `CARGO_PROFILE_DEV_DEBUG=line-tables-only CARGO_INCREMENTAL=0 CARGO_BUILD_JOBS=4 cargo test -p calternal-plugin-files -- --test-threads=4`. ``` test result: FAILED. 267 passed; 4 failed; 4 ignored; 0 measured; 0 filtered out; finished in 760.86s ``` Failures: - `public_password_is_checked_once_then_parallel_requests_pass`: link creation returned 429, expected 200. `public.rs` documents a process-wide two-worker/sixteen-admission Argon2 budget with a five-second queue bound. This test passes in an isolated serial run. - `public_password_attempts_are_reserved_before_parallel_checks`: responses `[401, 401, 429, 429, 429, 401, 401, 429]`; four unauthorized instead of five. The test counts all 429 replies as spent guesses, while worker admission also uses 429. It passes in an isolated serial run. - `public_password_rejection_does_not_wait_for_data_mutation_lock`: the unchanged two-second timeout returned `Elapsed(())`, both in the suite and in isolation. The timeout includes Argon2 verification, not only lock wait. - `internal_temp_paths_never_enter_index_during_atomic_write_reconcile_storm`: the unchanged five-minute timeout returned `Elapsed(())` for the existing 1,000 writes/four scans/watcher. No temp-path leak assertion was reported. Isolated executable command: `calternal_plugin_files-b8b96acb0f0e9812 public_password_ --test-threads=1`. ``` test result: FAILED. 3 passed; 1 failed; 0 ignored; 0 measured; 271 filtered out; finished in 50.91s ``` Please review deterministic worker/fixture isolation and how the tests distinguish admission throttling from password-attempt throttling. Keep their security and confinement assertions. The #1295 job does not modify public-password behavior or raise any deadline. Logs remain in its worktree under artifacts/jd4-files-test.log and artifacts/jd4-password-isolated.log.
Commenting is not possible because the repository is archived.
No labels
No milestone
No project
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kayg/calternal-v0#1342
No description provided.