Money e2e exact Month expectation conflicts with empty Notes child #1343

Open
opened 2026-10-07 08:52:46 +00:00 by kayg · 0 comments
Owner

Found during merge32b (#1122), after fixing the current CSV Review selector (#1318). A focused production User flow preserves all numeric and Markdown assertions and omits only screenshot loops. It passes Budget creation, Category and Account creation, inline assignment, register posting, tag rendering and the displayed derived values. It then fails assertPersistedMonthRows: the original regular expression anchors the final Transaction row at end of file, but the file has an additional empty child line - notes:: "". The top-level Transaction and numeric values match.

DESIGN §48 separates Transaction notes from the Payee. The #1130 JSON property tests admit empty notes. The Money TransactionForm and plugin store have no diff from origin/dev 3601719b8, so this serialization behavior is pre-existing. It causes no data loss, corruption or changed balances.

The owner rule forbids changing an existing expectation unless the issue changes that behavior. #1318 changes the Review contract, not this file expectation. I kept the original anchored regular expression and all source values unchanged. Owner follow-up: decide whether a new Transaction with empty Notes should omit the child line, or whether the exact e2e expectation should include it. No Money product change was made.

Evidence: artifacts/merge32b/money-numeric-probe2.log. The full Money area flow cannot be reported as passing to the end until this preserved expectation is resolved.

Found during merge32b (#1122), after fixing the current CSV Review selector (#1318). A focused production User flow preserves all numeric and Markdown assertions and omits only screenshot loops. It passes Budget creation, Category and Account creation, inline assignment, register posting, tag rendering and the displayed derived values. It then fails assertPersistedMonthRows: the original regular expression anchors the final Transaction row at end of file, but the file has an additional empty child line ` - notes:: ""`. The top-level Transaction and numeric values match. DESIGN §48 separates Transaction notes from the Payee. The #1130 JSON property tests admit empty notes. The Money TransactionForm and plugin store have no diff from origin/dev 3601719b8, so this serialization behavior is pre-existing. It causes no data loss, corruption or changed balances. The owner rule forbids changing an existing expectation unless the issue changes that behavior. #1318 changes the Review contract, not this file expectation. I kept the original anchored regular expression and all source values unchanged. Owner follow-up: decide whether a new Transaction with empty Notes should omit the child line, or whether the exact e2e expectation should include it. No Money product change was made. Evidence: artifacts/merge32b/money-numeric-probe2.log. The full Money area flow cannot be reported as passing to the end until this preserved expectation is resolved.
Commenting is not possible because the repository is archived.
No labels
No milestone
No project
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kayg/calternal-v0#1343
No description provided.