Shortcut opening Quick Look leaves a focus ring before keyboard navigation #1406

Open
opened 2026-10-07 21:52:10 +00:00 by kayg · 0 comments
Owner

Found during #1403 merge-round PDF captures on the real production build, macOS-emulated Chromium at 390 px (also review 820/1440).

Reproduction: open Files, click a PDF row, press Space to open Quick Look. The close IconButton receives a blue focus ring immediately. The attached merge-round shortcut capture records it. No Tab or arrow navigation is required.

The owner rule of 2026-10-07 permits rings only after Tab/arrow navigation. keydownSignalsKeyboardModality in apps/web/src/lib/a11y/inputModality.ts treats every non-editable shortcut target as keyboard modality; focusQuietly then preserves the browser ring on programmatic focus. Quick Look already uses this shared helper.

This is a cosmetic, non-blocking finding. Fix the shared modality/focus policy with owner-reviewed regression expectations. Do not change motion durations: keyboard actions must still animate.

Found during #1403 merge-round PDF captures on the real production build, macOS-emulated Chromium at 390 px (also review 820/1440). Reproduction: open Files, click a PDF row, press Space to open Quick Look. The close IconButton receives a blue focus ring immediately. The attached merge-round shortcut capture records it. No Tab or arrow navigation is required. The owner rule of 2026-10-07 permits rings only after Tab/arrow navigation. `keydownSignalsKeyboardModality` in `apps/web/src/lib/a11y/inputModality.ts` treats every non-editable shortcut target as keyboard modality; `focusQuietly` then preserves the browser ring on programmatic focus. Quick Look already uses this shared helper. This is a cosmetic, non-blocking finding. Fix the shared modality/focus policy with owner-reviewed regression expectations. Do not change motion durations: keyboard actions must still animate.
Commenting is not possible because the repository is archived.
No labels
No milestone
No project
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kayg/calternal-v0#1406
No description provided.