Search review test contradicts the accessible results scroll Tab stop #1407

Open
opened 2026-10-07 21:54:35 +00:00 by kayg · 0 comments
Owner

Found during #1403 real-server Search review. SEARCH_E2E_1360_ONLY=1 bun e2e/search.mjs --screenshots ... stops after the desktop opening captures:

AssertionError: the scroll container does not add a competing keyboard focus ring
'0' !== null

The production base ef0aa12b1 intentionally gives the named Search results region tabindex="0" for keyboard scrolling (#1320, DESIGN §34). Its existing E2E checks already require this attribute to be absent. The #1360 merge preserved the base accessibility Tab stop and therefore exposes the same contradiction. The test checks an attribute, not actual focus-ring paint.

Do not remove the keyboard scroll access to make this test pass. Reconcile the assertion with the owner and test keyboard scrolling plus actual ring paint. The merge round keeps every existing assertion unchanged and records the failed run. Screenshots are collected separately without claiming this E2E passed.

This is non-blocking test drift; no crash, corruption or authorization failure is observed.

Found during #1403 real-server Search review. `SEARCH_E2E_1360_ONLY=1 bun e2e/search.mjs --screenshots ...` stops after the desktop opening captures: ``` AssertionError: the scroll container does not add a competing keyboard focus ring '0' !== null ``` The production base ef0aa12b1 intentionally gives the named Search results region `tabindex="0"` for keyboard scrolling (#1320, DESIGN §34). Its existing E2E checks already require this attribute to be absent. The #1360 merge preserved the base accessibility Tab stop and therefore exposes the same contradiction. The test checks an attribute, not actual focus-ring paint. Do not remove the keyboard scroll access to make this test pass. Reconcile the assertion with the owner and test keyboard scrolling plus actual ring paint. The merge round keeps every existing assertion unchanged and records the failed run. Screenshots are collected separately without claiming this E2E passed. This is non-blocking test drift; no crash, corruption or authorization failure is observed.
Commenting is not possible because the repository is archived.
No labels
No milestone
No project
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kayg/calternal-v0#1407
No description provided.