Phone Quick Look header covers text at the top of the first PDF page #1408

Closed
opened 2026-10-07 22:03:26 +00:00 by kayg · 4 comments
Owner

Found in #1403 PDF Quick Look captures from a real local server and production SPA, macOS-emulated Chromium.

At 390 px, the floating title/actions header covers the text at the top of the first PDF page. The test fixture's Accessible PDF body 1 is visible at desktop width but hidden by the phone header; the second page's body is visible below. The accessibility tree and selectable text tests pass. This is paint occlusion, not missing data.

Reproduction: open a text PDF whose first line is near its top edge in Files Quick Look at 390 px, scroll to the start. Compare #1403's pdf-quicklook-390-light.png with pdf-quicklook-1440-light.png.

Fix the shared viewer's content clearance using existing role tokens. Do not add runtime layout measurements or restyle the shared Pill controls locally. Cosmetic, non-blocking finding; keep the current PDF accessibility expectations.

Found in #1403 PDF Quick Look captures from a real local server and production SPA, macOS-emulated Chromium. At 390 px, the floating title/actions header covers the text at the top of the first PDF page. The test fixture's `Accessible PDF body 1` is visible at desktop width but hidden by the phone header; the second page's body is visible below. The accessibility tree and selectable text tests pass. This is paint occlusion, not missing data. Reproduction: open a text PDF whose first line is near its top edge in Files Quick Look at 390 px, scroll to the start. Compare #1403's `pdf-quicklook-390-light.png` with `pdf-quicklook-1440-light.png`. Fix the shared viewer's content clearance using existing role tokens. Do not add runtime layout measurements or restyle the shared Pill controls locally. Cosmetic, non-blocking finding; keep the current PDF accessibility expectations.
Author
Owner

Additional reproduction of this same shared Quick Look paint occlusion: after fixing public text classification in #1419, a signed-out public link for a one-line .txt file opens TextView, but the floating title pill covers the text at the top. At 1440 px, the DOM text exists at y=39 with visible style, while the captured viewer appears blank except for its title pill. A view-only one-line file is therefore unreadable. Evidence: /home/kayg/Developer/calternal-wt/bash-core/artifacts/bash-core2/public-preview-pixels.png. This appears to be the same viewer clearance defect and stays filed only because packages/ui owns Quick Look.

Additional reproduction of this same shared Quick Look paint occlusion: after fixing public text classification in #1419, a signed-out public link for a one-line `.txt` file opens TextView, but the floating title pill covers the text at the top. At 1440 px, the DOM text exists at `y=39` with visible style, while the captured viewer appears blank except for its title pill. A view-only one-line file is therefore unreadable. Evidence: `/home/kayg/Developer/calternal-wt/bash-core/artifacts/bash-core2/public-preview-pixels.png`. This appears to be the same viewer clearance defect and stays filed only because `packages/ui` owns Quick Look.
Author
Owner

Starting: branch job/qltitle-1408, base d395b6e25.

Starting: branch job/qltitle-1408, base d395b6e25.
Author
Owner

Finished: head 2741f6393. Quick Look content now starts below the pill via --viewer-clear-top (text, Markdown, PDF, image). e2e apps/web/e2e/quicklook-clear-1408.mjs fails before and passes after. bun run check exit 0; full test 2115/2116, one load timeout (AppPasswordsGroup) passes alone.

Finished: head 2741f6393. Quick Look content now starts below the pill via --viewer-clear-top (text, Markdown, PDF, image). e2e apps/web/e2e/quicklook-clear-1408.mjs fails before and passes after. bun run check exit 0; full test 2115/2116, one load timeout (AppPasswordsGroup) passes alone.
kayg referenced this issue from a commit 2026-10-08 10:41:40 +00:00
Author
Owner

Deployed to calternal.cloud in merge round 35a (build cc1af3c12, live 2026-10-09 00:12 IST). Closing.

Deployed to calternal.cloud in merge round 35a (build cc1af3c12, live 2026-10-09 00:12 IST). Closing.
kayg closed this issue 2026-10-08 18:41:45 +00:00
Commenting is not possible because the repository is archived.
No labels
No milestone
No project
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kayg/calternal-v0#1408
No description provided.