Calendar Tab: view switcher tooltips omit shortcuts #1429

Closed
opened 2026-10-08 03:01:10 +00:00 by kayg · 3 comments
Owner

Steps

  1. Open Calendar in the production web app with a real Event visible.
  2. Hover each option in the centred Agenda / Day / Week / Month / Year view control.

Expected

Each warm tooltip shows its registered shortcut: Agenda 5, Day 1, Week 2, Month 3, Year 4. Each radio also exposes the shortcut to assistive technology. This is required by docs/DESIGN.md §34 and the Calendar shortcut registry.

Actual

The tooltip labels are present, but all five controls have no data-tooltip-keys or aria-keyshortcuts attributes. The visible tooltip shows the view name without its shortcut.

Evidence

  • artifacts/bash3-calendar/agenda-view-shortcut-mac.png (production app, macOS platform emulation, real Journal data loaded)
  • artifacts/bash3-calendar/agenda-view-shortcut-metadata.json (all five radio attributes)

Severity: minor. The shortcuts still switch views, but they are undiscoverable from the control and are not announced on the radio.

## Steps 1. Open Calendar in the production web app with a real Event visible. 2. Hover each option in the centred Agenda / Day / Week / Month / Year view control. ## Expected Each warm tooltip shows its registered shortcut: Agenda `5`, Day `1`, Week `2`, Month `3`, Year `4`. Each radio also exposes the shortcut to assistive technology. This is required by `docs/DESIGN.md` §34 and the Calendar shortcut registry. ## Actual The tooltip labels are present, but all five controls have no `data-tooltip-keys` or `aria-keyshortcuts` attributes. The visible tooltip shows the view name without its shortcut. ## Evidence - `artifacts/bash3-calendar/agenda-view-shortcut-mac.png` (production app, macOS platform emulation, real Journal data loaded) - `artifacts/bash3-calendar/agenda-view-shortcut-metadata.json` (all five radio attributes) Severity: minor. The shortcuts still switch views, but they are undiscoverable from the control and are not announced on the radio.
Author
Owner

Fixed in commit 2c957adac on job/bash3-calendar. Calendar view options now resolve the configured shortcut combo through the shared shortcut registry, so each view tooltip includes its key and each radio exposes aria-keyshortcuts.

Verified all five views at 390, 820 and 1440 px in light and dark with macOS platform emulation, a matching production web build, and a real Journal Log visible. Clean screenshots: artifacts/bash3-calendar/calendar-shortcuts-clean-{390,820,1440}-{light,dark}-mac.png.

bun run check passed with 0 errors and 4 existing warnings. bun run test: 297 files and 2,116 tests passed.

Fixed in commit 2c957adac on `job/bash3-calendar`. Calendar view options now resolve the configured shortcut combo through the shared shortcut registry, so each view tooltip includes its key and each radio exposes `aria-keyshortcuts`. Verified all five views at 390, 820 and 1440 px in light and dark with macOS platform emulation, a matching production web build, and a real Journal Log visible. Clean screenshots: `artifacts/bash3-calendar/calendar-shortcuts-clean-{390,820,1440}-{light,dark}-mac.png`. `bun run check` passed with 0 errors and 4 existing warnings. `bun run test`: 297 files and 2,116 tests passed.
Author
Owner

Evidence note: the original screenshot and metadata filenames in the issue body were later overwritten by post-fix captures during this Round 3 run; they now show the fixed shortcut hints. The clean after captures are artifacts/bash3-calendar/calendar-shortcuts-clean-{390,820,1440}-{light,dark}-mac.png. The original before screenshot is no longer available, so the visual before/after artifact requirement has a gap; the pre-fix behavior remains documented in the issue description and source diff.

Evidence note: the original screenshot and metadata filenames in the issue body were later overwritten by post-fix captures during this Round 3 run; they now show the fixed shortcut hints. The clean after captures are `artifacts/bash3-calendar/calendar-shortcuts-clean-{390,820,1440}-{light,dark}-mac.png`. The original before screenshot is no longer available, so the visual before/after artifact requirement has a gap; the pre-fix behavior remains documented in the issue description and source diff.
Author
Owner

Deployed to calternal.cloud in merge round 35a (build cc1af3c12, live 2026-10-09 00:12 IST). Closing.

Deployed to calternal.cloud in merge round 35a (build cc1af3c12, live 2026-10-09 00:12 IST). Closing.
kayg closed this issue 2026-10-08 18:41:57 +00:00
Commenting is not possible because the repository is archived.
No labels
No milestone
No project
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kayg/calternal-v0#1429
No description provided.