Photos screenshot Undo locator misses restored feedback #1514

Open
opened 2026-10-09 07:31:56 +00:00 by kayg · 0 comments
Owner

Merge round #1500 ran bun e2e/photos.mjs --screenshots <dir> against merged and production 9dc65437e assets.

The merged functional checks pass the Tags and burst key-photo Undo API invariants, Taken information, HEIC rendering, selection and Trash Undo. The later screenshot matrix fails at line1122 while waiting for the key-photo restored toast after clicking the last global Undo. That capture block and the key-photo toast implementation are unchanged from production; production stops earlier at the existing Tags toast text assertion, so the later failure has not been reproduced independently on production.

Review whether the global Undo locator picks another toast or whether the drop policy suppresses the restored notification during the prior toast's exit. Do not weaken the functional Undo assertions. A separate 5,000-Photo capture already proves the loaded viewer at 1440/820/390 in light/dark, including pointer and shortcut opening without rings. This is a capture/feedback gap; no byte loss or duplicate Photo was observed.

Merge round #1500 ran `bun e2e/photos.mjs --screenshots <dir>` against merged and production 9dc65437e assets. The merged functional checks pass the Tags and burst key-photo Undo API invariants, Taken information, HEIC rendering, selection and Trash Undo. The later screenshot matrix fails at line1122 while waiting for the key-photo restored toast after clicking the last global Undo. That capture block and the key-photo toast implementation are unchanged from production; production stops earlier at the existing Tags toast text assertion, so the later failure has not been reproduced independently on production. Review whether the global Undo locator picks another toast or whether the drop policy suppresses the restored notification during the prior toast's exit. Do not weaken the functional Undo assertions. A separate 5,000-Photo capture already proves the loaded viewer at 1440/820/390 in light/dark, including pointer and shortcut opening without rings. This is a capture/feedback gap; no byte loss or duplicate Photo was observed.
Commenting is not possible because the repository is archived.
No labels
No milestone
No project
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kayg/calternal-v0#1514
No description provided.