Shortcut geometry e2e expects caps in the phone Search footer #1564

Open
opened 2026-10-10 21:39:28 +00:00 by kayg · 0 comments
Owner

Merge round #1561 ran kbd-1134.mjs on merged code and production 4ebeba0b8. The full merged run passes the new plain menu shortcuts and the Search tooltip geometry, then fails at the phone Search footer: chromium paper palette footer: visible shortcut caps are present.

The phone Search footer has no caps by design. apps/web/src/lib/components/search-dialog.svelte derives showHints from !coarsePointer.current && !phone.current, then renders its Kbd caps only if showHints. That source is unchanged by this merge.

Added a surface selector for diagnosis only. The same script with CALTERNAL_KBD_1134_SURFACE=palette-footer CALTERNAL_KBD_1134_ENGINE=chromium fails the identical assertion on both production and merged builds. Existing assertions and all default scenarios remain unchanged. The original full production run stops earlier at its old menu cap markup, so this focused replay is needed to classify the footer.

Correct the test with the owner-approved expected phone behavior; do not change UI solely to satisfy this old assertion. This failure prevents subsequent viewport/theme/engine checks in the full script.

Merge round #1561 ran kbd-1134.mjs on merged code and production 4ebeba0b8. The full merged run passes the new plain menu shortcuts and the Search tooltip geometry, then fails at the phone Search footer: `chromium paper palette footer: visible shortcut caps are present`. The phone Search footer has no caps by design. `apps/web/src/lib/components/search-dialog.svelte` derives `showHints` from `!coarsePointer.current && !phone.current`, then renders its Kbd caps only if showHints. That source is unchanged by this merge. Added a surface selector for diagnosis only. The same script with `CALTERNAL_KBD_1134_SURFACE=palette-footer CALTERNAL_KBD_1134_ENGINE=chromium` fails the identical assertion on both production and merged builds. Existing assertions and all default scenarios remain unchanged. The original full production run stops earlier at its old menu cap markup, so this focused replay is needed to classify the footer. Correct the test with the owner-approved expected phone behavior; do not change UI solely to satisfy this old assertion. This failure prevents subsequent viewport/theme/engine checks in the full script.
Commenting is not possible because the repository is archived.
No labels
No milestone
No project
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kayg/calternal-v0#1564
No description provided.