Money: long names, zero amounts and phone titles break the layout (break-ui findings) #1613

Closed
opened 2026-10-12 12:49:43 +00:00 by kayg · 2 comments
Owner

Money breaks with long or edge-case data (break-ui review #1598; shots on branch worktree-agent-a0afcda97025f5170 under artifacts/ui-breakui/):

  1. Money sidebar: the account name becomes "Che…" next to a 15-character balance (money@1440-light). The name gets priority; the balance can drop to a compact form or wrap below per HIG.
  2. Register: a zero amount renders two empty cells with no €0.00 (money-accounts@1440-light). A zero transaction must show €0.00 in the column it belongs to.
  3. Phone page titles truncate to 4–6 letters ("Hous…") while space remains (money@390-light).
  4. Money empty budget: focus lands on the second field, and the button sits under the first.

Money rule: every change gets an extra number review (property tests for any amount formatting change).

Money breaks with long or edge-case data (break-ui review #1598; shots on branch worktree-agent-a0afcda97025f5170 under artifacts/ui-breakui/): 1. Money sidebar: the account name becomes "Che…" next to a 15-character balance (money@1440-light). The name gets priority; the balance can drop to a compact form or wrap below per HIG. 2. Register: a zero amount renders two empty cells with no €0.00 (money-accounts@1440-light). A zero transaction must show €0.00 in the column it belongs to. 3. Phone page titles truncate to 4–6 letters ("Hous…") while space remains (money@390-light). 4. Money empty budget: focus lands on the second field, and the button sits under the first. Money rule: every change gets an extra number review (property tests for any amount formatting change).
Author
Owner

Branch worktree-agent-a95dff277c3953cb2, commit b5edceb46 (not pushed).

  1. Sidebar: the name keeps its line. A balance that cannot share it drops under the name, right-aligned (MoneySidebar.svelte, scoped CSS).
  2. Register: zero shows its exact zero in the Inflow column, in muted ink (not green). Property tests (fast-check) in register-display.test.ts cover zero, -0, tiny and huge amounts, both columns, 7 locales and 4 scales, and the parse round trip.
  3. NOT fixed. The phone title slot is 127 px wide because the header row gives the rest to the sidebar toggle, the month switcher and the copy and more pills. That layout is in ModeHeader (packages/ui). Option for the owner: on phones move the month switcher into the month caption row, which frees about 64 px for the title.
  4. Empty budget form: the Group field takes focus first (the first empty field). The action is centred under the fields in the centred empty state.

Gates: bun run check exit 0; bun run test 323 files, 2354 tests passed; perf-lint re-pinned, ratchet.json unchanged.

Branch worktree-agent-a95dff277c3953cb2, commit b5edceb46 (not pushed). 1. Sidebar: the name keeps its line. A balance that cannot share it drops under the name, right-aligned (MoneySidebar.svelte, scoped CSS). 2. Register: zero shows its exact zero in the Inflow column, in muted ink (not green). Property tests (fast-check) in register-display.test.ts cover zero, -0, tiny and huge amounts, both columns, 7 locales and 4 scales, and the parse round trip. 3. NOT fixed. The phone title slot is 127 px wide because the header row gives the rest to the sidebar toggle, the month switcher and the copy and more pills. That layout is in ModeHeader (packages/ui). Option for the owner: on phones move the month switcher into the month caption row, which frees about 64 px for the title. 4. Empty budget form: the Group field takes focus first (the first empty field). The action is centred under the fields in the centred empty state. Gates: bun run check exit 0; bun run test 323 files, 2354 tests passed; perf-lint re-pinned, ratchet.json unchanged.
Author
Owner

Deployed to calternal.cloud as build e02566532 (fast lane, 19:11 IST). Item 3 (phone title width) moved to #1611 (ModeHeader owner).

Deployed to calternal.cloud as build e02566532 (fast lane, 19:11 IST). Item 3 (phone title width) moved to #1611 (ModeHeader owner).
kayg closed this issue 2026-10-12 13:41:36 +00:00
Commenting is not possible because the repository is archived.
No labels
No milestone
No project
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kayg/calternal-v0#1613
No description provided.