E2E theme unit fixtures lack the current User storage seam #1006

Closed
opened 2026-10-03 10:40:13 +00:00 by kayg · 2 comments
Owner

Found while preparing #981 screenshots at head a79564495.

node --test apps/web/e2e/harness.test.mjs reports:

# tests 9
# pass 2
# fail 7

The new #981 mounted-frame regression passes. Seven existing tests fail with ReferenceError: window is not defined in the unchanged assertRenderedTheme reads. The existing themePage VM fixture defines localStorage, but the current helper reads window.__userStorageTest after the tagged User storage change. The same mismatch is present in origin/dev; #981 only changes the mounted-frame selector and adds a separate test.

Update the VM storage fixture to the current seam without relaxing the Auto/System preference, rendered phase or server preference assertions. #981 leaves the existing fixtures/expectations unchanged under the owner rule. This is a test-fixture maintenance issue, not evidence of a production theme failure.

Found while preparing #981 screenshots at head a79564495. `node --test apps/web/e2e/harness.test.mjs` reports: ``` # tests 9 # pass 2 # fail 7 ``` The new #981 mounted-frame regression passes. Seven existing tests fail with `ReferenceError: window is not defined` in the unchanged `assertRenderedTheme` reads. The existing `themePage` VM fixture defines localStorage, but the current helper reads `window.__userStorageTest` after the tagged User storage change. The same mismatch is present in origin/dev; #981 only changes the mounted-frame selector and adds a separate test. Update the VM storage fixture to the current seam without relaxing the Auto/System preference, rendered phase or server preference assertions. #981 leaves the existing fixtures/expectations unchanged under the owner rule. This is a test-fixture maintenance issue, not evidence of a production theme failure.
Author
Owner

Duplicate of existing #958. The title appeared in the search result, but issue creation ran before I applied that result. Keep the maintenance work on #958. The #981 finding adds current evidence: seven existing VM fixture failures and a passing new mounted-frame regression. No existing assertion or fixture was relaxed.

Duplicate of existing #958. The title appeared in the search result, but issue creation ran before I applied that result. Keep the maintenance work on #958. The #981 finding adds current evidence: seven existing VM fixture failures and a passing new mounted-frame regression. No existing assertion or fixture was relaxed.
Author
Owner

Duplicate of #958. Both reports identify the same apps/web/e2e/harness.test.mjs themePage fixture: it provides localStorage but no window.__userStorageTest, while assertRenderedTheme reads that shared User storage seam. I verified the current origin/dev source still has this mismatch; keep the fixture update and unchanged assertions tracked on #958.

Duplicate of #958. Both reports identify the same apps/web/e2e/harness.test.mjs themePage fixture: it provides localStorage but no window.__userStorageTest, while assertRenderedTheme reads that shared User storage seam. I verified the current origin/dev source still has this mismatch; keep the fixture update and unchanged assertions tracked on #958.
kayg closed this issue 2026-10-03 12:42:46 +00:00
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kayg/calternal#1006
No description provided.