Server migration-order review rejects later Mail migrations #1024

Open
opened 2026-10-03 18:06:04 +00:00 by kayg · 0 comments
Owner

The independent-review helper in crates/calternal-server/src/integrations_review.rs:88 asserts that the last Mail migration version is 9. #726 adds Mail migrations 10–12. Both migration-order tests stop at this assertion before they check the unchanged 0009 SQL or account preservation.

On job/mailhtml-726 at dd5d68ae0, cargo test -p calternal-server -- --test-threads=4 returns:

test result: FAILED. 163 passed; 2 failed; 5 ignored; 0 measured; 0 filtered out; finished in 21.10s

The failed tests are mail_626_and_connected_accounts_apply_in_both_orders and populated_0012_and_mail_0009_preserve_links_in_both_orders. Both report left 12, right 9.

Keep the migration-0009 SQL comparison, both upgrade orders, credential/cache preservation and idempotency checks. The orchestrator must decide how the version assertion should support later Mail migrations. This job left the test expectation unchanged under the owner rule.

The independent-review helper in `crates/calternal-server/src/integrations_review.rs:88` asserts that the last Mail migration version is 9. #726 adds Mail migrations 10–12. Both migration-order tests stop at this assertion before they check the unchanged 0009 SQL or account preservation. On `job/mailhtml-726` at `dd5d68ae0`, `cargo test -p calternal-server -- --test-threads=4` returns: ``` test result: FAILED. 163 passed; 2 failed; 5 ignored; 0 measured; 0 filtered out; finished in 21.10s ``` The failed tests are `mail_626_and_connected_accounts_apply_in_both_orders` and `populated_0012_and_mail_0009_preserve_links_in_both_orders`. Both report left 12, right 9. Keep the migration-0009 SQL comparison, both upgrade orders, credential/cache preservation and idempotency checks. The orchestrator must decide how the version assertion should support later Mail migrations. This job left the test expectation unchanged under the owner rule.
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kayg/calternal#1024
No description provided.