kayg/calternal

Watch

Fork 0

Merge gate: agree on the thumbnail launcher retry message (#988/#1045) #1080

New issue

Open

opened 2026-10-05 02:45:20 +00:00 by kayg · 4 comments

kayg commented

2026-10-05 02:45:20 +00:00

Owner

Found in merge-round-7c4 (#867), after production origin/dev 2b6c77c14 was merged with job/merge-round-7c.

The original tests in crates/plugins/files/src/media.rs disagree about the public retry error for the same launcher failure category. The #988 test retry_message_keeps_diagnostics_out_of_user_jobs expects Err("Thumbnails are temporarily unavailable"). The #1045 tests document_launcher_failure_is_retryable_and_private and document_launcher_spawn_failure_is_retryable expect Err("thumbnail runtime unavailable").

The merge preserves the #988 plain-language message, the shared bounded runner, private diagnostics and #1045 retry behavior. All original assertions remain. Changing an existing expectation requires an explicit behavior decision under the owner rule.

Command: OPENSSL_NO_VENDOR=1 CARGO_PROFILE_DEV_DEBUG=line-tables-only CARGO_INCREMENTAL=0 CARGO_BUILD_JOBS=4 cargo test -p calternal-plugin-files -- --test-threads=4.

Verbatim result:

assertion `left == right` failed
  left: Err("Thumbnails are temporarily unavailable")
 right: Err("thumbnail runtime unavailable")

test result: FAILED. 248 passed; 2 failed; 4 ignored; 0 measured; 0 filtered out; finished in 160.57s

Resolve the intended public error contract and update the affected assertions explicitly. This fails the requested gate, so round 7c4 is not ready for staging. The existing #1045 is closed; this issue records the unresolved merge conflict separately.

Found in merge-round-7c4 (#867), after production origin/dev 2b6c77c14 was merged with job/merge-round-7c. The original tests in crates/plugins/files/src/media.rs disagree about the public retry error for the same launcher failure category. The #988 test `retry_message_keeps_diagnostics_out_of_user_jobs` expects `Err("Thumbnails are temporarily unavailable")`. The #1045 tests `document_launcher_failure_is_retryable_and_private` and `document_launcher_spawn_failure_is_retryable` expect `Err("thumbnail runtime unavailable")`. The merge preserves the #988 plain-language message, the shared bounded runner, private diagnostics and #1045 retry behavior. All original assertions remain. Changing an existing expectation requires an explicit behavior decision under the owner rule. Command: `OPENSSL_NO_VENDOR=1 CARGO_PROFILE_DEV_DEBUG=line-tables-only CARGO_INCREMENTAL=0 CARGO_BUILD_JOBS=4 cargo test -p calternal-plugin-files -- --test-threads=4`. Verbatim result: ``` assertion `left == right` failed left: Err("Thumbnails are temporarily unavailable") right: Err("thumbnail runtime unavailable") test result: FAILED. 248 passed; 2 failed; 4 ignored; 0 measured; 0 filtered out; finished in 160.57s ``` Resolve the intended public error contract and update the affected assertions explicitly. This fails the requested gate, so round 7c4 is not ready for staging. The existing #1045 is closed; this issue records the unresolved merge conflict separately.

kayg referenced this issue

2026-10-05 03:10:23 +00:00

Plan: merge order and conflicts for merge round 7b #867

kayg commented

2026-10-05 03:13:35 +00:00

Author

Owner

Orchestrator decision (owner rule: user-friendly names, no jargon in UI): the public retry error for a thumbnail launcher failure is "Thumbnails are temporarily unavailable". Internal diagnostics stay private. Update the #1045 assertion that expects "thumbnail runtime unavailable" to the plain message; keep its retry-behaviour checks.

Orchestrator decision (owner rule: user-friendly names, no jargon in UI): the public retry error for a thumbnail launcher failure is **"Thumbnails are temporarily unavailable"**. Internal diagnostics stay private. Update the #1045 assertion that expects "thumbnail runtime unavailable" to the plain message; keep its retry-behaviour checks.

kayg commented

2026-10-05 03:22:27 +00:00

Author

Owner

Applied the authorized public contract in b6b67590d: both #1045 launcher assertions now expect Thumbnails are temporarily unavailable. Retry and private-diagnostic checks are retained. Files gates are pending the merged server build.

Applied the authorized public contract in b6b67590d: both #1045 launcher assertions now expect Thumbnails are temporarily unavailable. Retry and private-diagnostic checks are retained. Files gates are pending the merged server build.

kayg referenced this issue from a commit

2026-10-05 03:22:50 +00:00

test(files): align launcher retry message with owner decision #1080

kayg commented

2026-10-05 03:58:59 +00:00

Author

Owner

Round 7c5 follows the owner decision. The #1045 Files launcher tests now expect Thumbnails are temporarily unavailable. Retry, recovery and launcher-detail privacy checks remain in place. No status or retry expectation changed.

Commit: b6b67590d. Current branch: job/merge-round-7c, head 433c3bce9.

Files gates:

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 4m 30s

test result: ok. 251 passed; 0 failed; 4 ignored; 0 measured; 0 filtered out; finished in 349.84s
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

The Files clippy command exited 0. The merge round is still running its remaining gates. No push or deploy.

Round 7c5 follows the owner decision. The #1045 Files launcher tests now expect `Thumbnails are temporarily unavailable`. Retry, recovery and launcher-detail privacy checks remain in place. No status or retry expectation changed. Commit: b6b67590d. Current branch: job/merge-round-7c, head 433c3bce9. Files gates: ``` Finished `dev` profile [unoptimized + debuginfo] target(s) in 4m 30s ``` ``` test result: ok. 251 passed; 0 failed; 4 ignored; 0 measured; 0 filtered out; finished in 349.84s test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s ``` The Files clippy command exited 0. The merge round is still running its remaining gates. No push or deploy.

kayg referenced this issue

2026-10-05 04:49:58 +00:00

Plan: merge order and conflicts for merge round 7b #867

kayg commented

2026-10-05 04:49:59 +00:00

Author

Owner

Round 7c5 is complete at df92d4da12 (job/merge-round-7c).

The #1045 assertions use the owner decision: Thumbnails are temporarily unavailable. Retry, recovery and private-diagnostic checks remain intact. Files is green:

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 4m 30s

test result: ok. 251 passed; 0 failed; 4 ignored; 0 measured; 0 filtered out; finished in 349.84s
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

The full report and screenshot evidence are on #867. All requested final gates, Canvas flows and the Notes idle probe passed. READY FOR STAGING: yes. No push or deploy.

Round 7c5 is complete at df92d4da129bfead879d417aef6e0514fc56ee96 (job/merge-round-7c). The #1045 assertions use the owner decision: `Thumbnails are temporarily unavailable`. Retry, recovery and private-diagnostic checks remain intact. Files is green: ``` Finished `dev` profile [unoptimized + debuginfo] target(s) in 4m 30s ``` ``` test result: ok. 251 passed; 0 failed; 4 ignored; 0 measured; 0 filtered out; finished in 349.84s test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s ``` The full report and screenshot evidence are on #867. All requested final gates, Canvas flows and the Notes idle probe passed. READY FOR STAGING: yes. No push or deploy.

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

kayg/calternal#1080

No description provided.

Rows
Columns