Money import: avoid false temporary-copy cleanup warning after a rejected archive #1174

Open
opened 2026-10-06 03:41:10 +00:00 by kayg · 0 comments
Owner

Found in the real production wizard walkthrough for #1140 on head f9684b7b7. After a completed import, notification Undo and empty Budget creation, select a corrupt ZIP containing only PK unreadable fixture and Continue. The parser failure screen shows its plain export error followed by "The temporary copy could not be removed." The Files API returns GET 404 file not found during this sequence. Explicit Cancel then completes and returns to Money; no Budget is created, no crash or 5xx was seen.

Evidence: fresh failure-light-390.png and the full six-case walkthrough log will be attached to #1140 with capture times. This is an odd-but-harmless cleanup message, not a merge blocker under the owner rule. Investigate why MoneyImportSession.#trashStagedUpload reports failed cleanup although a missing file should count as removed; keep transient cleanup diagnostics out of the everyday flow. Add a regression using the real missing-file API response. Do not weaken cancellation or storage cleanup.

Found in the real production wizard walkthrough for #1140 on head f9684b7b7. After a completed import, notification Undo and empty Budget creation, select a corrupt ZIP containing only `PK unreadable fixture` and Continue. The parser failure screen shows its plain export error followed by "The temporary copy could not be removed." The Files API returns GET 404 `file not found` during this sequence. Explicit Cancel then completes and returns to Money; no Budget is created, no crash or 5xx was seen. Evidence: fresh `failure-light-390.png` and the full six-case walkthrough log will be attached to #1140 with capture times. This is an odd-but-harmless cleanup message, not a merge blocker under the owner rule. Investigate why `MoneyImportSession.#trashStagedUpload` reports failed cleanup although a missing file should count as removed; keep transient cleanup diagnostics out of the everyday flow. Add a regression using the real missing-file API response. Do not weaken cancellation or storage cleanup.
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kayg/calternal#1174
No description provided.