Logs: 'WebDAV upload stage' is logged for every file change, not only WebDAV #1204

Open
opened 2026-10-06 13:52:24 +00:00 by kayg · 0 comments
Owner

Misleading profiling log (found 2026-10-06 while diagnosing #1197)

crates/plugins/files/src/uploads.rs::profile_stage logs target: "calternal_webdav::profile", message "WebDAV upload stage", for every Files change-event publish (publish_inner in crates/plugins/files/src/lib.rs: change_event_commit, sse_wakeup_signal, search_enqueue, semantic_search_enqueue) — including Note saves from the app, server writers and uploads that never touched WebDAV. On production this (a) sends investigators down the wrong path ("an external WebDAV client wrote the file") and (b) logs several INFO lines per save.

Do: name the stages for what they are (target calternal_files::change_publish, message "file change publish stage", plus the writer origin: app, webdav, server writer, upload), and emit them at DEBUG (or only when an explicit profiling setting is on) instead of INFO. Keep the bench/profile tooling that consumes them working (update its filter). Tests for the origin label. Gates per crate quoted. Do not push.

## Misleading profiling log (found 2026-10-06 while diagnosing #1197) `crates/plugins/files/src/uploads.rs::profile_stage` logs `target: "calternal_webdav::profile"`, message "WebDAV upload stage", for every Files change-event publish (`publish_inner` in crates/plugins/files/src/lib.rs: change_event_commit, sse_wakeup_signal, search_enqueue, semantic_search_enqueue) — including Note saves from the app, server writers and uploads that never touched WebDAV. On production this (a) sends investigators down the wrong path ("an external WebDAV client wrote the file") and (b) logs several INFO lines per save. Do: name the stages for what they are (target `calternal_files::change_publish`, message "file change publish stage", plus the writer origin: app, webdav, server writer, upload), and emit them at DEBUG (or only when an explicit profiling setting is on) instead of INFO. Keep the bench/profile tooling that consumes them working (update its filter). Tests for the origin label. Gates per crate quoted. Do not push.
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kayg/calternal#1204
No description provided.