kayg/calternal
Watch
1
0
Fork
You've already forked calternal
 0
Code Issues 803 Pull requests Projects Releases Packages Wiki Activity Actions 430

Files: names with ZWJ/ZWNJ are refused (emoji sequences, Persian words), and the upload toast gives no reason #142

New issue
Closed
opened 2026-09-25 23:17:31 +00:00 by kayg · 30 comments
kayg commented 2026-09-25 23:17:31 +00:00
Owner
Copy link

Severity: medium (common emoji and Persian/Indic names cannot be stored; the UI does not say why)

Problem

calternal_fs::normalize_new_name refuses U+200B–U+200D and U+FEFF. That blocks:

  • every emoji ZWJ sequence: family 👩‍👩‍👧‍👦 flag 🏳️‍🌈.md, 👩‍💻 notes.md, ❤️‍🔥.jpg (400 on upload, mkdir and rename);
  • ZWNJ (U+200C), which Persian, Urdu and Indic writing need inside words (نامه‌ای.txt);
  • files from a phone or a Mac that already have such names (sync, the importer).

The Files UI then shows only "2 of 2 could not upload" with a Retry button (/home/kayg/Developer/calternal/target/breakit/upload-refused-name-final_1440.png): no reason, and Retry fails the same way.

Repro

Upload a file named 👩‍💻.md in Files.

Expected

  1. Allow ZWJ between emoji (Extended_Pictographic on both sides) and ZWNJ/ZWJ after a letter of a joining script; keep refusing U+200B, U+FEFF and a leading or trailing joiner (the spoofing cases the rule was made for). The same rule must hold in calternald (sync collisions).
  2. A refused name shows its reason in the upload toast ("This name has a character that is not allowed: U+200D") and Retry is not offered for a 400.

Owner: calternal-fs (security-sensitive name policy), so not changed here.

Found by the break-it sweep (#117). Re-run: cd apps/web && bun run build && bun e2e/breakit.mjs --keep <dir> (script on branch job/breakit-fixes). Screenshots: /home/kayg/Developer/calternal/target/breakit (run 1 in run1/, fix checks in verify/).

**Severity:** medium (common emoji and Persian/Indic names cannot be stored; the UI does not say why) ## Problem `calternal_fs::normalize_new_name` refuses U+200B–U+200D and U+FEFF. That blocks: - every emoji ZWJ sequence: `family 👩‍👩‍👧‍👦 flag 🏳️‍🌈.md`, `👩‍💻 notes.md`, `❤️‍🔥.jpg` (400 on upload, mkdir and rename); - ZWNJ (U+200C), which Persian, Urdu and Indic writing need inside words (`نامه‌ای.txt`); - files from a phone or a Mac that already have such names (sync, the importer). The Files UI then shows only **"2 of 2 could not upload"** with a **Retry** button (`/home/kayg/Developer/calternal/target/breakit/upload-refused-name-final_1440.png`): no reason, and Retry fails the same way. ## Repro Upload a file named `👩‍💻.md` in Files. ## Expected 1. Allow ZWJ between emoji (Extended_Pictographic on both sides) and ZWNJ/ZWJ after a letter of a joining script; keep refusing U+200B, U+FEFF and a leading or trailing joiner (the spoofing cases the rule was made for). The same rule must hold in `calternald` (sync collisions). 2. A refused name shows its reason in the upload toast ("This name has a character that is not allowed: U+200D") and Retry is not offered for a 400. Owner: calternal-fs (security-sensitive name policy), so not changed here. Found by the break-it sweep (#117). Re-run: `cd apps/web && bun run build && bun e2e/breakit.mjs --keep <dir>` (script on branch `job/breakit-fixes`). Screenshots: `/home/kayg/Developer/calternal/target/breakit` (run 1 in `run1/`, fix checks in `verify/`).
files-filenames-row-01-phone-light.png
143 KiB
files-filenames-desktop-dark.png
4.3 MiB
files-filenames-desktop-light.png
4.7 MiB
files-filenames-phone-dark.png
1.7 MiB
files-filenames-row-01-desktop-dark.png
194 KiB
files-filenames-row-01-desktop-light.png
200 KiB
files-filenames-row-01-phone-dark.png
139 KiB
files-filenames-row-01-tablet-dark.png
100 KiB
files-filenames-row-01-tablet-light.png
104 KiB
files-filenames-row-02-desktop-dark.png
185 KiB
files-filenames-row-02-desktop-light.png
197 KiB
files-filenames-row-02-phone-dark.png
132 KiB
files-filenames-row-02-phone-light.png
141 KiB
files-filenames-row-02-tablet-dark.png
100 KiB
files-filenames-row-02-tablet-light.png
106 KiB
files-filenames-row-03-desktop-dark.png
191 KiB
files-filenames-row-03-desktop-light.png
199 KiB
files-filenames-row-03-phone-dark.png
146 KiB
files-filenames-row-03-phone-light.png
152 KiB
files-filenames-row-03-tablet-dark.png
100 KiB
files-filenames-row-03-tablet-light.png
105 KiB
files-filename-zoom-phone-dark-cjk.png
108 KiB
files-filenames-row-04-desktop-dark.png
199 KiB
files-filenames-row-04-desktop-light.png
211 KiB
files-filenames-row-04-phone-dark.png
149 KiB
files-filenames-row-04-phone-light.png
158 KiB
files-filenames-row-04-tablet-dark.png
100 KiB
files-filenames-row-04-tablet-light.png
109 KiB
files-filenames-row-05-desktop-dark.png
211 KiB
files-filenames-row-05-desktop-light.png
223 KiB
files-filenames-row-05-phone-dark.png
157 KiB
files-filenames-row-05-phone-light.png
167 KiB
files-filenames-row-05-tablet-dark.png
113 KiB
files-filenames-row-05-tablet-light.png
118 KiB
files-filenames-tablet-dark.png
2.6 MiB
files-filenames-tablet-light.png
2.8 MiB
files-filename-zoom-desktop-dark-cjk.png
60 KiB
files-filename-zoom-desktop-dark-long.png
49 KiB
files-filename-zoom-desktop-dark-rtl.png
62 KiB
files-filename-zoom-desktop-light-cjk.png
61 KiB
files-filename-zoom-desktop-light-long.png
51 KiB
files-filename-zoom-desktop-light-rtl.png
59 KiB
files-filename-zoom-phone-dark-long.png
92 KiB
files-filename-zoom-phone-dark-rtl.png
104 KiB
files-filename-zoom-phone-light-cjk.png
112 KiB
files-filename-zoom-phone-light-long.png
94 KiB
files-filename-zoom-phone-light-rtl.png
107 KiB
files-filename-zoom-tablet-dark-cjk.png
24 KiB
files-filename-zoom-tablet-dark-long.png
20 KiB
files-filename-zoom-tablet-dark-rtl.png
21 KiB
files-filename-zoom-tablet-light-cjk.png
24 KiB
files-filename-zoom-tablet-light-long.png
20 KiB
files-filename-zoom-tablet-light-rtl.png
22 KiB
files-filenames-phone-light.png
1.9 MiB
files-filenames-phone-light.png
1.9 MiB
files-filenames-phone-dark.png
1.7 MiB
files-filenames-tablet-light.png
2.8 MiB
files-filenames-tablet-dark.png
2.6 MiB
files-filenames-desktop-light.png
4.7 MiB
files-filenames-desktop-dark.png
4.3 MiB
files-filenames-rows-01-02-phone-light.png
345 KiB
files-filenames-rows-01-02-phone-dark.png
326 KiB
files-filenames-rows-01-02-tablet-light.png
204 KiB
files-filenames-rows-01-02-tablet-dark.png
196 KiB
files-filenames-rows-01-02-desktop-light.png
390 KiB
files-filenames-rows-01-02-desktop-dark.png
372 KiB
files-filenames-row-01-phone-light.png files-filenames-desktop-dark.png files-filenames-desktop-light.png files-filenames-phone-dark.png files-filenames-row-01-desktop-dark.png files-filenames-row-01-desktop-light.png files-filenames-row-01-phone-dark.png files-filenames-row-01-tablet-dark.png files-filenames-row-01-tablet-light.png files-filenames-row-02-desktop-dark.png files-filenames-row-02-desktop-light.png files-filenames-row-02-phone-dark.png files-filenames-row-02-phone-light.png files-filenames-row-02-tablet-dark.png files-filenames-row-02-tablet-light.png files-filenames-row-03-desktop-dark.png files-filenames-row-03-desktop-light.png files-filenames-row-03-phone-dark.png files-filenames-row-03-phone-light.png files-filenames-row-03-tablet-dark.png files-filenames-row-03-tablet-light.png files-filename-zoom-phone-dark-cjk.png files-filenames-row-04-desktop-dark.png files-filenames-row-04-desktop-light.png files-filenames-row-04-phone-dark.png files-filenames-row-04-phone-light.png files-filenames-row-04-tablet-dark.png files-filenames-row-04-tablet-light.png files-filenames-row-05-desktop-dark.png files-filenames-row-05-desktop-light.png files-filenames-row-05-phone-dark.png files-filenames-row-05-phone-light.png files-filenames-row-05-tablet-dark.png files-filenames-row-05-tablet-light.png files-filenames-tablet-dark.png files-filenames-tablet-light.png files-filename-zoom-desktop-dark-cjk.png files-filename-zoom-desktop-dark-long.png files-filename-zoom-desktop-dark-rtl.png files-filename-zoom-desktop-light-cjk.png files-filename-zoom-desktop-light-long.png files-filename-zoom-desktop-light-rtl.png files-filename-zoom-phone-dark-long.png files-filename-zoom-phone-dark-rtl.png files-filename-zoom-phone-light-cjk.png files-filename-zoom-phone-light-long.png files-filename-zoom-phone-light-rtl.png files-filename-zoom-tablet-dark-cjk.png files-filename-zoom-tablet-dark-long.png files-filename-zoom-tablet-dark-rtl.png files-filename-zoom-tablet-light-cjk.png files-filename-zoom-tablet-light-long.png files-filename-zoom-tablet-light-rtl.png files-filenames-phone-light.png files-filenames-phone-light.png files-filenames-phone-dark.png files-filenames-tablet-light.png files-filenames-tablet-dark.png files-filenames-desktop-light.png files-filenames-desktop-dark.png files-filenames-rows-01-02-phone-light.png files-filenames-rows-01-02-phone-dark.png files-filenames-rows-01-02-tablet-light.png files-filenames-rows-01-02-tablet-dark.png files-filenames-rows-01-02-desktop-light.png files-filenames-rows-01-02-desktop-dark.png
kayg commented 2026-09-28 18:47:12 +00:00
Author
Owner
Copy link

Starting the small-bugs batch on job/small-bugs, based on fba83527f2cccf2334934bb1fd0932be7c0e209b.

Starting the small-bugs batch on `job/small-bugs`, based on `fba83527f2cccf2334934bb1fd0932be7c0e209b`.
kayg commented 2026-09-28 20:29:08 +00:00
Author
Owner
Copy link

The new storage regression test reproduced the issue: normalize_new_name rejected family emoji, emoji modifier sequences, Persian ZWNJ, and Devanagari virama sequences. The fix now permits join controls only in virama, joining-script, or emoji ZWJ contexts. The focused test passes for those valid names and still rejects standalone, Latin-context, and incomplete joiners.

The new storage regression test reproduced the issue: `normalize_new_name` rejected family emoji, emoji modifier sequences, Persian ZWNJ, and Devanagari virama sequences. The fix now permits join controls only in virama, joining-script, or emoji ZWJ contexts. The focused test passes for those valid names and still rejects standalone, Latin-context, and incomplete joiners.
kayg commented 2026-09-28 22:49:01 +00:00
Author
Owner
Copy link

Focused review finding: normalize_new_name("ب\u{200d}ب.txt") currently accepts ZWJ between Arabic joining letters. The new regression test reproduces this; cargo test -p calternal-fs --test storage new_name_policy_allows_joiners_only_in_writing_sequences fails on that input. Unicode UAX #31 §2.3.1 defines the cursive joining context for ZWNJ, while ZWJ is limited to virama and valid emoji-sequence contexts: https://unicode.org/reports/tr31/tr31-38.html#Limited_Contexts_for_Joining_Controls. I am tightening the check and will rerun the focused test.

Focused review finding: `normalize_new_name("ب\u{200d}ب.txt")` currently accepts ZWJ between Arabic joining letters. The new regression test reproduces this; `cargo test -p calternal-fs --test storage new_name_policy_allows_joiners_only_in_writing_sequences` fails on that input. Unicode UAX #31 §2.3.1 defines the cursive joining context for ZWNJ, while ZWJ is limited to virama and valid emoji-sequence contexts: https://unicode.org/reports/tr31/tr31-38.html#Limited_Contexts_for_Joining_Controls. I am tightening the check and will rerun the focused test.
kayg commented 2026-09-28 22:50:20 +00:00
Author
Owner
Copy link

Follow-up for the join-control review finding: ZWJ now rejects cursive joining contexts. The focused test failed before the fix on ب\u{200d}ب.txt and passes after it; the same test still accepts the Persian ZWNJ, Indic virama, and emoji ZWJ cases.

Verification:

running 1 test
test new_name_policy_allows_joiners_only_in_writing_sequences ... ok
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 40 filtered out; finished in 0.08s

Commit: e2c0f950.

Follow-up for the join-control review finding: ZWJ now rejects cursive joining contexts. The focused test failed before the fix on `ب\u{200d}ب.txt` and passes after it; the same test still accepts the Persian ZWNJ, Indic virama, and emoji ZWJ cases. Verification: ```text running 1 test test new_name_policy_allows_joiners_only_in_writing_sequences ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 40 filtered out; finished in 0.08s ``` Commit: `e2c0f950`.
kayg commented 2026-09-28 22:56:55 +00:00
Author
Owner
Copy link

Integration status: all small-bugs changes are committed through e2c0f950, and the worktree is clean. As of 2026-09-29 00:55 CEST, origin/dev is deb16f61 and does not contain the pushed job/cli-agent retry change (0c38b723) or job/hig-type change (06757bba). I am holding the single required git merge dev until those branches reach dev, so final browser evidence, the API adversarial round, and gates cover the integrated tree.

Integration status: all small-bugs changes are committed through `e2c0f950`, and the worktree is clean. As of 2026-09-29 00:55 CEST, `origin/dev` is `deb16f61` and does not contain the pushed `job/cli-agent` retry change (`0c38b723`) or `job/hig-type` change (`06757bba`). I am holding the single required `git merge dev` until those branches reach `dev`, so final browser evidence, the API adversarial round, and gates cover the integrated tree.
kayg commented 2026-09-28 23:14:39 +00:00
Author
Owner
Copy link

Update at 2026-09-29 01:15 CEST: origin/dev is now b708b258, still without job/cli-agent (0c38b723) or job/hig-type (06757bba). A read-only merge preview of job/cli-agent against dev reports a content conflict in crates/calternal-cli/src/remote_commands.rs; the type-scale branch previews cleanly. I have not changed either job's files. My branch is clean at e2c0f950; final integrated verification remains pending.

Update at 2026-09-29 01:15 CEST: `origin/dev` is now `b708b258`, still without `job/cli-agent` (`0c38b723`) or `job/hig-type` (`06757bba`). A read-only merge preview of `job/cli-agent` against `dev` reports a content conflict in `crates/calternal-cli/src/remote_commands.rs`; the type-scale branch previews cleanly. I have not changed either job's files. My branch is clean at `e2c0f950`; final integrated verification remains pending.
kayg commented 2026-09-28 23:32:54 +00:00
Author
Owner
Copy link

Update at 2026-09-29 01:32 CEST: my branch is clean at 05771f0e0d4f733dba69f1dd9fb2f0257fd87b46. The adversarial runner now has a focused full-API mode so one round can cover #276 and #282/#283 without the larger Search/editor/restart campaigns. Current dev is 5cb977188697c7f1b5dca6d2dd70dc05a6817626; it still does not contain job/cli-agent (0c38b723) or job/hig-type (06757bba). The one required merge preview reports conflicts in Notes plugin startup and the adversarial runner; final integrated verification is pending.

Update at 2026-09-29 01:32 CEST: my branch is clean at `05771f0e0d4f733dba69f1dd9fb2f0257fd87b46`. The adversarial runner now has a focused full-API mode so one round can cover #276 and #282/#283 without the larger Search/editor/restart campaigns. Current `dev` is `5cb977188697c7f1b5dca6d2dd70dc05a6817626`; it still does not contain `job/cli-agent` (`0c38b723`) or `job/hig-type` (`06757bba`). The one required merge preview reports conflicts in Notes plugin startup and the adversarial runner; final integrated verification is pending.
kayg commented 2026-09-28 23:59:52 +00:00
Author
Owner
Copy link

Update at 2026-09-29 01:59 CEST: dev is a9185e89. job/hig-type is now clean after merging dev into itself at 247b1cbf, but that branch is not yet on dev. job/cli-agent is still clean at 3c4caab7, is not on dev, and its merge preview still conflicts only in test imports in crates/calternal-cli/src/remote_commands.rs. My branch remains clean at 05771f0e0d4f733dba69f1dd9fb2f0257fd87b46; the required final merge and verification remain pending.

Update at 2026-09-29 01:59 CEST: `dev` is `a9185e89`. `job/hig-type` is now clean after merging `dev` into itself at `247b1cbf`, but that branch is not yet on `dev`. `job/cli-agent` is still clean at `3c4caab7`, is not on `dev`, and its merge preview still conflicts only in test imports in `crates/calternal-cli/src/remote_commands.rs`. My branch remains clean at `05771f0e0d4f733dba69f1dd9fb2f0257fd87b46`; the required final merge and verification remain pending.
kayg commented 2026-09-29 00:24:57 +00:00
Author
Owner
Copy link

small-bugs #142 report

Built

  • #142 accepts contextual ZWJ/ZWNJ name sequences and rejects misplaced joiners (8579a9f7, e2c0f950).
  • #143 adds the long unbroken Share name regression (f33cd91e).
  • #145 adds a hard horizontal-overflow regression for long Tags on phones (13060ab1).
  • #146 was already fixed on the branch; anonymous_requests_get_401_not_500 passed.
  • #153 improves muted Search contrast and adds responsive assertions (75a0944a).
  • #155 removes the phone viewport width floor and adds 200% zoom overflow coverage (232e9d37).
  • #273 adds 44×44 phone Week header target checks (b1b0492d).
  • #276 adds an adversarial probe that checks role denial before config parsing (3900868a).
  • #282/#283 add proxy and Rust API oversized Appearance probes for 200 KiB and 3 MiB bodies (f1126003, a7b1adda).
  • #214 maps transient Calendar Index create failures to retryable 503 (d53a8f5a).
  • #344 repairs Daily note navigation to existing adjacent days with relative links (8322d304).
  • Added focused full-API adversarial mode (4f552baf, a9e848ec, 05771f0e).
  • Merged dev once at 94f1cfd5; resolved Notes imports and preserved both API-only and note-byte-stability adversarial modes (868a0eb1).

Files

Cargo.lock; apps/web/e2e/{breakit,layout-sweep,share}.mjs; apps/web/src/lib/components/search-dialog.svelte; apps/web/src/lib/search/{PhotoGrid,SearchField,SearchPreview,SearchResultRow}.svelte; apps/web/src/routes/layout.css; crates/calternal-fs/{Cargo.toml,src/path.rs,tests/storage.rs}; crates/calternal-notes-core/{src/dayfile.rs,src/lib.rs,tests/vectors/dayfile.json}; crates/plugins/calendar/src/routes.rs; crates/plugins/notes/{migrations/0016_daily_note_navigation.sql,src/lib.rs,src/store.rs}; tests/adversarial/{attack.py,editor-proxy.mjs,run.sh}. The dev merge also integrates files from other jobs.

Head SHA

868a0eb10a7400e1f034c6eb12a28e495c15845f

Verification

Focused Rust regressions passed for #142, #344, #214, #146 and #276. bash -n tests/adversarial/run.sh and git diff --check passed after merge conflict resolution.

  • cargo fmt --check: exit 0, no output.
  • cargo clippy --all-targets -- -D warnings: not run.
  • cargo test: not run.
  • cd apps/web && bun run check output: 
    Loading svelte-check in workspace: /home/kayg/Developer/calternal-wt/small-bugs/apps/web
Getting Svelte diagnostics...

/home/kayg/Developer/calternal-wt/small-bugs/apps/web/src/lib/themes.test.ts:278:21
Error: Object is possibly 'undefined'.
      expect(found, `--layer-${name} defined once`).toHaveLength(1);
      return Number(found[0][1]);
    };

svelte-check found 1 error and 0 warnings in 1 file
error: script "check" exited with code 1
  • cd apps/web && bun run test output: 
     Test Files  117 passed (117)
      Tests  764 passed (764)
   Start at  02:20:50
   Duration  177.31s (transform 54%, environment 19%, import 14%, tests 9%, setup 3%)
  • Production screenshots and the API adversarial round: not run.

Known gaps

The job/cli-agent retry change (0c38b723) and job/hig-type change (06757bba) were not on dev when it was merged at 94f1cfd5. #348 is therefore not implemented or regression-tested in this branch. The production screenshots and the focused API adversarial round remain pending. Full Rust gates remain pending. The web check failure is in a file supplied by the merged dev tree and outside this issue batch.

Decisions not covered by DESIGN.md

  • Join controls are accepted only in contextual writing or emoji sequences; ZWJ cursive joining is rejected while ZWNJ cursive joining remains allowed, following Unicode UAX #31 §2.3.1.
  • Daily note navigation links only to existing adjacent days; a one-time Notes migration repairs stored links through Replace to retain versions.
  • Search muted text uses a 70% muted / 30% ink blend. SearchPreview gets an explicit token because it is portalled outside .sw.
  • Removing the 320 CSS-pixel minimum lets the Files page reflow at 160/195 CSS-pixel widths under 200% phone zoom.
  • The editor proxy's Appearance Expect: 100-continue threshold matches the Rust route's 64 KiB body limit.

Local OpenSSL verification used system OpenSSL through OPENSSL_NO_VENDOR=1; this does not change product configuration.

# small-bugs #142 report ## Built - #142 accepts contextual ZWJ/ZWNJ name sequences and rejects misplaced joiners (`8579a9f7`, `e2c0f950`). - #143 adds the long unbroken Share name regression (`f33cd91e`). - #145 adds a hard horizontal-overflow regression for long Tags on phones (`13060ab1`). - #146 was already fixed on the branch; `anonymous_requests_get_401_not_500` passed. - #153 improves muted Search contrast and adds responsive assertions (`75a0944a`). - #155 removes the phone viewport width floor and adds 200% zoom overflow coverage (`232e9d37`). - #273 adds 44×44 phone Week header target checks (`b1b0492d`). - #276 adds an adversarial probe that checks role denial before config parsing (`3900868a`). - #282/#283 add proxy and Rust API oversized Appearance probes for 200 KiB and 3 MiB bodies (`f1126003`, `a7b1adda`). - #214 maps transient Calendar Index create failures to retryable 503 (`d53a8f5a`). - #344 repairs Daily note navigation to existing adjacent days with relative links (`8322d304`). - Added focused full-API adversarial mode (`4f552baf`, `a9e848ec`, `05771f0e`). - Merged `dev` once at `94f1cfd5`; resolved Notes imports and preserved both API-only and note-byte-stability adversarial modes (`868a0eb1`). ## Files `Cargo.lock`; `apps/web/e2e/{breakit,layout-sweep,share}.mjs`; `apps/web/src/lib/components/search-dialog.svelte`; `apps/web/src/lib/search/{PhotoGrid,SearchField,SearchPreview,SearchResultRow}.svelte`; `apps/web/src/routes/layout.css`; `crates/calternal-fs/{Cargo.toml,src/path.rs,tests/storage.rs}`; `crates/calternal-notes-core/{src/dayfile.rs,src/lib.rs,tests/vectors/dayfile.json}`; `crates/plugins/calendar/src/routes.rs`; `crates/plugins/notes/{migrations/0016_daily_note_navigation.sql,src/lib.rs,src/store.rs}`; `tests/adversarial/{attack.py,editor-proxy.mjs,run.sh}`. The `dev` merge also integrates files from other jobs. ## Head SHA `868a0eb10a7400e1f034c6eb12a28e495c15845f` ## Verification Focused Rust regressions passed for #142, #344, #214, #146 and #276. `bash -n tests/adversarial/run.sh` and `git diff --check` passed after merge conflict resolution. - `cargo fmt --check`: exit 0, no output. - `cargo clippy --all-targets -- -D warnings`: not run. - `cargo test`: not run. - `cd apps/web && bun run check` output: ```text Loading svelte-check in workspace: /home/kayg/Developer/calternal-wt/small-bugs/apps/web Getting Svelte diagnostics... /home/kayg/Developer/calternal-wt/small-bugs/apps/web/src/lib/themes.test.ts:278:21 Error: Object is possibly 'undefined'. expect(found, `--layer-${name} defined once`).toHaveLength(1); return Number(found[0][1]); }; svelte-check found 1 error and 0 warnings in 1 file error: script "check" exited with code 1 ``` - `cd apps/web && bun run test` output: ```text Test Files 117 passed (117) Tests 764 passed (764) Start at 02:20:50 Duration 177.31s (transform 54%, environment 19%, import 14%, tests 9%, setup 3%) ``` - Production screenshots and the API adversarial round: not run. ## Known gaps The `job/cli-agent` retry change (`0c38b723`) and `job/hig-type` change (`06757bba`) were not on `dev` when it was merged at `94f1cfd5`. #348 is therefore not implemented or regression-tested in this branch. The production screenshots and the focused API adversarial round remain pending. Full Rust gates remain pending. The web check failure is in a file supplied by the merged `dev` tree and outside this issue batch. ## Decisions not covered by DESIGN.md - Join controls are accepted only in contextual writing or emoji sequences; ZWJ cursive joining is rejected while ZWNJ cursive joining remains allowed, following [Unicode UAX #31 §2.3.1](https://unicode.org/reports/tr31/tr31-38.html#Limited_Contexts_for_Joining_Controls). - Daily note navigation links only to existing adjacent days; a one-time Notes migration repairs stored links through Replace to retain versions. - Search muted text uses a 70% muted / 30% ink blend. SearchPreview gets an explicit token because it is portalled outside `.sw`. - Removing the 320 CSS-pixel minimum lets the Files page reflow at 160/195 CSS-pixel widths under 200% phone zoom. - The editor proxy's Appearance `Expect: 100-continue` threshold matches the Rust route's 64 KiB body limit. Local OpenSSL verification used system OpenSSL through `OPENSSL_NO_VENDOR=1`; this does not change product configuration.
kayg commented 2026-09-29 02:39:54 +00:00
Author
Owner
Copy link

Claude: small-bugs merge REVERTED on dev (43a69592) — startup-recovery bug

crates/plugins/notes test tests::retitle_replays_after_each_persisted_step fails after the merge with a 500 from recover(). Cause: commit 8322d304 ("Repair relative navigation between Daily notes") adds migrate_daily_note_navigation to recover(), and it runs SELECT id FROM users against the Notes database. The users table belongs to the auth store, not to notes.sqlite; in the test (and on any instance where the Notes DB is separate) this errors, and recover() fails at startup. A plugin must not read another crate's tables.

Fix:

  1. Enumerate Users from the Home directories through calternal-fs (the way the Notes reconcile already does) or from the Notes plugin's own tables, never from auth's users table.
  2. The migration must never fail startup: log and retry later on error; mark done per User.
  3. Run the whole cargo test -p calternal-plugin-notes suite (it was not run) plus the focused regressions; quote verbatim.
  4. Because the merge was reverted on dev, re-merging the same commits will not bring them back. Make a new branch job/small-bugs-2 from current dev, git cherry-pick your non-merge commits from job/small-bugs (in order), fix the migration there, run the gates, and push job/small-bugs-2. Also include #348 now (the CLI retry change is on dev).
## Claude: small-bugs merge REVERTED on dev (43a69592) — startup-recovery bug `crates/plugins/notes` test `tests::retitle_replays_after_each_persisted_step` fails after the merge with a 500 from `recover()`. Cause: commit 8322d304 ("Repair relative navigation between Daily notes") adds `migrate_daily_note_navigation` to `recover()`, and it runs `SELECT id FROM users` against the **Notes** database. The `users` table belongs to the auth store, not to `notes.sqlite`; in the test (and on any instance where the Notes DB is separate) this errors, and `recover()` fails at startup. A plugin must not read another crate's tables. Fix: 1. Enumerate Users from the Home directories through calternal-fs (the way the Notes reconcile already does) or from the Notes plugin's own tables, never from auth's `users` table. 2. The migration must never fail startup: log and retry later on error; mark done per User. 3. Run the **whole** `cargo test -p calternal-plugin-notes` suite (it was not run) plus the focused regressions; quote verbatim. 4. Because the merge was reverted on dev, re-merging the same commits will not bring them back. Make a new branch `job/small-bugs-2` from current dev, `git cherry-pick` your non-merge commits from job/small-bugs (in order), fix the migration there, run the gates, and push `job/small-bugs-2`. Also include #348 now (the CLI retry change is on dev).
kayg commented 2026-09-29 02:41:52 +00:00
Author
Owner
Copy link

Starting the rework on job/small-bugs-2, based on 43a69592b70254825fb9b82092f1b883ba65fc3a (dev). I will cherry-pick the listed non-merge commits in order, make the Daily note migration enumerate Homes and complete per User without failing startup, add #348, then run the requested gates.

Starting the rework on `job/small-bugs-2`, based on `43a69592b70254825fb9b82092f1b883ba65fc3a` (`dev`). I will cherry-pick the listed non-merge commits in order, make the Daily note migration enumerate Homes and complete per User without failing startup, add #348, then run the requested gates.
kayg commented 2026-09-29 02:57:28 +00:00
Author
Owner
Copy link

Finding: on the restored branch, cargo test -p calternal-plugin-notes retitle_replays_after_each_persisted_step -- --nocapture fails at recover(&root, &db).await.unwrap() with ApiError(500, ... Internal ...). The Notes test database has no auth users table; migrate_daily_note_navigation queries it and propagates the SQL error through startup recovery.

Finding: on the restored branch, `cargo test -p calternal-plugin-notes retitle_replays_after_each_persisted_step -- --nocapture` fails at `recover(&root, &db).await.unwrap()` with `ApiError(500, ... Internal ...)`. The Notes test database has no auth `users` table; `migrate_daily_note_navigation` queries it and propagates the SQL error through startup recovery.
kayg commented 2026-09-29 03:55:02 +00:00
Author
Owner
Copy link

Finding during the required web check after merging dev: bun run check rejected font-size: var(--text-dense, 0.86rem) in apps/web/src/lib/components/search-dialog.svelte:1317 because the literal bypassed the shared type-token guard. The --text-dense token is defined in packages/ui/src/tokens.css, so I removed the redundant fallback. The rerun passed: svelte-check found 0 errors and 0 warnings. Fix commit: bd3f735a.

Finding during the required web check after merging `dev`: `bun run check` rejected `font-size: var(--text-dense, 0.86rem)` in `apps/web/src/lib/components/search-dialog.svelte:1317` because the literal bypassed the shared type-token guard. The `--text-dense` token is defined in `packages/ui/src/tokens.css`, so I removed the redundant fallback. The rerun passed: `svelte-check found 0 errors and 0 warnings`. Fix commit: `bd3f735a`.
kayg commented 2026-09-29 04:37:19 +00:00
Author
Owner
Copy link

Resume at 2026-09-29 06:35 CEST: branch job/small-bugs-2 is clean at bd3f735a. The earlier work already includes the Home-based per-User Daily note migration, CLI transient 502 retry, the dev merge, and the Search token fix.

The whole cargo test -p calternal-plugin-notes suite passed: 110 passed; 0 failed, including retitle_replays_after_each_persisted_step and both new migration regressions. The focused CLI 502 polling regression passed. cargo fmt --check passed with no output. Running the remaining final gates now.

Resume at 2026-09-29 06:35 CEST: branch `job/small-bugs-2` is clean at `bd3f735a`. The earlier work already includes the Home-based per-User Daily note migration, CLI transient 502 retry, the `dev` merge, and the Search token fix. The whole `cargo test -p calternal-plugin-notes` suite passed: `110 passed; 0 failed`, including `retitle_replays_after_each_persisted_step` and both new migration regressions. The focused CLI 502 polling regression passed. `cargo fmt --check` passed with no output. Running the remaining final gates now.
kayg commented 2026-09-29 04:43:47 +00:00
Author
Owner
Copy link

Finding for #348: the shared send_with_retry helper retries transport errors only for safe HTTP methods. The CLI token poll is a POST, so a dropped connection still ended login, and the helper retried only selected 5xx statuses. I added a bounded retry in the device-login polling loop for transport errors, any 5xx, and 429. The regression now serves a dropped connection, HTTP 500 and HTTP 502 in sequence and checks the retryable failure message after the limit.

Finding for #348: the shared `send_with_retry` helper retries transport errors only for safe HTTP methods. The CLI token poll is a POST, so a dropped connection still ended login, and the helper retried only selected 5xx statuses. I added a bounded retry in the device-login polling loop for transport errors, any 5xx, and 429. The regression now serves a dropped connection, HTTP 500 and HTTP 502 in sequence and checks the retryable failure message after the limit.
kayg commented 2026-09-29 05:11:44 +00:00
Author
Owner
Copy link

Resume at 2026-09-29 07:13 CEST: branch job/small-bugs-2 is clean at 17598901711658e84f83060de4f29dcffbdaf717, which is also on origin/job/small-bugs-2. The Notes suite, focused CLI polling regression, Rust fmt, web check and web unit tests have passed in this worktree. The earlier workspace clippy and Rust test logs stopped mid-build during the restart, so I am running the remaining workspace gates now. The required dev merge already happened once at de14b938; I will not repeat it.

Resume at 2026-09-29 07:13 CEST: branch `job/small-bugs-2` is clean at `17598901711658e84f83060de4f29dcffbdaf717`, which is also on `origin/job/small-bugs-2`. The Notes suite, focused CLI polling regression, Rust fmt, web check and web unit tests have passed in this worktree. The earlier workspace clippy and Rust test logs stopped mid-build during the restart, so I am running the remaining workspace gates now. The required `dev` merge already happened once at `de14b938`; I will not repeat it.
kayg commented 2026-09-29 05:32:33 +00:00
Author
Owner
Copy link

Production browser review finding at 2026-09-29 07:31 CEST: the focused breakit.mjs --quick --only search run saved 48 Search screens and returned 301 automated findings, mainly contrast estimates over translucent glass. For search@320-paper, the probe estimates the section label on RGB(139,142,142) at 2.32:1, but the saved production screenshot has RGB(240,240,242) next to that label (checked from the PNG pixel data with ffmpeg). The probe's comment calls glass contrast an estimate; this specific contrast finding does not prove a real text contrast failure. The run also reports page-hscroll on simulated 200% zoom because Chromium reports a 320px layout viewport for a 160/195px mobile emulation, and expected 5xx in the intentional network-failure campaign. Artifacts remain uncommitted at target/breakit-final/report.json and target/breakit-review/. I will list these limits in the final report; no test expectations were changed.

Production browser review finding at 2026-09-29 07:31 CEST: the focused `breakit.mjs --quick --only search` run saved 48 Search screens and returned 301 automated findings, mainly contrast estimates over translucent glass. For `search@320-paper`, the probe estimates the section label on RGB(139,142,142) at 2.32:1, but the saved production screenshot has RGB(240,240,242) next to that label (checked from the PNG pixel data with ffmpeg). The probe's comment calls glass contrast an estimate; this specific contrast finding does not prove a real text contrast failure. The run also reports page-hscroll on simulated 200% zoom because Chromium reports a 320px layout viewport for a 160/195px mobile emulation, and expected 5xx in the intentional network-failure campaign. Artifacts remain uncommitted at `target/breakit-final/report.json` and `target/breakit-review/`. I will list these limits in the final report; no test expectations were changed.
kayg commented 2026-09-29 05:40:58 +00:00
Author
Owner
Copy link

At 2026-09-29 07:41 CEST the full workspace clippy gate is still compiling under the 4-job cap on the shared host; no diagnostic has appeared. The one time-boxed real-server API adversarial round is in progress. It has found one non-SLOW Appearance 3 MiB response (502 from the local proxy instead of 413), plus a DAV alarm accepted-hostile-input result outside this batch; the remaining reported delays are marked SLOW. I am recording those findings and will give exact final gate results and unresolved items. The branch remains clean at 17598901.

At 2026-09-29 07:41 CEST the full workspace clippy gate is still compiling under the 4-job cap on the shared host; no diagnostic has appeared. The one time-boxed real-server API adversarial round is in progress. It has found one non-SLOW Appearance 3 MiB response (`502` from the local proxy instead of `413`), plus a DAV alarm accepted-hostile-input result outside this batch; the remaining reported delays are marked SLOW. I am recording those findings and will give exact final gate results and unresolved items. The branch remains clean at `17598901`.
kayg commented 2026-09-29 05:55:42 +00:00
Author
Owner
Copy link

Finding for #155 after the production browser review: the original fix removed min-width: 320px from apps/web/src/routes/layout.css, but packages/ui/src/tokens.css still applied the same minimum to html, body. The real Files sweep therefore reported a 320px layout viewport for simulated 160px and 195px CSS widths. A minimal Chromium page at 195px did not clamp, which isolated the remaining floor to shared CSS.

Commit d34e6266 removes the shared floor (small addition outside the prior file set, required by #155). With a rebuilt production app, the existing breakit.mjs --quick --only files-hostile 200% width assertion passed at both 160px and 195px; that focused run exited 0. bun run check reported svelte-check found 0 errors and 0 warnings, and bun run test reported 120 passed (120) files and 782 passed (782) tests. The screenshot sweep still records soft overlap and partly offscreen button findings at extreme zoom; artifacts are in target/breakit-files-zoomfix and are not committed.

Finding for #155 after the production browser review: the original fix removed `min-width: 320px` from `apps/web/src/routes/layout.css`, but `packages/ui/src/tokens.css` still applied the same minimum to `html, body`. The real Files sweep therefore reported a 320px layout viewport for simulated 160px and 195px CSS widths. A minimal Chromium page at 195px did not clamp, which isolated the remaining floor to shared CSS. Commit `d34e6266` removes the shared floor (small addition outside the prior file set, required by #155). With a rebuilt production app, the existing `breakit.mjs --quick --only files-hostile` 200% width assertion passed at both 160px and 195px; that focused run exited 0. `bun run check` reported `svelte-check found 0 errors and 0 warnings`, and `bun run test` reported `120 passed (120)` files and `782 passed (782)` tests. The screenshot sweep still records soft overlap and partly offscreen button findings at extreme zoom; artifacts are in `target/breakit-files-zoomfix` and are not committed.
kayg commented 2026-09-29 06:11:37 +00:00
Author
Owner
Copy link

At 2026-09-29 08:12 CEST, the new shared CSS width-floor fix is committed and pushed as d34e6266; the branch is clean. The rebuilt production Files sweep passes its 160px and 195px width assertions, and the Tags sweep exits 0. Calendar Week still has a 206–207px minimum-content width at those extreme zoom sizes; I recorded it on #155. cargo fmt --check, bun run check, and bun run test have passed at this head. The full workspace clippy gate is still running under CARGO_BUILD_JOBS=4; the full workspace Rust test gate is queued behind it. I will report exact exit codes, not infer them from partial logs.

At 2026-09-29 08:12 CEST, the new shared CSS width-floor fix is committed and pushed as `d34e6266`; the branch is clean. The rebuilt production Files sweep passes its 160px and 195px width assertions, and the Tags sweep exits 0. Calendar Week still has a 206–207px minimum-content width at those extreme zoom sizes; I recorded it on #155. `cargo fmt --check`, `bun run check`, and `bun run test` have passed at this head. The full workspace clippy gate is still running under `CARGO_BUILD_JOBS=4`; the full workspace Rust test gate is queued behind it. I will report exact exit codes, not infer them from partial logs.
kayg commented 2026-09-29 06:30:47 +00:00
Author
Owner
Copy link

At 2026-09-29 08:30 CEST, the workspace cargo clippy --all-targets -- -D warnings gate completed at the pushed head. The first invocation finished its Cargo check in 82m 23s, then my zsh wrapper failed because status is read-only; the cached confirmation invocation produced Finished dev profile [unoptimized + debuginfo] target(s) in 1m 10s and CLIPPY_EXIT=0. The full workspace cargo test gate is running now. No code changed after d34e6266.

At 2026-09-29 08:30 CEST, the workspace `cargo clippy --all-targets -- -D warnings` gate completed at the pushed head. The first invocation finished its Cargo check in 82m 23s, then my zsh wrapper failed because `status` is read-only; the cached confirmation invocation produced `Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 10s` and `CLIPPY_EXIT=0`. The full workspace `cargo test` gate is running now. No code changed after `d34e6266`.
kayg commented 2026-09-29 06:46:17 +00:00
Author
Owner
Copy link

At 2026-09-29 08:46 CEST, cargo test is still compiling the full workspace with the required four-job cap. It has reached calternal-plugin-calendar; no test case has run or failed in this invocation yet. The branch remains clean at pushed head d34e6266. I will report the final gate exit code once it exists, or mark the gate pending if the job time cap ends first.

At 2026-09-29 08:46 CEST, `cargo test` is still compiling the full workspace with the required four-job cap. It has reached `calternal-plugin-calendar`; no test case has run or failed in this invocation yet. The branch remains clean at pushed head `d34e6266`. I will report the final gate exit code once it exists, or mark the gate pending if the job time cap ends first.
kayg commented 2026-09-29 07:35:15 +00:00
Author
Owner
Copy link

Finding and fix: The Files upload toast still hid the reason for a refused filename and offered Retry after a 400. Commit e5750bfa makes the first failure reason visible in the collapsed toast, identifies U+200B/U+FEFF and disallowed joiners after server refusal, and prevents unchanged 400 requests from being retried. Focused queue and component regressions pass (6 tests); web check passes with 0 errors and 0 warnings. The full web suite hit 5-second timeouts in unrelated menu focus and Mail tests under shared-host load; both test files pass alone. Production screenshot verification is in progress against a branch server build.

Finding and fix: The Files upload toast still hid the reason for a refused filename and offered Retry after a 400. Commit e5750bfa makes the first failure reason visible in the collapsed toast, identifies U+200B/U+FEFF and disallowed joiners after server refusal, and prevents unchanged 400 requests from being retried. Focused queue and component regressions pass (6 tests); web check passes with 0 errors and 0 warnings. The full web suite hit 5-second timeouts in unrelated menu focus and Mail tests under shared-host load; both test files pass alone. Production screenshot verification is in progress against a branch server build.
kayg commented 2026-09-29 07:52:15 +00:00
Author
Owner
Copy link

small-bugs-2 final report for #142

Built

  • Restored the small-bugs batch on job/small-bugs-2: contextual Unicode join controls in Files (#142), long Share-name containment (#143), Tags overflow regression (#145), muted Search contrast (#153), phone zoom reflow (#155), Week touch targets (#273), admin config denial before parsing (#276), oversized Appearance probes (#282/#283), retryable Calendar Index writes (#214), and Daily note relative navigation (#344). The anonymous 401 regression for #146 already passed on the branch.
  • Repaired the Daily note migration that caused the prior merge revert. It enumerates Homes through calternal-fs, records completion per User, and logs failures for retry rather than failing Notes startup.
  • Added #348: bounded retries for transient CLI device-login poll transport errors, 429, and 5xx, with a regression that includes 502.
  • Completed #142's Files UI behavior in e5750bfa: the collapsed upload toast shows a refused name's reason, including U+200B; a 400 has no Retry action and cannot be resent unchanged.
  • Merged dev once at de14b938, resolved both sides, and pushed this branch. No merge to dev or deploy was performed.

Files

Principal changed files: crates/calternal-fs/{src/path.rs,tests/storage.rs}; crates/plugins/notes/{migrations/0016_daily_note_navigation.sql,migrations/0017_daily_note_navigation_per_user.sql,src/lib.rs,src/store.rs}; crates/calternal-cli/src/login.rs; crates/plugins/calendar/src/routes.rs; apps/web/src/lib/files/{uploads.svelte.ts,uploads.svelte.test.ts,UploadToast.svelte,UploadToast.svelte.test.ts}; apps/web/src/lib/search/{PhotoGrid,SearchField,SearchPreview,SearchResultRow}.svelte; apps/web/src/lib/components/search-dialog.svelte; apps/web/src/routes/layout.css; packages/ui/src/tokens.css; apps/web/e2e/{breakit,layout-sweep,share}.mjs; tests/adversarial/{attack.py,editor-proxy.mjs}; Cargo.lock. The dev merge also brought other jobs' files into this branch.

Head SHA

e5750bfa3d1434c0d66ae77e451e23966fb42c56 (same SHA on origin/job/small-bugs-2); worktree clean.

Gates and evidence

Commands used CARGO_PROFILE_DEV_DEBUG=line-tables-only, CARGO_INCREMENTAL=0, CARGO_BUILD_JOBS=4, and TMPDIR=$PWD/target/tmp. The output excerpts below are verbatim.

  • cargo fmt --check: exit 0, no output.
  • cargo clippy --all-targets -- -D warnings: exit 0 on cached confirmation: 
        Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 10s
  • cargo test -p calternal-plugin-notes: 
    test result: ok. 110 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 39.78s
  • Focused CLI polling regression: 
    test login::tests::device_login_retries_a_transient_token_poll_and_says_when_retry_remains_possible ... ok
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 21 filtered out; finished in 0.77s
  • cargo test: exit 101 in the unrelated calternal-collab/tests/two_clients.rs crash/debounce test under shared-host load: 
    thread 'crash_before_debounce_reloads_only_complete_markdown' (431225) panicked at crates/calternal-collab/tests/two_clients.rs:89:5:
assertion `left == right` failed: 
  left: Some(101)
 right: Some(137)
test result: FAILED. 1 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 7.38s
    Direct rerun of that compiled test binary: 
    test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.88s
    The failure was recorded on #385; no test expectation was changed.
  • cd apps/web && bun run check: 
    svelte-check found 0 errors and 0 warnings
  • cd apps/web && bun run test --maxWorkers 2: exit 0: 
     Test Files  121 passed (121)
      Tests  784 passed (784)
    Two default-concurrency runs had 5-second timeouts in unrelated menu-focus/Mail tests; both test files passed alone. The lower-concurrency run passed the entire suite without changing expectations.
  • cd apps/web && bun run build: exit 0: 
    ✓ built in 1m 40s
  • Real local API returned 400 for bad\u200bname.txt; the current production web build showed This name has a character that is not allowed: U+200B and no Retry action. Playwright captured all six Files states at 390, 820, and 1440 px in light and dark; its assertions and page-error check passed: 
    UPLOAD_RESPONSE 400 http://localhost:12069/api/v1/files/uploads
TOAST_TEXT 1 of 1 could not upload
This name has a character that is not allowed: U+200B
PASS phone light: refusal visible, no Retry
PASS phone dark: refusal visible, no Retry
PASS tablet light: refusal visible, no Retry
PASS tablet dark: refusal visible, no Retry
PASS desktop light: refusal visible, no Retry
PASS desktop dark: refusal visible, no Retry
UPLOAD_TOAST_EVIDENCE_PASSED
    Screenshots remain uncommitted at target/upload-toast-review/files-upload-refusal-*.png. The local API binary embeds a different checkout's web assets, so Playwright served this branch's compiled production assets at the API origin while retaining the real server API.
  • The one time-boxed real-server API adversarial round exited 1 with SLOW load findings plus existing non-SLOW Appearance proxy 502, DAV discovery 207, and DAV alarm acceptance findings. These were recorded on #394/#379. The server remained alive. The Files and Tags focused production sweeps passed; Calendar Week still overflows at 160/195 CSS-pixel extreme zoom (#155).
  • git diff --check passed. cargo clean completed (Removed 216 files, 83.9MiB total after the canceled extra server build), and web build output was removed.

Known gaps

The full workspace Rust test gate is red on the load-sensitive collab test. The adversarial round has non-SLOW findings tracked on #394/#379. Calendar Week extreme zoom and some soft Files overlap remain on #155; those are outside this batch. Screenshot files could not be uploaded with scripts/fj, whose issue commands have no attachment option; they remain in the worktree for orchestrator review.

Decisions not covered by DESIGN.md

  • A 400 upload refusal is terminal for the unchanged request. The client reports an invisible code point only after the server refuses it; the server remains the validation authority. Other 400 cases use The server refused this file name or folder.
  • The migration uses Homes rather than auth tables and tracks completion per User, so an error can be retried without blocking startup.
  • ZWNJ cursive joining remains allowed; ZWJ cursive joining is refused. Emoji ZWJ context follows Unicode UAX #31 limited contexts.
  • Search muted text uses the shared dense role token and a 70% muted / 30% ink blend. Removing the shared 320px html, body minimum permits Files to reflow at 200% phone zoom.
# small-bugs-2 final report for #142 ## Built - Restored the small-bugs batch on `job/small-bugs-2`: contextual Unicode join controls in Files (#142), long Share-name containment (#143), Tags overflow regression (#145), muted Search contrast (#153), phone zoom reflow (#155), Week touch targets (#273), admin config denial before parsing (#276), oversized Appearance probes (#282/#283), retryable Calendar Index writes (#214), and Daily note relative navigation (#344). The anonymous 401 regression for #146 already passed on the branch. - Repaired the Daily note migration that caused the prior merge revert. It enumerates Homes through `calternal-fs`, records completion per User, and logs failures for retry rather than failing Notes startup. - Added #348: bounded retries for transient CLI device-login poll transport errors, 429, and 5xx, with a regression that includes 502. - Completed #142's Files UI behavior in `e5750bfa`: the collapsed upload toast shows a refused name's reason, including U+200B; a 400 has no Retry action and cannot be resent unchanged. - Merged `dev` once at `de14b938`, resolved both sides, and pushed this branch. No merge to `dev` or deploy was performed. ## Files Principal changed files: `crates/calternal-fs/{src/path.rs,tests/storage.rs}`; `crates/plugins/notes/{migrations/0016_daily_note_navigation.sql,migrations/0017_daily_note_navigation_per_user.sql,src/lib.rs,src/store.rs}`; `crates/calternal-cli/src/login.rs`; `crates/plugins/calendar/src/routes.rs`; `apps/web/src/lib/files/{uploads.svelte.ts,uploads.svelte.test.ts,UploadToast.svelte,UploadToast.svelte.test.ts}`; `apps/web/src/lib/search/{PhotoGrid,SearchField,SearchPreview,SearchResultRow}.svelte`; `apps/web/src/lib/components/search-dialog.svelte`; `apps/web/src/routes/layout.css`; `packages/ui/src/tokens.css`; `apps/web/e2e/{breakit,layout-sweep,share}.mjs`; `tests/adversarial/{attack.py,editor-proxy.mjs}`; `Cargo.lock`. The `dev` merge also brought other jobs' files into this branch. ## Head SHA `e5750bfa3d1434c0d66ae77e451e23966fb42c56` (same SHA on `origin/job/small-bugs-2`); worktree clean. ## Gates and evidence Commands used `CARGO_PROFILE_DEV_DEBUG=line-tables-only`, `CARGO_INCREMENTAL=0`, `CARGO_BUILD_JOBS=4`, and `TMPDIR=$PWD/target/tmp`. The output excerpts below are verbatim. - `cargo fmt --check`: exit 0, no output. - `cargo clippy --all-targets -- -D warnings`: exit 0 on cached confirmation: ```text Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 10s ``` - `cargo test -p calternal-plugin-notes`: ```text test result: ok. 110 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 39.78s ``` - Focused CLI polling regression: ```text test login::tests::device_login_retries_a_transient_token_poll_and_says_when_retry_remains_possible ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 21 filtered out; finished in 0.77s ``` - `cargo test`: exit 101 in the unrelated `calternal-collab/tests/two_clients.rs` crash/debounce test under shared-host load: ```text thread 'crash_before_debounce_reloads_only_complete_markdown' (431225) panicked at crates/calternal-collab/tests/two_clients.rs:89:5: assertion `left == right` failed: left: Some(101) right: Some(137) test result: FAILED. 1 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 7.38s ``` Direct rerun of that compiled test binary: ```text test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.88s ``` The failure was recorded on #385; no test expectation was changed. - `cd apps/web && bun run check`: ```text svelte-check found 0 errors and 0 warnings ``` - `cd apps/web && bun run test --maxWorkers 2`: exit 0: ```text Test Files 121 passed (121) Tests 784 passed (784) ``` Two default-concurrency runs had 5-second timeouts in unrelated menu-focus/Mail tests; both test files passed alone. The lower-concurrency run passed the entire suite without changing expectations. - `cd apps/web && bun run build`: exit 0: ```text ✓ built in 1m 40s ``` - Real local API returned 400 for `bad\u200bname.txt`; the current production web build showed `This name has a character that is not allowed: U+200B` and no Retry action. Playwright captured all six Files states at 390, 820, and 1440 px in light and dark; its assertions and page-error check passed: ```text UPLOAD_RESPONSE 400 http://localhost:12069/api/v1/files/uploads TOAST_TEXT 1 of 1 could not upload This name has a character that is not allowed: U+200B PASS phone light: refusal visible, no Retry PASS phone dark: refusal visible, no Retry PASS tablet light: refusal visible, no Retry PASS tablet dark: refusal visible, no Retry PASS desktop light: refusal visible, no Retry PASS desktop dark: refusal visible, no Retry UPLOAD_TOAST_EVIDENCE_PASSED ``` Screenshots remain uncommitted at `target/upload-toast-review/files-upload-refusal-*.png`. The local API binary embeds a different checkout's web assets, so Playwright served this branch's compiled production assets at the API origin while retaining the real server API. - The one time-boxed real-server API adversarial round exited 1 with SLOW load findings plus existing non-SLOW Appearance proxy 502, DAV discovery 207, and DAV alarm acceptance findings. These were recorded on #394/#379. The server remained alive. The Files and Tags focused production sweeps passed; Calendar Week still overflows at 160/195 CSS-pixel extreme zoom (#155). - `git diff --check` passed. `cargo clean` completed (`Removed 216 files, 83.9MiB total` after the canceled extra server build), and web build output was removed. ## Known gaps The full workspace Rust test gate is red on the load-sensitive collab test. The adversarial round has non-SLOW findings tracked on #394/#379. Calendar Week extreme zoom and some soft Files overlap remain on #155; those are outside this batch. Screenshot files could not be uploaded with `scripts/fj`, whose issue commands have no attachment option; they remain in the worktree for orchestrator review. ## Decisions not covered by DESIGN.md - A 400 upload refusal is terminal for the unchanged request. The client reports an invisible code point only after the server refuses it; the server remains the validation authority. Other 400 cases use `The server refused this file name or folder.` - The migration uses Homes rather than auth tables and tracks completion per User, so an error can be retried without blocking startup. - ZWNJ cursive joining remains allowed; ZWJ cursive joining is refused. Emoji ZWJ context follows Unicode UAX #31 limited contexts. - Search muted text uses the shared dense role token and a 70% muted / 30% ink blend. Removing the shared 320px `html, body` minimum permits Files to reflow at 200% phone zoom.
kayg closed this issue 2026-09-29 08:29:11 +00:00
kayg commented 2026-09-29 10:41:12 +00:00
Author
Owner
Copy link

Starting visual-resume work on job/ui-small-2 at 87a0a877495eefd55a1abe4b2e2f140051733839; the branch's current dev base is 191b179baac3ef4f5bebfe07ce91c4b7a887ace2.

The job prompt says this is the Files filename visual rejection. The current closed #142 body and its history describe the earlier Unicode filename validation batch, so this progress note records the mismatch. I am continuing the shared FileName.svelte, row rhythm and Files production evidence work from the requested review.

Starting visual-resume work on `job/ui-small-2` at `87a0a877495eefd55a1abe4b2e2f140051733839`; the branch's current `dev` base is `191b179baac3ef4f5bebfe07ce91c4b7a887ace2`. The job prompt says this is the Files filename visual rejection. The current closed #142 body and its history describe the earlier Unicode filename validation batch, so this progress note records the mismatch. I am continuing the shared `FileName.svelte`, row rhythm and Files production evidence work from the requested review.
kayg commented 2026-09-29 11:11:38 +00:00
Author
Owner
Copy link

Finding from the resumed branch: FileName.svelte rendered .stem and .ext as separate children, then set direction: rtl on the filename box to reverse CSS clamping. That let a long suffix occupy its own edge-aligned box. Files list rows also did not pass an explicit one-line desktop/two-line phone limit. I replaced this with one text run, cached canvas middle cuts, and a shared width observer. The production browser run is pending the local server build.

The requested task is a visual continuation. The closed #142 body still describes Unicode name validation, as noted in my start comment.

Finding from the resumed branch: `FileName.svelte` rendered `.stem` and `.ext` as separate children, then set `direction: rtl` on the filename box to reverse CSS clamping. That let a long suffix occupy its own edge-aligned box. Files list rows also did not pass an explicit one-line desktop/two-line phone limit. I replaced this with one text run, cached canvas middle cuts, and a shared width observer. The production browser run is pending the local server build. The requested task is a visual continuation. The closed #142 body still describes Unicode name validation, as noted in my start comment.
kayg commented 2026-09-29 12:24:31 +00:00
Author
Owner
Copy link

Delivered

  • Shared FileName.svelte keeps each filename in one text run. It measures grapheme-safe middle cuts with a bounded canvas cache and one shared ResizeObserver; it keeps the extension at the logical end. The full name remains in title and aria-label.
  • Files list names wrap to at most two lines on phone and one line at tablet and desktop widths. The title/meta stack uses a scaled 0.5rem gap.
  • The Files E2E asserts suffix glyph adjacency within 1ch on the same line, full accessible name, RTL direction, middle truncation, and line limits across five API-created filenames.
  • The sidebar ignores navigation targets without URLs when tracking same-origin history depth.

Production screenshot evidence

All 54 PNGs are attached to this issue: six full-page captures, 30 row crops and 18 zoom crops. They use this worktree's production SPA build and a real local API server.

Width Light Dark
390px phone light dark
820px tablet light dark
1440px desktop light dark

3× row crops

Zoom crops

Decisions

  • DESIGN §34 sets the filename suffix and line-count behavior. The implementation uses a balanced grapheme-safe middle cut and a 512-entry LRU keyed by width and text metrics; no per-row observer runs during scrolling.
  • Settings AccountRow has no shared paragraph-gap token. I used 0.5rem * --ui-scale (8px at default scale) for the wrapped title/meta stack because the prior 0.25rem gap looked too tight.
  • DESIGN §34 states the phone two-line and desktop one-line limits. I applied the one-line list limit at 820px tablet width too.
  • E2E used a prebuilt agenda-413 server binary whose server, filesystem and Files plugin crates match dev; CALTERNAL_E2E_ASSET_OVERRIDE=1 served this worktree's production SPA.

Files

  • apps/web/e2e/analytics.mjs, files.mjs, harness.mjs, photos.mjs
  • apps/web/src/lib/components/analytics/BklitAnalytics.tsx and analytics/vendor/bklit/charts/heatmap/heatmap-y-axis.tsx
  • apps/web/src/lib/components/app-sidebar.svelte
  • apps/web/src/lib/files/FileCollection.svelte.test.ts, PublicLinkPage.svelte, UploadToast.svelte
  • apps/web/src/lib/photos/TimelineScrubber.svelte
  • apps/web/src/lib/search/SearchResultRow.svelte and SearchResultRow.svelte.test.ts
  • packages/ui/src/components/calendar/ItemPreview.svelte
  • packages/ui/src/components/files/FileCollection.svelte and FileName.svelte
  • packages/ui/src/tokens.css

Gates

cargo fmt --check
(no stdout; exit 0)

bun run check
svelte-check found 0 errors and 0 warnings

bun run test
 Test Files  125 passed (125)
      Tests  803 passed (803)
   Start at  14:12:25
   Duration  106.70s (transform 58%, environment 15%, import 15%, tests 9%, setup 3%)

bun run build
✓ built in 31.28s
  Wrote site to "build"
  ✔ done

CALTERNAL_E2E_ASSET_OVERRIDE=1 bun e2e/files.mjs --screenshots target/files-name-review --screenshots-only --shot-surface files
FILES SCREENSHOTS PASSED
CSP REPORTS files: 0 across 7 pages

No Rust source or contract changed, so Rust clippy/tests were not run. node --check apps/web/e2e/files.mjs and git diff --check also passed.

Known gaps

  • The filename screenshot path uses Playwright's native row crops and passed. This host's sharp native module could not load libstdc++.so.6; the separate selection/header 2× crop path still uses sharp and was not part of this capture.
  • The branch-local server build was stopped after long shared-host contention. The compatible prebuilt server above supplied the real API during E2E.
  • Issue #142 is closed and its body covers Unicode join-control validation, not this UI review. I posted this report and evidence there without changing the issue state.

Commits

Head: b65058175f7dc2578c78fe2d6098101bfb42dfc8. Merged dev once before final gates as instructed; no push or deploy was performed.

## Delivered - Shared `FileName.svelte` keeps each filename in one text run. It measures grapheme-safe middle cuts with a bounded canvas cache and one shared `ResizeObserver`; it keeps the extension at the logical end. The full name remains in `title` and `aria-label`. - Files list names wrap to at most two lines on phone and one line at tablet and desktop widths. The title/meta stack uses a scaled 0.5rem gap. - The Files E2E asserts suffix glyph adjacency within 1ch on the same line, full accessible name, RTL direction, middle truncation, and line limits across five API-created filenames. - The sidebar ignores navigation targets without URLs when tracking same-origin history depth. ## Production screenshot evidence All 54 PNGs are attached to this issue: six full-page captures, 30 row crops and 18 zoom crops. They use this worktree's production SPA build and a real local API server. | Width | Light | Dark | | --- | --- | --- | | 390px phone | [light](https://git.kayg.org/attachments/e3f23b34-68d8-4d66-bf81-c3284cdc73ea) | [dark](https://git.kayg.org/attachments/93a8ab59-ad23-439a-af59-3955c6a50ccf) | | 820px tablet | [light](https://git.kayg.org/attachments/77f38df7-01bc-4928-b814-d8b0149e81bd) | [dark](https://git.kayg.org/attachments/e00ef41e-aa5d-4f89-87f0-0553ff6d2ab5) | | 1440px desktop | [light](https://git.kayg.org/attachments/1ba20b01-7fd1-40b5-b55d-b75d957204d6) | [dark](https://git.kayg.org/attachments/d2700147-6ae1-4028-96ec-aabba536ff76) | ### 3× row crops - **phone / light:** [row 01-phone-light.png](https://git.kayg.org/attachments/7f097c90-d617-4914-8795-05b99046de1e) · [row 02-phone-light.png](https://git.kayg.org/attachments/68026ac9-77b6-463a-ad09-f7ea6988f1a4) · [row 03-phone-light.png](https://git.kayg.org/attachments/17dc5ce5-3c8c-4f9f-a6a9-7e467edd6314) · [row 04-phone-light.png](https://git.kayg.org/attachments/eb4e520c-c4b3-48eb-b086-58efe34c26ec) · [row 05-phone-light.png](https://git.kayg.org/attachments/f3ca3a97-31d1-421b-81d4-47d9fd31291f) - **phone / dark:** [row 01-phone-dark.png](https://git.kayg.org/attachments/ddc612d3-f2bf-49b2-b287-c8beec72f4a8) · [row 02-phone-dark.png](https://git.kayg.org/attachments/e724a887-86c7-491f-9f2c-c0f5e6352360) · [row 03-phone-dark.png](https://git.kayg.org/attachments/3d128f69-83ef-4a29-b003-392b553f153d) · [row 04-phone-dark.png](https://git.kayg.org/attachments/e6817a69-a58f-42cd-b984-f8ce82d404c0) · [row 05-phone-dark.png](https://git.kayg.org/attachments/11e4a395-7a15-4b67-a19e-a5fd324e5d17) - **tablet / light:** [row 01-tablet-light.png](https://git.kayg.org/attachments/b6237f8a-53c0-4e43-a7a9-7f98b40bc33e) · [row 02-tablet-light.png](https://git.kayg.org/attachments/68c7635f-9809-40c6-b01b-a1f50bea97f2) · [row 03-tablet-light.png](https://git.kayg.org/attachments/3bb907a5-f2ea-4b1f-9dc8-11249e6a6c7c) · [row 04-tablet-light.png](https://git.kayg.org/attachments/101dc896-1f63-4304-9041-83144b88199f) · [row 05-tablet-light.png](https://git.kayg.org/attachments/51162b5b-2dca-4e08-aef5-e1fd6e292b4f) - **tablet / dark:** [row 01-tablet-dark.png](https://git.kayg.org/attachments/47cd2763-a3ba-47bf-9f5b-f130b410cfcc) · [row 02-tablet-dark.png](https://git.kayg.org/attachments/ebde42db-a41c-43cd-8b6f-50fe389adab1) · [row 03-tablet-dark.png](https://git.kayg.org/attachments/08e3a0ee-6bc7-4217-9560-d3218b2bf55a) · [row 04-tablet-dark.png](https://git.kayg.org/attachments/af1bba39-a6a3-43d4-a02e-c0a61fd88c1b) · [row 05-tablet-dark.png](https://git.kayg.org/attachments/5a3bba78-daaf-48e4-9544-cfa7e97f8532) - **desktop / light:** [row 01-desktop-light.png](https://git.kayg.org/attachments/b5174002-8eec-4573-aac1-9a3657b70884) · [row 02-desktop-light.png](https://git.kayg.org/attachments/63beb631-1325-472a-8571-cb7188975db6) · [row 03-desktop-light.png](https://git.kayg.org/attachments/e2206ba9-4dcd-4439-bcc1-d3328792a75d) · [row 04-desktop-light.png](https://git.kayg.org/attachments/c59b5341-964d-4ab4-be07-7e8435e77442) · [row 05-desktop-light.png](https://git.kayg.org/attachments/5638116b-d7b8-4a24-8372-d80d6cf852ef) - **desktop / dark:** [row 01-desktop-dark.png](https://git.kayg.org/attachments/4ed5df33-4106-4806-b3d0-0688d7e4d21d) · [row 02-desktop-dark.png](https://git.kayg.org/attachments/34d2770e-ff90-4744-846a-c88495c85421) · [row 03-desktop-dark.png](https://git.kayg.org/attachments/2c2bf2af-44b1-417c-94d0-b7b6551c468a) · [row 04-desktop-dark.png](https://git.kayg.org/attachments/428271d5-a88b-43aa-b041-b6eda5a0cd82) · [row 05-desktop-dark.png](https://git.kayg.org/attachments/c48da2ef-58ae-43fd-bb1f-848c14ca239d) ### Zoom crops - **phone / light:** [zoom phone-light-long.png](https://git.kayg.org/attachments/616c0e91-3b67-4012-8b5f-a89ddf9c5740) · [zoom phone-light-rtl.png](https://git.kayg.org/attachments/f8ed1f5e-b2d6-49fd-b7db-a6d86d22b04a) · [zoom phone-light-cjk.png](https://git.kayg.org/attachments/ba3f6df6-2f62-4113-800c-1a6525ba0f88) - **phone / dark:** [zoom phone-dark-long.png](https://git.kayg.org/attachments/77609394-4901-4e27-9baf-eaf85b117b12) · [zoom phone-dark-rtl.png](https://git.kayg.org/attachments/190b974b-fe90-4c43-81d4-181db61d2c6a) · [zoom phone-dark-cjk.png](https://git.kayg.org/attachments/ab17c3bc-5952-4650-b97b-10646c8cd793) - **tablet / light:** [zoom tablet-light-long.png](https://git.kayg.org/attachments/acd39707-fc71-46da-b43c-a2313d6cf565) · [zoom tablet-light-rtl.png](https://git.kayg.org/attachments/45da2aa3-e121-434b-a979-35e25da7ff73) · [zoom tablet-light-cjk.png](https://git.kayg.org/attachments/92f93807-da74-4131-b7dd-3a269ad668bc) - **tablet / dark:** [zoom tablet-dark-long.png](https://git.kayg.org/attachments/09993f67-0624-4e39-8940-6721cb5113ed) · [zoom tablet-dark-rtl.png](https://git.kayg.org/attachments/46a226a6-383b-444b-9ad1-5993e0fbb82d) · [zoom tablet-dark-cjk.png](https://git.kayg.org/attachments/ccad4d28-0780-4cdd-8404-370ffb77924f) - **desktop / light:** [zoom desktop-light-long.png](https://git.kayg.org/attachments/5c03150c-7d4b-4d43-8df9-a043cbdbc320) · [zoom desktop-light-rtl.png](https://git.kayg.org/attachments/a4d470ae-aad2-4609-81ad-7b7a618320b7) · [zoom desktop-light-cjk.png](https://git.kayg.org/attachments/97d59638-010d-419c-a981-33234cad30f1) - **desktop / dark:** [zoom desktop-dark-long.png](https://git.kayg.org/attachments/e9337f5a-998e-4fce-88d0-06b584c9f6ca) · [zoom desktop-dark-rtl.png](https://git.kayg.org/attachments/5dbd35d8-49ee-4309-8277-852716eded5f) · [zoom desktop-dark-cjk.png](https://git.kayg.org/attachments/884f0cc8-368e-4177-a093-c57b4356162d) ## Decisions - DESIGN §34 sets the filename suffix and line-count behavior. The implementation uses a balanced grapheme-safe middle cut and a 512-entry LRU keyed by width and text metrics; no per-row observer runs during scrolling. - Settings AccountRow has no shared paragraph-gap token. I used `0.5rem * --ui-scale` (8px at default scale) for the wrapped title/meta stack because the prior `0.25rem` gap looked too tight. - DESIGN §34 states the phone two-line and desktop one-line limits. I applied the one-line list limit at 820px tablet width too. - E2E used a prebuilt `agenda-413` server binary whose server, filesystem and Files plugin crates match `dev`; `CALTERNAL_E2E_ASSET_OVERRIDE=1` served this worktree's production SPA. ## Files - `apps/web/e2e/analytics.mjs`, `files.mjs`, `harness.mjs`, `photos.mjs` - `apps/web/src/lib/components/analytics/BklitAnalytics.tsx` and `analytics/vendor/bklit/charts/heatmap/heatmap-y-axis.tsx` - `apps/web/src/lib/components/app-sidebar.svelte` - `apps/web/src/lib/files/FileCollection.svelte.test.ts`, `PublicLinkPage.svelte`, `UploadToast.svelte` - `apps/web/src/lib/photos/TimelineScrubber.svelte` - `apps/web/src/lib/search/SearchResultRow.svelte` and `SearchResultRow.svelte.test.ts` - `packages/ui/src/components/calendar/ItemPreview.svelte` - `packages/ui/src/components/files/FileCollection.svelte` and `FileName.svelte` - `packages/ui/src/tokens.css` ## Gates ```text cargo fmt --check (no stdout; exit 0) bun run check svelte-check found 0 errors and 0 warnings bun run test Test Files 125 passed (125) Tests 803 passed (803) Start at 14:12:25 Duration 106.70s (transform 58%, environment 15%, import 15%, tests 9%, setup 3%) bun run build ✓ built in 31.28s Wrote site to "build" ✔ done CALTERNAL_E2E_ASSET_OVERRIDE=1 bun e2e/files.mjs --screenshots target/files-name-review --screenshots-only --shot-surface files FILES SCREENSHOTS PASSED CSP REPORTS files: 0 across 7 pages ``` No Rust source or contract changed, so Rust clippy/tests were not run. `node --check apps/web/e2e/files.mjs` and `git diff --check` also passed. ## Known gaps - The filename screenshot path uses Playwright's native row crops and passed. This host's `sharp` native module could not load `libstdc++.so.6`; the separate selection/header 2× crop path still uses `sharp` and was not part of this capture. - The branch-local server build was stopped after long shared-host contention. The compatible prebuilt server above supplied the real API during E2E. - Issue #142 is closed and its body covers Unicode join-control validation, not this UI review. I posted this report and evidence there without changing the issue state. ## Commits Head: `b65058175f7dc2578c78fe2d6098101bfb42dfc8`. Merged dev once before final gates as instructed; no push or deploy was performed.
kayg commented 2026-09-29 12:30:28 +00:00
Author
Owner
Copy link

Resuming ui-small-2 on branch job/ui-small-2, based on dev at 191b179baa. The accepted filename truncation and suffix behavior remains in place. I am fixing the reported phone row rhythm, adding the requested spacing assertion, and recapturing production screenshots at 390, 820, and 1440 px in both themes.

Resuming ui-small-2 on branch job/ui-small-2, based on dev at 191b179baac3ef4f5bebfe07ce91c4b7a887ace2. The accepted filename truncation and suffix behavior remains in place. I am fixing the reported phone row rhythm, adding the requested spacing assertion, and recapturing production screenshots at 390, 820, and 1440 px in both themes.
kayg commented 2026-09-29 12:55:53 +00:00
Author
Owner
Copy link

Finding and fix: the compact Files list used a fixed 60px row although phone filenames can wrap to two lines and show metadata. The metadata could overrun its row and sit close to the following title. The row is now 76px; the title-to-metadata gap matches Settings at 0.2rem.

The production Files e2e passed on the real local server. At 390px, light and dark, it asserts a 2–4px rendered text gap, metadata-to-next-title spacing at least twice that gap, and icon centring within 1px. Captures are saved in artifacts/ui-small-2/files-final/.

Finding and fix: the compact Files list used a fixed 60px row although phone filenames can wrap to two lines and show metadata. The metadata could overrun its row and sit close to the following title. The row is now 76px; the title-to-metadata gap matches Settings at 0.2rem. The production Files e2e passed on the real local server. At 390px, light and dark, it asserts a 2–4px rendered text gap, metadata-to-next-title spacing at least twice that gap, and icon centring within 1px. Captures are saved in `artifacts/ui-small-2/files-final/`.
kayg commented 2026-09-29 13:05:56 +00:00
Author
Owner
Copy link

ui-small-2 final report

Built

  • Phone Files rows now keep each filename and its metadata in one tight group. The title-to-metadata gap matches Settings at 0.2rem, and the row is 76px tall so a two-line filename and metadata fit with vertical breathing room.
  • The file icon centres on the complete title-plus-metadata group.
  • The production e2e asserts a 2–4px rendered text gap, gap(title→meta) × 2 ≤ gap(meta→next title), and icon alignment within 1px on phone rows.
  • Captured full screenshots and paired-row crops at 390px, 820px and 1440px, in light and dark. All 12 requested PNGs are saved under artifacts/ui-small-2/files-final/ and attached to this issue.

Files

  • packages/ui/src/components/files/FileCollection.svelte
  • apps/web/e2e/files.mjs
  • apps/web/src/lib/components/app-sidebar.svelte — merged the dev null-safe navigation guard and combined its comments.

Production evidence

View Light Dark
390px phone full screenshot · two-row crop full screenshot · two-row crop
820px tablet full screenshot · two-row crop full screenshot · two-row crop
1440px desktop full screenshot · two-row crop full screenshot · two-row crop

Flow: register a test User with the Files e2e harness → create the Name review folder and upload API-backed filename fixtures → open /files?path=Name%20review → check filename geometry and capture screenshots. The Browser plugin was not available, so I used the repo's Playwright production-build harness. It reported FILES SCREENSHOTS PASSED and CSP REPORTS files: 0 across 7 pages.

Gates

cd apps/web && bun run check

$ node scripts/check-type-tokens.mjs && svelte-kit sync && svelte-check --tsconfig ./tsconfig.json
Text sizes use shared role tokens.
Loading svelte-check in workspace: /home/kayg/Developer/calternal-wt/ui-small-2/apps/web
Getting Svelte diagnostics...

svelte-check found 0 errors and 0 warnings

cd apps/web && bun run test

$ vitest run

 RUN  v5.0.1 /home/kayg/Developer/calternal-wt/ui-small-2/apps/web

Not implemented: Window's scrollTo() method
Not implemented: Window's scrollTo() method
Could not parse CSS stylesheet
Not implemented: Window's scrollTo() method
Not implemented: Window's scrollTo() method
Not implemented: Window's scrollTo() method
Not implemented: Window's scrollTo() method
Not implemented: Window's scrollTo() method
Not implemented: Window's scrollTo() method
Not implemented: Window's scrollTo() method
Not implemented: Window's scrollTo() method
Not implemented: Window's scrollTo() method
Not implemented: Window's scrollTo() method
Not implemented: Window's scrollTo() method
Not implemented: Window's scrollTo() method
Not implemented: Window's scrollTo() method
Not implemented: Window's scrollTo() method
Not implemented: Window's scrollTo() method
Not implemented: Window's scrollTo() method
Not implemented: Window's scrollTo() method
Not implemented: Window's scrollTo() method
Not implemented: Window's scrollTo() method
Not implemented: Window's scrollTo() method
Not implemented: Window's scrollTo() method
Not implemented: Window's scrollTo() method
Not implemented: Window's scrollTo() method
Not implemented: Window's scrollTo() method
Not implemented: Window's scrollTo() method
Not implemented: Window's scrollTo() method
Not implemented: Window's scrollTo() method
Not implemented: Window's scrollTo() method
Not implemented: Window's scrollTo() method
Not implemented: Window's scrollTo() method
Not implemented: Window's scrollTo() method
Not implemented: Window's scrollTo() method

 Test Files  125 passed (125)
      Tests  803 passed (803)
   Start at  14:58:35
   Duration  66.97s (transform 47%, environment 22%, import 15%, tests 11%, setup 5%)

Environment  |component| jsdom was created 39 times · 84.34s total, 30% of tracked time
             create it once per worker with pool: 'vmThreads' (keeps per-file isolation) or isolate: false (shares it across files)
             learn more: https://vitest.dev/guide/improving-performance#test-environments

Merge and commits

  • Merged dev once at 70fce975945c272c7ed7f3e1844949e818ac778f. The only conflict was the sidebar null-URL guard comment; both branches had the same null-safe condition, and the merged comment keeps both explanations.
  • Feature commit: 2fb760eb7a6b4d0b0f9f4e1ae0a39fb06c9c8695 (fix(files): pair phone filenames with metadata).
  • Head SHA: 10ca061192e0af8e2d87bbd3beed82b79f5463b2.
  • No push or deploy was performed.

Known gaps

  • The dev merge added iCalendar fixtures with required CRLF line endings. git diff --cached --check reports those carriage returns as trailing whitespace; I left the fixtures unchanged.
  • The production build completed, with Rolldown's existing use client module-directive warnings.
  • The issue remains closed and its original body still describes the Unicode join-control report. I left its state unchanged.

Decision not specified by DESIGN.md

DESIGN §34 permits a two-line Files name on phones but does not set the compact row height. I used a fixed 76px row so the supported two-line name, 0.2rem Settings-matched metadata gap, caption and icon fit without per-row layout measurement. Please confirm this row height with the owner.

# ui-small-2 final report ## Built - Phone Files rows now keep each filename and its metadata in one tight group. The title-to-metadata gap matches Settings at 0.2rem, and the row is 76px tall so a two-line filename and metadata fit with vertical breathing room. - The file icon centres on the complete title-plus-metadata group. - The production e2e asserts a 2–4px rendered text gap, `gap(title→meta) × 2 ≤ gap(meta→next title)`, and icon alignment within 1px on phone rows. - Captured full screenshots and paired-row crops at 390px, 820px and 1440px, in light and dark. All 12 requested PNGs are saved under `artifacts/ui-small-2/files-final/` and attached to this issue. ## Files - `packages/ui/src/components/files/FileCollection.svelte` - `apps/web/e2e/files.mjs` - `apps/web/src/lib/components/app-sidebar.svelte` — merged the `dev` null-safe navigation guard and combined its comments. ## Production evidence | View | Light | Dark | | --- | --- | --- | | 390px phone | [full screenshot](https://git.kayg.org/attachments/0c8e6828-8792-4624-9c51-723f1f7f8f4d) · [two-row crop](https://git.kayg.org/attachments/72bd03e8-0872-4d4b-bdc2-c689d549f93c) | [full screenshot](https://git.kayg.org/attachments/249b8108-65ff-4b85-9bc8-81e9d49f1341) · [two-row crop](https://git.kayg.org/attachments/5b889597-37ac-4fb8-a9b0-b7c2f2c4d4c0) | | 820px tablet | [full screenshot](https://git.kayg.org/attachments/f656004f-2693-402c-bc8a-ff9f7e62eef0) · [two-row crop](https://git.kayg.org/attachments/5e534869-0ec0-4d53-bdcd-baff218246b2) | [full screenshot](https://git.kayg.org/attachments/3e324bd1-0c58-4da5-86ac-d89f2b2b8b75) · [two-row crop](https://git.kayg.org/attachments/29a2b413-e809-461a-9ddc-c331c968776d) | | 1440px desktop | [full screenshot](https://git.kayg.org/attachments/d83a2ba2-5546-4332-a428-3599397c7a61) · [two-row crop](https://git.kayg.org/attachments/5789a82a-491e-4663-a58e-35d9b57ac773) | [full screenshot](https://git.kayg.org/attachments/780e8f06-da6f-476f-b6a7-dc531c53ba3e) · [two-row crop](https://git.kayg.org/attachments/28a20ba4-3187-4cac-bb4f-66acf3fa8151) | Flow: register a test User with the Files e2e harness → create the `Name review` folder and upload API-backed filename fixtures → open `/files?path=Name%20review` → check filename geometry and capture screenshots. The Browser plugin was not available, so I used the repo's Playwright production-build harness. It reported `FILES SCREENSHOTS PASSED` and `CSP REPORTS files: 0 across 7 pages`. ## Gates `cd apps/web && bun run check` ```text $ node scripts/check-type-tokens.mjs && svelte-kit sync && svelte-check --tsconfig ./tsconfig.json Text sizes use shared role tokens. Loading svelte-check in workspace: /home/kayg/Developer/calternal-wt/ui-small-2/apps/web Getting Svelte diagnostics... svelte-check found 0 errors and 0 warnings ``` `cd apps/web && bun run test` ```text $ vitest run RUN v5.0.1 /home/kayg/Developer/calternal-wt/ui-small-2/apps/web Not implemented: Window's scrollTo() method Not implemented: Window's scrollTo() method Could not parse CSS stylesheet Not implemented: Window's scrollTo() method Not implemented: Window's scrollTo() method Not implemented: Window's scrollTo() method Not implemented: Window's scrollTo() method Not implemented: Window's scrollTo() method Not implemented: Window's scrollTo() method Not implemented: Window's scrollTo() method Not implemented: Window's scrollTo() method Not implemented: Window's scrollTo() method Not implemented: Window's scrollTo() method Not implemented: Window's scrollTo() method Not implemented: Window's scrollTo() method Not implemented: Window's scrollTo() method Not implemented: Window's scrollTo() method Not implemented: Window's scrollTo() method Not implemented: Window's scrollTo() method Not implemented: Window's scrollTo() method Not implemented: Window's scrollTo() method Not implemented: Window's scrollTo() method Not implemented: Window's scrollTo() method Not implemented: Window's scrollTo() method Not implemented: Window's scrollTo() method Not implemented: Window's scrollTo() method Not implemented: Window's scrollTo() method Not implemented: Window's scrollTo() method Not implemented: Window's scrollTo() method Not implemented: Window's scrollTo() method Not implemented: Window's scrollTo() method Not implemented: Window's scrollTo() method Not implemented: Window's scrollTo() method Not implemented: Window's scrollTo() method Not implemented: Window's scrollTo() method Test Files 125 passed (125) Tests 803 passed (803) Start at 14:58:35 Duration 66.97s (transform 47%, environment 22%, import 15%, tests 11%, setup 5%) Environment |component| jsdom was created 39 times · 84.34s total, 30% of tracked time create it once per worker with pool: 'vmThreads' (keeps per-file isolation) or isolate: false (shares it across files) learn more: https://vitest.dev/guide/improving-performance#test-environments ``` ## Merge and commits - Merged `dev` once at `70fce975945c272c7ed7f3e1844949e818ac778f`. The only conflict was the sidebar null-URL guard comment; both branches had the same null-safe condition, and the merged comment keeps both explanations. - Feature commit: `2fb760eb7a6b4d0b0f9f4e1ae0a39fb06c9c8695` (`fix(files): pair phone filenames with metadata`). - Head SHA: `10ca061192e0af8e2d87bbd3beed82b79f5463b2`. - No push or deploy was performed. ## Known gaps - The `dev` merge added iCalendar fixtures with required CRLF line endings. `git diff --cached --check` reports those carriage returns as trailing whitespace; I left the fixtures unchanged. - The production build completed, with Rolldown's existing `use client` module-directive warnings. - The issue remains closed and its original body still describes the Unicode join-control report. I left its state unchanged. ## Decision not specified by DESIGN.md DESIGN §34 permits a two-line Files name on phones but does not set the compact row height. I used a fixed 76px row so the supported two-line name, 0.2rem Settings-matched metadata gap, caption and icon fit without per-row layout measurement. Please confirm this row height with the owner.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
dev
wip/onboard-1141
wip/notifloop-1194
wip/nlpchip-1127
wip/morph-1104
wip/merge-round-7c5
wip/merge-round-7c4
wip/merge-round-7c3
wip/merge-round-7c2
wip/merge-round-7c
wip/mchrome-1084
wip/mailghost2-1094
wip/mailghost-1094
wip/kbpreview2-1118
wip/kbpreview-1118
wip/kanban-1092
wip/importhang-1121
wip/hiderev-1153
wip/hide4-1153
wip/hide3-1153
wip/hide2-1153
wip/hide-1153
wip/editreg-1132
wip/editorrail3-1113
wip/editorrail2-1113
wip/editorrail-1113
wip/e2e-b2-1071
wip/e2e-b-1071
wip/draw4-1101
wip/draw3-1101
wip/draw2-1101
wip/draw-1101
wip/directory-1199-r
wip/directory-1199
wip/delete-1119
wip/collabrev-1197
wip/collabloss-1197
wip/cards2-1083
wip/cards-1083
wip/canvas-visual
wip/canvasvis2-976
wip/calhdr-1112
wip/calcards-1115
wip/browserfix
wip/blocks-1125
job/onboard-1141
wip/allday-1107
wip/agenda-decks
wip/agenda-1086
wip/adv7c-1105
wip/txentry-1198
wip/trayicons2-1095
wip/trayicons-1095
wip/tagperf-1186
wip/sidebar3-1094
wip/rev2-webperf
wip/rev2-money-ident
job/adv-1202
wip/restyle-notes
wip/previewcard-1098
wip/palette2-1123
wip/palette-1093
wip/onboard2-1141
wip/onboard-1141.aborted-early
job/merge30
job/notifloop-1194
job/collabloss-1197
job/hide-1153
job/perf-1124
job/perf2-1124
job/tocrail-1191
job/restyle-settings
wip/restyle-settings
job/segmented-1200
job/tagperf-1186
wip/segmented-1200
job/restyle-files
job/tagdnd-1187
job/cards-1179
wip/cards2-1179
wip/cards-1179
wip/tocrail-1191
wip/tagdnd-1187
wip/restyle-files
wip/perf-1124
wip/merge30j
job/restyle-notes
job/wizchoices-1140
wip/wizchoices-1140
wip/restyle-1190
job/moneyfmt-1180
job/txentry-1198
wip/moneyfmt2-1180
wip/moneyfmt-1180-r
wip/moneyfmt-1180
job/pillglass-1189
job/flags-1181
wip/flags-1181
job/restyle-1190
job/restyle-mailmoney
job/restyle-search
job/settingsreg-1195
job/wizard-1140
site/website
wip/wizardrev2-1140
wip/wizardrev-1140
wip/wizard5-1140
wip/wizard4-1140
wip/wizard3-1140
wip/wizard2-1140
wip/wizard-1140
wip/pillglass-1189
wip/settingsreg-1195
job/merge29
job/fu-1171
wip/merge29j
wip/fu-1171
job/fu-1166
job/directory-1199
job/proflog-1204
job/txresearch-1188
wip/fu-1166
job/merge28
job/search-1066
wip/search-1066
wip/merge28j
job/gateslot-1182
job/bulkimport-1157
job/mailnet-1160
wip/mailnetrev-1160
wip/mailnet-1160
wip/bulkrev-1157
wip/bulkimport-1157
job/startup-1161
wip/startup-1161
job/merge27
job/linkcards-1151
wip/linkcards3-1151
wip/linkcards2-1151
wip/linkcards-1151
job/traydate-1144
wip/traydate3-1144
wip/traydate2-1144
wip/traydate-1144
job/draw-1101
wip/merge27j
job/blockpill-1152
wip/blockpill3-1152
wip/blockpill2-1152
wip/blockpill-1152
job/minihover-1149
wip/minihover2-1149
wip/minihover-1149
job/merge25
wip/merge25-r
wip/merge25b
wip/merge25
job/inspector-1129
job/tags-1110
wip/inspector3-1129
wip/inspector2-1129
wip/inspector-1129
wip/tagsrev-1110
wip/tags2-1110
wip/tags-1110
job/dates-1148
wip/datesrev-1148
wip/dates2-1148
wip/dates-1148
job/licence-1145
wip/licence2-1145
wip/licence-1145
job/selfhost-1156
job/merge23
wip/merge23
job/tagfilter-1109
wip/tagfilter2-1109
wip/tagfilter-1109
job/kbd-1134
wip/kbd2-1134
wip/kbd-1134
job/palfoot-1137
wip/selfhost-1156
wip/palfoot2-1137
wip/palfoot-1137
job/toggle-1158
wip/toggle-1158
job/kbpreview-1118
job/docratchet-1155
job/perflint-1133
job/devtests-1159
wip/docratchet-1155
wip/devtests-1159
job/segv-1136
wip/toast-1142
wip/segv-1136
job/toast-1142
job/blockreload-1147
wip/blockreload-1147
job/font-1150
wip/font-1150
job/importui-1120
job/minimonth-1149
wip/importui-1120
wip/minimonth-1149
job/depcheck-1146
wip/perflint-1133
wip/depcheck-1146
job/calcards-1115
job/blocks-1125
job/plus-1128
job/shift-1138
wip/plus2-1128
wip/plus-1128
wip/shift-1138
job/moneyfid-1130
job/editorrail-1113
wip/moneyrev-1130
wip/moneyfid-1130
job/noext-851
wip/noext-851
wip/noext3-851
wip/noext2-851
job/week-1135
wip/week-1135
job/editreg-1132
job/smoke-1122
wip/smoke-1122
job/docs-1143
job/palette2-1123
job/calhdr-1112
job/nlpchip-1127
job/mailghost-1094
job/reconnect-1131
wip/reconnect-1131
job/trayicons-1095
job/delete-1119
job/importhang-1121
job/cards-1083
job/palette-1093
job/mchrome-1084
job/e2e-a-1071
job/canvas-visual
job/previewcard-1098
job/allday-1107
wip/e2e-a2-1071
wip/e2e-a-1071
job/e2e-b-1071
job/adv7c-1105
job/kanban-1092
job/agenda-1086
job/merge-round-7c
job/morph-1104
wip/surfaces-p2
job/merge-round-9
wip/merge-round-9
job/7cfix-small
wip/7cfix-small
job/mailui-1078
job/merge-round-8
wip/merge-round-8
wip/mailui-1078
job/mailround-1038
job/applemail-accept
wip/settitle-1068
wip/mailround2-1038
wip/mailround-1038
wip/e2e-7b
job/crash-1069
wip/crash-1069
job/searchlost-1066
wip/searchlost-1066
job/7b-reconcile
job/flake-1065
wip/flake-1065
wip/merge-round-7b7
wip/merge-round-7b6
wip/merge-round-7b5
wip/merge-round-7b4
wip/7b-reconcile
job/appupdate-1059
job/nfd-1044
wip/appupdate-1059
job/e2e-7b
job/loop-1062
wip/loop-1062
job/pdfprev-1045
job/invtoggle-1053
wip/pdfprev-1045
wip/nfd-1044
wip/invtoggle-1053
job/7bfix-e2e
job/mailstress-b
wip/7bfix-e2e
wip/mailstress-b
job/7bfix-adv
wip/7bfix-adv
job/mailstress-a
job/stack-1054
wip/stack-1054
wip/mailstress-a
job/mailstress-1038
wip/mailstress-1038
job/upload500-1051
wip/upload500-1051
job/share-1034
wip/share-1034
job/syncerr-1037
job/7bfix-photos
wip/7bfix-photos
job/paste-1036
job/setside-1039
wip/setside-1039
wip/paste-1036
job/lease-1042
wip/syncerr-1037
wip/lease-1042
job/7bfix-data
job/passkeybind-1043
wip/apprevoke-1041
job/invite-1035
wip/invite-1035
job/merge-round-7b2
wip/merge-round-7b2
job/mailproxy-486
job/apprevoke-1041
job/rebuild-1033
job/pillborder-1029
wip/pillborder-1029
wip/mailproxy-486
wip/applemail-486
job/headless-998
wip/headless-998
job/groups-1028
wip/groups-1028
job/rebuildwarn-1016
wip/rebuildwarn-1016
job/startup-1011
wip/startup-1011
job/monthpill-1009
job/bgthumb-1025
job/sharetitle-1012
wip/monthpill-1009
wip/bgthumb-1025
wip/sharetitle-1012
job/canvas-cards-977
wip/canvas-cards-977
job/canvas-pencil-978
job/canvas-sketch-990
wip/canvas-sketch-990
wip/canvas-pencil-978
job/canvas-files-989
wip/canvas-files-989
job/canvas-collab-991
wip/canvas-collab-991
job/weekscroll-1018
wip/weekscroll-1018
wip/canvas-core-976
job/canvas-core-976
job/round-drag
wip/round-drag
job/round-settings
job/browserfix
wip/oapi-974
job/oapi-974
job/hist2-integrate
job/mailhtml-726
wip/mailhtml-726
wip/hist2-integrate
job/moneyfu-984
job/drag-1015
wip/drag-1015
job/rename-1017
wip/rename-1017
job/hist2-api
wip/hist2-api
job/oneacct-1014
wip/oneacct-1014
wip/moneyfu-984
job/hist2-bench
job/hist2-restore
wip/hist2-bench
job/hist2-write
job/hotfix-724
wip/hotfix-724
wip/hist2-write
wip/hist2-restore
job/hist2-store
job/hist2-ui
wip/hist2-ui
wip/hist2-store
job/searchstarve-965
job/shutdown-963
wip/shutdown-963
wip/pubedit-981
job/pubedit-981
job/analytics-973
wip/searchstarve-965
job/authflash-850
job/weeklane-969
job/pvtitle-1004
job/hist-975
wip/authflash-850
job/voicepill-617
wip/pvtitle-1004
job/headring-1003
wip/weeklane-969
wip/voicepill-617
wip/headring-1003
wip/analytics-973
job/agentscope-980
wip/thumbsandbox-988
job/thumbsandbox-988
wip/hist-975
job/links-856
wip/links-856
job/davetag-966
wip/davetag-966
job/filesstorm-1000
job/hoverpad-725
wip/filesstorm-1000
job/ffmpegblas-993
job/merge-round-7a
wip/hoverpad-725
wip/ffmpegblas-993
job/nowdot-1002
wip/verify-7a
job/noteid-857
wip/nowdot-1002
wip/noteid-857
wip/merge-round-7a
wip/agentscope-980
job/imapedge
job/a11yfix2
wip/imapedge-941
wip/imapedge
wip/a11yfix2
job/notetask-986
job/logheading
wip/logheading-998
job/textthumb-652
job/photolive-987
wip/photolive-987
job/davactive-983
job/savefix-985
job/tabicons-607
wip/davactive-983
wip/tabicons-607
wip/notetask-986
wip/savefix-985
job/dirid-627
job/buildspeed-1007
wip/dirid-627
job/agenda-decks
job/perfguards-impl
job/undo-a11y
wip/undo-a11y
job/mailperf
job/wal-824
wip/settings-50
job/settings-50
job/notesfilter-606
wip/notesfilter-606
job/surfaces-p2
wip/wal-824
job/maillayouts
wip/mailperf
wip/maillayouts
job/taskmeta-659
job/money-ident
wip/money-ident
wip/taskmeta-659
job/errstates
wip/perfguards-impl
job/headings-881
wip/headings-881
wip/errstates
job/voice-619
job/gaps-827
job/notesperf
wip/notesperf
wip/voice-619
job/hddsql-549
job/perf-stream-668
wip/perf-stream-668
wip/deeplinks-fix
job/deeplinks-fix
job/authfix
job/docsfix-rust
wip/docsfix-rust
job/webperf
job/docsfix-web
job/datafix2
job/webdav-lock-476
job/copyfix
wip/copyfix
wip/webperf
job/focus-658
wip/protofix
job/mediafix
job/protofix
wip/mediafix
job/agentfix
job/hhmm-724
wip/agentfix
job/undo-722
job/reuse
wip/webdav-lock-476
wip/reuse
job/scopefix
job/datafix
wip/hhmm-724
wip/undo-722
job/surfaces-p1
wip/hddsql-549
job/voicememos-618
wip/datafix2
wip/surfaces-p1
job/fix-940
wip/fix-940
job/blaze-surfaces
wip/datafix
wip/blaze-surfaces
job/taskday-655
job/linknav-639
wip/linknav-639
wip/gaps-827
job/isolation-707
job/audiophotos-720
wip/audiophotos-720
job/advfind-664
wip/voicememos-618
wip/taskday-655
wip/isolation-707
wip/advfind-664
wip/scopefix
wip/focus-658
job/testgaps
wip/testgaps
job/overscroll-718
wip/authfix
job/deps
wip/overscroll-718
job/rev2-agentfix
job/rev2-money-ident
job/rev2-mailperf
wip/deps
job/hardening-728
wip/hardening-728
job/searchgen-832
wip/searchgen-832
job/photopw-849
job/mailsql-825
wip/photopw-849
job/sharefix
wip/sharefix
job/rev2-mailhtml-726
job/rev2-perfguards
job/copyval-723
job/lightglass-r2
wip/lightglass-r2
wip/docsfix-web
job/copy-audit
job/macinterop-staging-r2
job/design-sync
job/rev2-taskmeta-659
job/rev2-webperf
job/docs-audit
job/rev2-advfind-664
job/rev2-mailproxy-486
job/states-audit
job/rev2-datafix
job/design-drift
job/test-gaps
job/rev2-voicememos-618
job/rev2-mediafix
job/rev2-deps
job/rev2-datafix2
job/licence-audit
job/issue-hygiene
job/rev2-protofix
job/rev2-voice-619
job/rev2-isolation-707
job/rev2-surfaces-p1
job/deeplink-audit2
job/rev2-audiophotos-720
wip/test-gaps
job/rev2-overscroll-718
job/rev2-undo-722
wip/states-audit
job/rev2-dropmd-719
job/rev2-linknav-639
job/merge-7b-plan
wip/merge-7b-plan
job/rev2-taskday-655
wip/mailsql-825
job/rev2-webdav-lock-476
job/rev2-browserfix
wip/design-drift
job/rev2-hddsql-549
wip/deeplink-audit2
job/rev2-scopefix
job/rev2-authfix
job/rev2-hardening-728
job/rev2-wal-824
job/rev2-sharefix
job/calsidebar-638
job/chrome-audit
job/ioperf
wip/ioperf
wip/chrome-audit
wip/calsidebar-638
job/dropmd-719
wip/dropmd-719
job/ocr-build
wip/ocr-build
job/blaze-settings
wip/copyval-723
job/toastring-721
wip/toastring-721
job/deployfix-732
wip/deployfix-732
wip/blaze-settings
job/money-import-recheck
job/rev-a11y
job/perf-arch-db
job/rev-7b-data
wip/textthumb-652
wip/perf-arch-db
job/sec-protocols
job/sidehdr-660
job/rev-7b-security
job/research-surfaces
job/rev-design-gaps
job/rev-mcp-api
wip/sidehdr-660
job/perf-arch-memory
wip/sec-protocols
job/perf-arch-bundle
job/snapedge-714
wip/rev-mcp-api
job/sec-supplychain
wip/research-surfaces
job/perf-arch-sync
job/rev-consistency
job/perf-arch-server
wip/perf-arch-server
wip/perf-arch-memory
job/perf-arch-io
job/perf-arch-client
job/sec-fs
job/sec-mcp-scopes
job/sec-sharing
job/perf-guards
job/sec-browser
job/sec-admin-deploy
job/sec-auth
wip/snapedge-714
job/bgpicker-717
wip/perf-arch-bundle
wip/money-import-recheck
job/advsetup-654
wip/bgpicker-717
wip/advsetup-654
job/burst-709
job/kbdcaps-710
job/app-pw-chooser
wip/burst-709
wip/app-pw-chooser
job/imaptest-625
wip/kbdcaps-710
job/fix-499
wip/fix-499
job/perf-mut-667
job/calimg-589
job/perf-snap-666
wip/calimg-589
wip/perf-snap-666
wip/perf-mut-667
job/perf-cache-665
wip/perf-cache-665
job/voicefiles-620
wip/voicefiles-620
job/admin-burst-705
wip/admin-burst-705
job/voicememos-review
wip/voicememos-review
wip/ryw-653
job/ryw-653
job/writeonopen-661
job/instant-663
wip/writeonopen-661
job/money-import-review
wip/money-import-review
wip/importjs-610
review/integrations-407-round6
wip/integrations-review
job/dragghost-612
wip/dragghost-612
job/integrations
wip/integrations
job/decider-656
job/merge-round-6
job/perf-rerun
wip/merge-round-6
job/integrations-review-round5
job/selalign-576
wip/selalign-576
job/mcp-events-491
job/files-631
job/cal-e2e-569
wip/cal-e2e-569
job/reload-423
wip/reload-423
wip/mcp-events-491
wip/files-631
job/notesbridge-644
wip/notesbridge-644
job/editor-series
job/calcard-series
wip/calcard-series
job/mcp-events-review-491
wip/mcp-events-review
wip/editor-series
job/quirks-546
job/integrations-recheck
job/tocrail-636
wip/tocrail-636
wip/quirks-546
wip/reminders-643
job/reminders-643
wip/davscale-573
job/davscale-573
job/integrations-review
wip/ocr-eval-584
job/ocr-eval-584
job/esc-537
wip/esc-537
job/toastname-586
wip/toastname-586
job/submenu-579
wip/submenu-579
job/tasks-mode
wip/tasks-mode
job/agentdocs-630
job/dupwrite-634
wip/agentdocs-630
wip/dupwrite-634
job/lightglass-588
wip/lightglass-588
job/tabswitch-549
job/ghosttask-623
wip/ghosttask-623
job/toaststack-616
job/weekstate-609
job/mailsync-613
wip/mailsync-613
wip/weekstate-609
job/maildup-626
wip/tabswitch-549
wip/maildup-626
wip/toaststack-616
job/motion-611
wip/motion-611
job/tlstest-601
wip/tlstest-601
job/perf-495
job/floating-sheet
wip/floating-sheet
job/remdup-585
wip/remdup-585
job/fix-502
wip/fix-502
job/attachplay-622
job/perf-batch
wip/perf-batch-563
wip/perf-495
hotfix/mail-sync-diag
job/mail-m3
wip/mail-m3
job/attach-poof-603
job/calhover-608
job/editorbar-604
job/mentions-605
job/merge-round-4
job/allday-514
wip/merge-round-4
wip/allday-514
job/merge-round-4a
wip/merge-round-4a
job/sharestack-580
job/fix-501
wip/sharestack-580
wip/fix-501
job/perf-batch-563
job/apw-cache-review
wip/apw-cache-review
job/probe-520
wip/probe-520
job/mac-393
wip/mac-393
job/header-571
job/flake-513
wip/flake-513
job/docs-thumb-547
wip/header-571
job/webcal-572
wip/webcal-572
wip/shortcuts-542
job/shortcuts-542
wip/docs-thumb-547
job/caldav-stress
wip/caldav-stress
wip/sweep-478
job/apw-cache-512
wip/apw-cache-512
job/money-empty-540
wip/restart-505
wip/money-empty-540
wip/fix-510
job/restart-505
job/fix-503
job/perf-496
wip/perf-496
job/fix-498
wip/fix-498
job/info-inspector-465
wip/info-inspector-465
job/fix-510
job/fix-507
wip/fix-507
wip/fix-503
job/fix-493
job/money-kinds
wip/money-kinds
job/hygiene-548
job/merge-round-3
wip/fix-493
job/drag-snap-536
wip/merge-round-3
wip/merge-round-0930
wip/drag-snap-536
job/align-538
wip/align-538
job/bg-flash
wip/bg-flash
job/money-import
job/search-count-544
wip/search-count-544
wip/money-import
job/settings-key-541
wip/settings-key-541
job/toast-539
job/preview-421
wip/preview-421
wip/toast-539
job/tasks-500-531
job/title-plain-526
wip/title-plain-526
wip/tasks-500-531
job/notes-bridge
wip/parity-484
job/parity-484
job/files-slow
job/crash-525
wip/notes-bridge
wip/files-slow
wip/crash-525
job/kbd-motion-527
wip/bg-422
job/analytics-504
wip/analytics-504
wip/kbd-motion-527
job/upload-pill-523
wip/upload-pill-523
wip/tray-order
job/tray-order
wip/overflow-mid
wip/merge-round-2
job/perf-494
wip/perf-494
wip/mcp-fast-492
wip/motion-477
wip/asr-ab-489
wip/theme-variants-506
wip/overflow-511
wip/week-header-508
wip/attach-427
job/dav-delete-471
job/iso-435
wip/iso-435
wip/files-sel-keys
wip/dav-delete-471
job/align-253
job/siwc-490
wip/siwc-490
job/money-kinds-review
wip/align-253
wip/money-kinds-review
job/small-bugs-3
wip/overlay-title-487
wip/multiget-500
wip/hidden-420
wip/webcal-ui
wip/webcal-431
job/perf-367
job/location
wip/small-bugs-3
wip/location
wip/perf-367
wip/admin-deny-483
job/tag-unicode-473
wip/tag-unicode-473
job/blur-436
wip/photos-470
wip/blur-436
wip/small-bugs-4
wip/hunt-20260930
wip/settings-hdr-482
wip/chips-416
job/dedup-375
wip/dedup-375
job/doc-stack
wip/doc-stack
job/tokens-literals
wip/tokens-literals
job/jobs-leftovers
wip/send-fast
wip/paste-467
wip/money-numbers
job/money-plugin
wip/money-plugin
job/break-dav
wip/merge-batch
wip/crossday-469
wip/mac-verify
wip/mail-m2
wip/break-dav
wip/money-review2
job/money-md
job/modes-424
wip/money-md
wip/jobs-leftovers
job/agenda-413
wip/agenda-413
wip/modes-424
job/recog-417
wip/recog-417
wip/bounce-425
wip/ab-384-luna
job/webdav-perf
wip/webdav-perf
job/toast-ring
wip/toast-ring
job/money-review
wip/money-review
wip/micro-motion
wip/settings-card
wip/minical
job/notes-imap-428
job/least-priv
wip/ui-small-2
wip/flaky-426
wip/drag-end-418
job/jank
wip/jank
wip/least-priv
wip/docs-site
job/agenda
job/sec-batch
wip/sec-batch
wip/per-user-index
job/area-calendars
wip/area-calendars
job/parity
wip/parity
job/documents-research
wip/documents-research
job/test-infra
job/reminders-sync
wip/small-bugs-2
wip/reminders-sync
wip/gestures
job/google-oauth
wip/tags-merge
wip/tags
job/e2e-theme
wip/e2e-theme
job/icon-align
wip/test-infra
wip/select-align
wip/editor-385
job/voice
wip/webdav
job/webdav
job/app-pw-ui
job/editor-integrity
wip/editor-integrity
wip/voice
wip/quota
wip/cal-followups
wip/icon-align
job/composer-scale
wip/composer-scale
job/jobs-page
wip/jobs-page
job/hig-type
wip/hig-type
wip/app-pw-ui
job/motion-spring
job/mcp
wip/motion-spring
wip/mcp
job/small-bugs
wip/push-hosts
job/profile-sign
wip/touch-369
wip/profile-sign
job/mobile-focus
wip/mobile-focus
wip/ui-polish-354
wip/small-bugs
wip/dup-task
job/toast-polish
job/app-pw-scopes
wip/toast-polish
wip/app-pw-scopes
wip/cli-agent
wip/selection-pills
job/preview-attach
wip/preview-attach
job/dav-proppatch
wip/dav-proppatch
wip/cal-switcher
job/atomic-race
wip/atomic-race
job/photos-shared
wip/photos-shared
wip/cal-grid
wip/note-rewrite
wip/search-rebuild
job/mail-m1
job/paperless-import
wip/paperless-import
wip/mail-m1
wip/hidden-activity
wip/search-d
wip/pricing-research
wip/cursors
wip/auto-scheme
job/single-pills
wip/single-pills
wip/xuser-matrix
wip/money-format
wip/app-pw-setup
wip/purge-dos
wip/vault-health
wip/caldav-apple
wip/xuser-audit
wip/e2e-green
wip/tabbar
wip/adv-harness
wip/maple-mono
job/search-fix
wip/search-fix
wip/search-perf-c
job/adv-harness
wip/sidebar-headers
job/glass
wip/temp-index
job/polish
wip/polish
wip/file-protocols
wip/money-research
wip/glass
wip/voice-models
wip/collab-redo
job/voice-research
wip/hunt-20260928
wip/notes-actions-research
wip/search-pad
wip/search-perf
wip/search-sticky
wip/editor-undo
wip/chrome-rules
wip/motion
wip/appearance-research
wip/appearance
wip/audit-bugs
wip/cal-glass
wip/block-actions
wip/authz-order
wip/event-stripes
wip/chrome-sidebar
wip/auth-flaky
wip/robust-2
wip/gate-fix
wip/menu-blur
wip/import-calternaljs
wip/tray-fix
job/import-calternaljs
wip/index-order
wip/audit-fixes
wip/search-chevrons
research/mail
wip/phone-chrome
wip/dedup-break
wip/csp
wip/ui-audit
wip/select-toast
wip/perf
wip/flat-layout
wip/fonts
wip/event-tint
wip/sync-converge
wip/data-split
wip/glass-audit
wip/robustness
wip/sync-chaos
wip/search-thumbs
wip/fuzz
wip/menu-icons
wip/search-pill
wip/sync-changing
wip/heading-links
wip/date-formats
wip/a11y
wip/break-editor
wip/e2e-fix
wip/settings-sections
wip/sync-root-guard
wip/search-palette
wip/share-edit
job/toasts
wip/toasts
wip/cont-analytics
wip/authz-review
wip/popovers
wip/overlay-glass
wip/change-feed
wip/editor-modes
wip/composer-align
wip/cont-agenda
wip/agenda-merge
job/agent-conventions
wip/agent-conventions
wip/backend-misc
job/route-audit
wip/route-audit
wip/ui-batch
wip/heif-hardening
wip/grid-resize
wip/ask-page
wip/webmcp
job/deeplink-audit
wip/deeplinks
wip/shortcuts
wip/cont-tz-days
main
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kayg/calternal#142
No description provided.