TOKENS: replace hard-coded radii, line heights and letter spacing with shared tokens (after #287)

kayg commented

2026-09-28 06:55:55 +00:00

Owner

Owner (2026-09-28): 'yes please simplify and code-reuse so that we don't override so often.' This follows the #287 font-weight migration (202 literals → 4 steps) with the same treatment for the other overrides.

Audit on dev 58818bc3 (excluding tokens.css, calternal-app.css and the theme files; colour literals are already almost all in themes.css/themes.ts, where they belong):

border-radius: Npx: 195 literals, 20 distinct values
line-height: N: 105 literals, 19 distinct values
letter-spacing: N: 60 literals, 14 distinct values
font-size literals: 11 (fold them into the rem type scale; CLAUDE.md: one rem type scale)
box-shadow literals: 34 (one value; make it a token)

Fix:

For each property, define a small role-based scale in the tokens (e.g. radius: control, card, surface, pill/full; line-height: tight (headings), UI, body/prose; tracking: display, UI, caps/eyebrow). Name by role, not by number. Reuse existing tokens where they exist (--radius-control, --island-pad, …).
Map every literal to its role (not the nearest number). The result should show fewer distinct visual values, with no visible regressions except intended unification.
Extend the #287 guard check to fail on new numeric literals for these properties outside the tokens.
Keep the diff mechanical (property lines only) so parallel jobs merge easily.
Evidence: the same 8-screen before/after crop grid as #287, light and dark, desktop and phone; call out every place that visibly changed.

Start only after #287 merges (same files).

Owner (2026-09-28): 'yes please simplify and code-reuse so that we don't override so often.' This follows the #287 font-weight migration (202 literals → 4 steps) with the same treatment for the other overrides. Audit on dev 58818bc3 (excluding tokens.css, calternal-app.css and the theme files; colour literals are already almost all in themes.css/themes.ts, where they belong): - `border-radius: Npx`: **195 literals, 20 distinct values** - `line-height: N`: **105 literals, 19 distinct values** - `letter-spacing: N`: **60 literals, 14 distinct values** - `font-size` literals: 11 (fold them into the rem type scale; CLAUDE.md: one rem type scale) - `box-shadow` literals: 34 (one value; make it a token) Fix: 1. For each property, define a small role-based scale in the tokens (e.g. radius: control, card, surface, pill/full; line-height: tight (headings), UI, body/prose; tracking: display, UI, caps/eyebrow). Name by role, not by number. Reuse existing tokens where they exist (`--radius-control`, `--island-pad`, …). 2. Map every literal to its role (not the nearest number). The result should show fewer distinct visual values, with no visible regressions except intended unification. 3. Extend the #287 guard check to fail on new numeric literals for these properties outside the tokens. 4. Keep the diff mechanical (property lines only) so parallel jobs merge easily. Evidence: the same 8-screen before/after crop grid as #287, light and dark, desktop and phone; call out every place that visibly changed. Start only after #287 merges (same files).

tokens-literals-299.tar.gz

28 MiB

tokens-literals-299.tar.gz

28 MiB

kayg commented

2026-09-28 07:34:34 +00:00

Author

Owner

The scan of dev at c9ec6aff84a9ec810124a2cfbdd07c189eea1b9c found 194 pixel border-radius declarations, 107 unitless line-height declarations, 60 numeric letter-spacing declarations, 11 numeric font-size declarations, and 59 box-shadow declarations with literal pixel geometry. Top sources include apps/web/src/lib/files/PublicLinkPage.svelte, apps/web/src/lib/search/SearchPreview.svelte, apps/web/src/lib/notes/NoteEditorSurface.svelte, packages/ui/src/components/calendar/GridColumn.svelte, and apps/web/src/routes/settings/appearance/BackgroundGroup.svelte.

This scan includes apps/web/src/calternal-app.css and packages/editor/src, while the earlier issue count excluded the app stylesheet. The prior Markdown audit docs/audits/consistency-237.md has no comparable numeric baseline, so I do not report a delta. The counts and file list are source leads for the existing token migration, not a replacement for its visual review.

The scan of dev at `c9ec6aff84a9ec810124a2cfbdd07c189eea1b9c` found 194 pixel `border-radius` declarations, 107 unitless `line-height` declarations, 60 numeric `letter-spacing` declarations, 11 numeric `font-size` declarations, and 59 `box-shadow` declarations with literal pixel geometry. Top sources include `apps/web/src/lib/files/PublicLinkPage.svelte`, `apps/web/src/lib/search/SearchPreview.svelte`, `apps/web/src/lib/notes/NoteEditorSurface.svelte`, `packages/ui/src/components/calendar/GridColumn.svelte`, and `apps/web/src/routes/settings/appearance/BackgroundGroup.svelte`. This scan includes `apps/web/src/calternal-app.css` and `packages/editor/src`, while the earlier issue count excluded the app stylesheet. The prior Markdown audit `docs/audits/consistency-237.md` has no comparable numeric baseline, so I do not report a delta. The counts and file list are source leads for the existing token migration, not a replacement for its visual review.

kayg referenced this issue

2026-09-28 08:13:57 +00:00

TOAST: more room between the message and its action; slightly larger message text #317

kayg referenced this issue

2026-09-28 08:31:30 +00:00

AUDIT: app-wide chrome consistency (headers, blur, breadcrumbs, pills, links, type scale) #237

kayg commented

2026-09-29 04:36:46 +00:00

Author

Owner

Starting #299 on branch job/tokens-literals, based on dev at 00015e652a153485d9e7adda1c5ee61bc17300db. The #287 token migration is already in dev. I am auditing the authored UI declarations and the existing token guard before making the mechanical role-token migration.

Starting #299 on branch `job/tokens-literals`, based on dev at `00015e652a153485d9e7adda1c5ee61bc17300db`. The #287 token migration is already in dev. I am auditing the authored UI declarations and the existing token guard before making the mechanical role-token migration.

kayg commented

2026-09-29 04:40:03 +00:00

Author

Owner

Finding: the existing check-type-tokens.mjs scans apps/web/src and packages/ui/src, but not packages/editor/src. The editor already has an authored numeric radius (packages/editor/src/components/CalloutView.svelte:96), so extending the guard only across the existing roots would leave part of the UI unprotected. I will add the editor source root and migrate its declaration.

Finding: the existing `check-type-tokens.mjs` scans `apps/web/src` and `packages/ui/src`, but not `packages/editor/src`. The editor already has an authored numeric radius (`packages/editor/src/components/CalloutView.svelte:96`), so extending the guard only across the existing roots would leave part of the UI unprotected. I will add the editor source root and migrate its declaration.

kayg commented

2026-09-29 04:43:18 +00:00

Author

Owner

Correction to the finding line number: the literal in packages/editor/src/components/CalloutView.svelte is at line 97 in the raw file.

Correction to the finding line number: the literal in `packages/editor/src/components/CalloutView.svelte` is at line 97 in the raw file.

kayg commented

2026-09-29 04:49:31 +00:00

Author

Owner

Finding: the shared token file and the app root define the same radius roles at different values. For example, packages/ui/src/tokens.css sets --radius-card: 20px and --radius-glass: 24px, while apps/web/src/calternal-app.css overrides them with 17px and 22px; it also owns the menu, sheet, and glass-row radius tokens. I will move the active app values into the shared token file and remove the duplicate app definitions, so all components read one role value and the existing app appearance stays stable.

Finding: the shared token file and the app root define the same radius roles at different values. For example, `packages/ui/src/tokens.css` sets `--radius-card: 20px` and `--radius-glass: 24px`, while `apps/web/src/calternal-app.css` overrides them with 17px and 22px; it also owns the menu, sheet, and glass-row radius tokens. I will move the active app values into the shared token file and remove the duplicate app definitions, so all components read one role value and the existing app appearance stays stable.

kayg commented

2026-09-29 05:04:13 +00:00

Author

Owner

Decision: I kept existing HIG type-role tokens for declarations with a text role. UI declarations without a sized text role now use shared leading roles: single (1), tight (the HIG title-1 leading), UI (1.35), body (1.5), and prose (1.6). Tracking uses default, label, and caps roles alongside the existing title and stat roles. The DESIGN file does not set values for the non-size-role leading scale, so this migration uses the repeated authored UI values as the shared role values.

The migration and guard follow the three properties in the issue title: border radius, line height, and letter spacing. The existing font-size guard remains in place.

Decision: I kept existing HIG type-role tokens for declarations with a text role. UI declarations without a sized text role now use shared leading roles: single (1), tight (the HIG title-1 leading), UI (1.35), body (1.5), and prose (1.6). Tracking uses default, label, and caps roles alongside the existing title and stat roles. The DESIGN file does not set values for the non-size-role leading scale, so this migration uses the repeated authored UI values as the shared role values. The migration and guard follow the three properties in the issue title: border radius, line height, and letter spacing. The existing font-size guard remains in place.

kayg commented

2026-09-29 06:57:58 +00:00

Author

Owner

Finding: the first production HIG capture failed its requested theme assertion. After setTheme wrote light to local storage, the authenticated page reported data-mode=system; the app hydrates the scheme from the server-backed appearance setting on navigation. I am updating the HIG capture path to save the scheme through the existing /api/v1/appearance endpoint before capture. This changes the screenshot setup only; it does not add or change a product API.

Finding: the first production HIG capture failed its requested theme assertion. After `setTheme` wrote `light` to local storage, the authenticated page reported `data-mode=system`; the app hydrates the scheme from the server-backed appearance setting on navigation. I am updating the HIG capture path to save the scheme through the existing `/api/v1/appearance` endpoint before capture. This changes the screenshot setup only; it does not add or change a product API.

kayg commented

2026-09-29 07:06:35 +00:00

Author

Owner

Finding: the first theme-persistence retry reached the tablet page while it was still about:blank, so its relative appearance request could not resolve (Failed to parse URL from /api/v1/appearance). The HIG capture now opens the tablet page on the local app before setting the theme. I also added a focused --hig-only option so this review capture does not first traverse the unrelated route matrix.

Finding: the first theme-persistence retry reached the tablet page while it was still `about:blank`, so its relative appearance request could not resolve (`Failed to parse URL from /api/v1/appearance`). The HIG capture now opens the tablet page on the local app before setting the theme. I also added a focused `--hig-only` option so this review capture does not first traverse the unrelated route matrix.

kayg commented

2026-09-29 07:08:56 +00:00

Author

Owner

Finding: the focused rerun captured the 1440 px and 820 px HIG screens, then failed when it reached the 390 px page, which was also still about:blank. The relative appearance request could not resolve from that page. I am adding one origin check for every HIG page before persisting the theme, covering both the new tablet page and the existing phone page.

Finding: the focused rerun captured the 1440 px and 820 px HIG screens, then failed when it reached the 390 px page, which was also still `about:blank`. The relative appearance request could not resolve from that page. I am adding one origin check for every HIG page before persisting the theme, covering both the new tablet page and the existing phone page.

kayg commented

2026-09-29 07:12:22 +00:00

Author

Owner

Update: the focused production screenshot run passed with LAYOUT SWEEP PASSED and CSP REPORTS layout-sweep: 0 across 3 pages. It saved 36 screenshots under artifacts/tokens-literals-299/: Files, Calendar, Note, Settings, the tray, and pills at 390, 820, and 1440 CSS px in Paper and Tokyo Night. The runner saved the requested scheme to the authenticated test User and asserted data-mode, data-theme, and is-dark before each capture. Harness fix commit: 8451ea72.

Update: the focused production screenshot run passed with `LAYOUT SWEEP PASSED` and `CSP REPORTS layout-sweep: 0 across 3 pages`. It saved 36 screenshots under `artifacts/tokens-literals-299/`: Files, Calendar, Note, Settings, the tray, and pills at 390, 820, and 1440 CSS px in Paper and Tokyo Night. The runner saved the requested scheme to the authenticated test User and asserted `data-mode`, `data-theme`, and `is-dark` before each capture. Harness fix commit: `8451ea72`.

kayg commented

2026-09-29 07:20:30 +00:00

Author

Owner

Finding: after the merged-build capture asserted both schemes at 1440 and 820 px, the first 390 px Paper capture resolved data-theme=tokyo-night-day instead of paper. The 820 px tablet page shares the phone browser context, and stayed open while the phone page changed schemes. I am closing the tablet page after its captures before reusing that context for phone screenshots.

Finding: after the merged-build capture asserted both schemes at 1440 and 820 px, the first 390 px Paper capture resolved `data-theme=tokyo-night-day` instead of `paper`. The 820 px tablet page shares the phone browser context, and stayed open while the phone page changed schemes. I am closing the tablet page after its captures before reusing that context for phone screenshots.

kayg commented

2026-09-29 11:32:39 +00:00

Author

Owner

Finished #299 on job/tokens-literals.

Built

Added shared shape, leading, and tracking roles. Migrated authored border-radius, line-height, and letter-spacing values across the web app, UI package, and editor package.
Extended check-type-tokens.mjs to scan all three source trees and reject direct literals for those properties.
Added Analytics to the production HIG screenshot set. Theme state is asserted before each capture.
Kept the Analytics comparison chip radius inside Pill; the inner loading bar uses the shared --radius-circle role.

Files

packages/ui/src/tokens.css
apps/web/scripts/check-type-tokens.mjs
apps/web/e2e/layout-sweep.mjs
apps/web/src styles, packages/ui/src styles, and packages/editor/src styles
apps/web/src/lib/components/analytics/widgets/StatRow.svelte

Commits

Head: e62ad45abfaee0f08a70ee72d74832f02d5f6b3d
Pushed to origin/job/tokens-literals.

Gate output

cargo fmt --check: no output; exit 0.
cargo clippy --all-targets -- -D warnings:

Finished `dev` profile [unoptimized + debuginfo] target(s) in 35m 22s

cargo test stopped in calternal-search on this existing concurrency test:

thread 'indexer::tests::staged_publication_waits_for_search_readers_before_swapping_directories' panicked at crates/calternal-search/src/indexer.rs:2817:13:
staged publication did not wait for the active Search reader
test result: FAILED. 32 passed; 1 failed; 1 ignored; 0 measured; 0 filtered out; finished in 14.56s
error: test failed, to rerun pass `-p calternal-search --lib`

bun run check: Text sizes and UI shape values use shared role tokens.; svelte-check found 0 errors and 0 warnings.
bun run test: Test Files 123 passed (123); Tests 787 passed (787).
Production HIG capture:

CSP REPORTS layout-sweep: 0 across 3 pages
checked 0 screens
LAYOUT SWEEP PASSED

The capture used --hig-only, so the normal route sweep count is zero. It produced 42 PNGs in artifacts/tokens-literals-299/, with light and dark themes at 390, 820, and 1440 CSS pixels. The archive is attached: Download the 42 screenshots.

Decisions

DESIGN.md defines type sizes, but it does not define the non-size line-height and tracking roles. I used repeated authored values: --leading-single: 1, --leading-tight: var(--text-title-1-leading), --leading-ui: 1.35, --leading-body: 1.5, --leading-prose: 1.6; tracking roles are default 0, label .02em, and caps .04em. Existing HIG type roles remain the source for size-specific metrics.
The loading bar uses --radius-circle because its 50% radius keeps a capsule shape at any width. Pill owns the enclosing chip radius.
The AccountRow merge conflict kept dev's centered icon alignment and retained the body-leading role on the name.

Known gaps

The workspace test stopped at the calternal-search concurrency test above. The test waits up to five seconds for the rebuild writer to reach the query lock. No files in that crate changed in this job; I left its expectation unchanged and did not rerun the workspace gate.
The first clippy session ended with exit 130 during dependency compilation. The live-output rerun completed successfully.
The production build completed with existing use client module-directive warnings.
No API changed, so an adversarial API round was not needed.
cargo clean completed. apps/web/build and apps/web/.svelte-kit were removed.

Finished #299 on `job/tokens-literals`. **Built** - Added shared shape, leading, and tracking roles. Migrated authored `border-radius`, `line-height`, and `letter-spacing` values across the web app, UI package, and editor package. - Extended `check-type-tokens.mjs` to scan all three source trees and reject direct literals for those properties. - Added Analytics to the production HIG screenshot set. Theme state is asserted before each capture. - Kept the Analytics comparison chip radius inside `Pill`; the inner loading bar uses the shared `--radius-circle` role. **Files** - `packages/ui/src/tokens.css` - `apps/web/scripts/check-type-tokens.mjs` - `apps/web/e2e/layout-sweep.mjs` - `apps/web/src` styles, `packages/ui/src` styles, and `packages/editor/src` styles - `apps/web/src/lib/components/analytics/widgets/StatRow.svelte` **Commits** - Head: `e62ad45abfaee0f08a70ee72d74832f02d5f6b3d` - Pushed to `origin/job/tokens-literals`. **Gate output** - `cargo fmt --check`: no output; exit 0. - `cargo clippy --all-targets -- -D warnings`: ```text Finished `dev` profile [unoptimized + debuginfo] target(s) in 35m 22s ``` - `cargo test` stopped in `calternal-search` on this existing concurrency test: ```text thread 'indexer::tests::staged_publication_waits_for_search_readers_before_swapping_directories' panicked at crates/calternal-search/src/indexer.rs:2817:13: staged publication did not wait for the active Search reader test result: FAILED. 32 passed; 1 failed; 1 ignored; 0 measured; 0 filtered out; finished in 14.56s error: test failed, to rerun pass `-p calternal-search --lib` ``` - `bun run check`: `Text sizes and UI shape values use shared role tokens.`; `svelte-check found 0 errors and 0 warnings`. - `bun run test`: `Test Files 123 passed (123)`; `Tests 787 passed (787)`. - Production HIG capture: ```text CSP REPORTS layout-sweep: 0 across 3 pages checked 0 screens LAYOUT SWEEP PASSED ``` The capture used `--hig-only`, so the normal route sweep count is zero. It produced 42 PNGs in `artifacts/tokens-literals-299/`, with light and dark themes at 390, 820, and 1440 CSS pixels. The archive is attached: [Download the 42 screenshots](https://git.kayg.org/attachments/baf481e8-f137-4dbc-98b6-d30d3df0a01e). **Decisions** - `DESIGN.md` defines type sizes, but it does not define the non-size line-height and tracking roles. I used repeated authored values: `--leading-single: 1`, `--leading-tight: var(--text-title-1-leading)`, `--leading-ui: 1.35`, `--leading-body: 1.5`, `--leading-prose: 1.6`; tracking roles are default `0`, label `.02em`, and caps `.04em`. Existing HIG type roles remain the source for size-specific metrics. - The loading bar uses `--radius-circle` because its 50% radius keeps a capsule shape at any width. `Pill` owns the enclosing chip radius. - The AccountRow merge conflict kept `dev`'s centered icon alignment and retained the body-leading role on the name. **Known gaps** - The workspace test stopped at the `calternal-search` concurrency test above. The test waits up to five seconds for the rebuild writer to reach the query lock. No files in that crate changed in this job; I left its expectation unchanged and did not rerun the workspace gate. - The first clippy session ended with exit 130 during dependency compilation. The live-output rerun completed successfully. - The production build completed with existing `use client` module-directive warnings. - No API changed, so an adversarial API round was not needed. - `cargo clean` completed. `apps/web/build` and `apps/web/.svelte-kit` were removed.

kayg commented

2026-09-29 18:35:45 +00:00

Author

Owner

Starting merge-only resume on branch job/tokens-literals. Base SHA (merge-base with origin/dev before fetch): c465150468. Current HEAD: e62ad45abf.

Starting merge-only resume on branch job/tokens-literals. Base SHA (merge-base with origin/dev before fetch): c46515046871936ad681c4d00e8b76de69dde3b7. Current HEAD: e62ad45abfaee0f08a70ee72d74832f02d5f6b3d.

kayg commented

2026-09-29 18:36:21 +00:00

Author

Owner

Finding after fetching origin/dev at 369ab6a2: dev deletes apps/web/src/routes/settings/parts/AccountRow.svelte and SettingsGroup.svelte and adds SettingsCard.svelte and SettingsRow.svelte. The merge also conflicts in layout-sweep, PublicLinkPage, NoteEditorSurface, PhotoTimeline, JobDetails and FileSelectionCheckbox; I’m resolving each from dev’s current behavior while retaining shared leading/radius tokens.

Finding after fetching origin/dev at 369ab6a2: dev deletes apps/web/src/routes/settings/parts/AccountRow.svelte and SettingsGroup.svelte and adds SettingsCard.svelte and SettingsRow.svelte. The merge also conflicts in layout-sweep, PublicLinkPage, NoteEditorSurface, PhotoTimeline, JobDetails and FileSelectionCheckbox; I’m resolving each from dev’s current behavior while retaining shared leading/radius tokens.

kayg commented

2026-09-29 18:40:44 +00:00

Author

Owner

Finding: the first post-merge token-guard run found numeric radii, leading and tracking declarations in the merged PublicLinkPage, NoteEditorSurface, PhotoTimeline, SettingsCard/SettingsRow, JobDetails, Checkbox and calendar components. I mapped those declarations to the shared role tokens (including the replacements for deleted AccountRow and SettingsGroup). The rerun passed: Text sizes and UI shape values use shared role tokens.

kayg referenced this issue from a commit

2026-09-29 18:50:12 +00:00

Merge origin/dev and preserve #299 token roles

kayg referenced this issue from a commit

2026-09-29 19:01:12 +00:00

docs: record #299 token roles in touched UI modules

kayg commented

2026-09-29 20:08:35 +00:00

Author

Owner

Finding after merge: apps/web/e2e/layout-sweep.mjs retains --hig, but it no longer accepts the earlier --hig-only mode. A --hig run therefore also enters the full three-width route matrix before saving the 42-screen HIG set. I am restoring an opt-in capture-only flag so the requested post-merge production evidence runs the same set without changing the normal layout sweep.

Finding after merge: `apps/web/e2e/layout-sweep.mjs` retains `--hig`, but it no longer accepts the earlier `--hig-only` mode. A `--hig` run therefore also enters the full three-width route matrix before saving the 42-screen HIG set. I am restoring an opt-in capture-only flag so the requested post-merge production evidence runs the same set without changing the normal layout sweep.

kayg commented

2026-09-30 01:01:54 +00:00

Author

Owner

Resuming the accepted token migration on job/tokens-literals. Worktree HEAD before merge: 3b3cb33262. Refreshed base: origin/dev at 55a2f90feb. I will preserve current dev behavior and reapply the token guard to replacement components where needed.

Resuming the accepted token migration on job/tokens-literals. Worktree HEAD before merge: 3b3cb33262a7ac4ba8973aecbd5d4f5d5b960ebd. Refreshed base: origin/dev at 55a2f90feb8a52d91f8bbc1347889b509af02260. I will preserve current dev behavior and reapply the token guard to replacement components where needed.

kayg commented

2026-09-30 01:02:48 +00:00

Author

Owner

Post-merge finding at origin/dev 55a2f90: the guard still finds three 50% radii in the new MailView and one 999px radius in the changed calendar AgendaList. These are role-equivalent circular and pill radii; I will map them to the existing shape tokens and rerun the guard across the complete scanned source roots.

Post-merge finding at origin/dev 55a2f90: the guard still finds three 50% radii in the new MailView and one 999px radius in the changed calendar AgendaList. These are role-equivalent circular and pill radii; I will map them to the existing shape tokens and rerun the guard across the complete scanned source roots.

kayg commented

2026-09-30 03:42:57 +00:00

Author

Owner

Resume started on job/tokens-literals at 04a199a1f7; worktree clean. I will merge origin/dev and reapply the #299 token rules to current replacements.

Resume started on job/tokens-literals at 04a199a1f7945c871279c862e6411e5d4082887f; worktree clean. I will merge origin/dev and reapply the #299 token rules to current replacements.

kayg commented

2026-09-30 03:45:17 +00:00

Author

Owner

Finding after the latest origin/dev merge: the #299 guard reports one newly merged authored literal, apps/web/src/lib/files/FilesBrowser.svelte:1424 () in the upload-conflict message. I will use the existing role; SettingsCard and SettingsRow plus the named merge-resolved files currently use shared role tokens.

kayg commented

2026-09-30 03:45:39 +00:00

Author

Owner

Correction: the guard finding is the numeric declaration line-height 1.5 at apps/web/src/lib/files/FilesBrowser.svelte:1424. It is now mapped to the existing body-leading role. The earlier comment formatter stripped inline code marks and their contents.

kayg commented

2026-09-30 03:47:40 +00:00

Author

Owner

Finding: bun run check reached Svelte validation and reported 15 diagnostics in three newly merged Money test files because fast-check is declared but absent from node_modules. I will install from the committed bun.lock with frozen lockfile, then rerun the check.

kayg commented

2026-09-30 03:57:35 +00:00

Author

Owner

Correction: libstdc++6 is installed. Bun cannot dlopen the Sharp 0.34.5 native module on this host, while Node 22 loads Sharp successfully. I will run the unchanged production capture script under Node.

kayg commented

2026-09-30 03:57:55 +00:00

Author

Owner

Finding: Node loads Sharp, but the production HIG runner then reports that target/debug/calternal-server is absent after the earlier cargo clean. I will build calternal-server as capture fixture infrastructure before retrying the unchanged script.

kayg commented

2026-09-30 04:17:00 +00:00

Author

Owner

Consistency-hunt update from dev at dfb5964a2fcf13dc8b9a50a319eee09bc386f322 (2026-09-30). The source scan found 197 direct pixel radius declarations (previous report: 194, +3), 109 unitless line-height declarations (107, +2), 41 tracking declarations (60, -19), 71 box-shadow declarations with pixel geometry (59, +12), and 0 numeric font-size declarations (11, -11). High counts remain in apps/web/src/lib/files/PublicLinkPage.svelte (9 radii), apps/web/src/lib/search/SearchPreview.svelte (9), apps/web/src/lib/notes/NoteEditorSurface.svelte (7), and packages/ui/src/components/files/FileCollection.svelte (8).

Rule: use shared role tokens and one rem type scale. Please keep the mapping in the existing owner file, packages/ui/src/tokens.css; keep local values only when no role token fits. These are source candidates, not proof that every local drawing value should become a token.

Consistency-hunt update from `dev` at `dfb5964a2fcf13dc8b9a50a319eee09bc386f322` (2026-09-30). The source scan found 197 direct pixel radius declarations (previous report: 194, +3), 109 unitless line-height declarations (107, +2), 41 tracking declarations (60, -19), 71 box-shadow declarations with pixel geometry (59, +12), and 0 numeric font-size declarations (11, -11). High counts remain in `apps/web/src/lib/files/PublicLinkPage.svelte` (9 radii), `apps/web/src/lib/search/SearchPreview.svelte` (9), `apps/web/src/lib/notes/NoteEditorSurface.svelte` (7), and `packages/ui/src/components/files/FileCollection.svelte` (8). Rule: use shared role tokens and one rem type scale. Please keep the mapping in the existing owner file, `packages/ui/src/tokens.css`; keep local values only when no role token fits. These are source candidates, not proof that every local drawing value should become a token.

kayg commented

2026-09-30 05:00:41 +00:00

Author

Owner

Completed the merge-only resume on branch job/tokens-literals.

Built

Merged origin/dev at dfb5964a2f. The merge commit is 4ac097d0d8. The current dev behavior is preserved in the settings replacements and the files named in the resume instructions.
The post-merge token guard found one new literal in apps/web/src/lib/files/FilesBrowser.svelte:1424. Replaced line-height 1.5 with var(--leading-body); this keeps the existing leading value and lets the shared role own it.
Confirmed SettingsCard, SettingsRow, layout-sweep.mjs, PublicLinkPage, NoteEditorSurface, PhotoTimeline, JobDetails and FileSelectionCheckbox use shared shape/leading/tracking roles. No glass alpha or blur tokens changed.
Rebuilt the production web app and captured the same 42-image HIG set: Files, Calendar, Note, Settings, Analytics, tray and pills at 390, 820 and 1440 px in Paper and Tokyo Night. Archive: Download the 42 screenshots. Local copy: artifacts/tokens-literals-299.tar.gz.

Files

Additional resume code change: apps/web/src/lib/files/FilesBrowser.svelte.
The previously accepted token migration and guard remain in the existing #299 commits.

Head SHA

957cc1f5a1

Gate output

bun run check:

Text sizes and UI shape values use shared role tokens.
Loading svelte-check in workspace: /home/kayg/Developer/calternal-wt/tokens-literals/apps/web
Getting Svelte diagnostics...

svelte-check found 0 errors and 0 warnings

bun run test:

 Test Files  136 passed (136)
      Tests  877 passed (877)
   Start at  05:50:08
   Duration  152.59s (transform 47%, environment 23%, import 15%, tests 11%, setup 5%)

Production web build:

✓ built in 1m 2s
> Using @sveltejs/adapter-static
  Wrote site to "build"
  ✔ done

Production HIG capture:

CSP REPORTS layout-sweep: 0 across 3 pages
checked 0 screens
LAYOUT SWEEP PASSED

Capture fixture build:

Finished `dev` profile [unoptimized + debuginfo] target(s) in 47m 28s

Cleanup:

Removed 7081 files, 4.4GiB total
Removing apps/web/.svelte-kit/
Removing apps/web/build/

Known gaps

The focused --hig-only run skips the ordinary route matrix, so it reports checked 0 screens. It did produce the full 42-image HIG set requested.
Bun could not dlopen Sharp 0.34.5 on this host. Node 22 loaded Sharp, and the unchanged capture script passed under Node.
The first check attempt found fast-check missing from node_modules. bun install --frozen-lockfile installed the committed dependencies; the rerun passed without changing bun.lock.
Vitest emitted jsdom CSS parsing and scrollTo-not-implemented warnings; all 877 tests passed. The production build also emitted existing use-client module-directive warnings from vendored analytics sources.
No Rust source changed. Rust fmt/clippy/test gates were not run. cargo build -p calternal-server was used only to supply the production capture server.

Decisions

Reused the existing --leading-body role for the merged 1.5 leading value. No new design decision was needed.

Completed the merge-only resume on branch job/tokens-literals. **Built** - Merged origin/dev at dfb5964a2fcf13dc8b9a50a319eee09bc386f322. The merge commit is 4ac097d0d8c309e7fbfcebff754636520469e0bc. The current dev behavior is preserved in the settings replacements and the files named in the resume instructions. - The post-merge token guard found one new literal in apps/web/src/lib/files/FilesBrowser.svelte:1424. Replaced line-height 1.5 with var(--leading-body); this keeps the existing leading value and lets the shared role own it. - Confirmed SettingsCard, SettingsRow, layout-sweep.mjs, PublicLinkPage, NoteEditorSurface, PhotoTimeline, JobDetails and FileSelectionCheckbox use shared shape/leading/tracking roles. No glass alpha or blur tokens changed. - Rebuilt the production web app and captured the same 42-image HIG set: Files, Calendar, Note, Settings, Analytics, tray and pills at 390, 820 and 1440 px in Paper and Tokyo Night. Archive: [Download the 42 screenshots](https://git.kayg.org/attachments/f2e109c9-60b8-4312-8d80-2d3d0161c0da). Local copy: artifacts/tokens-literals-299.tar.gz. **Files** - Additional resume code change: apps/web/src/lib/files/FilesBrowser.svelte. - The previously accepted token migration and guard remain in the existing #299 commits. **Head SHA** 957cc1f5a151646581b9c0b0391125319ebcf095 **Gate output** bun run check: ```text Text sizes and UI shape values use shared role tokens. Loading svelte-check in workspace: /home/kayg/Developer/calternal-wt/tokens-literals/apps/web Getting Svelte diagnostics... svelte-check found 0 errors and 0 warnings ``` bun run test: ```text Test Files 136 passed (136) Tests 877 passed (877) Start at 05:50:08 Duration 152.59s (transform 47%, environment 23%, import 15%, tests 11%, setup 5%) ``` Production web build: ```text ✓ built in 1m 2s > Using @sveltejs/adapter-static Wrote site to "build" ✔ done ``` Production HIG capture: ```text CSP REPORTS layout-sweep: 0 across 3 pages checked 0 screens LAYOUT SWEEP PASSED ``` Capture fixture build: ```text Finished `dev` profile [unoptimized + debuginfo] target(s) in 47m 28s ``` Cleanup: ```text Removed 7081 files, 4.4GiB total Removing apps/web/.svelte-kit/ Removing apps/web/build/ ``` **Known gaps** - The focused --hig-only run skips the ordinary route matrix, so it reports checked 0 screens. It did produce the full 42-image HIG set requested. - Bun could not dlopen Sharp 0.34.5 on this host. Node 22 loaded Sharp, and the unchanged capture script passed under Node. - The first check attempt found fast-check missing from node_modules. bun install --frozen-lockfile installed the committed dependencies; the rerun passed without changing bun.lock. - Vitest emitted jsdom CSS parsing and scrollTo-not-implemented warnings; all 877 tests passed. The production build also emitted existing use-client module-directive warnings from vendored analytics sources. - No Rust source changed. Rust fmt/clippy/test gates were not run. cargo build -p calternal-server was used only to supply the production capture server. **Decisions** - Reused the existing --leading-body role for the merged 1.5 leading value. No new design decision was needed.

kayg commented

2026-09-30 05:07:36 +00:00

Author

Owner

Merged into dev at 2bd689029 (web gates on the merged tree: 0 errors, 881/881 tests).

Merged into dev at 2bd689029 (web gates on the merged tree: 0 errors, 881/881 tests).

kayg referenced this issue from a commit

2026-09-30 05:07:37 +00:00

Merge job/tokens-literals (#299: role tokens replace numeric style literals across 124 files; guard passes)

kayg referenced this issue

2026-09-30 07:18:52 +00:00

AUDIT: app-wide chrome consistency (headers, blur, breadcrumbs, pills, links, type scale) #237

kayg referenced this issue

2026-09-30 09:30:41 +00:00

Owner test tracker: every request and when it is testable on o2 #203

kayg commented

2026-10-03 11:55:31 +00:00

Author

Owner

Fixed in 2bd689029 (origin/dev); the token migration and guard cover the shared UI role values.

Fixed in 2bd689029 (origin/dev); the token migration and guard cover the shared UI role values.

kayg closed this issue

2026-10-03 11:55:31 +00:00

kayg referenced this issue

2026-10-03 12:04:41 +00:00

Issue hygiene sweep 2026-10-03 #1008

Rows
Columns

TOKENS: replace hard-coded radii, line heights and letter spacing with shared tokens (after #287) #299