CALENDAR: Attach and Record voice in the item preview actions (reuse the composer's tray and recorder)

kayg commented

2026-09-28 07:05:49 +00:00

Owner

Owner (2026-09-28, screenshot of the Calendar selection preview's action pill: Copy link · Edit · Delete): 'we need two more buttons here → an attachment icon and a mic icon that lets me record my thoughts.'

Where: packages/ui/src/components/calendar/ItemPreview.svelte, the PillGroup action row (log entries; do the same for events and tasks where the item can carry attachments).

Build (reuse gate: no second upload or recorder implementation):

Attach (Paperclip icon, tooltip 'Attach file', shortcut in the registry): opens the file picker (and accepts drag-and-drop onto the preview). It uploads with the composer's AttachmentTray (apps/web/src/lib/composer/attachments.svelte.ts) and appends the files to the item, the same way the composer attaches them on create (Attachments/ in Home; the log entry's attachment list in the day file via calternal-notes-core dayfile). The preview's attachment deck updates in place (no reload; see #298 for the live-update bug).
Record (Mic icon, tooltip 'Record voice note'): records with the composer's VoiceRecorder (recorder.svelte.ts: the same MIME choice, 30-min cap, states) and shows the composer's recording bar inside the preview (Stop / Keep / Discard; reuse the component; extract it from Composer.svelte if it is inline). Keep attaches the audio to the item as an attachment. Transcription is out of scope here (see the local transcription research issue); leave a clean hook.
Order in the pill: Copy link · Attach · Record · Edit · Delete (destructive last). Icons only, with the warm tooltips; cap-height alignment (#253).
If an API to append attachments to an existing item is missing, add one on the server (single writer, calternal-fs, size limits), regenerate the OpenAPI and the client, and extend tests/adversarial (oversized, hostile names, concurrent appends, appending to a deleted item).
Accessibility: labelled buttons, a live region for recording state and elapsed time, Esc cancels the recording with a confirm, touch hit targets, reduced motion.
Phone: the same actions in the item sheet.
Evidence: screenshots of the pill, the recording state and the deck after attaching; light and dark; desktop and phone.

Owner (2026-09-28, screenshot of the Calendar selection preview's action pill: Copy link · Edit · Delete): 'we need two more buttons here → an attachment icon and a mic icon that lets me record my thoughts.' Where: `packages/ui/src/components/calendar/ItemPreview.svelte`, the `PillGroup` action row (log entries; do the same for events and tasks where the item can carry attachments). Build (reuse gate: no second upload or recorder implementation): - **Attach** (Paperclip icon, tooltip 'Attach file', shortcut in the registry): opens the file picker (and accepts drag-and-drop onto the preview). It uploads with the composer's `AttachmentTray` (`apps/web/src/lib/composer/attachments.svelte.ts`) and appends the files to the item, the same way the composer attaches them on create (`Attachments/` in Home; the log entry's attachment list in the day file via calternal-notes-core dayfile). The preview's attachment deck updates in place (no reload; see #298 for the live-update bug). - **Record** (Mic icon, tooltip 'Record voice note'): records with the composer's `VoiceRecorder` (`recorder.svelte.ts`: the same MIME choice, 30-min cap, states) and shows the composer's recording bar inside the preview (Stop / Keep / Discard; reuse the component; extract it from Composer.svelte if it is inline). Keep attaches the audio to the item as an attachment. Transcription is out of scope here (see the local transcription research issue); leave a clean hook. - Order in the pill: Copy link · Attach · Record · Edit · Delete (destructive last). Icons only, with the warm tooltips; cap-height alignment (#253). - If an API to append attachments to an existing item is missing, add one on the server (single writer, calternal-fs, size limits), regenerate the OpenAPI and the client, and extend tests/adversarial (oversized, hostile names, concurrent appends, appending to a deleted item). - Accessibility: labelled buttons, a live region for recording state and elapsed time, Esc cancels the recording with a confirm, touch hit targets, reduced motion. - Phone: the same actions in the item sheet. Evidence: screenshots of the pill, the recording state and the deck after attaching; light and dark; desktop and phone.

preview-deck-light-1440.png

538 KiB

preview-deck-dark-1440.png

423 KiB

preview-recording-light-1440.png

540 KiB

preview-recording-dark-1440.png

426 KiB

preview-deck-light-390.png

66 KiB

preview-deck-dark-390.png

76 KiB

preview-recording-light-390.png

69 KiB

preview-recording-dark-390.png

79 KiB

preview-idle-matrix.png

1.3 MiB

preview-inline-morph-strip.png

138 KiB

composer-idle-matrix.png

566 KiB

preview-recording-matrix.png

1.1 MiB

composer-recording-matrix.png

582 KiB

composer-after-keep-matrix.png

593 KiB

preview-after-keep-matrix.png

1.1 MiB

composer-recording-matrix.png

582 KiB

preview-idle-matrix.png

1 MiB

preview-after-keep-matrix.png

1.1 MiB

composer-idle-matrix.png

678 KiB

composer-recording-matrix.png

584 KiB

composer-after-keep-matrix.png

595 KiB

preview-inline-morph-strip.png

147 KiB

preview-recording-matrix.png

1.1 MiB

calendar-week-matrix.png

1.1 MiB

calendar-today-matrix.png

1.4 MiB

calendar-day-matrix.png

1.1 MiB

calendar-week-matrix.png

1.1 MiB

calendar-month-matrix.png

1.3 MiB

preview-idle-matrix.png

1.1 MiB

preview-recording-matrix.png

1.1 MiB

preview-after-keep-matrix.png

1.1 MiB

composer-idle-matrix.png

571 KiB

composer-recording-matrix.png

585 KiB

composer-after-keep-matrix.png

598 KiB

preview-inline-morph-strip.png

79 KiB

calendar-week-parity-light-1440.png

632 KiB

calendar-week-parity-dark-1440.png

507 KiB

calendar-edge-left-selected-light-1440.png

521 KiB

calendar-edge-left-selected-dark-1440.png

429 KiB

calendar-edge-right-selected-light-1440.png

522 KiB

calendar-edge-right-selected-dark-1440.png

431 KiB

search-calendar-selected-light-390.png

62 KiB

search-calendar-selected-dark-390.png

77 KiB

search-calendar-selected-light-1440.png

117 KiB

search-calendar-selected-dark-1440.png

151 KiB

search-results-selected-light-820.png

85 KiB

search-results-selected-dark-820.png

105 KiB

kayg commented

2026-09-28 07:49:19 +00:00

Author

Owner

Starting #303 on job/preview-attach, based on dev at 6c1e5062c781feb87a85a70825a69661239bc855. I am checking the existing preview, composer attachment tray and voice recorder, plus the API path for appending attachments before making a focused implementation.

Starting #303 on `job/preview-attach`, based on `dev` at `6c1e5062c781feb87a85a70825a69661239bc855`. I am checking the existing preview, composer attachment tray and voice recorder, plus the API path for appending attachments before making a focused implementation.

kayg commented

2026-09-28 07:56:21 +00:00

Author

Owner

Finding: the Notes API validates and writes attachments only in POST /api/v1/notes/journal/log; there is no route to append after creation (rg of the journal handlers/routes confirms this). The Calendar preview model has an attachment deck for Log entries; CalendarTask and CalendarEvent currently have no attachment collection in that model. I will add the Log append route and wire Attach/Record for Log previews. Uploads will keep using AttachmentTray's current type routing: DESIGN §40 removes Attachments/ and places voice memos in Documents/Voice memos/.

Finding: the Notes API validates and writes attachments only in `POST /api/v1/notes/journal/log`; there is no route to append after creation (`rg` of the journal handlers/routes confirms this). The Calendar preview model has an attachment deck for Log entries; CalendarTask and CalendarEvent currently have no attachment collection in that model. I will add the Log append route and wire Attach/Record for Log previews. Uploads will keep using AttachmentTray's current type routing: DESIGN §40 removes `Attachments/` and places voice memos in `Documents/Voice memos/`.

kayg referenced this issue

2026-09-28 08:42:20 +00:00

RESEARCH: local voice transcription and rewrite (Superwhisper-style) — on-device/on-server, no cloud (NO implementation) #304

kayg commented

2026-09-28 08:42:21 +00:00

Author

Owner

Owner (2026-09-28): the recording animation should reuse https://sveltebits.xyz/micro/voice-pill, refined with calternal's aesthetics (cherry-pick it into packages/ui as the shared recorder pill used by BOTH the composer and the item preview; motion tokens; reduced motion). If your branch already has the recorder bar extracted, apply it there; otherwise note it for a follow-up.

kayg commented

2026-09-28 08:44:09 +00:00

Author

Owner

Owner refinement (2026-09-28) on the recording UI: the mic icon expands inline into the animated recording pill. The mic button itself morphs (width morph with the #236/#291 spring, as the tab bar does) into the recording state in place: the waveform/level animation, the elapsed time, Stop/Keep/Discard. No overlay, no sheet, no separate bar, no extra chrome. Owner: 'no over-the-top crap. our design looks great as is.' Take only the voice-pill's core motion idea from sveltebits; keep calternal's existing pill look (the same PillGroup/glass, tokens, icon sizes). Collapse back into the mic on Stop/Keep/Discard. Reduced motion: an instant swap. The same component in the composer tools pill and the Calendar item-preview pill.

Owner refinement (2026-09-28) on the recording UI: **the mic icon expands inline into the animated recording pill**. The mic button itself morphs (width morph with the #236/#291 spring, as the tab bar does) into the recording state in place: the waveform/level animation, the elapsed time, Stop/Keep/Discard. No overlay, no sheet, no separate bar, no extra chrome. Owner: 'no over-the-top crap. our design looks great as is.' Take only the voice-pill's core motion idea from sveltebits; keep calternal's existing pill look (the same PillGroup/glass, tokens, icon sizes). Collapse back into the mic on Stop/Keep/Discard. Reduced motion: an instant swap. The same component in the composer tools pill and the Calendar item-preview pill.

kayg commented

2026-09-28 08:50:04 +00:00

Author

Owner

Progress on job/preview-attach (base 6c1e5062c781feb87a85a70825a69661239bc855): the Notes API had no append route for existing Journal Logs, and CalendarTask/CalendarEvent have no attachment collection. I added a checked, idempotent Log attachment append route and committed it as f5af97ad; cargo test -p calternal-plugin-notes passed (101 tests, 0 failures). UI work reuses Composer's AttachmentTray and VoiceRecorder/RecordingBar, updates the open preview and Agenda cache, and keeps a recording until its Log append succeeds. I added production-build Playwright coverage and screenshots for the preview action pill, recording bar and attachment deck. OpenAPI/client generation and the final gates remain.

Progress on `job/preview-attach` (base `6c1e5062c781feb87a85a70825a69661239bc855`): the Notes API had no append route for existing Journal Logs, and CalendarTask/CalendarEvent have no attachment collection. I added a checked, idempotent Log attachment append route and committed it as `f5af97ad`; `cargo test -p calternal-plugin-notes` passed (101 tests, 0 failures). UI work reuses Composer's AttachmentTray and VoiceRecorder/RecordingBar, updates the open preview and Agenda cache, and keeps a recording until its Log append succeeds. I added production-build Playwright coverage and screenshots for the preview action pill, recording bar and attachment deck. OpenAPI/client generation and the final gates remain.

kayg commented

2026-09-28 08:57:43 +00:00

Author

Owner

Finding and fix: the production E2E flow recorded an audio/webm File named *.webm, then found its appended Log link outside Documents/Voice memos/. kindForFile checked the shared media extension table first, which classified WebM as a photo. Audio MIME now takes precedence; attachments.test.ts covers audio WebM as a Voice memo and video WebM as a photo. Targeted result: 1 test file passed, 3 tests passed.

Finding and fix: the production E2E flow recorded an `audio/webm` File named `*.webm`, then found its appended Log link outside `Documents/Voice memos/`. `kindForFile` checked the shared media extension table first, which classified WebM as a photo. Audio MIME now takes precedence; `attachments.test.ts` covers audio WebM as a Voice memo and video WebM as a photo. Targeted result: 1 test file passed, 3 tests passed.

kayg commented

2026-09-28 10:00:45 +00:00

Author

Owner

Adversarial progress (2026-09-28): The required local round is still running. The Journal attachment cases completed without findings, including hostile targets, malformed and oversized JSON, retry idempotency, 12 concurrent appends, attachment de-duplication, and append after delete.

The round also found two unrelated consistency issues that I am recording separately: search_chaos.py observed four HTTP 200 queries that omitted the existing unicodenfcsentinel hit during a staged index rebuild; the editor browser probe (seed 25608414) found that undo/redo changed whitespace after a mixed paste and block-action sequence. I will file both findings after the round finishes.

Other API timeouts and 503 busy responses happened during sustained local fixture and concurrency load. I am collecting the runner’s final output before classifying them.

Adversarial progress (2026-09-28): The required local round is still running. The Journal attachment cases completed without findings, including hostile targets, malformed and oversized JSON, retry idempotency, 12 concurrent appends, attachment de-duplication, and append after delete. The round also found two unrelated consistency issues that I am recording separately: `search_chaos.py` observed four HTTP 200 queries that omitted the existing `unicodenfcsentinel` hit during a staged index rebuild; the editor browser probe (seed 25608414) found that undo/redo changed whitespace after a mixed paste and block-action sequence. I will file both findings after the round finishes. Other API timeouts and 503 busy responses happened during sustained local fixture and concurrency load. I am collecting the runner’s final output before classifying them.

kayg referenced this issue

2026-09-28 10:37:22 +00:00

PERF: search & indexing — stupid fast and reliable (targets, benchmark, fixes, chaos) #258

kayg referenced this issue

2026-09-28 10:37:23 +00:00

Adversarial editor undo/redo round trip loses note text #314

kayg referenced this issue

2026-09-28 10:37:24 +00:00

FOLLOW-UP from #235 adversarial round: DAV/Journal/bookmark timeouts, pasted-image undo duplication, 10k-block collab timeout #265

kayg referenced this issue

2026-09-28 10:37:25 +00:00

Calendar: aggregated range and year endpoints (server side of #39) #56

kayg referenced this issue

2026-09-28 10:37:26 +00:00

Search: hybrid keyword + semantic retrieval #59

kayg referenced this issue

2026-09-28 10:37:28 +00:00

Search: sources — PDF text extraction, events, bookmarks, tasks, tags in the index #58

kayg referenced this issue

2026-09-28 10:37:29 +00:00

Adversarial proxy returns a false 502 for oversized Appearance body #283

kayg referenced this issue

2026-09-28 10:37:30 +00:00

Adversarial attack2-only run uses deleted users and skips restart coordination #285

kayg commented

2026-09-28 10:42:17 +00:00

Author

Owner

Production preview screenshots from the merged build. The local E2E passed the real Log attachment flow, voice recording flow, Escape confirmation and file destination checks. I checked the icon/text pairs in the deck captures against the ±1 px cap-height rule.

Desktop · 1440 px · attachment deck

Desktop · recording

Phone · 390 px · attachment deck

Phone · recording

Production preview screenshots from the merged build. The local E2E passed the real Log attachment flow, voice recording flow, Escape confirmation and file destination checks. I checked the icon/text pairs in the deck captures against the ±1 px cap-height rule. **Desktop · 1440 px · attachment deck** ![Desktop light attachment deck](https://git.kayg.org/attachments/47955d61-f16c-486b-82a2-8d3bea7f2698) ![Desktop dark attachment deck](https://git.kayg.org/attachments/66441553-5200-47b1-a4dd-34b4316eba30) **Desktop · recording** ![Desktop light recording](https://git.kayg.org/attachments/ffc60e64-6541-440e-b3e3-004eb20e73b5) ![Desktop dark recording](https://git.kayg.org/attachments/b70812a6-c6d2-4e6d-b5b6-72410e0fc467) **Phone · 390 px · attachment deck** ![Phone light attachment deck](https://git.kayg.org/attachments/e5ad7ea0-589a-4843-a8b7-d5a0c889eb5d) ![Phone dark attachment deck](https://git.kayg.org/attachments/5025db76-58d2-4c60-bbad-e7e8f41af101) **Phone · recording** ![Phone light recording](https://git.kayg.org/attachments/f3553693-e08c-4f25-b3b1-c44415bc0a04) ![Phone dark recording](https://git.kayg.org/attachments/cb0a6997-8e5d-49c7-9ad3-0f8226ed9376)

kayg commented

2026-09-28 11:45:25 +00:00

Author

Owner

Full workspace cargo test reached crates/calternal-collab/tests/two_clients.rs::concurrent_clients_and_external_writer_converge and failed once. The Yjs client run succeeded, but after the external file write and the test's 900 ms settle, the stored note contained only first, second, and external; it did not contain either from A or from B. The existing assertion at crates/calternal-collab/tests/two_clients.rs:224 requires all three edits. I did not change the expectation or rerun the suite. This is outside the preview-attach files and may indicate external-write/collaboration update loss; the final gate result will include the failure.

Full workspace `cargo test` reached `crates/calternal-collab/tests/two_clients.rs::concurrent_clients_and_external_writer_converge` and failed once. The Yjs client run succeeded, but after the external file write and the test's 900 ms settle, the stored note contained only `first`, `second`, and `external`; it did not contain either `from A` or `from B`. The existing assertion at `crates/calternal-collab/tests/two_clients.rs:224` requires all three edits. I did not change the expectation or rerun the suite. This is outside the preview-attach files and may indicate external-write/collaboration update loss; the final gate result will include the failure.

kayg commented

2026-09-28 11:54:50 +00:00

Author

Owner

Finished #303 on job/preview-attach.

Built Log preview Attach and Record actions using the Composer's existing AttachmentTray and VoiceRecorder flows. Added an append API for existing Home files, generated the API client, added local deck refresh behavior, and added production E2E plus hostile-input coverage. The audio/webm MIME type now classifies .webm recordings as audio. Eight production screenshots (desktop and phone, light/dark, deck/recording) are attached above.

Issue-owned files:

crates/plugins/notes/src/lib.rs
contracts/openapi.json, packages/api-client/src/generated.ts
packages/ui/src/components/calendar/ItemPreview.svelte
apps/web/src/routes/calendar/[view]/[date]/+page.svelte, apps/web/src/lib/calendar/journal.ts
apps/web/src/lib/composer/Composer.svelte, RecordingBar.svelte, attachments.svelte.ts, attachments.test.ts
apps/web/src/lib/shortcuts/registry.ts, registry.test.ts, apps/web/e2e/preview-attach.mjs, apps/web/package.json
tests/adversarial/attack.py

Commits: f5af97ad (append API), 052d5b34 (preview actions), 89f6c8e8 (adversarial probe), 45b6e0a4 (one required merge of dev). Head: 45b6e0a4e2a62f9d2b0877d6aed6114cbad3db26, pushed to origin/job/preview-attach.

Gates (output excerpts verbatim):

cargo fmt --check
[no output; exit 0]

cargo clippy --all-targets -- -D warnings
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 46m 07s

cargo test
 test result: FAILED. 1 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 4.76s
error: test failed, to rerun pass `-p calternal-collab --test two_clients`

The failed existing test was concurrent_clients_and_external_writer_converge in crates/calternal-collab/tests/two_clients.rs:224. Both client edits appeared in the converged Yjs state, but the final Markdown after an external write contained only first, second, and external; it lost from A and from B. I did not change the assertion or rerun the gate. Evidence is also on #332 for reproduction; other builds and adversarial runs were active on the shared host.

bun run --cwd apps/web check
Loading svelte-check in workspace: /home/kayg/Developer/calternal-wt/preview-attach/apps/web
Getting Svelte diagnostics...
svelte-check found 0 errors and 0 warnings

bun run --cwd apps/web test
 Test Files  110 passed (110)
      Tests  709 passed (709)
   Start at  13:47:58
   Duration  118.05s (transform 57%, environment 18%, import 13%, tests 8%, setup 3%)

The production E2E passed after the merge: preview attach e2e: attachment and recording flows passed; screenshots in /home/kayg/Developer/calternal-wt/preview-attach/artifacts/preview-attach.

The single full adversarial round exited 1. The new Journal attachment probes passed (malformed/oversized payloads, hostile targets, retries, 12 concurrent appends, dedupe, append after delete). The round also reproduced existing unrelated findings, recorded on their current issues: search rebuild omissions (#258), editor undo/redo whitespace changes (#314), API timeouts under concurrent load (#265, #56), semantic recall and PDF extraction/thumbnail delays (#59, #58), proxy 502 behavior (#283), and stale restart barriers in the runner (#285). Several unrelated operations were marked SLOW during heavy shared-host load.

Decisions not specified by the design: the append endpoint accepts existing Home files, de-duplicates each Log's attachments by target on retries, caps a Log at 32 attachments, and applies updates under a per-user lock with compare-and-swap retries. MIME type takes precedence over the ambiguous .webm extension when classifying recordings.

Finished #303 on `job/preview-attach`. Built Log preview Attach and Record actions using the Composer's existing `AttachmentTray` and `VoiceRecorder` flows. Added an append API for existing Home files, generated the API client, added local deck refresh behavior, and added production E2E plus hostile-input coverage. The `audio/webm` MIME type now classifies `.webm` recordings as audio. Eight production screenshots (desktop and phone, light/dark, deck/recording) are attached above. Issue-owned files: - `crates/plugins/notes/src/lib.rs` - `contracts/openapi.json`, `packages/api-client/src/generated.ts` - `packages/ui/src/components/calendar/ItemPreview.svelte` - `apps/web/src/routes/calendar/[view]/[date]/+page.svelte`, `apps/web/src/lib/calendar/journal.ts` - `apps/web/src/lib/composer/Composer.svelte`, `RecordingBar.svelte`, `attachments.svelte.ts`, `attachments.test.ts` - `apps/web/src/lib/shortcuts/registry.ts`, `registry.test.ts`, `apps/web/e2e/preview-attach.mjs`, `apps/web/package.json` - `tests/adversarial/attack.py` Commits: `f5af97ad` (append API), `052d5b34` (preview actions), `89f6c8e8` (adversarial probe), `45b6e0a4` (one required merge of `dev`). Head: `45b6e0a4e2a62f9d2b0877d6aed6114cbad3db26`, pushed to `origin/job/preview-attach`. Gates (output excerpts verbatim): ```text cargo fmt --check [no output; exit 0] ``` ```text cargo clippy --all-targets -- -D warnings Finished `dev` profile [unoptimized + debuginfo] target(s) in 46m 07s ``` ```text cargo test test result: FAILED. 1 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 4.76s error: test failed, to rerun pass `-p calternal-collab --test two_clients` ``` The failed existing test was `concurrent_clients_and_external_writer_converge` in `crates/calternal-collab/tests/two_clients.rs:224`. Both client edits appeared in the converged Yjs state, but the final Markdown after an external write contained only `first`, `second`, and `external`; it lost `from A` and `from B`. I did not change the assertion or rerun the gate. Evidence is also on #332 for reproduction; other builds and adversarial runs were active on the shared host. ```text bun run --cwd apps/web check Loading svelte-check in workspace: /home/kayg/Developer/calternal-wt/preview-attach/apps/web Getting Svelte diagnostics... svelte-check found 0 errors and 0 warnings ``` ```text bun run --cwd apps/web test Test Files 110 passed (110) Tests 709 passed (709) Start at 13:47:58 Duration 118.05s (transform 57%, environment 18%, import 13%, tests 8%, setup 3%) ``` The production E2E passed after the merge: `preview attach e2e: attachment and recording flows passed; screenshots in /home/kayg/Developer/calternal-wt/preview-attach/artifacts/preview-attach`. The single full adversarial round exited 1. The new Journal attachment probes passed (malformed/oversized payloads, hostile targets, retries, 12 concurrent appends, dedupe, append after delete). The round also reproduced existing unrelated findings, recorded on their current issues: search rebuild omissions (#258), editor undo/redo whitespace changes (#314), API timeouts under concurrent load (#265, #56), semantic recall and PDF extraction/thumbnail delays (#59, #58), proxy 502 behavior (#283), and stale restart barriers in the runner (#285). Several unrelated operations were marked SLOW during heavy shared-host load. Decisions not specified by the design: the append endpoint accepts existing Home files, de-duplicates each Log's attachments by target on retries, caps a Log at 32 attachments, and applies updates under a per-user lock with compare-and-swap retries. MIME type takes precedence over the ambiguous `.webm` extension when classifying recordings.

kayg commented

2026-09-28 12:01:41 +00:00

Author

Owner

Orchestrator review of 45b6e0a4 (desktop 1440 + phone 390, dark): attaching works (the files and the voice memo appear in the preview deck; the append API passed its hostile probes). Not accepted yet:

The recording UI must be the owner's inline design (comment above, 2026-09-28): the mic button itself expands inline (width-morph spring) into the recording state inside the same action pill: a small live level animation, the elapsed time, Stop/Keep/Discard as compact pill buttons; then it collapses back into the mic. No separate bar, block, progress track or panel below the actions. Use sveltebits' voice-pill only as a motion idea; keep calternal's pill look. The same shared component in the composer tools pill (the composer's current recording bar should move to it too, for reuse).
Desktop: 'Discard' wraps onto its own line; that goes away with (1).
Phone: the sheet header shows a truncated 'Preview atta' above the content. Use the sheet's normal title behaviour (the full title or none, per the phone chrome rules).
Evidence at 390 / 820 / 1440, light and dark: idle, recording (expanded), just after Keep (collapsed, with the new memo in the deck), plus a frame strip of expand and collapse.

Orchestrator review of 45b6e0a4 (desktop 1440 + phone 390, dark): attaching works (the files and the voice memo appear in the preview deck; the append API passed its hostile probes). **Not accepted yet:** 1. **The recording UI must be the owner's inline design** (comment above, 2026-09-28): the **mic button itself expands inline** (width-morph spring) into the recording state inside the same action pill: a small live level animation, the elapsed time, Stop/Keep/Discard as compact pill buttons; then it collapses back into the mic. No separate bar, block, progress track or panel below the actions. Use sveltebits' voice-pill only as a motion idea; keep calternal's pill look. The same shared component in the composer tools pill (the composer's current recording bar should move to it too, for reuse). 2. Desktop: 'Discard' wraps onto its own line; that goes away with (1). 3. Phone: the sheet header shows a truncated 'Preview atta' above the content. Use the sheet's normal title behaviour (the full title or none, per the phone chrome rules). Evidence at 390 / 820 / 1440, light and dark: idle, recording (expanded), just after Keep (collapsed, with the new memo in the deck), plus a frame strip of expand and collapse.

kayg commented

2026-09-28 12:03:29 +00:00

Author

Owner

Continuing the review fixes on job/preview-attach at 45b6e0a4, with dev at cde2cb8. I read the full issue thread. I will replace the separate RecordingBar with one shared inline expanding mic control in the Composer tools pill and Calendar preview pill, and correct the phone sheet title. I will capture idle, recording, and post-Keep states at 390/820/1440 in light/dark plus an expand/collapse frame strip from the production build.

Continuing the review fixes on job/preview-attach at 45b6e0a4, with dev at cde2cb8. I read the full issue thread. I will replace the separate RecordingBar with one shared inline expanding mic control in the Composer tools pill and Calendar preview pill, and correct the phone sheet title. I will capture idle, recording, and post-Keep states at 390/820/1440 in light/dark plus an expand/collapse frame strip from the production build.

kayg commented

2026-09-28 12:18:35 +00:00

Author

Owner

Finding confirmed in source: Composer.svelte and ItemPreview.svelte both mounted the same RecordingBar after their action PillGroup; ItemPreview.svelte also rendered a separate mic button. OverlaySurface.svelte then put a sheet with no leading/trailing controls in a three-column title row, which left the preview title only one-third of the phone width. The new pill will replace both separate controls, and the sheet title row will use its full width when it has no side controls.

kayg commented

2026-09-28 12:55:17 +00:00

Author

Owner

Finding (2026-09-28): the production browser flow completed the preview and composer recorder transitions, saved every expected attachment, and captured the requested screenshot matrix plus morph strip. Its final console assertion then failed on 31 “Failed to load resource” 404 messages. The first run did not include response paths. I added diagnostics that retain only status, origin, and path, and am reproducing the issue. The console assertion remains strict.

kayg commented

2026-09-28 13:00:46 +00:00

Author

Owner

Finding and fix (2026-09-28): the diagnostic run reported 404s from /api/v1/files/thumb/<hash>. The six unique hashes matched the six preview voice memos saved by the matrix. Files indexes .webm by extension as video/webm; the Log card then treated audio as video and requested a thumbnail that audio does not have. I updated the shared Calendar attachment adapter to treat items in the documented Documents/Voice memos/ folder with recorder audio extensions as audio and to omit thumbnails for audio cards. Added a regression test that keeps ordinary WebM video thumbnails unchanged. This fixes the display edge in the UI scope without changing Files indexing behavior.

Finding and fix (2026-09-28): the diagnostic run reported 404s from `/api/v1/files/thumb/<hash>`. The six unique hashes matched the six preview voice memos saved by the matrix. Files indexes `.webm` by extension as `video/webm`; the Log card then treated audio as video and requested a thumbnail that audio does not have. I updated the shared Calendar attachment adapter to treat items in the documented `Documents/Voice memos/` folder with recorder audio extensions as audio and to omit thumbnails for audio cards. Added a regression test that keeps ordinary WebM video thumbnails unchanged. This fixes the display edge in the UI scope without changing Files indexing behavior.

kayg commented

2026-09-28 13:09:17 +00:00

Author

Owner

Follow-up finding: after the Log attachment-card fix, the production run went from 31 failed thumbnail requests to one. The remaining /api/v1/files/thumb/<hash> request came from the Calendar standalone item card, which receives a video thumbnail hash through the day photo adapter. I reused the Voice memos path rule in that adapter so a WebM voice memo does not get an image thumbnail there either. The next production run will verify both Calendar surfaces.

Follow-up finding: after the Log attachment-card fix, the production run went from 31 failed thumbnail requests to one. The remaining `/api/v1/files/thumb/<hash>` request came from the Calendar standalone item card, which receives a video thumbnail hash through the day photo adapter. I reused the Voice memos path rule in that adapter so a WebM voice memo does not get an image thumbnail there either. The next production run will verify both Calendar surfaces.

kayg commented

2026-09-28 13:32:04 +00:00

Author

Owner

Merged-tree follow-up: dev added the newer /api/v1/calendar/items path for standalone grid cards. Its adapter used thumbnail_url directly, bypassing the day-range fix and preserving the 404 for a WebM voice memo. The shared adapter now maps the documented Voice memos path to a file/audio card with no thumbnail; I added a loadItems regression test for this path.

Merged-tree follow-up: `dev` added the newer `/api/v1/calendar/items` path for standalone grid cards. Its adapter used `thumbnail_url` directly, bypassing the day-range fix and preserving the 404 for a WebM voice memo. The shared adapter now maps the documented Voice memos path to a file/audio card with no thumbnail; I added a `loadItems` regression test for this path.

kayg commented

2026-09-28 13:58:00 +00:00

Author

Owner

Adversarial finding from the merged API round (separate from preview attach): search_chaos.py recorded 1,231 observations of “old Index stopped returning a live hit during staged rebuild.” These were 200 Search responses that did not include the committed unicodenfcsentinel hit during a full staged rebuild. I am tracking this separately; the one bounded adversarial round is still exercising the remaining API sections.

Adversarial finding from the merged API round (separate from preview attach): `search_chaos.py` recorded 1,231 observations of “old Index stopped returning a live hit during staged rebuild.” These were `200` Search responses that did not include the committed `unicodenfcsentinel` hit during a full staged rebuild. I am tracking this separately; the one bounded adversarial round is still exercising the remaining API sections.

kayg commented

2026-09-28 15:06:42 +00:00

Author

Owner

Final report

Implemented and pushed job/preview-attach at 23fed8641782fd3c1a4580756c189b6feff06844.

Built

Added the shared VoiceRecordingPill.svelte. The mic expands inline in the action pill into the waveform, timer and Keep/Discard controls. Calendar preview and Composer use the same component.
Kept the active pill inside the action row while preserving touch targets. Escape follows the discard confirmation flow and focus moves into the recording controls.
Fixed the phone preview sheet title row. It uses the full row when the sheet has no controls.
Added the Log attachment API path and client types used by the preview. Voice memo files under Documents/Voice memos/ resolve as audio and do not request image/video thumbnails.
Restored the merged Calendar linked-note state flow so existing and newly created linked Notes keep the “Open note” action.
Added a real-server Playwright flow and attached production-build evidence for 390, 820 and 1440 px in light and dark themes, plus the recording morph strip.

Files

apps/web/e2e/preview-attach.mjs, apps/web/package.json
apps/web/src/lib/calendar/attachments.test.ts, apps/web/src/lib/calendar/data.test.ts, apps/web/src/lib/calendar/data.ts, apps/web/src/lib/calendar/journal.ts
apps/web/src/lib/composer/Composer.svelte, apps/web/src/lib/composer/attachments.svelte.ts, apps/web/src/lib/composer/attachments.test.ts
apps/web/src/lib/shortcuts/registry.ts, apps/web/src/lib/shortcuts/registry.test.ts
apps/web/src/routes/calendar/[view]/[date]/+page.svelte
contracts/openapi.json, crates/plugins/notes/src/lib.rs, packages/api-client/src/generated.ts
packages/ui/src/components/OverlaySurface.svelte, packages/ui/src/components/PillGroup.svelte, packages/ui/src/components/calendar/ItemPreview.svelte, packages/ui/src/components/calendar/attachments.ts, packages/ui/src/components/composer/VoiceRecordingPill.svelte, packages/ui/src/index.ts
tests/adversarial/attack.py

Gates

cargo fmt --check: exit 0; no output.

cargo clippy --all-targets -- -D warnings:

Finished `dev` profile [unoptimized + debuginfo] target(s) in 15m 47s

cargo test: 72 test result: ok. summaries; 1,367 passed, 0 failed, 12 ignored (totals counted from the full output).

bun run --cwd apps/web check:

svelte-check found 0 errors and 0 warnings

bun run --cwd apps/web test:

 Test Files  112 passed (112)
      Tests  729 passed (729)
  Duration  88.01s (transform 57%, environment 17%, import 14%, tests 8%, setup 3%)

Real-server screenshot flow:

preview attach e2e: inline recording flows passed at 390/820/1440 in light/dark; screenshots in /home/kayg/Developer/calternal-wt/preview-attach/artifacts/preview-attach

Evidence: preview idle, preview recording, preview after Keep, Composer idle, Composer recording, Composer after Keep, recording morph frame strip.

Adversarial round and known gaps

The single 25-minute round stopped at its time cap before later attack2 sections ran. It found 1,231 HTTP 200 search responses that omitted the committed sentinel during staged rebuild; this is tracked by existing issue #336. Under the 20k-watcher load, the guest-share fixture upload returned -1 before its matrix ran, the valid quiet-hours settings PUT timed out, and the malformed daily-date GET timed out. Those findings are recorded on #331, #22 and #14. There were 24 SLOW responses. The search and no-response findings remain open outside this UI job.

Vitest passed while printing the jsdom notices Not implemented: Window's scrollTo() method and Could not parse CSS stylesheet.

Decisions not specified in DESIGN.md

The active inline pill uses a 10.75 rem width and keeps focus within the recording controls after the mic expands.
A phone preview sheet with no controls gives its title the full row.
Files in the recorder's Documents/Voice memos/ folder are treated as audio even when the stored .webm extension is indexed as video.

The merge from dev was performed once. No screenshots or other review artifacts were committed.

## Final report Implemented and pushed `job/preview-attach` at `23fed8641782fd3c1a4580756c189b6feff06844`. ### Built - Added the shared `VoiceRecordingPill.svelte`. The mic expands inline in the action pill into the waveform, timer and Keep/Discard controls. Calendar preview and Composer use the same component. - Kept the active pill inside the action row while preserving touch targets. Escape follows the discard confirmation flow and focus moves into the recording controls. - Fixed the phone preview sheet title row. It uses the full row when the sheet has no controls. - Added the Log attachment API path and client types used by the preview. Voice memo files under `Documents/Voice memos/` resolve as audio and do not request image/video thumbnails. - Restored the merged Calendar linked-note state flow so existing and newly created linked Notes keep the “Open note” action. - Added a real-server Playwright flow and attached production-build evidence for 390, 820 and 1440 px in light and dark themes, plus the recording morph strip. ### Files - `apps/web/e2e/preview-attach.mjs`, `apps/web/package.json` - `apps/web/src/lib/calendar/attachments.test.ts`, `apps/web/src/lib/calendar/data.test.ts`, `apps/web/src/lib/calendar/data.ts`, `apps/web/src/lib/calendar/journal.ts` - `apps/web/src/lib/composer/Composer.svelte`, `apps/web/src/lib/composer/attachments.svelte.ts`, `apps/web/src/lib/composer/attachments.test.ts` - `apps/web/src/lib/shortcuts/registry.ts`, `apps/web/src/lib/shortcuts/registry.test.ts` - `apps/web/src/routes/calendar/[view]/[date]/+page.svelte` - `contracts/openapi.json`, `crates/plugins/notes/src/lib.rs`, `packages/api-client/src/generated.ts` - `packages/ui/src/components/OverlaySurface.svelte`, `packages/ui/src/components/PillGroup.svelte`, `packages/ui/src/components/calendar/ItemPreview.svelte`, `packages/ui/src/components/calendar/attachments.ts`, `packages/ui/src/components/composer/VoiceRecordingPill.svelte`, `packages/ui/src/index.ts` - `tests/adversarial/attack.py` ### Gates - `cargo fmt --check`: exit 0; no output. - `cargo clippy --all-targets -- -D warnings`: ``` Finished `dev` profile [unoptimized + debuginfo] target(s) in 15m 47s ``` - `cargo test`: 72 `test result: ok.` summaries; 1,367 passed, 0 failed, 12 ignored (totals counted from the full output). - `bun run --cwd apps/web check`: ``` svelte-check found 0 errors and 0 warnings ``` - `bun run --cwd apps/web test`: ``` Test Files 112 passed (112) Tests 729 passed (729) Duration 88.01s (transform 57%, environment 17%, import 14%, tests 8%, setup 3%) ``` - Real-server screenshot flow: ``` preview attach e2e: inline recording flows passed at 390/820/1440 in light/dark; screenshots in /home/kayg/Developer/calternal-wt/preview-attach/artifacts/preview-attach ``` Evidence: [preview idle](https://git.kayg.org/attachments/0847615b-ca73-4ca4-81fd-0fedbf261f8a), [preview recording](https://git.kayg.org/attachments/762f2e18-6720-44c8-9b96-8b7addf984bc), [preview after Keep](https://git.kayg.org/attachments/9882a29e-3caa-41d0-98e7-2b4bae9f98a3), [Composer idle](https://git.kayg.org/attachments/a559984c-0eb7-43f3-8ac7-1a49dfb75a6c), [Composer recording](https://git.kayg.org/attachments/380370eb-ca1b-4e9f-940c-1d17bb4a45d5), [Composer after Keep](https://git.kayg.org/attachments/5215ee7b-5e74-4ef0-9bb3-36e4c2a33143), [recording morph frame strip](https://git.kayg.org/attachments/3ba68429-6279-4f37-94cd-9c4414204855). ### Adversarial round and known gaps The single 25-minute round stopped at its time cap before later attack2 sections ran. It found 1,231 HTTP 200 search responses that omitted the committed sentinel during staged rebuild; this is tracked by existing issue #336. Under the 20k-watcher load, the guest-share fixture upload returned -1 before its matrix ran, the valid quiet-hours settings PUT timed out, and the malformed daily-date GET timed out. Those findings are recorded on #331, #22 and #14. There were 24 `SLOW` responses. The search and no-response findings remain open outside this UI job. Vitest passed while printing the jsdom notices `Not implemented: Window's scrollTo() method` and `Could not parse CSS stylesheet`. ### Decisions not specified in DESIGN.md - The active inline pill uses a 10.75 rem width and keeps focus within the recording controls after the mic expands. - A phone preview sheet with no controls gives its title the full row. - Files in the recorder's `Documents/Voice memos/` folder are treated as audio even when the stored `.webm` extension is indexed as video. The merge from `dev` was performed once. No screenshots or other review artifacts were committed.

kayg commented

2026-09-28 15:11:13 +00:00

Author

Owner

Orchestrator review of 23fed864 + two owner reports (2026-09-28): not accepted yet.

'Discard' is clipped ('Discaro') in the recording pill at 1440 (light and dark). The pill must fit its content; if space is tight, Stop/Keep/Discard become icon buttons with tooltips.
No morph: the frame strip shows the expanded pill at full width already at 0 ms and the collapsed one unchanged from 0 ms; nothing animates. Use the #236 width-morph spring (the same helper as the tab bar); show a strip where the widths actually differ across frames.
Owner: 'hovering and selecting give me different previews?' The hover preview hides Attach/Record/Edit/Delete (the page passes logActions only when not hovering: {...preview.hover ? {} : logActions(preview.item)}). Make them the same preview: the same content and the same action pill in both states. Hover stays transient (it closes when the pointer leaves, unless the pointer moves into the preview); a click pins it.
Owner: 'I am not sure why the preview shows up at a distance from the cursor.' In both states the popover sits far from the event (at 1440 it opens on the left, over the sidebar, away from the block). Anchor it to the event block's nearest edge, with the shared small gap token (the same as other popovers), on the side with room (right first, then left); vertically aligned with the block's top (clamped to the viewport). Never leave a large empty gap between the block and the preview. Test at 390/820/1440: on phone it stays a sheet.
Evidence: hover and selected previews side by side at 820 and 1440 (light and dark), the placement next to a block at the left edge and at the right edge of the grid, and a real morph frame strip.

Orchestrator review of 23fed864 + two owner reports (2026-09-28): **not accepted yet.** 1. **'Discard' is clipped** ('Discaro') in the recording pill at 1440 (light and dark). The pill must fit its content; if space is tight, Stop/Keep/Discard become icon buttons with tooltips. 2. **No morph:** the frame strip shows the expanded pill at full width already at 0 ms and the collapsed one unchanged from 0 ms; nothing animates. Use the #236 width-morph spring (the same helper as the tab bar); show a strip where the widths actually differ across frames. 3. **Owner: 'hovering and selecting give me different previews?'** The hover preview hides Attach/Record/Edit/Delete (the page passes `logActions` only when not hovering: `{...preview.hover ? {} : logActions(preview.item)}`). **Make them the same preview**: the same content and the same action pill in both states. Hover stays transient (it closes when the pointer leaves, unless the pointer moves into the preview); a click pins it. 4. **Owner: 'I am not sure why the preview shows up at a distance from the cursor.'** In both states the popover sits far from the event (at 1440 it opens on the left, over the sidebar, away from the block). Anchor it to the **event block's nearest edge**, with the shared small gap token (the same as other popovers), on the side with room (right first, then left); vertically aligned with the block's top (clamped to the viewport). Never leave a large empty gap between the block and the preview. Test at 390/820/1440: on phone it stays a sheet. Evidence: hover and selected previews side by side at 820 and 1440 (light and dark), the placement next to a block at the left edge and at the right edge of the grid, and a real morph frame strip.

kayg commented

2026-09-28 15:12:19 +00:00

Author

Owner

Owner (2026-09-28): 'the preview looks different in day vs week mode?' One preview everywhere: identical width, padding, content order and action pill in Agenda, Day, Week and Month (and in Search's calendar card). Today the page passes onopenday={view === 'day' ? undefined : openDay}, so the action pill changes per view, and the popover width/placement also differ by view. Keep the pill identical: show 'Open day' in every view (in Day view it is simply disabled, or replaced by the same-width slot, never a different layout), and use one popover width token. Add an e2e that opens the same log entry's preview in all four views and compares the preview box size and the action list.

Owner (2026-09-28): **'the preview looks different in day vs week mode?'** One preview everywhere: identical width, padding, content order and action pill in Agenda, Day, Week and Month (and in Search's calendar card). Today the page passes `onopenday={view === 'day' ? undefined : openDay}`, so the action pill changes per view, and the popover width/placement also differ by view. Keep the pill identical: show 'Open day' in every view (in Day view it is simply disabled, or replaced by the same-width slot, never a different layout), and use one popover width token. Add an e2e that opens the same log entry's preview in all four views and compares the preview box size and the action list.

kayg referenced this issue

2026-09-28 15:12:40 +00:00

ACTIVITY: internal and hidden files (.calternal/settings.json, dot-files) show as 'files saved' in Calendar, Search and Recent #351

kayg commented

2026-09-28 15:15:17 +00:00

Author

Owner

Starting the #303 review follow-up on job/preview-attach at 23fed8641782fd3c1a4580756c189b6feff06844; current dev is eb4ff20a9862a627f6d0aea1ca617ca9a9491bce. I have read the latest review comments. I am fixing the Discard clipping and width morph, keeping hover and selected previews identical and anchored to the block edge, and making the shared preview identical in Agenda, Day, Week, Month and Search's Calendar card. I will add the cross-view e2e and capture 390/820/1440 px in light and dark.

Starting the #303 review follow-up on `job/preview-attach` at `23fed8641782fd3c1a4580756c189b6feff06844`; current `dev` is `eb4ff20a9862a627f6d0aea1ca617ca9a9491bce`. I have read the latest review comments. I am fixing the Discard clipping and width morph, keeping hover and selected previews identical and anchored to the block edge, and making the shared preview identical in Agenda, Day, Week, Month and Search's Calendar card. I will add the cross-view e2e and capture 390/820/1440 px in light and dark.

kayg referenced this issue

2026-09-28 15:42:35 +00:00

Calendar: rich task counted twice (→ bullet + task file checkbox); +N chip is a no-op #357

kayg commented

2026-09-28 16:11:15 +00:00

Author

Owner

Finding: the new production Playwright parity flow opens the seeded Log in Agenda, then reports that the preview action pill has Copy link, Attach, Record, Edit and Delete but no Open day action. The literal Open day assertion fails on this real local Calendar preview. The Calendar route also currently passes onopenday as undefined in Day and omits Log actions and the recording pill for transient hover previews; I am keeping the e2e assertions on both view parity and hover/selection parity while fixing the shared ItemPreview.

Finding: the new production Playwright parity flow opens the seeded Log in Agenda, then reports that the preview action pill has Copy link, Attach, Record, Edit and Delete but no Open day action. The literal Open day assertion fails on this real local Calendar preview. The Calendar route also currently passes `onopenday` as `undefined` in Day and omits Log actions and the recording pill for transient hover previews; I am keeping the e2e assertions on both view parity and hover/selection parity while fixing the shared ItemPreview.

kayg commented

2026-09-28 16:50:28 +00:00

Author

Owner

Finding from the real production Playwright run: after animations settle, the Calendar Log card measures 290 × 348 px at 1440 px, while the Search calendar card measures 282 × 348 px. This confirms an 8 px width mismatch in Search's calendar-card sizing. I am correcting the shared width and adding an e2e parity assertion.

kayg commented

2026-09-28 16:55:48 +00:00

Author

Owner

The desktop Search card now matches the Calendar card at 290 px. The same production e2e then measured 290 px for Search's phone peek against 322 px for the Calendar sheet, with matching height. I am aligning Search's phone inset to the shared sheet content inset, then I will rerun the viewport/theme evidence pass.

kayg commented

2026-09-28 17:14:01 +00:00

Author

Owner

The single dev merge had one API contract conflict: this branch adds Log attachment request/result schemas and dev adds ApplyResult. I preserved both sides in contracts/openapi.json and regenerated packages/api-client/src/generated.ts with the locked openapi-typescript 7.13.0 command. The merged tree also retains dev's linked-Note action alongside Open day. I will run the one post-merge adversarial round because dev brings API changes.

The single `dev` merge had one API contract conflict: this branch adds Log attachment request/result schemas and `dev` adds `ApplyResult`. I preserved both sides in `contracts/openapi.json` and regenerated `packages/api-client/src/generated.ts` with the locked openapi-typescript 7.13.0 command. The merged tree also retains `dev`'s linked-Note action alongside Open day. I will run the one post-merge adversarial round because `dev` brings API changes.

kayg commented

2026-09-28 17:40:17 +00:00

Author

Owner

The merged production e2e reproduced the reported clipped Discard on the 1440 px Calendar preview. At recording time, the inline recorder and the other Log actions exceeded the card width; the action button's scroll width was greater than its client width. The captured evidence is artifacts/preview-attach/preview-recording-light-1440.png. I am compacting the sibling controls while recording and hiding the already-disabled Edit/Delete actions for that temporary state.

The merged production e2e reproduced the reported clipped Discard on the 1440 px Calendar preview. At recording time, the inline recorder and the other Log actions exceeded the card width; the action button's scroll width was greater than its client width. The captured evidence is `artifacts/preview-attach/preview-recording-light-1440.png`. I am compacting the sibling controls while recording and hiding the already-disabled Edit/Delete actions for that temporary state.

kayg commented

2026-09-28 18:25:18 +00:00

Author

Owner

Resuming #303 on job/preview-attach at fca472e1 after the interrupted build. The one pending worktree change closes each E2E browser context after its capture. The existing E2E compares Calendar card dimensions and content, but SearchPreview.svelte currently mounts ItemPreview with only item, so the Search card omits the preview's Attach, Record, Edit and Delete actions. I am wiring that card to the existing upload, recorder and journal flows, then extending the E2E to compare the full action list across Agenda, Day, Week, Month and Search.

Resuming #303 on `job/preview-attach` at `fca472e1` after the interrupted build. The one pending worktree change closes each E2E browser context after its capture. The existing E2E compares Calendar card dimensions and content, but `SearchPreview.svelte` currently mounts `ItemPreview` with only `item`, so the Search card omits the preview's Attach, Record, Edit and Delete actions. I am wiring that card to the existing upload, recorder and journal flows, then extending the E2E to compare the full action list across Agenda, Day, Week, Month and Search.

kayg referenced this issue

2026-09-28 18:44:50 +00:00

VOICE: local transcription (Parakeet v2 → S1-mini by Superwhisper), background model download, inline mic morph #373

kayg commented

2026-09-28 18:48:15 +00:00

Author

Owner

Progress on #303 at fca472e1: Search's Calendar card now passes the same Attach, Record, Open day, Edit and Delete actions to the shared ItemPreview. It uses the existing attachment tray, voice recorder, journal APIs, and update-by-id projection refresh. The E2E compares dimensions, content and action order in Agenda, Day, Week, Month and Search, and exercises file and voice attachment from Search once. bun run --cwd apps/web check reported 0 errors and 0 warnings; the production build passed. The first E2E attempt stopped before the app started because the preset external Cargo target had no calternal-server binary, so I am building it now with the required low-memory settings.

Progress on #303 at `fca472e1`: Search's Calendar card now passes the same Attach, Record, Open day, Edit and Delete actions to the shared `ItemPreview`. It uses the existing attachment tray, voice recorder, journal APIs, and update-by-id projection refresh. The E2E compares dimensions, content and action order in Agenda, Day, Week, Month and Search, and exercises file and voice attachment from Search once. `bun run --cwd apps/web check` reported 0 errors and 0 warnings; the production build passed. The first E2E attempt stopped before the app started because the preset external Cargo target had no `calternal-server` binary, so I am building it now with the required low-memory settings.

kayg commented

2026-09-28 20:59:44 +00:00

Author

Owner

Search card sizing finding: the production screenshot at 1440 px showed the compact Search window sized to its result list while the Calendar Log card was taller, leaving the shared Log action pill below the visible preview pane. The compact height now includes the loaded preview card's natural height. The final E2E checks the action pill fits inside the Search card surface at phone and desktop widths.

kayg commented

2026-09-28 22:21:25 +00:00

Author

Owner

Completed

Calendar Log preview content and action order now match across Today/Agenda, Day, Week, Month, and Search.
Search Log cards use the shared ItemPreview and existing attachment and recording flows. The card supports Attach, Record, Open day, Edit, Convert to note, and Delete with Undo. Search stays open while recording or uploading; Open day closes Search.
Compact Search sizing includes the loaded preview height, so the full action pill stays visible.
Production E2E compares the four Calendar views and Search. It checks action order and preview content/size, hover-to-selected parity, left/right edge placement, Search bounds, and recording/Keep flows at 390, 820, and 1440 px in light and dark.

Files

apps/web/src/lib/calendar/journal.ts
apps/web/src/lib/components/search-dialog.svelte
apps/web/src/lib/search/SearchPreview.svelte
apps/web/src/routes/calendar/[view]/[date]/+page.svelte
apps/web/e2e/preview-attach.mjs
packages/ui/src/components/PillGroup.svelte
packages/ui/src/components/calendar/ItemPreview.svelte
packages/ui/src/components/composer/VoiceRecordingPill.svelte

Branch job/preview-attach; HEAD bf6d0bf5ef61d78c603610614539ef9a2e5195dc. The branch is pushed and up to date. dev was merged once before final gates (8b01164f).

Gate output

cargo fmt --check returned exit 0 with no output.

Clippy was still compiling workspace dependencies at the four-hour job limit. It was stopped then. Its last output was:

    Checking async-task v4.7.1
    Checking chacha20poly1305 v0.11.0
   Compiling zvariant v5.15.0
    Checking async-channel v2.5.0

No Clippy diagnostics appeared before it was stopped. cargo test and bun run --cwd apps/web test were not run before the time limit.

The web check passed. Output:

Loading svelte-check in workspace: /home/kayg/Developer/calternal-wt/preview-attach/apps/web
Getting Svelte diagnostics...

svelte-check found 0 errors and 0 warnings

Production E2E passed. Output:

preview attach e2e: inline recording flows passed at 390/820/1440 in light/dark; screenshots in /home/kayg/Developer/calternal-wt/preview-attach/artifacts/preview-attach

Decisions and known gaps

Search keeps the existing responsive layout: the calendar preview is in the phone sheet and desktop pane; the 820 px tablet layout remains the results surface. No additional product behavior was needed beyond the issue request.

The workspace Clippy and Rust test gates remain incomplete because the job reached its four-hour limit during dependency compilation. The web unit test gate also remains incomplete. Build outputs were cleaned after stopping.

Visual evidence

Calendar matrices cover all three widths and both themes: Today/Agenda, Day, Week, Month.

Preview states: idle, recording, after Keep. Composer states: idle, recording, after Keep. Inline width morph.

Hover/selection parity: light, dark. Edge placement: left light, left dark, right light, right dark.

Search surfaces: phone light, phone dark, desktop light, desktop dark, tablet results light, tablet results dark.

## Completed - Calendar Log preview content and action order now match across Today/Agenda, Day, Week, Month, and Search. - Search Log cards use the shared `ItemPreview` and existing attachment and recording flows. The card supports Attach, Record, Open day, Edit, Convert to note, and Delete with Undo. Search stays open while recording or uploading; Open day closes Search. - Compact Search sizing includes the loaded preview height, so the full action pill stays visible. - Production E2E compares the four Calendar views and Search. It checks action order and preview content/size, hover-to-selected parity, left/right edge placement, Search bounds, and recording/Keep flows at 390, 820, and 1440 px in light and dark. ## Files - `apps/web/src/lib/calendar/journal.ts` - `apps/web/src/lib/components/search-dialog.svelte` - `apps/web/src/lib/search/SearchPreview.svelte` - `apps/web/src/routes/calendar/[view]/[date]/+page.svelte` - `apps/web/e2e/preview-attach.mjs` - `packages/ui/src/components/PillGroup.svelte` - `packages/ui/src/components/calendar/ItemPreview.svelte` - `packages/ui/src/components/composer/VoiceRecordingPill.svelte` Branch `job/preview-attach`; HEAD `bf6d0bf5ef61d78c603610614539ef9a2e5195dc`. The branch is pushed and up to date. `dev` was merged once before final gates (`8b01164f`). ## Gate output `cargo fmt --check` returned exit 0 with no output. Clippy was still compiling workspace dependencies at the four-hour job limit. It was stopped then. Its last output was: ```text Checking async-task v4.7.1 Checking chacha20poly1305 v0.11.0 Compiling zvariant v5.15.0 Checking async-channel v2.5.0 ``` No Clippy diagnostics appeared before it was stopped. `cargo test` and `bun run --cwd apps/web test` were not run before the time limit. The web check passed. Output: ```text Loading svelte-check in workspace: /home/kayg/Developer/calternal-wt/preview-attach/apps/web Getting Svelte diagnostics... svelte-check found 0 errors and 0 warnings ``` Production E2E passed. Output: ```text preview attach e2e: inline recording flows passed at 390/820/1440 in light/dark; screenshots in /home/kayg/Developer/calternal-wt/preview-attach/artifacts/preview-attach ``` ## Decisions and known gaps Search keeps the existing responsive layout: the calendar preview is in the phone sheet and desktop pane; the 820 px tablet layout remains the results surface. No additional product behavior was needed beyond the issue request. The workspace Clippy and Rust test gates remain incomplete because the job reached its four-hour limit during dependency compilation. The web unit test gate also remains incomplete. Build outputs were cleaned after stopping. ## Visual evidence Calendar matrices cover all three widths and both themes: [Today/Agenda](https://git.kayg.org/attachments/29d5f93e-64e2-42b8-8468-46431f80d6aa), [Day](https://git.kayg.org/attachments/39078faf-2fb5-449d-8496-7f363d497ef5), [Week](https://git.kayg.org/attachments/35cd4042-bb74-4407-b6c5-12d4fed90908), [Month](https://git.kayg.org/attachments/f2f9fba5-0a49-42b1-a8b2-4729b7cabbfe). Preview states: [idle](https://git.kayg.org/attachments/54f0d98d-193b-4b65-8f36-9a110be8da05), [recording](https://git.kayg.org/attachments/43fba6eb-eaf3-4312-81d5-ce1b8dd55f94), [after Keep](https://git.kayg.org/attachments/fe96de2d-6889-44e3-a3bd-a2974152a59e). Composer states: [idle](https://git.kayg.org/attachments/e8c76473-c581-4180-90b5-e628c4853dd7), [recording](https://git.kayg.org/attachments/4ddd396b-9afd-4b64-a9cf-0fd338032533), [after Keep](https://git.kayg.org/attachments/6772f7bd-9886-4bee-ab7d-31ef73615b3c). [Inline width morph](https://git.kayg.org/attachments/42886f1a-c077-4261-b99a-daaf90c4ad5d). Hover/selection parity: [light](https://git.kayg.org/attachments/998bad33-f96e-448a-ae7f-d81be15fda25), [dark](https://git.kayg.org/attachments/0fb7e62f-5ade-48f5-bf7d-441f250d425e). Edge placement: [left light](https://git.kayg.org/attachments/0ed55f5a-8e5d-404c-8dae-42159d03a196), [left dark](https://git.kayg.org/attachments/05048184-70f3-4483-aea7-89602c4c0661), [right light](https://git.kayg.org/attachments/1cbf9d13-e823-4540-8b6f-d8960bc7e806), [right dark](https://git.kayg.org/attachments/4d227e5e-7229-49da-a925-40a6fc0f2425). Search surfaces: [phone light](https://git.kayg.org/attachments/f8c57125-0178-47cb-880d-22a856205be6), [phone dark](https://git.kayg.org/attachments/57425057-bfb6-4911-843c-5efa28b66d25), [desktop light](https://git.kayg.org/attachments/9d49807c-a634-4a1d-9d91-c33dd6708ee1), [desktop dark](https://git.kayg.org/attachments/783ff76e-c3be-4807-a9bc-8fd9c7dd25b3), [tablet results light](https://git.kayg.org/attachments/84cb89ce-82ee-41c2-9fdc-a8060cf36956), [tablet results dark](https://git.kayg.org/attachments/b1b148df-4f0a-4375-ab8d-6cf84cea1c80).

kayg referenced this issue

2026-09-29 08:21:31 +00:00

CALENDAR Agenda: Fantastical-style — one card per day, time and title on separate lines, attachment thumbnails, hover preview, selection #413

kayg referenced this issue

2026-10-03 12:56:40 +00:00

Issue hygiene sweep 2026-10-03 #1008