NOTES: daily notes' previous/next links are wrong-relative and show up as broken links; vault-health copy polish #344

Closed
opened 2026-09-28 13:35:57 +00:00 by kayg · 1 comment
Owner

From the #301 review (orchestrator, 2026-09-28):

  1. Daily-note front matter links are written as [2026-09-27-daily-note](<Notes/20260927-dailynote.md>) from a file that lives in Notes/, so the relative link resolves to Notes/Notes/…: broken for every daily note. They also point at days that may not exist. Result: is:broken-link lists every daily note. Fix the generator (crates/calternal-notes-core dayfile.rs template) to write correct relative links (20260927-dailynote.md, no folder prefix, CommonMark relative per DESIGN §26), and decide: link only to days that exist (update the neighbours when a day is created) OR exclude front matter navigation links from link-health. Proposal: the former (correct links everywhere). Add a one-time migration that rewrites the existing daily notes' previous/next links (server single writer; versions kept).
  2. Copy: pluralisation ('1 Notes with 1 links', 'Apply 1 changes', '1 unresolved references'); use one plural helper (reuse #310's formatter). The page title 'Convert wikilinks' appears twice (page H1 and card H1): keep one. Line labels are inconsistent ('Line 7' vs 'Line 7:').
From the #301 review (orchestrator, 2026-09-28): 1. **Daily-note front matter links** are written as `[2026-09-27-daily-note](<Notes/20260927-dailynote.md>)` from a file that lives in `Notes/`, so the relative link resolves to `Notes/Notes/…`: broken for every daily note. They also point at days that may not exist. Result: `is:broken-link` lists every daily note. Fix the generator (crates/calternal-notes-core dayfile.rs template) to write correct relative links (`20260927-dailynote.md`, no folder prefix, CommonMark relative per DESIGN §26), and decide: link only to days that exist (update the neighbours when a day is created) OR exclude front matter navigation links from link-health. Proposal: the former (correct links everywhere). Add a one-time migration that rewrites the existing daily notes' previous/next links (server single writer; versions kept). 2. Copy: pluralisation ('1 Notes with 1 links', 'Apply 1 changes', '1 unresolved references'); use one plural helper (reuse #310's formatter). The page title 'Convert wikilinks' appears twice (page H1 and card H1): keep one. Line labels are inconsistent ('Line 7' vs 'Line 7:').
Author
Owner

Daily note navigation regression coverage passes. The core vector now keeps previous/next links absent when adjacent notes do not exist, and the Notes plugin tests cover relative links, neighbour updates after creating a day, and the one-time migration preserving versions. Focused results: calternal-notes-core: 1 passed; calternal-plugin-notes daily_note_: 5 passed.

Daily note navigation regression coverage passes. The core vector now keeps previous/next links absent when adjacent notes do not exist, and the Notes plugin tests cover relative links, neighbour updates after creating a day, and the one-time migration preserving versions. Focused results: calternal-notes-core: 1 passed; calternal-plugin-notes daily_note_: 5 passed.
kayg closed this issue 2026-09-29 08:29:19 +00:00
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kayg/calternal#344
No description provided.