Calendar photos: remove 'Show photos by' setting; show on date taken AND an 'N Added' picture deck on upload day, carousel hover card, overlay on click

kayg commented

2026-10-01 10:17:59 +00:00

Owner

Owner decision (2026-10-01, Settings → Calendars → Week and Day "Show photos by: Date taken / Date added")

"This option is totally unnecessary. Just show them on both dates. On the upload date, if the density is small, add a picture deck as a thumbnail and say " Added". The hover preview should contain the same hover preview card, but with a horizontally scrollable carousel fitting within the bounds of the card. Clicking any picture should open as an overlay!"
Build (with #589, the same Calendar activity layout; one owner):

Remove the setting (and its preference/API field; a migration drops the stored value).
Photos show on both dates: on the date taken, as captured activity at its time (the #589 lane rules), and on the date added (upload day) as an "Added" item.
Upload-day item: when the day's density allows, a small picture deck thumbnail (3 stacked cards, the shared deck style) labelled " Added". When there is no room, a compact chip "📷 N" (#589).
Hover preview: the same shared hover card as other items (#421), containing a horizontally scrollable carousel of the added photos that stays inside the card bounds: snap scrolling, lazy thumbnails, keyboard ←/→, a count indicator.
Click any photo → Quick Look overlay over the Calendar (#622 behaviour), ‹ › through that day's added set. Closing returns to the same view.
The same photo never appears twice on the same day (if taken and added on the same day, show it once, as taken).
Test: e2e: upload 12 old photos today → today shows "12 Added" with a deck; hovering shows the carousel; clicking a photo opens Quick Look; each photo's taken date shows it at its time. Screenshots of the deck/chip/carousel in both themes.

## Owner decision (2026-10-01, Settings → Calendars → Week and Day "Show photos by: Date taken / Date added") "This option is totally unnecessary. Just show them on both dates. On the upload date, if the density is small, add a picture deck as a thumbnail and say "<N> Added". The hover preview should contain the same hover preview card, but with a horizontally scrollable carousel fitting within the bounds of the card. Clicking any picture should open as an overlay!" **Build (with #589, the same Calendar activity layout; one owner):** - **Remove the setting** (and its preference/API field; a migration drops the stored value). - **Photos show on both dates:** on the **date taken**, as captured activity at its time (the #589 lane rules), and on the **date added** (upload day) as an "Added" item. - **Upload-day item:** when the day's density allows, a small **picture deck** thumbnail (3 stacked cards, the shared deck style) labelled "**<N> Added**". When there is no room, a compact chip "📷 N" (#589). - **Hover preview:** the same shared hover card as other items (#421), containing a **horizontally scrollable carousel** of the added photos that stays inside the card bounds: snap scrolling, lazy thumbnails, keyboard ←/→, a count indicator. - **Click any photo → Quick Look overlay** over the Calendar (#622 behaviour), ‹ › through that day's added set. Closing returns to the same view. - The same photo never appears twice on the same day (if taken and added on the same day, show it once, as taken). **Test:** e2e: upload 12 old photos today → today shows "12 Added" with a deck; hovering shows the carousel; clicking a photo opens Quick Look; each photo's taken date shows it at its time. Screenshots of the deck/chip/carousel in both themes.

kayg referenced this issue

2026-10-01 15:32:09 +00:00

Calendar: photo/file activity cards overlap entries and don't scale; give them their own lane and size them to the view #589

kayg referenced this issue

2026-10-01 16:06:30 +00:00

Calendar: photo/file activity cards overlap entries and don't scale; give them their own lane and size them to the view #589

kayg commented

2026-10-01 20:24:59 +00:00

Author

Owner

Implemented with #589 at head eecd7b6b5: the Calendar preference/API field is removed, Photos appear on capture and upload dates with same-day deduplication, and upload-day decks open the shared bounded carousel and Quick Look. The real 12-photo E2E and 24-screen screenshot matrix passed; screenshots are attached to #589. The final gate report and adversarial findings are on #589.

Implemented with #589 at head eecd7b6b5: the Calendar preference/API field is removed, Photos appear on capture and upload dates with same-day deduplication, and upload-day decks open the shared bounded carousel and Quick Look. The real 12-photo E2E and 24-screen screenshot matrix passed; screenshots are attached to #589. The final gate report and adversarial findings are on #589.

kayg referenced this issue

2026-10-01 20:28:19 +00:00

Calendar: photo/file activity cards overlap entries and don't scale; give them their own lane and size them to the view #589

kayg commented

2026-10-01 20:28:38 +00:00

Author

Owner

Finished with #589 at head eecd7b6b59. The Photo date preference is gone; capture dates and upload dates both appear, same-day rows deduplicate, and upload-day decks open the shared carousel and Quick Look. The 12-photo production E2E passed. Twenty-four screenshots for Week, Day, Month and Added carousel across phone/tablet/desktop and both themes are attached to #589. Web check found 0 Svelte errors or warnings; web tests passed 148 files / 1018 tests. The full gate output, performance figures, decisions and adversarial findings are in the final report on #589.

Finished with #589 at head eecd7b6b59e509084fe2b3530baa9bface3440b0. The Photo date preference is gone; capture dates and upload dates both appear, same-day rows deduplicate, and upload-day decks open the shared carousel and Quick Look. The 12-photo production E2E passed. Twenty-four screenshots for Week, Day, Month and Added carousel across phone/tablet/desktop and both themes are attached to #589. Web check found 0 Svelte errors or warnings; web tests passed 148 files / 1018 tests. The full gate output, performance figures, decisions and adversarial findings are in the final report on #589.

kayg referenced this issue

2026-10-01 22:00:34 +00:00

Attachments: inline play on audio chips (hover → ▶), and open attachments in a Quick Look overlay instead of navigating to Files #622

kayg referenced this issue

2026-10-02 10:05:35 +00:00

Calendar: photo/file activity cards overlap entries and don't scale; give them their own lane and size them to the view #589

kayg commented

2026-10-02 10:06:08 +00:00

Author

Owner

Round 2 is complete on head 421dd6373. Calendar Photos use both capture and upload dates, with a same-day Photo appearing once. Activity decks now size to lane width and reserved time, and the carousel count and action row are fixed. The final 24 screenshot matrix (Week, Day, Month and carousel; 390/820/1440; Light/Dark) is attached to #589. The focused production E2E and web suite passed. Full gate output and known gaps are in the #589 final report. This issue remains open.

Round 2 is complete on head `421dd6373`. Calendar Photos use both capture and upload dates, with a same-day Photo appearing once. Activity decks now size to lane width and reserved time, and the carousel count and action row are fixed. The final 24 screenshot matrix (Week, Day, Month and carousel; 390/820/1440; Light/Dark) is attached to #589. The focused production E2E and web suite passed. Full gate output and known gaps are in the #589 final report. This issue remains open.

kayg referenced this issue

2026-10-03 06:49:00 +00:00

Plan: merge order and conflicts for merge round 7b #867

kayg referenced this issue

2026-10-03 12:51:32 +00:00

Issue hygiene sweep 2026-10-03 #1008

kayg referenced this issue

2026-10-04 06:02:58 +00:00

Plan: merge order and conflicts for merge round 7b #867

kayg referenced this issue

2026-10-04 11:29:45 +00:00

Plan: merge order and conflicts for merge round 7b #867