PERF: Settings rule 8 — keep counts and background work off the first usable path (#663) #692

Open
opened 2026-10-02 05:36:44 +00:00 by kayg · 2 comments
Owner

Context: #663 matrix and DESIGN §58 rule 8. Scope: Settings must keep counts and background work off the first usable path. Shared client machinery belongs only to #665–#668.

Evidence at c4a61e8cf0:

  • Endpoint: GET /api/v1/auth/me/security.
  • Source: crates/calternal-auth/src/store.rs:2043. Auth reads share store.pool instead of a separate read-only pool; base Settings cards start their data reads on mount. #642 scheduling work is active reuse.
  • Representative endpoint numbers, server/client revisions, fixture size, lock/HDD qualification and limits are in the #663 production/HDD table. Those numbers do not prove this rule passes; the structural gap above is separate evidence.

Expected and regression tests:
Compare first-row/first-card paint with counts/stats deliberately delayed. Interactive input and usable rows must not await counts, thumbnail jobs or non-selected sidebars. Under a held writer and indexing/backfill batches, reads use a separate read-only pool and return a complete committed answer. Bound batches, yield between them and record CPU/RSS plus per-phase latency. Keep all visible totals correct; do not remove counts or replace them with fake values. Record accepted and durable timings via #667, without content or credentials.

Performance test:
Extend the existing bench profile for this hot path and the #549/#641 harness. Use production builds on root@10.69.69.63, bench/hdd-emu.sh and flock -w 14400 /root/perf.lock. Record load inside the lock; ≥5 samples, median/p95/max, average CPU/RSS and one realistic large-data/burst case. Separate warm, cold, accepted and durable boundaries. First usable 10k view ≤1.5 s; cached open/warm return ≤100 ms and accepted action ≤150 ms where applicable. Compare only a matching baseline in docs/perf/baseline.json; missing profiles require a new recorded baseline, not a made-up comparison.

Reuse/ownership:

Reuse #555 userStorage, #549 route caches, Files signed keysets/change feed and the existing Db reader_pool. #641 owns blaze measurements; #642 owns Settings opening; #640 owns Mail layouts; #639 owns linked Note opening. Integrate their active/completed branches before changing related code.

Acceptance:
Existing tests and status expectations stay intact. Run the per-crate gates (and calternal-server for route/contract changes), web gates if changed, and one time-boxed real-server regression/adversarial round for any new API contract. Preserve calternal-fs as the only filesystem interface and the server as the only writer. UI changes need pointer/touch/keyboard/screen-reader coverage and real-production captures at 390/820/1440 in both themes. Do not change shared motion for keyboard input.

Representative measurement from the audit (not a full-view budget result):
/api/v1/auth/me/security, five serial requests after fixture readiness, all HTTP 200. Median/p95/max 482.2/1266.5/1266.5 ms; five-request burst median/p95/max 86.4/89.9/89.9 ms. Serial window server CPU 290 ms, RSS 511967232 bytes; no ETag on these sampled responses. Load inside lock 3.92/2.18/0.96.
Shared release server source cc25c441b7a974185622a1dee853cf38686d2b67, binary SHA-256 2f3567d91c34839851247bc0acbc25a56aaacd14dca269b8f0342ddf83447ed9; embedded production SPA; Chromium browser on the build host through SSH/HTTPS. Server/Home/Index on perf VM HDD emulator: direct-I/O loop, 8 ms read/write dm-delay, 200 IOPS and 150 MiB/s caps. Every measured phase held flock -w 14400 /root/perf.lock. Qualification QD1 115.3 IOPS/8.028 ms median, QD16 200.7 IOPS/96.993 ms. Fixture: 366 Daily notes, 10,980 Logs, 100 Files/Photos, 20 Notes/Tasks, three Budgets and 100 transactions; Mail empty, Admin one User.
Structural source evidence above is the newer audit base, not the measured binary revision. No claim that these revisions are equivalent. The baseline in docs/perf/baseline.json uses another fixture/build/transport; no regression ratio is valid here. See #663 for matching baseline endpoint values and coverage gaps.

Context: #663 matrix and DESIGN §58 rule 8. Scope: Settings must keep counts and background work off the first usable path. Shared client machinery belongs only to #665–#668. Evidence at c4a61e8cf090170f35b1bed3350d9de20c83ecd5: - Endpoint: `GET /api/v1/auth/me/security`. - Source: `crates/calternal-auth/src/store.rs:2043`. Auth reads share store.pool instead of a separate read-only pool; base Settings cards start their data reads on mount. #642 scheduling work is active reuse. - Representative endpoint numbers, server/client revisions, fixture size, lock/HDD qualification and limits are in the #663 production/HDD table. Those numbers do not prove this rule passes; the structural gap above is separate evidence. Expected and regression tests: Compare first-row/first-card paint with counts/stats deliberately delayed. Interactive input and usable rows must not await counts, thumbnail jobs or non-selected sidebars. Under a held writer and indexing/backfill batches, reads use a separate read-only pool and return a complete committed answer. Bound batches, yield between them and record CPU/RSS plus per-phase latency. Keep all visible totals correct; do not remove counts or replace them with fake values. Record accepted and durable timings via #667, without content or credentials. Performance test: Extend the existing bench profile for this hot path and the #549/#641 harness. Use production builds on root@10.69.69.63, bench/hdd-emu.sh and flock -w 14400 /root/perf.lock. Record load inside the lock; ≥5 samples, median/p95/max, average CPU/RSS and one realistic large-data/burst case. Separate warm, cold, accepted and durable boundaries. First usable 10k view ≤1.5 s; cached open/warm return ≤100 ms and accepted action ≤150 ms where applicable. Compare only a matching baseline in docs/perf/baseline.json; missing profiles require a new recorded baseline, not a made-up comparison. Reuse/ownership: Reuse #555 userStorage, #549 route caches, Files signed keysets/change feed and the existing Db reader_pool. #641 owns blaze measurements; #642 owns Settings opening; #640 owns Mail layouts; #639 owns linked Note opening. Integrate their active/completed branches before changing related code. Acceptance: Existing tests and status expectations stay intact. Run the per-crate gates (and calternal-server for route/contract changes), web gates if changed, and one time-boxed real-server regression/adversarial round for any new API contract. Preserve calternal-fs as the only filesystem interface and the server as the only writer. UI changes need pointer/touch/keyboard/screen-reader coverage and real-production captures at 390/820/1440 in both themes. Do not change shared motion for keyboard input. Representative measurement from the audit (not a full-view budget result): `/api/v1/auth/me/security`, five serial requests after fixture readiness, all HTTP 200. Median/p95/max 482.2/1266.5/1266.5 ms; five-request burst median/p95/max 86.4/89.9/89.9 ms. Serial window server CPU 290 ms, RSS 511967232 bytes; no ETag on these sampled responses. Load inside lock 3.92/2.18/0.96. Shared release server source `cc25c441b7a974185622a1dee853cf38686d2b67`, binary SHA-256 `2f3567d91c34839851247bc0acbc25a56aaacd14dca269b8f0342ddf83447ed9`; embedded production SPA; Chromium browser on the build host through SSH/HTTPS. Server/Home/Index on perf VM HDD emulator: direct-I/O loop, 8 ms read/write dm-delay, 200 IOPS and 150 MiB/s caps. Every measured phase held `flock -w 14400 /root/perf.lock`. Qualification QD1 115.3 IOPS/8.028 ms median, QD16 200.7 IOPS/96.993 ms. Fixture: 366 Daily notes, 10,980 Logs, 100 Files/Photos, 20 Notes/Tasks, three Budgets and 100 transactions; Mail empty, Admin one User. Structural source evidence above is the newer audit base, not the measured binary revision. No claim that these revisions are equivalent. The baseline in docs/perf/baseline.json uses another fixture/build/transport; no regression ratio is valid here. See #663 for matching baseline endpoint values and coverage gaps.
Author
Owner

Client runtime audit for #663; keep with #642/#674/#692 and #698 (Admin).

Queued job/blaze-settings bf3ad5f29d keeps visited sections mounted and hidden, Settings [+page.svelte]:77–80,140–142,407–429. This improves warm traversal; do not discard it. However MyJobsGroup.svelte:31–37 and Admin JobsGroup.svelte:51–54 still subscribe on mount; jobs/api.ts:32–41 calls onchange for every SSE change. Hidden mounted job sections therefore continue full Resource.load requests and selected-job reads. Resource's generation guard prevents stale publication but does not cancel or coalesce those requests. TurnHistory also keeps a 30-second relative-time timer while hidden.

Provide an active/visible signal or move job data to the shared capped delta owner #668: while hidden retain snapshots and one dirty marker, then one capped catch-up on activation. Do not lose progress notifications. Test visiting User/Admin Background Work and then Appearance while job events arrive; hidden sections must not issue one full read per event. The Settings route still statically imports all section components (:46–58); use #642 traces to decide splitting, not a new duplicate chunk issue. No frame/latency measurement is claimed here.

Client runtime audit for #663; keep with #642/#674/#692 and #698 (Admin). Queued job/blaze-settings bf3ad5f29d1108c34e87c0e9d20b1dbe67ffc5c3 keeps visited sections mounted and hidden, Settings [+page.svelte]:77–80,140–142,407–429. This improves warm traversal; do not discard it. However MyJobsGroup.svelte:31–37 and Admin JobsGroup.svelte:51–54 still subscribe on mount; jobs/api.ts:32–41 calls onchange for every SSE change. Hidden mounted job sections therefore continue full Resource.load requests and selected-job reads. Resource's generation guard prevents stale publication but does not cancel or coalesce those requests. TurnHistory also keeps a 30-second relative-time timer while hidden. Provide an active/visible signal or move job data to the shared capped delta owner #668: while hidden retain snapshots and one dirty marker, then one capped catch-up on activation. Do not lose progress notifications. Test visiting User/Admin Background Work and then Appearance while job events arrive; hidden sections must not issue one full read per event. The Settings route still statically imports all section components (:46–58); use #642 traces to decide splitting, not a new duplicate chunk issue. No frame/latency measurement is claimed here.
Author
Owner

SQLite audit #663 on job/perf-arch-db. Base c4a61e8cf0; queued merge-round-7a 2f4482ded0 checked separately.

Precise pool evidence: the server already passes Db.writer_pool and Db.reader_pool to SqliteAuthStore::from_pools (wire.rs:1233). user() and session authentication use read_pool, but list_app_passwords() (:1181), list_sessions() (:2046), oidc_issuers() (:2403), legacy_recovery_codes() (:2412) still read self.pool, the single writer. This is partial reader adoption, not absence of a reader pool. Round 7a retains these writer-pool read methods. Move independent reads to read_pool; leave authority reads inside mutation transactions atomic. A held-writer integration test should prove Settings GET can read complete committed state without writer checkout. Long WAL writes do not inherently lock WAL readers; sharing the connection queue is the concrete problem.

Local query-work figures use Python SQLite 3.53.3 and synthetic data; VM callbacks count 1,000-instruction units. They are not production latency, CPU/RSS or HDD budget samples. The locked Rust bundled SQLite is 3.51.3. Repeat with audit-sqlite.py --plans and confirm the production-version plan before implementing. No existing assertion or product behavior was changed. Reuse this issue instead of filing a duplicate.

SQLite audit #663 on job/perf-arch-db. Base c4a61e8cf090170f35b1bed3350d9de20c83ecd5; queued merge-round-7a 2f4482ded066d9c5d9c59130377907f7fd2916c9 checked separately. Precise pool evidence: the server already passes Db.writer_pool and Db.reader_pool to SqliteAuthStore::from_pools (wire.rs:1233). user() and session authentication use read_pool, but list_app_passwords() (:1181), list_sessions() (:2046), oidc_issuers() (:2403), legacy_recovery_codes() (:2412) still read self.pool, the single writer. This is partial reader adoption, not absence of a reader pool. Round 7a retains these writer-pool read methods. Move independent reads to read_pool; leave authority reads inside mutation transactions atomic. A held-writer integration test should prove Settings GET can read complete committed state without writer checkout. Long WAL writes do not inherently lock WAL readers; sharing the connection queue is the concrete problem. Local query-work figures use Python SQLite 3.53.3 and synthetic data; VM callbacks count 1,000-instruction units. They are not production latency, CPU/RSS or HDD budget samples. The locked Rust bundled SQLite is 3.51.3. Repeat with audit-sqlite.py --plans and confirm the production-version plan before implementing. No existing assertion or product behavior was changed. Reuse this issue instead of filing a duplicate.
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kayg/calternal#692
No description provided.