Review adversarial Appearance and DAV PUT expectations #708

New issue

Open

opened 2026-10-02 09:21:02 +00:00 by kayg · 2 comments

kayg commented

2026-10-02 09:21:02 +00:00

Owner

Found during the single local adversarial round for calternal at head 9968f4d3f.

The current adversarial probe reported two contract mismatches:

appearance Auto default: expected no saved mode, but the new User response contained {"mode":"system"}.
DAV Journal accepts a well-formed alarm: the probe PUT an existing resource with If-Match and expected 201, but the server returned 204. The probe only adopts a new ETag when the status is 201, so subsequent cross-date move and delete requests used a stale ETag and returned 412.

Please check the intended default and conditional PUT contracts, then update the probe or product behavior through the normal owner decision. I did not change its existing expectations in this task.

Found during the single local adversarial round for calternal at head `9968f4d3f`. The current adversarial probe reported two contract mismatches: - `appearance Auto default`: expected no saved mode, but the new User response contained `{"mode":"system"}`. - `DAV Journal accepts a well-formed alarm`: the probe PUT an existing resource with `If-Match` and expected 201, but the server returned 204. The probe only adopts a new ETag when the status is 201, so subsequent cross-date move and delete requests used a stale ETag and returned 412. Please check the intended default and conditional PUT contracts, then update the probe or product behavior through the normal owner decision. I did not change its existing expectations in this task.

kayg referenced this issue

2026-10-02 09:37:02 +00:00

Calendar: new Task shows on the previous day and in the all-day lane; Tasks without dates should appear at the time they were added #655

kayg referenced this issue

2026-10-02 13:20:36 +00:00

Triage real-server API adversarial findings from #642 final round #664

kayg referenced this issue

2026-10-02 16:07:31 +00:00

Triage real-server API adversarial findings from #642 final round #664

kayg referenced this issue

2026-10-02 17:23:53 +00:00

Refresh stale Appearance and DAV adversarial API expectations #557

kayg commented

2026-10-02 17:23:59 +00:00

Author

Owner

Partial overlap with #557: both report an existing DAV Journal resource PUT returning 204 while the probe expects 201, then using a stale ETag and receiving 412. This issue also reports a distinct Appearance default-value mismatch; #557 reports a different Appearance payload field mismatch. Recommend link the shared DAV probe defect and keep the separate Appearance evidence in its own tracking issue. No test expectation should change without the owner decision.

kayg commented

2026-10-02 17:30:55 +00:00

Author

Owner

The DAV probe correction is committed in ff592fc23: it accepts 200/204 for an existing-resource PUT, requires a fresh response ETag, and adopts that value before later conditional requests. No DAV server change was needed.

For Appearance, the current server code returns no saved Auto setting when appearance.auto_scheme is absent, and appearance_auto_scheme.mjs asserts that a newly registered User receives null. The broad API probe remains strict. This job did not run a fresh API-only server round, so the earlier system observation remains unverified against this head. No Appearance behavior changed.

The DAV probe correction is committed in `ff592fc23`: it accepts 200/204 for an existing-resource PUT, requires a fresh response ETag, and adopts that value before later conditional requests. No DAV server change was needed. For Appearance, the current server code returns no saved Auto setting when `appearance.auto_scheme` is absent, and `appearance_auto_scheme.mjs` asserts that a newly registered User receives `null`. The broad API probe remains strict. This job did not run a fresh API-only server round, so the earlier `system` observation remains unverified against this head. No Appearance behavior changed.

kayg referenced this issue

2026-10-02 17:30:58 +00:00

Triage real-server API adversarial findings from #642 final round #664

kayg referenced this issue

2026-10-02 17:42:29 +00:00

Audit: open issue hygiene (duplicates, already fixed, stale) #866

kayg referenced this issue

2026-10-04 15:49:17 +00:00

Plan: merge order and conflicts for merge round 7b #867