kayg/calternal

Watch

Fork 0

Search deep links: same-route query changes do not restore the palette #773

New issue

Open

opened 2026-10-02 13:10:17 +00:00 by kayg · 3 comments

kayg commented

2026-10-02 13:10:17 +00:00

Owner

Found during the source review for #427 on origin/dev at c4a61e8cf090170f35b1bed3350d9de20c83ecd5.

Decided behavior

DESIGN §33 requires URL-to-view restoration for cold loads and back/forward, including the search query, scope and expanded state.

Evidence

apps/web/src/routes/search/+page.svelte:20–29 reads page.url.searchParams only in onMount. Its afterNavigate callback at lines 16–18 changes cameFromApp only. apps/web/src/routes/+layout.svelte:840 renders children without a URL-keyed remount. apps/web/src/lib/components/search-dialog.svelte:695 derives the copy URL from window state; it does not restore that state from navigation.

Observed behavior

A cold search URL is restored, but navigation between /search URLs can reuse the page component and leave the prior query, Calendar scope, subfolder setting or expanded state in the palette.

This is a source finding. No production build or live-server run was made in this review job.

Expected

Restore the palette from the current URL on relevant same-route navigation, including Back/Forward. Keep the URL-to-intent path in one place and avoid reopening on ordinary result updates.

Test idea

Visit /search?q=alpha, then navigate to /search?q=beta&view=all&scope=calendar&sub=0 without reloading. Assert query, scope, subfolders and expanded state. Back and Forward must restore each state.

For UI evidence, use a production build at 390, 820 and 1440 px in light and dark, with macOS platform hints. Check pointer, keyboard and touch, plus reduced motion.

Duplicate check

Searched all issue titles and search-link results. #167 is the general deep-link audit; #57 is the original palette feature. No specific same-route search-query restoration ticket found. This is a source finding; the test above must provide browser proof.

Found during the source review for #427 on `origin/dev` at `c4a61e8cf090170f35b1bed3350d9de20c83ecd5`. ## Decided behavior DESIGN §33 requires URL-to-view restoration for cold loads and back/forward, including the search query, scope and expanded state. ## Evidence `apps/web/src/routes/search/+page.svelte:20–29` reads page.url.searchParams only in onMount. Its afterNavigate callback at lines 16–18 changes cameFromApp only. `apps/web/src/routes/+layout.svelte:840` renders children without a URL-keyed remount. `apps/web/src/lib/components/search-dialog.svelte:695` derives the copy URL from window state; it does not restore that state from navigation. ## Observed behavior A cold search URL is restored, but navigation between /search URLs can reuse the page component and leave the prior query, Calendar scope, subfolder setting or expanded state in the palette. This is a source finding. No production build or live-server run was made in this review job. ## Expected Restore the palette from the current URL on relevant same-route navigation, including Back/Forward. Keep the URL-to-intent path in one place and avoid reopening on ordinary result updates. ## Test idea Visit /search?q=alpha, then navigate to /search?q=beta&view=all&scope=calendar&sub=0 without reloading. Assert query, scope, subfolders and expanded state. Back and Forward must restore each state. For UI evidence, use a production build at 390, 820 and 1440 px in light and dark, with macOS platform hints. Check pointer, keyboard and touch, plus reduced motion. ## Duplicate check Searched all issue titles and search-link results. #167 is the general deep-link audit; #57 is the original palette feature. No specific same-route search-query restoration ticket found. This is a source finding; the test above must provide browser proof.

kayg referenced this issue

2026-10-02 13:21:37 +00:00

Log attachments: deleted file still shown, attachments not live, batch send not live, Log order, raw camera names #427

kayg referenced this issue

2026-10-02 13:24:48 +00:00

Log attachments: deleted file still shown, attachments not live, batch send not live, Log order, raw camera names #427

kayg commented

2026-10-02 13:47:56 +00:00

Author

Owner

Additional source check: the route reads query parameters only during onMount; same-route navigation and Back/Forward do not refresh the Search window. I will exercise client-side navigation for query, scope, subfolder and expanded state.

Additional source check: the route reads query parameters only during `onMount`; same-route navigation and Back/Forward do not refresh the Search window. I will exercise client-side navigation for query, scope, subfolder and expanded state.

kayg commented

2026-10-02 14:56:02 +00:00

Author

Owner

Implemented #773 in d1460f667: Search state now restores after every navigation to /search, including same-route query changes and browser Back/Forward. The first external route still determines where closing Search returns. Added a regression that applies alpha → full Calendar-scoped beta in Projects with subfolders off → alpha and checks all URL-backed state. bun run test -- src/lib/search/route.svelte.test.ts: 1 passed. Production browser proof and the required screenshot matrix remain in the final verification pass.

Implemented #773 in `d1460f667`: Search state now restores after every navigation to `/search`, including same-route query changes and browser Back/Forward. The first external route still determines where closing Search returns. Added a regression that applies alpha → full Calendar-scoped beta in Projects with subfolders off → alpha and checks all URL-backed state. `bun run test -- src/lib/search/route.svelte.test.ts`: 1 passed. Production browser proof and the required screenshot matrix remain in the final verification pass.

kayg commented

2026-10-02 17:17:38 +00:00

Author

Owner

The #861 source audit confirms the current Search route still reads URL state only in onMount: apps/web/src/routes/search/+page.svelte:20-28. Its afterNavigate callback at lines 16-18 updates only cameFromApp, so same-route changes to q, view, scope or sub do not reapply the URL intent. This matches the behavior and expected fix already recorded here; no new issue is needed.

The #861 source audit confirms the current Search route still reads URL state only in `onMount`: `apps/web/src/routes/search/+page.svelte:20-28`. Its `afterNavigate` callback at lines 16-18 updates only `cameFromApp`, so same-route changes to `q`, `view`, `scope` or `sub` do not reapply the URL intent. This matches the behavior and expected fix already recorded here; no new issue is needed.

kayg referenced this issue

2026-10-02 17:34:54 +00:00

Deep-link audit: every item has Copy link, every link restores the exact view #167

kayg referenced this issue

2026-10-02 17:38:57 +00:00

Audit: deep links and Copy link coverage for every item type #861

kayg referenced this issue

2026-10-02 17:56:10 +00:00

Saved searches: Trash and Unpin have no Undo action #758

kayg referenced this issue

2026-10-03 06:29:49 +00:00

Saved searches: Trash and Unpin have no Undo action #758