Forward provider features so disabled crates add no work #66
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Problem and evidence
crates/agent/Cargo.toml:9-12defaults to both providers, whilecrates/server/Cargo.toml:22,62has unconditional Bollard and Docker dependencies and itsinfraternal-agentdependency does not disable default features. There is no top-level feature-forwarding matrix demonstrating that a disabled provider is absent from the dependency tree.Recommendation
Forward provider features from the binary/server with
default-features = falsewhere appropriate. Remove the server's provider-only dependency/error bridge as compatibility callers move. Add disabled/default/selected-provider compile checks and dependency-tree assertions before claiming feature-off savings.Payoff and estimate
Disabled providers add no native provider dependency or initialization work. Estimate: 1–2 engineering days after callers move; measure the feature-off build on the perf-test VM before reporting savings.
Priority: Next milestone (PLAN steps 3/8).
2026-10-04 owner decisions: Direct match: providers are compiled-in crates with zero cost when disabled. Performance numbers still require the perf-test-VM A/B. Related: #49.
Report: arch-review report
Source: arch-review 2026-10-04