Open
opened 2026-11-04 03:37:43 +00:00 by kayg
·
7 comments
No Branch/Tag specified
main
j470b-server-mesh-rejoin
mesh-compat-382
j444b-d381-key-wins-flood
j461b-macos-utun-reader-thread
j475b-remove-host-motion
fix-reconnect-new-link
j481-d380
dev
j479-mesh-soak
fix/j476-host-facts
j475-motion-pill-split
j470-mac-node-join
root-upgrade-d376
j474-review-merge
latency-targets-120hz
nightly-suite-shards
gotatun-pin-j469
macos-utun-reader-thread
fix-flood-echo-stall
wip/j416
motion-fast-ease-out
mesh-addhost-j259
takeover-close-terminals-d368
kbd-instant-followups
fix-trust-key-double-click
nightly-suite-partial-report
appwin-icons-j207
rusqlite-slice1
swipe-content-first-d374
mesh-mtu-381
addhost-instant-open
glass-contrast-d365-mock
glass-contrast-d365
signout-followups-442
fix-startup-toast-red
research-gotatun-matrix-j317
themes-sync-j304
fix-load-flakes
fix-nix-zig-patch
fix-compute01-browser-baseline
ratchet-size-baseline-419
predict-auto-d130
revoke-coverage-d367
nightly-suite-queue-timeout
nightly-browser-suite
fix-rustsec-2026-0459
fonts-ioskeley-obel
log-retention-d375
fix-kbd-no-anim-427
fix-dev-red-specs-2
takeover-proof-305-j205
wip/j410-server-pump
ui-consistency-d372
fix-osc52-clipboard
libghostty-vt-1.0
forget-retired-host-d369
j404-merge-426
fix-setup-lock-race
fix-touch-select-426
revoke-access-report-ui
fix-predictive-echo-specs
fix-selinux-agent-exec
wip/j395-checkpoint2
wip/j395
j391-review-scratch
ui-consistency-j195-deferred-rebased
fix-rustc-paths-421
decisions-wording-341
fix-install-suite-red
fix-dev-rtt-specs
fix-pending-removal-align
fix-privileged-skip
fix-install-suite-404
review-j368
mesh-dns-j254
revoke-access-report-d356b
revoke-privilege-round5
fix-removal-confirm
review-j360
gotatun-rotation-367
deps-refresh-340
review-j354
review-J351
review-j350
addhost-takeover-d359
revoke-report-items-347
revoke-end-sessions-d362
review-j348
size-mesh-ssh-346
size-trim-337
revoke-access-diff-d356
j259-pre-rebase-b06c5a6
j305-ended-at-start-spec
addhost-sudo-consent
fix-layout-real-specs-411
fix-shell-open-411
fix-console-hosts-373
fix-shell-exit
fuzz-host-name-353
fix-host-details-410
macos-filter-j197
research-gotatun-tricks
revoke-p3-j216l
stale-state-pill
revoke-followups-j216k
revoke-progress-j216e
backup/macos01-20261106/lume/j197
backup/macos01-20261106/lume/appwin-icons-j207-stash0
backup/macos01-20261106/claude/stash-0
backup/macos01-20261106/claude/stash-1
backup/macos01-20261106/claude/J80-macos-s1
backup/macos01-20261106/claude/J80
backup/macos01-20261106/claude/J80-slice1-20261102
backup/macos01-20261106/claude/J16b-appwin-on-dev
backup/macos01-20261106/claude/appwin-launch-idle-146
backup/macos01-20261106/claude/J80-s1-run
wip/j259
trust-285-p3c
runtime-lock-j216f
mesh-ssh-p3-j175
tun-proof-p3b
trust-285-p3
terminal-polish-j271
tun-proof-p3
ssh-install-flakes-j216i
fuzz-fixes-j264
trust-285-a
trust-285-b
restart-oversized-fixture-j198
backup/macos01-20261106/lume/appwin-icons-j207
restart-bound-j216h
up-preflight-p3-j198
backup/macos01-20261106/lume/j251
up-preflight-j198
wip/up-preflight-j198-j245-p2
wip/up-preflight-j198-j245-p1
agent-fsync-offloop-j196
wip/up-preflight-j198-j245
settings-offscreen-j231
wip/up-preflight-j198-j226-inspection
wip/j103f
themes-j206
wip/up-preflight-j198-j226
flakes-j216c
backup/macos01-20261106/claude/j197
flakes-j216b
backup/macos01-20261106/claude/j197-red
wip/up-preflight-j198-review
flakes-j216
backup/macos01-20261106/claude/appwin-icons-j207
engineering-j208b
appwin-mock-j209
toast-stack-j165
engineering-j208
decisions-d351
decisions-d350
decisions-d349
appearance-presets-mock-j129
decisions-d348
docs-audit-spec
doc-coverage-baseline-raise
decisions-d347
decisions-d346b
decisions-d346
j88h-profile
ui-consistency-j195-deferred
ui-consistency-j195
engineering-practices-j194
preferred-login-ui-j166
signin-pools-263-j174
macos-node-265-s1
decisions-d345
decisions-d344
proxy-cgroup-j164
verify-quick-fuzz-329
proxy-start-io-j168
timing-flakes-j163
up-263-s1
mcp-events-j147
verify-quick-fuzz-j158
proxy-p3-j159
agent-resource-j157-detect
wip/j103d-final
remote-cancel-hang-j155
proxy-traefik-281-j62d
j149-verify-quick
proxy-traefik-281-j62b
j150-drop-unnamed
wip/j79d-red-r4
wip/j103d-d332
rootless-toast-j142
wip/j103d-head
wip/j103d
j125c-mcp
macos-build-j136
backup/macos01-20261106/claude/j136
wip/j79d-red-cli
wip/j79d-red-server
j121-link-liveness
j118c-tracer-failures
wip/j79c-head
release-desktop-j131
j124c-signed-macos
wip/j79c-red-p3
wip/j79c-red-p23
wip/j79c-red-p22
merge-j128-check
perf-deferred-j128
sidebar-toggle-260
j127-shortcut-changed-dot
j125-mcp
j118-tracer-failures
j126-account-summary
settings-sections-mock-j92
j120-pinch-lock
sidebar-292
backup/macos01-20261106/claude/j120
taste-2026-11-03
row-actions-242-215
backup/macos01-20261106/claude/stash-0-untracked
backup/macos01-20261106/claude/J80-265-s1-run
backup/macos01-20261106/claude/J80-macos-s1-20261102
j112-canvas-commands
ui-no-overshoot-scroll
fix-recovery-restart
backup/macos01-20261106/claude/stash-1-untracked
taste-2026-11-02
size-baseline-ratchet
machine-cards-structure-j108
j109-boot-copy-mockups
fix-dev-red
wip/up-263-s1
j95b-settings-rows
proxy-traefik-281
j95-option-rows
docs-human-j91
docs-keys-palette
fix-flood-1013-270-j38d
mesh-ssh-s1
mesh-ssh-s0
addhost-d291-tunnel
test-stability-load
mesh-relay-220
repro-296
shim-thp-off-24
mesh-pins-258-v2
mesh-dns
signin-d311-merged
docs-pages
ui-size-283
fix-ui-batch-specs
wip/j12b-edge-update
gate-on-arm
fix-rename-sync-293
trust-285-j60b
fix-focus-ring-clip
integ-ui-1101
edge-update-v2
signin-d311
taste-2026-11-01
layout-per-tab-250
ui-approved-splitopt-224
ui-approved-splitopt-224-on-dev
icon-text-centre-282
ui-approved-189-212-216
research-reverse-proxy
transfer-budget-320
review-mesh-pins-258-r2
sidebar-pill-259
review-mesh-relay-220
wip/j12-edge-update-v2
nix-package
status-crash-loop-237
fix-dev-test-failures
fix-fixture-socket-path
wip/mesh-relay-220-pre-dev-advance-rebase
fix-canvas-side-clip
research-head-to-head
frosted-real-256
review-mesh-pins-258
wip/mesh-relay-220-pre-final-rebase
review-layout-per-tab-250-r2
broad-suite-triage
nix-devshell
review-status-crash-loop-237-r3
wip/nix-devshell-pre-p3
taste-frosted-real
wip/code-serve-demo-2026-10-30
wip/code-serve-glass-2026-10-30
wip/code-serve-clusters-2026-10-30
wip/code-merge-release94-dev-2026-10-30
wip/rproxy-delta-scratch-2026-10-30
wip/stale-note-257-staged-2026-10-30
wip/d241-size-staged-2026-10-30
review-broad-suite-207
wip/mesh-pins-258-pre-split
wip/mesh-relay-220-pre-rebase
mesh-measure-220
plan-211-update
review-edge-autoupdate-r3
perf24-reconnect
review-stale-note-r2
release-prod-live
d241-shell-marker
review-mesh-pins-server-258
review-revocation-r3
review-setup-token-r2
review-sync-journal-r3
wip/review-mesh-pins-258-prune-review-1995fee46
frosted-scroll-256
sync-journal-r3
revocation-per-account-wip
review-tokio-asyncfd-0386
review-sync-p3s
wip/stash-8by64-stash0-2026-10-30
mesh-drag-r2
setup-token-data-wip
release-9-4
auth-busy-1013
mesh-view-overlap
sync-p3s
review-auth-busy-wake
review-readd-r8-wip
mesh-drag-bounds
audit-auth-93
app-windows-stream-start
review-authority-cap-r3
app-windows-r7-measure
readd-minimal-r6
readd-minimal-r5
app-windows-r7-soak
readd-minimal-r4
app-windows-r7
app-windows-r6
readd-minimal-r3
readd-minimal-r2
readd-minimal
merge-release8-dev
review-busy-page-liveness-r2
review-busy-page-liveness
mesh-view-trim
review-authority-read-retry-r2
review-remove-uninstall-r2
release-retry-reattach
release-retry
review-remove-uninstall
review-authority-read-retry
app-windows-ship
mesh-autoswitch-p2
mesh-ssh
mesh-relay
mesh-macos-node
screen-and-control
session-labels
review-real-logins-r5
review-real-logins-r4
review-real-logins-r3
shim-memory-r2
review-real-logins-r2
shim-memory
shadow-addhost-instant
shadow-real-logins
shadow-same-session-flood
shadow-prod-perf-fix
hosts-from-server
app-windows-real
app-windows-transport
release-prod-6w
mesh-policy-verify
quiet-close-toast
dev-merge-r4
review-mesh-agent-transport
review-app-windows-transport
settings-roundtrip
review-release-pipeline-r4
mesh-agent-transport
ended-strip-fix
review-audit-ca-update-d244
settings-rows
phone-width
signout-clear
fix-restart-tests
dev-merge-rp
signer-hardening
review-audit-ca-update
terminal-fidelity
review-audit-ca-update-wip
mesh-integrate
review-mesh-agent-transport-515d3712
review-mesh-dataplane-feec1988
mesh-dataplane
signout
research-canvas-node
wip/review-renderer-cost
wip/review-terminal-fidelity
padlock-glyph
review-release-pipeline-2e95b689
phone-polish
sidebar-polish
inbox-generic
review-mesh-dataplane-378d4055
prod-batch
ui-inbox
ui-ca-unlock
ui-machine-sections
review-mesh-dataplane-a5f744fb
tls-session-prod
session-bounds-prod
fix-dead-session
session-bounds
tls-session
palette-polish
shortcuts-d222
research-appmeta
phone-gutter
ui-centre-button
wip/ui-centre-button
wip/tls-session
review-addhost-breakit
ui-platform
renderer-cost
remote-agents
mesh-api
ssh-bootstrap
prod-hotfix2
prod-fixes
review-remote-agents
review-mesh-dataplane
session-life
research-browser
review-mesh-api
research-capture
review-mesh-api-round3
review-mesh-api-round1
gate-stability
review-gate-stability
review-relay-direct
review-mesh-api-findings
proto-sessions
font-picker
proto-addhost
proto-windows
mesh-core
latency-gate
research-bsd
research-discovery
keytray-mods
mock-core
ui-tweaks
fix-motion-sel
fix-motion
integrate2
fix-robust
t-web
t-server
vt-ghostty
fix-snap-echo
t-web-auth
review-vt2
t-agent
lane-protocol
lane-shim
lane-auth
s1-base
s1-contracts
s1-workspace
No results found.
No labels
launch-qa
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set
Reference
kayg/infraternal#335
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
J165 (UI): stack toasts instead of replacing them. Linked to #327 (rootless refusal) and D336.
Owner (D336): "doesn't svelte-sonner allow for this? the calternal thread took that base of svelte-sonner and rewrote it to be smaller and to its needs. it behaves the same way though so stack them."
Problem: the shared toast in packages/ui shows one message at a time. On a rootless first load the "can't open a shell" error was replaced by "unlock host connections".
Scope
Branch: toast-stack-j165, base origin/dev
109e14cb71.Plan and estimate: read calternal + callers (20 min), stack core in toast.ts + CSS (60 min), copy change (5 min), specs (40 min), screenshots + gate on compute01 (40 min).
Finding 1 (started; branch toast-stack-j165, base
109e14cb7): the owner's calternal toast code is on branchtrain/2026-11-04-bm14d(packages/ui/src/primitives/toast/*.svelte.ts, Toasts.svelte), not onmain. Evidence:grep -ril sonnerover every file there returns nothing, and no file carries a licence header. It is a plain column: VISIBLE=3, a per-toast clock paused by hold reasons (mouse, focus, touch), swipe down to dismiss. It has no compressed stack behind the newest toast and no expand-on-hover.Decision: I port the approach (VISIBLE cap, per-toast clock with hold reasons, swipe threshold) as fresh vanilla TS in packages/ui/src/toast.ts. The compressed-behind/expand layout is written from svelte-sonner's documented behaviour only. No third-party source is copied, so THIRD_PARTY_NOTICES.md is unchanged.
Also: terminal-refusal.ts already has the requested text for
permission;no_loginstill has the long one. I will shortenno_loginto the same sentence (owner D336 asks for a shorter message) unless told otherwise.Progress (head
9cbbdae42, pushed to toast-stack-j165):e8d61d3af: both rootless reasons use the short sentence (open-refusal unit test + real rootless spec updated).251b4607f: stacked toast core in packages/ui/src/toast.ts + styles.css.show()now returns an id;dismiss(id)removes one toast, a baredismiss()removes every non-error toast. Owners that show errors or their own prompts (status relay, authority unlock, recovery notice) dismiss by id.9cbbdae42: apps/tracer/test/toast-stack.spec.ts (1440x900 and 393x852) and awindow.__toasthook behind__CLUSTERS_PREVIEW__(removed from the product build).Next: browser spec run (queued in build-slot on compute01, log ~/.cache/codex-scratch/j165/spec.log), budget numbers,
scripts/verify fast, screenshots.Orchestrator: deploy request (J165): please deploy branch
toast-stack-j165at head918c45db2to https://test.ssh.kayg.org (unitinfraternal-test). The real first-load case I want to see: sign in on a rootless server with a locked authority. The refusal ("This server runs without root, so it can only open shells as its own user. Add a host to work elsewhere.") and "Unlock host connections" should both stay on screen as a stack. I can't do this myself and have no way to run it for real until it is deployed.Evidence at
918c45db2(browser spec on compute01, production-built preview build):bun x playwright test test/toast-stack.spec.tsat 1440x900 and 393x852: 23 passed (2.5m), SPEC_EXIT=0.?theme=takes theme ids, so the first "dark" captures were light.109e14cb7-> branch: critical gzip 318,131 -> 319,430 B (+1,299; cap 327,680), brotli 265,715 -> 266,872 B (+1,157; cap 273,408); deferred gzip 54,302 -> 54,306 B (+4), brotli +85; on-demand largest chunk 16,215 -> 16,217 B gzip. Thewindow.__toasthook is behind__CLUSTERS_PREVIEW__, so it adds nothing to the product build.Question for kayg (recommendation: leave it): at 393 px the rootless sentence wraps to 4 lines (306 px of text in a 362 px card at 16 px touch text), one more than "about 3". Getting to 3 would need narrower phone insets or smaller touch text, and D174 fixes the type scale. I kept the owner's sentence and the type scale.
Gate status at
918c45db2(dev-02, build-slot):scripts/verify fast: Rusttestrow FAIL (101):real_binary_keeps_background_backend_probe_off_the_control_path(crates/infraternal/tests/agent_daemon.rs:15) panicked on a Pythonprobe_listener.accept()TimeoutError in scripts/verify-agent-lazy-manager.py. Every other Rust row PASS (fmt, clippy, cargo-deny, gate architecture, static builds). Because the Rust half failed,ts_verify_fastdid not run in that pass.source scripts/verify.d/ts.sh; ts_verify_fast): TS_EXIT=0 (tracer typecheck, unit tests, build, transfer budget).109e14cb7(1 passed, 1.25 s). My change touches no Rust, so I read run 1 as a load timeout (the VM had other jobs), not a regression, but I do not call run 1 green.scripts/verify fastre-queued on dev-02 (log ~/.cache/codex-scratch/j165/gate.log); I will post its verbatim result.Final report (J165), branch
toast-stack-j165, head918c45db2.Done: stacked toasts (newest in front, older compressed behind, fan out on hover/focus, cap 3 drawn, one clock per toast held while the stack is held, touch swipe, count for repeats, in-place morph, errors never removed or hidden by later notices), short rootless sentence for both reasons, spec at 1440x900 and 393x852 (23 passed), screenshots attached above (dark and light).
Gate, verbatim (
scripts/verify fastdoes NOT pass in a single run; evidence follows):real_binary_keeps_background_backend_probe_off_the_control_path(a socket accept timeout); that test passes on the branch on retry and on origin/dev. Run 2 failed in threeremote_clienttiming tests; the same three fail on unmodified origin/dev109e14cb7and pass on the branch alone. This change contains no Rust.ts_verify_fast) ran on its own: TS_EXIT=0. It does not run insideverify fastonce the Rust half fails.Still open: the real first-load check needs the deploy asked for above. The phone rootless sentence is 4 lines, not 3 (question above, recommendation: leave it).
Real first-load check on https://test.ssh.kayg.org, deployed head
918c45db2(rootless unit, fresh profile and real passkey sign-in per case via sw-authenticator, theme set with?theme=mocha|latte). Screenshots attached: desktop 1440x900 and phone 393x852 (touch, 2x), dark and light, collapsed, plus the desktop stack fanned out on hover.What the real server did, same in all four cases (timeline from sampling
.ui-toastevery 150 ms after "Open shell on ssh"):data-hidden="false").Before this change the same sequence replaced the first toast with the second.
What I could not show for real, and why:
an error is never removed or hidden by later notices, 100 % of 5 later notices at 1440x900 and 393x852), not by this real run.Two real bugs found by this check, fixed in
b2403663b(not yet deployed):transform: noneon every toast, which would flatten the stack.New spec checks cover the first and third. Browser spec rerun with the fixes is queued (build-slot, compute01).
Request: please redeploy
toast-stack-j165atb2403663bso I can recapture the four cases with the fixes. Accepted per your note: 4-line phone wrap (D174).Update: head is now
39709a52e(fixesb2403663bplus a spec correction). Browser spec on compute01: 25 passed (3.2m), SPEC_EXIT=0, at 1440x900 and 393x852. The unit tests are unchanged by these CSS-only fixes;scripts/verify fastwas not re-run for them (earlier gate result at918c45db2stands, with its two known timing-test failures that also fail on origin/dev).Orchestrator: when you put the test server back, please deploy
39709a52efirst only if you want me to recapture the four real cases with the fixes; otherwise the real run above (at918c45db2) is the evidence and the fixes are covered by the spec. Not claimed as verified for real: "Unlock host connections" next to the refusal (CA is unlocked on the test unit), and a later info toast after the error (no real action raises one).