kayg/calternal-v0
Archived
Watch
1
0
Fork
You've already forked calternal-v0
 0
Code Issues 1.1k Pull requests Projects Releases Packages Wiki Activity Actions

Hide any item (⋯ → Hide) with one reserved marker across the app #1153

Open
opened 2026-10-05 15:22:42 +00:00 by kayg · 64 comments
kayg commented 2026-10-05 15:22:42 +00:00
Owner
Copy link

Owner decision (2026-10-05): Hide for every item, one marker

"Please add hiding functionality to Notes: ⋯ menu → Hide. I want something that works for all elements in the app."

Marker

The reserved tag _calternal/hidden (written #_calternal/hidden in Markdown lines) is THE hide marker for every item kind. It already exists for Calendar Log entries (calternal-notes-core dayfile.rs: written as #_calternal/hidden, parsed into hidden: bool, filtered out of user-facing tags; Calendar ⋯ → Hide, #1099). Extend the same marker, stored wherever that item kind keeps its tags:

  • Notes and Canvases: frontmatter tags: list.
  • Log entries / Events in day files: as today.
  • Tasks: the Task's tags.
  • Files and folders: the per-folder .calternal.json tags (DESIGN tags section).
  • Photos: XMP keywords (the same sidecar Photos tags use).
    One shared predicate/helper per side (Rust and web) decides "is hidden"; the marker never appears in tag lists, tag counts, tag autocomplete, the Tags page, exported tag clouds, or sync output as a user tag. Do not invent a second mechanism (no calternal-show, no plain #hidden).

Behaviour

  • ⋯ → Hide on every item (Notes, Canvases, Events/Log entries, Tasks, Files, folders, Photos, albums where they are items, saved searches if they have ⋯) with an Undo toast (actionable, fits #1142).
  • Hidden items are left out of lists, the sidebar/Notes tree, Calendar views, Agenda, Tasks views, Files and Photos grids, search results and the palette by default.
  • Each Tab's view menu has Show hidden (per User preference, like Files' "Show hidden files"): hidden items appear dimmed with ⋯ → Unhide.
  • Search operator is:hidden (and -is:hidden) per DESIGN search grammar.
  • Deep links still open a hidden item; it shows a small "Hidden" badge with an Unhide action.
  • Hiding is presentation only, not access control: Shares and other Users with access still see the item. Say so in the Hide confirmation text only if the item is shared ("Hidden for you. People you shared it with still see it.").
  • CLI/API/MCP parity: hide/unhide actions and the hidden field on item payloads.

Evidence

Unit tests per storage format (round-trip, marker never in user tags, idempotent hide/unhide, hand-written #_calternal/hidden), search filter tests, cross-user (hiding does not hide for a share recipient). e2e like a User: hide a Note from ⋯, it disappears from the tree and search, Undo restores; Show hidden shows it dimmed; Unhide. Screenshots per Tab at 1440 and 390, light + dark, including the dimmed state and the deep-link badge.

## Owner decision (2026-10-05): Hide for every item, one marker "Please add hiding functionality to Notes: ⋯ menu → Hide. I want something that works for all elements in the app." ### Marker The reserved tag `_calternal/hidden` (written `#_calternal/hidden` in Markdown lines) is THE hide marker for every item kind. It already exists for Calendar Log entries (calternal-notes-core dayfile.rs: written as ` #_calternal/hidden`, parsed into `hidden: bool`, filtered out of user-facing tags; Calendar ⋯ → Hide, #1099). Extend the same marker, stored wherever that item kind keeps its tags: - Notes and Canvases: frontmatter `tags:` list. - Log entries / Events in day files: as today. - Tasks: the Task's tags. - Files and folders: the per-folder `.calternal.json` tags (DESIGN tags section). - Photos: XMP keywords (the same sidecar Photos tags use). One shared predicate/helper per side (Rust and web) decides "is hidden"; the marker never appears in tag lists, tag counts, tag autocomplete, the Tags page, exported tag clouds, or sync output as a user tag. Do not invent a second mechanism (no `calternal-show`, no plain `#hidden`). ### Behaviour - ⋯ → **Hide** on every item (Notes, Canvases, Events/Log entries, Tasks, Files, folders, Photos, albums where they are items, saved searches if they have ⋯) with an Undo toast (actionable, fits #1142). - Hidden items are left out of lists, the sidebar/Notes tree, Calendar views, Agenda, Tasks views, Files and Photos grids, search results and the palette by default. - Each Tab's view menu has **Show hidden** (per User preference, like Files' "Show hidden files"): hidden items appear dimmed with ⋯ → **Unhide**. - Search operator `is:hidden` (and `-is:hidden`) per DESIGN search grammar. - Deep links still open a hidden item; it shows a small "Hidden" badge with an Unhide action. - Hiding is presentation only, not access control: Shares and other Users with access still see the item. Say so in the Hide confirmation text only if the item is shared ("Hidden for you. People you shared it with still see it."). - CLI/API/MCP parity: hide/unhide actions and the `hidden` field on item payloads. ### Evidence Unit tests per storage format (round-trip, marker never in user tags, idempotent hide/unhide, hand-written `#_calternal/hidden`), search filter tests, cross-user (hiding does not hide for a share recipient). e2e like a User: hide a Note from ⋯, it disappears from the tree and search, Undo restores; Show hidden shows it dimmed; Unhide. Screenshots per Tab at 1440 and 390, light + dark, including the dimmed state and the deep-link badge.
files-unhidden-phone-dark.png
126 KiB
files-unhidden-phone-light.png
159 KiB
files-unhidden-tablet-dark.png
397 KiB
files-unhide-action-desktop-dark.png
120 KiB
files-unhide-action-desktop-light.png
153 KiB
files-unhide-action-phone-dark.png
59 KiB
files-unhide-action-tablet-light.png
112 KiB
folders-deep-link-desktop-dark.png
361 KiB
folders-hidden-off-phone-light.png
155 KiB
folders-hidden-off-tablet-dark.png
394 KiB
folders-hidden-tablet-dark.png
399 KiB
folders-unhidden-desktop-dark.png
369 KiB
folders-unhidden-desktop-light.png
537 KiB
folders-unhidden-phone-dark.png
126 KiB
folders-unhidden-phone-light.png
159 KiB
folders-unhidden-tablet-dark.png
397 KiB
folders-unhidden-tablet-light.png
474 KiB
files-unhidden-tablet-light.png
474 KiB
files-unhide-action-phone-light.png
67 KiB
files-unhide-action-tablet-dark.png
93 KiB
folders-deep-link-desktop-light.png
530 KiB
folders-deep-link-phone-dark.png
120 KiB
folders-deep-link-phone-light.png
154 KiB
folders-deep-link-tablet-dark.png
392 KiB
folders-hidden-desktop-light.png
537 KiB
folders-hidden-off-desktop-dark.png
364 KiB
folders-hidden-off-desktop-light.png
533 KiB
folders-hidden-off-tablet-light.png
471 KiB
folders-hidden-phone-dark.png
127 KiB
folders-hidden-phone-light.png
160 KiB
folders-hidden-tablet-light.png
475 KiB
folders-unhide-action-desktop-dark.png
123 KiB
folders-unhide-action-phone-dark.png
60 KiB
hide5-gate-evidence.zip
854 KiB
folders-unhide-action-desktop-light.png
158 KiB
folders-unhide-action-tablet-dark.png
95 KiB
folders-unhide-action-tablet-light.png
114 KiB
photo-viewer-hidden-phone-light.png
29 KiB
photo-viewer-hidden-tablet-dark.png
16 KiB
photo-viewer-hidden-tablet-light.png
19 KiB
photos-hidden-off-phone-dark.png
127 KiB
photos-hidden-off-phone-light.png
158 KiB
photos-hidden-off-tablet-dark.png
392 KiB
photos-hidden-off-tablet-light.png
470 KiB
photos-hidden-phone-dark.png
114 KiB
photos-hidden-phone-light.png
145 KiB
photos-hidden-tablet-dark.png
386 KiB
photos-hidden-tablet-light.png
462 KiB
photos-unhidden-phone-dark.png
108 KiB
photos-unhidden-tablet-dark.png
375 KiB
photos-unhide-action-desktop-light.png
130 KiB
photos-unhide-action-phone-dark.png
51 KiB
photos-unhide-action-tablet-dark.png
88 KiB
photos-unhide-action-tablet-light.png
109 KiB
tasks-deep-link-desktop-light.png
546 KiB
tasks-deep-link-phone-dark.png
121 KiB
tasks-deep-link-phone-light.png
150 KiB
tasks-deep-link-tablet-light.png
472 KiB
tasks-hidden-desktop-dark.png
360 KiB
tasks-hidden-desktop-light.png
531 KiB
tasks-hidden-off-desktop-light.png
524 KiB
tasks-hidden-off-tablet-light.png
462 KiB
tasks-hidden-phone-dark.png
112 KiB
tasks-hidden-phone-light.png
147 KiB
tasks-hidden-tablet-dark.png
389 KiB
tasks-hidden-tablet-light.png
469 KiB
tasks-unhidden-desktop-dark.png
360 KiB
photo-viewer-hidden-desktop-light.png
28 KiB
photo-viewer-hidden-phone-dark.png
23 KiB
photos-hidden-desktop-light.png
515 KiB
photos-hidden-off-desktop-dark.png
364 KiB
photos-hidden-off-desktop-light.png
530 KiB
photos-unhidden-desktop-dark.png
336 KiB
photos-unhidden-desktop-light.png
492 KiB
photos-unhidden-phone-light.png
139 KiB
photos-unhidden-tablet-light.png
448 KiB
photos-unhide-action-phone-light.png
56 KiB
tasks-deep-link-desktop-dark.png
381 KiB
tasks-deep-link-tablet-dark.png
398 KiB
tasks-hidden-off-desktop-dark.png
352 KiB
tasks-hidden-off-phone-light.png
143 KiB
tasks-hidden-off-tablet-dark.png
384 KiB
tasks-unhidden-phone-light.png
146 KiB
tasks-unhide-action-desktop-dark.png
365 KiB
tasks-unhide-action-phone-light.png
149 KiB
tasks-unhide-action-tablet-dark.png
378 KiB
plain-canvas-hidden-phone-light.png
155 KiB
plain-canvas-hidden-tablet-light.png
467 KiB
shared-log-hidden-phone-dark.png
111 KiB
shared-log-hidden-phone-light.png
272 KiB
shared-log-link-desktop-light.png
533 KiB
shared-log-link-phone-dark.png
117 KiB
shared-log-link-phone-light.png
150 KiB
shared-log-link-tablet-dark.png
393 KiB
shared-note-link-desktop-dark.png
338 KiB
shared-note-link-phone-light.png
149 KiB
shared-note-link-tablet-dark.png
370 KiB
shared-task-hidden-phone-dark.png
110 KiB
shared-task-hidden-phone-light.png
160 KiB
shared-task-hidden-tablet-light.png
485 KiB
shared-task-link-desktop-dark.png
366 KiB
shared-task-link-tablet-dark.png
450 KiB
plain-canvas-link-desktop-dark.png
132 KiB
plain-canvas-link-desktop-light.png
179 KiB
plain-canvas-link-phone-dark.png
34 KiB
plain-canvas-link-phone-light.png
43 KiB
plain-canvas-link-tablet-dark.png
144 KiB
plain-canvas-link-tablet-light.png
161 KiB
tasks-unhidden-desktop-light.png
530 KiB
tasks-unhidden-phone-dark.png
112 KiB
tasks-unhidden-tablet-dark.png
387 KiB
tasks-unhidden-tablet-light.png
466 KiB
shared-log-hidden-desktop-light.png
549 KiB
shared-log-hidden-tablet-dark.png
403 KiB
shared-log-hidden-tablet-light.png
484 KiB
shared-log-link-desktop-dark.png
368 KiB
shared-note-link-desktop-light.png
511 KiB
shared-note-link-phone-dark.png
114 KiB
shared-note-link-tablet-light.png
452 KiB
shared-notes-hidden-desktop-dark.png
341 KiB
shared-notes-hidden-desktop-light.png
514 KiB
shared-notes-hidden-phone-dark.png
114 KiB
shared-notes-hidden-phone-light.png
149 KiB
shared-notes-hidden-tablet-dark.png
375 KiB
shared-notes-hidden-tablet-light.png
453 KiB
shared-task-hidden-desktop-dark.png
678 KiB
shared-task-hidden-desktop-light.png
550 KiB
shared-task-link-desktop-light.png
539 KiB
shared-task-link-phone-dark.png
117 KiB
shared-task-link-phone-light.png
149 KiB
shared-task-link-tablet-light.png
582 KiB
plain-canvas-hidden-desktop-dark.png
348 KiB
plain-canvas-hidden-desktop-light.png
524 KiB
plain-canvas-hidden-phone-dark.png
119 KiB
tasks-unhide-action-desktop-light.png
531 KiB
calendar-hidden-desktop-dark.png
375 KiB
calendar-hidden-desktop-light.png
550 KiB
calendar-hidden-phone-dark.png
130 KiB
calendar-hidden-phone-light.png
165 KiB
calendar-hidden-tablet-dark.png
405 KiB
calendar-hidden-tablet-light.png
486 KiB
files-hidden-desktop-dark.png
372 KiB
files-hidden-desktop-light.png
541 KiB
files-hidden-phone-dark.png
131 KiB
files-hidden-phone-light.png
163 KiB
files-hidden-tablet-light.png
475 KiB
folders-hidden-desktop-dark.png
686 KiB
folders-hidden-desktop-light.png
540 KiB
folders-hidden-phone-dark.png
130 KiB
folders-hidden-phone-light.png
163 KiB
folders-hidden-tablet-dark.png
400 KiB
folders-hidden-tablet-light.png
475 KiB
note-deep-link-desktop-light.png
516 KiB
note-deep-link-phone-dark.png
123 KiB
note-deep-link-phone-light.png
160 KiB
note-deep-link-tablet-dark.png
369 KiB
note-deep-link-tablet-light.png
456 KiB
note-header-4x-dark.png
284 KiB
notes-hidden-desktop-light.png
517 KiB
notes-hidden-off-desktop-dark.png
342 KiB
notes-hidden-off-desktop-light.png
514 KiB
notes-hidden-off-phone-dark.png
114 KiB
notes-hidden-off-phone-light.png
148 KiB
notes-hidden-off-tablet-light.png
452 KiB
notes-hidden-phone-dark.png
116 KiB
notes-hidden-phone-light.png
151 KiB
hide5-calendar-part1.zip
2.9 MiB
hide5-calendar-part4.zip
1.7 MiB
hide5-files-part1.zip
2.5 MiB
hide5-folders-part1.zip
2.9 MiB
hide5-folders-part2.zip
2.7 MiB
hide5-folders-part3.zip
3 MiB
hide5-folders-part4.zip
114 KiB
hide5-known-gap-part1.zip
167 KiB
hide5-note-part1.zip
2.5 MiB
hide5-notes-part2.zip
2.7 MiB
hide5-photo-part1.zip
116 KiB
note-header-4x-light.png
301 KiB
notes-hidden-desktop-dark.png
344 KiB
notes-hidden-off-tablet-dark.png
376 KiB
notes-hidden-tablet-dark.png
377 KiB
notes-hidden-tablet-light.png
454 KiB
photos-hidden-desktop-dark.png
351 KiB
photos-hidden-desktop-light.png
518 KiB
photos-hidden-phone-dark.png
117 KiB
photos-hidden-phone-light.png
148 KiB
photos-hidden-tablet-dark.png
388 KiB
photos-hidden-tablet-light.png
462 KiB
tasks-hidden-desktop-dark.png
363 KiB
tasks-hidden-desktop-light.png
534 KiB
tasks-hidden-phone-dark.png
226 KiB
tasks-hidden-phone-light.png
262 KiB
tasks-hidden-tablet-dark.png
391 KiB
tasks-hidden-tablet-light.png
469 KiB
hide3-review-1.zip
6.5 MiB
hide3-review-2.zip
6.6 MiB
hide3-review-3.zip
6.6 MiB
hide5-calendar-part2.zip
2.7 MiB
hide5-calendar-part3.zip
2.9 MiB
hide5-files-part2.zip
2.8 MiB
hide5-files-part3.zip
1.4 MiB
hide5-photos-part1.zip
2.7 MiB
hide5-search-part1.zip
1.1 MiB
hide5-shared-part5.zip
467 KiB
hide5-tag-part1.zip
2.8 MiB
calendar-deep-link-desktop-light.png
542 KiB
calendar-deep-link-phone-dark.png
117 KiB
hiderev2-1153-gate-evidence.zip
434 KiB
calendar-deep-link-tablet-light.png
469 KiB
calendar-hidden-desktop-dark.png
372 KiB
calendar-hidden-desktop-light.png
547 KiB
calendar-hidden-off-desktop-light.png
549 KiB
calendar-hidden-off-tablet-light.png
484 KiB
calendar-hidden-tablet-dark.png
403 KiB
calendar-hidden-tablet-light.png
485 KiB
calendar-unhidden-desktop-dark.png
372 KiB
calendar-unhidden-desktop-light.png
548 KiB
calendar-unhidden-phone-dark.png
127 KiB
hide5-photos-part2.zip
3 MiB
hide5-photos-part3.zip
983 KiB
hide5-plain-part1.zip
2.6 MiB
hide5-shared-part1.zip
2.9 MiB
hide5-shared-part2.zip
3 MiB
hide5-shared-part3.zip
2.9 MiB
hide5-shared-part4.zip
2.5 MiB
calendar-deep-link-desktop-dark.png
385 KiB
calendar-deep-link-phone-light.png
145 KiB
calendar-deep-link-tablet-dark.png
398 KiB
calendar-hidden-off-desktop-dark.png
373 KiB
calendar-hidden-off-phone-light.png
160 KiB
calendar-hidden-off-tablet-dark.png
403 KiB
calendar-hidden-phone-dark.png
109 KiB
calendar-hidden-phone-light.png
162 KiB
calendar-unhide-action-tablet-dark.png
401 KiB
calendar-unhide-action-tablet-light.png
475 KiB
files-deep-link-desktop-dark.png
24 KiB
files-deep-link-desktop-light.png
26 KiB
files-hidden-desktop-light.png
537 KiB
files-hidden-off-desktop-dark.png
363 KiB
files-hidden-off-desktop-light.png
532 KiB
files-hidden-off-phone-dark.png
120 KiB
files-hidden-off-phone-light.png
154 KiB
hide5-tag-part2.zip
2.7 MiB
hide5-tasks-part1.zip
2.9 MiB
hide5-tasks-part2.zip
2.7 MiB
hide5-tasks-part3.zip
2.8 MiB
calendar-unhidden-phone-light.png
162 KiB
calendar-unhidden-tablet-dark.png
403 KiB
calendar-unhidden-tablet-light.png
484 KiB
calendar-unhide-action-desktop-dark.png
377 KiB
calendar-unhide-action-phone-dark.png
131 KiB
files-deep-link-phone-light.png
22 KiB
files-deep-link-tablet-light.png
24 KiB
files-hidden-desktop-dark.png
369 KiB
files-hidden-off-tablet-dark.png
394 KiB
files-hidden-off-tablet-light.png
470 KiB
files-hidden-phone-light.png
160 KiB
files-hidden-tablet-dark.png
399 KiB
files-hidden-tablet-light.png
475 KiB
files-unhidden-desktop-dark.png
369 KiB
hide5-tag-part3.zip
2.9 MiB
hide5-tag-part4.zip
1.6 MiB
hide5-tasks-part4.zip
1.6 MiB
files-unhidden-desktop-light.png
537 KiB
tasks-unhide-action-tablet-light.png
453 KiB
folders-unhide-action-phone-light.png
67 KiB
photos-unhide-action-desktop-dark.png
101 KiB
shared-log-hidden-desktop-dark.png
676 KiB
shared-task-hidden-tablet-dark.png
403 KiB
plain-canvas-hidden-tablet-dark.png
385 KiB
tasks-hidden-off-phone-dark.png
108 KiB
photo-viewer-hidden-desktop-dark.png
26 KiB
folders-hidden-desktop-dark.png
369 KiB
calendar-unhide-action-desktop-light.png
548 KiB
calendar-hidden-off-phone-dark.png
124 KiB
shared-log-link-tablet-light.png
584 KiB
files-hidden-tablet-dark.png
400 KiB
files-hidden-phone-dark.png
127 KiB
calendar-unhide-action-phone-light.png
165 KiB
note-deep-link-desktop-dark.png
339 KiB
hide5-notes-part1.zip
3 MiB
photos-hidden-desktop-dark.png
347 KiB
files-deep-link-phone-dark.png
20 KiB
tasks-unhide-action-phone-dark.png
116 KiB
hide3-review-4.zip
2.9 MiB
files-deep-link-tablet-dark.png
21 KiB
folders-deep-link-tablet-light.png
468 KiB
folders-hidden-off-phone-dark.png
121 KiB
files-unhidden-phone-dark.png files-unhidden-phone-light.png files-unhidden-tablet-dark.png files-unhide-action-desktop-dark.png files-unhide-action-desktop-light.png files-unhide-action-phone-dark.png files-unhide-action-tablet-light.png folders-deep-link-desktop-dark.png folders-hidden-off-phone-light.png folders-hidden-off-tablet-dark.png folders-hidden-tablet-dark.png folders-unhidden-desktop-dark.png folders-unhidden-desktop-light.png folders-unhidden-phone-dark.png folders-unhidden-phone-light.png folders-unhidden-tablet-dark.png folders-unhidden-tablet-light.png files-unhidden-tablet-light.png files-unhide-action-phone-light.png files-unhide-action-tablet-dark.png folders-deep-link-desktop-light.png folders-deep-link-phone-dark.png folders-deep-link-phone-light.png folders-deep-link-tablet-dark.png folders-hidden-desktop-light.png folders-hidden-off-desktop-dark.png folders-hidden-off-desktop-light.png folders-hidden-off-tablet-light.png folders-hidden-phone-dark.png folders-hidden-phone-light.png folders-hidden-tablet-light.png folders-unhide-action-desktop-dark.png folders-unhide-action-phone-dark.png folders-unhide-action-desktop-light.png folders-unhide-action-tablet-dark.png folders-unhide-action-tablet-light.png photo-viewer-hidden-phone-light.png photo-viewer-hidden-tablet-dark.png photo-viewer-hidden-tablet-light.png photos-hidden-off-phone-dark.png photos-hidden-off-phone-light.png photos-hidden-off-tablet-dark.png photos-hidden-off-tablet-light.png photos-hidden-phone-dark.png photos-hidden-phone-light.png photos-hidden-tablet-dark.png photos-hidden-tablet-light.png photos-unhidden-phone-dark.png photos-unhidden-tablet-dark.png photos-unhide-action-desktop-light.png photos-unhide-action-phone-dark.png photos-unhide-action-tablet-dark.png photos-unhide-action-tablet-light.png tasks-deep-link-desktop-light.png tasks-deep-link-phone-dark.png tasks-deep-link-phone-light.png tasks-deep-link-tablet-light.png tasks-hidden-desktop-dark.png tasks-hidden-desktop-light.png tasks-hidden-off-desktop-light.png tasks-hidden-off-tablet-light.png tasks-hidden-phone-dark.png tasks-hidden-phone-light.png tasks-hidden-tablet-dark.png tasks-hidden-tablet-light.png tasks-unhidden-desktop-dark.png photo-viewer-hidden-desktop-light.png photo-viewer-hidden-phone-dark.png photos-hidden-desktop-light.png photos-hidden-off-desktop-dark.png photos-hidden-off-desktop-light.png photos-unhidden-desktop-dark.png photos-unhidden-desktop-light.png photos-unhidden-phone-light.png photos-unhidden-tablet-light.png photos-unhide-action-phone-light.png tasks-deep-link-desktop-dark.png tasks-deep-link-tablet-dark.png tasks-hidden-off-desktop-dark.png tasks-hidden-off-phone-light.png tasks-hidden-off-tablet-dark.png tasks-unhidden-phone-light.png tasks-unhide-action-desktop-dark.png tasks-unhide-action-phone-light.png tasks-unhide-action-tablet-dark.png plain-canvas-hidden-phone-light.png plain-canvas-hidden-tablet-light.png shared-log-hidden-phone-dark.png shared-log-hidden-phone-light.png shared-log-link-desktop-light.png shared-log-link-phone-dark.png shared-log-link-phone-light.png shared-log-link-tablet-dark.png shared-note-link-desktop-dark.png shared-note-link-phone-light.png shared-note-link-tablet-dark.png shared-task-hidden-phone-dark.png shared-task-hidden-phone-light.png shared-task-hidden-tablet-light.png shared-task-link-desktop-dark.png shared-task-link-tablet-dark.png plain-canvas-link-desktop-dark.png plain-canvas-link-desktop-light.png plain-canvas-link-phone-dark.png plain-canvas-link-phone-light.png plain-canvas-link-tablet-dark.png plain-canvas-link-tablet-light.png tasks-unhidden-desktop-light.png tasks-unhidden-phone-dark.png tasks-unhidden-tablet-dark.png tasks-unhidden-tablet-light.png shared-log-hidden-desktop-light.png shared-log-hidden-tablet-dark.png shared-log-hidden-tablet-light.png shared-log-link-desktop-dark.png shared-note-link-desktop-light.png shared-note-link-phone-dark.png shared-note-link-tablet-light.png shared-notes-hidden-desktop-dark.png shared-notes-hidden-desktop-light.png shared-notes-hidden-phone-dark.png shared-notes-hidden-phone-light.png shared-notes-hidden-tablet-dark.png shared-notes-hidden-tablet-light.png shared-task-hidden-desktop-dark.png shared-task-hidden-desktop-light.png shared-task-link-desktop-light.png shared-task-link-phone-dark.png shared-task-link-phone-light.png shared-task-link-tablet-light.png plain-canvas-hidden-desktop-dark.png plain-canvas-hidden-desktop-light.png plain-canvas-hidden-phone-dark.png tasks-unhide-action-desktop-light.png calendar-hidden-desktop-dark.png calendar-hidden-desktop-light.png calendar-hidden-phone-dark.png calendar-hidden-phone-light.png calendar-hidden-tablet-dark.png calendar-hidden-tablet-light.png files-hidden-desktop-dark.png files-hidden-desktop-light.png files-hidden-phone-dark.png files-hidden-phone-light.png files-hidden-tablet-light.png folders-hidden-desktop-dark.png folders-hidden-desktop-light.png folders-hidden-phone-dark.png folders-hidden-phone-light.png folders-hidden-tablet-dark.png folders-hidden-tablet-light.png note-deep-link-desktop-light.png note-deep-link-phone-dark.png note-deep-link-phone-light.png note-deep-link-tablet-dark.png note-deep-link-tablet-light.png note-header-4x-dark.png notes-hidden-desktop-light.png notes-hidden-off-desktop-dark.png notes-hidden-off-desktop-light.png notes-hidden-off-phone-dark.png notes-hidden-off-phone-light.png notes-hidden-off-tablet-light.png notes-hidden-phone-dark.png notes-hidden-phone-light.png note-header-4x-light.png notes-hidden-desktop-dark.png notes-hidden-off-tablet-dark.png notes-hidden-tablet-dark.png notes-hidden-tablet-light.png photos-hidden-desktop-dark.png photos-hidden-desktop-light.png photos-hidden-phone-dark.png photos-hidden-phone-light.png photos-hidden-tablet-dark.png photos-hidden-tablet-light.png tasks-hidden-desktop-dark.png tasks-hidden-desktop-light.png tasks-hidden-phone-dark.png tasks-hidden-phone-light.png tasks-hidden-tablet-dark.png tasks-hidden-tablet-light.png calendar-deep-link-desktop-light.png calendar-deep-link-phone-dark.png calendar-deep-link-tablet-light.png calendar-hidden-desktop-dark.png calendar-hidden-desktop-light.png calendar-hidden-off-desktop-light.png calendar-hidden-off-tablet-light.png calendar-hidden-tablet-dark.png calendar-hidden-tablet-light.png calendar-unhidden-desktop-dark.png calendar-unhidden-desktop-light.png calendar-unhidden-phone-dark.png calendar-deep-link-desktop-dark.png calendar-deep-link-phone-light.png calendar-deep-link-tablet-dark.png calendar-hidden-off-desktop-dark.png calendar-hidden-off-phone-light.png calendar-hidden-off-tablet-dark.png calendar-hidden-phone-dark.png calendar-hidden-phone-light.png calendar-unhide-action-tablet-dark.png calendar-unhide-action-tablet-light.png files-deep-link-desktop-dark.png files-deep-link-desktop-light.png files-hidden-desktop-light.png files-hidden-off-desktop-dark.png files-hidden-off-desktop-light.png files-hidden-off-phone-dark.png files-hidden-off-phone-light.png calendar-unhidden-phone-light.png calendar-unhidden-tablet-dark.png calendar-unhidden-tablet-light.png calendar-unhide-action-desktop-dark.png calendar-unhide-action-phone-dark.png files-deep-link-phone-light.png files-deep-link-tablet-light.png files-hidden-desktop-dark.png files-hidden-off-tablet-dark.png files-hidden-off-tablet-light.png files-hidden-phone-light.png files-hidden-tablet-dark.png files-hidden-tablet-light.png files-unhidden-desktop-dark.png files-unhidden-desktop-light.png tasks-unhide-action-tablet-light.png folders-unhide-action-phone-light.png photos-unhide-action-desktop-dark.png shared-log-hidden-desktop-dark.png shared-task-hidden-tablet-dark.png plain-canvas-hidden-tablet-dark.png tasks-hidden-off-phone-dark.png photo-viewer-hidden-desktop-dark.png folders-hidden-desktop-dark.png calendar-unhide-action-desktop-light.png calendar-hidden-off-phone-dark.png shared-log-link-tablet-light.png files-hidden-tablet-dark.png files-hidden-phone-dark.png calendar-unhide-action-phone-light.png note-deep-link-desktop-dark.png photos-hidden-desktop-dark.png files-deep-link-phone-dark.png tasks-unhide-action-phone-dark.png files-deep-link-tablet-dark.png folders-deep-link-tablet-light.png folders-hidden-off-phone-dark.png
kayg commented 2026-10-05 17:47:29 +00:00
Author
Owner
Copy link

Starting issue #1153 on branch job/hide-1153 at base SHA de654a42ac4f9a6dca83bed8e0eebc99706f7dfe. The worktree is clean. The branch is currently 48 commits behind origin/dev; I will merge origin/dev once before final gates as required.

Starting issue #1153 on branch `job/hide-1153` at base SHA `de654a42ac4f9a6dca83bed8e0eebc99706f7dfe`. The worktree is clean. The branch is currently 48 commits behind `origin/dev`; I will merge `origin/dev` once before final gates as required.
kayg commented 2026-10-05 17:59:25 +00:00
Author
Owner
Copy link

Finding during the marker helper slice: bun run check in apps/web exits 2 before Svelte checking. scripts/perf-lint --check reports ledger has 21977 exceptions; ratchet total is 21964, including rule counts over the committed ratchet by one. contracts/perf/exceptions.json and contracts/perf/ratchet.json are unchanged in this worktree; this mismatch is present on the merged origin/dev baseline.

Finding during the marker helper slice: `bun run check` in `apps/web` exits 2 before Svelte checking. `scripts/perf-lint --check` reports `ledger has 21977 exceptions; ratchet total is 21964`, including rule counts over the committed ratchet by one. `contracts/perf/exceptions.json` and `contracts/perf/ratchet.json` are unchanged in this worktree; this mismatch is present on the merged `origin/dev` baseline.
kayg commented 2026-10-05 18:38:43 +00:00
Author
Owner
Copy link

Finding for #1153: the Calendar item menu already lists Hide, but runItemContext("hide") only closes the preview and menu; it makes no API write. Also, note_tags_union returned all scanned Tags unchanged, so a hand-written #_calternal/hidden could enter tag indexing. I am wiring Log visibility through the existing conditional Journal PATCH and filtering the reserved marker at the shared tag-union boundary.

Finding for #1153: the Calendar item menu already lists Hide, but `runItemContext("hide")` only closes the preview and menu; it makes no API write. Also, `note_tags_union` returned all scanned Tags unchanged, so a hand-written `#_calternal/hidden` could enter tag indexing. I am wiring Log visibility through the existing conditional Journal PATCH and filtering the reserved marker at the shared tag-union boundary.
kayg commented 2026-10-05 19:04:24 +00:00
Author
Owner
Copy link

Finding for #1153: Calendar range and year projections used hidden=0 for every owner, which also removed a shared owner's hidden Log from a recipient's Calendar. The range now applies Hide only when the viewer owns the Log; a recipient still sees it, and an owner can opt in with show_hidden=true.

Finding for #1153: Calendar range and year projections used `hidden=0` for every owner, which also removed a shared owner's hidden Log from a recipient's Calendar. The range now applies Hide only when the viewer owns the Log; a recipient still sees it, and an owner can opt in with `show_hidden=true`.
kayg commented 2026-10-05 20:25:00 +00:00
Author
Owner
Copy link

The Files crate gate exposed one transient existing storm-test failure under shared-host load. In the full run, tests::internal_temp_paths_never_enter_index_during_atomic_write_reconcile_storm panicked with JoinHandle polled after completion after 258 tests passed. I reran only that test once; it passed in 200.14s. The new owner_listing_filters_marker_hidden_items_before_counting_and_paging test passed in the full run. I did not alter the existing test or its expectation.

The Files crate gate exposed one transient existing storm-test failure under shared-host load. In the full run, `tests::internal_temp_paths_never_enter_index_during_atomic_write_reconcile_storm` panicked with `JoinHandle polled after completion` after 258 tests passed. I reran only that test once; it passed in 200.14s. The new `owner_listing_filters_marker_hidden_items_before_counting_and_paging` test passed in the full run. I did not alter the existing test or its expectation.
kayg commented 2026-10-05 21:39:25 +00:00
Author
Owner
Copy link

Search gate findings (#1153), 2026-10-05:

  • cargo test -p calternal-search unit tests passed (56 passed, 1 ignored), but its indexer integration suite ended with 24 passed and 2 failures after 656.83s. exact_title_and_open_history_rank_per_user expected the frecency-ranked z-archive.md but received a-needle.md; one isolated rerun passed (1 passed in 5.55s), so this is load-sensitive.
  • search_returns_committed_hits_while_the_frecency_pool_is_busy failed at its first search because its hand-built search_manifest table lacks the existing mime column queried by calternal-search/src/indexer.rs. I did not edit this existing fixture because the feature does not change that schema contract.
  • overflow_recovery_answers_a_queued_integrity_check passed; it took over ten minutes on the shared host.
  • The new Search hidden-visibility unit test passed, and apps/web/src/lib/search/providers.test.ts passed (7 tests).
Search gate findings (#1153), 2026-10-05: - `cargo test -p calternal-search` unit tests passed (56 passed, 1 ignored), but its indexer integration suite ended with 24 passed and 2 failures after 656.83s. `exact_title_and_open_history_rank_per_user` expected the frecency-ranked `z-archive.md` but received `a-needle.md`; one isolated rerun passed (1 passed in 5.55s), so this is load-sensitive. - `search_returns_committed_hits_while_the_frecency_pool_is_busy` failed at its first search because its hand-built `search_manifest` table lacks the existing `mime` column queried by `calternal-search/src/indexer.rs`. I did not edit this existing fixture because the feature does not change that schema contract. - `overflow_recovery_answers_a_queued_integrity_check` passed; it took over ten minutes on the shared host. - The new Search hidden-visibility unit test passed, and `apps/web/src/lib/search/providers.test.ts` passed (7 tests).
kayg commented 2026-10-05 22:04:37 +00:00
Author
Owner
Copy link

OpenAPI generation for #1153 initially panicked at crates/calternal-server/src/action_contract.rs:74 with tags_set_hidden: declare action policy before publishing the operation. The new write route had no reviewed action policy. I added a data-scope write policy with replay set to never; OpenAPI generation is being rerun.

OpenAPI generation for #1153 initially panicked at `crates/calternal-server/src/action_contract.rs:74` with `tags_set_hidden: declare action policy before publishing the operation`. The new write route had no reviewed action policy. I added a data-scope write policy with replay set to `never`; OpenAPI generation is being rerun.
kayg commented 2026-10-05 22:45:07 +00:00
Author
Owner
Copy link

Finding: the new Hide E2E script resolved as , so it looked for Playwright at and exited before server startup. Evidence: . I am fixing the path and rerunning the focused E2E.

Finding: the new Hide E2E script resolved as , so it looked for Playwright at and exited before server startup. Evidence: . I am fixing the path and rerunning the focused E2E.
kayg commented 2026-10-05 22:45:28 +00:00
Author
Owner
Copy link

Finding: the new Hide E2E script resolved the repository root as the apps directory, so it looked for Playwright at apps/tests/adversarial/node_modules/playwright/index.mjs and exited before server startup.

Evidence: the test reported Playwright module missing: /home/kayg/Developer/calternal-wt/hide-1153/apps/tests/adversarial/node_modules/playwright/index.mjs. I am fixing the root path and rerunning the focused E2E.

Finding: the new Hide E2E script resolved the repository root as the apps directory, so it looked for Playwright at apps/tests/adversarial/node_modules/playwright/index.mjs and exited before server startup. Evidence: the test reported `Playwright module missing: /home/kayg/Developer/calternal-wt/hide-1153/apps/tests/adversarial/node_modules/playwright/index.mjs`. I am fixing the root path and rerunning the focused E2E.
kayg commented 2026-10-05 22:46:55 +00:00
Author
Owner
Copy link

Finding: the focused E2E starts on Notes, where a Note is present in both the sidebar tree and All Notes list. The unscoped More actions for <title> locator matched both buttons and Playwright stopped with a strict mode violation.

Evidence: Playwright reported two matching buttons, one in the Notes tree and one in the All Notes list. I am scoping the action to the list row and rerunning the flow.

Finding: the focused E2E starts on Notes, where a Note is present in both the sidebar tree and All Notes list. The unscoped `More actions for <title>` locator matched both buttons and Playwright stopped with a strict mode violation. Evidence: Playwright reported two matching buttons, one in the Notes tree and one in the All Notes list. I am scoping the action to the list row and rerunning the flow.
kayg commented 2026-10-05 22:47:47 +00:00
Author
Owner
Copy link

Follow-up finding: the first Hide action was scoped to the All Notes row, but the second Hide action after Undo still used the page-wide locator. The same two-button strict mode violation occurred at the second action. I am changing it to reuse the row-scoped locator.

Follow-up finding: the first Hide action was scoped to the All Notes row, but the second Hide action after Undo still used the page-wide locator. The same two-button strict mode violation occurred at the second action. I am changing it to reuse the row-scoped locator.
kayg commented 2026-10-05 22:57:28 +00:00
Author
Owner
Copy link

Finding: calternal-notes-core clippy failed because the new inline Task hidden-marker regression test called crate::extract_task_index, but the function is re-exported under crate::tasks.

Evidence: clippy reported error[E0425]: cannot find function extract_task_index in the crate root at crates/calternal-notes-core/src/tasks/line.rs:1365. I am correcting the path and rerunning the Notes core gates.

Finding: `calternal-notes-core` clippy failed because the new inline Task hidden-marker regression test called `crate::extract_task_index`, but the function is re-exported under `crate::tasks`. Evidence: clippy reported `error[E0425]: cannot find function extract_task_index in the crate root` at `crates/calternal-notes-core/src/tasks/line.rs:1365`. I am correcting the path and rerunning the Notes core gates.
kayg commented 2026-10-05 22:58:40 +00:00
Author
Owner
Copy link

Follow-up finding: after correcting the projector path, the new file Task test used frontmatter with only title and tags. The Task projector correctly treats that as a normal Note because no Task-specific field is present, so its hidden assertion failed.

Evidence: the Notes core test run reported 575 passed and one failed at crates/calternal-notes-core/src/tasks/extract.rs:1051 (assertion failed: row.hidden). I am adding the required status field to the fixture while keeping the assertion.

Follow-up finding: after correcting the projector path, the new file Task test used frontmatter with only `title` and `tags`. The Task projector correctly treats that as a normal Note because no Task-specific field is present, so its hidden assertion failed. Evidence: the Notes core test run reported 575 passed and one failed at `crates/calternal-notes-core/src/tasks/extract.rs:1051` (`assertion failed: row.hidden`). I am adding the required `status` field to the fixture while keeping the assertion.
kayg commented 2026-10-05 23:26:55 +00:00
Author
Owner
Copy link

Finding: Calendar clippy failed after the visibility flag was threaded through the existing projection helpers. Three functions exceeded the seven-argument lint limit: aggregate_range, project_days, and load_log_counts.

Evidence: cargo clippy -p calternal-plugin-calendar --all-targets -- -D warnings reported this function has too many arguments (8/7) at lines 1064, 1095, and 1239 in crates/plugins/calendar/src/view.rs. I am grouping the projection window and options into the existing projection request types.

Finding: Calendar clippy failed after the visibility flag was threaded through the existing projection helpers. Three functions exceeded the seven-argument lint limit: `aggregate_range`, `project_days`, and `load_log_counts`. Evidence: `cargo clippy -p calternal-plugin-calendar --all-targets -- -D warnings` reported `this function has too many arguments (8/7)` at lines 1064, 1095, and 1239 in `crates/plugins/calendar/src/view.rs`. I am grouping the projection window and options into the existing projection request types.
kayg commented 2026-10-05 23:46:33 +00:00
Author
Owner
Copy link

Finding: the Files crate suite had one load-sensitive timeout during final gates. The existing public_password_rejection_does_not_wait_for_data_mutation_lock test did not return within its two-second bound while other worktrees were compiling.

Evidence: cargo test -p calternal-plugin-files reported 258 passed, 1 failed, and 4 ignored; the failure was called Result::unwrap() on an Err value: Elapsed(()) at crates/plugins/files/src/lib.rs:13780. I did not change the assertion. The test ran amid concurrent builds and is recorded as a SLOW/load result.

Finding: the Files crate suite had one load-sensitive timeout during final gates. The existing `public_password_rejection_does_not_wait_for_data_mutation_lock` test did not return within its two-second bound while other worktrees were compiling. Evidence: `cargo test -p calternal-plugin-files` reported 258 passed, 1 failed, and 4 ignored; the failure was `called Result::unwrap() on an Err value: Elapsed(())` at `crates/plugins/files/src/lib.rs:13780`. I did not change the assertion. The test ran amid concurrent builds and is recorded as a SLOW/load result.
kayg commented 2026-10-06 00:07:14 +00:00
Author
Owner
Copy link

The server gate exposed release inventory assertions that still assumed Notes migration 0033 was the tip: production_round_9_schema_upgrades_once_with_original_receipts omitted Notes 0034, the production 7b combined migration count was 16 instead of 17, and the production 7c history count expected three new receipts instead of four. I updated only those inventory expectations and documented that #1153 adds the Notes Hide-marker migration; focused checks are pending.

The same run had a separate slow live-app startup timeout (startup_serves_http_while_upgrade_backfills_wait: Elapsed(())). I left its timeout and expectations unchanged. The Photos crate also had five fixture failures because the shared host was below the filesystem test reserve (31,695,649,792 bytes required; 30,968,987,648 bytes available at the first failure).

The server gate exposed release inventory assertions that still assumed Notes migration 0033 was the tip: `production_round_9_schema_upgrades_once_with_original_receipts` omitted Notes 0034, the production 7b combined migration count was 16 instead of 17, and the production 7c history count expected three new receipts instead of four. I updated only those inventory expectations and documented that #1153 adds the Notes Hide-marker migration; focused checks are pending. The same run had a separate slow live-app startup timeout (`startup_serves_http_while_upgrade_backfills_wait`: `Elapsed(())`). I left its timeout and expectations unchanged. The Photos crate also had five fixture failures because the shared host was below the filesystem test reserve (31,695,649,792 bytes required; 30,968,987,648 bytes available at the first failure).
kayg commented 2026-10-06 00:34:18 +00:00
Author
Owner
Copy link

#1153 implementation report

Branch: job/hide-1153
Head: 219251c4986424026df80f2d5f61fd1f0047a87a

Commits include the shared marker predicate, storage and API support, per-surface UI, search visibility, the Notes migration, the focused E2E flow, and migration inventory updates for migration 0034.

Built

  • Added one shared Rust and web predicate for _calternal/hidden. Notes and Canvases use frontmatter Tags; Calendar Log entries use the day file marker; Tasks use frontmatter or inline Tags; Files and folders use .calternal.json; Photos use XMP keywords. User Tag lists and counts omit the marker.
  • Added hidden fields and Hide/Unhide writers for Notes, Tasks, Calendar entries, Files/folders and Photos. The generated action registry provides the API, CLI and MCP surface.
  • Added a per-User Show hidden preference, default filtering, dimmed hidden rows, Undo toasts, is:hidden and -is:hidden, and hidden-item handling for stable deep links. Share recipients still see shared items.
  • Added migration crates/plugins/notes/migrations/0034_note_visibility.sql, storage/search tests, and apps/web/e2e/hide-1153.mjs.
  • Added bench/hidden-1153.mjs; no timing run was made because this is not a performance issue and the current policy reserves perf VM runs for performance issues.

Files

Rust changes are in crates/calternal-api, crates/calternal-notes-core, crates/calternal-search, crates/calternal-tags, crates/calternal-plugin, crates/calternal-server, and crates/plugins/{calendar,files,notes,photos}. Web changes are in apps/web/src/lib/{calendar,components,files,notes,photos,search,tasks}, the Notes, Calendar, Tags and Files settings routes, packages/ui, and generated packages/api-client types. Contracts, Cargo.lock, apps/web/package.json, the E2E script and bench/hidden-1153.mjs also changed.

UX gaps closed

Hide and Unhide work through the shared item menus and preserve stable identities. The Note flow covers Undo, default Search filtering, Show hidden, is:hidden, dimmed rows and the deep-link badge. Photos can open a hidden deep link in the viewer, and Files/Calendar/Tasks show the hidden state in their item views.

UX gaps left

  • The real-server E2E and screenshots cover Notes only. The 12 macOS-emulated screenshots are in local artifacts/hide-1153 (Notes list and Note deep link at 390/820/1440 in light and dark). They are not attached to this issue: fj has no attachment command and git credential fill returned no reusable HTTPS credential for the upload API.
  • No Hide action was added for standalone albums or saved searches; the current models do not expose them as marker-backed items.
  • The Photos, Files, Tasks and Calendar hide flows do not yet have dedicated real-server E2E coverage.

Decisions not specified by DESIGN

  • Show hidden uses one shared per-User preference across Tabs, stored with Files display preferences. Each Tab exposes that shared value in its view menu.
  • The OpenAPI hidden response field is optional for older clients; the server populates it on current responses.
  • A hidden Photo reached by a stable deep link gets a viewer-only tile if it is absent from the visible timeline. The tile does not enter the default grid.

Gates

cargo fmt --check exited 0 with no output. Clippy passed for every changed Rust crate, including calternal-server.

Verbatim Cargo test result lines:

calternal-api: test result: ok. 18 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.10s
calternal-notes-core: test result: ok. 576 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.80s
calternal-plugin: test result: ok. 43 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 7.67s
calternal-search unit: test result: ok. 56 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 43.02s
calternal-search indexer: test result: FAILED. 25 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 605.52s
calternal-tags: test result: ok. 19 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 6.58s
calternal-plugin-calendar: test result: ok. 101 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 17.36s
calternal-plugin-files: test result: FAILED. 258 passed; 1 failed; 4 ignored; 0 measured; 0 filtered out; finished in 219.43s
calternal-plugin-notes: test result: ok. 289 passed; 0 failed; 3 ignored; 0 measured; 0 filtered out; finished in 230.98s
calternal-plugin-photos: test result: FAILED. 51 passed; 5 failed; 4 ignored; 0 measured; 0 filtered out; finished in 1.91s
calternal-server full run before inventory expectation fix: test result: FAILED. 252 passed; 4 failed; 10 ignored; 0 measured; 0 filtered out; finished in 119.31s
server production migration subset after the fix: test result: ok. 5 passed; 0 failed; 0 ignored; 0 measured; 261 filtered out; finished in 8.82s

The Search indexer failure is no such column: mime in search_returns_committed_hits_while_the_frecency_pool_is_busy; its fixture/expectation was left unchanged. The Files failure is the 2-second public_password_rejection_does_not_wait_for_data_mutation_lock timeout. Five Photos tests failed before their assertions because the host had less space than the test reserve: reserve: 31695649792, available: 30968987648. The server's three stale migration inventory expectations were updated for Notes 0034 and the focused five-test subset passes; the remaining live-app startup test timed out at Elapsed(()). No full suite was rerun after those fixes.

Focused web Vitest output: Test Files 2 passed (2) and Tests 19 passed (19). node --check apps/web/e2e/hide-1153.mjs passed. Production bun run build passed. The focused real-server E2E passed and produced the 12 local screenshots.

bun run check output (verbatim):

$ check_rc=0; bun scripts/check-dependency-licenses.mjs || check_rc=1; ../../scripts/perf-lint --check || check_rc=1; node scripts/check-user-storage.mjs || check_rc=1; node scripts/check-glass-tokens.mjs || check_rc=1; node scripts/check-type-tokens.mjs || check_rc=1; node scripts/check-focus-tokens.mjs || check_rc=1; node scripts/check-motion-tokens.mjs || check_rc=1; svelte-kit sync || check_rc=1; svelte-check --tsconfig ./tsconfig.json || check_rc=1; exit "$check_rc"
NOTE Bun skipped 1 lock package(s) not installed in this production environment
PASS production dependency licences: 759 locked package releases across apps/web, apps/docs and packages
perf-lint: parse Rust product sources
perf-lint: parse browser product sources
perf-lint: validate coverage and architecture
perf-lint: INVALID: ('render.bound', 'apps/web/src/lib/components/NoteList.svelte', 'apps/web/src/lib/components/NoteList.svelte#each:a6432f7bb9653f60:1'): unused or changed exception
User browser caches use userStorage; only documented device/public-link exceptions remain.
Glass alpha, blur and backdrop-filter roles use packages/ui/src/tokens.css.
Text sizes and UI shape values use shared role tokens.
Keyboard focus rings use the shared focus tokens.
UI transitions and animation options use shared motion tokens or documented exceptions.
Loading svelte-check in workspace: /home/kayg/Developer/calternal-wt/hide-1153/apps/web
Getting Svelte diagnostics...

/home/kayg/Developer/calternal-wt/hide-1153/apps/web/../../packages/ui/src/components/calendar/AttachmentDeck.svelte:1055:3
Warn: Do not use empty rulesets (css)
  }
  .attachment-row:focus {

====================================
svelte-check found 0 errors and 1 warning in 1 file
error: script "check" exited with code 1

The remaining bun run check failure is the perf-lint exception fingerprint for the changed NoteList loop. The token and Svelte diagnostics otherwise pass; Svelte reports one existing empty-ruleset warning.

For the merge round

  • bun run test -- --maxWorkers=2 — full web tests and perf-source tests.
  • bun run test:e2e:hide-1153 — rerun the owner hide, Undo, Search, Show hidden and deep-link flow on the combined branch.
  • cargo test -p calternal-search -- --test-threads=4 — verify hidden Search filters and the currently failing indexer fixture on the combined branch.
  • cargo test -p calternal-plugin-files -- --test-threads=4 — verify Files hidden listing and the load-sensitive public-password test.
  • cargo test -p calternal-plugin-photos -- --test-threads=4 — verify XMP sidecars, owner filtering and share-recipient visibility with adequate test space.
  • cargo test -p calternal-server -- --test-threads=4 — verify routes, action parity and migration upgrades; classify the live-app timeout.
  • bash tests/adversarial/run.sh — run the XUser, authz and robustness matrices against a real local server.

cargo clean removed 28.9 GiB of build output. Web build output was deleted. No push, deploy or merge was made.

# #1153 implementation report Branch: `job/hide-1153` Head: `219251c4986424026df80f2d5f61fd1f0047a87a` Commits include the shared marker predicate, storage and API support, per-surface UI, search visibility, the Notes migration, the focused E2E flow, and migration inventory updates for migration 0034. ## Built - Added one shared Rust and web predicate for `_calternal/hidden`. Notes and Canvases use frontmatter Tags; Calendar Log entries use the day file marker; Tasks use frontmatter or inline Tags; Files and folders use `.calternal.json`; Photos use XMP keywords. User Tag lists and counts omit the marker. - Added `hidden` fields and Hide/Unhide writers for Notes, Tasks, Calendar entries, Files/folders and Photos. The generated action registry provides the API, CLI and MCP surface. - Added a per-User Show hidden preference, default filtering, dimmed hidden rows, Undo toasts, `is:hidden` and `-is:hidden`, and hidden-item handling for stable deep links. Share recipients still see shared items. - Added migration `crates/plugins/notes/migrations/0034_note_visibility.sql`, storage/search tests, and `apps/web/e2e/hide-1153.mjs`. - Added `bench/hidden-1153.mjs`; no timing run was made because this is not a performance issue and the current policy reserves perf VM runs for performance issues. ## Files Rust changes are in `crates/calternal-api`, `crates/calternal-notes-core`, `crates/calternal-search`, `crates/calternal-tags`, `crates/calternal-plugin`, `crates/calternal-server`, and `crates/plugins/{calendar,files,notes,photos}`. Web changes are in `apps/web/src/lib/{calendar,components,files,notes,photos,search,tasks}`, the Notes, Calendar, Tags and Files settings routes, `packages/ui`, and generated `packages/api-client` types. Contracts, `Cargo.lock`, `apps/web/package.json`, the E2E script and `bench/hidden-1153.mjs` also changed. ## UX gaps closed Hide and Unhide work through the shared item menus and preserve stable identities. The Note flow covers Undo, default Search filtering, Show hidden, `is:hidden`, dimmed rows and the deep-link badge. Photos can open a hidden deep link in the viewer, and Files/Calendar/Tasks show the hidden state in their item views. ## UX gaps left - The real-server E2E and screenshots cover Notes only. The 12 macOS-emulated screenshots are in local `artifacts/hide-1153` (Notes list and Note deep link at 390/820/1440 in light and dark). They are not attached to this issue: `fj` has no attachment command and `git credential fill` returned no reusable HTTPS credential for the upload API. - No Hide action was added for standalone albums or saved searches; the current models do not expose them as marker-backed items. - The Photos, Files, Tasks and Calendar hide flows do not yet have dedicated real-server E2E coverage. ## Decisions not specified by DESIGN - Show hidden uses one shared per-User preference across Tabs, stored with Files display preferences. Each Tab exposes that shared value in its view menu. - The OpenAPI `hidden` response field is optional for older clients; the server populates it on current responses. - A hidden Photo reached by a stable deep link gets a viewer-only tile if it is absent from the visible timeline. The tile does not enter the default grid. ## Gates `cargo fmt --check` exited 0 with no output. Clippy passed for every changed Rust crate, including `calternal-server`. Verbatim Cargo test result lines: ```text calternal-api: test result: ok. 18 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.10s calternal-notes-core: test result: ok. 576 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.80s calternal-plugin: test result: ok. 43 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 7.67s calternal-search unit: test result: ok. 56 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 43.02s calternal-search indexer: test result: FAILED. 25 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 605.52s calternal-tags: test result: ok. 19 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 6.58s calternal-plugin-calendar: test result: ok. 101 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 17.36s calternal-plugin-files: test result: FAILED. 258 passed; 1 failed; 4 ignored; 0 measured; 0 filtered out; finished in 219.43s calternal-plugin-notes: test result: ok. 289 passed; 0 failed; 3 ignored; 0 measured; 0 filtered out; finished in 230.98s calternal-plugin-photos: test result: FAILED. 51 passed; 5 failed; 4 ignored; 0 measured; 0 filtered out; finished in 1.91s calternal-server full run before inventory expectation fix: test result: FAILED. 252 passed; 4 failed; 10 ignored; 0 measured; 0 filtered out; finished in 119.31s server production migration subset after the fix: test result: ok. 5 passed; 0 failed; 0 ignored; 0 measured; 261 filtered out; finished in 8.82s ``` The Search indexer failure is `no such column: mime` in `search_returns_committed_hits_while_the_frecency_pool_is_busy`; its fixture/expectation was left unchanged. The Files failure is the 2-second `public_password_rejection_does_not_wait_for_data_mutation_lock` timeout. Five Photos tests failed before their assertions because the host had less space than the test reserve: `reserve: 31695649792, available: 30968987648`. The server's three stale migration inventory expectations were updated for Notes 0034 and the focused five-test subset passes; the remaining live-app startup test timed out at `Elapsed(())`. No full suite was rerun after those fixes. Focused web Vitest output: `Test Files 2 passed (2)` and `Tests 19 passed (19)`. `node --check apps/web/e2e/hide-1153.mjs` passed. Production `bun run build` passed. The focused real-server E2E passed and produced the 12 local screenshots. `bun run check` output (verbatim): ```text $ check_rc=0; bun scripts/check-dependency-licenses.mjs || check_rc=1; ../../scripts/perf-lint --check || check_rc=1; node scripts/check-user-storage.mjs || check_rc=1; node scripts/check-glass-tokens.mjs || check_rc=1; node scripts/check-type-tokens.mjs || check_rc=1; node scripts/check-focus-tokens.mjs || check_rc=1; node scripts/check-motion-tokens.mjs || check_rc=1; svelte-kit sync || check_rc=1; svelte-check --tsconfig ./tsconfig.json || check_rc=1; exit "$check_rc" NOTE Bun skipped 1 lock package(s) not installed in this production environment PASS production dependency licences: 759 locked package releases across apps/web, apps/docs and packages perf-lint: parse Rust product sources perf-lint: parse browser product sources perf-lint: validate coverage and architecture perf-lint: INVALID: ('render.bound', 'apps/web/src/lib/components/NoteList.svelte', 'apps/web/src/lib/components/NoteList.svelte#each:a6432f7bb9653f60:1'): unused or changed exception User browser caches use userStorage; only documented device/public-link exceptions remain. Glass alpha, blur and backdrop-filter roles use packages/ui/src/tokens.css. Text sizes and UI shape values use shared role tokens. Keyboard focus rings use the shared focus tokens. UI transitions and animation options use shared motion tokens or documented exceptions. Loading svelte-check in workspace: /home/kayg/Developer/calternal-wt/hide-1153/apps/web Getting Svelte diagnostics... /home/kayg/Developer/calternal-wt/hide-1153/apps/web/../../packages/ui/src/components/calendar/AttachmentDeck.svelte:1055:3 Warn: Do not use empty rulesets (css) } .attachment-row:focus { ==================================== svelte-check found 0 errors and 1 warning in 1 file error: script "check" exited with code 1 ``` The remaining `bun run check` failure is the perf-lint exception fingerprint for the changed NoteList loop. The token and Svelte diagnostics otherwise pass; Svelte reports one existing empty-ruleset warning. ## For the merge round - `bun run test -- --maxWorkers=2` — full web tests and perf-source tests. - `bun run test:e2e:hide-1153` — rerun the owner hide, Undo, Search, Show hidden and deep-link flow on the combined branch. - `cargo test -p calternal-search -- --test-threads=4` — verify hidden Search filters and the currently failing indexer fixture on the combined branch. - `cargo test -p calternal-plugin-files -- --test-threads=4` — verify Files hidden listing and the load-sensitive public-password test. - `cargo test -p calternal-plugin-photos -- --test-threads=4` — verify XMP sidecars, owner filtering and share-recipient visibility with adequate test space. - `cargo test -p calternal-server -- --test-threads=4` — verify routes, action parity and migration upgrades; classify the live-app timeout. - `bash tests/adversarial/run.sh` — run the XUser, authz and robustness matrices against a real local server. `cargo clean` removed 28.9 GiB of build output. Web build output was deleted. No push, deploy or merge was made.
kayg commented 2026-10-06 00:36:53 +00:00
Author
Owner
Copy link

Orchestrator review of artifacts/hide-1153 (head 219251c49). Fix before the independent data review:

  1. Empty-state lie (notes-hidden-desktop-dark.png): with Show hidden on, All notes lists the hidden Note but the sidebar Notes tree says "No notes yet." The tree follows the same Show hidden preference (dimmed hidden rows when on); when every Note is hidden and Show hidden is off, the empty text says so plainly ("1 hidden note · Show hidden"), never "No notes yet".
  2. Deep-link badge alignment (note-deep-link-desktop-light.png): "Hidden" + Unhide float above the Note card, and "Hidden" starts at a different x than the card's text column. Put the Hidden state inside the Note's header row (a small shared chip "Hidden" next to the title area or in the header action capsule) with Unhide as a shared Pill, aligned to the card's padding/title column (4x crop proof).
  3. E2E coverage the result admits is missing: real-server flows for Calendar Log entries, Tasks, Files/folders and Photos — Hide from ⋯, disappears from the view and search, Undo, Show hidden shows dimmed, Unhide; and check the on-disk marker form for each (day-file line, Task tags, .calternal.json, XMP keywords) round-trips byte-for-byte except the marker. Saved searches/albums: no Hide action is fine (not items in this sense); say so in DESIGN.
  4. Migration 0034 (notes): confirm the number is still free on origin/dev after merging; renumber if needed.
    Merge origin/dev (green); bun run check + bun run test pass; gates per crate quoted; screenshots per Tab at 1440 + 390, light + dark. Commit; comment on #1153 with head SHA. Do not push.
Orchestrator review of artifacts/hide-1153 (head 219251c49). Fix before the independent data review: 1. **Empty-state lie** (notes-hidden-desktop-dark.png): with Show hidden on, All notes lists the hidden Note but the sidebar Notes tree says "No notes yet." The tree follows the same Show hidden preference (dimmed hidden rows when on); when every Note is hidden and Show hidden is off, the empty text says so plainly ("1 hidden note · Show hidden"), never "No notes yet". 2. **Deep-link badge alignment** (note-deep-link-desktop-light.png): "Hidden" + Unhide float above the Note card, and "Hidden" starts at a different x than the card's text column. Put the Hidden state inside the Note's header row (a small shared chip "Hidden" next to the title area or in the header action capsule) with Unhide as a shared Pill, aligned to the card's padding/title column (4x crop proof). 3. **E2E coverage** the result admits is missing: real-server flows for Calendar Log entries, Tasks, Files/folders and Photos — Hide from ⋯, disappears from the view and search, Undo, Show hidden shows dimmed, Unhide; and check the on-disk marker form for each (day-file line, Task tags, .calternal.json, XMP keywords) round-trips byte-for-byte except the marker. Saved searches/albums: no Hide action is fine (not items in this sense); say so in DESIGN. 4. Migration 0034 (notes): confirm the number is still free on origin/dev after merging; renumber if needed. Merge origin/dev (green); `bun run check` + `bun run test` pass; gates per crate quoted; screenshots per Tab at 1440 + 390, light + dark. Commit; comment on #1153 with head SHA. Do not push.
kayg commented 2026-10-06 02:16:44 +00:00
Author
Owner
Copy link

Started hide2-1153 on job/hide-1153, base/head 219251c498. Fixing Notes tree preference and in-card Hidden header; adding real-server coverage for Calendar Log entries, Tasks, Files/folders and Photos, with source-marker checks. No push.

Started hide2-1153 on job/hide-1153, base/head 219251c4986424026df80f2d5f61fd1f0047a87a. Fixing Notes tree preference and in-card Hidden header; adding real-server coverage for Calendar Log entries, Tasks, Files/folders and Photos, with source-marker checks. No push.
kayg commented 2026-10-06 02:24:40 +00:00
Author
Owner
Copy link

Findings: NotesExplorer always requested Files entries with hidden items omitted, and NoteIndex paged Notes without show_hidden. The tree could therefore show “No notes yet.” while the All notes list showed the same hidden Note. The tree now retains bounded hidden entries and filters on the shared per-User preference; NoteIndex retains hidden identities and titles. The hidden-only empty state offers Show hidden. The Note header now uses shared Pill chip/action inside the Card and the editor gutter for its title-column alignment. origin/dev merged cleanly; its latest Notes migration is 0033, so 0034 remains free. Focused regression: Test Files 1 passed (1) / Tests 2 passed (2). Refreshing exact performance pins from the previous Hide changes; no limits are raised.

Findings: NotesExplorer always requested Files entries with hidden items omitted, and NoteIndex paged Notes without show_hidden. The tree could therefore show “No notes yet.” while the All notes list showed the same hidden Note. The tree now retains bounded hidden entries and filters on the shared per-User preference; NoteIndex retains hidden identities and titles. The hidden-only empty state offers Show hidden. The Note header now uses shared Pill chip/action inside the Card and the editor gutter for its title-column alignment. origin/dev merged cleanly; its latest Notes migration is 0033, so 0034 remains free. Focused regression: `Test Files 1 passed (1)` / `Tests 2 passed (2)`. Refreshing exact performance pins from the previous Hide changes; no limits are raised.
kayg commented 2026-10-06 03:00:40 +00:00
Author
Owner
Copy link

Follow-up findings for #1153:

  • Agenda's Journal entry menu had no Hide action. It now calls the existing conditional Log writer and shared Undo. Two focused Agenda regressions pass. The real-server Log flow passes Search removal and exact day-file byte restoration.
  • ItemPreview had a second Hide action with no execution handler. I removed that dead preview action; the working context-menu action remains. Its existing 18 tests pass without changing expectations.
  • The real-server Task flow passes Hide, Search removal, Undo, dimmed Show hidden, Unhide and exact Task source restoration.
  • A hidden File still appeared in Search after 30 seconds, although its folder metadata contained the marker and Files removed its row. The generic text Index only projects Markdown Hide markers, not folder JSON/XMP. I am adding a bounded owner-marker projection across Search provider results, with a regression for a stale provider and a Share recipient. This uses 100-candidate SQL batches, without source reads in the request.
  • The earlier implementation omitted the new Hide route from the performance registry and left syntax pins stale. I am registering the real mutation and its proof, refreshing exact sites, and resolving pure/Index-read sites with exact AST bindings. Removed sites lower the ratchet. No guard rule or numeric budget is raised.

Notes migration 0034 remains free on the origin/dev revision merged for this job. DESIGN now states that Saved searches and Albums are Collection files and have no Hide item action.

Follow-up findings for #1153: - Agenda's Journal entry menu had no Hide action. It now calls the existing conditional Log writer and shared Undo. Two focused Agenda regressions pass. The real-server Log flow passes Search removal and exact day-file byte restoration. - ItemPreview had a second Hide action with no execution handler. I removed that dead preview action; the working context-menu action remains. Its existing 18 tests pass without changing expectations. - The real-server Task flow passes Hide, Search removal, Undo, dimmed Show hidden, Unhide and exact Task source restoration. - A hidden File still appeared in Search after 30 seconds, although its folder metadata contained the marker and Files removed its row. The generic text Index only projects Markdown Hide markers, not folder JSON/XMP. I am adding a bounded owner-marker projection across Search provider results, with a regression for a stale provider and a Share recipient. This uses 100-candidate SQL batches, without source reads in the request. - The earlier implementation omitted the new Hide route from the performance registry and left syntax pins stale. I am registering the real mutation and its proof, refreshing exact sites, and resolving pure/Index-read sites with exact AST bindings. Removed sites lower the ratchet. No guard rule or numeric budget is raised. Notes migration 0034 remains free on the origin/dev revision merged for this job. DESIGN now states that Saved searches and Albums are Collection files and have no Hide item action.
kayg commented 2026-10-06 03:58:00 +00:00
Author
Owner
Copy link

Further review found a Log block scope defect: whole-path marker queries also matched tags.item_kind='log_entry'. One hidden block could then hide its containing day File or visible sibling Search hits. The path projection now excludes Log blocks; their providers keep the per-block flag. A regression checks both the single-path and candidate-set queries. The real-server flow now creates two Log entries in one day File and checks the visible sibling during Hide.

The Notes tree and deep-link flow passed at 390, 820 and 1440 px in both themes with macOS emulation. The screen-reader hidden label and the title-column alignment checks passed. Task and Log source-byte round trips passed. Files verification found a test that attempted to click an exiting selection toolbar; it now waits for that toolbar to detach before selecting an item.

Filed #1175 for ranked Search completeness: generic File/folder metadata flags are not yet projected into the text Index for the positive is:hidden operator or before provider result limits. Default Search removal and Show hidden response labelling are covered by the response projection. This gap does not change access or bytes.

The full web suite passed 1,837 tests. Server unit tests passed (257 passed, 10 ignored); its performance-guard integration caught exact pins invalidated by the later block-scope fix. Those pins are being refreshed to the current sites without changing limits, and that integration will run again.

Further review found a Log block scope defect: whole-path marker queries also matched `tags.item_kind='log_entry'`. One hidden block could then hide its containing day File or visible sibling Search hits. The path projection now excludes Log blocks; their providers keep the per-block flag. A regression checks both the single-path and candidate-set queries. The real-server flow now creates two Log entries in one day File and checks the visible sibling during Hide. The Notes tree and deep-link flow passed at 390, 820 and 1440 px in both themes with macOS emulation. The screen-reader hidden label and the title-column alignment checks passed. Task and Log source-byte round trips passed. Files verification found a test that attempted to click an exiting selection toolbar; it now waits for that toolbar to detach before selecting an item. Filed #1175 for ranked Search completeness: generic File/folder metadata flags are not yet projected into the text Index for the positive `is:hidden` operator or before provider result limits. Default Search removal and Show hidden response labelling are covered by the response projection. This gap does not change access or bytes. The full web suite passed 1,837 tests. Server unit tests passed (257 passed, 10 ignored); its performance-guard integration caught exact pins invalidated by the later block-scope fix. Those pins are being refreshed to the current sites without changing limits, and that integration will run again.
kayg commented 2026-10-06 04:41:10 +00:00
Author
Owner
Copy link

The real-server Photo flow reached Hide, Undo, default Search removal and Show hidden. A reload then failed to show the hidden tile (30-second row wait at the screenshot phase). The shared timeline method returned an earlier in-flight bucket request even for a forced refresh. That read could start before the shared visibility preference loaded.

Fixed the shared timeline owner: forced callers coalesce one follow-up read after the earlier request. A destroyed User store does not start the follow-up. Added a deferred-response regression that verifies two forced callers share one fresh read and retain its real bucket count.

Hide/Unhide can also leave the bucket count unchanged while Show hidden is on. Their Photo handler now calls the existing group-page refresh, including Undo, so the tile's Hidden flag updates without a reload. A second regression verifies that same-count metadata change. The three focused Photo files pass 15 tests. No existing expectation changed.

The new real-server source comparisons remain strict: XMP supports inline and line-based marker elements, and Undo/Unhide must restore the exact original bytes. The test now also checks that Unhide clears each view's dimmed state without navigation. The full web suite is running for this final shared-state change.

The real-server Photo flow reached Hide, Undo, default Search removal and Show hidden. A reload then failed to show the hidden tile (30-second row wait at the screenshot phase). The shared timeline method returned an earlier in-flight bucket request even for a forced refresh. That read could start before the shared visibility preference loaded. Fixed the shared timeline owner: forced callers coalesce one follow-up read after the earlier request. A destroyed User store does not start the follow-up. Added a deferred-response regression that verifies two forced callers share one fresh read and retain its real bucket count. Hide/Unhide can also leave the bucket count unchanged while Show hidden is on. Their Photo handler now calls the existing group-page refresh, including Undo, so the tile's Hidden flag updates without a reload. A second regression verifies that same-count metadata change. The three focused Photo files pass 15 tests. No existing expectation changed. The new real-server source comparisons remain strict: XMP supports inline and line-based marker elements, and Undo/Unhide must restore the exact original bytes. The test now also checks that Unhide clears each view's dimmed state without navigation. The full web suite is running for this final shared-state change.
kayg commented 2026-10-06 04:52:43 +00:00
Author
Owner
Copy link

hide2-1153 review fixes

Head: 8256e5895b884571623edd378eb6af7e27531881. Branch: job/hide-1153. Base: 219251c4986424026df80f2d5f61fd1f0047a87a. Merged origin/dev at d0061ec3df127d81c86729d07d899b0bf2b6de91 once before final gates. No push, deploy or issue close.

Built / UX gaps closed

  • The Notes tree uses the shared Show hidden preference. Revealed hidden rows are dimmed and have accessible names. A hidden-only tree says 1 hidden note · Show hidden. The All notes empty Card says No notes in this view.
  • The Note header contains the shared Hidden chip and Unhide Pill. The browser checks that the chip starts at the title gutter within 1 px. Both themes have 4× crop evidence.
  • The Agenda Journal menu now sends Hide and Unhide to the host. Undo uses the committed marker state. Removed an unhandled hover-preview Hide action.
  • Photos has More actions in the shared selection capsule. Hide works from the existing action sheet. Forced refreshes queue one fresh read after an older read; same-count marker edits refresh the loaded group page. Show hidden survives reload and Unhide clears dimming without navigation.
  • Owner Search projects generic File/folder Hide markers in one bounded Tag Index query after provider fan-out. Stable Files links and listing/native Search queries report the marker. A hidden Log entry cannot hide its day File or siblings. Shared hits do not inherit an owner's marker.
  • The real-server regression covers Notes, Tasks, Calendar Log entries, Files, folders and Photos. It uses real API fixtures and item menus: Hide, default View/Search absence, Undo, Show hidden with dimmed rows, revealed Search flags, and Unhide. It compares Task tags, day-file lines, .calternal.json and XMP against original bytes after stripping only the reserved marker. Undo and Unhide restore exact original metadata; content bytes remain unchanged.
  • Exact performance pins match live calls. The performance guard hashes each binding site once. No guard was weakened and no budget increased; scoped debt fell from 22,104 to 21,955.
  • DESIGN §31 states that saved searches and albums are Collections and have no Hide action. Their items keep Hide.

Migration

Notes migration 0034_note_visibility.sql remains free on the merged origin/dev snapshot. Its latest Notes migration is 0033_link_path_alternates.sql. No renumber was needed.

Verification

Cargo used CARGO_PROFILE_DEV_DEBUG=line-tables-only CARGO_INCREMENTAL=0 CARGO_BUILD_JOBS=4 and the preset target directory. cargo fmt --check exited 0 with no output.

Commands: cargo clippy -p calternal-tags -p calternal-plugin-files --all-targets -- -D warnings, then final Files cargo clippy -p calternal-plugin-files --all-targets -- -D warnings, and cargo clippy -p calternal-server --all-targets -- -D warnings. Output:

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 51.84s
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 25.45s
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 46.89s

cargo test -p calternal-tags:

test result: ok. 20 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 5.36s
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

cargo test -p calternal-plugin-files:

test result: ok. 259 passed; 0 failed; 4 ignored; 0 measured; 0 filtered out; finished in 256.49s
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

cargo test -p calternal-server (unit tests, performance guard integration, private Index permissions integration):

test result: ok. 257 passed; 0 failed; 10 ignored; 0 measured; 0 filtered out; finished in 245.26s
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 45.46s
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.50s

cd apps/web && bun run check:

perf-lint: PASS; 0 violations; 21955 scoped exceptions
svelte-check found 0 errors and 1 warning in 1 file

The warning is the existing empty CSS rule in AttachmentDeck.svelte:1055.

cd apps/web && bun run test --maxWorkers=2 --testTimeout=15000 (full suite; existing assertions unchanged):

 Test Files  266 passed (266)
      Tests  1839 passed (1839)
   Duration  251.45s (transform 30%, environment 26%, import 21%, tests 18%, setup 5%)

The final full runs pass. Earlier startup and unrelated 5-second test timeouts occurred under concurrent compilation; the final web run used the CLI timeout above. No test expectation was changed. The production web build exited 0.

Known gaps / UX gaps left

#1175: generic File/folder markers are absent from the ranked text Index. Positive is:hidden can miss these entries, and hidden hits can underfill a bounded default Search page. Default Search exclusion and Show hidden flags are covered and pass. This Search completeness issue is filed separately; it does not cause data loss, an authorization hole or a crash.

Decisions

  • An empty All notes Card describes this View. The tree supplies the hidden count from its existing bounded read.
  • Generic marker projection uses the shared Tag Index in one bounded query. Log entries retain provider/block scope so a marker cannot hide the whole day File.
  • Photos reuses its existing item action sheet and loaded-group refresh. Concurrent forced refreshes share one follow-up read.

For the merge round

  • Run tests/adversarial/run.sh for cross-User, authorization and robustness coverage. Check Hidden marker visibility across owner and Shared projections. Full adversarial matrices are merge-round work under the verification policy.
  • Run cd apps/web && bun run test:e2e:calendar, bun run test:e2e:files and bun run test:e2e:photos for the broader existing screens. The focused Hide regression runs in this job.
  • Perform deployed o2 and real macOS interop checks with the required VM lock. Screenshots here emulate macOS; Claude reviews their visual quality.
  • Performance measurements are not run for this non-performance issue under the latest verification policy. The existing bench/hidden-1153.mjs profile remains available.

Files

apps/web/e2e/hide-1153.mjs
apps/web/src/lib/calendar/agenda.svelte.test.ts
apps/web/src/lib/files/api.test.ts
apps/web/src/lib/notes/NoteView.svelte
apps/web/src/lib/notes/NotesExplorer.svelte
apps/web/src/lib/notes/api.ts
apps/web/src/lib/notes/noteIndex.svelte.ts
apps/web/src/lib/notes/noteIndex.test.ts
apps/web/src/lib/photos/PhotosView.svelte
apps/web/src/lib/photos/timeline.svelte.ts
apps/web/src/lib/photos/timeline.test.ts
apps/web/src/lib/tasks/api.test.ts
apps/web/src/routes/calendar/[view]/[date]/+page.svelte
apps/web/src/routes/notes/+page.svelte
contracts/perf/adoption-1058.json
contracts/perf/exceptions.json
contracts/perf/ratchet.json
contracts/perf/registry.json
crates/calternal-server/src/main.rs
crates/calternal-tags/src/index.rs
crates/calternal-tags/src/lib.rs
crates/plugins/files/src/lib.rs
crates/plugins/files/src/listing.rs
crates/plugins/files/src/lookup.rs
docs/DESIGN.md
packages/ui/src/components/calendar/AgendaList.svelte
packages/ui/src/components/calendar/ItemPreview.svelte
scripts/perf_guards/rules.py

Focused real-server result

Command: CALTERNAL_E2E_ASSET_OVERRIDE=1 CALTERNAL_E2E_MAC=1 CALTERNAL_SERVER_BIN=$CARGO_TARGET_DIR/debug/calternal-server PLAYWRIGHT_MODULE=/home/kayg/Developer/calternal/tests/adversarial/node_modules/playwright/index.mjs node apps/web/e2e/hide-1153.mjs --screenshots artifacts/hide2-1153/screenshots. Exit 0.

Checking tasks Hide, Search, Undo, Show hidden, Unhide and markdown bytes
PASS tasks Hide round trip
Checking calendar Hide, Search, Undo, Show hidden, Unhide and markdown bytes
PASS calendar Hide round trip
Checking files Hide, Search, Undo, Show hidden, Unhide and json bytes
PASS files Hide round trip
Checking folders Hide, Search, Undo, Show hidden, Unhide and json bytes
PASS folders Hide round trip
Checking photos Hide, Search, Undo, Show hidden, Unhide and xmp bytes
PASS photos Hide round trip
Hide flow passed for Note ee546871-15fe-41e8-84e1-08b5585b6d28; screenshots: /home/kayg/Developer/calternal-wt/hide-1153/artifacts/hide2-1153/screenshots

Production screenshot evidence

50 images attached. macOS emulation, 390/820/1440 px, light and dark; Claude owns visual review.

View 390 light 390 dark 820 light 820 dark 1440 light 1440 dark
notes-hidden-off PNG PNG PNG PNG PNG PNG
notes-hidden PNG PNG PNG PNG PNG PNG
note-deep-link PNG PNG PNG PNG PNG PNG
tasks-hidden PNG PNG PNG PNG PNG PNG
calendar-hidden PNG PNG PNG PNG PNG PNG
files-hidden PNG PNG PNG PNG PNG PNG
folders-hidden PNG PNG PNG PNG PNG PNG
photos-hidden PNG PNG PNG PNG PNG PNG

Note header 4×: light, dark.

Cleanup completed: cargo clean removed 16.5 GiB. Removed generated apps/web/build and apps/web/.svelte-kit/output; retained local review artifacts. The Git worktree is clean. No credential contents were displayed.

# hide2-1153 review fixes Head: `8256e5895b884571623edd378eb6af7e27531881`. Branch: `job/hide-1153`. Base: `219251c4986424026df80f2d5f61fd1f0047a87a`. Merged `origin/dev` at `d0061ec3df127d81c86729d07d899b0bf2b6de91` once before final gates. No push, deploy or issue close. ## Built / UX gaps closed - The Notes tree uses the shared Show hidden preference. Revealed hidden rows are dimmed and have accessible names. A hidden-only tree says `1 hidden note · Show hidden`. The All notes empty Card says `No notes in this view.` - The Note header contains the shared Hidden chip and Unhide Pill. The browser checks that the chip starts at the title gutter within 1 px. Both themes have 4× crop evidence. - The Agenda Journal menu now sends Hide and Unhide to the host. Undo uses the committed marker state. Removed an unhandled hover-preview Hide action. - Photos has More actions in the shared selection capsule. Hide works from the existing action sheet. Forced refreshes queue one fresh read after an older read; same-count marker edits refresh the loaded group page. Show hidden survives reload and Unhide clears dimming without navigation. - Owner Search projects generic File/folder Hide markers in one bounded Tag Index query after provider fan-out. Stable Files links and listing/native Search queries report the marker. A hidden Log entry cannot hide its day File or siblings. Shared hits do not inherit an owner's marker. - The real-server regression covers Notes, Tasks, Calendar Log entries, Files, folders and Photos. It uses real API fixtures and item menus: Hide, default View/Search absence, Undo, Show hidden with dimmed rows, revealed Search flags, and Unhide. It compares Task tags, day-file lines, `.calternal.json` and XMP against original bytes after stripping only the reserved marker. Undo and Unhide restore exact original metadata; content bytes remain unchanged. - Exact performance pins match live calls. The performance guard hashes each binding site once. No guard was weakened and no budget increased; scoped debt fell from 22,104 to 21,955. - DESIGN §31 states that saved searches and albums are Collections and have no Hide action. Their items keep Hide. ## Migration Notes migration `0034_note_visibility.sql` remains free on the merged origin/dev snapshot. Its latest Notes migration is `0033_link_path_alternates.sql`. No renumber was needed. ## Verification Cargo used `CARGO_PROFILE_DEV_DEBUG=line-tables-only CARGO_INCREMENTAL=0 CARGO_BUILD_JOBS=4` and the preset target directory. `cargo fmt --check` exited 0 with no output. Commands: `cargo clippy -p calternal-tags -p calternal-plugin-files --all-targets -- -D warnings`, then final Files `cargo clippy -p calternal-plugin-files --all-targets -- -D warnings`, and `cargo clippy -p calternal-server --all-targets -- -D warnings`. Output: ```text Finished `dev` profile [unoptimized + debuginfo] target(s) in 51.84s Finished `dev` profile [unoptimized + debuginfo] target(s) in 25.45s Finished `dev` profile [unoptimized + debuginfo] target(s) in 46.89s ``` `cargo test -p calternal-tags`: ```text test result: ok. 20 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 5.36s test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s ``` `cargo test -p calternal-plugin-files`: ```text test result: ok. 259 passed; 0 failed; 4 ignored; 0 measured; 0 filtered out; finished in 256.49s test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s ``` `cargo test -p calternal-server` (unit tests, performance guard integration, private Index permissions integration): ```text test result: ok. 257 passed; 0 failed; 10 ignored; 0 measured; 0 filtered out; finished in 245.26s test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 45.46s test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.50s ``` `cd apps/web && bun run check`: ```text perf-lint: PASS; 0 violations; 21955 scoped exceptions svelte-check found 0 errors and 1 warning in 1 file ``` The warning is the existing empty CSS rule in `AttachmentDeck.svelte:1055`. `cd apps/web && bun run test --maxWorkers=2 --testTimeout=15000` (full suite; existing assertions unchanged): ```text Test Files 266 passed (266) Tests 1839 passed (1839) Duration 251.45s (transform 30%, environment 26%, import 21%, tests 18%, setup 5%) ``` The final full runs pass. Earlier startup and unrelated 5-second test timeouts occurred under concurrent compilation; the final web run used the CLI timeout above. No test expectation was changed. The production web build exited 0. ## Known gaps / UX gaps left [#1175](https://git.kayg.org/kayg/calternal/issues/1175): generic File/folder markers are absent from the ranked text Index. Positive `is:hidden` can miss these entries, and hidden hits can underfill a bounded default Search page. Default Search exclusion and Show hidden flags are covered and pass. This Search completeness issue is filed separately; it does not cause data loss, an authorization hole or a crash. ## Decisions - An empty All notes Card describes this View. The tree supplies the hidden count from its existing bounded read. - Generic marker projection uses the shared Tag Index in one bounded query. Log entries retain provider/block scope so a marker cannot hide the whole day File. - Photos reuses its existing item action sheet and loaded-group refresh. Concurrent forced refreshes share one follow-up read. ## For the merge round - Run `tests/adversarial/run.sh` for cross-User, authorization and robustness coverage. Check Hidden marker visibility across owner and Shared projections. Full adversarial matrices are merge-round work under the verification policy. - Run `cd apps/web && bun run test:e2e:calendar`, `bun run test:e2e:files` and `bun run test:e2e:photos` for the broader existing screens. The focused Hide regression runs in this job. - Perform deployed o2 and real macOS interop checks with the required VM lock. Screenshots here emulate macOS; Claude reviews their visual quality. - Performance measurements are not run for this non-performance issue under the latest verification policy. The existing `bench/hidden-1153.mjs` profile remains available. ## Files ```text apps/web/e2e/hide-1153.mjs apps/web/src/lib/calendar/agenda.svelte.test.ts apps/web/src/lib/files/api.test.ts apps/web/src/lib/notes/NoteView.svelte apps/web/src/lib/notes/NotesExplorer.svelte apps/web/src/lib/notes/api.ts apps/web/src/lib/notes/noteIndex.svelte.ts apps/web/src/lib/notes/noteIndex.test.ts apps/web/src/lib/photos/PhotosView.svelte apps/web/src/lib/photos/timeline.svelte.ts apps/web/src/lib/photos/timeline.test.ts apps/web/src/lib/tasks/api.test.ts apps/web/src/routes/calendar/[view]/[date]/+page.svelte apps/web/src/routes/notes/+page.svelte contracts/perf/adoption-1058.json contracts/perf/exceptions.json contracts/perf/ratchet.json contracts/perf/registry.json crates/calternal-server/src/main.rs crates/calternal-tags/src/index.rs crates/calternal-tags/src/lib.rs crates/plugins/files/src/lib.rs crates/plugins/files/src/listing.rs crates/plugins/files/src/lookup.rs docs/DESIGN.md packages/ui/src/components/calendar/AgendaList.svelte packages/ui/src/components/calendar/ItemPreview.svelte scripts/perf_guards/rules.py ``` ## Focused real-server result Command: `CALTERNAL_E2E_ASSET_OVERRIDE=1 CALTERNAL_E2E_MAC=1 CALTERNAL_SERVER_BIN=$CARGO_TARGET_DIR/debug/calternal-server PLAYWRIGHT_MODULE=/home/kayg/Developer/calternal/tests/adversarial/node_modules/playwright/index.mjs node apps/web/e2e/hide-1153.mjs --screenshots artifacts/hide2-1153/screenshots`. Exit 0. ```text Checking tasks Hide, Search, Undo, Show hidden, Unhide and markdown bytes PASS tasks Hide round trip Checking calendar Hide, Search, Undo, Show hidden, Unhide and markdown bytes PASS calendar Hide round trip Checking files Hide, Search, Undo, Show hidden, Unhide and json bytes PASS files Hide round trip Checking folders Hide, Search, Undo, Show hidden, Unhide and json bytes PASS folders Hide round trip Checking photos Hide, Search, Undo, Show hidden, Unhide and xmp bytes PASS photos Hide round trip Hide flow passed for Note ee546871-15fe-41e8-84e1-08b5585b6d28; screenshots: /home/kayg/Developer/calternal-wt/hide-1153/artifacts/hide2-1153/screenshots ``` ## Production screenshot evidence 50 images attached. macOS emulation, 390/820/1440 px, light and dark; Claude owns visual review. | View | 390 light | 390 dark | 820 light | 820 dark | 1440 light | 1440 dark | |---|---|---|---|---|---|---| | notes-hidden-off | [PNG](https://git.kayg.org/attachments/19271d5a-0faa-4280-9a79-35f694763538) | [PNG](https://git.kayg.org/attachments/5dbe1961-bc9e-42f2-86cd-6f191ee65690) | [PNG](https://git.kayg.org/attachments/54d0f1e7-9c2a-4263-9d7a-e18ef66e1292) | [PNG](https://git.kayg.org/attachments/605012f0-3504-4a53-97e7-4036fa35583c) | [PNG](https://git.kayg.org/attachments/1fca18ca-75b2-4fa5-a871-1886a9b6e508) | [PNG](https://git.kayg.org/attachments/236b30aa-3989-48ca-9781-8f660c8e6b16) | | notes-hidden | [PNG](https://git.kayg.org/attachments/10ed9efc-fe84-4a5f-a7a5-49c2e7c112a0) | [PNG](https://git.kayg.org/attachments/6ddc3b88-a396-4583-8e17-ea047260ce52) | [PNG](https://git.kayg.org/attachments/db85d9b6-b63e-4ca4-9467-bb8442f18956) | [PNG](https://git.kayg.org/attachments/5dc3d74a-4f1b-4e54-bd92-bd5ebccf8b6a) | [PNG](https://git.kayg.org/attachments/418416b4-df84-405c-bf6e-aab5d6463178) | [PNG](https://git.kayg.org/attachments/7207b7fd-c448-4c81-a8d2-f1bff9ef92d1) | | note-deep-link | [PNG](https://git.kayg.org/attachments/bca72d99-61c9-44b5-a03b-be7a64b72816) | [PNG](https://git.kayg.org/attachments/393656f3-6d3e-41ca-a802-0bd784978b8d) | [PNG](https://git.kayg.org/attachments/1dd5890c-0ea3-4b38-abdd-ba347a0ae5a0) | [PNG](https://git.kayg.org/attachments/805da9ea-3c0b-421b-81a7-adae2bc6cfb7) | [PNG](https://git.kayg.org/attachments/3e960d56-8dc7-4d84-942c-8fbac2f0d6ed) | [PNG](https://git.kayg.org/attachments/09265282-a416-4049-9f44-95e501a1952c) | | tasks-hidden | [PNG](https://git.kayg.org/attachments/cdf6f532-2591-4af7-ac16-49ebcb1dda78) | [PNG](https://git.kayg.org/attachments/9ae914e5-fdc9-4366-9a53-e74047f835b0) | [PNG](https://git.kayg.org/attachments/f55048db-50dd-47bb-b3de-2867685e10b4) | [PNG](https://git.kayg.org/attachments/9939d16b-73de-4da1-b37b-b80ca157f9e2) | [PNG](https://git.kayg.org/attachments/06648caf-d13c-450e-b4ab-68e73e41227f) | [PNG](https://git.kayg.org/attachments/d6114994-c695-4ec7-bc79-06131602b163) | | calendar-hidden | [PNG](https://git.kayg.org/attachments/182416d8-2c0b-44c1-881f-762b50812ea6) | [PNG](https://git.kayg.org/attachments/08e73ea4-9675-4042-adbb-53de934ecc8a) | [PNG](https://git.kayg.org/attachments/8b5ed724-e5fe-47d3-bccd-d4dc2d8f4ba8) | [PNG](https://git.kayg.org/attachments/c03c8187-fd0a-4bbc-a76f-320722017d7b) | [PNG](https://git.kayg.org/attachments/e8e73252-41d7-48de-8e12-870134402883) | [PNG](https://git.kayg.org/attachments/4218c39a-6197-4401-a4d8-ce8c02b02705) | | files-hidden | [PNG](https://git.kayg.org/attachments/15d5d1e2-1b02-4d50-81a2-2e6aa08f92c0) | [PNG](https://git.kayg.org/attachments/32fdcc32-830f-44c0-8520-f042ec8cd2f6) | [PNG](https://git.kayg.org/attachments/2823cbe8-cc25-4694-84f1-9089373537a2) | [PNG](https://git.kayg.org/attachments/76fd53de-d0bc-4a61-bdcc-387813214cd6) | [PNG](https://git.kayg.org/attachments/5e913ade-80bc-470c-b18b-e096670d050f) | [PNG](https://git.kayg.org/attachments/f7c787b7-eae3-4667-abe8-dd7cb7c131b3) | | folders-hidden | [PNG](https://git.kayg.org/attachments/f8fb3219-d7b2-401a-9c19-656b450443e7) | [PNG](https://git.kayg.org/attachments/b2b731f8-eb96-425a-8f6b-0db85af85641) | [PNG](https://git.kayg.org/attachments/989d67b8-6d77-438a-b168-9c84109aedf8) | [PNG](https://git.kayg.org/attachments/57966b60-7d48-4d5f-871f-7ca86aa842bf) | [PNG](https://git.kayg.org/attachments/ecb3b1f7-96c7-4aaa-baf1-6264063d3611) | [PNG](https://git.kayg.org/attachments/565e0b59-32e0-4ae4-9ec6-94ce9304214c) | | photos-hidden | [PNG](https://git.kayg.org/attachments/c7b54b44-e21b-4d5f-affb-671950e0572a) | [PNG](https://git.kayg.org/attachments/c8d7a838-efba-4dae-9bbb-9d5899564566) | [PNG](https://git.kayg.org/attachments/ee24f972-fe64-4c19-8638-0291f79410c8) | [PNG](https://git.kayg.org/attachments/68336dd2-d1d8-443f-9103-4164e1df88f6) | [PNG](https://git.kayg.org/attachments/99e5d7b0-b12a-4a75-acca-e7860cc04b3c) | [PNG](https://git.kayg.org/attachments/128585b1-fd1d-46e5-b271-283a6a903637) | Note header 4×: [light](https://git.kayg.org/attachments/25be562b-73e6-47f4-9cf1-8368871f5e56), [dark](https://git.kayg.org/attachments/35e6e9c7-0160-4999-8f19-ea6002320002). Cleanup completed: `cargo clean` removed 16.5 GiB. Removed generated `apps/web/build` and `apps/web/.svelte-kit/output`; retained local review artifacts. The Git worktree is clean. No credential contents were displayed.
kayg commented 2026-10-06 04:54:52 +00:00
Author
Owner
Copy link

Independent review started on job/hide-1153, head 8256e5895b884571623edd378eb6af7e27531881, merge base d0061ec3df127d81c86729d07d899b0bf2b6de91. I will check source byte round trips, checked writes, reserved Tag visibility, and Share/User isolation. Findings and verdict will be recorded in review-1153.md. No push or deploy.

Independent review started on `job/hide-1153`, head `8256e5895b884571623edd378eb6af7e27531881`, merge base `d0061ec3df127d81c86729d07d899b0bf2b6de91`. I will check source byte round trips, checked writes, reserved Tag visibility, and Share/User isolation. Findings and verdict will be recorded in `review-1153.md`. No push or deploy.
kayg commented 2026-10-06 05:01:13 +00:00
Author
Owner
Copy link

Independent review finding: a focused frontmatter contract test fails on a BOM + CRLF Note with tags: ['work', "keep"] before a quoted title. Hide → Unhide returns title: Plan before tags: [work, keep], rather than the original bytes. The existing Note test checks parsed Tags, not exact bytes. The properties route also writes a new last edited value on each Hide call. This affects Notes and Markdown Canvases; rich Tasks use the same Tag serialization path. Evidence: artifacts/review-1153/frontmatter-contract.log and the saved contract patch. No original test expectation was changed.

The folder metadata writer also serializes all JSON, and computes its checked-write hash by reading the current source after constructing replacement metadata. Folder and XMP contract probes are running.

Correction to an initial Search concern: recipient Search uses document_for_user / log_document_for_user, which remove owner Hide flags from the recipient Index. The cross-User test will use this production projection.

Independent review finding: a focused frontmatter contract test fails on a BOM + CRLF Note with `tags: ['work', "keep"]` before a quoted title. Hide → Unhide returns `title: Plan` before `tags: [work, keep]`, rather than the original bytes. The existing Note test checks parsed Tags, not exact bytes. The properties route also writes a new `last edited` value on each Hide call. This affects Notes and Markdown Canvases; rich Tasks use the same Tag serialization path. Evidence: `artifacts/review-1153/frontmatter-contract.log` and the saved contract patch. No original test expectation was changed. The folder metadata writer also serializes all JSON, and computes its checked-write hash by reading the current source after constructing replacement metadata. Folder and XMP contract probes are running. Correction to an initial Search concern: recipient Search uses `document_for_user` / `log_document_for_user`, which remove owner Hide flags from the recipient Index. The cross-User test will use this production projection.
kayg commented 2026-10-06 05:07:58 +00:00
Author
Owner
Copy link

Independent review adds two confirmed source-byte failures. An external test binary linked against this branch's compiled calternal-notes-core library runs three contracts. Rich Task Hide → Unhide changes tags: ['work', "keep"] into tags: ["work","keep"]. Log Hide → Unhide changes #work #keep ^block into #work #keep ^block. BOM and CRLF survive these fixtures. The inline Task contract preserves BOM, CRLF, indentation and trailing spaces. Output: test result: FAILED. 1 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s.

The two Notes copy fixes are committed in 2aeec9730. Full web test output: Test Files 266 passed (266); Tests 1840 passed (1840). Web check: perf-lint: PASS; 0 violations; 21955 scoped exceptions; svelte-check found 0 errors and 1 warning in 1 file. The existing warning is an empty CSS ruleset in NoteView. No original assertion was weakened. Findings are in review-1153.md (interim commit 060436eb5). Verdict remains SAFE TO MERGE: NO due to the exact-byte contract failures. Remaining folder, XMP, Search projection and visual checks continue.

Independent review adds two confirmed source-byte failures. An external test binary linked against this branch's compiled `calternal-notes-core` library runs three contracts. Rich Task Hide → Unhide changes `tags: ['work', "keep"]` into `tags: ["work","keep"]`. Log Hide → Unhide changes `#work #keep ^block ` into `#work #keep ^block`. BOM and CRLF survive these fixtures. The inline Task contract preserves BOM, CRLF, indentation and trailing spaces. Output: `test result: FAILED. 1 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s`. The two Notes copy fixes are committed in `2aeec9730`. Full web test output: `Test Files 266 passed (266)`; `Tests 1840 passed (1840)`. Web check: `perf-lint: PASS; 0 violations; 21955 scoped exceptions`; `svelte-check found 0 errors and 1 warning in 1 file`. The existing warning is an empty CSS ruleset in NoteView. No original assertion was weakened. Findings are in `review-1153.md` (interim commit `060436eb5`). Verdict remains SAFE TO MERGE: NO due to the exact-byte contract failures. Remaining folder, XMP, Search projection and visual checks continue.
kayg commented 2026-10-06 05:43:27 +00:00
Author
Owner
Copy link

Review fixes committed: 9499c3188 rejects stale folder Tag replacements and deletions against the revision originally read. The checked deletion regression and filesystem suite pass. db6afe41d adds the separate shared Search regression.

The Search recipient test uses the production per-User Index projection: normal Search finds both Shared items; is:hidden finds none, and the recipient gets no owner hidden flags. The full Search crate run also found a separate fixture error (no such column: mime), filed as #1185. No existing fixture or assertion was weakened.

The production Hide flow passed for Notes, Tasks, Calendar, Files, folders and Photos. The screenshot set covers 390/820/1440 px, light/dark and macOS shortcut rendering. The byte probes use hand-written sources; their failures still block merge even though API-created canonical fixtures pass the UI flow. Folder JSON and XMP normalize bytes; XMP also adds travel when only travel/europe existed.

Current verdict: SAFE TO MERGE: NO. Final backend gates are in progress. The imported Event category path also needed removal of _calternal/hidden from public Tag payloads and counts; focused tests are queued with the backend gates.

Review fixes committed: `9499c3188` rejects stale folder Tag replacements and deletions against the revision originally read. The checked deletion regression and filesystem suite pass. `db6afe41d` adds the separate shared Search regression. The Search recipient test uses the production per-User Index projection: normal Search finds both Shared items; `is:hidden` finds none, and the recipient gets no owner hidden flags. The full Search crate run also found a separate fixture error (`no such column: mime`), filed as #1185. No existing fixture or assertion was weakened. The production Hide flow passed for Notes, Tasks, Calendar, Files, folders and Photos. The screenshot set covers 390/820/1440 px, light/dark and macOS shortcut rendering. The byte probes use hand-written sources; their failures still block merge even though API-created canonical fixtures pass the UI flow. Folder JSON and XMP normalize bytes; XMP also adds `travel` when only `travel/europe` existed. Current verdict: **SAFE TO MERGE: NO**. Final backend gates are in progress. The imported Event category path also needed removal of `_calternal/hidden` from public Tag payloads and counts; focused tests are queued with the backend gates.
kayg commented 2026-10-06 05:57:40 +00:00
Author
Owner
Copy link

Final independent review — SAFE TO MERGE: NO

Head: 314b20b64a4ae38294f6a67c1bde7e5fa8823943. All review fixes and acceptance probes are committed. The worktree is clean. No push, deploy, issue close or merge to another branch was done.

Independent Hide review — #1153

SAFE TO MERGE: NO. The exact source byte contract fails for hand-written Note frontmatter. This also affects Markdown Canvases. Rich Task, Log, folder JSON and XMP sources also fail this contract. The XMP round trip adds a User Tag.

Reviewed feature head: 8256e5895b884571623edd378eb6af7e27531881.
Base: d0061ec3df127d81c86729d07d899b0bf2b6de91 (origin/dev).
git fetch origin && git merge origin/dev returned Already up to date.
No push, deploy or merge to another branch was done.

Built

Review fix head: b1e8ae916df3d6e3e0483e2fd5a0ae4bbca7bf80. The report-only commit follows this head.
Calendar public Tag fix: b1e8ae916.

Commit 2aeec9730 fixes the two requested Notes copy defects. The main empty list counts hidden Notes through the paged Notes API. It shows 1 hidden note · Show hidden and a working button. The sidebar button has an explicit CSS gap after the dot. The focused component test passes. The existing e2e copy assertion changes because this job explicitly changes that copy. Other expectations stay unchanged. Commit 360da609f keeps the hidden count local to each reload, so concurrent loads do not double it.

Files: apps/web/src/lib/components/NoteList.svelte, its .test.ts, apps/web/src/lib/notes/NotesExplorer.svelte, apps/web/src/routes/notes/+page.svelte, apps/web/e2e/hide-1153.mjs. Exact source hashes were refreshed in contracts/perf/exceptions.json and contracts/perf/adoption-1058.json. Rules, limits and the ratchet were not raised.

Findings

R1 — Note and Canvas byte round trips fail

The focused source test uses BOM + CRLF, quoted Tags, and Tags before a quoted title:

tags: ['work', "keep"]
title: 'Plan'
custom: preserved

set_note_frontmatter after Hide and Unhide writes the title first, removes its quotes, and writes tags: [work, keep]. The body, BOM and CRLF survive this fixture. The source does not round-trip byte-for-byte. The existing Hide test checks parsed Tags, not exact bytes. The real properties route also writes last edited on each Hide request. A repeated same-state request can therefore change source bytes and ETag.

Evidence: artifacts/review-1153/frontmatter-contract.patch and frontmatter-contract.log. This temporary probe was removed from product source after the run. No existing test expectation was changed.

test frontmatter::tests::review_1153_frontmatter_byte_round_trip ... FAILED
test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 576 filtered out; finished in 0.00s

R2 — Rich Task and Log source bytes change

The standalone review probe checks hand-written Note, Markdown Canvas, rich Task, Log and inline Task sources. Note, Canvas, rich Task and Log round trips fail. The inline Task fixture passes, including idempotent Hide. Rich Tasks replace YAML quoting and list spacing. Logs remove double spaces between Tags and spaces after the Block ID. The fixtures keep BOM and CRLF.

test review_1153_inline_task_bytes ... ok
test review_1153_rich_task_bytes ... FAILED
test review_1153_log_bytes ... FAILED
test review_1153_note_bytes ... FAILED
test review_1153_canvas_bytes ... FAILED
test result: FAILED. 1 passed; 4 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

Evidence: tests/adversarial/hide-1153-byte-contracts.rs and artifacts/review-1153/byte-contracts.log. The probe deliberately retains the required source bytes as its expected values. It is separate from the Cargo suites; its failures are merge findings.

R3 — Folder JSON and XMP byte round trips fail

The folder fixture has CRLF, indentation and files before schema. Hide and Unhide write compact JSON with schema first. The XMP fixture has CRLF and only one dc:subject keyword, travel/europe. The round trip replaces packet formatting, adds the Adobe toolkit attribute and a hierarchical keyword array, and adds the ordinary travel Tag. It therefore changes User Tags as well as source bytes. Files and folders share the JSON writer.

The corrected focused source probes fail at their byte comparisons. Their first run failed during fixture setup with Exists; that run is not product evidence.

test tests::review_1153_folder_byte_round_trip ... FAILED
test tests::review_1153_xmp_byte_round_trip ... FAILED

Evidence: artifacts/review-1153/tags-contracts.patch and tags-contract-final.log. The temporary failing probes were removed after the evidence was saved. Byte-preserving changes to these writers are still required.

R4 — Stale folder writer accepts a newer revision (fixed)

The probe reads folder metadata, changes its prepared Hide marker, writes a newer User assignment, then saves the stale metadata. Before the fix, the writer reads the newer file only to get its comparison hash. It accepts the stale replacement and loses new-user-edit.

The fix captures the original BLAKE3 digest when the folder source is read. Replacement and deletion use that digest. The digest is held in memory and never enters the JSON file. calternal-fs::Root::delete_if is the small public addition needed for deletion. It checks the digest and runs the existing journaled Delete under the replacement writer lock. It closes the gap between a separate comparison and Delete. Existing namespace mutation guards still apply.

The permanent regression covers stale replacement and stale deletion and checks that the newer bytes stay intact. A filesystem regression checks stale rejection and deletion of an exact current revision. Commit 9499c3188 contains this fix. The source regression and filesystem gates pass. Final gate output is below.

R5 — XMP removes an explicit User Tag (fixed)

With the marker present, the reader removed _calternal even when dc:subject explicitly assigned that User Tag. Hide then Unhide lost it. Commit 02bee7c16 changes the reader. It now removes only an implicit parent added by hierarchical keywords. It reads each Sidecar into its own set before merging. The permanent regression checks both Hide and Unhide with explicit _calternal and keep Tags.

R6 — Imported Event categories expose the marker (fixed)

An external VEVENT can contain _calternal/hidden in CATEGORIES. The import parser copied it into Event Tags. The Calendar Tag count then exposed both the marker and its _calternal prefix. The import and count paths filter the shared reserved Tag constant. Cached Event payloads reuse the common public Tag projection. It covers historic cache rows as well as new imports. Tests exercise raw categories, the /tags route and the cached Event provider. The provider's original iCalendar bytes stay intact.

Reserved Tag and external clients

The app Tag Index excludes _calternal/hidden from Tag lists, counts, item Tag payloads and autocomplete. Dedicated Tag edits reject the reserved name. Note and Log parsing separates it from User Tags. The Files Share list disables marker filtering and clears the displayed hidden state. Calendar and Photos compare owner and viewer before applying Hide. Incoming Notes query has no owner Hide filter.

Native Search uses a private Index per User. document_for_user and log_document_for_user remove the owner Hide flag from a Share recipient projection. Commit db6afe41d adds this regression. An initial query-only concern was withdrawn after this production path was found. The recipient projection test uses this path and passes. It checks ordinary Search, is:hidden and -is:hidden, and confirms that recipient hits do not carry the owner's hidden state. The existing owner assertions stay unchanged; both tests now share the production projection fixture.

test query::tests::review_1153_shared_hidden_search ... ok
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 57 filtered out; finished in 0.10s

External-client decision: raw Markdown and XMP carry the marker. A WebDAV download can see these exact source bytes. XMP currently writes the marker in dc:subject and _calternal|hidden in lr:hierarchicalSubject. Other XMP apps can show it as a keyword. It is not private metadata. iCalendar VEVENT categories use parsed Log Tags, which omit the marker; The native VTODO writer emits no CATEGORIES. Incoming external Event categories now omit the marker from app payloads and counts. Raw file preservation and removal of the stored marker from all external bytes are distinct contracts. This review keeps raw source exports intact and records the external visibility as a product limit. It does not claim the marker is private from raw-file clients.

UX gaps closed

  • Both hidden-only Notes surfaces report the hidden count and offer Show hidden.
  • The sidebar separates the dot and button visually with CSS.
  • The main Show hidden button has a native role, name and shared touch height.

UX gaps left

  • Incoming Notes have no Hide action. A recipient cannot hide a Shared Note independently with the current owner-marker mechanism.
  • Plain .excalidraw JSON cannot use the Note properties writer; it returns 400. This format needs a supported Hide action or an explicit product exception.

Decisions

Count hidden Notes only when the owned list has no visible Notes. Page the same Notes API with Show hidden, so Daily notes and Plugin-owned files stay outside the count. Do not load Note bodies. Use CSS spacing; do not measure layout at runtime.

Raw source exports retain the reserved marker. External XMP apps can see it. The app excludes the marker from User Tag projections; raw-file clients retain access to stored metadata. If raw-file client visibility must also be removed, the marker must move to a separate per-User store.

Verification

Logs and contract patches stay in artifacts/review-1153/. They are not committed.

Focused component test:

 Test Files  1 passed (1)
      Tests  3 passed (3)

cd apps/web && bun run test --maxWorkers=2:

 Test Files  266 passed (266)
      Tests  1840 passed (1840)
   Duration  586.20s (transform 34%, environment 24%, import 23%, tests 14%, setup 5%)

cd apps/web && bun run check:

perf-lint: PASS; 0 violations; 21955 scoped exceptions
svelte-check found 0 errors and 1 warning in 1 file

The warning is an existing empty CSS ruleset in NoteView. The production web build passed. Calendar changed 55 exact performance pins, including three moved expression identities. There are still 21,955 entries. Rules, expiry dates, numeric limits, adoption checkpoints and ratchet ceilings did not change.

cargo fmt --check exited 0 with no output. Required Cargo environment was used for every command. The filesystem, Tags and Search Clippy gates pass. The server Clippy gate was rerun after the final Calendar edit.

cargo clippy -p calternal-fs --all-targets -- -D warnings:

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 13m 02s

cargo test -p calternal-fs -- --test-threads=4:

test result: ok. 95 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 37.78s
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.23s
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.81s
test result: ok. 48 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 10.58s
test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.15s
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

cargo clippy -p calternal-tags --all-targets -- -D warnings:

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 10m 20s

cargo test -p calternal-tags -- --test-threads=4:

test result: ok. 22 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 10.83s
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

cargo clippy -p calternal-search --all-targets -- -D warnings:

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 3m 36s

cargo test -p calternal-search -- --test-threads=4 passed its unit suite and two integration binaries before the #1185 fixture failure:

test result: ok. 57 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 18.74s
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.46s
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.09s

cargo clippy -p calternal-server --all-targets -- -D warnings:

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 59.58s

cargo test -p calternal-server -- --test-threads=4:

test result: ok. 257 passed; 0 failed; 10 ignored; 0 measured; 0 filtered out; finished in 275.19s
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 33.04s
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.72s

cargo test -p calternal-plugin-calendar review_1153_ -- --test-threads=4:

test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 102 filtered out; finished in 2.80s

cargo clippy -p calternal-plugin-calendar --all-targets -- -D warnings:

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 04s

cargo test -p calternal-plugin-calendar -- --test-threads=4:

test result: ok. 103 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 8.99s
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.35s
test result: ok. 3 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.07s
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

The focused production Hide flow passed for Notes, Tasks, Calendar, Files, folders and Photos. Canonical API-created sources pass its round trips; the hand-written byte probes above still fail. Screenshots are in artifacts/review-1153/screenshots/: 390, 820 and 1440 px, light and dark, with macOS platform emulation. Header crops at 4× were inspected for alignment. The orchestrator owns visual review. fj issue comment has no attachment option; the screenshot files remain local for attachment by the orchestrator.

The full Search gate fails in an existing integration fixture, before its latency assertion, with no such column: mime. Filed as #1185. The fixture and expectations were not changed.

test result: FAILED. 25 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 558.75s
error: test failed, to rerun pass `-p calternal-search --test indexer`

No performance measurement was run: this is a data-safety review, and the current verification policy reserves the perf VM for performance issues. No dependency versions changed.

For the merge round

After the source-byte defects are fixed, run the full adversarial matrices and real Apple-client checks under the shared locks. The focused production Hide command is cd apps/web && CALTERNAL_E2E_MAC=1 bun e2e/hide-1153.mjs --screenshots ../../artifacts/review-1153/screenshots; it must prove the marker stays outside User Tag surfaces and each Hide action has Undo, Show hidden and Unhide. Rerun cargo test -p calternal-search --test indexer -- --test-threads=4 after #1185 repairs the schema fixture. No source-byte failure may be resolved by changing its expected bytes.

Re-run the byte probe

Use the required Cargo environment. Build calternal-notes-core, set review_lib to its libcalternal_notes_core-*.rlib under $CARGO_TARGET_DIR/debug/deps, then run:

rustc --edition=2024 --test tests/adversarial/hide-1153-byte-contracts.rs \
  --extern "calternal_notes_core=$review_lib" \
  -L "dependency=$CARGO_TARGET_DIR/debug/deps" \
  -C debuginfo=line-tables-only -o artifacts/review-1153/byte-contracts
artifacts/review-1153/byte-contracts --nocapture

Files

  • apps/web/e2e/hide-1153.mjs
  • apps/web/src/lib/components/NoteList.svelte
  • apps/web/src/lib/components/NoteList.svelte.test.ts
  • apps/web/src/lib/notes/NotesExplorer.svelte
  • apps/web/src/routes/notes/+page.svelte
  • contracts/perf/adoption-1058.json
  • contracts/perf/exceptions.json
  • crates/calternal-fs/src/file_ops.rs
  • crates/calternal-fs/src/lib.rs
  • crates/calternal-search/src/query.rs
  • crates/calternal-tags/src/lib.rs
  • crates/calternal-tags/src/source.rs
  • crates/plugins/calendar/src/client/mod.rs
  • crates/plugins/calendar/src/view.rs
  • review-1153.md
  • tests/adversarial/hide-1153-byte-contracts.rs

Known limits

R1–R3 remain merge blockers. The exact-byte probe retains its failing assertions. The writer change fixes stale folder replacement and deletion; it does not make folder serialization lossless. The XMP reader fix keeps an explicit _calternal User Tag; it does not prevent the separate travel Tag addition.

The source review covers Share listing filters, and the recipient Search regression runs the real private Index projection. A full two-User browser matrix and real Apple-client sync were not run. The current verification policy assigns those full suites to the merge round. Screenshots are local; the CLI cannot attach them. No secret was displayed. No issue was closed.

Cleanup

cargo clean completed:

     Removed 23486 files, 20.3GiB total

Removed generated apps/web/build and apps/web/.svelte-kit/output. Review logs, patches and screenshots remain in artifacts/review-1153/.

Final independent review — **SAFE TO MERGE: NO** Head: `314b20b64a4ae38294f6a67c1bde7e5fa8823943`. All review fixes and acceptance probes are committed. The worktree is clean. No push, deploy, issue close or merge to another branch was done. # Independent Hide review — #1153 SAFE TO MERGE: **NO**. The exact source byte contract fails for hand-written Note frontmatter. This also affects Markdown Canvases. Rich Task, Log, folder JSON and XMP sources also fail this contract. The XMP round trip adds a User Tag. Reviewed feature head: `8256e5895b884571623edd378eb6af7e27531881`. Base: `d0061ec3df127d81c86729d07d899b0bf2b6de91` (`origin/dev`). `git fetch origin && git merge origin/dev` returned `Already up to date.` No push, deploy or merge to another branch was done. ## Built Review fix head: `b1e8ae916df3d6e3e0483e2fd5a0ae4bbca7bf80`. The report-only commit follows this head. Calendar public Tag fix: `b1e8ae916`. Commit `2aeec9730` fixes the two requested Notes copy defects. The main empty list counts hidden Notes through the paged Notes API. It shows `1 hidden note · Show hidden` and a working button. The sidebar button has an explicit CSS gap after the dot. The focused component test passes. The existing e2e copy assertion changes because this job explicitly changes that copy. Other expectations stay unchanged. Commit `360da609f` keeps the hidden count local to each reload, so concurrent loads do not double it. Files: `apps/web/src/lib/components/NoteList.svelte`, its `.test.ts`, `apps/web/src/lib/notes/NotesExplorer.svelte`, `apps/web/src/routes/notes/+page.svelte`, `apps/web/e2e/hide-1153.mjs`. Exact source hashes were refreshed in `contracts/perf/exceptions.json` and `contracts/perf/adoption-1058.json`. Rules, limits and the ratchet were not raised. ## Findings ### R1 — Note and Canvas byte round trips fail The focused source test uses BOM + CRLF, quoted Tags, and Tags before a quoted title: ```yaml tags: ['work', "keep"] title: 'Plan' custom: preserved ``` `set_note_frontmatter` after Hide and Unhide writes the title first, removes its quotes, and writes `tags: [work, keep]`. The body, BOM and CRLF survive this fixture. The source does not round-trip byte-for-byte. The existing Hide test checks parsed Tags, not exact bytes. The real properties route also writes `last edited` on each Hide request. A repeated same-state request can therefore change source bytes and ETag. Evidence: `artifacts/review-1153/frontmatter-contract.patch` and `frontmatter-contract.log`. This temporary probe was removed from product source after the run. No existing test expectation was changed. ```text test frontmatter::tests::review_1153_frontmatter_byte_round_trip ... FAILED test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 576 filtered out; finished in 0.00s ``` ### R2 — Rich Task and Log source bytes change The standalone review probe checks hand-written Note, Markdown Canvas, rich Task, Log and inline Task sources. Note, Canvas, rich Task and Log round trips fail. The inline Task fixture passes, including idempotent Hide. Rich Tasks replace YAML quoting and list spacing. Logs remove double spaces between Tags and spaces after the Block ID. The fixtures keep BOM and CRLF. ```text test review_1153_inline_task_bytes ... ok test review_1153_rich_task_bytes ... FAILED test review_1153_log_bytes ... FAILED test review_1153_note_bytes ... FAILED test review_1153_canvas_bytes ... FAILED test result: FAILED. 1 passed; 4 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s ``` Evidence: `tests/adversarial/hide-1153-byte-contracts.rs` and `artifacts/review-1153/byte-contracts.log`. The probe deliberately retains the required source bytes as its expected values. It is separate from the Cargo suites; its failures are merge findings. ### R3 — Folder JSON and XMP byte round trips fail The folder fixture has CRLF, indentation and `files` before `schema`. Hide and Unhide write compact JSON with `schema` first. The XMP fixture has CRLF and only one `dc:subject` keyword, `travel/europe`. The round trip replaces packet formatting, adds the Adobe toolkit attribute and a hierarchical keyword array, and adds the ordinary `travel` Tag. It therefore changes User Tags as well as source bytes. Files and folders share the JSON writer. The corrected focused source probes fail at their byte comparisons. Their first run failed during fixture setup with `Exists`; that run is not product evidence. ```text test tests::review_1153_folder_byte_round_trip ... FAILED test tests::review_1153_xmp_byte_round_trip ... FAILED ``` Evidence: `artifacts/review-1153/tags-contracts.patch` and `tags-contract-final.log`. The temporary failing probes were removed after the evidence was saved. Byte-preserving changes to these writers are still required. ### R4 — Stale folder writer accepts a newer revision (fixed) The probe reads folder metadata, changes its prepared Hide marker, writes a newer User assignment, then saves the stale metadata. Before the fix, the writer reads the newer file only to get its comparison hash. It accepts the stale replacement and loses `new-user-edit`. The fix captures the original BLAKE3 digest when the folder source is read. Replacement and deletion use that digest. The digest is held in memory and never enters the JSON file. `calternal-fs::Root::delete_if` is the small public addition needed for deletion. It checks the digest and runs the existing journaled Delete under the replacement writer lock. It closes the gap between a separate comparison and Delete. Existing namespace mutation guards still apply. The permanent regression covers stale replacement and stale deletion and checks that the newer bytes stay intact. A filesystem regression checks stale rejection and deletion of an exact current revision. Commit `9499c3188` contains this fix. The source regression and filesystem gates pass. Final gate output is below. ### R5 — XMP removes an explicit User Tag (fixed) With the marker present, the reader removed `_calternal` even when `dc:subject` explicitly assigned that User Tag. Hide then Unhide lost it. Commit `02bee7c16` changes the reader. It now removes only an implicit parent added by hierarchical keywords. It reads each Sidecar into its own set before merging. The permanent regression checks both Hide and Unhide with explicit `_calternal` and `keep` Tags. ### R6 — Imported Event categories expose the marker (fixed) An external VEVENT can contain `_calternal/hidden` in `CATEGORIES`. The import parser copied it into Event Tags. The Calendar Tag count then exposed both the marker and its `_calternal` prefix. The import and count paths filter the shared reserved Tag constant. Cached Event payloads reuse the common public Tag projection. It covers historic cache rows as well as new imports. Tests exercise raw categories, the `/tags` route and the cached Event provider. The provider's original iCalendar bytes stay intact. ### Reserved Tag and external clients The app Tag Index excludes `_calternal/hidden` from Tag lists, counts, item Tag payloads and autocomplete. Dedicated Tag edits reject the reserved name. Note and Log parsing separates it from User Tags. The Files Share list disables marker filtering and clears the displayed hidden state. Calendar and Photos compare owner and viewer before applying Hide. Incoming Notes query has no owner Hide filter. Native Search uses a private Index per User. `document_for_user` and `log_document_for_user` remove the owner Hide flag from a Share recipient projection. Commit `db6afe41d` adds this regression. An initial query-only concern was withdrawn after this production path was found. The recipient projection test uses this path and passes. It checks ordinary Search, `is:hidden` and `-is:hidden`, and confirms that recipient hits do not carry the owner's hidden state. The existing owner assertions stay unchanged; both tests now share the production projection fixture. ```text test query::tests::review_1153_shared_hidden_search ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 57 filtered out; finished in 0.10s ``` External-client decision: raw Markdown and XMP carry the marker. A WebDAV download can see these exact source bytes. XMP currently writes the marker in `dc:subject` and `_calternal|hidden` in `lr:hierarchicalSubject`. Other XMP apps can show it as a keyword. It is not private metadata. iCalendar VEVENT categories use parsed Log Tags, which omit the marker; The native VTODO writer emits no CATEGORIES. Incoming external Event categories now omit the marker from app payloads and counts. Raw file preservation and removal of the stored marker from all external bytes are distinct contracts. This review keeps raw source exports intact and records the external visibility as a product limit. It does not claim the marker is private from raw-file clients. ## UX gaps closed - Both hidden-only Notes surfaces report the hidden count and offer Show hidden. - The sidebar separates the dot and button visually with CSS. - The main Show hidden button has a native role, name and shared touch height. ## UX gaps left - Incoming Notes have no Hide action. A recipient cannot hide a Shared Note independently with the current owner-marker mechanism. - Plain `.excalidraw` JSON cannot use the Note properties writer; it returns 400. This format needs a supported Hide action or an explicit product exception. ## Decisions Count hidden Notes only when the owned list has no visible Notes. Page the same Notes API with Show hidden, so Daily notes and Plugin-owned files stay outside the count. Do not load Note bodies. Use CSS spacing; do not measure layout at runtime. Raw source exports retain the reserved marker. External XMP apps can see it. The app excludes the marker from User Tag projections; raw-file clients retain access to stored metadata. If raw-file client visibility must also be removed, the marker must move to a separate per-User store. ## Verification Logs and contract patches stay in `artifacts/review-1153/`. They are not committed. Focused component test: ```text Test Files 1 passed (1) Tests 3 passed (3) ``` `cd apps/web && bun run test --maxWorkers=2`: ```text Test Files 266 passed (266) Tests 1840 passed (1840) Duration 586.20s (transform 34%, environment 24%, import 23%, tests 14%, setup 5%) ``` `cd apps/web && bun run check`: ```text perf-lint: PASS; 0 violations; 21955 scoped exceptions svelte-check found 0 errors and 1 warning in 1 file ``` The warning is an existing empty CSS ruleset in NoteView. The production web build passed. Calendar changed 55 exact performance pins, including three moved expression identities. There are still 21,955 entries. Rules, expiry dates, numeric limits, adoption checkpoints and ratchet ceilings did not change. `cargo fmt --check` exited 0 with no output. Required Cargo environment was used for every command. The filesystem, Tags and Search Clippy gates pass. The server Clippy gate was rerun after the final Calendar edit. `cargo clippy -p calternal-fs --all-targets -- -D warnings`: ```text Finished `dev` profile [unoptimized + debuginfo] target(s) in 13m 02s ``` `cargo test -p calternal-fs -- --test-threads=4`: ```text test result: ok. 95 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 37.78s test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.23s test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.81s test result: ok. 48 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 10.58s test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.15s test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s ``` `cargo clippy -p calternal-tags --all-targets -- -D warnings`: ```text Finished `dev` profile [unoptimized + debuginfo] target(s) in 10m 20s ``` `cargo test -p calternal-tags -- --test-threads=4`: ```text test result: ok. 22 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 10.83s test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s ``` `cargo clippy -p calternal-search --all-targets -- -D warnings`: ```text Finished `dev` profile [unoptimized + debuginfo] target(s) in 3m 36s ``` `cargo test -p calternal-search -- --test-threads=4` passed its unit suite and two integration binaries before the #1185 fixture failure: ```text test result: ok. 57 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 18.74s test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.46s test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.09s ``` `cargo clippy -p calternal-server --all-targets -- -D warnings`: ```text Finished `dev` profile [unoptimized + debuginfo] target(s) in 59.58s ``` `cargo test -p calternal-server -- --test-threads=4`: ```text test result: ok. 257 passed; 0 failed; 10 ignored; 0 measured; 0 filtered out; finished in 275.19s test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 33.04s test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.72s ``` `cargo test -p calternal-plugin-calendar review_1153_ -- --test-threads=4`: ```text test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 102 filtered out; finished in 2.80s ``` `cargo clippy -p calternal-plugin-calendar --all-targets -- -D warnings`: ```text Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 04s ``` `cargo test -p calternal-plugin-calendar -- --test-threads=4`: ```text test result: ok. 103 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 8.99s test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.35s test result: ok. 3 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.07s test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s ``` The focused production Hide flow passed for Notes, Tasks, Calendar, Files, folders and Photos. Canonical API-created sources pass its round trips; the hand-written byte probes above still fail. Screenshots are in `artifacts/review-1153/screenshots/`: 390, 820 and 1440 px, light and dark, with macOS platform emulation. Header crops at 4× were inspected for alignment. The orchestrator owns visual review. `fj issue comment` has no attachment option; the screenshot files remain local for attachment by the orchestrator. The full Search gate fails in an existing integration fixture, before its latency assertion, with `no such column: mime`. Filed as [#1185](https://git.kayg.org/kayg/calternal/issues/1185). The fixture and expectations were not changed. ```text test result: FAILED. 25 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 558.75s error: test failed, to rerun pass `-p calternal-search --test indexer` ``` No performance measurement was run: this is a data-safety review, and the current verification policy reserves the perf VM for performance issues. No dependency versions changed. ## For the merge round After the source-byte defects are fixed, run the full adversarial matrices and real Apple-client checks under the shared locks. The focused production Hide command is `cd apps/web && CALTERNAL_E2E_MAC=1 bun e2e/hide-1153.mjs --screenshots ../../artifacts/review-1153/screenshots`; it must prove the marker stays outside User Tag surfaces and each Hide action has Undo, Show hidden and Unhide. Rerun `cargo test -p calternal-search --test indexer -- --test-threads=4` after #1185 repairs the schema fixture. No source-byte failure may be resolved by changing its expected bytes. ## Re-run the byte probe Use the required Cargo environment. Build `calternal-notes-core`, set `review_lib` to its `libcalternal_notes_core-*.rlib` under `$CARGO_TARGET_DIR/debug/deps`, then run: ```sh rustc --edition=2024 --test tests/adversarial/hide-1153-byte-contracts.rs \ --extern "calternal_notes_core=$review_lib" \ -L "dependency=$CARGO_TARGET_DIR/debug/deps" \ -C debuginfo=line-tables-only -o artifacts/review-1153/byte-contracts artifacts/review-1153/byte-contracts --nocapture ``` ## Files - `apps/web/e2e/hide-1153.mjs` - `apps/web/src/lib/components/NoteList.svelte` - `apps/web/src/lib/components/NoteList.svelte.test.ts` - `apps/web/src/lib/notes/NotesExplorer.svelte` - `apps/web/src/routes/notes/+page.svelte` - `contracts/perf/adoption-1058.json` - `contracts/perf/exceptions.json` - `crates/calternal-fs/src/file_ops.rs` - `crates/calternal-fs/src/lib.rs` - `crates/calternal-search/src/query.rs` - `crates/calternal-tags/src/lib.rs` - `crates/calternal-tags/src/source.rs` - `crates/plugins/calendar/src/client/mod.rs` - `crates/plugins/calendar/src/view.rs` - `review-1153.md` - `tests/adversarial/hide-1153-byte-contracts.rs` ## Known limits R1–R3 remain merge blockers. The exact-byte probe retains its failing assertions. The writer change fixes stale folder replacement and deletion; it does not make folder serialization lossless. The XMP reader fix keeps an explicit `_calternal` User Tag; it does not prevent the separate `travel` Tag addition. The source review covers Share listing filters, and the recipient Search regression runs the real private Index projection. A full two-User browser matrix and real Apple-client sync were not run. The current verification policy assigns those full suites to the merge round. Screenshots are local; the CLI cannot attach them. No secret was displayed. No issue was closed. ## Cleanup `cargo clean` completed: ```text Removed 23486 files, 20.3GiB total ``` Removed generated `apps/web/build` and `apps/web/.svelte-kit/output`. Review logs, patches and screenshots remain in `artifacts/review-1153/`.
kayg commented 2026-10-06 06:00:32 +00:00
Author
Owner
Copy link

Started hide3-1153 on job/hide-1153 at 314b20b64. Reading the independent review and repairing exact-byte source mutation, XMP keyword preservation, and per-User Hide for read-only items. No push.

Started hide3-1153 on job/hide-1153 at 314b20b64. Reading the independent review and repairing exact-byte source mutation, XMP keyword preservation, and per-User Hide for read-only items. No push.
kayg commented 2026-10-06 06:09:40 +00:00
Author
Owner
Copy link

#1153 byte-fix progress: Notes/Markdown Canvas and rich Task Hide now use source splices; Log Hide bypasses its normal line serializer. Generated YAML tests cover quoting, key order, flow/block/empty Tags, trailing commas, comments, BOM and CRLF. The core test suite passes. The XMP travel addition comes from the ordinary writer creating hierarchical prefix keywords while serializing travel/europe; Hide now has a separate namespace-aware byte editor and does not merge/rewrite keyword bags. Required crate compilation is in progress.

#1153 byte-fix progress: Notes/Markdown Canvas and rich Task Hide now use source splices; Log Hide bypasses its normal line serializer. Generated YAML tests cover quoting, key order, flow/block/empty Tags, trailing commas, comments, BOM and CRLF. The core test suite passes. The XMP `travel` addition comes from the ordinary writer creating hierarchical prefix keywords while serializing `travel/europe`; Hide now has a separate namespace-aware byte editor and does not merge/rewrite keyword bags. Required crate compilation is in progress.
kayg commented 2026-10-06 06:34:26 +00:00
Author
Owner
Copy link

Finding while wiring #1153 overlays: native Search incremental private writes call document_for_user, but the initial private generation in rebuild_user calls flush_upserts, which used the owner-agnostic document and log_document. This could retain an owner's Hide flag in a newly built recipient Index. The fix carries the private viewer through the staging scan and uses the same owner-aware projections for initial and incremental writes. A new integration regression exercises an owner-hidden shared Note through the real Indexer::rebuild_user, then recipient Hide/Unhide and visibility operators without changing owner bytes. Gate compilation is in progress.

Finding while wiring #1153 overlays: native Search incremental private writes call `document_for_user`, but the initial private generation in `rebuild_user` calls `flush_upserts`, which used the owner-agnostic `document` and `log_document`. This could retain an owner's Hide flag in a newly built recipient Index. The fix carries the private viewer through the staging scan and uses the same owner-aware projections for initial and incremental writes. A new integration regression exercises an owner-hidden shared Note through the real `Indexer::rebuild_user`, then recipient Hide/Unhide and visibility operators without changing owner bytes. Gate compilation is in progress.
kayg commented 2026-10-06 06:54:16 +00:00
Author
Owner
Copy link

Index preference decision (#1153): read-only Item overlays use per-User SQLite preference rows (user_hidden_items), keyed by owner and stable Item identity. Normal content reconciliation does not clear them. This avoids a settings file read on each list page. Writes use the existing single Index writer pool and a transaction checks Undo expectations. The retained set is bounded to 4096 Items per User. Hide migration moved to Notes 36 and overlay preferences to 37 after the required origin/dev merge; upstream 34/35 are preserved. No owner source writes occur.

Index preference decision (#1153): read-only Item overlays use per-User SQLite preference rows (`user_hidden_items`), keyed by owner and stable Item identity. Normal content reconciliation does not clear them. This avoids a settings file read on each list page. Writes use the existing single Index writer pool and a transaction checks Undo expectations. The retained set is bounded to 4096 Items per User. Hide migration moved to Notes 36 and overlay preferences to 37 after the required origin/dev merge; upstream 34/35 are preserved. No owner source writes occur.
kayg commented 2026-10-06 07:35:07 +00:00
Author
Owner
Copy link

The overlay source is the recipient's own .calternal/settings.json, keyed by owner plus stable Item ID. user_hidden_items is only a bounded Index projection. A startup recovery and focused regression restore the projection after Index loss; list/Search reads perform no settings-file reads. Hide writes source settings with the existing checked writer and acknowledges after projection. Undo checks the previous state. Both View recipients and plain Canvases use this path and leave owner Item bytes unchanged.

Imported Note IDs may repeat between Homes. Shared Note deep links now carry an owner hint; the server binds that hint to the existing live Share authorization query. This prevents resolving another Home's same-ID Note.

The overlay source is the recipient's own `.calternal/settings.json`, keyed by owner plus stable Item ID. `user_hidden_items` is only a bounded Index projection. A startup recovery and focused regression restore the projection after Index loss; list/Search reads perform no settings-file reads. Hide writes source settings with the existing checked writer and acknowledges after projection. Undo checks the previous state. Both View recipients and plain Canvases use this path and leave owner Item bytes unchanged. Imported Note IDs may repeat between Homes. Shared Note deep links now carry an owner hint; the server binds that hint to the existing live Share authorization query. This prevents resolving another Home's same-ID Note.
kayg commented 2026-10-06 07:56:14 +00:00
Author
Owner
Copy link

A cross-feature review found that adding the overlay parameter to the Notes path-filter parameter vector placed it before repeated Tag parameters, although its SQL placeholder came after them. The new regression combines tag=work, an overlay and limit=1, and verifies hidden exclusion and Show hidden. Overlay predicates now query the indexed (user_id,item_key) table directly. This both fixes binding order and avoids scanning a JSON list of up to 4096 overlay keys for every candidate row. The same indexed membership is used by Files, incoming Notes and the fallback Search providers.

A cross-feature review found that adding the overlay parameter to the Notes path-filter parameter vector placed it before repeated Tag parameters, although its SQL placeholder came after them. The new regression combines `tag=work`, an overlay and `limit=1`, and verifies hidden exclusion and Show hidden. Overlay predicates now query the indexed `(user_id,item_key)` table directly. This both fixes binding order and avoids scanning a JSON list of up to 4096 overlay keys for every candidate row. The same indexed membership is used by Files, incoming Notes and the fallback Search providers.
kayg commented 2026-10-06 08:32:29 +00:00
Author
Owner
Copy link

Review-fix progress on job/hide-1153, head 170678b94.

  • Exact-byte source regressions pass for Notes, Markdown Canvases, rich Tasks, Log lines, folder JSON and XMP. Core: 589 unit tests plus all integration groups pass. Tags: 51 tests pass. The independent review byte probe now passes all five unchanged byte assertions.
  • XMP now reads physical keyword bags without synthesizing travel from travel/europe; explicit _calternal and other keywords survive. Folder and JSON sources preserve BOM and source layout.
  • Private overlays persist in the current User's own settings and project into the Index. Stable keys include the owner and item ID. Index rebuild recovery is tested. Files regression passes for View access, recipient privacy, Undo conflict checking and revoked grants; source bytes stay unchanged.
  • Notes predicates filter overlays before pagination and compose with repeated Tag filters. Search private rebuild and recipient overlay regressions pass.
  • Full Search run reached an existing frecency timing failure: frecency read waited for the held writer transaction: Elapsed(()). No expectation was changed. #1185's missing-mime fixture remains outside this fix.
  • Merge combined duplicate exact performance pins. The final web check exposed inflated per-rule counts. Duplicates are removed; the ratchet is lowered to the exact unique live entries. No rule or budget is weakened.

Final crate gates, production screenshots and web gates are in progress. No push or deployment.

Review-fix progress on `job/hide-1153`, head `170678b94`. - Exact-byte source regressions pass for Notes, Markdown Canvases, rich Tasks, Log lines, folder JSON and XMP. Core: 589 unit tests plus all integration groups pass. Tags: 51 tests pass. The independent review byte probe now passes all five unchanged byte assertions. - XMP now reads physical keyword bags without synthesizing `travel` from `travel/europe`; explicit `_calternal` and other keywords survive. Folder and JSON sources preserve BOM and source layout. - Private overlays persist in the current User's own settings and project into the Index. Stable keys include the owner and item ID. Index rebuild recovery is tested. Files regression passes for View access, recipient privacy, Undo conflict checking and revoked grants; source bytes stay unchanged. - Notes predicates filter overlays before pagination and compose with repeated Tag filters. Search private rebuild and recipient overlay regressions pass. - Full Search run reached an existing frecency timing failure: `frecency read waited for the held writer transaction: Elapsed(())`. No expectation was changed. #1185's missing-mime fixture remains outside this fix. - Merge combined duplicate exact performance pins. The final web check exposed inflated per-rule counts. Duplicates are removed; the ratchet is lowered to the exact unique live entries. No rule or budget is weakened. Final crate gates, production screenshots and web gates are in progress. No push or deployment.
kayg commented 2026-10-06 08:49:04 +00:00
Author
Owner
Copy link

Production finding: the real recipient Hide/Undo flow passed and left the owner bytes unchanged, but GET /api/v1/search?...&show_hidden=true did not return the private Hidden flag. Evidence: artifacts/hide3-1153/e2e-hide.log, overlayFlows assertion after all five cross-format round trips passed.

Cause: calternal-server::apply_search_hidden_markers unconditionally set hit.hidden = false for every Shared/ result. This erased the correctly projected recipient flag from the Search Indexer. The fix resolves the current viewer's preference against bounded hit paths and indexed stable identities, then applies only that preference to Share results. It still removes any stale owner marker from recipient results. New regression: tests::search_boundary_preserves_private_overlay_flags; original owner-marker assertions stay unchanged.

Also corrected stale public SearchHit.hidden and Files Entry documentation to describe the viewer's private overlay. No API shape changed for this correction.

Production finding: the real recipient Hide/Undo flow passed and left the owner bytes unchanged, but `GET /api/v1/search?...&show_hidden=true` did not return the private Hidden flag. Evidence: `artifacts/hide3-1153/e2e-hide.log`, `overlayFlows` assertion after all five cross-format round trips passed. Cause: `calternal-server::apply_search_hidden_markers` unconditionally set `hit.hidden = false` for every `Shared/` result. This erased the correctly projected recipient flag from the Search Indexer. The fix resolves the current viewer's preference against bounded hit paths and indexed stable identities, then applies only that preference to Share results. It still removes any stale owner marker from recipient results. New regression: `tests::search_boundary_preserves_private_overlay_flags`; original owner-marker assertions stay unchanged. Also corrected stale public `SearchHit.hidden` and Files Entry documentation to describe the viewer's private overlay. No API shape changed for this correction.
kayg commented 2026-10-06 09:28:26 +00:00
Author
Owner
Copy link

hide3-1153: NOT READY FOR MERGE

Head: 09323205acb93ba2663896b58120768a77e61aaa, branch job/hide-1153. Merged origin/dev once before final gates. No push or deploy. The four-hour job limit has been reached. All code is committed; the worktree is clean. Build output has been removed (cargo clean: 26.1 GiB).

Built

  • Exact-byte Hide/Unhide splices for Notes, Markdown Canvases, rich Tasks, Log lines, folder .calternal.json and XMP. Tests cover quoting, key order, comments, flow/block lists, CRLF, BOM and unusual whitespace. Provenance records which containers Hide created so Unhide removes only those containers. Log markers preserve trailing block IDs. No whole-document serialization is used for these marker writes.
  • XMP reads physical keyword bags without adding ancestor keywords. Hide/Unhide preserves every unrelated keyword, including explicit _calternal. The independent byte-contract probe passes without changing its expectations.
  • Durable per-User hidden overlays in the User's own settings, with an indexed projection and recovery after Index loss. Keys use stable item identity and owner identity. Checked Undo rejects stale state. Shared View Notes and readable Files/Photos do not write the owner's file. Plain JSON Canvas API tests exercise an indexed ID.
  • Default and is:hidden filtering for Notes, Files, Photos and Search, including shared Notes. Filtering happens before result limits. The final Search HTTP filter preserves recipient visibility. A separate read-only visibility pool avoids waiting for both the single writer and optional ranking reads.
  • Hide/Unhide, Undo, Copy link and shared Note deep links in the UI. Shared links carry an owner hint to resolve duplicate imported IDs. Photo Retry keeps explicit action intent. Owner Note Unhide can perform its checked marker write while editor text is pending.
  • Generated API/action contracts, reviewed exact performance pins, and an extended overlay benchmark profile. Performance rules were not weakened. No perf VM measurement was run because this is not a performance issue under the current verification policy.

Files

Core changes are in crates/calternal-notes-core/src/{frontmatter,dayfile,canvas,tasks/*}.rs, crates/calternal-tags/src/source.rs, crates/calternal-plugin/src/user_settings.rs, crates/plugins/notes/{src/lib.rs,src/store.rs,migrations/0037_user_hidden_items.sql}, crates/plugins/files/src/{lib,listing,lookup,preferences,shares}.rs, crates/plugins/photos/src/{routes,search}.rs, crates/calternal-search/src/{index,indexer,query,plugin}.rs, and crates/calternal-server/src/{main,upgrade_tests}.rs.

UI changes are in the Notes, Canvas, Files, Photos and Search modules under apps/web/src/lib. Review automation is apps/web/e2e/hide-1153.mjs. Contracts are in contracts/ and packages/api-client/src/generated.ts. Documentation and benchmark changes are in docs/DESIGN.md and bench/hidden-1153.mjs. Exact performance pins are in contracts/perf/ and scripts/perf_guards/rules.py. Module comments were re-read before this report.

Blocking finding and UX gaps left

The real production browser check passes the shared Note recipient flow, then fails for a plain .excalidraw Canvas. GET /api/v1/notes/files/open?path=Notes/Hideproof plain canvas.excalidraw returns 200, but Hide through the returned ID sends PATCH /api/v1/notes/<returned-id>/properties and returns 404. Evidence: artifacts/hide3-1153/e2e-overlays.log, assertion 404 !== 200 at line 433. Source inspection points to open_file returning view(...) identity rather than the indexed identity for a format without frontmatter. This diagnosis still needs a regression test and fix. Check both open and get response IDs, then exercise Hide through the returned ID. The existing API regression obtains its ID from the Index and therefore did not detect this browser failure.

Private visibility for shared individual Tasks and shared Log entries has not been implemented or verified. The completed overlay paths cover shared Notes, readable Files/Photos and the plain Canvas API path; they do not prove the entire "all items a User cannot write" requirement. Keep this branch out of the merge until these gaps are resolved or explicitly scoped by the orchestrator.

Plain Canvas screenshots are missing because its flow stops at the 404. Latest full Server and web test gates also need a successful repeat, as detailed below. Full matrices and Mac interop were deferred under the verification policy.

UX gaps closed

Shared Note Hide is private to the recipient; Undo, Unhide, default Search exclusion, revealed Search flags, Shared list visibility and owner-aware deep links passed against a real server. Owner bytes stay unchanged. Owned Notes, Tasks, Calendar, Files, folders and Photos have production-build screenshot coverage. Photo Retry uses the selected action; Note Unhide no longer silently stops when an editor buffer is pending. Pointer and keyboard checks are in the focused browser flow; touch target and macOS shortcut rendering are included in the screenshots. The orchestrator must judge visual quality.

Evidence

74 macOS-emulated screenshots cover phone 390 px, tablet 820 px and desktop 1440 px, in light and dark. They include owned Notes visibility/deep links, Tasks, Calendar, Files, folders, Photo Timeline, Photo Viewer, Tag view, recipient Shared list and shared Note deep links. Review archives:

Logs remain under artifacts/hide3-1153/. The independent five-test byte probe passes. Full Search passes after fixing our visibility-read contention. Earlier comments attributed those timeouts to load; the fix and held-pool regression show that mandatory visibility reads sharing optional ranking/writer connections were the relevant cause. #1185's missing-mime fixture was left unchanged; its test passes on the final merged branch. Do not close #1185.

Gate limits

cargo fmt --check passes without output. All touched-crate clippy gates pass. Notes core, plugin, Notes, Tags, Files, Photos, API and Search tests pass. Focused Server visibility regressions pass. The latest full Server run fails wire::tests::live_apps_run_in_separate_processes at wire.rs:9427 with Os { code: 2, kind: NotFound, message: "No such file or directory" }. An executable replacement race during concurrent cargo builds is suspected; it is not proven. Repeat serially. Do not count this gate as passed.

The latest full web run has one 5000 ms timeout in InfoPanel.svelte.test.ts, test shows Canvas membership with its source title and stable copy link. That unchanged file passes all 19 tests in isolation. An earlier full web run passed all 1921 tests, but the latest full gate is failed. bun run check passes with the existing empty-CSS warning in AttachmentDeck.svelte:1055.

Decisions

  • Own settings are authoritative for private visibility; the Index is a recoverable projection. Existing settings limits bound overlays to 4096 entries and 256 KiB of pretty JSON.
  • Private keys include item kind and owner identity. Shared Note links use an optional owner query hint; it grants no access.
  • Format-local provenance records container ownership for exact reversal. Marker writes retain checked ETag semantics and do not wait for editor animation or pending editor text.
  • Required visibility reads use two read-only connections separate from optional ranking reads and the single writer.

For the next job / merge round

First fix the plain Canvas response identity and add a regression using the ID returned by Files open. Complete or resolve shared Task/Log overlay coverage. Then run:

cargo fmt --check
cargo clippy -p calternal-plugin-notes --all-targets -- -D warnings
cargo test -p calternal-plugin-notes -- --test-threads=4
cargo clippy -p calternal-server --all-targets -- -D warnings
cargo test -p calternal-server -- --test-threads=4
cd apps/web
bun run check
bun run test
CALTERNAL_E2E_MAC=1 CALTERNAL_E2E_ASSET_OVERRIDE=1 bun e2e/hide-1153.mjs --screenshots ../../artifacts/review-1153/screenshots

Use the documented Cargo environment and an available server binary for the browser command. It must prove returned-ID Canvas Hide/Undo, private shared visibility and all six width/theme combinations. Run the full adversarial matrices and staging/Mac interop in the merge round under the required locks. Do not weaken test expectations. The extended profile is bun bench/hidden-1153.mjs --overlays; no numbers are claimed here.

Gate output verbatim

final-fmt.log

(no output; exit 0)

api-clippy-final.log

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 48.26s

api-test-final.log

    Finished `test` profile [unoptimized + debuginfo] target(s) in 38.93s
test result: ok. 18 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.09s
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

final-core-clippy.log

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 11m 07s

final-core-test.log

    Finished `test` profile [unoptimized + debuginfo] target(s) in 8m 04s
test result: ok. 589 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.92s
test result: ok. 19 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 9.17s
test result: ok. 5 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.07s
test result: ok. 7 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.48s
test result: ok. 12 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.04s
test result: ok. 4 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

plugin-clippy.log

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 7m 01s

plugin-test.log

    Finished `test` profile [unoptimized + debuginfo] target(s) in 5m 14s
test result: ok. 49 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 10.55s
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

final-notes-clippy.log

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 11m 24s

final-notes-test.log

    Finished `test` profile [unoptimized + debuginfo] target(s) in 15m 09s
test result: ok. 307 passed; 0 failed; 4 ignored; 0 measured; 0 filtered out; finished in 2104.64s
test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 2.42s
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

final-tags-clippy.log

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 11m 50s

final-tags-test.log

    Finished `test` profile [unoptimized + debuginfo] target(s) in 7m 57s
test result: ok. 51 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 97.96s
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

final-files-clippy.log

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 46.77s

final-files-test.log

    Finished `test` profile [unoptimized + debuginfo] target(s) in 6m 04s
test result: ok. 260 passed; 0 failed; 4 ignored; 0 measured; 0 filtered out; finished in 298.70s
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

final-photos-clippy.log

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 40s

final-photos-test.log

    Finished `test` profile [unoptimized + debuginfo] target(s) in 26.01s
test result: ok. 58 passed; 0 failed; 4 ignored; 0 measured; 0 filtered out; finished in 6.58s
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

search-clippy-final.log

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 7m 39s

final-search-test.log

    Finished `test` profile [unoptimized + debuginfo] target(s) in 3m 07s
test result: ok. 59 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 48.45s
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.97s
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.07s
test result: ok. 27 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 469.08s
test result: ok. 6 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.05s
test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.03s
test result: ok. 1 passed; 0 failed; 2 ignored; 0 measured; 0 filtered out; finished in 3.11s
test result: ok. 4 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

search-frecency-focus.log

    Finished `test` profile [unoptimized + debuginfo] target(s) in 2m 47s
test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 26 filtered out; finished in 2.78s
error: test failed, to rerun pass `-p calternal-search --test indexer`

server-boundary-clippy.log

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 3m 52s

server-boundary-focus.log

    Finished `test` profile [unoptimized + debuginfo] target(s) in 8m 18s
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 274 filtered out; finished in 0.15s
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 1 filtered out; finished in 0.03s
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 1 filtered out; finished in 0.00s

server-owner-focus.log

    Finished `test` profile [unoptimized + debuginfo] target(s) in 11m 39s
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 274 filtered out; finished in 0.27s
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 1 filtered out; finished in 0.00s
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 1 filtered out; finished in 0.00s

server-test-final.log

    Finished `test` profile [unoptimized + debuginfo] target(s) in 12m 32s
test result: FAILED. 264 passed; 1 failed; 10 ignored; 0 measured; 0 filtered out; finished in 289.50s
error: test failed, to rerun pass `-p calternal-server --bin calternal-server`

latest-web-check.log

perf-lint: parse Rust product sources
perf-lint: parse browser product sources
perf-lint: validate coverage and architecture
DEBT io.unresolved-call crates/plugins/calendar/src/feeds/subscriptions.rs calendar_list_subscriptions:read_cache:233907e41cff9547 limit='sqlx::query(\n        "SELECT icalendar, parsed_events, etag, last_modified, refreshed_ms, refresh_after_ms, failure_count, last_error \\\n         FROM calendar_url_subscriptions WHERE owner_id = ? AND id = ?",\n    )\n    .bind(owner)\n    .bind(id)\n    .fetch_optional' owner=https://git.kayg.org/kayg/calternal/issues/677 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/calendar/src/feeds/subscriptions.rs calendar_list_subscriptions:read_cache:4d032ebe4bce1497 limit='sqlx::query(\n        "SELECT icalendar, parsed_events, etag, last_modified, refreshed_ms, refresh_after_ms, failure_count, last_error \\\n         FROM calendar_url_subscriptions WHERE owner_id = ? AND id = ?",\n    )\n    .bind(owner)\n    .bind' owner=https://git.kayg.org/kayg/calternal/issues/677 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/calendar/src/feeds/subscriptions.rs calendar_list_subscriptions:read_cache:59b2e18d2c6e234c limit='row.map(|row| {\n        Ok(CacheRecord {\n            icalendar: row.try_get("icalendar")?,\n            parsed_events: row.try_get("parsed_events")?,\n            etag: row.try_get("etag")?,\n            last_modified: row.try_get("last_modified")?,\n            refreshed_ms: row.try_get("refreshed_ms")?,\n            refresh_after_ms: row.try_get("refresh_after_ms")?,\n            failure_count: row.try_get::<i64, _>("failure_count")?.max(0) as u32,\n            last_error: row.try_get("last_error")?,\n        })\n    })\n    .transpose' owner=https://git.kayg.org/kayg/calternal/issues/677 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/calendar/src/feeds/subscriptions.rs calendar_list_subscriptions:read_cache:92654c0b56aa9feb limit='sqlx::query(\n        "SELECT icalendar, parsed_events, etag, last_modified, refreshed_ms, refresh_after_ms, failure_count, last_error \\\n         FROM calendar_url_subscriptions WHERE owner_id = ? AND id = ?",\n    )\n    .bind' owner=https://git.kayg.org/kayg/calternal/issues/677 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs entries:authorize:4a898330fa4de0c7 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n            .bind(slug)\n            .bind(ip)\n            .bind(slug)\n            .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs entries:authorize:778ad9a69060e936 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n            .bind(slug)\n            .bind(ip)\n            .bind(slug)\n            .bind(&link.id)\n            .bind(&link.password_hash)\n            .execute' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs entries:authorize:97f3dc549d2626b1 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n            .bind(slug)\n            .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs entries:authorize:d321720839567ec5 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n            .bind(slug)\n            .bind(ip)\n            .bind(slug)\n            .bind(&link.id)\n            .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs entries:authorize:d3be6cba02853860 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n            .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs entries:authorize:e0087a0a594c5a4f limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n            .bind(slug)\n            .bind(ip)\n            .bind(slug)\n            .bind(&link.id)\n            .bind(&link.password_hash)\n            .execute(state.db.writer_pool())\n            .await\n            .map_err' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs entries:authorize:e9c1718709427ca4 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n            .bind(slug)\n            .bind(ip)\n            .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs entries:current_link:137adfee590f640b limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n        .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs entries:current_link:1eebc216a4e7e2ec limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n        .bind(slug).fetch_optional(state.db.reader_pool()).await.map_err(database_failure)?.ok_or_else' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs entries:current_link:ecd59ede3f75e21f limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n        .bind(slug).fetch_optional(state.db.reader_pool()).await.map_err' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs entries:current_link:fcd519d2cc9ed4a0 limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n        .bind(slug).fetch_optional' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs files_list_public_links:list:35a2487927e35aa7 limit='sqlx::query("SELECT id, slug, path, permissions, expires_at, password_hash, max_downloads, download_count, view_count, last_access, presentation, hide_filenames FROM files_public_links WHERE owner_id = ? ORDER BY created_at DESC")\n        .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs files_list_public_links:list:426626112ce4a1d4 limit='sqlx::query("SELECT id, slug, path, permissions, expires_at, password_hash, max_downloads, download_count, view_count, last_access, presentation, hide_filenames FROM files_public_links WHERE owner_id = ? ORDER BY created_at DESC")\n        .bind(account_user(&principal)?).fetch_all' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs files_list_public_links:list:8f49c3f982d5611c limit='sqlx::query("SELECT id, slug, path, permissions, expires_at, password_hash, max_downloads, download_count, view_count, last_access, presentation, hide_filenames FROM files_public_links WHERE owner_id = ? ORDER BY created_at DESC")\n        .bind(account_user(&principal)?).fetch_all(state.db.reader_pool()).await.map_err' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs info:authorize:4a898330fa4de0c7 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n            .bind(slug)\n            .bind(ip)\n            .bind(slug)\n            .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs info:authorize:778ad9a69060e936 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n            .bind(slug)\n            .bind(ip)\n            .bind(slug)\n            .bind(&link.id)\n            .bind(&link.password_hash)\n            .execute' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs info:authorize:97f3dc549d2626b1 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n            .bind(slug)\n            .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs info:authorize:d321720839567ec5 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n            .bind(slug)\n            .bind(ip)\n            .bind(slug)\n            .bind(&link.id)\n            .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs info:authorize:d3be6cba02853860 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n            .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs info:authorize:e0087a0a594c5a4f limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n            .bind(slug)\n            .bind(ip)\n            .bind(slug)\n            .bind(&link.id)\n            .bind(&link.password_hash)\n            .execute(state.db.writer_pool())\n            .await\n            .map_err' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs info:authorize:e9c1718709427ca4 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n            .bind(slug)\n            .bind(ip)\n            .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs info:current_link:137adfee590f640b limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n        .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs info:current_link:1eebc216a4e7e2ec limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n        .bind(slug).fetch_optional(state.db.reader_pool()).await.map_err(database_failure)?.ok_or_else' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs info:current_link:ecd59ede3f75e21f limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n        .bind(slug).fetch_optional(state.db.reader_pool()).await.map_err' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs info:current_link:fcd519d2cc9ed4a0 limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n        .bind(slug).fetch_optional' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs linked_note:authorize:4a898330fa4de0c7 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n            .bind(slug)\n            .bind(ip)\n            .bind(slug)\n            .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs linked_note:authorize:778ad9a69060e936 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n            .bind(slug)\n            .bind(ip)\n            .bind(slug)\n            .bind(&link.id)\n            .bind(&link.password_hash)\n            .execute' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs linked_note:authorize:97f3dc549d2626b1 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n            .bind(slug)\n            .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs linked_note:authorize:d321720839567ec5 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n            .bind(slug)\n            .bind(ip)\n            .bind(slug)\n            .bind(&link.id)\n            .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs linked_note:authorize:d3be6cba02853860 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n            .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs linked_note:authorize:e0087a0a594c5a4f limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n            .bind(slug)\n            .bind(ip)\n            .bind(slug)\n            .bind(&link.id)\n            .bind(&link.password_hash)\n            .execute(state.db.writer_pool())\n            .await\n            .map_err' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs linked_note:authorize:e9c1718709427ca4 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n            .bind(slug)\n            .bind(ip)\n            .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs linked_note:current_link:137adfee590f640b limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n        .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs linked_note:current_link:1eebc216a4e7e2ec limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n        .bind(slug).fetch_optional(state.db.reader_pool()).await.map_err(database_failure)?.ok_or_else' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs linked_note:current_link:ecd59ede3f75e21f limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n        .bind(slug).fetch_optional(state.db.reader_pool()).await.map_err' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs linked_note:current_link:fcd519d2cc9ed4a0 limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n        .bind(slug).fetch_optional' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs public_linked_notes:authorize:4a898330fa4de0c7 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n            .bind(slug)\n            .bind(ip)\n            .bind(slug)\n            .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs public_linked_notes:authorize:778ad9a69060e936 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n            .bind(slug)\n            .bind(ip)\n            .bind(slug)\n            .bind(&link.id)\n            .bind(&link.password_hash)\n            .execute' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs public_linked_notes:authorize:97f3dc549d2626b1 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n            .bind(slug)\n            .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs public_linked_notes:authorize:d321720839567ec5 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n            .bind(slug)\n            .bind(ip)\n            .bind(slug)\n            .bind(&link.id)\n            .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs public_linked_notes:authorize:d3be6cba02853860 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n            .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs public_linked_notes:authorize:e0087a0a594c5a4f limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n            .bind(slug)\n            .bind(ip)\n            .bind(slug)\n            .bind(&link.id)\n            .bind(&link.password_hash)\n            .execute(state.db.writer_pool())\n            .await\n            .map_err' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs public_linked_notes:authorize:e9c1718709427ca4 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n            .bind(slug)\n            .bind(ip)\n            .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs public_linked_notes:current_link:137adfee590f640b limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n        .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs public_linked_notes:current_link:1eebc216a4e7e2ec limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n        .bind(slug).fetch_optional(state.db.reader_pool()).await.map_err(database_failure)?.ok_or_else' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs public_linked_notes:current_link:ecd59ede3f75e21f limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n        .bind(slug).fetch_optional(state.db.reader_pool()).await.map_err' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs public_linked_notes:current_link:fcd519d2cc9ed4a0 limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n        .bind(slug).fetch_optional' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs public_upload_head:authorize:4a898330fa4de0c7 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n            .bind(slug)\n            .bind(ip)\n            .bind(slug)\n            .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs public_upload_head:authorize:778ad9a69060e936 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n            .bind(slug)\n            .bind(ip)\n            .bind(slug)\n            .bind(&link.id)\n            .bind(&link.password_hash)\n            .execute' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs public_upload_head:authorize:97f3dc549d2626b1 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n            .bind(slug)\n            .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs public_upload_head:authorize:d321720839567ec5 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n            .bind(slug)\n            .bind(ip)\n            .bind(slug)\n            .bind(&link.id)\n            .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs public_upload_head:authorize:d3be6cba02853860 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n            .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs public_upload_head:authorize:e0087a0a594c5a4f limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n            .bind(slug)\n            .bind(ip)\n            .bind(slug)\n            .bind(&link.id)\n            .bind(&link.password_hash)\n            .execute(state.db.writer_pool())\n            .await\n            .map_err' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs public_upload_head:authorize:e9c1718709427ca4 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n            .bind(slug)\n            .bind(ip)\n            .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs public_upload_head:current_link:137adfee590f640b limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n        .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs public_upload_head:current_link:1eebc216a4e7e2ec limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n        .bind(slug).fetch_optional(state.db.reader_pool()).await.map_err(database_failure)?.ok_or_else' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs public_upload_head:current_link:ecd59ede3f75e21f limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n        .bind(slug).fetch_optional(state.db.reader_pool()).await.map_err' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/files/src/public.rs public_upload_head:current_link:fcd519d2cc9ed4a0 limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n        .bind(slug).fetch_optional' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/mail/src/imap.rs mail_download_attachment:connect:5037cb89ee742676 limit='timeout(AUTH_TIMEOUT, client.login(&account.username, password))\n        .await\n        .map_err' owner=https://git.kayg.org/kayg/calternal/issues/684 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/mail/src/imap.rs mail_download_attachment:connect:7703eb61df01c616 limit='timeout(AUTH_TIMEOUT, client.login(&account.username, password))\n        .await\n        .map_err(|_| ImapError::Timeout)?\n        .map_err' owner=https://git.kayg.org/kayg/calternal/issues/684 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/notes/src/voice.rs notes_voice_transcription:transcription:040c6c7be6355f1a limit='"Local transcription failed. Record a new memo and try again.".into' owner=https://git.kayg.org/kayg/calternal/issues/702 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/notes/src/voice.rs notes_voice_transcription:transcription:71cb23c6769cd0ad limit='"Cleanup failed. The raw transcript is available.".into' owner=https://git.kayg.org/kayg/calternal/issues/702 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/notifications/src/routes.rs notifications_get_quiet_hours:user_id:3c9b29093d0ee67f limit='Uuid::parse_str(&user_id)\n        .map_err(|_| {\n            failure(\n                StatusCode::UNAUTHORIZED,\n                ErrorCode::Unauthorized,\n                "invalid user",\n            )\n        })?\n        .to_string' owner=https://git.kayg.org/kayg/calternal/issues/663 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/notifications/src/routes.rs notifications_inbox_list:user_id:3c9b29093d0ee67f limit='Uuid::parse_str(&user_id)\n        .map_err(|_| {\n            failure(\n                StatusCode::UNAUTHORIZED,\n                ErrorCode::Unauthorized,\n                "invalid user",\n            )\n        })?\n        .to_string' owner=https://git.kayg.org/kayg/calternal/issues/663 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/notifications/src/routes.rs notifications_inbox_mutation_receipt:user_id:3c9b29093d0ee67f limit='Uuid::parse_str(&user_id)\n        .map_err(|_| {\n            failure(\n                StatusCode::UNAUTHORIZED,\n                ErrorCode::Unauthorized,\n                "invalid user",\n            )\n        })?\n        .to_string' owner=https://git.kayg.org/kayg/calternal/issues/663 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/photos/src/routes.rs photos_get_item:internal:18c0be2fd23f30c2 limit='(\n            StatusCode::INTERNAL_SERVER_ERROR,\n            Json(ErrorEnvelope::new(\n                ErrorCode::Internal,\n                "Photos Index failed",\n            )),\n        )\n            .into_response' owner=https://git.kayg.org/kayg/calternal/issues/700 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/photos/src/routes.rs photos_get_stack:internal:18c0be2fd23f30c2 limit='(\n            StatusCode::INTERNAL_SERVER_ERROR,\n            Json(ErrorEnvelope::new(\n                ErrorCode::Internal,\n                "Photos Index failed",\n            )),\n        )\n            .into_response' owner=https://git.kayg.org/kayg/calternal/issues/700 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/photos/src/routes.rs photos_search:internal:18c0be2fd23f30c2 limit='(\n            StatusCode::INTERNAL_SERVER_ERROR,\n            Json(ErrorEnvelope::new(\n                ErrorCode::Internal,\n                "Photos Index failed",\n            )),\n        )\n            .into_response' owner=https://git.kayg.org/kayg/calternal/issues/700 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/photos/src/routes.rs photos_timeline:internal:18c0be2fd23f30c2 limit='(\n            StatusCode::INTERNAL_SERVER_ERROR,\n            Json(ErrorEnvelope::new(\n                ErrorCode::Internal,\n                "Photos Index failed",\n            )),\n        )\n            .into_response' owner=https://git.kayg.org/kayg/calternal/issues/700 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/photos/src/routes.rs photos_timeline_buckets:internal:18c0be2fd23f30c2 limit='(\n            StatusCode::INTERNAL_SERVER_ERROR,\n            Json(ErrorEnvelope::new(\n                ErrorCode::Internal,\n                "Photos Index failed",\n            )),\n        )\n            .into_response' owner=https://git.kayg.org/kayg/calternal/issues/700 expires=2026-11-16
DEBT io.unresolved-call crates/plugins/photos/src/routes.rs photos_timeline_day:internal:18c0be2fd23f30c2 limit='(\n            StatusCode::INTERNAL_SERVER_ERROR,\n            Json(ErrorEnvelope::new(\n                ErrorCode::Internal,\n                "Photos Index failed",\n            )),\n        )\n            .into_response' owner=https://git.kayg.org/kayg/calternal/issues/700 expires=2026-11-16
perf-lint: PASS; 0 violations; 22091 scoped exceptions
svelte-check found 0 errors and 1 warning in 1 file
WEB_CHECK_EXIT=0

latest-web-test.log

 8 pass
 0 fail
Ran 8 tests across 1 file. [542.00ms]
 ❯ |component| src/lib/files/InfoPanel.svelte.test.ts (19 tests | 1 failed) 9872ms
⎯⎯⎯⎯⎯⎯⎯ Failed Tests 1 ⎯⎯⎯⎯⎯⎯⎯
If this is a long-running test, pass a timeout value as the last argument or configure it globally with "testTimeout".
 Test Files  1 failed | 273 passed (274)
      Tests  1 failed | 1920 passed (1921)

infopanel-focus.log

 Test Files  1 passed (1)
      Tests  19 passed (19)

web-focused-final.log

 Test Files  2 passed (2)
      Tests  35 passed (35)

api-client-test.log

(pass) apiFetch > keeps a typed failure body that is not an error envelope [0.42ms]
 20 pass
 0 fail
Ran 20 tests across 1 file. [1410.00ms]

independent-byte-probe.log

test result: ok. 5 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
# hide3-1153: NOT READY FOR MERGE Head: `09323205acb93ba2663896b58120768a77e61aaa`, branch `job/hide-1153`. Merged `origin/dev` once before final gates. No push or deploy. The four-hour job limit has been reached. All code is committed; the worktree is clean. Build output has been removed (`cargo clean`: 26.1 GiB). ## Built - Exact-byte Hide/Unhide splices for Notes, Markdown Canvases, rich Tasks, Log lines, folder `.calternal.json` and XMP. Tests cover quoting, key order, comments, flow/block lists, CRLF, BOM and unusual whitespace. Provenance records which containers Hide created so Unhide removes only those containers. Log markers preserve trailing block IDs. No whole-document serialization is used for these marker writes. - XMP reads physical keyword bags without adding ancestor keywords. Hide/Unhide preserves every unrelated keyword, including explicit `_calternal`. The independent byte-contract probe passes without changing its expectations. - Durable per-User hidden overlays in the User's own settings, with an indexed projection and recovery after Index loss. Keys use stable item identity and owner identity. Checked Undo rejects stale state. Shared View Notes and readable Files/Photos do not write the owner's file. Plain JSON Canvas API tests exercise an indexed ID. - Default and `is:hidden` filtering for Notes, Files, Photos and Search, including shared Notes. Filtering happens before result limits. The final Search HTTP filter preserves recipient visibility. A separate read-only visibility pool avoids waiting for both the single writer and optional ranking reads. - Hide/Unhide, Undo, Copy link and shared Note deep links in the UI. Shared links carry an owner hint to resolve duplicate imported IDs. Photo Retry keeps explicit action intent. Owner Note Unhide can perform its checked marker write while editor text is pending. - Generated API/action contracts, reviewed exact performance pins, and an extended overlay benchmark profile. Performance rules were not weakened. No perf VM measurement was run because this is not a performance issue under the current verification policy. ## Files Core changes are in `crates/calternal-notes-core/src/{frontmatter,dayfile,canvas,tasks/*}.rs`, `crates/calternal-tags/src/source.rs`, `crates/calternal-plugin/src/user_settings.rs`, `crates/plugins/notes/{src/lib.rs,src/store.rs,migrations/0037_user_hidden_items.sql}`, `crates/plugins/files/src/{lib,listing,lookup,preferences,shares}.rs`, `crates/plugins/photos/src/{routes,search}.rs`, `crates/calternal-search/src/{index,indexer,query,plugin}.rs`, and `crates/calternal-server/src/{main,upgrade_tests}.rs`. UI changes are in the Notes, Canvas, Files, Photos and Search modules under `apps/web/src/lib`. Review automation is `apps/web/e2e/hide-1153.mjs`. Contracts are in `contracts/` and `packages/api-client/src/generated.ts`. Documentation and benchmark changes are in `docs/DESIGN.md` and `bench/hidden-1153.mjs`. Exact performance pins are in `contracts/perf/` and `scripts/perf_guards/rules.py`. Module comments were re-read before this report. ## Blocking finding and UX gaps left The real production browser check passes the shared Note recipient flow, then fails for a plain `.excalidraw` Canvas. `GET /api/v1/notes/files/open?path=Notes/Hideproof plain canvas.excalidraw` returns 200, but Hide through the returned ID sends `PATCH /api/v1/notes/<returned-id>/properties` and returns 404. Evidence: `artifacts/hide3-1153/e2e-overlays.log`, assertion `404 !== 200` at line 433. Source inspection points to `open_file` returning `view(...)` identity rather than the indexed identity for a format without frontmatter. This diagnosis still needs a regression test and fix. Check both open and get response IDs, then exercise Hide through the returned ID. The existing API regression obtains its ID from the Index and therefore did not detect this browser failure. Private visibility for shared individual Tasks and shared Log entries has not been implemented or verified. The completed overlay paths cover shared Notes, readable Files/Photos and the plain Canvas API path; they do not prove the entire "all items a User cannot write" requirement. Keep this branch out of the merge until these gaps are resolved or explicitly scoped by the orchestrator. Plain Canvas screenshots are missing because its flow stops at the 404. Latest full Server and web test gates also need a successful repeat, as detailed below. Full matrices and Mac interop were deferred under the verification policy. ## UX gaps closed Shared Note Hide is private to the recipient; Undo, Unhide, default Search exclusion, revealed Search flags, Shared list visibility and owner-aware deep links passed against a real server. Owner bytes stay unchanged. Owned Notes, Tasks, Calendar, Files, folders and Photos have production-build screenshot coverage. Photo Retry uses the selected action; Note Unhide no longer silently stops when an editor buffer is pending. Pointer and keyboard checks are in the focused browser flow; touch target and macOS shortcut rendering are included in the screenshots. The orchestrator must judge visual quality. ## Evidence 74 macOS-emulated screenshots cover phone 390 px, tablet 820 px and desktop 1440 px, in light and dark. They include owned Notes visibility/deep links, Tasks, Calendar, Files, folders, Photo Timeline, Photo Viewer, Tag view, recipient Shared list and shared Note deep links. Review archives: - [Screenshots 1](https://git.kayg.org/attachments/979ef47b-cc26-40e9-b9d8-a02ac14b3a4b) - [Screenshots 2](https://git.kayg.org/attachments/a66b1b62-2dba-4d42-8f42-8022ce61c346) - [Screenshots 3](https://git.kayg.org/attachments/7ef64682-13b5-4083-884b-e4856ebbb945) - [Screenshots 4](https://git.kayg.org/attachments/c87431ce-c59f-4af0-b1c6-32bdfc22d2f2) Logs remain under `artifacts/hide3-1153/`. The independent five-test byte probe passes. Full Search passes after fixing our visibility-read contention. Earlier comments attributed those timeouts to load; the fix and held-pool regression show that mandatory visibility reads sharing optional ranking/writer connections were the relevant cause. #1185's missing-mime fixture was left unchanged; its test passes on the final merged branch. Do not close #1185. ## Gate limits `cargo fmt --check` passes without output. All touched-crate clippy gates pass. Notes core, plugin, Notes, Tags, Files, Photos, API and Search tests pass. Focused Server visibility regressions pass. The latest full Server run fails `wire::tests::live_apps_run_in_separate_processes` at `wire.rs:9427` with `Os { code: 2, kind: NotFound, message: "No such file or directory" }`. An executable replacement race during concurrent cargo builds is suspected; it is not proven. Repeat serially. Do not count this gate as passed. The latest full web run has one 5000 ms timeout in `InfoPanel.svelte.test.ts`, test `shows Canvas membership with its source title and stable copy link`. That unchanged file passes all 19 tests in isolation. An earlier full web run passed all 1921 tests, but the latest full gate is failed. `bun run check` passes with the existing empty-CSS warning in `AttachmentDeck.svelte:1055`. ## Decisions - Own settings are authoritative for private visibility; the Index is a recoverable projection. Existing settings limits bound overlays to 4096 entries and 256 KiB of pretty JSON. - Private keys include item kind and owner identity. Shared Note links use an optional owner query hint; it grants no access. - Format-local provenance records container ownership for exact reversal. Marker writes retain checked ETag semantics and do not wait for editor animation or pending editor text. - Required visibility reads use two read-only connections separate from optional ranking reads and the single writer. ## For the next job / merge round First fix the plain Canvas response identity and add a regression using the ID returned by Files open. Complete or resolve shared Task/Log overlay coverage. Then run: ```sh cargo fmt --check cargo clippy -p calternal-plugin-notes --all-targets -- -D warnings cargo test -p calternal-plugin-notes -- --test-threads=4 cargo clippy -p calternal-server --all-targets -- -D warnings cargo test -p calternal-server -- --test-threads=4 cd apps/web bun run check bun run test CALTERNAL_E2E_MAC=1 CALTERNAL_E2E_ASSET_OVERRIDE=1 bun e2e/hide-1153.mjs --screenshots ../../artifacts/review-1153/screenshots ``` Use the documented Cargo environment and an available server binary for the browser command. It must prove returned-ID Canvas Hide/Undo, private shared visibility and all six width/theme combinations. Run the full adversarial matrices and staging/Mac interop in the merge round under the required locks. Do not weaken test expectations. The extended profile is `bun bench/hidden-1153.mjs --overlays`; no numbers are claimed here. ## Gate output verbatim final-fmt.log ```text (no output; exit 0) ``` api-clippy-final.log ```text Finished `dev` profile [unoptimized + debuginfo] target(s) in 48.26s ``` api-test-final.log ```text Finished `test` profile [unoptimized + debuginfo] target(s) in 38.93s test result: ok. 18 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.09s test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s ``` final-core-clippy.log ```text Finished `dev` profile [unoptimized + debuginfo] target(s) in 11m 07s ``` final-core-test.log ```text Finished `test` profile [unoptimized + debuginfo] target(s) in 8m 04s test result: ok. 589 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.92s test result: ok. 19 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 9.17s test result: ok. 5 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.07s test result: ok. 7 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.48s test result: ok. 12 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.04s test result: ok. 4 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s ``` plugin-clippy.log ```text Finished `dev` profile [unoptimized + debuginfo] target(s) in 7m 01s ``` plugin-test.log ```text Finished `test` profile [unoptimized + debuginfo] target(s) in 5m 14s test result: ok. 49 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 10.55s test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s ``` final-notes-clippy.log ```text Finished `dev` profile [unoptimized + debuginfo] target(s) in 11m 24s ``` final-notes-test.log ```text Finished `test` profile [unoptimized + debuginfo] target(s) in 15m 09s test result: ok. 307 passed; 0 failed; 4 ignored; 0 measured; 0 filtered out; finished in 2104.64s test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 2.42s test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s ``` final-tags-clippy.log ```text Finished `dev` profile [unoptimized + debuginfo] target(s) in 11m 50s ``` final-tags-test.log ```text Finished `test` profile [unoptimized + debuginfo] target(s) in 7m 57s test result: ok. 51 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 97.96s test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s ``` final-files-clippy.log ```text Finished `dev` profile [unoptimized + debuginfo] target(s) in 46.77s ``` final-files-test.log ```text Finished `test` profile [unoptimized + debuginfo] target(s) in 6m 04s test result: ok. 260 passed; 0 failed; 4 ignored; 0 measured; 0 filtered out; finished in 298.70s test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s ``` final-photos-clippy.log ```text Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 40s ``` final-photos-test.log ```text Finished `test` profile [unoptimized + debuginfo] target(s) in 26.01s test result: ok. 58 passed; 0 failed; 4 ignored; 0 measured; 0 filtered out; finished in 6.58s test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s ``` search-clippy-final.log ```text Finished `dev` profile [unoptimized + debuginfo] target(s) in 7m 39s ``` final-search-test.log ```text Finished `test` profile [unoptimized + debuginfo] target(s) in 3m 07s test result: ok. 59 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 48.45s test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.97s test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.07s test result: ok. 27 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 469.08s test result: ok. 6 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.05s test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.03s test result: ok. 1 passed; 0 failed; 2 ignored; 0 measured; 0 filtered out; finished in 3.11s test result: ok. 4 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s ``` search-frecency-focus.log ```text Finished `test` profile [unoptimized + debuginfo] target(s) in 2m 47s test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 26 filtered out; finished in 2.78s error: test failed, to rerun pass `-p calternal-search --test indexer` ``` server-boundary-clippy.log ```text Finished `dev` profile [unoptimized + debuginfo] target(s) in 3m 52s ``` server-boundary-focus.log ```text Finished `test` profile [unoptimized + debuginfo] target(s) in 8m 18s test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 274 filtered out; finished in 0.15s test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 1 filtered out; finished in 0.03s test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 1 filtered out; finished in 0.00s ``` server-owner-focus.log ```text Finished `test` profile [unoptimized + debuginfo] target(s) in 11m 39s test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 274 filtered out; finished in 0.27s test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 1 filtered out; finished in 0.00s test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 1 filtered out; finished in 0.00s ``` server-test-final.log ```text Finished `test` profile [unoptimized + debuginfo] target(s) in 12m 32s test result: FAILED. 264 passed; 1 failed; 10 ignored; 0 measured; 0 filtered out; finished in 289.50s error: test failed, to rerun pass `-p calternal-server --bin calternal-server` ``` latest-web-check.log ```text perf-lint: parse Rust product sources perf-lint: parse browser product sources perf-lint: validate coverage and architecture DEBT io.unresolved-call crates/plugins/calendar/src/feeds/subscriptions.rs calendar_list_subscriptions:read_cache:233907e41cff9547 limit='sqlx::query(\n "SELECT icalendar, parsed_events, etag, last_modified, refreshed_ms, refresh_after_ms, failure_count, last_error \\\n FROM calendar_url_subscriptions WHERE owner_id = ? AND id = ?",\n )\n .bind(owner)\n .bind(id)\n .fetch_optional' owner=https://git.kayg.org/kayg/calternal/issues/677 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/calendar/src/feeds/subscriptions.rs calendar_list_subscriptions:read_cache:4d032ebe4bce1497 limit='sqlx::query(\n "SELECT icalendar, parsed_events, etag, last_modified, refreshed_ms, refresh_after_ms, failure_count, last_error \\\n FROM calendar_url_subscriptions WHERE owner_id = ? AND id = ?",\n )\n .bind(owner)\n .bind' owner=https://git.kayg.org/kayg/calternal/issues/677 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/calendar/src/feeds/subscriptions.rs calendar_list_subscriptions:read_cache:59b2e18d2c6e234c limit='row.map(|row| {\n Ok(CacheRecord {\n icalendar: row.try_get("icalendar")?,\n parsed_events: row.try_get("parsed_events")?,\n etag: row.try_get("etag")?,\n last_modified: row.try_get("last_modified")?,\n refreshed_ms: row.try_get("refreshed_ms")?,\n refresh_after_ms: row.try_get("refresh_after_ms")?,\n failure_count: row.try_get::<i64, _>("failure_count")?.max(0) as u32,\n last_error: row.try_get("last_error")?,\n })\n })\n .transpose' owner=https://git.kayg.org/kayg/calternal/issues/677 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/calendar/src/feeds/subscriptions.rs calendar_list_subscriptions:read_cache:92654c0b56aa9feb limit='sqlx::query(\n "SELECT icalendar, parsed_events, etag, last_modified, refreshed_ms, refresh_after_ms, failure_count, last_error \\\n FROM calendar_url_subscriptions WHERE owner_id = ? AND id = ?",\n )\n .bind' owner=https://git.kayg.org/kayg/calternal/issues/677 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs entries:authorize:4a898330fa4de0c7 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n .bind(slug)\n .bind(ip)\n .bind(slug)\n .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs entries:authorize:778ad9a69060e936 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n .bind(slug)\n .bind(ip)\n .bind(slug)\n .bind(&link.id)\n .bind(&link.password_hash)\n .execute' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs entries:authorize:97f3dc549d2626b1 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n .bind(slug)\n .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs entries:authorize:d321720839567ec5 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n .bind(slug)\n .bind(ip)\n .bind(slug)\n .bind(&link.id)\n .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs entries:authorize:d3be6cba02853860 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs entries:authorize:e0087a0a594c5a4f limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n .bind(slug)\n .bind(ip)\n .bind(slug)\n .bind(&link.id)\n .bind(&link.password_hash)\n .execute(state.db.writer_pool())\n .await\n .map_err' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs entries:authorize:e9c1718709427ca4 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n .bind(slug)\n .bind(ip)\n .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs entries:current_link:137adfee590f640b limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs entries:current_link:1eebc216a4e7e2ec limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n .bind(slug).fetch_optional(state.db.reader_pool()).await.map_err(database_failure)?.ok_or_else' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs entries:current_link:ecd59ede3f75e21f limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n .bind(slug).fetch_optional(state.db.reader_pool()).await.map_err' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs entries:current_link:fcd519d2cc9ed4a0 limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n .bind(slug).fetch_optional' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs files_list_public_links:list:35a2487927e35aa7 limit='sqlx::query("SELECT id, slug, path, permissions, expires_at, password_hash, max_downloads, download_count, view_count, last_access, presentation, hide_filenames FROM files_public_links WHERE owner_id = ? ORDER BY created_at DESC")\n .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs files_list_public_links:list:426626112ce4a1d4 limit='sqlx::query("SELECT id, slug, path, permissions, expires_at, password_hash, max_downloads, download_count, view_count, last_access, presentation, hide_filenames FROM files_public_links WHERE owner_id = ? ORDER BY created_at DESC")\n .bind(account_user(&principal)?).fetch_all' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs files_list_public_links:list:8f49c3f982d5611c limit='sqlx::query("SELECT id, slug, path, permissions, expires_at, password_hash, max_downloads, download_count, view_count, last_access, presentation, hide_filenames FROM files_public_links WHERE owner_id = ? ORDER BY created_at DESC")\n .bind(account_user(&principal)?).fetch_all(state.db.reader_pool()).await.map_err' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs info:authorize:4a898330fa4de0c7 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n .bind(slug)\n .bind(ip)\n .bind(slug)\n .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs info:authorize:778ad9a69060e936 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n .bind(slug)\n .bind(ip)\n .bind(slug)\n .bind(&link.id)\n .bind(&link.password_hash)\n .execute' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs info:authorize:97f3dc549d2626b1 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n .bind(slug)\n .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs info:authorize:d321720839567ec5 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n .bind(slug)\n .bind(ip)\n .bind(slug)\n .bind(&link.id)\n .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs info:authorize:d3be6cba02853860 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs info:authorize:e0087a0a594c5a4f limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n .bind(slug)\n .bind(ip)\n .bind(slug)\n .bind(&link.id)\n .bind(&link.password_hash)\n .execute(state.db.writer_pool())\n .await\n .map_err' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs info:authorize:e9c1718709427ca4 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n .bind(slug)\n .bind(ip)\n .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs info:current_link:137adfee590f640b limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs info:current_link:1eebc216a4e7e2ec limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n .bind(slug).fetch_optional(state.db.reader_pool()).await.map_err(database_failure)?.ok_or_else' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs info:current_link:ecd59ede3f75e21f limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n .bind(slug).fetch_optional(state.db.reader_pool()).await.map_err' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs info:current_link:fcd519d2cc9ed4a0 limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n .bind(slug).fetch_optional' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs linked_note:authorize:4a898330fa4de0c7 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n .bind(slug)\n .bind(ip)\n .bind(slug)\n .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs linked_note:authorize:778ad9a69060e936 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n .bind(slug)\n .bind(ip)\n .bind(slug)\n .bind(&link.id)\n .bind(&link.password_hash)\n .execute' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs linked_note:authorize:97f3dc549d2626b1 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n .bind(slug)\n .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs linked_note:authorize:d321720839567ec5 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n .bind(slug)\n .bind(ip)\n .bind(slug)\n .bind(&link.id)\n .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs linked_note:authorize:d3be6cba02853860 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs linked_note:authorize:e0087a0a594c5a4f limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n .bind(slug)\n .bind(ip)\n .bind(slug)\n .bind(&link.id)\n .bind(&link.password_hash)\n .execute(state.db.writer_pool())\n .await\n .map_err' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs linked_note:authorize:e9c1718709427ca4 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n .bind(slug)\n .bind(ip)\n .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs linked_note:current_link:137adfee590f640b limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs linked_note:current_link:1eebc216a4e7e2ec limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n .bind(slug).fetch_optional(state.db.reader_pool()).await.map_err(database_failure)?.ok_or_else' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs linked_note:current_link:ecd59ede3f75e21f limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n .bind(slug).fetch_optional(state.db.reader_pool()).await.map_err' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs linked_note:current_link:fcd519d2cc9ed4a0 limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n .bind(slug).fetch_optional' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs public_linked_notes:authorize:4a898330fa4de0c7 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n .bind(slug)\n .bind(ip)\n .bind(slug)\n .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs public_linked_notes:authorize:778ad9a69060e936 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n .bind(slug)\n .bind(ip)\n .bind(slug)\n .bind(&link.id)\n .bind(&link.password_hash)\n .execute' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs public_linked_notes:authorize:97f3dc549d2626b1 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n .bind(slug)\n .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs public_linked_notes:authorize:d321720839567ec5 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n .bind(slug)\n .bind(ip)\n .bind(slug)\n .bind(&link.id)\n .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs public_linked_notes:authorize:d3be6cba02853860 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs public_linked_notes:authorize:e0087a0a594c5a4f limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n .bind(slug)\n .bind(ip)\n .bind(slug)\n .bind(&link.id)\n .bind(&link.password_hash)\n .execute(state.db.writer_pool())\n .await\n .map_err' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs public_linked_notes:authorize:e9c1718709427ca4 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n .bind(slug)\n .bind(ip)\n .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs public_linked_notes:current_link:137adfee590f640b limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs public_linked_notes:current_link:1eebc216a4e7e2ec limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n .bind(slug).fetch_optional(state.db.reader_pool()).await.map_err(database_failure)?.ok_or_else' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs public_linked_notes:current_link:ecd59ede3f75e21f limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n .bind(slug).fetch_optional(state.db.reader_pool()).await.map_err' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs public_linked_notes:current_link:fcd519d2cc9ed4a0 limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n .bind(slug).fetch_optional' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs public_upload_head:authorize:4a898330fa4de0c7 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n .bind(slug)\n .bind(ip)\n .bind(slug)\n .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs public_upload_head:authorize:778ad9a69060e936 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n .bind(slug)\n .bind(ip)\n .bind(slug)\n .bind(&link.id)\n .bind(&link.password_hash)\n .execute' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs public_upload_head:authorize:97f3dc549d2626b1 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n .bind(slug)\n .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs public_upload_head:authorize:d321720839567ec5 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n .bind(slug)\n .bind(ip)\n .bind(slug)\n .bind(&link.id)\n .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs public_upload_head:authorize:d3be6cba02853860 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs public_upload_head:authorize:e0087a0a594c5a4f limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n .bind(slug)\n .bind(ip)\n .bind(slug)\n .bind(&link.id)\n .bind(&link.password_hash)\n .execute(state.db.writer_pool())\n .await\n .map_err' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs public_upload_head:authorize:e9c1718709427ca4 limit='sqlx::query("DELETE FROM files_public_ip_failures WHERE slug = ? AND ip = ? AND EXISTS (SELECT 1 FROM files_public_links WHERE slug = ? AND id = ? AND password_hash IS ?)")\n .bind(slug)\n .bind(ip)\n .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs public_upload_head:current_link:137adfee590f640b limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n .bind' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs public_upload_head:current_link:1eebc216a4e7e2ec limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n .bind(slug).fetch_optional(state.db.reader_pool()).await.map_err(database_failure)?.ok_or_else' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs public_upload_head:current_link:ecd59ede3f75e21f limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n .bind(slug).fetch_optional(state.db.reader_pool()).await.map_err' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/files/src/public.rs public_upload_head:current_link:fcd519d2cc9ed4a0 limit='sqlx::query("SELECT id, owner_id, path, item_id, permissions, expires_at, password_hash, max_downloads, download_count, presentation, hide_filenames FROM files_public_links WHERE slug = ?")\n .bind(slug).fetch_optional' owner=https://git.kayg.org/kayg/calternal/issues/699 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/mail/src/imap.rs mail_download_attachment:connect:5037cb89ee742676 limit='timeout(AUTH_TIMEOUT, client.login(&account.username, password))\n .await\n .map_err' owner=https://git.kayg.org/kayg/calternal/issues/684 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/mail/src/imap.rs mail_download_attachment:connect:7703eb61df01c616 limit='timeout(AUTH_TIMEOUT, client.login(&account.username, password))\n .await\n .map_err(|_| ImapError::Timeout)?\n .map_err' owner=https://git.kayg.org/kayg/calternal/issues/684 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/notes/src/voice.rs notes_voice_transcription:transcription:040c6c7be6355f1a limit='"Local transcription failed. Record a new memo and try again.".into' owner=https://git.kayg.org/kayg/calternal/issues/702 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/notes/src/voice.rs notes_voice_transcription:transcription:71cb23c6769cd0ad limit='"Cleanup failed. The raw transcript is available.".into' owner=https://git.kayg.org/kayg/calternal/issues/702 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/notifications/src/routes.rs notifications_get_quiet_hours:user_id:3c9b29093d0ee67f limit='Uuid::parse_str(&user_id)\n .map_err(|_| {\n failure(\n StatusCode::UNAUTHORIZED,\n ErrorCode::Unauthorized,\n "invalid user",\n )\n })?\n .to_string' owner=https://git.kayg.org/kayg/calternal/issues/663 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/notifications/src/routes.rs notifications_inbox_list:user_id:3c9b29093d0ee67f limit='Uuid::parse_str(&user_id)\n .map_err(|_| {\n failure(\n StatusCode::UNAUTHORIZED,\n ErrorCode::Unauthorized,\n "invalid user",\n )\n })?\n .to_string' owner=https://git.kayg.org/kayg/calternal/issues/663 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/notifications/src/routes.rs notifications_inbox_mutation_receipt:user_id:3c9b29093d0ee67f limit='Uuid::parse_str(&user_id)\n .map_err(|_| {\n failure(\n StatusCode::UNAUTHORIZED,\n ErrorCode::Unauthorized,\n "invalid user",\n )\n })?\n .to_string' owner=https://git.kayg.org/kayg/calternal/issues/663 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/photos/src/routes.rs photos_get_item:internal:18c0be2fd23f30c2 limit='(\n StatusCode::INTERNAL_SERVER_ERROR,\n Json(ErrorEnvelope::new(\n ErrorCode::Internal,\n "Photos Index failed",\n )),\n )\n .into_response' owner=https://git.kayg.org/kayg/calternal/issues/700 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/photos/src/routes.rs photos_get_stack:internal:18c0be2fd23f30c2 limit='(\n StatusCode::INTERNAL_SERVER_ERROR,\n Json(ErrorEnvelope::new(\n ErrorCode::Internal,\n "Photos Index failed",\n )),\n )\n .into_response' owner=https://git.kayg.org/kayg/calternal/issues/700 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/photos/src/routes.rs photos_search:internal:18c0be2fd23f30c2 limit='(\n StatusCode::INTERNAL_SERVER_ERROR,\n Json(ErrorEnvelope::new(\n ErrorCode::Internal,\n "Photos Index failed",\n )),\n )\n .into_response' owner=https://git.kayg.org/kayg/calternal/issues/700 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/photos/src/routes.rs photos_timeline:internal:18c0be2fd23f30c2 limit='(\n StatusCode::INTERNAL_SERVER_ERROR,\n Json(ErrorEnvelope::new(\n ErrorCode::Internal,\n "Photos Index failed",\n )),\n )\n .into_response' owner=https://git.kayg.org/kayg/calternal/issues/700 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/photos/src/routes.rs photos_timeline_buckets:internal:18c0be2fd23f30c2 limit='(\n StatusCode::INTERNAL_SERVER_ERROR,\n Json(ErrorEnvelope::new(\n ErrorCode::Internal,\n "Photos Index failed",\n )),\n )\n .into_response' owner=https://git.kayg.org/kayg/calternal/issues/700 expires=2026-11-16 DEBT io.unresolved-call crates/plugins/photos/src/routes.rs photos_timeline_day:internal:18c0be2fd23f30c2 limit='(\n StatusCode::INTERNAL_SERVER_ERROR,\n Json(ErrorEnvelope::new(\n ErrorCode::Internal,\n "Photos Index failed",\n )),\n )\n .into_response' owner=https://git.kayg.org/kayg/calternal/issues/700 expires=2026-11-16 perf-lint: PASS; 0 violations; 22091 scoped exceptions svelte-check found 0 errors and 1 warning in 1 file WEB_CHECK_EXIT=0 ``` latest-web-test.log ```text 8 pass 0 fail Ran 8 tests across 1 file. [542.00ms] ❯ |component| src/lib/files/InfoPanel.svelte.test.ts (19 tests | 1 failed) 9872ms ⎯⎯⎯⎯⎯⎯⎯ Failed Tests 1 ⎯⎯⎯⎯⎯⎯⎯ If this is a long-running test, pass a timeout value as the last argument or configure it globally with "testTimeout". Test Files 1 failed | 273 passed (274) Tests 1 failed | 1920 passed (1921) ``` infopanel-focus.log ```text Test Files 1 passed (1) Tests 19 passed (19) ``` web-focused-final.log ```text Test Files 2 passed (2) Tests 35 passed (35) ``` api-client-test.log ```text (pass) apiFetch > keeps a typed failure body that is not an error envelope [0.42ms] 20 pass 0 fail Ran 20 tests across 1 file. [1410.00ms] ``` independent-byte-probe.log ```text test result: ok. 5 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s ```
kayg commented 2026-10-06 12:08:58 +00:00
Author
Owner
Copy link

Continuing hide4-1153 on job/hide-1153, base/head 09323205acb93ba2663896b58120768a77e61aaa. I will fix Files-open Canvas IDs, complete View-only Task and Log overlays, and fix the failing web gate. No pushes or deployments.

Continuing hide4-1153 on `job/hide-1153`, base/head `09323205acb93ba2663896b58120768a77e61aaa`. I will fix Files-open Canvas IDs, complete View-only Task and Log overlays, and fix the failing web gate. No pushes or deployments.
kayg commented 2026-10-06 12:24:11 +00:00
Author
Owner
Copy link

Findings: Files open used source frontmatter to form the plain Canvas ID, while the Index retained a different ID. It now returns the retained Index identity; marker-only plain Canvas writes also canonicalize legacy aliases. Shared Task PATCH rejected all qualified IDs. Shared Log range rows exposed unqualified block IDs and had no recipient overlay. The new visibility-only branches check server-authorized Share roots and keep owner bytes unchanged. Calendar counts and detail rows apply the same viewer overlay. Hidden Log links also need a one-day projection because the default range excludes them; this opens only the requested preview. The prior web failure is a 5-second timeout in the Canvas membership test; its one-shot fake response changed to an empty list on refresh. The fixture now persists across refreshes and is reset per test. No assertions changed.

Decisions: shared Log API identities use shared:<owner>:<block> as Tasks already do; the source Block ID stays unchanged. File Task overlays use the Note identity, so Files, Notes and Calendar agree.

Findings: Files open used source frontmatter to form the plain Canvas ID, while the Index retained a different ID. It now returns the retained Index identity; marker-only plain Canvas writes also canonicalize legacy aliases. Shared Task PATCH rejected all qualified IDs. Shared Log range rows exposed unqualified block IDs and had no recipient overlay. The new visibility-only branches check server-authorized Share roots and keep owner bytes unchanged. Calendar counts and detail rows apply the same viewer overlay. Hidden Log links also need a one-day projection because the default range excludes them; this opens only the requested preview. The prior web failure is a 5-second timeout in the Canvas membership test; its one-shot fake response changed to an empty list on refresh. The fixture now persists across refreshes and is reset per test. No assertions changed. Decisions: shared Log API identities use `shared:<owner>:<block>` as Tasks already do; the source Block ID stays unchanged. File Task overlays use the Note identity, so Files, Notes and Calendar agree.
kayg commented 2026-10-06 12:50:23 +00:00
Author
Owner
Copy link

Progress on job/hide-1153, HEAD 105ba74ce: merged origin/dev once. The production web build passed. Notes clippy passed:

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 31m 33s

bun run check reports svelte-check found 0 errors and 1 warning in 1 file; the warning is the existing empty AttachmentDeck focus ruleset. Full web tests (two workers, 30-second test timeout) and the per-crate Rust tests are running. No test assertions were relaxed. The Canvas membership fixture now persists across subscription refreshes and resets between tests. The first atomic commit fixes the plain Canvas E2E Unhide response check.

Progress on `job/hide-1153`, HEAD `105ba74ce`: merged origin/dev once. The production web build passed. Notes clippy passed: ``` Finished `dev` profile [unoptimized + debuginfo] target(s) in 31m 33s ``` `bun run check` reports `svelte-check found 0 errors and 1 warning in 1 file`; the warning is the existing empty AttachmentDeck focus ruleset. Full web tests (two workers, 30-second test timeout) and the per-crate Rust tests are running. No test assertions were relaxed. The Canvas membership fixture now persists across subscription refreshes and resets between tests. The first atomic commit fixes the plain Canvas E2E Unhide response check.
kayg commented 2026-10-06 12:59:02 +00:00
Author
Owner
Copy link

Web verification passed after the origin/dev merge. HEAD is 9abd6481e (backend crate gates are still running). Atomic commits: 105ba74ce fixes the E2E Unhide response check; 8a24c66bf fixes Canvas membership mock lifetime; 5955e0648 enables shared Calendar Hide actions and hidden Log previews; 9abd6481e refreshes generated exact pins. The final Calendar SQL optimization adds four further exact pins (refresh complete, pending commit with that slice).

bun run test --maxWorkers=2 --testTimeout=30000:

 Test Files  274 passed (274)
      Tests  1923 passed (1923)
   Start at  14:35:51
   Duration  1091.71s (transform 57%, tests 14%, import 13%, environment 13%, setup 3%)

No assertions were weakened. The 30-second CLI timeout permits the existing UI tests to run on this shared host; the default five-second limit previously timed out the Canvas and dense Agenda cases.

Web verification passed after the origin/dev merge. HEAD is `9abd6481e` (backend crate gates are still running). Atomic commits: `105ba74ce` fixes the E2E Unhide response check; `8a24c66bf` fixes Canvas membership mock lifetime; `5955e0648` enables shared Calendar Hide actions and hidden Log previews; `9abd6481e` refreshes generated exact pins. The final Calendar SQL optimization adds four further exact pins (refresh complete, pending commit with that slice). `bun run test --maxWorkers=2 --testTimeout=30000`: ``` Test Files 274 passed (274) Tests 1923 passed (1923) Start at 14:35:51 Duration 1091.71s (transform 57%, tests 14%, import 13%, environment 13%, setup 3%) ``` No assertions were weakened. The 30-second CLI timeout permits the existing UI tests to run on this shared host; the default five-second limit previously timed out the Canvas and dense Agenda cases.
kayg commented 2026-10-06 13:16:48 +00:00
Author
Owner
Copy link

Found one cross-view overlay gap while following shared Logs: calternal-search/src/indexer.rs resolves only note: and file: overlay keys, and query.rs matches only whole-file paths. A new private log: overlay would therefore leave its individual Search hit visible. Search Log anchors also omitted the owner qualifier.

The fix extends the existing resolver and exact-term visibility query. Log keys project an exact users/<owner>/<path>#^<block> result identity; they do not hide the Daily note or its sibling Logs. Shared Search links carry the same shared:<owner>:<block> ID used by Calendar. The resolver starts from the settings key set (maximum 4096) and joins indexed Note, File and Log identities, replacing the previous per-query Index scans. No User input is used to build filesystem paths.

Focused integration coverage checks the sibling, a one-hit is:hidden result and a source move. Production E2E coverage also checks shared Log Search. The bench profile now includes indexed block resolution. Its small SQLite validation reports:

PASS benchmark production SQL extraction and overlay fixture counts
PASS Search overlay fixture uses the indexed block lookup without a Home scan

This adds calternal-search to the crate gates. It closes the Hide consistency requirement of this issue; it introduces no new Search design.

Found one cross-view overlay gap while following shared Logs: `calternal-search/src/indexer.rs` resolves only `note:` and `file:` overlay keys, and `query.rs` matches only whole-file paths. A new private `log:` overlay would therefore leave its individual Search hit visible. Search Log anchors also omitted the owner qualifier. The fix extends the existing resolver and exact-term visibility query. Log keys project an exact `users/<owner>/<path>#^<block>` result identity; they do not hide the Daily note or its sibling Logs. Shared Search links carry the same `shared:<owner>:<block>` ID used by Calendar. The resolver starts from the settings key set (maximum 4096) and joins indexed Note, File and Log identities, replacing the previous per-query Index scans. No User input is used to build filesystem paths. Focused integration coverage checks the sibling, a one-hit `is:hidden` result and a source move. Production E2E coverage also checks shared Log Search. The bench profile now includes indexed block resolution. Its small SQLite validation reports: ``` PASS benchmark production SQL extraction and overlay fixture counts PASS Search overlay fixture uses the indexed block lookup without a Home scan ``` This adds `calternal-search` to the crate gates. It closes the Hide consistency requirement of this issue; it introduces no new Search design.
kayg commented 2026-10-06 14:28:44 +00:00
Author
Owner
Copy link

Gate finding: Calendar’s new shared-overlay regression passed. Sixteen existing write tests failed while the host disk had 24 GB free, below the 31,695,649,792-byte production reserve; representative error: FreeSpaceReserve { reserve: 31695649792, available: 24035876864 }. No assertions or reserve were changed. This job’s target/tmp now points to its own directory on /mnt/hdd (239 GB free), and the Calendar gates are being rerun there.

Legacy shared file Tasks without source IDs now resolve their retained Note identity through an indexed alias. Hide shares the Note key across Tasks, Files and Search, and the returned link remains stable without adopting an ID in owner bytes. A router regression covers both selectors, canonical response identity, private Hide/Unhide and exact source bytes.

Gate finding: Calendar’s new shared-overlay regression passed. Sixteen existing write tests failed while the host disk had 24 GB free, below the 31,695,649,792-byte production reserve; representative error: `FreeSpaceReserve { reserve: 31695649792, available: 24035876864 }`. No assertions or reserve were changed. This job’s `target/tmp` now points to its own directory on /mnt/hdd (239 GB free), and the Calendar gates are being rerun there. Legacy shared file Tasks without source IDs now resolve their retained Note identity through an indexed alias. Hide shares the Note key across Tasks, Files and Search, and the returned link remains stable without adopting an ID in owner bytes. A router regression covers both selectors, canonical response identity, private Hide/Unhide and exact source bytes.
kayg commented 2026-10-06 14:31:47 +00:00
Author
Owner
Copy link

Committed optimistic Calendar Hide and field-scoped rollback/Undo as 14fcd819a; exact live performance guard metadata is bbf9ff1af. Shared controls continue to use AgendaList, ItemPreview and their existing Menu/Tooltip/Undo primitives; no feature-local restyling was added.

Focused optimistic regressions:

Test Files  2 passed (2)
Tests  76 passed (76)

Current web check:

perf-lint: PASS; 0 violations; 22266 scoped exceptions
svelte-check found 0 errors and 1 warning in 1 file

The warning is the existing AttachmentDeck empty focus rule. Full web tests, remaining Rust gates and production screenshots are running/pending. No push.

Committed optimistic Calendar Hide and field-scoped rollback/Undo as `14fcd819a`; exact live performance guard metadata is `bbf9ff1af`. Shared controls continue to use AgendaList, ItemPreview and their existing Menu/Tooltip/Undo primitives; no feature-local restyling was added. Focused optimistic regressions: ```text Test Files 2 passed (2) Tests 76 passed (76) ``` Current web check: ```text perf-lint: PASS; 0 violations; 22266 scoped exceptions svelte-check found 0 errors and 1 warning in 1 file ``` The warning is the existing AttachmentDeck empty focus rule. Full web tests, remaining Rust gates and production screenshots are running/pending. No push.
kayg commented 2026-10-06 14:43:36 +00:00
Author
Owner
Copy link

Final web gates after the optimistic Hide changes passed:

perf-lint: PASS; 0 violations; 22266 scoped exceptions
svelte-check found 0 errors and 1 warning in 1 file

 Test Files  274 passed (274)
      Tests  1926 passed (1926)
   Start at  16:31:16
   Duration  625.92s (transform 31%, environment 24%, import 24%, tests 16%, setup 5%)

The production build also passed:

Compressed 905 static variants; saved 21178852 bytes.

The plain Canvas Files-open identity regression passed in the current Notes suite. Remaining Rust gates and real-server production screenshots are still in progress.

Final web gates after the optimistic Hide changes passed: ```text perf-lint: PASS; 0 violations; 22266 scoped exceptions svelte-check found 0 errors and 1 warning in 1 file Test Files 274 passed (274) Tests 1926 passed (1926) Start at 16:31:16 Duration 625.92s (transform 31%, environment 24%, import 24%, tests 16%, setup 5%) ``` The production build also passed: ```text Compressed 905 static variants; saved 21178852 bytes. ``` The plain Canvas Files-open identity regression passed in the current Notes suite. Remaining Rust gates and real-server production screenshots are still in progress.
kayg commented 2026-10-06 16:23:12 +00:00
Author
Owner
Copy link

hide4-1153 — NOT READY FOR MERGE. Stopped at the four-hour limit.

Head: cbf52277c6b03322a51fb6464043dd6ffedb2963 on job/hide-1153. Merged origin/dev once in ce9a79156. Nine atomic implementation/fix/generated-profile commits follow that merge. No push.

Built

  • Files open and Canvas Hide resolve the retained Note identity; plain .excalidraw bytes stay unchanged.
  • Read-only shared file Tasks and Log entries use private per-User overlays, qualified stable links, guarded Undo and current Share authorization.
  • Shared Calendar Hide updates mounted rows immediately, rolls back only visibility on refusal and uses shared keyboard/toast Undo. Shared content edits stay unavailable.
  • Fixed the unstable InfoPanel Canvas membership fixture without changing expectations.

Files (includes pending changes listed below)

  • crates/plugins/notes/src/{lib.rs,tasks_api.rs,tasks_store.rs}
  • crates/plugins/calendar/src/view.rs
  • crates/calternal-search/src/{indexer.rs,query.rs}, tests/indexer.rs
  • apps/web/src/lib/calendar/{data.ts,data.test.ts,edits.ts,edits.test.ts,agenda.svelte.test.ts}
  • apps/web/src/routes/calendar/[view]/[date]/+page.svelte
  • apps/web/src/lib/files/InfoPanel.svelte.test.ts
  • packages/ui/src/components/calendar/{AgendaList.svelte,ItemPreview.svelte}
  • apps/web/e2e/hide-1153.mjs, bench/hidden-1153.mjs
  • contracts/perf/{exceptions.json,adoption-1058.json,ratchet.json}

UX gaps closed
Private Hide/Unhide is available on read-only shared Tasks and Logs; hidden links open the real item; Hide is optimistic; Undo uses the common stack; default lists, counts and Search agree; source writes and invalid shared edits are refused. Visible controls reuse AgendaList and its Menu; ItemPreview reuses Pill, PillGroup, TagPill and its existing warm tooltip actions. Undo uses the route’s existing shared stack. No local restyling was added.

Decisions

  • File Tasks reuse the Note overlay identity because Files and Notes expose that identity. The uncommitted legacy extension uses the indexed Note ID without adopting IDs in owner bytes.
  • Shared Log block links qualify the block with its owner; the overlay remains scoped to one block, not its Daily note.
  • Hidden Log deep links read one bounded day with show_hidden=true without changing the User preference.
  • Optimistic Task visibility has field-specific write versions so it does not replace a newer owner status/title.

Expected cost
Hide writes one bounded settings document and one indexed overlay projection. Task identity uses an indexed lookup. Calendar visibility uses its indexed range plus one indexed overlay predicate per Log. Search resolves at most 4,096 overlay keys with indexed identity joins, then exact Tantivy terms before the result limit; it does not scan a Home. UI updates traverse only mounted Calendar rows. The bench profile adds 10,000-Log average and 100,000-Log/50-read burst fixtures; production SQL extraction and indexed-plan assertions passed. No performance measurement was run under the non-performance-job verification policy; baseline has no equivalent private Log metric.

For the merge round

  • flock /root/perf.lock ... CALTERNAL_PERF_LOCATION=perf-vm bun bench/hidden-1153.mjs --overlays: record load average inside the lock and p50/p95, CPU/RSS for average and worst cases against docs/perf/baseline.json.
  • Full combined e2e and tests/adversarial matrices, release/staging and real Mac interop remain the merge-round responsibility under the verification policy.

No push, deploy or issue close.

Completed gate output (verbatim)

Web check, full web tests and production build after the final UI change:

perf-lint: PASS; 0 violations; 22266 scoped exceptions
svelte-check found 0 errors and 1 warning in 1 file

 Test Files  274 passed (274)
      Tests  1926 passed (1926)
   Start at  16:31:16
   Duration  625.92s (transform 31%, environment 24%, import 24%, tests 16%, setup 5%)

Compressed 905 static variants; saved 21178852 bytes.

The warning is the unchanged AttachmentDeck empty focus rule. Commands were cd apps/web && bun run check, bun run test --maxWorkers=2 --testTimeout=30000, and bun run build.

Last fully completed Notes gates, before the pending legacy identity extension (the committed Canvas and shared Task/Log regressions passed here):

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 31m 33s
test result: ok. 308 passed; 0 failed; 4 ignored; 0 measured; 0 filtered out; finished in 436.79s
test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 2.56s
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

Notes clippy after the pending extension also passed:

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 39.83s

Server clippy passed:

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 9m 13s

cargo fmt --check completed with no output and exit 0 before the final fixture-title correction. git diff --check passed afterward. All Cargo commands used the required debug/incremental/jobs/TMPDIR settings and the preset target directory.

Known gaps and pending work

  • Eight files remain uncommitted: apps/web/e2e/hide-1153.mjs; Search indexer/query/integration tests; Calendar view; Notes lib/tasks_api/tasks_store. A copy is retained in artifacts/hide4-pending.patch. These changes are not claimed as validated or ready.
  • Calendar counts/details and exact-block Search overlay filtering are implemented in those pending files. The new Calendar shared-overlay regression passed, but Calendar’s full gate initially failed under the production free-space reserve:
test result: FAILED. 88 passed; 16 failed; 1 ignored; 0 measured; 0 filtered out; finished in 14.74s
FreeSpaceReserve { reserve: 31695649792, available: 24035876864 }

Temporary data was moved through this worktree’s target/tmp symlink to this job’s own /mnt/hdd directory; no reserve or assertions were changed. Calendar clippy’s initial BTreeSet/HashSet mismatch was corrected with the matching inferred empty set; its retry is incomplete.

  • The later Notes suite reported:
test tests::shared_task_and_log_hide_overlays_are_private_and_grant_bound ... FAILED
test tests::daily_log_projection_rebuild_resumes_without_markdown_writes ... FAILED

The new legacy fixture had no frontmatter title. Its title-less file Task was correctly omitted, leaving an inline child; shared inline Tasks are correctly refused. The new fixture now has title: Legacy Task, and its selector explicitly requests kind='file'. No existing expectation was changed. That final correction has not been rebuilt or verified.

  • The existing Daily Log rebuild failure remains unexplained. The suite did not finish and emit its failure diagnostics; seven_hundred_notes_reconcile_without_feedback remained running. Do not classify this as harmless or SLOW without a focused rerun. The subsequent complete Notes attempt was stopped at the job time limit.
  • Search per-crate clippy/tests, Calendar retry, complete Notes rerun and server tests are incomplete. Server test compilation was paused to prioritize touched crates and then stopped at the limit. No server binary was produced.
  • Production screenshot/E2E run did not start. No new screenshots were attached or judged. The pending focused runner covers delayed real writes, private Hide/Undo, Search, hidden links, source-byte preservation and revoked grants; it needs a real run in all 390/820/1440 light/dark macOS-emulated combinations.

UX gaps left
The pending Calendar/Search projections and production browser validation are required before this job can be called done. Independent Claude visual review follows the screenshot run.

Required continuation commands (not waived or shifted to the merge round)

export CARGO_PROFILE_DEV_DEBUG=line-tables-only CARGO_INCREMENTAL=0 CARGO_BUILD_JOBS=4 TMPDIR=$PWD/target/tmp
cargo fmt --check
cargo clippy -p calternal-plugin-notes --all-targets -- -D warnings
cargo test -p calternal-plugin-notes -- --test-threads=4
cargo clippy -p calternal-plugin-calendar --all-targets -- -D warnings
cargo test -p calternal-plugin-calendar -- --test-threads=4
cargo clippy -p calternal-search --all-targets -- -D warnings
cargo test -p calternal-search -- --test-threads=4
cargo test -p calternal-server -- --test-threads=4
cargo build -p calternal-server
CALTERNAL_SERVER_BIN="$CARGO_TARGET_DIR/debug/calternal-server" CALTERNAL_E2E_ASSET_OVERRIDE=1 TMPDIR="$PWD/target/tmp" node apps/web/e2e/hide-1153.mjs --overlays-only --screenshots artifacts/hide4-1153/screenshots

Run the specific unexplained Daily Log rebuild test first to capture its diagnostics, then complete the required suites once the cause is known. Commit the pending slices only after their gates pass; attach screenshots; post the new head and outputs. Web gates already passed after the final UI change; repeat only if code changes justify it.

For the merge round, exact additional commands include tests/adversarial/run.sh, cd apps/web && bun run test:e2e, and node apps/web/e2e/hide-1153.mjs without the focused flag. They must prove combined User isolation/authz/robustness, shared shell behavior and all item Hide flows. Release/staging and real Mac interop follow the orchestrator’s combined-branch gates.

Cleanup

     Removed 19492 files, 13.4GiB total

Cargo clean completed. Generated apps/web/build and .svelte-kit/output were deleted. Source changes, logs, the pending patch and prior ignored artifacts remain in the worktree.

hide4-1153 — NOT READY FOR MERGE. Stopped at the four-hour limit. Head: `cbf52277c6b03322a51fb6464043dd6ffedb2963` on `job/hide-1153`. Merged origin/dev once in `ce9a79156`. Nine atomic implementation/fix/generated-profile commits follow that merge. No push. Built - Files open and Canvas Hide resolve the retained Note identity; plain `.excalidraw` bytes stay unchanged. - Read-only shared file Tasks and Log entries use private per-User overlays, qualified stable links, guarded Undo and current Share authorization. - Shared Calendar Hide updates mounted rows immediately, rolls back only visibility on refusal and uses shared keyboard/toast Undo. Shared content edits stay unavailable. - Fixed the unstable InfoPanel Canvas membership fixture without changing expectations. Files (includes pending changes listed below) - crates/plugins/notes/src/{lib.rs,tasks_api.rs,tasks_store.rs} - crates/plugins/calendar/src/view.rs - crates/calternal-search/src/{indexer.rs,query.rs}, tests/indexer.rs - apps/web/src/lib/calendar/{data.ts,data.test.ts,edits.ts,edits.test.ts,agenda.svelte.test.ts} - apps/web/src/routes/calendar/[view]/[date]/+page.svelte - apps/web/src/lib/files/InfoPanel.svelte.test.ts - packages/ui/src/components/calendar/{AgendaList.svelte,ItemPreview.svelte} - apps/web/e2e/hide-1153.mjs, bench/hidden-1153.mjs - contracts/perf/{exceptions.json,adoption-1058.json,ratchet.json} UX gaps closed Private Hide/Unhide is available on read-only shared Tasks and Logs; hidden links open the real item; Hide is optimistic; Undo uses the common stack; default lists, counts and Search agree; source writes and invalid shared edits are refused. Visible controls reuse AgendaList and its Menu; ItemPreview reuses Pill, PillGroup, TagPill and its existing warm tooltip actions. Undo uses the route’s existing shared stack. No local restyling was added. Decisions - File Tasks reuse the Note overlay identity because Files and Notes expose that identity. The uncommitted legacy extension uses the indexed Note ID without adopting IDs in owner bytes. - Shared Log block links qualify the block with its owner; the overlay remains scoped to one block, not its Daily note. - Hidden Log deep links read one bounded day with show_hidden=true without changing the User preference. - Optimistic Task visibility has field-specific write versions so it does not replace a newer owner status/title. Expected cost Hide writes one bounded settings document and one indexed overlay projection. Task identity uses an indexed lookup. Calendar visibility uses its indexed range plus one indexed overlay predicate per Log. Search resolves at most 4,096 overlay keys with indexed identity joins, then exact Tantivy terms before the result limit; it does not scan a Home. UI updates traverse only mounted Calendar rows. The bench profile adds 10,000-Log average and 100,000-Log/50-read burst fixtures; production SQL extraction and indexed-plan assertions passed. No performance measurement was run under the non-performance-job verification policy; baseline has no equivalent private Log metric. For the merge round - `flock /root/perf.lock ... CALTERNAL_PERF_LOCATION=perf-vm bun bench/hidden-1153.mjs --overlays`: record load average inside the lock and p50/p95, CPU/RSS for average and worst cases against docs/perf/baseline.json. - Full combined e2e and tests/adversarial matrices, release/staging and real Mac interop remain the merge-round responsibility under the verification policy. No push, deploy or issue close. Completed gate output (verbatim) Web check, full web tests and production build after the final UI change: ```text perf-lint: PASS; 0 violations; 22266 scoped exceptions svelte-check found 0 errors and 1 warning in 1 file Test Files 274 passed (274) Tests 1926 passed (1926) Start at 16:31:16 Duration 625.92s (transform 31%, environment 24%, import 24%, tests 16%, setup 5%) Compressed 905 static variants; saved 21178852 bytes. ``` The warning is the unchanged AttachmentDeck empty focus rule. Commands were `cd apps/web && bun run check`, `bun run test --maxWorkers=2 --testTimeout=30000`, and `bun run build`. Last fully completed Notes gates, before the pending legacy identity extension (the committed Canvas and shared Task/Log regressions passed here): ```text Finished `dev` profile [unoptimized + debuginfo] target(s) in 31m 33s test result: ok. 308 passed; 0 failed; 4 ignored; 0 measured; 0 filtered out; finished in 436.79s test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 2.56s test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s ``` Notes clippy after the pending extension also passed: ```text Finished `dev` profile [unoptimized + debuginfo] target(s) in 39.83s ``` Server clippy passed: ```text Finished `dev` profile [unoptimized + debuginfo] target(s) in 9m 13s ``` `cargo fmt --check` completed with no output and exit 0 before the final fixture-title correction. `git diff --check` passed afterward. All Cargo commands used the required debug/incremental/jobs/TMPDIR settings and the preset target directory. Known gaps and pending work - Eight files remain uncommitted: `apps/web/e2e/hide-1153.mjs`; Search indexer/query/integration tests; Calendar view; Notes lib/tasks_api/tasks_store. A copy is retained in `artifacts/hide4-pending.patch`. These changes are not claimed as validated or ready. - Calendar counts/details and exact-block Search overlay filtering are implemented in those pending files. The new Calendar shared-overlay regression passed, but Calendar’s full gate initially failed under the production free-space reserve: ```text test result: FAILED. 88 passed; 16 failed; 1 ignored; 0 measured; 0 filtered out; finished in 14.74s FreeSpaceReserve { reserve: 31695649792, available: 24035876864 } ``` Temporary data was moved through this worktree’s `target/tmp` symlink to this job’s own /mnt/hdd directory; no reserve or assertions were changed. Calendar clippy’s initial BTreeSet/HashSet mismatch was corrected with the matching inferred empty set; its retry is incomplete. - The later Notes suite reported: ```text test tests::shared_task_and_log_hide_overlays_are_private_and_grant_bound ... FAILED test tests::daily_log_projection_rebuild_resumes_without_markdown_writes ... FAILED ``` The new legacy fixture had no frontmatter title. Its title-less file Task was correctly omitted, leaving an inline child; shared inline Tasks are correctly refused. The new fixture now has `title: Legacy Task`, and its selector explicitly requests `kind='file'`. No existing expectation was changed. That final correction has not been rebuilt or verified. - The existing Daily Log rebuild failure remains unexplained. The suite did not finish and emit its failure diagnostics; `seven_hundred_notes_reconcile_without_feedback` remained running. Do not classify this as harmless or SLOW without a focused rerun. The subsequent complete Notes attempt was stopped at the job time limit. - Search per-crate clippy/tests, Calendar retry, complete Notes rerun and server tests are incomplete. Server test compilation was paused to prioritize touched crates and then stopped at the limit. No server binary was produced. - Production screenshot/E2E run did not start. No new screenshots were attached or judged. The pending focused runner covers delayed real writes, private Hide/Undo, Search, hidden links, source-byte preservation and revoked grants; it needs a real run in all 390/820/1440 light/dark macOS-emulated combinations. UX gaps left The pending Calendar/Search projections and production browser validation are required before this job can be called done. Independent Claude visual review follows the screenshot run. Required continuation commands (not waived or shifted to the merge round) ```sh export CARGO_PROFILE_DEV_DEBUG=line-tables-only CARGO_INCREMENTAL=0 CARGO_BUILD_JOBS=4 TMPDIR=$PWD/target/tmp cargo fmt --check cargo clippy -p calternal-plugin-notes --all-targets -- -D warnings cargo test -p calternal-plugin-notes -- --test-threads=4 cargo clippy -p calternal-plugin-calendar --all-targets -- -D warnings cargo test -p calternal-plugin-calendar -- --test-threads=4 cargo clippy -p calternal-search --all-targets -- -D warnings cargo test -p calternal-search -- --test-threads=4 cargo test -p calternal-server -- --test-threads=4 cargo build -p calternal-server CALTERNAL_SERVER_BIN="$CARGO_TARGET_DIR/debug/calternal-server" CALTERNAL_E2E_ASSET_OVERRIDE=1 TMPDIR="$PWD/target/tmp" node apps/web/e2e/hide-1153.mjs --overlays-only --screenshots artifacts/hide4-1153/screenshots ``` Run the specific unexplained Daily Log rebuild test first to capture its diagnostics, then complete the required suites once the cause is known. Commit the pending slices only after their gates pass; attach screenshots; post the new head and outputs. Web gates already passed after the final UI change; repeat only if code changes justify it. For the merge round, exact additional commands include `tests/adversarial/run.sh`, `cd apps/web && bun run test:e2e`, and `node apps/web/e2e/hide-1153.mjs` without the focused flag. They must prove combined User isolation/authz/robustness, shared shell behavior and all item Hide flows. Release/staging and real Mac interop follow the orchestrator’s combined-branch gates. Cleanup ```text Removed 19492 files, 13.4GiB total ``` Cargo clean completed. Generated `apps/web/build` and `.svelte-kit/output` were deleted. Source changes, logs, the pending patch and prior ignored artifacts remain in the worktree.
kayg commented 2026-10-06 16:28:40 +00:00
Author
Owner
Copy link

hide5-1153 starts on job/hide-1153, base cbf52277c6. Preserved the eight pending files in artifacts/hide5-pending.patch and a Git stash. Merging origin/dev before verification; resolving generated contracts and combined migration pins. Daily Log failure will be rerun without weakening its assertions. No push. Time box: 150 minutes.

hide5-1153 starts on job/hide-1153, base cbf52277c6b03322a51fb6464043dd6ffedb2963. Preserved the eight pending files in artifacts/hide5-pending.patch and a Git stash. Merging origin/dev before verification; resolving generated contracts and combined migration pins. Daily Log failure will be rerun without weakening its assertions. No push. Time box: 150 minutes.
kayg commented 2026-10-06 16:35:41 +00:00
Author
Owner
Copy link

Merged origin/dev ff53d7b8b into job/hide-1153 in 76a67ccb7, then restored all eight pending files. Combined migration pins retain Notes 36/37 plus Auth 16, Files 28 and Notifications 8; no deployed migration bytes changed. The first web check had 0 Svelte errors and one AttachmentDeck warning, but failed on merged performance pins. The combined ledgers held 26,150 entries, including stale duplicates. Refreshing only existing live syntax identities and exact call bindings, retaining limits; no rule weakening or blanket adoption. Production web build passed: Compressed 917 static variants; saved 21429817 bytes. Rust compilation and full web tests are running.

Merged origin/dev ff53d7b8b into job/hide-1153 in 76a67ccb7, then restored all eight pending files. Combined migration pins retain Notes 36/37 plus Auth 16, Files 28 and Notifications 8; no deployed migration bytes changed. The first web check had 0 Svelte errors and one AttachmentDeck warning, but failed on merged performance pins. The combined ledgers held 26,150 entries, including stale duplicates. Refreshing only existing live syntax identities and exact call bindings, retaining limits; no rule weakening or blanket adoption. Production web build passed: `Compressed 917 static variants; saved 21429817 bytes.` Rust compilation and full web tests are running.
kayg commented 2026-10-06 17:17:07 +00:00
Author
Owner
Copy link

Production evidence: delayed real shared Task Hide removes the row optimistically, but PATCH /api/v1/notes/tasks/properties returns 404 {"error":{"code":"not_found","message":"Task not found"}}. Root cause: wire::authorize_task_reads attaches live Share roots only to GET Task reads, while the private overlay writer calls the same authorized lookup. The same omission affects shared Log entry reads/visibility writes. Extend that existing guard only to typed Task properties PATCH and exact Log entry GET/PATCH; handler guards still deny shared content changes, and grants are checked on each request. Existing guard assertions remain; add positive visibility and negative attachment-route cases. Also found Search HTTP postprocessing overwrote exact shared Log overlay flags; added block/sibling/viewer isolation regression without widening visibility.

Daily Log: unchanged 650-Note rebuild regression passes. New focused regression records the single-attempt SQLITE_BUSY failure ("Index is busy; retry shortly") under a held authority writer, then verifies the bounded retry imported from origin/dev completes and preserves source bytes. Full Notes suite is still running; its reported failures will be diagnosed before final reporting.

Production evidence: delayed real shared Task Hide removes the row optimistically, but PATCH /api/v1/notes/tasks/properties returns 404 {"error":{"code":"not_found","message":"Task not found"}}. Root cause: wire::authorize_task_reads attaches live Share roots only to GET Task reads, while the private overlay writer calls the same authorized lookup. The same omission affects shared Log entry reads/visibility writes. Extend that existing guard only to typed Task properties PATCH and exact Log entry GET/PATCH; handler guards still deny shared content changes, and grants are checked on each request. Existing guard assertions remain; add positive visibility and negative attachment-route cases. Also found Search HTTP postprocessing overwrote exact shared Log overlay flags; added block/sibling/viewer isolation regression without widening visibility. Daily Log: unchanged 650-Note rebuild regression passes. New focused regression records the single-attempt SQLITE_BUSY failure ("Index is busy; retry shortly") under a held authority writer, then verifies the bounded retry imported from origin/dev completes and preserves source bytes. Full Notes suite is still running; its reported failures will be diagnosed before final reporting.
kayg commented 2026-10-06 17:31:45 +00:00
Author
Owner
Copy link

The full Notes suite finished on the inherited HDD temp symlink: 306 passed, 5 failed, 4 ignored, 2079.87s. All five failures are Sqlx(PoolTimedOut) at fixture database connect, before API/assertion logic: four at notes/lib.rs:9430 and the property test at reminders_tests.rs:22. Both Daily Log tests pass in the same suite. The worktree has 46 GB local free space. After Notes closed its fixtures, replaced only target/tmp symlink with a local worktree directory (old link retained at target/tmp-hdd-hide5). Paused the crate sequence while one full Notes replay runs with unchanged assertions and the generated proptest seed retained. No timing budget or production rule changed.

New server regressions: Search boundary 2 passed/0 failed; live typed Share authority 1 passed/0 failed. Server test compilation now passes after adapting the preserved Search fixture to the merged StartupProgress type. Web check again passes with 0 errors and the existing AttachmentDeck empty-CSS warning; perf-lint passes with 22550 exact scoped exceptions. No rules or limits weakened.

The full Notes suite finished on the inherited HDD temp symlink: 306 passed, 5 failed, 4 ignored, 2079.87s. All five failures are Sqlx(PoolTimedOut) at fixture database connect, before API/assertion logic: four at notes/lib.rs:9430 and the property test at reminders_tests.rs:22. Both Daily Log tests pass in the same suite. The worktree has 46 GB local free space. After Notes closed its fixtures, replaced only target/tmp symlink with a local worktree directory (old link retained at target/tmp-hdd-hide5). Paused the crate sequence while one full Notes replay runs with unchanged assertions and the generated proptest seed retained. No timing budget or production rule changed. New server regressions: Search boundary 2 passed/0 failed; live typed Share authority 1 passed/0 failed. Server test compilation now passes after adapting the preserved Search fixture to the merged StartupProgress type. Web check again passes with 0 errors and the existing AttachmentDeck empty-CSS warning; perf-lint passes with 22550 exact scoped exceptions. No rules or limits weakened.
kayg commented 2026-10-06 17:45:05 +00:00
Author
Owner
Copy link

Full Notes replay with unchanged assertions and timeouts passes on local worktree fixtures: 311 unit tests passed, 0 failed, 4 ignored in 484.46s; 2 Apple replay tests passed, 0 failed in 2.60s. Both the original 650-Note rebuild and the new held-writer BUSY/recovery regression pass. All five HDD failures were fixture Sqlx(PoolTimedOut), before assertions. The auto-generated proptest seed also passed in the replay and is retained in artifacts/hide5-1153/pool-timeout-proptest-seed.txt; it is not a production regression fixture. Calendar clippy completed successfully; the paused driver subsequently exited 143, so the remaining driver resumes at Calendar tests and does not repeat completed gates.

Full Notes replay with unchanged assertions and timeouts passes on local worktree fixtures: 311 unit tests passed, 0 failed, 4 ignored in 484.46s; 2 Apple replay tests passed, 0 failed in 2.60s. Both the original 650-Note rebuild and the new held-writer BUSY/recovery regression pass. All five HDD failures were fixture Sqlx(PoolTimedOut), before assertions. The auto-generated proptest seed also passed in the replay and is retained in artifacts/hide5-1153/pool-timeout-proptest-seed.txt; it is not a production regression fixture. Calendar clippy completed successfully; the paused driver subsequently exited 143, so the remaining driver resumes at Calendar tests and does not repeat completed gates.
kayg commented 2026-10-06 18:02:35 +00:00
Author
Owner
Copy link

Production screenshot flows pass for Tasks, Calendar, Files, folders, Photos and Tag pages, at 390/820/1440 in light/dark with macOS platform emulation. Note and Search states are also captured. Shared Task/Log flows passed earlier; the complete Shared Note/plain Canvas pass is running with isolated Show hidden preferences.

One remaining product gap is filed as #1212: kayg/calternal#1212. A real-server cold-link probe reports:

{"defaultHiddenFileLinkOpens":false,"hiddenFileBadgeCount":0,"visibleUnhideActionCount":0,"apiHidden":true}

Files/folder screenshots cannot honestly prove a Hidden badge where the product does not provide it. The hide5 brief permits preserved projection work, Daily Log recovery, gates and screenshots, with no new UI scope. No product UI files were changed in this run. Keep this gap visible in the merge decision; the screenshot archive includes its evidence.

Build environment: the preset Cargo target directory was physically on the root filesystem. It reached 31 GB free, near the ordinary 5% reserve. Interrupted compilation before the next tests, moved only this job's cache to /mnt/hdd/targets/jobs/hide5-1153-transferred-20261006, and left CARGO_TARGET_DIR unchanged through a symlink. Root free space is now 66 GB. Resume at Calendar tests, retaining completed Notes and Calendar clippy logs. No quota, assertion, timeout, performance rule or ratchet limit was relaxed.

Current committed head: 1d187f8c0. Server boundary fixes are in separate commits ce0630151 and 1d187f8c0; their focused regressions pass. Final per-crate gates remain in progress.

Production screenshot flows pass for Tasks, Calendar, Files, folders, Photos and Tag pages, at 390/820/1440 in light/dark with macOS platform emulation. Note and Search states are also captured. Shared Task/Log flows passed earlier; the complete Shared Note/plain Canvas pass is running with isolated Show hidden preferences. One remaining product gap is filed as #1212: https://git.kayg.org/kayg/calternal/issues/1212. A real-server cold-link probe reports: ```json {"defaultHiddenFileLinkOpens":false,"hiddenFileBadgeCount":0,"visibleUnhideActionCount":0,"apiHidden":true} ``` Files/folder screenshots cannot honestly prove a Hidden badge where the product does not provide it. The hide5 brief permits preserved projection work, Daily Log recovery, gates and screenshots, with no new UI scope. No product UI files were changed in this run. Keep this gap visible in the merge decision; the screenshot archive includes its evidence. Build environment: the preset Cargo target directory was physically on the root filesystem. It reached 31 GB free, near the ordinary 5% reserve. Interrupted compilation before the next tests, moved only this job's cache to /mnt/hdd/targets/jobs/hide5-1153-transferred-20261006, and left CARGO_TARGET_DIR unchanged through a symlink. Root free space is now 66 GB. Resume at Calendar tests, retaining completed Notes and Calendar clippy logs. No quota, assertion, timeout, performance rule or ratchet limit was relaxed. Current committed head: 1d187f8c0. Server boundary fixes are in separate commits ce0630151 and 1d187f8c0; their focused regressions pass. Final per-crate gates remain in progress.
kayg commented 2026-10-06 18:36:47 +00:00
Author
Owner
Copy link

Head ee8e9aea0. The preserved Search projection changes are committed. The focused regression recipient_log_overlay_filters_only_its_block passes: one private Log overlay hides only that block before limits, keeps its sibling visible, retains qualified shared links after a source move, and leaves source bytes exact. The fixture needed an indexed row for its granted folder, and its move UPDATE must target the day-file row only; otherwise it incorrectly moved the grant folder. All original assertions remain.

Files full gate ended test result: FAILED. 259 passed; 1 failed; 4 ignored; 0 measured; 0 filtered out; finished in 479.67s: the existing reconcile-storm test double-polls a JoinHandle on cleanup. Filed kayg/calternal#1213 with source evidence. This gate is not passing. Photos and Tags clippy pass. Server clippy and the remaining full crate tests continue within the 150-minute box.

Head ee8e9aea0. The preserved Search projection changes are committed. The focused regression `recipient_log_overlay_filters_only_its_block` passes: one private Log overlay hides only that block before limits, keeps its sibling visible, retains qualified shared links after a source move, and leaves source bytes exact. The fixture needed an indexed row for its granted folder, and its move UPDATE must target the day-file row only; otherwise it incorrectly moved the grant folder. All original assertions remain. Files full gate ended `test result: FAILED. 259 passed; 1 failed; 4 ignored; 0 measured; 0 filtered out; finished in 479.67s`: the existing reconcile-storm test double-polls a JoinHandle on cleanup. Filed https://git.kayg.org/kayg/calternal/issues/1213 with source evidence. This gate is not passing. Photos and Tags clippy pass. Server clippy and the remaining full crate tests continue within the 150-minute box.
kayg commented 2026-10-06 18:54:50 +00:00
Author
Owner
Copy link

hide5-1153 final report. Head e702556534. No push, deploy or merge after the initial origin/dev merge.

Built: preserved and committed the legacy Shared Task extension; Calendar uses the same private Log overlay for counts and details; Search filters exact Log block overlays before limits and keeps owner-qualified links. The server rechecks live Share roots for visibility-only Task/Log writes and final Search results. Shared content edits remain denied. Generated API contracts and exact live performance pins were refreshed after merging origin/dev once.

Daily Log: the original prior-run failure was not retained, so its precise cause cannot be proved retrospectively. A held SQLite writer reproduces BUSY on the single-attempt witness. The real rebuild succeeds after release through origin/dev's fresh-transaction retry fix (#1157), preserving source bytes, Log/title values and the rebuild cursor. New regression assertions are unchanged. Full Notes tests pass on local SSD. Earlier HDD fixture initialization produced SQLx PoolTimedOut before assertions; its log is retained.

UX gaps closed: shared Task/Log visibility PATCH was rejected at the HTTP boundary despite valid live Shares; the scope guard now supplies live roots and still denies source edits, revoked grants and stale revisions. Exact shared Log Search overlays keep sibling Logs visible and agree with Calendar. Legacy non-.md Task sources resolve through indexed Note identity.

UX gaps left: #1212, kayg/calternal#1212 — a cold hidden File deep link does not open with Show hidden off; File/folder headers lack Hidden/Unhide. This job's restricted projection/test scope did not change that UI. Do not treat its screenshot as a completed deep-link badge.

Decisions: extend the existing Share-root guard and Search predicates; no new UI design. Use indexed identities for legacy source extensions. Fix only the new Search fixture's missing grant-folder row and its overly broad source-move UPDATE; preserve all assertions. SSD fixture storage avoids HDD initialization timeouts without changing production limits.

Expected cost: legacy Task resolution uses a bounded indexed lookup chain. Calendar applies indexed overlays to bounded date queries. Search resolves at most 4096 overlay keys with indexed identity joins, then exact Tantivy terms before limits; final HTTP projection does constant string/set work per returned hit. No per-request Home scan or extra network work. No benchmark run: the latest verification policy reserves performance measurements for performance jobs. Existing bench/hidden-1153.mjs --overlays covers 10k average and 100k/50-burst cases.

Evidence: 266 original production PNGs plus two cold File-link proofs. Actual CSS pixels at 390, 820 and 1440, both light and dark, with macOS emulation. Focused item, Tag and shared-overlay browser runs pass. Claude/orchestrator owns visual review.

Screenshot archive attachments:

For the merge round: run the full default node apps/web/e2e/hide-1153.mjs with the production web build and CALTERNAL_SERVER_BIN, then the full tests/adversarial/run.sh matrices. Confirm cross-User isolation, live grants, source preservation and projection agreement. Review the attached production screenshots and resolve #1212 before calling every requested deep-link badge complete.

Shared UI reuse: this finishing pass adds no visual control or local primitive styling. Screens use the existing ItemActionMenu (Menu, Pill and shared tooltip), TaskCard (Card, Checkbox, StatusPill, TagPill), Tag Card/CopyLink, shared Calendar components, and the existing File/Photo preview surfaces.

Files for this finishing pass: crates/plugins/notes/src/{lib.rs,tasks_api.rs,tasks_store.rs}; crates/plugins/calendar/src/view.rs; crates/calternal-search/src/{indexer.rs,query.rs} and tests/indexer.rs; crates/calternal-server/src/{main.rs,wire.rs,upgrade_tests.rs}; apps/web/e2e/hide-1153.mjs; generated contracts/actions.json, contracts/openapi.json, packages/api-client/src/generated.ts; contracts/perf/{exceptions.json,registry.json,adoption-1058.json,ratchet.json}. Full issue file inventory is attached as owned-files.txt. Screenshots were not committed.

Known gate gap: #1213 kayg/calternal#1213 — the unchanged Files reconcile-storm test double-polls the watcher JoinHandle during failed-completion cleanup. Full Files test is FAILED, not waived.

Gate output, verbatim excerpts (full logs attached):

cargo fmt --check (fmt-check-final.log)

No completion output recorded; see final status below.

cargo clippy -p calternal-plugin-notes --all-targets -- -D warnings (notes-final-clippy.log)

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 40.29s

cargo test -p calternal-plugin-notes -- --test-threads=4 (calternal-plugin-notes-test-local.log)

    Finished `test` profile [unoptimized + debuginfo] target(s) in 3m 51s
test result: ok. 311 passed; 0 failed; 4 ignored; 0 measured; 0 filtered out; finished in 484.46s
test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 2.60s
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

cargo clippy -p calternal-plugin-calendar --all-targets -- -D warnings (calternal-plugin-calendar-clippy.log)

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 3m 11s

cargo test -p calternal-plugin-calendar -- --test-threads=4 (calternal-plugin-calendar-test.log)

    Finished `test` profile [unoptimized + debuginfo] target(s) in 4m 07s
test result: ok. 104 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 17.50s
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.21s
test result: ok. 3 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.08s
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

cargo clippy -p calternal-search --all-targets -- -D warnings (calternal-search-clippy.log)

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 34s

cargo test -p calternal-search -- --test-threads=4 (calternal-search-test-final.log)

    Finished `test` profile [unoptimized + debuginfo] target(s) in 9m 41s
test result: ok. 59 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 86.88s
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 8.48s
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 2.60s

cargo clippy -p calternal-plugin-files --all-targets -- -D warnings (calternal-plugin-files-clippy.log)

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 38s

cargo test -p calternal-plugin-files -- --test-threads=4 (calternal-plugin-files-test.log)

    Finished `test` profile [unoptimized + debuginfo] target(s) in 10m 24s
test result: FAILED. 259 passed; 1 failed; 4 ignored; 0 measured; 0 filtered out; finished in 479.67s
error: test failed, to rerun pass `-p calternal-plugin-files --lib`

cargo clippy -p calternal-plugin-photos --all-targets -- -D warnings (calternal-plugin-photos-clippy.log)

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 41s

cargo test -p calternal-plugin-photos -- --test-threads=4 (calternal-plugin-photos-test-final.log)

No completion output recorded; see final status below.

cargo clippy -p calternal-tags --all-targets -- -D warnings (calternal-tags-clippy.log)

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 53.85s

cargo test -p calternal-tags -- --test-threads=4 (calternal-tags-test-final.log)

No completion output recorded; see final status below.

cargo clippy -p calternal-server --all-targets -- -D warnings (calternal-server-clippy.log)

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 9m 09s

cargo test -p calternal-server -- --test-threads=4 (calternal-server-test-final.log)

No completion output recorded; see final status below.

cd apps/web && bun run check (web-check-final.log)

perf-lint: PASS; 0 violations; 22550 scoped exceptions
svelte-check found 0 errors and 1 warning in 1 file

cd apps/web && bun run test --maxWorkers=2 --testTimeout=30000 (web-test.log)

 Test Files  282 passed (282)
      Tests  1997 passed (1997)

Daily Log writer-contention regression (daily-contention.log)

    Finished `test` profile [unoptimized + debuginfo] target(s) in 11m 15s
Daily Log single-attempt witness: Index is busy; retry shortly
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 314 filtered out; finished in 2.09s
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 2 filtered out; finished in 0.00s

exact private Log Search regression (search-overlay-final.log)

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 27 filtered out; finished in 4.96s

Final status: NOT READY FOR MERGE. The 150-minute time box ended with the Files full test FAILED (#1213), and full Search, Photos, Tags and Server tests incomplete. The corrected Search overlay integration passes in the full rerun, and Search unit/Ask/client contracts pass; the overflow-recovery integration had not completed. Photos test compilation was interrupted; Tags and Server full tests had not started. No existing assertion was weakened. Own gate groups were terminated and cleanup was requested.

Remaining job gates (not claimed as passed): cargo test -p calternal-search -- --test-threads=4; cargo test -p calternal-plugin-photos -- --test-threads=4; cargo test -p calternal-tags -- --test-threads=4; cargo test -p calternal-server -- --test-threads=4. Fix #1213 without weakening the storm checks, then run cargo test -p calternal-plugin-files -- --test-threads=4.

Formatter exit status: 0 (no output). Production web build passed. Full web check/test and all seven clippy gates passed; the comment-only final commit does not change runtime behavior. #1153 is left open.

Full gate logs, file inventory and screenshot manifest: hide5-gate-evidence.zip.

hide5-1153 final report. Head e702556534d9f1c2ed0c243a2465566d80a86b55. No push, deploy or merge after the initial origin/dev merge. Built: preserved and committed the legacy Shared Task extension; Calendar uses the same private Log overlay for counts and details; Search filters exact Log block overlays before limits and keeps owner-qualified links. The server rechecks live Share roots for visibility-only Task/Log writes and final Search results. Shared content edits remain denied. Generated API contracts and exact live performance pins were refreshed after merging origin/dev once. Daily Log: the original prior-run failure was not retained, so its precise cause cannot be proved retrospectively. A held SQLite writer reproduces BUSY on the single-attempt witness. The real rebuild succeeds after release through origin/dev's fresh-transaction retry fix (#1157), preserving source bytes, Log/title values and the rebuild cursor. New regression assertions are unchanged. Full Notes tests pass on local SSD. Earlier HDD fixture initialization produced SQLx PoolTimedOut before assertions; its log is retained. UX gaps closed: shared Task/Log visibility PATCH was rejected at the HTTP boundary despite valid live Shares; the scope guard now supplies live roots and still denies source edits, revoked grants and stale revisions. Exact shared Log Search overlays keep sibling Logs visible and agree with Calendar. Legacy non-.md Task sources resolve through indexed Note identity. UX gaps left: #1212, https://git.kayg.org/kayg/calternal/issues/1212 — a cold hidden File deep link does not open with Show hidden off; File/folder headers lack Hidden/Unhide. This job's restricted projection/test scope did not change that UI. Do not treat its screenshot as a completed deep-link badge. Decisions: extend the existing Share-root guard and Search predicates; no new UI design. Use indexed identities for legacy source extensions. Fix only the new Search fixture's missing grant-folder row and its overly broad source-move UPDATE; preserve all assertions. SSD fixture storage avoids HDD initialization timeouts without changing production limits. Expected cost: legacy Task resolution uses a bounded indexed lookup chain. Calendar applies indexed overlays to bounded date queries. Search resolves at most 4096 overlay keys with indexed identity joins, then exact Tantivy terms before limits; final HTTP projection does constant string/set work per returned hit. No per-request Home scan or extra network work. No benchmark run: the latest verification policy reserves performance measurements for performance jobs. Existing bench/hidden-1153.mjs --overlays covers 10k average and 100k/50-burst cases. Evidence: 266 original production PNGs plus two cold File-link proofs. Actual CSS pixels at 390, 820 and 1440, both light and dark, with macOS emulation. Focused item, Tag and shared-overlay browser runs pass. Claude/orchestrator owns visual review. Screenshot archive attachments: - [hide5-calendar-part1.zip](https://git.kayg.org/attachments/78eb7370-7d84-4d51-81a9-b917c18bcd59) - [hide5-calendar-part2.zip](https://git.kayg.org/attachments/a3c2e591-94a0-4deb-9ce3-d1f1416e1a28) - [hide5-calendar-part3.zip](https://git.kayg.org/attachments/56d70b03-e3d3-4bac-baec-49a305f6e81d) - [hide5-calendar-part4.zip](https://git.kayg.org/attachments/9dd541aa-cfe2-46e0-a101-ec349cedfd7e) - [hide5-files-part1.zip](https://git.kayg.org/attachments/2e9d5137-cca4-43e3-96f3-2c7fb80b7a80) - [hide5-files-part2.zip](https://git.kayg.org/attachments/b8aae69d-cc4b-4271-9f11-3b1a46c71421) - [hide5-files-part3.zip](https://git.kayg.org/attachments/2f951d81-8d92-4182-b2d6-3ba0e26001f2) - [hide5-folders-part1.zip](https://git.kayg.org/attachments/849e97a3-2a98-4461-a9a7-f64ce440a516) - [hide5-folders-part2.zip](https://git.kayg.org/attachments/41d178ca-e2b9-435e-9e1b-6a0fa40ac565) - [hide5-folders-part3.zip](https://git.kayg.org/attachments/6158769d-827c-450e-8158-32791f033347) - [hide5-folders-part4.zip](https://git.kayg.org/attachments/8276130c-0423-4740-8307-ad919a121cf0) - [hide5-known-gap-part1.zip](https://git.kayg.org/attachments/7f75620f-ac86-420b-9d5a-26e45f4f2bcb) - [hide5-note-part1.zip](https://git.kayg.org/attachments/30128307-f6f6-41a5-9a4c-a9b171af94cb) - [hide5-notes-part1.zip](https://git.kayg.org/attachments/008d6330-b57f-4550-a76f-d68734b24b9b) - [hide5-notes-part2.zip](https://git.kayg.org/attachments/ffc7eca2-54c0-49e4-bd6c-523093725851) - [hide5-photo-part1.zip](https://git.kayg.org/attachments/41040a78-4cdc-4101-ae29-9fbc556a6927) - [hide5-photos-part1.zip](https://git.kayg.org/attachments/9656beef-1893-4067-a832-a944c04c1a14) - [hide5-photos-part2.zip](https://git.kayg.org/attachments/d375faf8-6be0-431f-b52c-4fc61db7db44) - [hide5-photos-part3.zip](https://git.kayg.org/attachments/ec2754b3-327d-47a4-8c6a-7af5493528a0) - [hide5-plain-part1.zip](https://git.kayg.org/attachments/f1710c41-1305-49eb-838c-1dd071faa892) - [hide5-search-part1.zip](https://git.kayg.org/attachments/91200807-ca0e-480a-9a29-088b818e8847) - [hide5-shared-part1.zip](https://git.kayg.org/attachments/9ebf82fb-43cf-41c3-8fc9-cb737b26a984) - [hide5-shared-part2.zip](https://git.kayg.org/attachments/77416d35-f61b-47f6-8254-51a71480ae39) - [hide5-shared-part3.zip](https://git.kayg.org/attachments/b5eaa2c0-18d7-4f27-a8a6-040767e72a05) - [hide5-shared-part4.zip](https://git.kayg.org/attachments/69fc7781-ef60-46c4-bd67-275cb2931d59) - [hide5-shared-part5.zip](https://git.kayg.org/attachments/9e2d1323-3d00-4db5-8d02-019735e14c3f) - [hide5-tag-part1.zip](https://git.kayg.org/attachments/32045ca3-91df-4df7-b3d7-60e8244e2347) - [hide5-tag-part2.zip](https://git.kayg.org/attachments/0d5ae8ed-468f-40f5-b35a-231ce3a6a2d2) - [hide5-tag-part3.zip](https://git.kayg.org/attachments/ba31f0a0-2282-4407-9c1c-32d5bda8af63) - [hide5-tag-part4.zip](https://git.kayg.org/attachments/e6b95254-6735-4133-b4e0-c7713a3bfafe) - [hide5-tasks-part1.zip](https://git.kayg.org/attachments/69cee812-a682-4e27-8110-26436cdda5d5) - [hide5-tasks-part2.zip](https://git.kayg.org/attachments/465a51c0-d652-4b03-8960-2877a7821cf1) - [hide5-tasks-part3.zip](https://git.kayg.org/attachments/2ce1a8aa-bd40-4c6c-af7e-4fe09d603c77) - [hide5-tasks-part4.zip](https://git.kayg.org/attachments/a36c5b3d-a590-472d-8b3c-2d752c5094ff) For the merge round: run the full default `node apps/web/e2e/hide-1153.mjs` with the production web build and CALTERNAL_SERVER_BIN, then the full `tests/adversarial/run.sh` matrices. Confirm cross-User isolation, live grants, source preservation and projection agreement. Review the attached production screenshots and resolve #1212 before calling every requested deep-link badge complete. Shared UI reuse: this finishing pass adds no visual control or local primitive styling. Screens use the existing ItemActionMenu (Menu, Pill and shared tooltip), TaskCard (Card, Checkbox, StatusPill, TagPill), Tag Card/CopyLink, shared Calendar components, and the existing File/Photo preview surfaces. Files for this finishing pass: crates/plugins/notes/src/{lib.rs,tasks_api.rs,tasks_store.rs}; crates/plugins/calendar/src/view.rs; crates/calternal-search/src/{indexer.rs,query.rs} and tests/indexer.rs; crates/calternal-server/src/{main.rs,wire.rs,upgrade_tests.rs}; apps/web/e2e/hide-1153.mjs; generated contracts/actions.json, contracts/openapi.json, packages/api-client/src/generated.ts; contracts/perf/{exceptions.json,registry.json,adoption-1058.json,ratchet.json}. Full issue file inventory is attached as owned-files.txt. Screenshots were not committed. Known gate gap: #1213 https://git.kayg.org/kayg/calternal/issues/1213 — the unchanged Files reconcile-storm test double-polls the watcher JoinHandle during failed-completion cleanup. Full Files test is FAILED, not waived. Gate output, verbatim excerpts (full logs attached): `cargo fmt --check` (fmt-check-final.log) ```text ``` No completion output recorded; see final status below. `cargo clippy -p calternal-plugin-notes --all-targets -- -D warnings` (notes-final-clippy.log) ```text Finished `dev` profile [unoptimized + debuginfo] target(s) in 40.29s ``` `cargo test -p calternal-plugin-notes -- --test-threads=4` (calternal-plugin-notes-test-local.log) ```text Finished `test` profile [unoptimized + debuginfo] target(s) in 3m 51s test result: ok. 311 passed; 0 failed; 4 ignored; 0 measured; 0 filtered out; finished in 484.46s test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 2.60s test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s ``` `cargo clippy -p calternal-plugin-calendar --all-targets -- -D warnings` (calternal-plugin-calendar-clippy.log) ```text Finished `dev` profile [unoptimized + debuginfo] target(s) in 3m 11s ``` `cargo test -p calternal-plugin-calendar -- --test-threads=4` (calternal-plugin-calendar-test.log) ```text Finished `test` profile [unoptimized + debuginfo] target(s) in 4m 07s test result: ok. 104 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 17.50s test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.21s test result: ok. 3 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.08s test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s ``` `cargo clippy -p calternal-search --all-targets -- -D warnings` (calternal-search-clippy.log) ```text Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 34s ``` `cargo test -p calternal-search -- --test-threads=4` (calternal-search-test-final.log) ```text Finished `test` profile [unoptimized + debuginfo] target(s) in 9m 41s test result: ok. 59 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 86.88s test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 8.48s test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 2.60s ``` `cargo clippy -p calternal-plugin-files --all-targets -- -D warnings` (calternal-plugin-files-clippy.log) ```text Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 38s ``` `cargo test -p calternal-plugin-files -- --test-threads=4` (calternal-plugin-files-test.log) ```text Finished `test` profile [unoptimized + debuginfo] target(s) in 10m 24s test result: FAILED. 259 passed; 1 failed; 4 ignored; 0 measured; 0 filtered out; finished in 479.67s error: test failed, to rerun pass `-p calternal-plugin-files --lib` ``` `cargo clippy -p calternal-plugin-photos --all-targets -- -D warnings` (calternal-plugin-photos-clippy.log) ```text Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 41s ``` `cargo test -p calternal-plugin-photos -- --test-threads=4` (calternal-plugin-photos-test-final.log) ```text ``` No completion output recorded; see final status below. `cargo clippy -p calternal-tags --all-targets -- -D warnings` (calternal-tags-clippy.log) ```text Finished `dev` profile [unoptimized + debuginfo] target(s) in 53.85s ``` `cargo test -p calternal-tags -- --test-threads=4` (calternal-tags-test-final.log) ```text ``` No completion output recorded; see final status below. `cargo clippy -p calternal-server --all-targets -- -D warnings` (calternal-server-clippy.log) ```text Finished `dev` profile [unoptimized + debuginfo] target(s) in 9m 09s ``` `cargo test -p calternal-server -- --test-threads=4` (calternal-server-test-final.log) ```text ``` No completion output recorded; see final status below. `cd apps/web && bun run check` (web-check-final.log) ```text perf-lint: PASS; 0 violations; 22550 scoped exceptions svelte-check found 0 errors and 1 warning in 1 file ``` `cd apps/web && bun run test --maxWorkers=2 --testTimeout=30000` (web-test.log) ```text Test Files 282 passed (282) Tests 1997 passed (1997) ``` `Daily Log writer-contention regression` (daily-contention.log) ```text Finished `test` profile [unoptimized + debuginfo] target(s) in 11m 15s Daily Log single-attempt witness: Index is busy; retry shortly test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 314 filtered out; finished in 2.09s test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 2 filtered out; finished in 0.00s ``` `exact private Log Search regression` (search-overlay-final.log) ```text test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 27 filtered out; finished in 4.96s ``` Final status: NOT READY FOR MERGE. The 150-minute time box ended with the Files full test FAILED (#1213), and full Search, Photos, Tags and Server tests incomplete. The corrected Search overlay integration passes in the full rerun, and Search unit/Ask/client contracts pass; the overflow-recovery integration had not completed. Photos test compilation was interrupted; Tags and Server full tests had not started. No existing assertion was weakened. Own gate groups were terminated and cleanup was requested. Remaining job gates (not claimed as passed): `cargo test -p calternal-search -- --test-threads=4`; `cargo test -p calternal-plugin-photos -- --test-threads=4`; `cargo test -p calternal-tags -- --test-threads=4`; `cargo test -p calternal-server -- --test-threads=4`. Fix #1213 without weakening the storm checks, then run `cargo test -p calternal-plugin-files -- --test-threads=4`. Formatter exit status: 0 (no output). Production web build passed. Full web check/test and all seven clippy gates passed; the comment-only final commit does not change runtime behavior. #1153 is left open. Full gate logs, file inventory and screenshot manifest: [hide5-gate-evidence.zip](https://git.kayg.org/attachments/76fff571-67d0-4458-a331-7bcdcc984e89).
kayg commented 2026-10-06 18:57:16 +00:00
Author
Owner
Copy link

Cleanup complete. Verbatim cargo clean output:

     Removed 1 file, 53B total

The Cargo target was this job's symlink to its transferred cache, so Cargo removed the link. The job-owned /mnt/hdd/targets/jobs/hide5-1153-transferred-20261006 compiler cache was then removed with a checked directory cleanup. apps/web/build and apps/web/.svelte-kit/output were also removed. Screenshot and gate artifacts remain. The working tree is clean. Verification stopped inside the time box; only cleanup and this status update followed. No push. Head e702556534.

Cleanup complete. Verbatim `cargo clean` output: ```text Removed 1 file, 53B total ``` The Cargo target was this job's symlink to its transferred cache, so Cargo removed the link. The job-owned `/mnt/hdd/targets/jobs/hide5-1153-transferred-20261006` compiler cache was then removed with a checked directory cleanup. `apps/web/build` and `apps/web/.svelte-kit/output` were also removed. Screenshot and gate artifacts remain. The working tree is clean. Verification stopped inside the time box; only cleanup and this status update followed. No push. Head e702556534d9f1c2ed0c243a2465566d80a86b55.
kayg commented 2026-10-06 18:59:23 +00:00
Author
Owner
Copy link

Independent final data-safety review started on job/hide-1153, head e702556534d9f1c2ed0c243a2465566d80a86b55, base ff53d7b8b4da5a21f862d57dcc3496f8c019f647. Read the branch diff and first independent review before the repair reports. Time-box: 90 minutes. Required git fetch origin && git merge origin/dev returned Already up to date. Checking source bytes, private overlays, checked concurrent writes, exported User Tags and exact Undo. No push.

Independent final data-safety review started on `job/hide-1153`, head `e702556534d9f1c2ed0c243a2465566d80a86b55`, base `ff53d7b8b4da5a21f862d57dcc3496f8c019f647`. Read the branch diff and first independent review before the repair reports. Time-box: 90 minutes. Required `git fetch origin && git merge origin/dev` returned `Already up to date.` Checking source bytes, private overlays, checked concurrent writes, exported User Tags and exact Undo. No push.
kayg commented 2026-10-06 19:02:04 +00:00
Author
Owner
Copy link

Independent final review reproduced two additional YAML defects on e70255653. The unchanged five original byte contracts pass. Added probes fail: (1) tags: [work, # keep comma\n keep, # keep trailing comma\n] receives another comma and no longer parses as a Tag list; (2) Unhide retains a block marker with an inline YAML comment. Evidence: artifacts/hiderev2-1153/byte-contracts-before.log (6 passed; 2 failed). Anchored list forms are also in the expanded probe. Fixing source-span scanning, with exact-byte regression fixtures; no original assertion changed.

Independent final review reproduced two additional YAML defects on e70255653. The unchanged five original byte contracts pass. Added probes fail: (1) `tags: [work, # keep comma\n keep, # keep trailing comma\n]` receives another comma and no longer parses as a Tag list; (2) Unhide retains a block marker with an inline YAML comment. Evidence: artifacts/hiderev2-1153/byte-contracts-before.log (`6 passed; 2 failed`). Anchored list forms are also in the expanded probe. Fixing source-span scanning, with exact-byte regression fixtures; no original assertion changed.
kayg commented 2026-10-06 19:17:55 +00:00
Author
Owner
Copy link

Final review progress: committed independent concurrency/isolation regression as 0d0803a67. Eight synchronized writers retain four private Hide keys and four other Plugin preference sections. A second viewer has an independent overlay; Undo leaves that viewer untouched; Index recovery retains the surviving keys; owner Note bytes are unchanged throughout. Plugin clippy passed. Verbatim suite result: test result: ok. 52 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 10.81s.

The expanded byte probe passes 11 contracts. The five original review fixtures remain unchanged. Additional fixes cover YAML commented flow lists, anchored lists, commented markers, complete Tag token matching, tab-separated Log markers, and safe refusal of unsupported Tag YAML. Full web output: Test Files 282 passed (282) / Tests 1997 passed (1997). API and live-write checks remain in progress. No push.

Final review progress: committed independent concurrency/isolation regression as `0d0803a67`. Eight synchronized writers retain four private Hide keys and four other Plugin preference sections. A second viewer has an independent overlay; Undo leaves that viewer untouched; Index recovery retains the surviving keys; owner Note bytes are unchanged throughout. Plugin clippy passed. Verbatim suite result: `test result: ok. 52 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 10.81s`. The expanded byte probe passes 11 contracts. The five original review fixtures remain unchanged. Additional fixes cover YAML commented flow lists, anchored lists, commented markers, complete Tag token matching, tab-separated Log markers, and safe refusal of unsupported Tag YAML. Full web output: `Test Files 282 passed (282)` / `Tests 1997 passed (1997)`. API and live-write checks remain in progress. No push.
kayg commented 2026-10-06 19:31:09 +00:00
Author
Owner
Copy link

Final independent source probe reproduced inline Task data loss: Unhide changes code #_calternal/hidden suffix inside a code span to code suffix. Evidence: artifacts/hiderev2-1153/task-code-before.log, exact expected bytes unchanged. The writer searched raw substrings without excluding Markdown code. The Task parser also treated the literal marker as hidden state. The fix reuses the Markdown Tag span scanner in the reserved-marker reader and writer, with code/link/escape regressions and exact CRLF/indent/trailing-space round trips. Ordinary Task Tags retain their existing parser. Gates are running for this additional atomic fix. No push.

Final independent source probe reproduced inline Task data loss: Unhide changes `code #_calternal/hidden suffix` inside a code span to `code suffix`. Evidence: artifacts/hiderev2-1153/task-code-before.log, exact expected bytes unchanged. The writer searched raw substrings without excluding Markdown code. The Task parser also treated the literal marker as hidden state. The fix reuses the Markdown Tag span scanner in the reserved-marker reader and writer, with code/link/escape regressions and exact CRLF/indent/trailing-space round trips. Ordinary Task Tags retain their existing parser. Gates are running for this additional atomic fix. No push.
kayg commented 2026-10-06 19:40:00 +00:00
Author
Owner
Copy link

Final-review source fix 03605b8bd is committed: inline Task Hide and Unhide use the existing Markdown Tag spans. Literal marker text in code, links and escapes remains source text. The unchanged ordinary Task path does not run the extra scanner.

Core Clippy passes. Core tests pass: 589 unit tests and all 12 independent exact-byte contracts, plus the existing integration suites. Three Notes API review tests pass after this change. The real production-server overlay run passes shared Note, Task, Log and plain Canvas Hide, exact Undo, recipient isolation, hidden deep links, and rejected stale/revoked writes. Screenshots cover macOS at 390/820/1440 px in both themes and are being attached.

Server Clippy passes after building the required SPA assets. Server tests have one SLOW-only failure, with the original threshold kept:

search_reconcile_calendar_write_profile files=20000 writes=32 p50_ms=12052 p95_ms=12373 p95_budget_ms=10000
Calendar write p95 12.373837554s exceeded 10s
test result: FAILED. 267 passed; 1 failed; 12 ignored; 0 measured; 0 filtered out; finished in 129.66s

This is the large-Home startup reconciliation timing assertion, not a Hide correctness or safety failure. Per the job rule, SLOW does not block. It will remain visible in the final gate report; no threshold or existing expectation was changed.

Final-review source fix `03605b8bd` is committed: inline Task Hide and Unhide use the existing Markdown Tag spans. Literal marker text in code, links and escapes remains source text. The unchanged ordinary Task path does not run the extra scanner. Core Clippy passes. Core tests pass: 589 unit tests and all 12 independent exact-byte contracts, plus the existing integration suites. Three Notes API review tests pass after this change. The real production-server overlay run passes shared Note, Task, Log and plain Canvas Hide, exact Undo, recipient isolation, hidden deep links, and rejected stale/revoked writes. Screenshots cover macOS at 390/820/1440 px in both themes and are being attached. Server Clippy passes after building the required SPA assets. Server tests have one SLOW-only failure, with the original threshold kept: ```text search_reconcile_calendar_write_profile files=20000 writes=32 p50_ms=12052 p95_ms=12373 p95_budget_ms=10000 Calendar write p95 12.373837554s exceeded 10s test result: FAILED. 267 passed; 1 failed; 12 ignored; 0 measured; 0 filtered out; finished in 129.66s ``` This is the large-Home startup reconciliation timing assertion, not a Hide correctness or safety failure. Per the job rule, SLOW does not block. It will remain visible in the final gate report; no threshold or existing expectation was changed.
kayg commented 2026-10-06 19:44:29 +00:00
Author
Owner
Copy link

Final independent review: 48 production screenshots for shared Note, Task, Log and plain Canvas. macOS is emulated; every state covers 390, 820 and 1440 px in light and dark. The runner passes Hide, Undo, Show hidden, deep-link Unhide, private source preservation, and denied stale/revoked writes. These assets are for the orchestrator’s visual review; they are not committed.

State phone-light phone-dark tablet-light tablet-dark desktop-light desktop-dark
plain-canvas-hidden PNG PNG PNG PNG PNG PNG
plain-canvas-link PNG PNG PNG PNG PNG PNG
shared-log-hidden PNG PNG PNG PNG PNG PNG
shared-log-link PNG PNG PNG PNG PNG PNG
shared-note-link PNG PNG PNG PNG PNG PNG
shared-notes-hidden PNG PNG PNG PNG PNG PNG
shared-task-hidden PNG PNG PNG PNG PNG PNG
shared-task-link PNG PNG PNG PNG PNG PNG
Final independent review: 48 production screenshots for shared Note, Task, Log and plain Canvas. macOS is emulated; every state covers 390, 820 and 1440 px in light and dark. The runner passes Hide, Undo, Show hidden, deep-link Unhide, private source preservation, and denied stale/revoked writes. These assets are for the orchestrator’s visual review; they are not committed. | State | phone-light | phone-dark | tablet-light | tablet-dark | desktop-light | desktop-dark | | --- | --- | --- | --- | --- | --- | --- | | plain-canvas-hidden | [PNG](https://git.kayg.org/attachments/7136dd0a-00d9-4e48-a960-eb0b1b2b545c) | [PNG](https://git.kayg.org/attachments/42718e25-7f67-42bb-995f-3eabfd7dc65d) | [PNG](https://git.kayg.org/attachments/ab3b2bde-4fa9-47e9-b776-9648f1316109) | [PNG](https://git.kayg.org/attachments/8f64a228-0d40-43ef-b344-c4eeff364072) | [PNG](https://git.kayg.org/attachments/8d130ccc-e913-44a4-af2c-b74cd6bbeed1) | [PNG](https://git.kayg.org/attachments/20acbc39-d6f7-4bf5-9f89-200f1cb5e585) | | plain-canvas-link | [PNG](https://git.kayg.org/attachments/81872edc-75df-42c7-90aa-b8813e6f6bab) | [PNG](https://git.kayg.org/attachments/d0598c7e-033d-45d2-aa48-e86c831b61a6) | [PNG](https://git.kayg.org/attachments/c6a1d149-4c3f-4033-b3bf-18a682a7e776) | [PNG](https://git.kayg.org/attachments/a18d3433-0837-41e0-bf39-6142ca58c390) | [PNG](https://git.kayg.org/attachments/39d70890-618a-41ec-858b-dcaf95faa84d) | [PNG](https://git.kayg.org/attachments/f55e22ee-24b5-4340-a7d7-80e1e76d5bfa) | | shared-log-hidden | [PNG](https://git.kayg.org/attachments/ff96edd7-8f7a-4aa0-a01c-b2675bececc8) | [PNG](https://git.kayg.org/attachments/8b29abff-1c46-4a20-9cbe-cc080fe37273) | [PNG](https://git.kayg.org/attachments/d736a347-cda4-4913-b143-5a59b40d2139) | [PNG](https://git.kayg.org/attachments/34c588df-c33b-4ba0-814b-d93c237534c5) | [PNG](https://git.kayg.org/attachments/4a531b3d-e9de-4f57-885a-b16c4976992e) | [PNG](https://git.kayg.org/attachments/4a7ff804-85bb-4c5a-acbc-f4f87d7a3b34) | | shared-log-link | [PNG](https://git.kayg.org/attachments/24839034-3180-4597-aa58-978fd2d8bff4) | [PNG](https://git.kayg.org/attachments/1b9dff1e-7160-4c2e-98c0-350e003e9190) | [PNG](https://git.kayg.org/attachments/5a8b41b7-c414-43a4-9a2e-c0a7019608c3) | [PNG](https://git.kayg.org/attachments/a9efb41a-f39d-413d-9f75-9c480ffa7c22) | [PNG](https://git.kayg.org/attachments/52818058-7972-40c1-82fc-9d4b640a0dc2) | [PNG](https://git.kayg.org/attachments/bf38ea13-ba69-4252-9190-7520e4d4b7b9) | | shared-note-link | [PNG](https://git.kayg.org/attachments/dfb80e8c-e71b-47ec-88f3-8748a19a7be8) | [PNG](https://git.kayg.org/attachments/ca2f857b-ff26-4901-9d8b-e0508c6ed43d) | [PNG](https://git.kayg.org/attachments/2b180153-ba04-47e1-9f8c-cd09b051fdf9) | [PNG](https://git.kayg.org/attachments/66ed4fa6-eeac-4f98-9369-1519c22c7a25) | [PNG](https://git.kayg.org/attachments/a4a85e86-092c-4f52-acbd-dfd056f1f923) | [PNG](https://git.kayg.org/attachments/692ea6fe-cee8-4ef5-98f2-f1e5a8485b5a) | | shared-notes-hidden | [PNG](https://git.kayg.org/attachments/3b477b24-b00a-493a-916b-adb232f1cd7a) | [PNG](https://git.kayg.org/attachments/f84498cd-a823-4124-ae23-79fc22526766) | [PNG](https://git.kayg.org/attachments/825721db-0225-4105-8a37-8f3bf238a9f5) | [PNG](https://git.kayg.org/attachments/9130d740-4df7-4a43-8821-f4d8ceef6bb3) | [PNG](https://git.kayg.org/attachments/ae2abbc4-7f40-44ea-96da-db27d74b5ef0) | [PNG](https://git.kayg.org/attachments/af648aff-420f-4e08-a979-f31e29032afb) | | shared-task-hidden | [PNG](https://git.kayg.org/attachments/0f1f8cb0-9270-46f8-bc02-0eb10c99cd33) | [PNG](https://git.kayg.org/attachments/4c86fd92-a7d7-47ca-a7ee-8eef49acb8f3) | [PNG](https://git.kayg.org/attachments/79eabda0-ec51-4c6a-a551-2bbded2b266f) | [PNG](https://git.kayg.org/attachments/2eb91a5b-8edb-42bf-a5ff-d53691cad19d) | [PNG](https://git.kayg.org/attachments/e7ecec1f-bb66-4e3b-aded-5a56f41e1321) | [PNG](https://git.kayg.org/attachments/069d0635-3903-425d-b6bc-b42272d5d0df) | | shared-task-link | [PNG](https://git.kayg.org/attachments/d6bbdd16-4a59-4fb2-b841-8e3064f24f94) | [PNG](https://git.kayg.org/attachments/547346cf-b320-45ee-84a7-490ae25fd52a) | [PNG](https://git.kayg.org/attachments/582f67cb-7fbc-4e79-9030-1afe9ad3b6f6) | [PNG](https://git.kayg.org/attachments/99f00d63-5105-46a1-b4d6-6b76cdf3189f) | [PNG](https://git.kayg.org/attachments/bc3022c4-8484-4e03-bddf-9702a43f5a07) | [PNG](https://git.kayg.org/attachments/bc8f287e-c877-4206-8559-bfed82c1eb48) |
kayg commented 2026-10-06 19:51:56 +00:00
Author
Owner
Copy link

SAFE TO MERGE: YES. Final reviewed branch head: cf5f4f05fefc8f0fb0d291b5b12068254a7b0602.

Final independent Hide review — #1153

SAFE TO MERGE: YES for data safety, with the raw-source export decision from the first review retained. The only failed gate is the SLOW-only startup timing assertion below. No data-safety failure remains in the checks run.

Branch: job/hide-1153. Reviewed product code head: 03605b8bd9e7fe323fd0eb82c5185f449cc6715a. A separate E2E readiness commit follows. The final issue comment gives the report commit SHA. Starting feature head: e702556534d9f1c2ed0c243a2465566d80a86b55. Base: ff53d7b8b4da5a21f862d57dcc3496f8c019f647 (origin/dev). Fetch and merge of origin/dev returned Already up to date. No push, deploy, or merge to another branch was done.

Built and findings fixed

This review read the branch diff and the first review before the author's reports. It tested the first review's source contracts rather than changing their expected values.

  • 0d0803a67: add a synchronized eight-writer test for private overlays and other Plugin preferences. Every key survives. Owner bytes stay intact. A second User's overlay remains independent. Undo and Index rebuild keep the viewer boundary.
  • c1df6d93b: fix YAML flow comments, trailing commas, sequence anchors and scalar boundaries. Reject unsupported or damaged Tag structures without editing them. Log Unhide removes only the parsed reserved token. It preserves a longer User Tag and literal title text. Add source regressions to the standard Cargo gate.
  • c1f9f97ed: Note and rich Task APIs return 400 when the byte writer cannot apply the requested hidden state. They do not acknowledge an unapplied Hide. Add real API revision tests, a later-edit Undo test, and native CalDAV export tests.
  • 0c8945c22: refresh exactly two mutation source hashes. Keep every perf rule, limit and ratchet unchanged.
  • d24a1fc6b: document the refusal contract for byte-preserving callers.
  • 477ecd4a6: share the existing Task date-adoption readiness wait between owner and Share E2E baselines. Keep all fixture data and exact assertions.
  • 03605b8bd: fix inline Task Unhide deleting literal marker text in code or links. Use the existing Markdown Tag spans for both visibility reads and writes. The extra scan is lazy and runs only when the reserved spelling occurs. Add code, link and escaped-text round trips with CRLF and trailing spaces.

The final owner-Task E2E also exposed a baseline race: the already-queued #1148 writer added date and last edited after the baseline read. The owner fixture now reuses the Share fixture’s migration-readiness wait. The fixture values and every exact-byte assertion remain unchanged. The Task production round trip then passes.

The initial new probes reproduced YAML damage and inline Task text loss. The corrected probes pass. No existing test assertion, status code or fixture expectation was weakened.

Files

  • crates/calternal-notes-core/src/frontmatter.rs: YAML marker splice and refusal contract.
  • crates/calternal-notes-core/src/dayfile.rs: exact trailing Log Tag removal.
  • crates/calternal-notes-core/src/tasks/line.rs: Markdown-aware Task marker spans.
  • crates/calternal-notes-core/tests/hide_review_1153.rs and tests/adversarial/hide-1153-byte-contracts.rs: permanent independent source tests.
  • crates/calternal-plugin/src/user_settings.rs: concurrent private overlay regression.
  • crates/plugins/notes/src/lib.rs and crates/plugins/notes/src/tasks_api.rs: safe refusal and real writer/export tests.
  • contracts/perf/exceptions.json: exact hashes only.
  • apps/web/e2e/hide-1153.mjs: shared date-adoption readiness for owner and Share byte baselines.
  • review-1153.md: this final report replaces the first review's obsolete verdict. The first review remains in issue history.

The doc comments of all changed Rust files were read again before this report. No package version or dependency changed. No UI component changed or was added.

Verified data contracts

Contract Evidence
Note, Markdown Canvas, rich Task Exact original bytes after Hide and Unhide; quotes, BOM, CRLF, comments, anchors and User Tags retained. Unsupported scalar, mapping, alias and explicit null sources receive 400 without a write.
Inline Task Exact source Undo; literal markers in code, links and escapes stay text; stable Block ID and whitespace retained.
Day-file Log Exact line, child-block and file Undo; reserved Tag removal does not remove a similar User Tag or title text.
Folder .calternal.json Existing exact-byte and created-container tests pass. Stale replacement and deletion reject a changed source.
XMP keywords Exact-byte and created-container tests pass. No stray parent keyword appears. An explicit _calternal User Tag survives.
Private overlays Eight concurrent preference writers retain all keys. Owner file bytes stay intact. A second recipient stays independent. Search rebuild and recipient Log projection retain the same boundary.
Live edits and Undo Real Note Hide rejects a stale collaboration write with 412. A fresh later edit is retained byte-for-byte by Unhide except for the reserved token. Log writes compare the freshly read entry before replacement.
Public Tags and exports Native Journal VEVENT and Task VTODO omit the marker without changing the source. Existing Tag source and UI/API tests pass. Raw WebDAV source visibility is the limitation below.

The final production item runner passes Task, Log, file, folder and Photo Hide → Undo → Hide → Unhide, exact source bytes, Search and Show hidden. Its 150 macOS screenshots cover every state at all six width/theme combinations. The final server build uses the reviewed product source.

The production-server overlay run passes shared Note, Task and Log Hide, Undo, Show hidden, hidden deep links, optimistic input, and rejection of stale or revoked writes. It also proves that plain Canvas Hide and Unhide do not change scene bytes. Its macOS screenshot set covers 390, 820 and 1440 px in light and dark. Screenshots are attached to #1153 and remain outside Git. The orchestrator owns visual review.

Gates (verbatim output)

Rust commands use CARGO_PROFILE_DEV_DEBUG=line-tables-only, CARGO_INCREMENTAL=0, CARGO_BUILD_JOBS=4, and the worktree target/tmp. The preset target directory was kept. The full Notes suite ran before the last added review test; all three review tests then ran on the final source. The core suite ran after the Task fix. Web tests ran once after the merge; the final check ran after the exact hash refresh and all source fixes.

cargo fmt --check: exit 0; no output.

cargo clippy -p calternal-plugin --all-targets -- -D warnings

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 4m 40s

cargo test -p calternal-plugin -- --test-threads=4

    Finished `test` profile [unoptimized + debuginfo] target(s) in 6m 53s
test result: ok. 52 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 10.81s
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

cargo clippy -p calternal-notes-core --all-targets -- -D warnings

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 5m 11s

cargo test -p calternal-notes-core -- --test-threads=4

    Finished `test` profile [unoptimized + debuginfo] target(s) in 1m 32s
test result: ok. 589 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.83s
test result: ok. 12 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s
test result: ok. 19 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 9.18s
test result: ok. 5 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.08s
test result: ok. 7 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.54s
test result: ok. 12 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
test result: ok. 4 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

cargo clippy -p calternal-plugin-notes --all-targets -- -D warnings

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 9m 55s

cargo test -p calternal-plugin-notes -- --test-threads=4

    Finished `test` profile [unoptimized + debuginfo] target(s) in 6m 41s
test result: ok. 313 passed; 0 failed; 4 ignored; 0 measured; 0 filtered out; finished in 347.59s
test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.30s
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

cargo test -p calternal-plugin-notes review_1153_ -- --test-threads=4

    Finished `test` profile [unoptimized + debuginfo] target(s) in 1m 19s
test result: ok. 3 passed; 0 failed; 0 ignored; 0 measured; 315 filtered out; finished in 1.19s
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 2 filtered out; finished in 0.00s

cargo clippy -p calternal-server --all-targets -- -D warnings

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 6m 09s

cargo test -p calternal-server -- --test-threads=4

    Finished `test` profile [unoptimized + debuginfo] target(s) in 10m 09s
search_reconcile_calendar_write_profile files=20000 writes=32 p50_ms=12052 p95_ms=12373 p95_budget_ms=10000
Calendar write p95 12.373837554s exceeded 10s
test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 279 filtered out; finished in 26.19s
test result: FAILED. 267 passed; 1 failed; 12 ignored; 0 measured; 0 filtered out; finished in 129.66s

cargo test -p calternal-tags -- --test-threads=4

    Finished `test` profile [unoptimized + debuginfo] target(s) in 6m 59s
test result: ok. 51 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 113.41s
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

cargo test -p calternal-search --test indexer private_rebuild_and_recipient_overlay_keep_owner_bytes -- --test-threads=4

    Finished `test` profile [unoptimized + debuginfo] target(s) in 5m 09s
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 27 filtered out; finished in 3.34s

cargo test -p calternal-search --test indexer recipient_log_overlay_filters_only_its_block -- --test-threads=4

    Finished `test` profile [unoptimized + debuginfo] target(s) in 8m 54s
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 27 filtered out; finished in 7.87s

cd apps/web && bun run check

perf-lint: PASS; 0 violations; 22550 scoped exceptions
svelte-check found 0 errors and 1 warning in 1 file

cd apps/web && bun run test

 Test Files  282 passed (282)
      Tests  1997 passed (1997)
   Duration  426.26s (transform 32%, environment 25%, import 22%, tests 15%, setup 5%)

The server timing failure comes from startup_search_reconciliation_keeps_calendar_writes_responsive_on_large_home, inside the isolated live-app runner. Its original 10-second threshold remains. This is SLOW-only under the job rule. The full server command exits 101; this report does not call it a pass. Server Clippy initially lacked production SPA assets; bun run build supplied them and the final Clippy run passes.

The web warning is the existing empty .attachment-row:focus rule in packages/ui/src/components/calendar/AttachmentDeck.svelte. There are no new web errors.

Focused real-server output (verbatim):

Checking shared Task and Log production overlays
PASS shared Task and Log UI Hide, Undo, hidden deep links, Show hidden, Unhide and denied stale/revoked writes
PASS shared Note recipient overlay and plain Canvas byte preservation
PASS focused production overlays and all six viewport/theme combinations
Checking tasks Hide, Search, Undo, Show hidden, Unhide and markdown bytes
PASS tasks Hide round trip
Checking calendar Hide, Search, Undo, Show hidden, Unhide and markdown bytes
PASS calendar Hide round trip
Checking files Hide, Search, Undo, Show hidden, Unhide and json bytes
PASS files Hide round trip
Checking folders Hide, Search, Undo, Show hidden, Unhide and json bytes
PASS folders Hide round trip
Checking photos Hide, Search, Undo, Show hidden, Unhide and xmp bytes
PASS photos Hide round trip
PASS focused production item states at all six viewport/theme combinations

UX gaps closed

  • Hide no longer damages commented YAML or silently succeeds when it cannot edit a Tag structure safely.
  • Undo no longer removes a similar Log User Tag or literal Task title text.
  • The live overlay walk confirms that primary actions, Undo, Show hidden and deep-link Unhide work through production menus.

UX gaps left and known gaps

  • Raw WebDAV Markdown and XMP downloads retain _calternal/hidden because they return the stored source. An external XMP client can display it as a keyword. This was an explicit first-review decision. Native app Tag projections and native CalDAV exports omit it. This review does not claim that the marker is private from raw-file clients.
  • The existing File/folder deep-link Hidden badge follow-up is #1212. This review changes no File/folder UI.
  • Server large-Home startup timing failed on this shared host. No benchmark threshold was changed. Performance is not a merge gate for this job.

Decisions

  • Refuse unsupported YAML with the existing 400 response and leave every source byte intact. Do not convert hand-written metadata to a new representation.
  • A marker spelling inside code, a link or escaped text is literal Markdown, not visibility metadata. Reuse the existing scanner so readers and writers agree.
  • Retain the first review's raw-source WebDAV export decision. Removing the marker from arbitrary downloaded source would change that contract and is outside this safety fix.

Expected operation cost stays one Item times a bounded source read, linear token scan/splice and checked write. No full-Home scan, new query or background job was added. Ordinary Task parsing keeps its old path; only the reserved spelling triggers the extra Markdown scan. No perf VM run was made: the current verification policy reserves measurements for performance issues. The existing bench/hidden-1153.mjs profile stays unchanged.

For the merge round

  • cargo test -p calternal-server -- --test-threads=4: finish the isolated live-app suite and record the 20,000-file startup timing on the combined branch. Keep the current budget.
  • cd apps/web && bun run test: confirm the combined branch retains all web assertions.
  • bun apps/web/e2e/hide-1153.mjs: verify the combined branch with its own production build. The focused source, real-writer, overlay and all-format item scenarios ran in this job.

Full gate and regression logs: ZIP. Screenshots are attached separately to #1153.

Cleanup completed: cargo clean reported Removed 22300 files, 18.3GiB total. The production web build and .svelte-kit/output were removed. Review artifacts remain in the worktree and on #1153; none were added to Git.

SAFE TO MERGE: **YES**. Final reviewed branch head: `cf5f4f05fefc8f0fb0d291b5b12068254a7b0602`. # Final independent Hide review — #1153 SAFE TO MERGE: **YES for data safety**, with the raw-source export decision from the first review retained. The only failed gate is the SLOW-only startup timing assertion below. No data-safety failure remains in the checks run. Branch: `job/hide-1153`. Reviewed product code head: `03605b8bd9e7fe323fd0eb82c5185f449cc6715a`. A separate E2E readiness commit follows. The final issue comment gives the report commit SHA. Starting feature head: `e702556534d9f1c2ed0c243a2465566d80a86b55`. Base: `ff53d7b8b4da5a21f862d57dcc3496f8c019f647` (`origin/dev`). Fetch and merge of `origin/dev` returned `Already up to date.` No push, deploy, or merge to another branch was done. ## Built and findings fixed This review read the branch diff and the first review before the author's reports. It tested the first review's source contracts rather than changing their expected values. - `0d0803a67`: add a synchronized eight-writer test for private overlays and other Plugin preferences. Every key survives. Owner bytes stay intact. A second User's overlay remains independent. Undo and Index rebuild keep the viewer boundary. - `c1df6d93b`: fix YAML flow comments, trailing commas, sequence anchors and scalar boundaries. Reject unsupported or damaged Tag structures without editing them. Log Unhide removes only the parsed reserved token. It preserves a longer User Tag and literal title text. Add source regressions to the standard Cargo gate. - `c1f9f97ed`: Note and rich Task APIs return 400 when the byte writer cannot apply the requested hidden state. They do not acknowledge an unapplied Hide. Add real API revision tests, a later-edit Undo test, and native CalDAV export tests. - `0c8945c22`: refresh exactly two mutation source hashes. Keep every perf rule, limit and ratchet unchanged. - `d24a1fc6b`: document the refusal contract for byte-preserving callers. - `477ecd4a6`: share the existing Task date-adoption readiness wait between owner and Share E2E baselines. Keep all fixture data and exact assertions. - `03605b8bd`: fix inline Task Unhide deleting literal marker text in code or links. Use the existing Markdown Tag spans for both visibility reads and writes. The extra scan is lazy and runs only when the reserved spelling occurs. Add code, link and escaped-text round trips with CRLF and trailing spaces. The final owner-Task E2E also exposed a baseline race: the already-queued #1148 writer added `date` and `last edited` after the baseline read. The owner fixture now reuses the Share fixture’s migration-readiness wait. The fixture values and every exact-byte assertion remain unchanged. The Task production round trip then passes. The initial new probes reproduced YAML damage and inline Task text loss. The corrected probes pass. No existing test assertion, status code or fixture expectation was weakened. ## Files - `crates/calternal-notes-core/src/frontmatter.rs`: YAML marker splice and refusal contract. - `crates/calternal-notes-core/src/dayfile.rs`: exact trailing Log Tag removal. - `crates/calternal-notes-core/src/tasks/line.rs`: Markdown-aware Task marker spans. - `crates/calternal-notes-core/tests/hide_review_1153.rs` and `tests/adversarial/hide-1153-byte-contracts.rs`: permanent independent source tests. - `crates/calternal-plugin/src/user_settings.rs`: concurrent private overlay regression. - `crates/plugins/notes/src/lib.rs` and `crates/plugins/notes/src/tasks_api.rs`: safe refusal and real writer/export tests. - `contracts/perf/exceptions.json`: exact hashes only. - `apps/web/e2e/hide-1153.mjs`: shared date-adoption readiness for owner and Share byte baselines. - `review-1153.md`: this final report replaces the first review's obsolete verdict. The first review remains in issue history. The doc comments of all changed Rust files were read again before this report. No package version or dependency changed. No UI component changed or was added. ## Verified data contracts | Contract | Evidence | | --- | --- | | Note, Markdown Canvas, rich Task | Exact original bytes after Hide and Unhide; quotes, BOM, CRLF, comments, anchors and User Tags retained. Unsupported scalar, mapping, alias and explicit null sources receive 400 without a write. | | Inline Task | Exact source Undo; literal markers in code, links and escapes stay text; stable Block ID and whitespace retained. | | Day-file Log | Exact line, child-block and file Undo; reserved Tag removal does not remove a similar User Tag or title text. | | Folder `.calternal.json` | Existing exact-byte and created-container tests pass. Stale replacement and deletion reject a changed source. | | XMP keywords | Exact-byte and created-container tests pass. No stray parent keyword appears. An explicit `_calternal` User Tag survives. | | Private overlays | Eight concurrent preference writers retain all keys. Owner file bytes stay intact. A second recipient stays independent. Search rebuild and recipient Log projection retain the same boundary. | | Live edits and Undo | Real Note Hide rejects a stale collaboration write with 412. A fresh later edit is retained byte-for-byte by Unhide except for the reserved token. Log writes compare the freshly read entry before replacement. | | Public Tags and exports | Native Journal VEVENT and Task VTODO omit the marker without changing the source. Existing Tag source and UI/API tests pass. Raw WebDAV source visibility is the limitation below. | The final production item runner passes Task, Log, file, folder and Photo Hide → Undo → Hide → Unhide, exact source bytes, Search and Show hidden. Its 150 macOS screenshots cover every state at all six width/theme combinations. The final server build uses the reviewed product source. The production-server overlay run passes shared Note, Task and Log Hide, Undo, Show hidden, hidden deep links, optimistic input, and rejection of stale or revoked writes. It also proves that plain Canvas Hide and Unhide do not change scene bytes. Its macOS screenshot set covers 390, 820 and 1440 px in light and dark. Screenshots are attached to #1153 and remain outside Git. The orchestrator owns visual review. ## Gates (verbatim output) Rust commands use `CARGO_PROFILE_DEV_DEBUG=line-tables-only`, `CARGO_INCREMENTAL=0`, `CARGO_BUILD_JOBS=4`, and the worktree `target/tmp`. The preset target directory was kept. The full Notes suite ran before the last added review test; all three review tests then ran on the final source. The core suite ran after the Task fix. Web tests ran once after the merge; the final check ran after the exact hash refresh and all source fixes. `cargo fmt --check`: exit 0; no output. `cargo clippy -p calternal-plugin --all-targets -- -D warnings` ```text Finished `dev` profile [unoptimized + debuginfo] target(s) in 4m 40s ``` `cargo test -p calternal-plugin -- --test-threads=4` ```text Finished `test` profile [unoptimized + debuginfo] target(s) in 6m 53s test result: ok. 52 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 10.81s test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s ``` `cargo clippy -p calternal-notes-core --all-targets -- -D warnings` ```text Finished `dev` profile [unoptimized + debuginfo] target(s) in 5m 11s ``` `cargo test -p calternal-notes-core -- --test-threads=4` ```text Finished `test` profile [unoptimized + debuginfo] target(s) in 1m 32s test result: ok. 589 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.83s test result: ok. 12 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s test result: ok. 19 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 9.18s test result: ok. 5 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.08s test result: ok. 7 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.54s test result: ok. 12 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s test result: ok. 4 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s ``` `cargo clippy -p calternal-plugin-notes --all-targets -- -D warnings` ```text Finished `dev` profile [unoptimized + debuginfo] target(s) in 9m 55s ``` `cargo test -p calternal-plugin-notes -- --test-threads=4` ```text Finished `test` profile [unoptimized + debuginfo] target(s) in 6m 41s test result: ok. 313 passed; 0 failed; 4 ignored; 0 measured; 0 filtered out; finished in 347.59s test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.30s test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s ``` `cargo test -p calternal-plugin-notes review_1153_ -- --test-threads=4` ```text Finished `test` profile [unoptimized + debuginfo] target(s) in 1m 19s test result: ok. 3 passed; 0 failed; 0 ignored; 0 measured; 315 filtered out; finished in 1.19s test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 2 filtered out; finished in 0.00s ``` `cargo clippy -p calternal-server --all-targets -- -D warnings` ```text Finished `dev` profile [unoptimized + debuginfo] target(s) in 6m 09s ``` `cargo test -p calternal-server -- --test-threads=4` ```text Finished `test` profile [unoptimized + debuginfo] target(s) in 10m 09s search_reconcile_calendar_write_profile files=20000 writes=32 p50_ms=12052 p95_ms=12373 p95_budget_ms=10000 Calendar write p95 12.373837554s exceeded 10s test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 279 filtered out; finished in 26.19s test result: FAILED. 267 passed; 1 failed; 12 ignored; 0 measured; 0 filtered out; finished in 129.66s ``` `cargo test -p calternal-tags -- --test-threads=4` ```text Finished `test` profile [unoptimized + debuginfo] target(s) in 6m 59s test result: ok. 51 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 113.41s test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s ``` `cargo test -p calternal-search --test indexer private_rebuild_and_recipient_overlay_keep_owner_bytes -- --test-threads=4` ```text Finished `test` profile [unoptimized + debuginfo] target(s) in 5m 09s test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 27 filtered out; finished in 3.34s ``` `cargo test -p calternal-search --test indexer recipient_log_overlay_filters_only_its_block -- --test-threads=4` ```text Finished `test` profile [unoptimized + debuginfo] target(s) in 8m 54s test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 27 filtered out; finished in 7.87s ``` `cd apps/web && bun run check` ```text perf-lint: PASS; 0 violations; 22550 scoped exceptions svelte-check found 0 errors and 1 warning in 1 file ``` `cd apps/web && bun run test` ```text Test Files 282 passed (282) Tests 1997 passed (1997) Duration 426.26s (transform 32%, environment 25%, import 22%, tests 15%, setup 5%) ``` The server timing failure comes from `startup_search_reconciliation_keeps_calendar_writes_responsive_on_large_home`, inside the isolated live-app runner. Its original 10-second threshold remains. This is SLOW-only under the job rule. The full server command exits 101; this report does not call it a pass. Server Clippy initially lacked production SPA assets; `bun run build` supplied them and the final Clippy run passes. The web warning is the existing empty `.attachment-row:focus` rule in `packages/ui/src/components/calendar/AttachmentDeck.svelte`. There are no new web errors. Focused real-server output (verbatim): ```text Checking shared Task and Log production overlays PASS shared Task and Log UI Hide, Undo, hidden deep links, Show hidden, Unhide and denied stale/revoked writes PASS shared Note recipient overlay and plain Canvas byte preservation PASS focused production overlays and all six viewport/theme combinations Checking tasks Hide, Search, Undo, Show hidden, Unhide and markdown bytes PASS tasks Hide round trip Checking calendar Hide, Search, Undo, Show hidden, Unhide and markdown bytes PASS calendar Hide round trip Checking files Hide, Search, Undo, Show hidden, Unhide and json bytes PASS files Hide round trip Checking folders Hide, Search, Undo, Show hidden, Unhide and json bytes PASS folders Hide round trip Checking photos Hide, Search, Undo, Show hidden, Unhide and xmp bytes PASS photos Hide round trip PASS focused production item states at all six viewport/theme combinations ``` ## UX gaps closed - Hide no longer damages commented YAML or silently succeeds when it cannot edit a Tag structure safely. - Undo no longer removes a similar Log User Tag or literal Task title text. - The live overlay walk confirms that primary actions, Undo, Show hidden and deep-link Unhide work through production menus. ## UX gaps left and known gaps - Raw WebDAV Markdown and XMP downloads retain `_calternal/hidden` because they return the stored source. An external XMP client can display it as a keyword. This was an explicit first-review decision. Native app Tag projections and native CalDAV exports omit it. This review does not claim that the marker is private from raw-file clients. - The existing File/folder deep-link Hidden badge follow-up is #1212. This review changes no File/folder UI. - Server large-Home startup timing failed on this shared host. No benchmark threshold was changed. Performance is not a merge gate for this job. ## Decisions - Refuse unsupported YAML with the existing 400 response and leave every source byte intact. Do not convert hand-written metadata to a new representation. - A marker spelling inside code, a link or escaped text is literal Markdown, not visibility metadata. Reuse the existing scanner so readers and writers agree. - Retain the first review's raw-source WebDAV export decision. Removing the marker from arbitrary downloaded source would change that contract and is outside this safety fix. Expected operation cost stays one Item times a bounded source read, linear token scan/splice and checked write. No full-Home scan, new query or background job was added. Ordinary Task parsing keeps its old path; only the reserved spelling triggers the extra Markdown scan. No perf VM run was made: the current verification policy reserves measurements for performance issues. The existing `bench/hidden-1153.mjs` profile stays unchanged. ## For the merge round - `cargo test -p calternal-server -- --test-threads=4`: finish the isolated live-app suite and record the 20,000-file startup timing on the combined branch. Keep the current budget. - `cd apps/web && bun run test`: confirm the combined branch retains all web assertions. - `bun apps/web/e2e/hide-1153.mjs`: verify the combined branch with its own production build. The focused source, real-writer, overlay and all-format item scenarios ran in this job. Full gate and regression logs: [ZIP](https://git.kayg.org/attachments/29f15296-c309-406e-b356-3b652014aa42). Screenshots are attached separately to #1153. Cleanup completed: `cargo clean` reported `Removed 22300 files, 18.3GiB total`. The production web build and `.svelte-kit/output` were removed. Review artifacts remain in the worktree and on #1153; none were added to Git.
kayg commented 2026-10-06 19:53:41 +00:00
Author
Owner
Copy link

Final item evidence for head cf5f4f05fefc8f0fb0d291b5b12068254a7b0602: 150 attached macOS-emulated production screenshots. Task, Log, file, folder and Photo exact-byte Hide/Undo/Unhide checks all pass. The initial owner-Task baseline race is retained in the gate archive; commit 477ecd4a6 only shares the existing #1148 readiness wait. No fixture value or exact-byte expectation changed. The earlier 48 private-overlay screenshots bring this review to 198 attached images. The orchestrator reviews their visual quality.

State phone-light phone-dark tablet-light tablet-dark desktop-light desktop-dark
calendar-deep-link PNG PNG PNG PNG PNG PNG
calendar-hidden PNG PNG PNG PNG PNG PNG
calendar-hidden-off PNG PNG PNG PNG PNG PNG
calendar-unhidden PNG PNG PNG PNG PNG PNG
calendar-unhide-action PNG PNG PNG PNG PNG PNG
files-deep-link PNG PNG PNG PNG PNG PNG
files-hidden PNG PNG PNG PNG PNG PNG
files-hidden-off PNG PNG PNG PNG PNG PNG
files-unhidden PNG PNG PNG PNG PNG PNG
files-unhide-action PNG PNG PNG PNG PNG PNG
folders-deep-link PNG PNG PNG PNG PNG PNG
folders-hidden PNG PNG PNG PNG PNG PNG
folders-hidden-off PNG PNG PNG PNG PNG PNG
folders-unhidden PNG PNG PNG PNG PNG PNG
folders-unhide-action PNG PNG PNG PNG PNG PNG
photo-viewer-hidden PNG PNG PNG PNG PNG PNG
photos-hidden PNG PNG PNG PNG PNG PNG
photos-hidden-off PNG PNG PNG PNG PNG PNG
photos-unhidden PNG PNG PNG PNG PNG PNG
photos-unhide-action PNG PNG PNG PNG PNG PNG
tasks-deep-link PNG PNG PNG PNG PNG PNG
tasks-hidden PNG PNG PNG PNG PNG PNG
tasks-hidden-off PNG PNG PNG PNG PNG PNG
tasks-unhidden PNG PNG PNG PNG PNG PNG
tasks-unhide-action PNG PNG PNG PNG PNG PNG
Final item evidence for head `cf5f4f05fefc8f0fb0d291b5b12068254a7b0602`: 150 attached macOS-emulated production screenshots. Task, Log, file, folder and Photo exact-byte Hide/Undo/Unhide checks all pass. The initial owner-Task baseline race is retained in the gate archive; commit `477ecd4a6` only shares the existing #1148 readiness wait. No fixture value or exact-byte expectation changed. The earlier 48 private-overlay screenshots bring this review to 198 attached images. The orchestrator reviews their visual quality. | State | phone-light | phone-dark | tablet-light | tablet-dark | desktop-light | desktop-dark | | --- | --- | --- | --- | --- | --- | --- | | calendar-deep-link | [PNG](https://git.kayg.org/attachments/90f1d441-4593-4c32-b972-aef26910e105) | [PNG](https://git.kayg.org/attachments/5ee8befb-b1fd-4edb-a800-fdc95f38ffa9) | [PNG](https://git.kayg.org/attachments/2d3a287f-f037-4ca7-886d-9e8c76890e0c) | [PNG](https://git.kayg.org/attachments/75f19cfc-2b9c-4e23-8e90-adcff40bd39e) | [PNG](https://git.kayg.org/attachments/3604cfcd-ad55-4526-a5cb-c0b3da7685aa) | [PNG](https://git.kayg.org/attachments/4e8cce13-17c0-4e57-bca6-ba5fc8f383ce) | | calendar-hidden | [PNG](https://git.kayg.org/attachments/c38494bf-2ae7-456e-a719-9ef612f5bb8d) | [PNG](https://git.kayg.org/attachments/5a452948-764e-4e5b-a499-0c2458f462fb) | [PNG](https://git.kayg.org/attachments/f2f00a1b-6b55-4579-a500-1faa7bae6611) | [PNG](https://git.kayg.org/attachments/7f094d03-6cec-49cc-890e-9c5dbfffc9e3) | [PNG](https://git.kayg.org/attachments/ed19493c-3015-4fdd-8c1a-20da9d72efc3) | [PNG](https://git.kayg.org/attachments/9b1984d3-685d-43f1-b16a-336067072a2a) | | calendar-hidden-off | [PNG](https://git.kayg.org/attachments/1dd11d8d-6de4-4018-9dc7-3c19e0cfe193) | [PNG](https://git.kayg.org/attachments/a6baca8d-9007-480c-a81b-2b79e329b829) | [PNG](https://git.kayg.org/attachments/171f71da-1003-491d-9883-b72e61d5b969) | [PNG](https://git.kayg.org/attachments/3406cfd6-cb96-45cf-a6fa-e8629d72a573) | [PNG](https://git.kayg.org/attachments/e116ab97-8e25-49ad-8e93-964a5cd7143e) | [PNG](https://git.kayg.org/attachments/926652cf-b20c-416d-9257-d9c6c3766bab) | | calendar-unhidden | [PNG](https://git.kayg.org/attachments/5e59647a-da8b-48f8-84b7-947672eb294b) | [PNG](https://git.kayg.org/attachments/d58b77d7-1bca-4965-bce3-2907002052af) | [PNG](https://git.kayg.org/attachments/19de58e9-53b4-42e2-ad29-1a48f460fc38) | [PNG](https://git.kayg.org/attachments/855cfa8d-f39c-4586-b73e-067e528128b6) | [PNG](https://git.kayg.org/attachments/86420290-c851-44ba-a822-c67536f37007) | [PNG](https://git.kayg.org/attachments/c33eb0e7-b76a-4257-bd7a-d3709a1ecbc6) | | calendar-unhide-action | [PNG](https://git.kayg.org/attachments/5968caa8-d17b-4b70-a305-e099686d95dd) | [PNG](https://git.kayg.org/attachments/1efa8d75-4d3d-4aa1-b6fb-f654509e6ae8) | [PNG](https://git.kayg.org/attachments/572f5163-900d-4c52-a568-8c0fc21fd184) | [PNG](https://git.kayg.org/attachments/8db36610-3114-428b-8be8-3b250c0bd506) | [PNG](https://git.kayg.org/attachments/8fd89157-13cf-4f9f-a514-9e103d12a816) | [PNG](https://git.kayg.org/attachments/b668e7b0-4194-471d-ba8a-aaa056a38099) | | files-deep-link | [PNG](https://git.kayg.org/attachments/ff9d3fa8-2e99-42ec-adcc-7ca01dae3655) | [PNG](https://git.kayg.org/attachments/64ad9add-b8d1-4624-8b5e-29414a2faefa) | [PNG](https://git.kayg.org/attachments/54151276-5a41-4ea0-b4bc-a1972e000c42) | [PNG](https://git.kayg.org/attachments/84ded6bd-2f19-4c1d-87ed-2a58602fc733) | [PNG](https://git.kayg.org/attachments/65d7b530-4926-46f6-91ae-5b584f90221b) | [PNG](https://git.kayg.org/attachments/0b892b16-e60e-4df7-b97f-2465a70cf242) | | files-hidden | [PNG](https://git.kayg.org/attachments/abf68feb-8e44-4199-bc7c-eeb6386aeea5) | [PNG](https://git.kayg.org/attachments/9c16cbc0-bd9a-402a-9110-cfbbcf5ed7e7) | [PNG](https://git.kayg.org/attachments/c726eb89-8071-4da9-a455-a0e2cf0ca994) | [PNG](https://git.kayg.org/attachments/9de3add9-40c4-4db3-9767-e33c9df06e0f) | [PNG](https://git.kayg.org/attachments/e14c4b63-066b-4c09-81f9-ff0af214ac9b) | [PNG](https://git.kayg.org/attachments/135adddb-7c0d-4b4f-970b-89238e6769d8) | | files-hidden-off | [PNG](https://git.kayg.org/attachments/89c16ceb-349a-42e1-ab8f-fec0a4d3b398) | [PNG](https://git.kayg.org/attachments/fca07ade-f407-43ca-ac25-145daad4e71b) | [PNG](https://git.kayg.org/attachments/93772e45-e089-4ee2-b62e-4fc82a3b7db7) | [PNG](https://git.kayg.org/attachments/6398ed97-236b-4aa3-ac7d-96baee4f43a8) | [PNG](https://git.kayg.org/attachments/2f5981f2-9e9f-4efb-a553-1b9ddbc7e2a8) | [PNG](https://git.kayg.org/attachments/8e257c62-3a50-4603-abab-c8ca78d2b6ac) | | files-unhidden | [PNG](https://git.kayg.org/attachments/e69283de-3c7e-4d91-a7ea-9a1e8039deea) | [PNG](https://git.kayg.org/attachments/f936d5c9-f89e-469a-9919-acbce4c9c1cc) | [PNG](https://git.kayg.org/attachments/a0fc5d2a-d022-4d0a-bd93-262815d3db47) | [PNG](https://git.kayg.org/attachments/8c587b80-d35c-4242-895c-5fb74169e29e) | [PNG](https://git.kayg.org/attachments/f60320ff-4d0a-46cc-a070-fa9605188184) | [PNG](https://git.kayg.org/attachments/0bb5c144-a806-4de5-839d-88b61c1b83d6) | | files-unhide-action | [PNG](https://git.kayg.org/attachments/cf8a88dc-4885-4020-ab31-c37e72f0427c) | [PNG](https://git.kayg.org/attachments/ae696b04-4bb8-45cb-b5af-ab9debd819fb) | [PNG](https://git.kayg.org/attachments/0107a6fe-a879-4883-b065-7e70e5e066b0) | [PNG](https://git.kayg.org/attachments/1bda2d91-92a4-427f-9818-0e62bdf14ed7) | [PNG](https://git.kayg.org/attachments/86a18874-b691-4188-b1b4-90edc21ef130) | [PNG](https://git.kayg.org/attachments/bb6cae02-252d-448f-aea3-36d0687055b1) | | folders-deep-link | [PNG](https://git.kayg.org/attachments/5f97342b-aaa0-4e75-ba6e-1d8419228c62) | [PNG](https://git.kayg.org/attachments/64655bb3-969c-48a4-a1bc-97613a1b0ab4) | [PNG](https://git.kayg.org/attachments/505f469b-7c31-4d95-a636-3cb05e3d4bb3) | [PNG](https://git.kayg.org/attachments/b0491d1c-0708-4eae-95e1-812a6772368e) | [PNG](https://git.kayg.org/attachments/abbb7340-02c9-4199-b30b-e885d4440edd) | [PNG](https://git.kayg.org/attachments/1d00dabb-1d54-4b98-8cf5-49e48c9b65e6) | | folders-hidden | [PNG](https://git.kayg.org/attachments/e710a315-6273-42b9-96fc-16b80a31af3d) | [PNG](https://git.kayg.org/attachments/4c84eb13-403a-4307-9586-ffbb009df002) | [PNG](https://git.kayg.org/attachments/bed56619-7c28-4c7e-810b-b406d6585712) | [PNG](https://git.kayg.org/attachments/5de51758-cdc0-4500-83e5-a9f050bcde2f) | [PNG](https://git.kayg.org/attachments/3913325a-0bca-4f09-bf6a-5ce3585014d3) | [PNG](https://git.kayg.org/attachments/f8229dd0-be09-4df5-8b05-34cb2b35e588) | | folders-hidden-off | [PNG](https://git.kayg.org/attachments/627eadbb-3db9-4ab1-a0f5-cc9dcbe43a7a) | [PNG](https://git.kayg.org/attachments/2f074055-061e-4837-bcbf-19f799cc8f7a) | [PNG](https://git.kayg.org/attachments/7f74580d-ff07-4ef7-9407-d3292f4112c9) | [PNG](https://git.kayg.org/attachments/07435520-d28e-4b90-b659-ade9d8353bc0) | [PNG](https://git.kayg.org/attachments/4ff451eb-c745-43ed-b75e-7df74cd6a987) | [PNG](https://git.kayg.org/attachments/9944a7df-c790-46d3-a287-76afb091fdc2) | | folders-unhidden | [PNG](https://git.kayg.org/attachments/416eff81-f37a-44cc-b0bd-2f343dcb96b6) | [PNG](https://git.kayg.org/attachments/5d19e60d-e2e6-4755-99d4-6f1f56e7af15) | [PNG](https://git.kayg.org/attachments/b36e20ea-9ca3-4650-a85c-547c6d3488be) | [PNG](https://git.kayg.org/attachments/131f15b7-66e5-4b3a-9783-e92ad2118b59) | [PNG](https://git.kayg.org/attachments/9edd46c7-55c0-44ef-a9a2-9763bd44d4fc) | [PNG](https://git.kayg.org/attachments/c21bd36d-65ae-41fa-9764-bafc0261cf31) | | folders-unhide-action | [PNG](https://git.kayg.org/attachments/943808c4-b2e1-453f-bdc8-d4e0eb2e9990) | [PNG](https://git.kayg.org/attachments/2298f1b9-f121-47ca-ae52-5cbe8e3841d5) | [PNG](https://git.kayg.org/attachments/2f366af9-33c2-40ac-b27d-d7c48ce3ddb8) | [PNG](https://git.kayg.org/attachments/da98dae4-a46a-4ceb-aad1-f1a1446a81ea) | [PNG](https://git.kayg.org/attachments/2dbe8f05-af31-42ad-9ed1-00ab19c86d80) | [PNG](https://git.kayg.org/attachments/806962c0-8b65-4f81-8506-380320fd24a6) | | photo-viewer-hidden | [PNG](https://git.kayg.org/attachments/7f0a81e3-7e6a-44d9-8435-f4eed66b1402) | [PNG](https://git.kayg.org/attachments/8f0f08ee-f2f4-43bf-a039-e4a5f4f3429f) | [PNG](https://git.kayg.org/attachments/f5f12a41-f328-4562-b613-65dbe13221fe) | [PNG](https://git.kayg.org/attachments/46f1add5-b9b5-4feb-8acf-4d195ee72318) | [PNG](https://git.kayg.org/attachments/5778cd08-42c9-491b-9ff6-0fba4f9503c8) | [PNG](https://git.kayg.org/attachments/db9f4f1a-3f7f-4067-935f-91b4074ce8ef) | | photos-hidden | [PNG](https://git.kayg.org/attachments/96e09f9a-db20-4a77-bf97-fb042360e762) | [PNG](https://git.kayg.org/attachments/d53d6c8f-31a5-4281-894e-c5959c8ce345) | [PNG](https://git.kayg.org/attachments/591a48d7-57f9-4093-96e1-36ba39d78e24) | [PNG](https://git.kayg.org/attachments/f333307b-aa13-4920-8fd7-bde313594b36) | [PNG](https://git.kayg.org/attachments/0c7e72c4-d0b5-428b-a52e-769f0874511c) | [PNG](https://git.kayg.org/attachments/bdd27ef1-b9bc-4a9e-b528-023a6918a6e5) | | photos-hidden-off | [PNG](https://git.kayg.org/attachments/501176f3-6f5e-489d-b2ee-2df8eece337e) | [PNG](https://git.kayg.org/attachments/a05b1716-9b41-4ebf-85a9-33701311a99d) | [PNG](https://git.kayg.org/attachments/fc12adec-0919-495a-b8ab-8ca03a92f482) | [PNG](https://git.kayg.org/attachments/4a13f8ed-bc2a-4dfa-b7e7-65fc0c1b4aa4) | [PNG](https://git.kayg.org/attachments/6b9ea0f4-2456-477e-88d3-427bb9423b83) | [PNG](https://git.kayg.org/attachments/224a0c38-0650-4187-a0d5-9603a3aa987f) | | photos-unhidden | [PNG](https://git.kayg.org/attachments/b88a12be-e781-4393-b4d2-ba93898873bb) | [PNG](https://git.kayg.org/attachments/4ae77e8d-ec0a-4f25-bef6-74e1d8f2dce6) | [PNG](https://git.kayg.org/attachments/4ed42ce2-64b7-4d90-9b6b-0f018cd67866) | [PNG](https://git.kayg.org/attachments/6c3c3ea9-ae73-4d99-bce9-9d45658096df) | [PNG](https://git.kayg.org/attachments/052aafa2-30f5-4308-8beb-54b3a4a77c39) | [PNG](https://git.kayg.org/attachments/39c43b7f-2dd0-419a-91d8-2c5889302ee5) | | photos-unhide-action | [PNG](https://git.kayg.org/attachments/f0e975d6-4198-412d-8e68-3a8416ddbb34) | [PNG](https://git.kayg.org/attachments/fd356958-462b-4b5b-a244-b87295abac72) | [PNG](https://git.kayg.org/attachments/7b7f78d3-3ce3-4577-86e7-b70ac01cb8fc) | [PNG](https://git.kayg.org/attachments/13b1240b-c273-4b45-9f69-2b48e36e7f25) | [PNG](https://git.kayg.org/attachments/dbeef859-35a9-4590-847f-c1477f4899c5) | [PNG](https://git.kayg.org/attachments/4cc4626d-0791-4dd4-b7a0-7908da01fc36) | | tasks-deep-link | [PNG](https://git.kayg.org/attachments/5ed7c197-90fb-4ed6-a1e1-d03c39393540) | [PNG](https://git.kayg.org/attachments/24362e85-1b9f-4dd0-ac39-ef6c262373ad) | [PNG](https://git.kayg.org/attachments/44c71013-ca94-49ce-82b8-1981a222da26) | [PNG](https://git.kayg.org/attachments/b2e2fa92-3a67-4878-a7dd-890c04117634) | [PNG](https://git.kayg.org/attachments/f521d4f5-4e2b-44be-822d-3e4049a33afd) | [PNG](https://git.kayg.org/attachments/e6b06606-f9ad-4c65-b717-27601a497877) | | tasks-hidden | [PNG](https://git.kayg.org/attachments/fcb2b09f-6c62-4830-8832-febc8b796dff) | [PNG](https://git.kayg.org/attachments/2f983837-fbec-4f98-87aa-a21c8d8d1ca9) | [PNG](https://git.kayg.org/attachments/c9dcdcdf-f915-4bba-960b-c7ec1e8d8847) | [PNG](https://git.kayg.org/attachments/9de121e5-debb-4198-8005-84991d3aab7a) | [PNG](https://git.kayg.org/attachments/e2decf04-e76e-414f-8afa-3a70ec5b57eb) | [PNG](https://git.kayg.org/attachments/6cea86e7-a87a-4b58-90c6-77244725f302) | | tasks-hidden-off | [PNG](https://git.kayg.org/attachments/c885ff70-b2a2-454c-8dd1-9f5c9bd5d428) | [PNG](https://git.kayg.org/attachments/dce00f3e-03c1-4daf-8280-35f7a869e6e3) | [PNG](https://git.kayg.org/attachments/58e3ab47-149c-4ef5-ad5c-ac63e4ab6817) | [PNG](https://git.kayg.org/attachments/7ae2a579-93fc-42f0-915a-dbcb1fbe508b) | [PNG](https://git.kayg.org/attachments/c35219e5-a4f5-444e-9041-8b8b6cb3f6ba) | [PNG](https://git.kayg.org/attachments/0387064c-c2ae-4b30-9fd0-83cf7d42c2de) | | tasks-unhidden | [PNG](https://git.kayg.org/attachments/2c95f251-e5e9-48bb-83fa-b5924c13202a) | [PNG](https://git.kayg.org/attachments/3251e920-91fd-405e-b088-ecc77555b70d) | [PNG](https://git.kayg.org/attachments/5b312ad7-f02f-4f0d-a1c4-20903dcc0baa) | [PNG](https://git.kayg.org/attachments/802c5252-ed23-4293-81ce-c12cfb8e1464) | [PNG](https://git.kayg.org/attachments/4b3c1c06-0f1d-43c5-b69a-256d558cedbc) | [PNG](https://git.kayg.org/attachments/ef708930-3b56-4e50-8a16-90fa448c09c7) | | tasks-unhide-action | [PNG](https://git.kayg.org/attachments/759fd327-7aaa-48d8-ae86-db6fa6cd0bbc) | [PNG](https://git.kayg.org/attachments/910d8e1a-0768-483f-8e11-f720509b5565) | [PNG](https://git.kayg.org/attachments/ec68288c-0893-4848-9559-79d27c39ec46) | [PNG](https://git.kayg.org/attachments/74a33973-635c-47ba-a4a0-ea6423c8c71a) | [PNG](https://git.kayg.org/attachments/45978a46-b31c-4134-ace2-8ead5d3520ff) | [PNG](https://git.kayg.org/attachments/82bd315c-6f4e-4c38-b5f9-edc69c00f7eb) |
Commenting is not possible because the repository is archived.
No Branch/Tag specified
Branches Tags
dev
wip/cards2-1083
wip/cards-1083
wip/canvas-visual
wip/canvasvis2-976
wip/calhdr-1112
wip/blocks-1125
wip/allday-1107
wip/agenda-1086
wip/trayicons2-1095
wip/trayicons-1095
wip/sidebar3-1094
wip/previewcard-1098
wip/palette2-1123
wip/palette-1093
wip/nlpchip-1127
wip/mchrome-1084
wip/mailghost2-1094
wip/mailghost-1094
wip/kbpreview2-1118
wip/kbpreview-1118
wip/kanban-1092
wip/editreg-1132
wip/editorrail3-1113
wip/editorrail2-1113
wip/editorrail-1113
wip/draw4-1101
wip/draw3-1101
wip/draw2-1101
wip/draw-1101
wip/delete-1119
job/txentry-1198
job/rev1586
job/rev2-money-ident
job/rev2-webperf
job/morph-1104
job/previewcard-1098
job/importhang-1121
job/kanban-1092
job/merge-round-7b
job/merge-round-7c
job/calcards-1115
job/collabrev3-1197
job/e2e-b-1071
job/agenda-1086
job/agenda-decks
job/allday-1107
job/browserfix
job/calact9
job/adv7c-1105
wip/collabrev3-1197
wip/calcards-1115
wip/calact9
wip/calact10
wip/browserfix
wip/agenda-decks
wip/adv7c-1105
wip/txentry-1198
wip/rev2-webperf
wip/rev2-money-ident
wip/rev1586
wip/morph-1104
wip/merge-round-7c5
wip/merge-round-7c4
wip/merge-round-7c3
wip/merge-round-7c2
wip/merge-round-7c
wip/importhang-1121
wip/fix1586
wip/e2e-b2-1071
wip/e2e-b-1071
job/noncanon-1618
wip/noncanon-1618
job/edrevert-1616
job/partial-1605
wip/partial-1605
job/calact6
job/cold-1586
job/perfvm-1587
wip/cold-1586
job/cal404-1581
wip/calact6
wip/cal404-1581
job/dname-1584
wip/dname-1584
job/merge41
wip/merge41b
wip/merge41
job/rev1573c
job/hscroll-1579
wip/rev1573c
job/rev1573b
job/rev1573
wip/fix1573
wip/hscroll2
wip/hscroll-1579
job/rev1574
wip/fix1574
wip/rev1574
job/startup-1573c
job/merge40
wip/startup-1573d
wip/startup-1573c
job/calact5
wip/remtext2
wip/merge40c
wip/merge40b
wip/merge40
job/calact4
job/startup-1573
job/calprof
wip/calprof
wip/startup-1573
job/fs1575
job/fix1570
job/calact3
job/rec1540c
wip/fix1570
job/rev1570-review
wip/calact3
job/calact2
wip/calact2
job/calcold-1560
wip/calcold-1560
wip/rec1540c
job/fix1569
wip/fix1569
job/calact-1557
wip/calact-1557
job/remtext-1568
wip/remtext-1568
job/fix1566
wip/fix1566
job/rec1540b
job/reconcile-1540
job/money2rev
wip/money2rev
job/merge39
wip/merge39
wip/reconcile-1540
job/tabswitch2
job/merge38
wip/merge38
job/autherr-1553
wip/autherr-1553
job/money-688
wip/money688rev3
wip/money688rev2
wip/money688rev
wip/money688l
wip/money688k
wip/money688j
wip/money688i
wip/money688h
wip/money688g
wip/money688f
wip/money688e
wip/money688d
wip/money688c
wip/money688b
wip/money-688
wip/tabswitch2
wip/merge37
job/merge37
job/jobnames-1538
wip/jobnames-1538
job/tabcomp-perf
job/calscript-1492
wip/tabcomp-perf
wip/calscript-1492
job/mailbody-1533
wip/mailbody-1533
job/intlfmt-1461
job/merge36
wip/intlfmt2
wip/intlfmt-1461
wip/merge36
job/merge35c
job/tagperf-1186
wip/tagrev2
wip/tagrev
wip/tagperf4
wip/tagperf2-1186
wip/tagperf-1186
wip/tagfix5
wip/tagfix3
wip/tagfast2
wip/tagfast
wip/merge35c
job/notesel-1493
wip/notesel2
wip/notesel-1493
job/merge35b
wip/merge35b
wip/m35btriage
wip/m35bratchet
wip/calsel-1491
job/calsel-1491
job/notifread-1387
job/bulkwrite-1393
wip/notifread2
wip/notifread-1387
job/slowsel-1392
wip/bulkwrite-1393
wip/bulkrev4
wip/bulkrev3
wip/bulkrev2
wip/bulkrev
wip/bulkfix4
wip/bulkfix3
wip/bulkfix2
wip/bulkfix
job/mail7-1340
job/bigscroll-1481
job/searchperf-1425
wip/mailrev4
wip/mailrev3
wip/mailrev2
wip/mailrev
wip/mail7f
wip/mail7e
wip/mail7d
wip/searchperf2
wip/searchperf-1425
wip/mail7c
wip/mail7b
wip/mail7-1340
job/photoopen-1367
job/mailsel-1449
wip/bigscroll-1481
wip/slowsel3
wip/slowsel2
wip/slowsel-1392
wip/selroot
job/journaldup
wip/journaldup8
wip/journaldup7
wip/journaldup6
wip/journaldup5
wip/journaldup4
wip/journaldup3
wip/journaldup2
wip/journaldup
wip/jdrev5
wip/jdrev4
wip/jdrev3
wip/jdrev2
wip/jdrev
wip/jdfix9
job/bignote-1349
wip/mailsel-1449
wip/bignote3
wip/bignote2
wip/bignote-1349
job/statusmark-1457
wip/statusmark-1457
wip/photoopen4
wip/photoopen3
wip/photoopen2
wip/photoopen-1367
job/authflash-1473
job/merge35
wip/authflash-1473
job/phototags-1370
wip/phototags-1370
wip/merge35
wip/m35triage
job/tick-1446
wip/tick-1446
job/restartidx-1450
job/exmove-1333
job/coldnote-1451
wip/restartidx-1450
wip/exmove-1333
wip/coldnote-1451
job/undo412-1430
wip/undo412-1430
job/calwrite-1441
job/xcancel-1443
job/calscroll-1362
wip/xcancel-1443
wip/calwrite-1441
job/xsub-1445
wip/calscroll3
wip/calscroll2
wip/calscroll-1362
wip/xsub-1445
job/linkdup-1440
wip/linkdup2
wip/linkdup-1440
wip/tabswitch4
wip/tabswitch3
wip/tabswitch-1233
wip/navrev
job/tabswitch-1233
job/mdpaste-1431
job/taskundo-1433
job/directory-1199
wip/taskundo-1433
job/remind-1432
job/nfd-1411
wip/remind-1432
wip/dirfix4
wip/dirfix3
wip/dirfix2
wip/dirfix-1199
wip/directory-1199-r
wip/directory-1199
job/readerx-1427
wip/readerx-1427
job/scrollfade-1416
job/tipphone-1439
wip/nfd-1411
job/purge-1420
job/notifrow-1414
wip/purge-1420
wip/notifrow-1414
job/slop-1385
wip/slop2
wip/slop-1385
job/tbover-1409
job/qltitle-1408
job/grantlive-1405
job/taskclick-1434
wip/tbover-1409
wip/taskclick-1434
wip/qltitle-1408
job/scrub-1422
job/hotfix35
job/ticks-1361
wip/scrub-1422
job/taskprev-1401
wip/grantlive-1405
job/ghost-1323
wip/ticks3
wip/ticks2
wip/ticks-1361
wip/taskprev-1401
job/bash3-settings
wip/ghost-1323
job/mailmorph-1368
wip/bash3-settings
job/apiaudit-1374
wip/bash3-filesphotos
job/bash3-filesphotos
job/xuser39-1402
job/bash3-money
job/mailhtml-1372
wip/mailhtml2
wip/mailhtml-1372
job/bash3-interop
job/bash3-calendar
wip/bash3-money
wip/bash3-interop
wip/bash3-calendar
wip/mailmorph2
wip/mailmorph-1368
wip/bash3-tasks
job/outro-1391
job/linkpick-1379
job/linkdel-1384
wip/linkpick2
wip/linkpick-1379
wip/linkdel3
wip/linkdel2
wip/linkdel-1384
job/mailrows-1390
wip/mailrows-1390
wip/apiaudit2
wip/apiaudit-1374
job/bash-core
wip/outro-1391
wip/bash-core2
wip/bash-core
job/bash3-notes
job/bash3-tasks
job/merge34
job/notifdel-1363
wip/merge34
wip/notifdel2
wip/notifdel-1363
job/wklink-1371
wip/wklink-1371
job/searchbar-1360
wip/searchbar2
wip/searchbar-1360
job/merge33-1122
wip/merge33c
wip/merge33b
wip/merge33-1122
job/bash-security
job/mailglass-1373
wip/bash-security2
wip/bash-security
wip/mailglass-1373
job/instaudit-1369
wip/instaudit-1369
job/tabstorm-1338
wip/tabstorm2
wip/tabstorm-1338
wip/bash-files2
wip/bash-files
job/bash-files
job/bash-money
job/editfuzz-1335
wip/bash-money
wip/moneyrev
job/tasksperf-1286
wip/tasksperf3
wip/tasksperf2
wip/tasksperf-1286
wip/editfuzz2
wip/editfuzz-1335
review/dirrev-1199
job/merge32
wip/merge32b
wip/merge32
job/bash-chrome
job/tagdnd-1187
job/bash-notes
wip/bash-notes2
wip/bash-notes
wip/bash-chrome
wip/reconcile-c1
wip/adv-c1
wip/tagdnd2-1187
wip/tagdnd-1187
job/bash-calendar
job/deploy-c1
job/editbreak-1334
job/bash-perf
wip/bash-calendar2
wip/bash-calendar
wip/bash-perf
job/hunt-20261006
job/bash-interop
job/collabloss-1197
wip/collabrev-1197
wip/collabloss5-1197
wip/collabloss4-1197
wip/collabloss3-1197
wip/collabloss2-1197
wip/collabloss-1197
wip/bash-interop
job/bash-mail
wip/bash-mail
job/vis-1293
wip/vis-1293
wip/restyle-search-r
wip/restyle-search-fix2
wip/restyle-search-fix
wip/restyle-search
job/restyle-settings
job/restyle-search
wip/restyle-settings-fix
wip/restyle-settings
job/adv31
wip/advfix-a
wip/adv31
job/bash-tasks
wip/bash-tasks
job/restyle-files
wip/restyle-files-fix
wip/restyle-files
job/fmtbar-1210
wip/fmtbar2-1210
wip/fmtbar-1210
job/perf2-1124
wip/perf2-1124
job/proflog-1204
job/merge31
wip/restyle-notes
wip/merge31
wip/proflog-1204
job/restyle-notes
job/fix-1213
wip/fix-1213
job/hide-1153
job/restyle-mailmoney
job/notestatus-1209
wip/hide-1153
wip/hiderev2-1153
wip/hiderev-1153
wip/hide5-1153
wip/hide4-1153
wip/hide3-1153
wip/hide2-1153
job/sidebarblur-1208
wip/notestatus-1209
wip/sidebarblur-1208
wip/restyle-mailmoney
job/onboard-1141
wip/onboard2-1141
wip/onboard-1141.aborted-early
wip/onboard-1141
job/adv-1202
job/segmented-1200
wip/segmented-1200
job/merge30
job/notifloop-1194
job/toastmorph-1201
wip/notifloop-1194
job/perf-1124
job/tocrail-1191
job/cards-1179
wip/cards2-1179
wip/cards-1179
wip/tocrail-1191
wip/perf-1124
wip/merge30j
job/wizchoices-1140
wip/wizchoices-1140
wip/restyle-1190
job/moneyfmt-1180
wip/moneyfmt2-1180
wip/moneyfmt-1180-r
wip/moneyfmt-1180
job/pillglass-1189
job/flags-1181
wip/flags-1181
job/restyle-1190
job/settingsreg-1195
job/wizard-1140
site/website
wip/wizardrev2-1140
wip/wizardrev-1140
wip/wizard5-1140
wip/wizard4-1140
wip/wizard3-1140
wip/wizard2-1140
wip/wizard-1140
wip/pillglass-1189
wip/settingsreg-1195
job/merge29
job/fu-1171
wip/merge29j
wip/fu-1171
job/fu-1166
job/txresearch-1188
wip/fu-1166
job/merge28
job/search-1066
wip/search-1066
wip/merge28j
job/gateslot-1182
job/bulkimport-1157
job/mailnet-1160
wip/mailnetrev-1160
wip/mailnet-1160
wip/bulkrev-1157
wip/bulkimport-1157
job/startup-1161
wip/startup-1161
job/merge27
job/linkcards-1151
wip/linkcards3-1151
wip/linkcards2-1151
wip/linkcards-1151
job/traydate-1144
wip/traydate3-1144
wip/traydate2-1144
wip/traydate-1144
job/draw-1101
wip/merge27j
job/blockpill-1152
wip/blockpill3-1152
wip/blockpill2-1152
wip/blockpill-1152
job/minihover-1149
wip/minihover2-1149
wip/minihover-1149
job/merge25
wip/merge25-r
wip/merge25b
wip/merge25
job/inspector-1129
job/tags-1110
wip/inspector3-1129
wip/inspector2-1129
wip/inspector-1129
wip/tagsrev-1110
wip/tags2-1110
wip/tags-1110
job/dates-1148
wip/datesrev-1148
wip/dates2-1148
wip/dates-1148
job/licence-1145
wip/licence2-1145
wip/licence-1145
job/selfhost-1156
fixbatch-25
job/merge23
wip/merge23
job/tagfilter-1109
wip/tagfilter2-1109
wip/tagfilter-1109
job/kbd-1134
wip/kbd2-1134
wip/kbd-1134
job/palfoot-1137
wip/selfhost-1156
wip/palfoot2-1137
wip/palfoot-1137
job/toggle-1158
wip/toggle-1158
fixbatch-23
job/kbpreview-1118
job/docratchet-1155
job/perflint-1133
job/devtests-1159
wip/docratchet-1155
wip/devtests-1159
job/segv-1136
wip/toast-1142
wip/segv-1136
job/toast-1142
job/blockreload-1147
wip/blockreload-1147
job/font-1150
wip/font-1150
job/importui-1120
job/minimonth-1149
wip/importui-1120
wip/minimonth-1149
job/depcheck-1146
wip/perflint-1133
wip/depcheck-1146
job/blocks-1125
job/plus-1128
job/shift-1138
wip/plus2-1128
wip/plus-1128
wip/shift-1138
job/moneyfid-1130
job/editorrail-1113
wip/moneyrev-1130
wip/moneyfid-1130
job/noext-851
wip/noext-851
wip/noext3-851
wip/noext2-851
job/week-1135
wip/week-1135
job/editreg-1132
job/smoke-1122
wip/smoke-1122
job/docs-1143
job/palette2-1123
job/calhdr-1112
job/nlpchip-1127
job/mailghost-1094
job/reconnect-1131
wip/reconnect-1131
job/trayicons-1095
job/delete-1119
hotfix-sidebar2
job/cards-1083
job/palette-1093
job/mchrome-1084
job/e2e-a-1071
job/canvas-visual
wip/e2e-a2-1071
wip/e2e-a-1071
backup/canvas-visual-before-reconcile
wip/surfaces-p2
job/merge-round-9
wip/merge-round-9
job/7cfix-small
wip/7cfix-small
job/mailui-1078
job/merge-round-8
wip/merge-round-8
wip/mailui-1078
job/mailround-1038
job/applemail-accept
wip/settitle-1068
wip/mailround2-1038
wip/mailround-1038
wip/e2e-7b
job/crash-1069
wip/crash-1069
job/searchlost-1066
wip/searchlost-1066
job/7b-reconcile
job/flake-1065
wip/flake-1065
wip/merge-round-7b7
wip/merge-round-7b6
wip/merge-round-7b5
wip/merge-round-7b4
wip/7b-reconcile
job/appupdate-1059
job/nfd-1044
wip/appupdate-1059
job/e2e-7b
job/loop-1062
wip/loop-1062
job/pdfprev-1045
job/invtoggle-1053
wip/pdfprev-1045
wip/nfd-1044
wip/invtoggle-1053
job/7bfix-e2e
job/mailstress-b
wip/7bfix-e2e
wip/mailstress-b
job/7bfix-adv
wip/7bfix-adv
job/mailstress-a
job/stack-1054
wip/stack-1054
wip/mailstress-a
job/mailstress-1038
wip/mailstress-1038
job/upload500-1051
wip/upload500-1051
job/share-1034
wip/share-1034
job/syncerr-1037
job/7bfix-photos
wip/7bfix-photos
job/paste-1036
job/setside-1039
wip/setside-1039
wip/paste-1036
job/lease-1042
wip/syncerr-1037
wip/lease-1042
job/7bfix-data
job/passkeybind-1043
wip/apprevoke-1041
job/invite-1035
wip/invite-1035
job/merge-round-7b2
wip/merge-round-7b2
job/mailproxy-486
job/apprevoke-1041
job/rebuild-1033
job/pillborder-1029
wip/pillborder-1029
wip/mailproxy-486
wip/applemail-486
job/headless-998
wip/headless-998
job/groups-1028
wip/groups-1028
job/rebuildwarn-1016
wip/rebuildwarn-1016
job/startup-1011
wip/startup-1011
job/monthpill-1009
job/bgthumb-1025
job/sharetitle-1012
wip/monthpill-1009
wip/bgthumb-1025
wip/sharetitle-1012
job/canvas-cards-977
wip/canvas-cards-977
job/canvas-pencil-978
job/canvas-sketch-990
wip/canvas-sketch-990
wip/canvas-pencil-978
job/canvas-files-989
wip/canvas-files-989
job/canvas-collab-991
wip/canvas-collab-991
job/weekscroll-1018
wip/weekscroll-1018
wip/canvas-core-976
job/canvas-core-976
job/round-drag
wip/round-drag
job/round-settings
wip/oapi-974
job/oapi-974
job/hist2-integrate
job/mailhtml-726
wip/mailhtml-726
wip/hist2-integrate
job/moneyfu-984
job/drag-1015
wip/drag-1015
job/rename-1017
wip/rename-1017
job/hist2-api
wip/hist2-api
job/oneacct-1014
wip/oneacct-1014
wip/moneyfu-984
job/hist2-bench
job/hist2-restore
wip/hist2-bench
job/hist2-write
job/hotfix-724
wip/hotfix-724
wip/hist2-write
wip/hist2-restore
job/hist2-store
job/hist2-ui
wip/hist2-ui
wip/hist2-store
job/searchstarve-965
job/shutdown-963
wip/shutdown-963
wip/pubedit-981
job/pubedit-981
job/analytics-973
wip/searchstarve-965
job/authflash-850
job/weeklane-969
job/pvtitle-1004
job/hist-975
wip/authflash-850
job/voicepill-617
wip/pvtitle-1004
job/headring-1003
wip/weeklane-969
wip/voicepill-617
wip/headring-1003
wip/analytics-973
job/agentscope-980
wip/thumbsandbox-988
job/thumbsandbox-988
wip/hist-975
job/links-856
wip/links-856
job/davetag-966
wip/davetag-966
job/filesstorm-1000
job/hoverpad-725
wip/filesstorm-1000
job/ffmpegblas-993
job/merge-round-7a
wip/hoverpad-725
wip/ffmpegblas-993
job/nowdot-1002
wip/verify-7a
job/noteid-857
wip/nowdot-1002
wip/noteid-857
wip/merge-round-7a
wip/agentscope-980
job/imapedge
job/a11yfix2
wip/imapedge-941
wip/imapedge
wip/a11yfix2
job/notetask-986
job/logheading
wip/logheading-998
job/textthumb-652
job/photolive-987
wip/photolive-987
job/davactive-983
job/savefix-985
job/tabicons-607
wip/davactive-983
wip/tabicons-607
wip/notetask-986
wip/savefix-985
job/dirid-627
job/buildspeed-1007
wip/dirid-627
job/staging-imap
job/perfguards-impl
job/undo-a11y
wip/undo-a11y
job/mailperf
job/wal-824
wip/settings-50
job/settings-50
job/notesfilter-606
wip/notesfilter-606
job/surfaces-p2
wip/wal-824
job/maillayouts
wip/mailperf
wip/maillayouts
job/taskmeta-659
job/money-ident
wip/money-ident
wip/taskmeta-659
job/errstates
wip/perfguards-impl
job/headings-881
wip/headings-881
wip/errstates
job/voice-619
job/gaps-827
job/notesperf
wip/notesperf
wip/voice-619
job/hddsql-549
job/perf-stream-668
wip/perf-stream-668
wip/deeplinks-fix
job/deeplinks-fix
job/authfix
job/docsfix-rust
wip/docsfix-rust
job/webperf
job/docsfix-web
job/datafix2
job/webdav-lock-476
job/copyfix
wip/copyfix
wip/webperf
job/focus-658
wip/protofix
job/mediafix
job/protofix
wip/mediafix
job/agentfix
job/hhmm-724
wip/agentfix
job/undo-722
job/reuse
wip/webdav-lock-476
wip/reuse
job/scopefix
job/datafix
wip/hhmm-724
wip/undo-722
job/surfaces-p1
wip/hddsql-549
job/voicememos-618
wip/datafix2
wip/surfaces-p1
job/fix-940
wip/fix-940
job/blaze-surfaces
wip/datafix
wip/blaze-surfaces
job/taskday-655
job/linknav-639
wip/linknav-639
wip/gaps-827
job/isolation-707
job/audiophotos-720
wip/audiophotos-720
job/advfind-664
wip/voicememos-618
wip/taskday-655
wip/isolation-707
wip/advfind-664
wip/scopefix
wip/focus-658
job/testgaps
wip/testgaps
job/overscroll-718
wip/authfix
job/deps
wip/overscroll-718
job/rev2-agentfix
job/rev2-mailperf
wip/deps
job/hardening-728
wip/hardening-728
job/searchgen-832
wip/searchgen-832
job/photopw-849
job/mailsql-825
wip/photopw-849
job/sharefix
wip/sharefix
job/rev2-mailhtml-726
job/rev2-perfguards
job/copyval-723
job/lightglass-r2
wip/lightglass-r2
wip/docsfix-web
job/copy-audit
job/macinterop-staging-r2
job/design-sync
job/rev2-taskmeta-659
job/docs-audit
job/rev2-advfind-664
job/rev2-mailproxy-486
job/states-audit
job/rev2-datafix
job/design-drift
job/test-gaps
job/rev2-voicememos-618
job/rev2-mediafix
job/rev2-deps
job/rev2-datafix2
job/licence-audit
job/issue-hygiene
job/rev2-protofix
job/rev2-voice-619
job/rev2-isolation-707
job/rev2-surfaces-p1
job/deeplink-audit2
job/rev2-audiophotos-720
wip/test-gaps
job/rev2-overscroll-718
job/rev2-undo-722
wip/states-audit
job/rev2-dropmd-719
job/rev2-linknav-639
job/merge-7b-plan
wip/merge-7b-plan
job/rev2-taskday-655
wip/mailsql-825
job/rev2-webdav-lock-476
job/rev2-browserfix
wip/design-drift
job/rev2-hddsql-549
wip/deeplink-audit2
job/rev2-scopefix
job/rev2-authfix
job/rev2-hardening-728
job/rev2-wal-824
job/rev2-sharefix
job/calsidebar-638
job/chrome-audit
job/ioperf
wip/ioperf
wip/chrome-audit
wip/calsidebar-638
job/dropmd-719
wip/dropmd-719
job/ocr-build
wip/ocr-build
job/blaze-settings
wip/copyval-723
job/toastring-721
wip/toastring-721
job/deployfix-732
wip/deployfix-732
wip/blaze-settings
job/money-import-recheck
job/rev-a11y
job/perf-arch-db
job/rev-7b-data
wip/textthumb-652
wip/perf-arch-db
job/sec-protocols
job/sidehdr-660
job/rev-7b-security
job/research-surfaces
job/rev-design-gaps
job/rev-mcp-api
wip/sidehdr-660
job/perf-arch-memory
wip/sec-protocols
job/perf-arch-bundle
job/snapedge-714
wip/rev-mcp-api
job/sec-supplychain
wip/research-surfaces
job/perf-arch-sync
job/rev-consistency
job/perf-arch-server
wip/perf-arch-server
wip/perf-arch-memory
job/perf-arch-io
job/perf-arch-client
job/sec-fs
job/sec-mcp-scopes
job/sec-sharing
job/perf-guards
job/sec-browser
job/sec-admin-deploy
job/sec-auth
wip/snapedge-714
job/bgpicker-717
wip/perf-arch-bundle
wip/money-import-recheck
job/advsetup-654
wip/bgpicker-717
wip/advsetup-654
job/burst-709
job/kbdcaps-710
job/app-pw-chooser
wip/burst-709
wip/app-pw-chooser
job/imaptest-625
wip/kbdcaps-710
job/fix-499
wip/fix-499
job/perf-mut-667
job/calimg-589
job/perf-snap-666
wip/calimg-589
wip/perf-snap-666
wip/perf-mut-667
job/perf-cache-665
wip/perf-cache-665
job/voicefiles-620
wip/voicefiles-620
job/admin-burst-705
wip/admin-burst-705
job/voicememos-review
wip/voicememos-review
wip/ryw-653
job/ryw-653
job/writeonopen-661
job/instant-663
wip/writeonopen-661
job/money-import-review
wip/money-import-review
wip/importjs-610
review/integrations-407-round6
wip/integrations-review
job/dragghost-612
wip/dragghost-612
job/integrations
wip/integrations
job/decider-656
job/merge-round-6
job/perf-rerun
wip/merge-round-6
job/integrations-review-round5
job/selalign-576
wip/selalign-576
job/mcp-events-491
job/files-631
job/cal-e2e-569
wip/cal-e2e-569
job/reload-423
wip/reload-423
wip/mcp-events-491
wip/files-631
job/notesbridge-644
wip/notesbridge-644
job/editor-series
job/calcard-series
wip/calcard-series
job/mcp-events-review-491
wip/mcp-events-review
wip/editor-series
job/quirks-546
job/integrations-recheck
job/tocrail-636
wip/tocrail-636
wip/quirks-546
wip/reminders-643
job/reminders-643
wip/davscale-573
job/davscale-573
job/integrations-review
wip/ocr-eval-584
job/ocr-eval-584
job/esc-537
wip/esc-537
job/toastname-586
wip/toastname-586
job/submenu-579
wip/submenu-579
job/tasks-mode
wip/tasks-mode
job/agentdocs-630
job/dupwrite-634
wip/agentdocs-630
wip/dupwrite-634
job/lightglass-588
wip/lightglass-588
job/tabswitch-549
job/ghosttask-623
wip/ghosttask-623
job/toaststack-616
job/weekstate-609
job/mailsync-613
wip/mailsync-613
wip/weekstate-609
job/maildup-626
wip/tabswitch-549
wip/maildup-626
wip/toaststack-616
job/motion-611
wip/motion-611
job/tlstest-601
wip/tlstest-601
job/perf-495
job/floating-sheet
wip/floating-sheet
job/remdup-585
wip/remdup-585
job/fix-502
wip/fix-502
job/attachplay-622
job/perf-batch
wip/perf-batch-563
wip/perf-495
hotfix/mail-sync-diag
job/mail-m3
wip/mail-m3
job/attach-poof-603
job/calhover-608
job/editorbar-604
job/mentions-605
job/merge-round-4
job/allday-514
wip/merge-round-4
wip/allday-514
job/merge-round-4a
wip/merge-round-4a
job/sharestack-580
job/fix-501
wip/sharestack-580
wip/fix-501
job/perf-batch-563
job/theme-detail
job/apw-cache-review
wip/apw-cache-review
job/probe-520
wip/probe-520
job/mac-393
wip/mac-393
job/header-571
job/flake-513
wip/flake-513
job/docs-thumb-547
wip/header-571
job/webcal-572
wip/webcal-572
wip/shortcuts-542
job/shortcuts-542
wip/docs-thumb-547
job/caldav-stress
wip/caldav-stress
wip/sweep-478
job/apw-cache-512
wip/apw-cache-512
job/money-empty-540
wip/restart-505
wip/money-empty-540
wip/fix-510
job/restart-505
job/fix-503
job/perf-496
wip/perf-496
job/fix-498
wip/fix-498
job/info-inspector-465
wip/info-inspector-465
job/fix-510
job/fix-507
wip/fix-507
wip/fix-503
job/fix-493
job/money-kinds
wip/money-kinds
job/hygiene-548
job/merge-round-3
wip/fix-493
job/drag-snap-536
wip/merge-round-3
wip/merge-round-0930
wip/drag-snap-536
job/align-538
wip/align-538
job/bg-flash
wip/bg-flash
job/money-import
job/search-count-544
wip/search-count-544
wip/money-import
job/settings-key-541
wip/settings-key-541
job/toast-539
job/preview-421
wip/preview-421
wip/toast-539
job/tasks-500-531
job/title-plain-526
wip/title-plain-526
wip/tasks-500-531
job/notes-bridge
wip/parity-484
job/parity-484
job/files-slow
job/crash-525
wip/notes-bridge
wip/files-slow
wip/crash-525
job/kbd-motion-527
wip/bg-422
job/analytics-504
wip/analytics-504
wip/kbd-motion-527
job/upload-pill-523
wip/upload-pill-523
wip/tray-order
job/tray-order
wip/overflow-mid
wip/merge-round-2
job/perf-494
wip/perf-494
job/merge-round-3-pre-rebuild
wip/mcp-fast-492
wip/motion-477
wip/asr-ab-489
wip/theme-variants-506
wip/overflow-511
wip/week-header-508
wip/attach-427
job/dav-delete-471
job/iso-435
wip/iso-435
wip/files-sel-keys
wip/dav-delete-471
job/align-253
job/siwc-490
wip/siwc-490
job/money-kinds-review
wip/align-253
wip/money-kinds-review
job/small-bugs-3
wip/overlay-title-487
wip/multiget-500
wip/hidden-420
wip/webcal-ui
wip/webcal-431
job/perf-367
job/location
wip/small-bugs-3
wip/location
wip/perf-367
wip/admin-deny-483
job/tag-unicode-473
wip/tag-unicode-473
job/blur-436
wip/photos-470
wip/blur-436
wip/small-bugs-4
wip/hunt-20260930
wip/settings-hdr-482
wip/chips-416
job/dedup-375
wip/dedup-375
job/doc-stack
wip/doc-stack
job/tokens-literals
wip/tokens-literals
job/jobs-leftovers
wip/send-fast
wip/paste-467
wip/money-numbers
job/money-plugin
wip/money-plugin
backup/doc-stack-r3-reset-source
job/break-dav
wip/merge-batch
wip/crossday-469
wip/mac-verify
wip/mail-m2
wip/break-dav
wip/money-review2
job/money-md
job/modes-424
wip/money-md
wip/jobs-leftovers
job/agenda-413
wip/agenda-413
job/dedup-375-clean
job/dedup-375-before-rebase
wip/modes-424
job/recog-417
wip/recog-417
wip/bounce-425
wip/ab-384-luna
backup/doc-stack-round3-before-rebuild
job/webdav-perf
wip/webdav-perf
job/toast-ring
wip/toast-ring
job/money-review
wip/money-review
wip/micro-motion
wip/settings-card
wip/minical
job/notes-imap-428
job/least-priv
wip/ui-small-2
wip/flaky-426
wip/drag-end-418
job/jank
wip/jank
wip/least-priv
wip/docs-site
job/agenda
job/sec-batch
wip/sec-batch
wip/per-user-index
job/area-calendars
wip/area-calendars
job/parity
wip/parity
job/documents-research
wip/documents-research
job/test-infra
job/reminders-sync
wip/small-bugs-2
wip/reminders-sync
wip/gestures
job/google-oauth
wip/tags-merge
wip/tags
job/e2e-theme
wip/e2e-theme
job/icon-align
wip/test-infra
wip/select-align
wip/editor-385
job/voice
wip/webdav
job/webdav
job/app-pw-ui
job/editor-integrity
wip/editor-integrity
wip/voice
wip/quota
wip/cal-followups
wip/icon-align
job/composer-scale
wip/composer-scale
job/jobs-page
wip/jobs-page
job/hig-type
wip/hig-type
wip/app-pw-ui
job/motion-spring
job/mcp
wip/motion-spring
wip/mcp
job/small-bugs
wip/push-hosts
job/profile-sign
wip/touch-369
wip/profile-sign
job/mobile-focus
wip/mobile-focus
wip/ui-polish-354
wip/small-bugs
wip/dup-task
job/toast-polish
job/app-pw-scopes
wip/toast-polish
wip/app-pw-scopes
wip/cli-agent
wip/selection-pills
job/preview-attach
wip/preview-attach
job/dav-proppatch
wip/dav-proppatch
wip/cal-switcher
job/atomic-race
wip/atomic-race
job/photos-shared
wip/photos-shared
wip/cal-grid
wip/note-rewrite
wip/search-rebuild
job/mail-m1
job/paperless-import
wip/paperless-import
wip/mail-m1
wip/hidden-activity
wip/search-d
wip/pricing-research
wip/cursors
wip/auto-scheme
job/single-pills
wip/single-pills
wip/xuser-matrix
wip/money-format
wip/app-pw-setup
wip/purge-dos
wip/vault-health
wip/caldav-apple
wip/xuser-audit
wip/e2e-green
wip/tabbar
wip/adv-harness
wip/maple-mono
job/search-fix
wip/search-fix
wip/search-perf-c
job/adv-harness
wip/sidebar-headers
job/glass
wip/temp-index
job/polish
wip/polish
wip/file-protocols
wip/money-research
wip/glass
wip/voice-models
wip/collab-redo
job/voice-research
wip/hunt-20260928
wip/notes-actions-research
wip/search-pad
wip/search-perf
wip/search-sticky
wip/editor-undo
wip/chrome-rules
wip/motion
wip/appearance-research
wip/appearance
wip/audit-bugs
wip/cal-glass
wip/block-actions
wip/authz-order
wip/event-stripes
wip/chrome-sidebar
wip/auth-flaky
wip/robust-2
wip/gate-fix
wip/menu-blur
wip/import-calternaljs
wip/tray-fix
job/import-calternaljs
wip/index-order
wip/audit-fixes
wip/search-chevrons
research/mail
wip/phone-chrome
wip/dedup-break
wip/csp
wip/ui-audit
wip/select-toast
wip/perf
wip/flat-layout
wip/fonts
wip/event-tint
wip/sync-converge
wip/data-split
wip/glass-audit
wip/robustness
wip/sync-chaos
wip/search-thumbs
wip/fuzz
wip/menu-icons
wip/search-pill
wip/sync-changing
wip/heading-links
wip/date-formats
wip/a11y
wip/break-editor
wip/e2e-fix
wip/settings-sections
wip/sync-root-guard
wip/search-palette
wip/share-edit
job/toasts
wip/toasts
wip/cont-analytics
wip/authz-review
wip/popovers
wip/overlay-glass
wip/change-feed
wip/editor-modes
wip/composer-align
wip/cont-agenda
wip/agenda-merge
job/agent-conventions
wip/agent-conventions
wip/backend-misc
job/route-audit
wip/route-audit
wip/ui-batch
wip/heif-hardening
wip/grid-resize
wip/ask-page
wip/webmcp
job/deeplink-audit
wip/deeplinks
wip/shortcuts
wip/cont-tz-days
main
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kayg/calternal-v0#1153
No description provided.