Audit: remove local restyling of shared components and hand-rolled controls app-wide #1190
Open
opened 2026-10-06 08:07:40 +00:00 by kayg
·
102 comments
No Branch/Tag specified
dev
wip/cards2-1083
wip/cards-1083
wip/canvas-visual
wip/canvasvis2-976
wip/calhdr-1112
wip/blocks-1125
wip/allday-1107
wip/agenda-1086
wip/trayicons2-1095
wip/trayicons-1095
wip/sidebar3-1094
wip/previewcard-1098
wip/palette2-1123
wip/palette-1093
wip/nlpchip-1127
wip/mchrome-1084
wip/mailghost2-1094
wip/mailghost-1094
wip/kbpreview2-1118
wip/kbpreview-1118
wip/kanban-1092
wip/editreg-1132
wip/editorrail3-1113
wip/editorrail2-1113
wip/editorrail-1113
wip/draw4-1101
wip/draw3-1101
wip/draw2-1101
wip/draw-1101
wip/delete-1119
job/txentry-1198
job/rev1586
job/rev2-money-ident
job/rev2-webperf
job/morph-1104
job/previewcard-1098
job/importhang-1121
job/kanban-1092
job/merge-round-7b
job/merge-round-7c
job/calcards-1115
job/collabrev3-1197
job/e2e-b-1071
job/agenda-1086
job/agenda-decks
job/allday-1107
job/browserfix
job/calact9
job/adv7c-1105
wip/collabrev3-1197
wip/calcards-1115
wip/calact9
wip/calact10
wip/browserfix
wip/agenda-decks
wip/adv7c-1105
wip/txentry-1198
wip/rev2-webperf
wip/rev2-money-ident
wip/rev1586
wip/morph-1104
wip/merge-round-7c5
wip/merge-round-7c4
wip/merge-round-7c3
wip/merge-round-7c2
wip/merge-round-7c
wip/importhang-1121
wip/fix1586
wip/e2e-b2-1071
wip/e2e-b-1071
job/noncanon-1618
wip/noncanon-1618
job/edrevert-1616
job/partial-1605
wip/partial-1605
job/calact6
job/cold-1586
job/perfvm-1587
wip/cold-1586
job/cal404-1581
wip/calact6
wip/cal404-1581
job/dname-1584
wip/dname-1584
job/merge41
wip/merge41b
wip/merge41
job/rev1573c
job/hscroll-1579
wip/rev1573c
job/rev1573b
job/rev1573
wip/fix1573
wip/hscroll2
wip/hscroll-1579
job/rev1574
wip/fix1574
wip/rev1574
job/startup-1573c
job/merge40
wip/startup-1573d
wip/startup-1573c
job/calact5
wip/remtext2
wip/merge40c
wip/merge40b
wip/merge40
job/calact4
job/startup-1573
job/calprof
wip/calprof
wip/startup-1573
job/fs1575
job/fix1570
job/calact3
job/rec1540c
wip/fix1570
job/rev1570-review
wip/calact3
job/calact2
wip/calact2
job/calcold-1560
wip/calcold-1560
wip/rec1540c
job/fix1569
wip/fix1569
job/calact-1557
wip/calact-1557
job/remtext-1568
wip/remtext-1568
job/fix1566
wip/fix1566
job/rec1540b
job/reconcile-1540
job/money2rev
wip/money2rev
job/merge39
wip/merge39
wip/reconcile-1540
job/tabswitch2
job/merge38
wip/merge38
job/autherr-1553
wip/autherr-1553
job/money-688
wip/money688rev3
wip/money688rev2
wip/money688rev
wip/money688l
wip/money688k
wip/money688j
wip/money688i
wip/money688h
wip/money688g
wip/money688f
wip/money688e
wip/money688d
wip/money688c
wip/money688b
wip/money-688
wip/tabswitch2
wip/merge37
job/merge37
job/jobnames-1538
wip/jobnames-1538
job/tabcomp-perf
job/calscript-1492
wip/tabcomp-perf
wip/calscript-1492
job/mailbody-1533
wip/mailbody-1533
job/intlfmt-1461
job/merge36
wip/intlfmt2
wip/intlfmt-1461
wip/merge36
job/merge35c
job/tagperf-1186
wip/tagrev2
wip/tagrev
wip/tagperf4
wip/tagperf2-1186
wip/tagperf-1186
wip/tagfix5
wip/tagfix3
wip/tagfast2
wip/tagfast
wip/merge35c
job/notesel-1493
wip/notesel2
wip/notesel-1493
job/merge35b
wip/merge35b
wip/m35btriage
wip/m35bratchet
wip/calsel-1491
job/calsel-1491
job/notifread-1387
job/bulkwrite-1393
wip/notifread2
wip/notifread-1387
job/slowsel-1392
wip/bulkwrite-1393
wip/bulkrev4
wip/bulkrev3
wip/bulkrev2
wip/bulkrev
wip/bulkfix4
wip/bulkfix3
wip/bulkfix2
wip/bulkfix
job/mail7-1340
job/bigscroll-1481
job/searchperf-1425
wip/mailrev4
wip/mailrev3
wip/mailrev2
wip/mailrev
wip/mail7f
wip/mail7e
wip/mail7d
wip/searchperf2
wip/searchperf-1425
wip/mail7c
wip/mail7b
wip/mail7-1340
job/photoopen-1367
job/mailsel-1449
wip/bigscroll-1481
wip/slowsel3
wip/slowsel2
wip/slowsel-1392
wip/selroot
job/journaldup
wip/journaldup8
wip/journaldup7
wip/journaldup6
wip/journaldup5
wip/journaldup4
wip/journaldup3
wip/journaldup2
wip/journaldup
wip/jdrev5
wip/jdrev4
wip/jdrev3
wip/jdrev2
wip/jdrev
wip/jdfix9
job/bignote-1349
wip/mailsel-1449
wip/bignote3
wip/bignote2
wip/bignote-1349
job/statusmark-1457
wip/statusmark-1457
wip/photoopen4
wip/photoopen3
wip/photoopen2
wip/photoopen-1367
job/authflash-1473
job/merge35
wip/authflash-1473
job/phototags-1370
wip/phototags-1370
wip/merge35
wip/m35triage
job/tick-1446
wip/tick-1446
job/restartidx-1450
job/exmove-1333
job/coldnote-1451
wip/restartidx-1450
wip/exmove-1333
wip/coldnote-1451
job/undo412-1430
wip/undo412-1430
job/calwrite-1441
job/xcancel-1443
job/calscroll-1362
wip/xcancel-1443
wip/calwrite-1441
job/xsub-1445
wip/calscroll3
wip/calscroll2
wip/calscroll-1362
wip/xsub-1445
job/linkdup-1440
wip/linkdup2
wip/linkdup-1440
wip/tabswitch4
wip/tabswitch3
wip/tabswitch-1233
wip/navrev
job/tabswitch-1233
job/mdpaste-1431
job/taskundo-1433
job/directory-1199
wip/taskundo-1433
job/remind-1432
job/nfd-1411
wip/remind-1432
wip/dirfix4
wip/dirfix3
wip/dirfix2
wip/dirfix-1199
wip/directory-1199-r
wip/directory-1199
job/readerx-1427
wip/readerx-1427
job/scrollfade-1416
job/tipphone-1439
wip/nfd-1411
job/purge-1420
job/notifrow-1414
wip/purge-1420
wip/notifrow-1414
job/slop-1385
wip/slop2
wip/slop-1385
job/tbover-1409
job/qltitle-1408
job/grantlive-1405
job/taskclick-1434
wip/tbover-1409
wip/taskclick-1434
wip/qltitle-1408
job/scrub-1422
job/hotfix35
job/ticks-1361
wip/scrub-1422
job/taskprev-1401
wip/grantlive-1405
job/ghost-1323
wip/ticks3
wip/ticks2
wip/ticks-1361
wip/taskprev-1401
job/bash3-settings
wip/ghost-1323
job/mailmorph-1368
wip/bash3-settings
job/apiaudit-1374
wip/bash3-filesphotos
job/bash3-filesphotos
job/xuser39-1402
job/bash3-money
job/mailhtml-1372
wip/mailhtml2
wip/mailhtml-1372
job/bash3-interop
job/bash3-calendar
wip/bash3-money
wip/bash3-interop
wip/bash3-calendar
wip/mailmorph2
wip/mailmorph-1368
wip/bash3-tasks
job/outro-1391
job/linkpick-1379
job/linkdel-1384
wip/linkpick2
wip/linkpick-1379
wip/linkdel3
wip/linkdel2
wip/linkdel-1384
job/mailrows-1390
wip/mailrows-1390
wip/apiaudit2
wip/apiaudit-1374
job/bash-core
wip/outro-1391
wip/bash-core2
wip/bash-core
job/bash3-notes
job/bash3-tasks
job/merge34
job/notifdel-1363
wip/merge34
wip/notifdel2
wip/notifdel-1363
job/wklink-1371
wip/wklink-1371
job/searchbar-1360
wip/searchbar2
wip/searchbar-1360
job/merge33-1122
wip/merge33c
wip/merge33b
wip/merge33-1122
job/bash-security
job/mailglass-1373
wip/bash-security2
wip/bash-security
wip/mailglass-1373
job/instaudit-1369
wip/instaudit-1369
job/tabstorm-1338
wip/tabstorm2
wip/tabstorm-1338
wip/bash-files2
wip/bash-files
job/bash-files
job/bash-money
job/editfuzz-1335
wip/bash-money
wip/moneyrev
job/tasksperf-1286
wip/tasksperf3
wip/tasksperf2
wip/tasksperf-1286
wip/editfuzz2
wip/editfuzz-1335
review/dirrev-1199
job/merge32
wip/merge32b
wip/merge32
job/bash-chrome
job/tagdnd-1187
job/bash-notes
wip/bash-notes2
wip/bash-notes
wip/bash-chrome
wip/reconcile-c1
wip/adv-c1
wip/tagdnd2-1187
wip/tagdnd-1187
job/bash-calendar
job/deploy-c1
job/editbreak-1334
job/bash-perf
wip/bash-calendar2
wip/bash-calendar
wip/bash-perf
job/hunt-20261006
job/bash-interop
job/collabloss-1197
wip/collabrev-1197
wip/collabloss5-1197
wip/collabloss4-1197
wip/collabloss3-1197
wip/collabloss2-1197
wip/collabloss-1197
wip/bash-interop
job/bash-mail
wip/bash-mail
job/vis-1293
wip/vis-1293
wip/restyle-search-r
wip/restyle-search-fix2
wip/restyle-search-fix
wip/restyle-search
job/restyle-settings
job/restyle-search
wip/restyle-settings-fix
wip/restyle-settings
job/adv31
wip/advfix-a
wip/adv31
job/bash-tasks
wip/bash-tasks
job/restyle-files
wip/restyle-files-fix
wip/restyle-files
job/fmtbar-1210
wip/fmtbar2-1210
wip/fmtbar-1210
job/perf2-1124
wip/perf2-1124
job/proflog-1204
job/merge31
wip/restyle-notes
wip/merge31
wip/proflog-1204
job/restyle-notes
job/fix-1213
wip/fix-1213
job/hide-1153
job/restyle-mailmoney
job/notestatus-1209
wip/hide-1153
wip/hiderev2-1153
wip/hiderev-1153
wip/hide5-1153
wip/hide4-1153
wip/hide3-1153
wip/hide2-1153
job/sidebarblur-1208
wip/notestatus-1209
wip/sidebarblur-1208
wip/restyle-mailmoney
job/onboard-1141
wip/onboard2-1141
wip/onboard-1141.aborted-early
wip/onboard-1141
job/adv-1202
job/segmented-1200
wip/segmented-1200
job/merge30
job/notifloop-1194
job/toastmorph-1201
wip/notifloop-1194
job/perf-1124
job/tocrail-1191
job/cards-1179
wip/cards2-1179
wip/cards-1179
wip/tocrail-1191
wip/perf-1124
wip/merge30j
job/wizchoices-1140
wip/wizchoices-1140
wip/restyle-1190
job/moneyfmt-1180
wip/moneyfmt2-1180
wip/moneyfmt-1180-r
wip/moneyfmt-1180
job/pillglass-1189
job/flags-1181
wip/flags-1181
job/restyle-1190
job/settingsreg-1195
job/wizard-1140
site/website
wip/wizardrev2-1140
wip/wizardrev-1140
wip/wizard5-1140
wip/wizard4-1140
wip/wizard3-1140
wip/wizard2-1140
wip/wizard-1140
wip/pillglass-1189
wip/settingsreg-1195
job/merge29
job/fu-1171
wip/merge29j
wip/fu-1171
job/fu-1166
job/txresearch-1188
wip/fu-1166
job/merge28
job/search-1066
wip/search-1066
wip/merge28j
job/gateslot-1182
job/bulkimport-1157
job/mailnet-1160
wip/mailnetrev-1160
wip/mailnet-1160
wip/bulkrev-1157
wip/bulkimport-1157
job/startup-1161
wip/startup-1161
job/merge27
job/linkcards-1151
wip/linkcards3-1151
wip/linkcards2-1151
wip/linkcards-1151
job/traydate-1144
wip/traydate3-1144
wip/traydate2-1144
wip/traydate-1144
job/draw-1101
wip/merge27j
job/blockpill-1152
wip/blockpill3-1152
wip/blockpill2-1152
wip/blockpill-1152
job/minihover-1149
wip/minihover2-1149
wip/minihover-1149
job/merge25
wip/merge25-r
wip/merge25b
wip/merge25
job/inspector-1129
job/tags-1110
wip/inspector3-1129
wip/inspector2-1129
wip/inspector-1129
wip/tagsrev-1110
wip/tags2-1110
wip/tags-1110
job/dates-1148
wip/datesrev-1148
wip/dates2-1148
wip/dates-1148
job/licence-1145
wip/licence2-1145
wip/licence-1145
job/selfhost-1156
fixbatch-25
job/merge23
wip/merge23
job/tagfilter-1109
wip/tagfilter2-1109
wip/tagfilter-1109
job/kbd-1134
wip/kbd2-1134
wip/kbd-1134
job/palfoot-1137
wip/selfhost-1156
wip/palfoot2-1137
wip/palfoot-1137
job/toggle-1158
wip/toggle-1158
fixbatch-23
job/kbpreview-1118
job/docratchet-1155
job/perflint-1133
job/devtests-1159
wip/docratchet-1155
wip/devtests-1159
job/segv-1136
wip/toast-1142
wip/segv-1136
job/toast-1142
job/blockreload-1147
wip/blockreload-1147
job/font-1150
wip/font-1150
job/importui-1120
job/minimonth-1149
wip/importui-1120
wip/minimonth-1149
job/depcheck-1146
wip/perflint-1133
wip/depcheck-1146
job/blocks-1125
job/plus-1128
job/shift-1138
wip/plus2-1128
wip/plus-1128
wip/shift-1138
job/moneyfid-1130
job/editorrail-1113
wip/moneyrev-1130
wip/moneyfid-1130
job/noext-851
wip/noext-851
wip/noext3-851
wip/noext2-851
job/week-1135
wip/week-1135
job/editreg-1132
job/smoke-1122
wip/smoke-1122
job/docs-1143
job/palette2-1123
job/calhdr-1112
job/nlpchip-1127
job/mailghost-1094
job/reconnect-1131
wip/reconnect-1131
job/trayicons-1095
job/delete-1119
hotfix-sidebar2
job/cards-1083
job/palette-1093
job/mchrome-1084
job/e2e-a-1071
job/canvas-visual
wip/e2e-a2-1071
wip/e2e-a-1071
backup/canvas-visual-before-reconcile
wip/surfaces-p2
job/merge-round-9
wip/merge-round-9
job/7cfix-small
wip/7cfix-small
job/mailui-1078
job/merge-round-8
wip/merge-round-8
wip/mailui-1078
job/mailround-1038
job/applemail-accept
wip/settitle-1068
wip/mailround2-1038
wip/mailround-1038
wip/e2e-7b
job/crash-1069
wip/crash-1069
job/searchlost-1066
wip/searchlost-1066
job/7b-reconcile
job/flake-1065
wip/flake-1065
wip/merge-round-7b7
wip/merge-round-7b6
wip/merge-round-7b5
wip/merge-round-7b4
wip/7b-reconcile
job/appupdate-1059
job/nfd-1044
wip/appupdate-1059
job/e2e-7b
job/loop-1062
wip/loop-1062
job/pdfprev-1045
job/invtoggle-1053
wip/pdfprev-1045
wip/nfd-1044
wip/invtoggle-1053
job/7bfix-e2e
job/mailstress-b
wip/7bfix-e2e
wip/mailstress-b
job/7bfix-adv
wip/7bfix-adv
job/mailstress-a
job/stack-1054
wip/stack-1054
wip/mailstress-a
job/mailstress-1038
wip/mailstress-1038
job/upload500-1051
wip/upload500-1051
job/share-1034
wip/share-1034
job/syncerr-1037
job/7bfix-photos
wip/7bfix-photos
job/paste-1036
job/setside-1039
wip/setside-1039
wip/paste-1036
job/lease-1042
wip/syncerr-1037
wip/lease-1042
job/7bfix-data
job/passkeybind-1043
wip/apprevoke-1041
job/invite-1035
wip/invite-1035
job/merge-round-7b2
wip/merge-round-7b2
job/mailproxy-486
job/apprevoke-1041
job/rebuild-1033
job/pillborder-1029
wip/pillborder-1029
wip/mailproxy-486
wip/applemail-486
job/headless-998
wip/headless-998
job/groups-1028
wip/groups-1028
job/rebuildwarn-1016
wip/rebuildwarn-1016
job/startup-1011
wip/startup-1011
job/monthpill-1009
job/bgthumb-1025
job/sharetitle-1012
wip/monthpill-1009
wip/bgthumb-1025
wip/sharetitle-1012
job/canvas-cards-977
wip/canvas-cards-977
job/canvas-pencil-978
job/canvas-sketch-990
wip/canvas-sketch-990
wip/canvas-pencil-978
job/canvas-files-989
wip/canvas-files-989
job/canvas-collab-991
wip/canvas-collab-991
job/weekscroll-1018
wip/weekscroll-1018
wip/canvas-core-976
job/canvas-core-976
job/round-drag
wip/round-drag
job/round-settings
wip/oapi-974
job/oapi-974
job/hist2-integrate
job/mailhtml-726
wip/mailhtml-726
wip/hist2-integrate
job/moneyfu-984
job/drag-1015
wip/drag-1015
job/rename-1017
wip/rename-1017
job/hist2-api
wip/hist2-api
job/oneacct-1014
wip/oneacct-1014
wip/moneyfu-984
job/hist2-bench
job/hist2-restore
wip/hist2-bench
job/hist2-write
job/hotfix-724
wip/hotfix-724
wip/hist2-write
wip/hist2-restore
job/hist2-store
job/hist2-ui
wip/hist2-ui
wip/hist2-store
job/searchstarve-965
job/shutdown-963
wip/shutdown-963
wip/pubedit-981
job/pubedit-981
job/analytics-973
wip/searchstarve-965
job/authflash-850
job/weeklane-969
job/pvtitle-1004
job/hist-975
wip/authflash-850
job/voicepill-617
wip/pvtitle-1004
job/headring-1003
wip/weeklane-969
wip/voicepill-617
wip/headring-1003
wip/analytics-973
job/agentscope-980
wip/thumbsandbox-988
job/thumbsandbox-988
wip/hist-975
job/links-856
wip/links-856
job/davetag-966
wip/davetag-966
job/filesstorm-1000
job/hoverpad-725
wip/filesstorm-1000
job/ffmpegblas-993
job/merge-round-7a
wip/hoverpad-725
wip/ffmpegblas-993
job/nowdot-1002
wip/verify-7a
job/noteid-857
wip/nowdot-1002
wip/noteid-857
wip/merge-round-7a
wip/agentscope-980
job/imapedge
job/a11yfix2
wip/imapedge-941
wip/imapedge
wip/a11yfix2
job/notetask-986
job/logheading
wip/logheading-998
job/textthumb-652
job/photolive-987
wip/photolive-987
job/davactive-983
job/savefix-985
job/tabicons-607
wip/davactive-983
wip/tabicons-607
wip/notetask-986
wip/savefix-985
job/dirid-627
job/buildspeed-1007
wip/dirid-627
job/staging-imap
job/perfguards-impl
job/undo-a11y
wip/undo-a11y
job/mailperf
job/wal-824
wip/settings-50
job/settings-50
job/notesfilter-606
wip/notesfilter-606
job/surfaces-p2
wip/wal-824
job/maillayouts
wip/mailperf
wip/maillayouts
job/taskmeta-659
job/money-ident
wip/money-ident
wip/taskmeta-659
job/errstates
wip/perfguards-impl
job/headings-881
wip/headings-881
wip/errstates
job/voice-619
job/gaps-827
job/notesperf
wip/notesperf
wip/voice-619
job/hddsql-549
job/perf-stream-668
wip/perf-stream-668
wip/deeplinks-fix
job/deeplinks-fix
job/authfix
job/docsfix-rust
wip/docsfix-rust
job/webperf
job/docsfix-web
job/datafix2
job/webdav-lock-476
job/copyfix
wip/copyfix
wip/webperf
job/focus-658
wip/protofix
job/mediafix
job/protofix
wip/mediafix
job/agentfix
job/hhmm-724
wip/agentfix
job/undo-722
job/reuse
wip/webdav-lock-476
wip/reuse
job/scopefix
job/datafix
wip/hhmm-724
wip/undo-722
job/surfaces-p1
wip/hddsql-549
job/voicememos-618
wip/datafix2
wip/surfaces-p1
job/fix-940
wip/fix-940
job/blaze-surfaces
wip/datafix
wip/blaze-surfaces
job/taskday-655
job/linknav-639
wip/linknav-639
wip/gaps-827
job/isolation-707
job/audiophotos-720
wip/audiophotos-720
job/advfind-664
wip/voicememos-618
wip/taskday-655
wip/isolation-707
wip/advfind-664
wip/scopefix
wip/focus-658
job/testgaps
wip/testgaps
job/overscroll-718
wip/authfix
job/deps
wip/overscroll-718
job/rev2-agentfix
job/rev2-mailperf
wip/deps
job/hardening-728
wip/hardening-728
job/searchgen-832
wip/searchgen-832
job/photopw-849
job/mailsql-825
wip/photopw-849
job/sharefix
wip/sharefix
job/rev2-mailhtml-726
job/rev2-perfguards
job/copyval-723
job/lightglass-r2
wip/lightglass-r2
wip/docsfix-web
job/copy-audit
job/macinterop-staging-r2
job/design-sync
job/rev2-taskmeta-659
job/docs-audit
job/rev2-advfind-664
job/rev2-mailproxy-486
job/states-audit
job/rev2-datafix
job/design-drift
job/test-gaps
job/rev2-voicememos-618
job/rev2-mediafix
job/rev2-deps
job/rev2-datafix2
job/licence-audit
job/issue-hygiene
job/rev2-protofix
job/rev2-voice-619
job/rev2-isolation-707
job/rev2-surfaces-p1
job/deeplink-audit2
job/rev2-audiophotos-720
wip/test-gaps
job/rev2-overscroll-718
job/rev2-undo-722
wip/states-audit
job/rev2-dropmd-719
job/rev2-linknav-639
job/merge-7b-plan
wip/merge-7b-plan
job/rev2-taskday-655
wip/mailsql-825
job/rev2-webdav-lock-476
job/rev2-browserfix
wip/design-drift
job/rev2-hddsql-549
wip/deeplink-audit2
job/rev2-scopefix
job/rev2-authfix
job/rev2-hardening-728
job/rev2-wal-824
job/rev2-sharefix
job/calsidebar-638
job/chrome-audit
job/ioperf
wip/ioperf
wip/chrome-audit
wip/calsidebar-638
job/dropmd-719
wip/dropmd-719
job/ocr-build
wip/ocr-build
job/blaze-settings
wip/copyval-723
job/toastring-721
wip/toastring-721
job/deployfix-732
wip/deployfix-732
wip/blaze-settings
job/money-import-recheck
job/rev-a11y
job/perf-arch-db
job/rev-7b-data
wip/textthumb-652
wip/perf-arch-db
job/sec-protocols
job/sidehdr-660
job/rev-7b-security
job/research-surfaces
job/rev-design-gaps
job/rev-mcp-api
wip/sidehdr-660
job/perf-arch-memory
wip/sec-protocols
job/perf-arch-bundle
job/snapedge-714
wip/rev-mcp-api
job/sec-supplychain
wip/research-surfaces
job/perf-arch-sync
job/rev-consistency
job/perf-arch-server
wip/perf-arch-server
wip/perf-arch-memory
job/perf-arch-io
job/perf-arch-client
job/sec-fs
job/sec-mcp-scopes
job/sec-sharing
job/perf-guards
job/sec-browser
job/sec-admin-deploy
job/sec-auth
wip/snapedge-714
job/bgpicker-717
wip/perf-arch-bundle
wip/money-import-recheck
job/advsetup-654
wip/bgpicker-717
wip/advsetup-654
job/burst-709
job/kbdcaps-710
job/app-pw-chooser
wip/burst-709
wip/app-pw-chooser
job/imaptest-625
wip/kbdcaps-710
job/fix-499
wip/fix-499
job/perf-mut-667
job/calimg-589
job/perf-snap-666
wip/calimg-589
wip/perf-snap-666
wip/perf-mut-667
job/perf-cache-665
wip/perf-cache-665
job/voicefiles-620
wip/voicefiles-620
job/admin-burst-705
wip/admin-burst-705
job/voicememos-review
wip/voicememos-review
wip/ryw-653
job/ryw-653
job/writeonopen-661
job/instant-663
wip/writeonopen-661
job/money-import-review
wip/money-import-review
wip/importjs-610
review/integrations-407-round6
wip/integrations-review
job/dragghost-612
wip/dragghost-612
job/integrations
wip/integrations
job/decider-656
job/merge-round-6
job/perf-rerun
wip/merge-round-6
job/integrations-review-round5
job/selalign-576
wip/selalign-576
job/mcp-events-491
job/files-631
job/cal-e2e-569
wip/cal-e2e-569
job/reload-423
wip/reload-423
wip/mcp-events-491
wip/files-631
job/notesbridge-644
wip/notesbridge-644
job/editor-series
job/calcard-series
wip/calcard-series
job/mcp-events-review-491
wip/mcp-events-review
wip/editor-series
job/quirks-546
job/integrations-recheck
job/tocrail-636
wip/tocrail-636
wip/quirks-546
wip/reminders-643
job/reminders-643
wip/davscale-573
job/davscale-573
job/integrations-review
wip/ocr-eval-584
job/ocr-eval-584
job/esc-537
wip/esc-537
job/toastname-586
wip/toastname-586
job/submenu-579
wip/submenu-579
job/tasks-mode
wip/tasks-mode
job/agentdocs-630
job/dupwrite-634
wip/agentdocs-630
wip/dupwrite-634
job/lightglass-588
wip/lightglass-588
job/tabswitch-549
job/ghosttask-623
wip/ghosttask-623
job/toaststack-616
job/weekstate-609
job/mailsync-613
wip/mailsync-613
wip/weekstate-609
job/maildup-626
wip/tabswitch-549
wip/maildup-626
wip/toaststack-616
job/motion-611
wip/motion-611
job/tlstest-601
wip/tlstest-601
job/perf-495
job/floating-sheet
wip/floating-sheet
job/remdup-585
wip/remdup-585
job/fix-502
wip/fix-502
job/attachplay-622
job/perf-batch
wip/perf-batch-563
wip/perf-495
hotfix/mail-sync-diag
job/mail-m3
wip/mail-m3
job/attach-poof-603
job/calhover-608
job/editorbar-604
job/mentions-605
job/merge-round-4
job/allday-514
wip/merge-round-4
wip/allday-514
job/merge-round-4a
wip/merge-round-4a
job/sharestack-580
job/fix-501
wip/sharestack-580
wip/fix-501
job/perf-batch-563
job/theme-detail
job/apw-cache-review
wip/apw-cache-review
job/probe-520
wip/probe-520
job/mac-393
wip/mac-393
job/header-571
job/flake-513
wip/flake-513
job/docs-thumb-547
wip/header-571
job/webcal-572
wip/webcal-572
wip/shortcuts-542
job/shortcuts-542
wip/docs-thumb-547
job/caldav-stress
wip/caldav-stress
wip/sweep-478
job/apw-cache-512
wip/apw-cache-512
job/money-empty-540
wip/restart-505
wip/money-empty-540
wip/fix-510
job/restart-505
job/fix-503
job/perf-496
wip/perf-496
job/fix-498
wip/fix-498
job/info-inspector-465
wip/info-inspector-465
job/fix-510
job/fix-507
wip/fix-507
wip/fix-503
job/fix-493
job/money-kinds
wip/money-kinds
job/hygiene-548
job/merge-round-3
wip/fix-493
job/drag-snap-536
wip/merge-round-3
wip/merge-round-0930
wip/drag-snap-536
job/align-538
wip/align-538
job/bg-flash
wip/bg-flash
job/money-import
job/search-count-544
wip/search-count-544
wip/money-import
job/settings-key-541
wip/settings-key-541
job/toast-539
job/preview-421
wip/preview-421
wip/toast-539
job/tasks-500-531
job/title-plain-526
wip/title-plain-526
wip/tasks-500-531
job/notes-bridge
wip/parity-484
job/parity-484
job/files-slow
job/crash-525
wip/notes-bridge
wip/files-slow
wip/crash-525
job/kbd-motion-527
wip/bg-422
job/analytics-504
wip/analytics-504
wip/kbd-motion-527
job/upload-pill-523
wip/upload-pill-523
wip/tray-order
job/tray-order
wip/overflow-mid
wip/merge-round-2
job/perf-494
wip/perf-494
job/merge-round-3-pre-rebuild
wip/mcp-fast-492
wip/motion-477
wip/asr-ab-489
wip/theme-variants-506
wip/overflow-511
wip/week-header-508
wip/attach-427
job/dav-delete-471
job/iso-435
wip/iso-435
wip/files-sel-keys
wip/dav-delete-471
job/align-253
job/siwc-490
wip/siwc-490
job/money-kinds-review
wip/align-253
wip/money-kinds-review
job/small-bugs-3
wip/overlay-title-487
wip/multiget-500
wip/hidden-420
wip/webcal-ui
wip/webcal-431
job/perf-367
job/location
wip/small-bugs-3
wip/location
wip/perf-367
wip/admin-deny-483
job/tag-unicode-473
wip/tag-unicode-473
job/blur-436
wip/photos-470
wip/blur-436
wip/small-bugs-4
wip/hunt-20260930
wip/settings-hdr-482
wip/chips-416
job/dedup-375
wip/dedup-375
job/doc-stack
wip/doc-stack
job/tokens-literals
wip/tokens-literals
job/jobs-leftovers
wip/send-fast
wip/paste-467
wip/money-numbers
job/money-plugin
wip/money-plugin
backup/doc-stack-r3-reset-source
job/break-dav
wip/merge-batch
wip/crossday-469
wip/mac-verify
wip/mail-m2
wip/break-dav
wip/money-review2
job/money-md
job/modes-424
wip/money-md
wip/jobs-leftovers
job/agenda-413
wip/agenda-413
job/dedup-375-clean
job/dedup-375-before-rebase
wip/modes-424
job/recog-417
wip/recog-417
wip/bounce-425
wip/ab-384-luna
backup/doc-stack-round3-before-rebuild
job/webdav-perf
wip/webdav-perf
job/toast-ring
wip/toast-ring
job/money-review
wip/money-review
wip/micro-motion
wip/settings-card
wip/minical
job/notes-imap-428
job/least-priv
wip/ui-small-2
wip/flaky-426
wip/drag-end-418
job/jank
wip/jank
wip/least-priv
wip/docs-site
job/agenda
job/sec-batch
wip/sec-batch
wip/per-user-index
job/area-calendars
wip/area-calendars
job/parity
wip/parity
job/documents-research
wip/documents-research
job/test-infra
job/reminders-sync
wip/small-bugs-2
wip/reminders-sync
wip/gestures
job/google-oauth
wip/tags-merge
wip/tags
job/e2e-theme
wip/e2e-theme
job/icon-align
wip/test-infra
wip/select-align
wip/editor-385
job/voice
wip/webdav
job/webdav
job/app-pw-ui
job/editor-integrity
wip/editor-integrity
wip/voice
wip/quota
wip/cal-followups
wip/icon-align
job/composer-scale
wip/composer-scale
job/jobs-page
wip/jobs-page
job/hig-type
wip/hig-type
wip/app-pw-ui
job/motion-spring
job/mcp
wip/motion-spring
wip/mcp
job/small-bugs
wip/push-hosts
job/profile-sign
wip/touch-369
wip/profile-sign
job/mobile-focus
wip/mobile-focus
wip/ui-polish-354
wip/small-bugs
wip/dup-task
job/toast-polish
job/app-pw-scopes
wip/toast-polish
wip/app-pw-scopes
wip/cli-agent
wip/selection-pills
job/preview-attach
wip/preview-attach
job/dav-proppatch
wip/dav-proppatch
wip/cal-switcher
job/atomic-race
wip/atomic-race
job/photos-shared
wip/photos-shared
wip/cal-grid
wip/note-rewrite
wip/search-rebuild
job/mail-m1
job/paperless-import
wip/paperless-import
wip/mail-m1
wip/hidden-activity
wip/search-d
wip/pricing-research
wip/cursors
wip/auto-scheme
job/single-pills
wip/single-pills
wip/xuser-matrix
wip/money-format
wip/app-pw-setup
wip/purge-dos
wip/vault-health
wip/caldav-apple
wip/xuser-audit
wip/e2e-green
wip/tabbar
wip/adv-harness
wip/maple-mono
job/search-fix
wip/search-fix
wip/search-perf-c
job/adv-harness
wip/sidebar-headers
job/glass
wip/temp-index
job/polish
wip/polish
wip/file-protocols
wip/money-research
wip/glass
wip/voice-models
wip/collab-redo
job/voice-research
wip/hunt-20260928
wip/notes-actions-research
wip/search-pad
wip/search-perf
wip/search-sticky
wip/editor-undo
wip/chrome-rules
wip/motion
wip/appearance-research
wip/appearance
wip/audit-bugs
wip/cal-glass
wip/block-actions
wip/authz-order
wip/event-stripes
wip/chrome-sidebar
wip/auth-flaky
wip/robust-2
wip/gate-fix
wip/menu-blur
wip/import-calternaljs
wip/tray-fix
job/import-calternaljs
wip/index-order
wip/audit-fixes
wip/search-chevrons
research/mail
wip/phone-chrome
wip/dedup-break
wip/csp
wip/ui-audit
wip/select-toast
wip/perf
wip/flat-layout
wip/fonts
wip/event-tint
wip/sync-converge
wip/data-split
wip/glass-audit
wip/robustness
wip/sync-chaos
wip/search-thumbs
wip/fuzz
wip/menu-icons
wip/search-pill
wip/sync-changing
wip/heading-links
wip/date-formats
wip/a11y
wip/break-editor
wip/e2e-fix
wip/settings-sections
wip/sync-root-guard
wip/search-palette
wip/share-edit
job/toasts
wip/toasts
wip/cont-analytics
wip/authz-review
wip/popovers
wip/overlay-glass
wip/change-feed
wip/editor-modes
wip/composer-align
wip/cont-agenda
wip/agenda-merge
job/agent-conventions
wip/agent-conventions
wip/backend-misc
job/route-audit
wip/route-audit
wip/ui-batch
wip/heif-hardening
wip/grid-resize
wip/ask-page
wip/webmcp
job/deeplink-audit
wip/deeplinks
wip/shortcuts
wip/cont-tz-days
main
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set
Reference
kayg/calternal-v0#1190
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Audit: local restyling and hand-rolled controls (owner, 2026-10-06: "why so many instances of custom components again?")
Example found: apps/web/src/lib/editor/format/BlockHoverActions.svelte wraps the shared
PillGroup frostedbut adds its own ProgressiveBlur+wash slab and a hand-styled ⋯ button with px literals (#1189 fixes that file).Do (whole repo, apps/web + packages):
:global(...)selectors into it, extra background/backdrop-filter/border/shadow/radius/hover colours, wrapper overlays); (b) draws its own button/pill/chip/menu/card/toggle instead of the shared one; (c) uses size/colour/radius/duration literals outside token files.artifacts/restyle-audit.mdand post it on this issue, grouped by Tab.:globaloverrides into shared primitive classes and on new hand-rolled<button class=…>controls in feature folders (with an allow-list for justified exceptions, each with a comment and issue link).Screenshots before/after of each changed surface at ACTUAL size (1x/2x), light + dark. Gates:
bun run check+bun run testquoted. Commit; comment with head SHA. Do not push.Starting #1190 in
job/restyle-1190, based onorigin/devat5301e020859c1d61b4a7f812a5049a64241203e8. I have readCLAUDE.md,docs/DESIGN.md, andCONTEXT.md. I am mapping shared primitive overrides, hand-rolled controls, and non-token visual literals acrossapps/webandpackagesbefore making small area commits.Initial full inventory from
5301e020859c1d61b4a7f812a5049a64241203e8. It groups findings by Tab and lists file, line, category, and the shared primitive or token family. The BlockHoverActions wash slab is assigned to #1189.Restyle audit — Forgejo #1190
Inventory from 2026-10-06 in apps/web and packages. Each entry has a file and line. Category (a) is a local style override of a shared primitive class or an extra surface around one. Category (b) is app-owned button, pill, chip, menu, card, or toggle markup and names the shared control to use. Category (c) is a literal control size, colour, radius, or duration outside token files and names the shared primitive.
Calendar (0 a, 1 b, 7 c)
(b)
(c)
Tasks (6 a, 10 b, 3 c)
(a)
(b)
(c)
Notes (8 a, 27 b, 11 c)
(a)
(b)
(c)
Files (6 a, 58 b, 1 c)
(a)
(b)
(c)
Photos (0 a, 7 b, 1 c)
(b)
(c)
Mail (2 a, 8 b, 0 c)
(a)
(b)
Money (0 a, 7 b, 0 c)
(b)
Search (9 a, 20 b, 14 c)
(a)
(b)
(c)
Settings (18 a, 34 b, 10 c)
(a)
(b)
(c)
Analytics (2 a, 5 b, 2 c)
(a)
(b)
(c)
Notifications (5 a, 3 b, 0 c)
(a)
(b)
Shared UI (16 a, 40 b, 53 c)
(a)
(b)
(c)
Tasks audit finding fixed at
d15075e81: TaskCard and TaskList styled shared Card/StatusPill internals through :global selectors, and TaskColumn hand-drew Add task. Card now owns compact padding, clipping, and DnD outline; StatusPill owns compact sizing; Pill owns the muted Add task control. Focused primitive and Tasks component tests passed. Exact #1058 hashes were refreshed for changed Task list sites; the ratchet did not change.Tasks workspace finding fixed at
cf1775319: List/Matrix Add task and the Task index Retry action used local button CSS. Both now use the shared muted Pill; the parent keeps only layout. TaskBoard/TaskList tests passed (7 tests), and the design-rule test passed against origin/dev.Finding: Task Inspector values and Task card overflow counts had local button/chip treatments instead of shared primitives. Replaced Inspector value buttons with
Pill shape="text"and shared semantic tones, and replaced the+Ncount span withPill shape="chip" tone="inset". Extended Pill with these shared variants, tests, and docs; local value paint and chip CSS are removed.Evidence:
bun run checkpassed (performance/token/type checks and Svelte check); focused Pill, Card, StatusPill, TaskBoard and TaskList tests passed: 5 files, 16 tests.node scripts/design-rules.test.mjspassed.Commit:
b95e6c04a6.Finding: Task List repeated the same local status sizing already represented by
StatusPill size="compact"and drew the hidden-tag count as a custom span. Removed the override and now render the count with the shared insetPillused by Task cards.Evidence:
TaskList.svelte.test.ts: 1 file, 4 tests passed;node scripts/design-rules.test.mjspassed; exact performance contract pins refreshed, without raising the ratchet. Commit:c74086679b.The design-rule regression test now scans changed Svelte/CSS in
apps/web/src/lib,apps/web/src/routes,packages/editor/src, andpackages/ui/src. It rejects new local primitive overrides in feature consumers and new hand-rolled classed buttons across those roots.packages/uiis excluded from the override check because a shared primitive must style its own composed internals; its native control markup remains guarded.node scripts/design-rules.test.mjspasses.Commit:
2b27975324.Coordination: #1200 owns SegmentedControl and all single-choice selector call sites; this audit leaves them alone and lists findings for them.
Final report — Forgejo #1190
Head SHA:
2b27975324bb1df94103b37cf8f90562390483e2Branch:
job/restyle-1190Status: The Tasks area and regression guard are implemented. The wider repo audit is not complete, so this branch is not ready to merge.
What changed
artifacts/restyle-audit.mdand posted the full inventory in the earlier issue comment.Card,Checkbox,Pill,StatusPillandTagPillcontrols.TasksWorkspacealso usesPillfor its Add and Retry actions. Existing action callbacks, task writes, tag filters and drag/drop behavior stay in place.CardwithoverflowanddropPreview;Pillwith the Inspectortextshape, shared hit floor andmuted,dangerandinsettones; andStatusPillwith acompactsize. Added component tests and package documentation.apps/web/scripts/design-rules.test.mjsto reject new shared-primitive:globaloverrides in web and Editor feature code, and new classed native buttons across web, Editor and shared UI source. A local exception needs an adjacent comment with an issue number and reason. The rule compares changes withorigin/devso the existing inventory does not fail the gate.Files
apps/web/scripts/design-rules.test.mjs,apps/web/package.jsonapps/web/src/lib/tasks/TaskCard.svelte,TaskColumn.svelte,TaskList.svelte,TaskList.svelte.test.ts,TaskSection.svelte,TasksWorkspace.svelteapps/web/src/lib/components/Card.svelte.test.ts,Pill.svelte.test.ts,StatusPill.svelte.test.tspackages/ui/src/components/Card.svelte,Pill.svelte,StatusPill.svelte,packages/ui/src/tokens.css,packages/ui/README.mdcontracts/perf/adoption-1058.json,contracts/perf/exceptions.jsonThe six commits are
aef181c,d15075e,cf17753,b95e6c0,c740866and2b27975. The worktree is clean. No Rust source changed.cargo cleancompleted at the end and the web build output was removed.UX gaps closed
UX gaps left
BlockHoverActions.svelteitem remains with #1189.Decisions not stated in DESIGN.md
Cardowns clipping and drag preview;Pillowns compact Inspector text actions and semantic tones;StatusPillowns compact status sizing.origin/devtree as its baseline and only rejects new signatures. Existing inventory entries remain visible for follow-up instead of being silently grandfathered as individual exceptions.Web gate output
bun run check:The two warnings are existing empty CSS rulesets in
packages/ui/src/components/calendar/AttachmentDeck.svelteandAgendaList.svelte.bun run test:Production screenshots
72 PNGs are attached to this issue: before and after for Tasks Board, Tasks List and Calendar Task Inspector at 390, 820 and 1440 px, in Paper light and Tokyo Night dark, at 1× and 2×. The production app used real server data and macOS platform emulation.
Open the 72-image screenshot index
Before
Tasks Board
Tasks List
Calendar Task Inspector
After
Tasks Board
Tasks List
Calendar Task Inspector
Starting Notes restyle audit on branch job/restyle-notes, base
2b27975324. I’m locating the Notes inventory and surfaces now.Starting Files+Photos pass on job/restyle-files, based on
2b27975324. I am locating the audit inventory and mapping its findings to the shared UI primitives before editing.Starting Calendar + Mail + Money findings for #1190.
Branch: job/restyle-mailmoney
Base SHA:
2b27975324I have read CLAUDE.md, CONTEXT.md, and the relevant Calendar, Mail, Money, Chrome, and Connected Account decisions in docs/DESIGN.md.
Starting Search-area restyle in job/restyle-search, based at
2b27975324.Starting #1190 Settings area in
job/restyle-settings, based at2b27975324bb1df94103b37cf8f90562390483e2.The prompt references
artifacts/restyle-audit.md, but that file is not present in the worktree or HEAD. I am checking the issue's recorded inventory and the Settings-specific design guard to recover the exact findings before editing.Evidence: test -f artifacts/restyle-audit.md returns false, and git ls-tree -r HEAD -- artifacts/restyle-audit.md returns no path. The initial inventory is present in the #1190 issue comments, so I am using it as the checklist for this pass.
Finding: artifacts/restyle-audit.md and the claimed top-level copy are absent from this worktree (git ls-tree and rg --files show no match). The issue's inventory comment contains the full Notes section, so I’m using that as the source list.
The first web check surfaced one stale exact performance pin:
coverage.surfacesforapps/web/src/lib/canvas/CanvasView.svelte#each:3a4cbef6167607e4:1reports “unused or changed exception.” This surface's action controls changed from native buttons to shared Pills and the local 44 px sizing rule was removed. I will refresh only the live syntax hash for the changed scope, keeping its owner, reason, replacement test, expiry, and limit unchanged, then rerun the guard.Inventory finding for Settings:
artifacts/restyle-audit.mdis absent from HEAD and the file history, but the #1190 audit comment records 18 shared-style overrides, 34 hand-rolled controls/cards, and 10 literal sizing/layout findings under Settings. I will use that posted inventory as the source.Scope boundary: the listed BackgroundGroup swatches and Unsplash photo choices are single-choice selectors. I will leave those controls to #1200 as requested, while fixing the ordinary action controls and shared surfaces in the same files.
Notes implementation decisions where DESIGN was silent:
material="clear",edge="none",shadow="none", andradius="control"props. This lets the Note editor keep its existing host geometry and lets embedded Canvas cards use Card without consumer selectors on.card.shape="row"for full-width label/value actions andtone="accent-soft"for the parsed reminder status. Pressed and expanded action Pills use their real ARIA state for the shared selected tint.sheetHeaderLayout="centered-leading"so the phone Contents control stays centered while the changing sheet title remains in the accessibility tree.origin/dev.The selector-owned surfaces stayed with their owners: Callout's kind selector and reminder audience selectors remain unchanged; PillGroup and BlockHoverActions remain untouched for #1189. No single-choice selector was changed.
Source review findings from the posted Settings inventory:
Cardresolve to.card-footerlayout wrappers inside existingSettingsCardgroups. They are not private card shells; wrapping each footer in another Card would add nested surfaces. App Passwords also already uses the sharedCardfor its instruction sub-cards.UnsplashSheetphoto choice button andConnectedAccountsSectionprovider choice buttons select a single option/provider. I will leave them to #1200, along with the BackgroundGroup swatches and SegmentedControl.Finding during the Files restyle:
bun run checkreported an unused or changed exactrender.boundpin forFilesBrowser.svelte#each:c469e9f9e005d61c:1. The Files menu row now uses the shared Pill, which changed the pinned loop syntax. I will refresh only this exact live pin and keep the existing performance rule and ratchet.Correction: the menu loop hash is shared by 12 exact performance-contract entries, not one. The source parser reports the live syntax digest as
93ca91d2cd4239a4edfab625a6074dfa70cba3907da5a7be04a94a8b455e6aa6. I will update those 12 existing entries to that digest only; their rules, limits, owners, and ratchet counts stay unchanged.The initial
bun run checkthen reported two implicit-anyevent parameters in the shared Files pinned-row Pill, one in the shared Card form on PublicLinkPage, and an unused.drop-namerule after replacing that local control. I addedDragEvent,KeyboardEvent, andSubmitEventannotations and removed the dead selector. The full check will run again after the requiredorigin/devmerge.Finding and fix: the focused Card/Pill tests first failed because the shared primitives did not expose the Settings variants. I added status tones, shared sizing flags, solid Card material, sheet flattening, and a semantic drop-target Card mode, with component tests and prop documentation. Focused result:
Test Files 2 passed (2); Tests 10 passed (10). The initial test invocation also found missing worktree dependencies;bun install --frozen-lockfilerestored them without a lockfile change. Commit:3b412851c.Finding and fix: Settings
StateChipandRowActionhad feature-scoped global rules that painted generic Pill tones and disabled state. They now select sharedPilltones; Jobs detail actions use the sharedflushStartprop. Focused result:Test Files 2 passed (2); Tests 9 passed (9). Commit:7438aa832.Finding and fix: Recovery Key, Unsplash and Calendar Feeds had local solid overlay paint; Recovery Key, Unsplash and Connected Accounts also carried local dialog sizes, and provider setup repeated the Settings sheet inset. OverlaySurface now owns
solid, compact/standard/wide dialog sizes and the Settings chrome option. Focused result:Test Files 1 passed (1); Tests 24 passed (24). Commit:f169d5716.Finding: the App Password expiry trigger is a date-popover button with the same field material as a text input, but the shared Select owns a single-choice menu and is outside this issue's scope. I added the additive
Pillfield shape for anchored form triggers; it does not alter Select. The focused Card/Pill tests pass:Test Files 2 passed (2); Tests 11 passed (11). Commit:be81f469b.Finding and fix: Plugins used a native button with a local 44px shell and local grab/touch styles. The handle now uses shared
Pillicon geometry and shared drag affordance while retaining the existing feature-owned drag action on the primitive root. Focused result:Test Files 2 passed (2); Tests 12 passed (12). Commit:4bd206287.Finding and fix: App Passwords had a sheet-only local Card override and a hand-built expiry button.
SettingsCardnow forwardsflatOnSheetto shared Card, and the expiry date popover uses shared Pill field geometry. The new forwarding regression test passes:Test Files 1 passed (1); Tests 4 passed (4). Commit:111b59bf6.Finding and fix: the shared AuthCard hand-built its shell, and auth flows styled native
.btncontrols around it. AuthCard now delegates surface, dimensions, padding and stack gap to shared Card; the flow actions use shared Pills and auth-ui.css excludes Pills from its native-button recipe. Commit:9b7717808.Finding and fix: Background picture upload used a feature-local dashed button, and its error retry used a hand-styled native button. The upload now uses shared Card
dropTarget, and Retry uses the shared text Pill; file selection and drag-and-drop handlers are unchanged. Commit:6df41be2a.Finding and fix: the Settings route's account, Admin-data, Plugin-catalog and Shortcuts retry actions used a locally styled native button. They now use the shared text Pill with its shared focus and touch behavior. Commit:
a303750dd.Settings follow-up findings: Admin Sign-in and Calendar Feeds had local toggle row spacing; they now use the shared Settings gap and hit-area tokens. Notifications and Voice wrapped shared Toggles in extra 34 px wrappers; those wrappers are removed because Toggle owns the target. Settings form footers now use the shared toolbar gap while Money retains its own existing footer gap.
Commits:
57776d5e9,1849d5c68,f1b077cfa,a84fbaf3d.git diff --checkpassed. The final web gates and production screenshots are still in progress.Build finding: the local calternal-server target embeds apps/web/build, which was absent from this worktree. The server compile stopped at that embed step after dependency compilation. I am building this branch’s production web assets and will rerun cargo build -p calternal-server; no Rust source change is needed.
Evidence finding: the first baseline screenshot runner exited before browser launch because Bun sharp could not resolve libstdc++.so.6. The Nix runtime library at /nix/store/z0n70pxyzi87why1bcq81zgd7b924nfj-gcc-15.2.0-lib/lib resolves it, and a sharp import check passes with that LD_LIBRARY_PATH. I am retrying the captures with this runtime path.
Evidence finding: the existing Contents rail runner reached the baseline production page but failed its unchanged geometry assertion at 1440 px light: the hover title pill intersects Note body text (pill x=292.80–526.39 px). I am preserving the test expectation and checking the after build for this overlap; I will capture the full viewport/theme matrix with a capture-only fallback if the assertion aborts early.
After-build finding: the Contents tick's offset parent is a zero-sized .pill-content; the shared magnetic action creates that positioning context, so the tick starts 15 px from the rail origin and the 1440 px hover pill begins 3 px before the tick ends. The preview container was also 233.6 px wide while Note text starts 182.8 px after its left edge. I am adding a Pill magnetic opt-out for positional markers and including both route paddings in the preview offset; the existing geometry assertions stay unchanged.
Baseline evidence before code changes:
CALTERNAL_SERVER_BIN=/home/kayg/build/targets/restyle-mailmoney/debug/calternal-server CALTERNAL_E2E_MAC=1 bun e2e/agenda-decks-822.mjsbuilt the local production route and passed the media contract checks, then timed out after 90 seconds waiting for the Week/Day attachment list to become visible. The captured DOM showed.attachment-list.is-fanwitharia-hidden="true"and theis-stack is-fanclasses. The script emitted partial Agenda screenshots, then exited 1. I did not change the existing assertion; I am keeping this restyle scoped to #1190 and will capture the affected Calendar surfaces with a focused screenshot flow.Screenshot evidence finding: the after build's real Settings theme-save API returned HTTP 507 with
Home storage quota or server free-space reserve reached.df -hshowed 23 GB available on/dev/sdb1. The screenshot fixture stopped before the after matrix completed. I am freeing this job's Rust build output, then I will rerun the production captures.After-fix finding: magnetic opt-out and padded route offset now pass the horizontal and prose-overlap assertions. The remaining centering assertion showed the rail's one-class placement selector losing to shared positioning, leaving the root 7 px above its row center. I strengthened the layout selector to target the rail row; the existing centering expectation is unchanged.
Clarification: after the prior fix, the remaining Contents tick centering issue came from selector specificity. The shared icon pill rule uses two classes, so the rail's one-class position rule did not win. I strengthened the Notes rail selector; the test expectation remains unchanged.
After-fix finding: the 1440 px hover geometry now passes, including tick clearance and no prose overlap. The next assertion found the visible tick extends 1 px into the editor Card at 820 px because the shared Pill border moves its child marker inward. I am offsetting the decorative tick by the shared hairline token so it aligns with the rail's outer edge; assertions remain unchanged.
Notes Contents follow-up: the real-server tablet geometry assertion measured the visible tick 0.078 px inside the editor Card after the shared Pill border inset. I increased the decorative marker offset by one shared hairline. The unchanged tocrail-636 assertion now passes across desktop, tablet, and phone in light and dark at 1x; committing this Contents surface fix.
Resuming #1190 in job/restyle-search. Base/head at resume:
2b27975324. Working tree is clean; I am locating the Search audit inventory and continuing the Search-only fixes.Files+Photos visual verification update (2026-10-06)
thumbnail-cache-547.txtto produce a PDF thumbnail. The API entry reportedmime=application/pdfandhas_thumbnail=true, but the harness timed out after 120 seconds. I left the assertion unchanged and added a focused real-API Files Browser/Sidebar capture path. Baseline and current each passed the six Mac captures at 390/820/1440 in light/dark (phone/tablet 2×, desktop 1×).acquired_after_secs=5175.653340628and Index-busy errors. I stopped that SLOW-only run and added an opt-in capture path that reuses the same real five-frame burst fixture from the full test. Baseline and current each passed empty-state and key-photo action captures at all three review widths and both themes.cargo clean(7.3 GiB removed), and pointed the required worktreetarget/tmppath at a job-specific directory on/mnt/hdd. The reserve guard stayed enabled and subsequent fixture writes succeeded.Baseline screenshot finding: the existing Notes section-card geometry assertion reports a 9 px overlap (gap = -9 px) on the pre-restyle build. I will retain the normal assertion unchanged; for before images only, a temporary capture runner bypasses assertions so the actual baseline rendering can be attached. The failing pre-restyle flow is isolated from the production changes.
Final web gate finding from
cd apps/web && bun run check:perf-lint: INVALIDreports an unused or changedrender.boundexception forapps/web/src/lib/auth/components/RecoveryKeyEntry.svelte#each:a69de360f4657485:1.backdrop-filterliterals inpackages/ui/src/components/Card.svelte:97andOverlaySurface.svelte:1015.border-radiusnumeric literal0inpackages/ui/src/components/Card.svelte:106.I am tracing each report against the current source and live guard entries before changing code.
Finding: the required post-merge
bun run checkfound theMailView.svelteexactrender.boundpin no longer matched. I compared the loop hashes at the original audit base, the incomingorigin/devparent, and this branch parent: the fourMailViewloops match at the base andorigin/dev, while this branch's Pill/Card action markup changes the enclosing component hash. I am refreshing only those four exact live hashes in the performance registry, exceptions, and adoption records. Owners, reasons, limits, replacement tests and ratchets remain unchanged.svelte-checkfound 0 errors and 4 existing warnings (AgendaList empty ruleset; three MailView swipe selectors).Search audit finding: the branch tree and HEAD contain no
artifacts/restyle-audit.md;git ls-tree -r HEADconfirms it is absent. The full Search inventory is in the existing #1190 inventory comment (9 shared-style overrides, 20 controls, 14 literal findings). I am using that posted list as the checklist. The requiredorigin/devmerge also had StatusPill component/test and UI README conflicts; I kept thedevinline feedback variant and the branch's compact StatusPill size, with their tests and docs.Merge integration finding: after the exact MailView refresh, the required check exposed 11 stale TaskColumn loop pins. The merged UI keeps the base branch's shared Pill and Card implementation; the incoming exception/adoption entries had an adapter hash for the alternate source version. I verified the live
visibleItemslist AST hash isab66631596991438470a60606ae91b83b42a16b9d660acabc5ac5175625a776b, which matches the registry and currentrender.boundentry. I refreshed only the 11 related exception/adoption hashes. TaskColumn source behavior, limits, owners and ratchets did not change. Commit:6cf73b060.Finding: after the Mail pins were refreshed, the check found a stale Calendar route
render.boundidentity. I compared live Svelte syntax against the exact registry, exception, and adoption entries in every Calendar, Mail, Money, and shared primitive file changed by this branch. Fourteen changed list identities needed new exact hashes. I updated their 14 registry hashes, 168 exception hashes, and 132 adoption hashes. The 3 YearHeatmap loops have no adoption record. No performance limits, exception rules, owners, reasons, or ratchets changed. Commit:9e2318686.Files+Photos evidence update: the first UploadToast capture path found that the completed toast stays in Sonner's stack after Close, so waiting for DOM detachment was invalid. A later after-build attempt also missed the card's four-second read window while the shared host logged 2–4 second SQLx waits. I changed the evidence path to hold the real Tus PATCH, capture the collapsed in-progress toast, expand by keyboard, release the upload, and capture the completed row. The focused rerun is pending.
The after-build Share capture produced all 18 Share and outgoing-grant screenshots, then made no progress for 191 seconds while fetching the newly created link list. The baseline visitor-page capture passed. I removed that extra API lookup and now read the slug from the URL displayed in the real Share dialog before opening the public page. I will rerun both builds.
Pin-refresh finding: the live parser identified two changed list identities in
RecoveryKeyEntry.svelte, and the exact 24 pins for those identities now match their current source hashes. The next perf-lint run exposed another stale exact pin atRecoveryKeyWords.svelte#each:a69de360f4657485:1. I am checking every changed Svelte file for the same source-hash change; exception limits and ratchet counts remain unchanged.Finding: the next post-merge check reached Calendar's route-level
blocked-networkexception after the list pins were refreshed. The Calendar page and both restyled Money routes also carry route-level snapshot/readiness contracts pinned to each complete Svelte component. I recomputed the live component hashes and updated 3 route registry hashes plus the 12 matching exception and 12 adoption hashes. This records the current shared-control markup; it changes no route behavior, rule, limit, owner, or ratchet. Commit:e6127aea0.The broad live-hash refresh now covers 298 existing exact pins across 24 changed Svelte files, plus 21 surface hashes and one route hash. The next perf-lint check reached the separate #1058 adoption checkpoint and reports that one checkpoint row no longer matches its exact live ledger entry. I am aligning only checkpoint rows that still have a current exception identity; no new rows or counts are planned.
Files+Photos evidence update: the new focused Files Inspector matrix did not produce a screenshot during a two-minute baseline attempt. The process check showed its local calternal-server in D state with
jbd2_log_wait_commit; I stopped the browser run. No UI assertion or 5xx result was reported. This is SLOW host filesystem pressure. The focused--restyle-screenshots-onlyrunner is inapps/web/e2e/info-inspector.mjsfor a rerun on the merge host.Gate finding: Search list markup changed exact render-bound syntax hashes. I refreshed only the live hashes for the touched Search lists in contracts/perf/{registry,adoption-1058,exceptions}.json. The merged origin/dev tree also had a stale TaskColumn render pin, so I refreshed that one live hash without changing its rule, bound, owner, replacement test or ratchet. The web check is running again against these exact entries.
Calendar/Mail/Money finding: after refreshing the exact route and list pins,
bun run checkidentified one remaining stalematerial.inline-style-resolutionhash forapps/web/src/routes/calendar/[view]/[date]/+page.svelte(style:b2b7ef5bfe5a1a28). The base commit had the pinned hash29ee0065…; the live AST hash is14eced58…, verified against the perf-source syntax/hash calculation. Updated the matching exact entry incontracts/perf/exceptions.jsonandcontracts/perf/adoption-1058.json. No budgets, owners, reasons, or rule behavior changed. Commit:15d0d67b88f390eb6dc384e08b339ba1527145c4.Calendar/Mail/Money finding: the next
bun run checksurfaced a stalematerial.inline-style-resolutionhash in sharedpackages/ui/src/components/calendar/ActivityStack.svelte(style:217bb7d1d4cb1c92). The current parsed Svelte syntax hash is1e6ed8e9…, replacing the exact prior hash2f024a11…in the matching rows ofcontracts/perf/exceptions.jsonandcontracts/perf/adoption-1058.json. Budgets, owners, reasons, and rule behavior are unchanged. Commit:75788f8c3a3f02cbc64476188f760bae96750301.Calendar/Mail/Money finding: perf-lint then identified a second ActivityStack style exception whose identity changed when the hand-built stack layer became a shared
Card. The oldstyle:2486fb050ad813dfattribute no longer exists; the live Card style binding isstyle:60ec4ccb0f079c8awith exact current syntax hashbe04de23…. Updated that paired exception/adoption record. No limits, ownership, reasons, or rule behavior changed. Commit:f7a51c334dbdc83d054674a56c72db0275ba6a24.Calendar/Mail/Money finding: after the shared ActivityStack pins were aligned, perf-lint surfaced TimeGrid's existing
layout.observer-purposerecord. Its scope hash changed because the Calendar script now imports sharedPill; the resize observer itself is unchanged. Reproduced the old hash (46c3faf2…) from the starting commit and computed the current Tree-sitter scope hash (b96c78ea…). Updated only the paired exact entry incontracts/perf/exceptions.jsonandcontracts/perf/adoption-1058.json. Commit:69b2f611d6e5cbffd3a3a6b691adfb7e00782246.Calendar/Mail/Money finding: perf-lint found the existing YearHeatmap month-position inline-style exception after the date-cell markup changed to shared
Pill. The style-site identity remainsstyle:ea4ea4ad3d5ec4c8; its current exact AST hash is9ea2c2ab…. Updated the single matching entry incontracts/perf/exceptions.json; no limit, owner, reason, or rule behavior changed. Commit:f6b861c71c600ad53e7f5d3f323e755d7634a735.The final production recapture stopped at the 820 px 2× dark recovery-key flow. After clicking Create new key, the screenshot helper timed out after 15 seconds while waiting for the
Save your new recovery keyheading. The earlier final-build 390 px and 820 px captures remain present. I am tracing the recovery API action and will resume from 820 px 2× with status-only diagnostics; no recovery key text is logged or captured before redaction.Calendar/Mail/Money finding: adding the shared square heatmap swatch token changed the whole
packages/ui/src/tokens.csssyntax hash. The 18 existingmaterial.local-filtersites remain unchanged, but each combined exact pin includes that file hash. Verified the old first pin against the starting commit, recomputed all 18 live facts with the Svelte parser, and updated only their paired hashes incontracts/perf/exceptions.jsonandcontracts/perf/adoption-1058.json. No filter, budget, owner, reason, or rule behavior changed. Commit:bac20fea2c3ea998854e7c027d0ee2336f83d569.Files+Photos post-merge check finding: the live performance scan found stale exact hashes on existing list-rendering scopes in branch-touched Svelte files. It found no removed or new scopes. I refreshed only matching
hashfields incontracts/perf/exceptions.jsonandcontracts/perf/adoption-1058.json; limits, owners, reasons, counts andcontracts/perf/ratchet.jsonstayed unchanged.perf-lintnow reportsperf-lint: PASS; 0 violations; 22615 scoped exceptions. The requiredcd apps/web && bun run checkalso passes withsvelte-check found 0 errors and 0 warnings. It exposed two empty Calendar focus rulesets in merged sources; I removed those no-op selectors so the whole-web check passes.Commits:
09fb4a988(exact pin refresh),d33cbb38f(empty selector cleanup). The fullbun run testis running. I have attached 49 safe Files/Photos/UploadToast before/after PNG assets to this issue; share-folder screenshots remain withheld because their rendered state includes public-link URLs.The final 1440 px 2× recapture stopped after the auth screens.
waitForAppearanceLoadin the production screenshot helper timed out at 15 seconds while awaiting the Settings Appearance response; the error contained no HTTP status. I am extending only the ignored capture helper's page action/navigation timeouts to 60 seconds and resuming this desktop 2× set.The first full post-merge
bun run testcompleted with 3 failures (280 files passed, 3 failed; 1,987 tests passed, 3 failed). Two are source-contract assertions that no longer follow the shared owners in this branch:themes.test.tsexpects Card's old literal class string after Card gained thematerialvariant, andsidebar-weight.test.tsexpects a local.pin-linkrule after FilesSidebar moved that row to sharedPill shape="row". I will update those checks to keep the existing rendered contract on the shared primitives. The remainingEditorFormatBar.svelte.test.tstest timed out at 5,948 ms against its 5,000 ms limit; I will check it in isolation without changing its timeout or expectations.The desktop 2× retry timed out on a
/readyzpage navigation after 60 seconds. Playwright reported that it was waiting for the navigationloadevent; it did not report an HTTP failure status. The capture helper only uses this endpoint to stage the next theme, so I am changing that one navigation to wait for the response commit and then continue with the real Appearance save and Settings route.Resolved the full-suite findings without changing rendered expectations or timeouts:
Pill shape="row"now uses--sidebar-row-weight. The Files sidebar continues to use the shared row primitive, and its weight no longer lives in local CSS.glass-card.Focused command:
bunx vitest run src/lib/components/Pill.svelte.test.ts src/lib/styles/sidebar-weight.test.ts src/lib/themes.test.ts src/lib/components/Card.svelte.test.ts src/lib/editor/format/EditorFormatBar.svelte.test.ts --maxWorkers=2Output:
Test Files 5 passed (5)andTests 97 passed (97). Commits:9bbac94f4and3b007f3bb. I will run the full post-fix web check and test suite before finishing.#1190 Search restyle — complete
Branch:
job/restyle-searchHead:
18b791864eebcc8d7e772f91cd262c9bb54f877fMerged
origin/devat1a9729f96before the final checks. No push or merge was made.Built
Pillactions andTagPillfilters in the query field, palette actions, preview actions, saved-search menu trigger, and Tag page Load more action. The existingPillGroupandBlockHoverActionsremain untouched.OverlaySurface, its shared owner.ItemCard.gaptoken API (default stays 6px) so Search result icon alignment no longer styles ItemCard’s private root. Added a unit test and package docs.TaskColumnpin fromorigin/dev.Files
apps/web/src/lib/components/search-dialog.svelte,apps/web/src/lib/search/{SavedSearchList,SearchField,SearchPreview,SearchResultRow}.svelte,apps/web/src/routes/tag/[tag]/+page.svelte,packages/ui/src/components/{ItemCard,OverlaySurface}.svelte,packages/ui/src/components/ItemCard.svelte.test.ts,packages/ui/README.md, andcontracts/perf/{registry,adoption-1058,exceptions}.json.Gates and evidence
cd apps/web && bun run checkexited 0:The two warnings are empty CSS rules in untouched
AttachmentDeck.svelteandAgendaList.svelte.cd apps/web && bun run testexited 0:bun run buildexited 0. The real-server Search review passed with macOS platform signals and no CSP reports:Tag page screenshots were captured from the real-server production build. Search palette/preview and Tag page captures cover 390, 820, and 1440 px at 1× and 2×, light and dark; Search captures emulate macOS. Artifacts are in ignored
artifacts/restyle-search/(97 PNGs total). Saved-search sidebar captures are partial: 1× light at all widths and 1× dark at desktop. A repeated saved-sidebar capture hit a Playwright navigation race at tablet width.cargo build -p calternal-serverwas used only to run the local screenshot server. No Rust source changed, so Rust fmt/clippy/test crate gates were not applicable. Cleanup output:UX gaps and known gaps
OverlaySurfacewith feature-level shell selectors. The #1093 run checked row names, focus edge, preview action bounds, and the 44px touch preview path.atlasresults at 1440px mono. The #1093 production review passed on retry. RerunSEARCH_E2E_MACOS=1 SEARCH_E2E_1123_ONLY=1 bun e2e/search.mjs --screenshots artifacts/restyle-search/merge-roundin the merge round to verify that scroll state.fj issue commentCLI accepts text and--body-filebut has no file-attachment option. Screenshots remain in the ignored local artifact directory and are not attached to this comment.artifacts/restyle-audit.md) was absent in this worktree; I used the Search inventory posted in the issue comments.Decisions not spelled out in DESIGN.md
OverlaySurfacebecause it owns the surface, while leaving Search body layout in Search.ItemCard.gapproperty for host alignment. It uses a private CSS variable internally and preserves the existing default.TagPillfor colored tag filters and genericPillfor other Search controls. No new control variant was needed.Commits
3c9dd62c8expose shared Search surface alignment tokens549ca713duse shared controls in the Search palettef1a3529dfuse shared actions in Search results18b791864refresh exact Search source pinsFiles+Photos capture finding: the existing Photos Backgrounds retry screenshot helper captures the error state, clicks Retry, then waits for a link named “Open camera”. Its screenshot fixture is “Restyle background.jpg”, so that stale locator times out before the matrix completes. I left the existing expectation unchanged. A separate production-build run captured all six before variants and verified Retry loads the actual “Open Restyle background.jpg” item. The after matrix is running now.
Post-merge finding on
daa684c60:bun run testreports one failure insrc/lib/themes.test.ts: “uses the overlay alpha for every page card and one more opaque shared inner tile role.” The test still requires the glass default markupclass="card glass-card {cls}"atapps/web/src/lib/themes.test.ts:530. The Settings extension changed that root class to a conditional expression. I will keep the test unchanged and preserve the original glass class while applying the solid state as a separate shared class binding.Files+Photos restyle is complete.
Head SHA:
304a9bdd82ad0e5734fa76ababf7be27b2b92befBuilt
Screenshots
I attached 133 production-build PNGs to this issue: 66 before and 67 after. They cover every changed surface at 390, 820, and 1440 CSS pixels in light and dark. Phone and tablet captures use 2× output; desktop captures use 1× output. Browser contexts emulate macOS. One extra after image is a duplicate phone-light UploadToast capture.
The Backgrounds Retry capture helper has an old post-click locator. It waits for “Open camera” although its fixture is “Restyle background.jpg.” I left that existing expectation unchanged. A separate production-build capture produced all six before and six after images and verified that Retry loads “Open Restyle background.jpg.” This is a test-helper gap, not a product UX gap.
UX gaps closed / left
Closed: shared controls keep keyboard focus, button semantics, shortcut tooltips, and the shared touch hit floor. Retry was exercised against a real server item. The restyled surfaces keep their existing API, stable-link, and edit paths.
Left: the stale
settings-effects.mjs --restyle-retry-screenshots-onlylocator still times out after its first screenshot. The full visual matrix and Retry behavior were verified with the separate production-build capture.Expected cost: this is a presentation change. It adds no route, API call, background work, or per-item data operation.
Decisions not specified in DESIGN
--sidebar-row-weightfor shared Pill rows so Files pins keep their existing text weight after their local styling is removed.fillprop when its parent fixes the preview size; this keeps sizing in the shared primitive without layout measurement.Gates
cd apps/web && bun run checkcd apps/web && bun run testFocused shared-component checks:
Screenshot runs passed for Share (
SHARE RESTYLE SCREENSHOTS PASSED; CSP reports: 0 across 2 pages), Inspector (INFO_INSPECTOR_RESTYLE_SCREENSHOTS PASSED), and UploadToast (FILES UPLOAD TOAST RESTYLE SCREENSHOTS PASSED; CSP reports: 0 across 7 pages). Backgrounds Retry passed in the separate capture run.cargo build -p calternal-serverpassed to prepare the local screenshot server; no Rust source changed, so Rust crate gates did not apply. Final cleanup:Removed 8648 files, 7.3GiB total.No push, deploy, or merge was performed by this job. The required
origin/devmerge is in the branch history.Report correction and merge note: this job did perform the required local merge of
origin/devin commitbb55b9cc743b45915e43bb98b3e9ff3e9fb1c942before final gates. It did not push, deploy, or merge intodevor `main.After that merge, the perf source pins were refreshed by changing only exact hashes for existing entries; rules, limits, scopes, and the total count did not change. The full web check also found two empty focus CSS blocks in shared Calendar components. I removed those empty blocks so the required check could pass; they had no declarations and no rendered effect. These are the only out-of-area source files touched for the gate.
#1190 final report — Settings restyle
State: implementation committed; final verification is incomplete. Issue remains open. No push or deploy.
Head:
08b8c7ad1fc2d0fa9ba1e25350de6a06ea0ec534What changed
Settings cards, actions, status badges, overlays, upload targets, and toggle rows now use the shared UI components and tokens. The shared
Card,Pill,StatusPill, andOverlaySurfacegained small additive variants for the missing solid, compact, drop-target, dialog-size, and Settings-sheet treatments. The default glass Card class remains stable for existing theme checks. Exact performance pins were refreshed after syncing currentorigin/dev; no new exception scopes, limits, or ratchet counts were added.There are no new routes, API operations, background jobs, filesystem calls, or scans. Expected work per Settings action is unchanged; this change adds no IO.
Files
apps/web/src/lib/auth/components/{AuthCard,CreateAccountFlow,RecoverFlow,RecoveryKeyEntry,RecoveryKeyWords}.svelte,apps/web/src/lib/styles/auth-ui.cssapps/web/src/routes/settings/[...path]/+page.svelte;account/{AppPasswordsGroup,RecoveryKeySheet}.svelte;admin/SignInGroup.svelte;appearance/{BackgroundGroup,UnsplashSheet}.svelte;apps/CalendarFeedsGroup.svelte;connected-accounts/ConnectedAccountsSection.svelte;jobs/{JobDetails,MyJobsGroup}.svelte;notifications/NotificationsSection.svelte;parts/{RowAction,SettingsCard,StateChip}.svelte,parts/settings-forms.css;plugins/PluginsSection.svelte;voice/VoiceSection.sveltepackages/ui/src/components/{Card,OverlaySurface,Pill,StatusPill}.svelte,packages/ui/src/tokens.css,packages/ui/README.md;apps/web/src/lib/components/{Card,OverlaySurface,Pill,StatusPill}.svelte.test.ts;apps/web/src/routes/settings/parts/{ActionPills.svelte.test.ts,SettingsCard.svelte.test.ts}contracts/perf/{registry.json,exceptions.json,adoption-1058.json}The merge commit
daa684c60syncs currentorigin/dev; it also includes upstream files outside this issue’s owned area.UX gaps closed
UX gaps left: no interaction gap was found in the captured flows. The final post-merge production screenshots and a complete passing post-fix
bun run testrun remain outstanding. The visual reviewer has not reviewed a post-merge capture.Screenshots
The attached before/after archives contain the 17-surface matrix at phone 390, tablet 820, and desktop 1440; 1× and 2×; light and dark; with macOS platform emulation. They were captured before the final
origin/devsync. Local matrix validation found 204 PNGs per side, all dimensions correct, with no missing combinations. The merged production build was not recaptured before the job exceeded its four-hour limit.Gates
bun run checkexited 0 on the merged tree before the final Card class-binding fix:The two warnings are existing empty focus rules in
packages/ui/src/components/calendar/AttachmentDeck.svelteandAgendaList.svelte.The first post-merge full
bun run testrun caught the Card class contract below. The component now preserves the tested glass class and the focused regression tests pass. The full suite was not rerun after that fix:The failure was
themes.test.ts:530, which expectedclass="card glass-card {cls}". After the fix:cargo cleanoutput:Removed 0 files. No Rust files differ from currentorigin/dev, so Rust crate gates were not run. Web build output was removed. Working tree is clean.Decisions not specified by DESIGN
Card.material="solid",flatOnSheet, anddropTargetto keep auth, Settings, and upload material inside the shared owner.OverlaySurface.dialogSizeandsheetChrome="settings"for the Settings presentation.StatusPillsizing and reused shared Pill tones/shapes for Settings actions and states.Remaining verification
bun run checkandbun run teston08b8c7ad1after the Card class-binding fix.Progress update for #1190
The Calendar, Mail, Money, and Agenda before/after screenshot matrices are captured from production builds. Each area has 1x and 2x PNGs in light and dark at 390, 820, and 1440 CSS pixels. I am attaching the archives after upload checks.
Two test-contract regressions found during the web suite were fixed without changing old expectations: Pill now preserves exact child text, and Card keeps the existing glass-card/overlay source contracts mutually exclusive. Focused verification passed: 4 files, 103 tests.
Final web check output:
perf-lint: PASS; 0 violations; 22615 scoped exceptions;svelte-check found 0 errors and 4 warnings in 2 files(existing AgendaList empty ruleset and MailView unused swipe selectors).Full
bun run testresult on the shared host:Test Files 2 failed | 282 passed (284)andTests 2 failed | 1994 passed (1996). The unchanged failures wereKeyboardShortcutsCard.svelte.test.tstiming out in 5 seconds andSettingsCard.svelte.test.tsexpecting.touch-feedback; both passed when run focused: 2 files, 5 tests. I left those tests and their expectations unchanged.Starting #1190 on branch
job/restyle-search, continuing from head18b791864eebcc8d7e772f91cd262c9bb54f877f.Inspection findings for #1190:
apps/web/src/lib/components/search-dialog.svelteoverrides--glass-tray-washfor the sharedProgressiveBlur; its Search-only wash paints an opaque--surfacestop. I will remove the override and use the shared filter-only edge blur.apps/web/src/lib/search/SearchResultRow.svelteplacesnavigationdescriptions in the inline.metaslot. I will keep Navigate rows title-only, matching the other navigation results.apps/web/src/lib/search/SavedSearchList.sveltealready opens its menu on right-click, Shift+F10 / ContextMenu, and the shared touch long-press gesture, but always renders the ⋯ button. I will hide that button for fine pointers and cover the menu paths in e2e.#1190 Calendar + Mail + Money restyle report
Area completed: Calendar + Mail + Money. Head SHA:
9f2a4fd6c2ac32247097df51dcac91c07bc7e84e.Built
Pillfor date heat cells, time-grid actions and task chips; sharedCheckboxowns Task hit geometry; sharedCardowns ActivityStack layer materials. Removed local primitive styling in the Calendar surfaces covered by this pass.Cardfor the reader overlay material and sharedPillfor view actions.Cardfor forms and sharedPillfor register state and row actions.Card,PillandCheckboxAPI extensions with tests and package documentation. Updated exact perf pins for the changed styles.Files
apps/web/src/lib/mail/MailMorphCard.svelte,apps/web/src/lib/mail/MailView.svelte,apps/web/src/routes/calendar/[view]/[date]/+page.svelte,apps/web/src/routes/money/[budget]/[month]/+page.svelte,apps/web/src/routes/money/[budget]/accounts/[[account]]/+page.svelte.packages/ui/src/components/{Card,Checkbox,Pill}.svelte,packages/ui/src/components/calendar/{ActivityStack,AttachmentDeck,TaskCheckbox,TimeGrid,YearHeatmap}.svelte,packages/ui/src/tokens.css,packages/ui/README.md.apps/web/src/lib/components/{Card,Checkbox,Pill}.svelte.test.ts,apps/web/e2e/{agenda-decks-822,calendar,mail-layouts,money}.mjs,tests/adversarial/mail_screenshot_fixture.py.contracts/perf/{adoption-1058,exceptions,registry}.json.UX gaps closed / left
KeyboardShortcutsCard.svelte.test.ts > puts the current view group first and closes with Escapetimed out at 5000 ms, andSettingsCard.svelte.test.ts > copies the group link after a touch double-tapfailed on.touch-feedback. Their focused rerun passed.#tab-calendar[aria-selected=true]; the original Money runner hit a/money/importroute mismatch; the original Agenda deck runner failed its fan assertion. Separate capture-only runs completed the required screenshot matrices. These interaction probes need follow-up in their owning test work.Decisions
Cardowns surface material/tint/elevation and layout props;Pillowns square Calendar cells and shared semantic action states;Checkboxowns configurable hit size.PillGroup,BlockHoverActions, segmented controls and single-choice selectors were left untouched.origin/dev. The restyle removes the local overrides without changing that guard.Verification output
bun run check— exit 0:bun run test— exit 1:Focused rerun of the two failing files — exit 0:
bun run buildsucceeded. No Rust code changed, so Rust crate gates were not run.cargo clean:git diff --checkpassed; worktree is clean. No push, deploy or merge was made.Screenshot attachments
Finding during the required web check:
scripts/perf-lint --checkrejected threecoverage.surfacesadoption checkpoints forapps/web/src/lib/canvas/CanvasView.sveltebecause their hashes did not match the exact live ledger entries. I updated those three hashes incontracts/perf/adoption-1058.json; the scopes, limits, and ratchet counts did not change. Commit:07b5f08e46d23dec9530f765c67b820d3012f608. I will rerun the web checks after this correction.Finding in the first
bun run check:NotesExplorer.svelteusedevent.currentTargetwithout narrowing Svelte's nullableEventTargettype, so TypeScript reported two errors on the Notes overflow action. Added anHTMLButtonElementguard and committed it asb4dc163e4ed7b8b9709eec3b3433bec2731bac7d. I am rerunning the required gates on the corrected head.The next performance scan found the Notes edits had moved exact source fingerprints in the adopted ledger, including the reminder-picker
render.boundentry. I refreshed the changed live entries for the Notes and shared UI files touched by this job withscripts/perf-lint --adopt-7c. The refreshed ledger reportsperf-lint: PASS; 0 violations; 22359 scoped exceptions;contracts/perf/ratchet.jsondid not change. Commit:8df304af044f9a22faeea779987f63f1c17532dd.Notes audit finding: the design-rule guard detected local CSS selectors reaching into shared Pill roots in NoteContents and NotesExplorer. I replaced the Contents tick positioning with row flex alignment, moved Explorer tree depth into an additive shared Pill
rowDepthprop, and use layout slots for the per-row action. The focused Pill test passes (11 tests). The remaining guard findings are four pre-existing native buttons in UploadToast.svelte, an out-of-scope Files surface; I left that file unchanged. The Contents CSS change also moved one exact performance checkpoint, which I am refreshing at the same bound.Post-merge check finding: merging origin/dev changed the exact source hash for the existing CanvasView
render.blaze-adaptercheckpoint (CanvasView.svelte#each:3a4cbef6167607e4:1:adapter), soscripts/perf-lint --checkreported it unused or changed. This is an upstream checkpoint refresh, not a Notes behavior change. I am updating only the exact pin and keeping the ratchet unchanged.The first requested #1123 e2e attempt captured
search-1123-empty-1440-mono.pngand stopped in the new footer assertion. The browser reported footer height47.109375pxandscroll-padding-block-end47.12px; the assertion reported a zero reserve becauseparseFloat()cannot read the unresolvedcalc(...)custom property. I am updating the test to compare the resolved footermin-heightwith the scroll padding, then rerunning the flow.The targeted production-browser run has captured the specified 1093 desktop Tokyo Night preview and exercised the new last-result path. It found that keyboard selection reaches the final result, but the result does not scroll fully above the footer. The panel reports its scroll-padding reserve; I am adding geometry diagnostics to identify why reveal does not honor it before changing the shared Search behavior.
Notes restyle complete (#1190)
Head SHA:
bdc724847125d1f217845e0b57beac712c36d737Built
PillwithrowDepthfor hierarchical full-width rows. Added component tests and README guidance.NoteContentsrail rows to center their shared tick Pill with flex layout. Removed the feature-level Pill-root positioning selector.NotesExplorerto pass tree depth toPilland use layout slots for the trailing action. Removed feature-level shared-Pill root overrides and the Notes guard allow-list entries.origin/devmerge.Shared controls on these surfaces:
Pillrenders Contents heading actions, explorer rows and per-Note actions; the phone Contents sheet uses sharedOverlaySurface; the explorer section actions use the existing sharedPillGroup.Screenshots
Production-build screenshots use macOS platform emulation. Before/after sets cover both surfaces at 390, 820 and 1440 CSS px, in light and dark, at 1x and 2x. Metadata checks confirmed 1x images match viewport dimensions and 2x images are exactly double. Files are under
artifacts/restyle-notes/{before,after}/{1x,2x}/{notes,contents}/.I also packaged the 48 PNGs into four archives under
artifacts/restyle-notes/. ThefjCLI has no attachment command, and no usable API credential was available to the upload attempt, so the archives remain local and are not attached to this issue.UX gaps closed
Removed local styling around shared Pills and kept tree indentation within the shared primitive. Contents ticks now align through the row layout.
UX gaps left
No interaction gaps remain in the changed surfaces. Screenshot archives could not be attached to this issue; their local artifact paths are listed above.
Decisions
DESIGN §34 does not define tree-row indentation values.
Pilluses a 1.6rem base inset and adds 0.95rem perrowDepth; the calculation is constant-time per row.Gates
bun run check:The two warnings are existing empty CSS rulesets in
AttachmentDeck.svelte:1055andAgendaList.svelte:1277.bun run test --maxWorkers=2:Focused Pill test: 1 file, 11 tests passed.
cargo clean:Removed 8648 files, 7.3GiB total. No Rust source changed, so Rust crate gates were not run.Starting the targeted #1190 follow-up on branch job/restyle-files, resuming from
304a9bdd82. I will fix the selected burst thumbnail and shared Quick Look progressive blur, add the browser regression assertion, and capture the requested Photos viewer screenshots.Starting the Settings phone-sheet correction on
job/restyle-settingsat08b8c7ad1, from common base5301e0208. I will mergejob/settingsreg-1195first, fix the full-height phone sheet and add its 390 px e2e assertion, then recapture every Settings section at 390/820/1440 in light and dark.The reviewed artifact
artifacts/restyle-files-after/photos-key-photo-action-1440-tokyo-night.pngshows the selected fourth burst frame as an empty thumbnail. The strip currently leaves every thumbnailloading="lazy"; selection does not make the current frame eager, so the browser can skip loading it while it is outside the horizontal lazy-load margin. I added eager loading for the selected frame and an e2e check for decoded pixels in every burst thumbnail.The post-build #1093 screenshot rerun exposed an e2e issue in the new last-result check: a transient toast could cover the “See all” pointer target. The Search action supports the documented macOS ⌘↩ shortcut, so the check now expands with that keyboard action before moving to the final row. The check remains focused on the final row’s geometry relative to the footer.
Evidence from the returned
settings-recovery-key-390-1x-dark.png(390×844): the Settings sheet occupies y=212..623, so the Calendar page title remains visible above it and the sheet does not reach the viewport bottom. The recovery group also inheritsscroll-margin-top: -1.5reminSettingsCard.svelte; the route'sscrollIntoView({ block: 'start' })therefore puts its heading under the sheet's sticky header. I mergedjob/settingsreg-1195and am wiring its page-wide scrim and Settings header reserve into a shared full-viewport phone sheet. The e2e will check the section page and the Recovery Key deep link.The #1123 rerun exposed a setup gap in its inherited #1137 sticky-heading check: the compact Atlas query had two options and a 174px scrollport with no scroll range, so the sticky heading could not activate. I kept its geometry and blur assertions unchanged and updated the setup to use the existing ⌘↩ See all action before measuring the sticky state.
Completed Search restyle fixes on
job/restyle-search.Head:
4b305a898359858055d1de5458af905229780971Built: reserved the Search result footer in the scrollport and kept the selected last result above it; removed the opaque mobile footer wash; made Navigate rows title-only; added shared
Pill.rowMenuActionbehavior so the touch action stays available on coarse pointers while fine-pointer sidebar rows use their context menu. Right-click, Shift+F10, ContextMenu and touch long-press checks are included.Files changed:
apps/web/src/lib/components/search-dialog.svelteapps/web/src/lib/search/SearchResultRow.svelteand.test.tsapps/web/src/lib/search/SavedSearchList.svelteapps/web/e2e/search.mjspackages/ui/src/components/OverlaySurface.sveltepackages/ui/src/components/Pill.svelteandpackages/ui/README.mdapps/web/src/lib/components/Pill.svelte.test.tscontracts/perf/adoption-1058.json,contracts/perf/exceptions.jsonDecision: the design rules did not name an API for a row menu action. I added the documented
Pill.rowMenuActionprop and kept its position and pointer rules in the shared Pill.UX gaps closed: selected-last rows are kept above the footer at 1440/820/390 widths in light and dark; mobile Search uses the shared progressive blur without a white slab; Navigate rows show titles only; desktop sidebar rows have no direct ⋯ button and their menu remains reachable by pointer, keyboard and touch.
New screenshot paths:
apps/web/artifacts/restyle-search/rerun/search-1190-selected-last-{1440,820,390}-{mono,noir}.pngapps/web/artifacts/restyle-search/rerun/search-saved-sidebar-restyle-{1440,820,390}-{mono,noir}.pngapps/web/artifacts/restyle-search/rerun/search-palette-empty-390-paper.pngartifacts/restyle-search/rerun/search-1093-selected-preview-1440-tokyo-night.pngGates, output quoted verbatim:
bun run check(exit 0):The two warnings are existing empty CSS rulesets in
AttachmentDeck.svelteandAgendaList.svelte.bun run test(exit 0):The post-build #1093 run completed all #1190 selected-last and sidebar assertions and captured the new screenshots, then timed out in the additional Atlas preview lookup. The requested
SEARCH_E2E_1123_ONLY=1rerun had passed earlier in this job; after the final build, reruns stopped at the inherited #1137 sticky-heading check because the Atlas results had no scroll range (latest diagnostic: 8 options,scrollTop=0,clientHeight=scrollHeight=729). I did not change that assertion. These are remaining e2e verification gaps outside the three #1190 UI fixes.The focused real-server screenshot run uploaded all five burst files, but the fixture timed out waiting for all thumbnail derivatives. The server logged
ERROR calternal_plugin::media_sandbox: native media command failed; ... cause=NamespaceResources, and two thumbnails stayed unavailable. I will merge origin/dev once and retry with its local media sandbox ceiling change before final verification.Merged
origin/devas67fff73ba. Resolved the sharedCardandStatusPillconflicts by keeping both branches' props, behavior, tests and docs. The merged live perf inventory required 277 exact source-hash refreshes; each live scope and limit was preserved, and no exception or adoption checkpoint was removed.bun run checkwill verify the result.#1190 final report
Branch:
job/restyle-filesHead:
70d6f0bc5c895835c41f8fc5003716ee28d89003Working tree: clean
Built
PhotoViewer.svelteeagerly loads the selected burst frame thumbnail. Other frames remain lazy. The Photos e2e fixture uploads a real five-frame burst, waits for all five generated thumbnails, scrolls each choice into view, and asserts everyimghasnaturalWidth > 0, including the selected frame.QuickLook.svelteomits the full-widthProgressiveBlurband in fullscreen Photos. The floating controls keep their shared glass material. The e2e screenshot path asserts that the band is absent.origin/devmerge. The ledger still has 22,548 scopes: 328 existing scope hashes changed, with no scopes added or removed, no recorded limits changed, and no ratchet change.Files for the fix:
apps/web/src/lib/photos/PhotoViewer.svelte,apps/web/e2e/photos.mjs,packages/ui/src/components/viewer/QuickLook.svelte,contracts/perf/adoption-1058.json,contracts/perf/exceptions.json.Screenshots
Captured from the production web build with macOS platform emulation, at CSS viewport widths 390, 820 and 1440, in paper-white and tokyo-night. The six actual-size screenshots are attached:
Verification
The focused production e2e run ended with:
bun run checksummary (verbatim):bun run testsummary (verbatim):The suite also printed jsdom
scrollTo()and CSS parser notices; all tests passed.UX gaps closed
UX gaps left / known gaps
cd apps/web && bun run test:e2e— verify the integrated browser flows after the branch merge. No API behavior changed in this job.Decisions
docs/DESIGN.mddoes not specify whether fullscreen Photos should show a full-width progressive blur across the photo edge and stage gutters. I omitted that band in this shared fullscreen viewer because the filtering caused the reported corner artifacts; the floating controls retain shared glass.N-1frame thumbnails stay lazy until needed. The real five-frame e2e burst checks the decode path.Commits:
a290e77a4(selected burst thumbnail),15fed8c8d(requiredorigin/devmerge),47516aac2(exact performance pins),70d6f0bc5(shared fullscreen blur fix).Starting #1190 follow-up on branch job/restyle-search. Worktree start SHA:
4b305a8983. I will trace the filter option alignment to the earlier Pill change, add a focused e2e assertion, verify Notes/Files/Tags sidebar rows against origin/dev, and capture the requested palette screenshots.Finding: artifacts/restyle-search/rerun/search-1190-selected-last-1440-noir.png shows TYPE options starting around x=192 while the TYPE heading starts around x=134; the same centered layout repeats under DATE, TAG, FOLDER and PERSON. The
rowMenuActionclass is only attached to SavedSearchList’s menu button, so it cannot affect these facet rows. Search changed its native facet buttons to sharedPillbuttons; the feature-scoped.facetroot rules do not style a child component root, and Pill centers the content wrapper by default. I will add an opt-in start-aligned Pill layout for these desktop facet rows and leave other Pill users at their current default.Found during the 1440px production review:
.contenthas a negative shadow margin that overlapped.rail-edge, so pointer input landed on content and the rail stayed at 256px. The separator now sits above that gutter. A focused production check confirms the edge receives the drag, reaches 280px, and two shared 48px keyboard steps reach the existing 184px minimum. The complete 1440px light and dark captures now pass.Completed: Settings restyle follow-up
Branch:
job/restyle-settingsHead:
ccd5502471df71dcd973f148e767c9b7d4541386What changed
OverlaySurfacecomponent and shared tokens.UX gaps closed
UX gaps left
apps/web/e2e/settings-overlay-1195.mjssetup times out atgetByLabel('Budget name')on the current empty Money route, before it reaches the overlay. I did not change that unrelated setup. I checked the real shared Settings scrim separately from a real Calendar route; it passed at 390, 820 and 1440 px in both themes.Screenshots
Files
apps/web/src/routes/settings/[...path]/+page.svelteapps/web/e2e/settings-review-50.mjspackages/ui/src/components/OverlaySurface.sveltecontracts/perf/exceptions.jsoncontracts/perf/adoption-1058.jsonDecisions
OverlaySurfacefull-viewportsize for the phone sheet. The Settings-specific choice is to keep its heading in the sheet header and start section content below that header.Verification
bun run checkexited 0. Relevant output, verbatim:The one warning is the existing empty CSS ruleset in
packages/ui/src/components/calendar/AttachmentDeck.svelte:1055.bun run testexited 0. Output, verbatim:The review e2e passed its requested section matrix and route checks. Output, verbatim:
The separate Calendar-route scrim review passed at all six width/theme combinations.
bun run buildexited 0; final output:git diff --checkandnode --check apps/web/e2e/settings-review-50.mjsexited 0 with no output. No Rust source changed, so Rust crate gates were not run. Cleanup output, verbatim:Completed on
job/restyle-search.Change
Added an opt-in
alignStartprop to sharedPilland used it only on desktop Search facet options. The facet labels now use the same--toolbar-gapinset as their section headings. The default Pill layout and phone chip rail stay unchanged. Counts follow their labels.The real-browser e2e checks all five facet sections and asserts each option label starts within 1 px of its heading. It also checks that counts do not overlap labels.
Verification
bun run check— exit 0:The one warning is the existing empty CSS ruleset in
packages/ui/src/components/calendar/AttachmentDeck.svelte:1055.bun run test— exit 0:Real-server production e2e — exit 0:
The Search filter screenshots use macOS emulation and cover 1440 px and 390 px in light (
mono) and dark (noir). The Notes, Files and Tags sidebar crops match the detachedorigin/devbuild at3601719b8pixel-for-pixel in both themes: changed pixels0for each crop.Review artifacts
The four Search filter captures are in
artifacts/restyle-search/rerun/. The origin/current/sidebar pixel-diff captures are inartifacts/restyle-search/sidebar-diffs-1190/.The installed
fj issue commentcommand has no attachment/upload option, so these screenshots remain in the worktree for review and are not committed.Decision
DESIGN §32 does not specify how a shared Pill should expose row alignment. I added the smallest opt-in prop and enabled it only for desktop Search facets; other Pill users are unaffected.
Head:
4aacba651ac91179b33c630aff774a8d22bbd076(Align Search filter facets with headings). Requiredorigin/devmerge is in02ecbacf6.