Merged feature-key classification tests require incompatible names #1350

Open
opened 2026-10-07 10:38:53 +00:00 by kayg · 1 comment
Owner

Merge round 33 (#1122) combines production round-31 classification coverage with round-32 #1297 coverage. Both test expectations are preserved, as required by the owner rule.

The same ROUTE_ID_FIELDS["admin_feature_flag_put"] is required to equal instance_feature_flag_id at line 42 and feature_flag_id at line 79 of tests/adversarial/test_xuser_classification.py. The current implementation uses the explicit Instance key name from #1297; route authority and the live matrix remain intact.

Reproduce: python3 -m unittest discover -s tests/adversarial -p test_xuser_classification.py.

Verbatim output:

AssertionError: 'instance_feature_flag_id' != 'feature_flag_id'
Ran 20 tests in 0.517s
FAILED (failures=1)

Please review which classification spelling the older regression must use. This is a test-contract conflict, not an observed authorization bypass.

Merge round 33 (#1122) combines production round-31 classification coverage with round-32 #1297 coverage. Both test expectations are preserved, as required by the owner rule. The same `ROUTE_ID_FIELDS["admin_feature_flag_put"]` is required to equal `instance_feature_flag_id` at line 42 and `feature_flag_id` at line 79 of `tests/adversarial/test_xuser_classification.py`. The current implementation uses the explicit Instance key name from #1297; route authority and the live matrix remain intact. Reproduce: `python3 -m unittest discover -s tests/adversarial -p test_xuser_classification.py`. Verbatim output: ``` AssertionError: 'instance_feature_flag_id' != 'feature_flag_id' Ran 20 tests in 0.517s FAILED (failures=1) ``` Please review which classification spelling the older regression must use. This is a test-contract conflict, not an observed authorization bypass.
Author
Owner

#1350 corrected in 33e0d90e0, per the merge33b brief. The current route classifier uses instance_feature_flag_id from #1297. The older #1202 test now uses that name and cites #1350/#1297; it still checks the route review and unrelated Notification identifier. The newer test is retained. No classifier or production behavior changed.

Focused output, verbatim:

....................
----------------------------------------------------------------------
Ran 20 tests in 0.798s

OK
#1350 corrected in 33e0d90e0, per the merge33b brief. The current route classifier uses `instance_feature_flag_id` from #1297. The older #1202 test now uses that name and cites #1350/#1297; it still checks the route review and unrelated Notification identifier. The newer test is retained. No classifier or production behavior changed. Focused output, verbatim: ``` .................... ---------------------------------------------------------------------- Ran 20 tests in 0.798s OK ```
Commenting is not possible because the repository is archived.
No labels
No milestone
No project
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kayg/calternal-v0#1350
No description provided.