Server Mail migration review tests assume version 9 is latest #1010

Open
opened 2026-10-03 14:25:06 +00:00 by kayg · 0 comments
Owner

The #984 follow-up server gate found two failures before their migration-order checks run:

  • integrations::tests::independent_review::mail_626_and_connected_accounts_apply_in_both_orders
  • integrations::tests::independent_review::populated_0012_and_mail_0009_preserve_links_in_both_orders

Both stop at crates/calternal-server/src/integrations_review.rs:88. The helper checks that the last Mail migration is version 9. The actual version is 10. The supplied #984 base 5153660807 already has this assertion and crates/plugins/mail/migrations/0010_preference_revision.sql. Neither file changed in the Money follow-up.

Command: cargo test -p calternal-server -- --test-threads=4

Verbatim output:

assertion `left == right` failed
  left: 10
 right: 9

test result: FAILED. 159 passed; 2 failed; 5 ignored; 0 measured; 0 filtered out; finished in 21.75s

The owner rule requires that existing expectations stay unchanged unless the issue changes that behavior. The Money job preserved both expectations. Review the helper against the current migration set. Keep the exact #626 SQL check and the migration-order, cache-preservation and idempotence checks. This finding does not show incorrect migration data; execution stops at the version assertion.

Reported from job/moneyfu-984 at 79b61c6cf. Raw output is retained at artifacts/money-984-followup/server-test.log in that worktree.

The #984 follow-up server gate found two failures before their migration-order checks run: - integrations::tests::independent_review::mail_626_and_connected_accounts_apply_in_both_orders - integrations::tests::independent_review::populated_0012_and_mail_0009_preserve_links_in_both_orders Both stop at crates/calternal-server/src/integrations_review.rs:88. The helper checks that the last Mail migration is version 9. The actual version is 10. The supplied #984 base 51536608075333dbaff7a92ad0d894fdd72c827c already has this assertion and crates/plugins/mail/migrations/0010_preference_revision.sql. Neither file changed in the Money follow-up. Command: cargo test -p calternal-server -- --test-threads=4 Verbatim output: ``` assertion `left == right` failed left: 10 right: 9 test result: FAILED. 159 passed; 2 failed; 5 ignored; 0 measured; 0 filtered out; finished in 21.75s ``` The owner rule requires that existing expectations stay unchanged unless the issue changes that behavior. The Money job preserved both expectations. Review the helper against the current migration set. Keep the exact #626 SQL check and the migration-order, cache-preservation and idempotence checks. This finding does not show incorrect migration data; execution stops at the version assertion. Reported from job/moneyfu-984 at 79b61c6cf. Raw output is retained at artifacts/money-984-followup/server-test.log in that worktree.
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kayg/calternal#1010
No description provided.