kayg/calternal

Watch

Fork 0

Settings sidebar: Tabs group lists plugins; Notifications appears twice #1040

New issue

Closed

opened 2026-10-04 07:12:29 +00:00 by kayg · 4 comments

kayg commented

2026-10-04 07:12:29 +00:00

Owner

Finding (orchestrator, from the owner's Settings screenshot, 2026-10-04, production `6074f71d1`)

The Tabs group in the Settings sidebar lists real Tabs (Calendar, Notes, Files, Photos, Mail, Analytics, Money) and then five entries with the generic plug icon: Notifications, Search, System, Tags, Video. These are plugins, not Tabs. "Notifications" also appears a second time under You, so the sidebar shows two different "Notifications" rows.

Wanted

The Tabs group lists only Tabs (items in the mode tray).
Plugin settings that are not Tabs live under Plugins (You → Plugins) or the group DESIGN §50 assigns them to; check §50 first and follow it.
No two sidebar rows share a label. If both settings pages must exist, give them distinct, user-friendly names (no jargon).
Each moved section keeps its deep link working (old link redirects to the new location, DESIGN §33).

Acceptance

Screenshots of the real build (light/dark), the deep-link redirect test, bun run check and bun run test verbatim.

## Finding (orchestrator, from the owner's Settings screenshot, 2026-10-04, production 6074f71d1) The **Tabs** group in the Settings sidebar lists real Tabs (Calendar, Notes, Files, Photos, Mail, Analytics, Money) and then five entries with the generic plug icon: **Notifications, Search, System, Tags, Video**. These are plugins, not Tabs. "Notifications" also appears a second time under **You**, so the sidebar shows two different "Notifications" rows. ## Wanted - The Tabs group lists only Tabs (items in the mode tray). - Plugin settings that are not Tabs live under **Plugins** (You → Plugins) or the group DESIGN §50 assigns them to; check §50 first and follow it. - No two sidebar rows share a label. If both settings pages must exist, give them distinct, user-friendly names (no jargon). - Each moved section keeps its deep link working (old link redirects to the new location, DESIGN §33). ## Acceptance Screenshots of the real build (light/dark), the deep-link redirect test, `bun run check` and `bun run test` verbatim.

plugins-1440-light-catalog.png

1 MiB

plugins-1440-dark-catalog.png

896 KiB

sidebar-1440-light-default.png

1,018 KiB

sidebar-1440-dark-default.png

833 KiB

sidebar-390-light-default.png

267 KiB

sidebar-390-dark-default.png

276 KiB

kayg commented

2026-10-04 07:13:35 +00:00

Author

Owner

Starting work on branch job/setside-1039 from base 6074f71d1. I am checking DESIGN §§33 and 50 and the current plugin navigation before the #1040 Settings grouping change.

Starting work on branch job/setside-1039 from base 6074f71d1. I am checking DESIGN §§33 and 50 and the current plugin navigation before the #1040 Settings grouping change.

kayg commented

2026-10-04 07:21:20 +00:00

Author

Owner

Finding: tabSettingsSections() orders actual Tab IDs, then appends every remaining enabled Plugin, including Notifications, Search, System, Tags and Video. Those entries create duplicate Notifications and generic no-settings pages; the existing Plugins page already owns the non-Tab Plugin catalog.

kayg referenced this issue from a commit

2026-10-04 07:30:19 +00:00

Keep non-Tab plugins out of Settings Tabs (#1040)

kayg referenced this issue

2026-10-04 08:02:20 +00:00

Settings sidebar: User/Admin bigger than group headings, indent nested items #1039

kayg commented

2026-10-04 08:02:24 +00:00

Author

Owner

Completed #1040. READY FOR MERGE: yes.

Enabled Tab Bar Plugins are the only entries in the Tabs group. Non-Tab Plugin settings stay under User → You → Plugins, Notifications has one Settings row, and old non-Tab paths and #tabs/... links resolve to their new home. The issue resolution differs from the older example in DESIGN §50, so I followed #1040 and left the design document for owner reconciliation.

The production screenshots are attached here: Plugins catalog, light, Plugins catalog, dark, desktop sidebar, light, desktop sidebar, dark, phone sidebar, light, phone sidebar, dark. More sizes, narrow-sidebar views, and alignment crops are linked in the final report on #1039.

bun run check passed with 0 errors and 0 warnings. Focused Vitest passed: 2 files, 18 tests. The full bun run test suite is reserved for the merge round by the 2026-10-02 verification policy. The Settings-open profile now records the sidebar composition; it was not measured because this is not a performance issue.

Commits: 2e2caa219 (Settings routing) and e4bebd97e (profile). Combined head: e4bebd97e8e816098a3da5197a8624034f5ea7f1.

Completed #1040. **READY FOR MERGE: yes.** Enabled Tab Bar Plugins are the only entries in the Tabs group. Non-Tab Plugin settings stay under User → You → Plugins, Notifications has one Settings row, and old non-Tab paths and `#tabs/...` links resolve to their new home. The issue resolution differs from the older example in DESIGN §50, so I followed #1040 and left the design document for owner reconciliation. The production screenshots are attached here: [Plugins catalog, light](https://git.kayg.org/attachments/57cf5210-8456-49f6-8849-2f1f49258aea), [Plugins catalog, dark](https://git.kayg.org/attachments/1d616f27-26b5-4794-be91-41f1a4c54e13), [desktop sidebar, light](https://git.kayg.org/attachments/d8f3b67c-1210-4c0c-9c42-5f935a8d4ff8), [desktop sidebar, dark](https://git.kayg.org/attachments/06c4af2a-b983-4c4c-be93-d3ccb4256134), [phone sidebar, light](https://git.kayg.org/attachments/87620633-a43b-47bb-ad1f-1988b261c91e), [phone sidebar, dark](https://git.kayg.org/attachments/e460983d-c743-4de7-976e-4d5ea365692f). More sizes, narrow-sidebar views, and alignment crops are linked in the final report on #1039. `bun run check` passed with 0 errors and 0 warnings. Focused Vitest passed: 2 files, 18 tests. The full `bun run test` suite is reserved for the merge round by the 2026-10-02 verification policy. The Settings-open profile now records the sidebar composition; it was not measured because this is not a performance issue. Commits: `2e2caa219` (Settings routing) and `e4bebd97e` (profile). Combined head: `e4bebd97e8e816098a3da5197a8624034f5ea7f1`.

kayg referenced this issue from a commit

2026-10-04 08:09:42 +00:00

Track Settings sidebar in open profile (#1040)

kayg commented

2026-10-04 09:53:02 +00:00

Author

Owner

Deployed to production (2026-10-04, small round 6 = `c39ffe5d9`)

Round: dev d0fc1f463 + job/setside-1039 + job/paste-1036 (web only). Gates on the round: web check COMPLETED 2005 FILES 0 ERRORS 0 WARNINGS, web tests Tests 1118 passed (1118), editor tests Tests 410 passed (410), PASTE-1036 E2E PASSED (WebKit, 390/820/1440 light/dark, image saved as a Home file and rendered after reload). Staging healthy first.

## Deployed to production (2026-10-04, small round 6 = c39ffe5d9) Round: dev d0fc1f463 + job/setside-1039 + job/paste-1036 (web only). Gates on the round: web check `COMPLETED 2005 FILES 0 ERRORS 0 WARNINGS`, web tests `Tests 1118 passed (1118)`, editor tests `Tests 410 passed (410)`, `PASTE-1036 E2E PASSED` (WebKit, 390/820/1440 light/dark, image saved as a Home file and rendered after reload). Staging healthy first.

kayg closed this issue

2026-10-04 09:53:03 +00:00

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

kayg/calternal#1040

No description provided.

Rows
Columns