Merge 7b: Month and Pill tests use superseded source-label and focus contracts #1046

New issue

Closed

opened 2026-10-04 09:15:47 +00:00 by kayg · 1 comment

kayg commented

2026-10-04 09:15:47 +00:00

Owner

The required production dev (6074f71d1) merge into merge round 7b2 (0c4fd513e) adds tests with two stale contracts:

apps/web/src/lib/calendar/MonthGrid.svelte.test.ts selects Log: Journal move in three tests. The round's MonthGrid uses Journal: Journal move. CONTEXT.md explicitly requires Journal as the UI source label.
apps/web/src/lib/components/Pill.svelte.test.ts requires the literal outline: var(--focus-ring); inside Pill.svelte. The round centralizes that rule in packages/ui/src/tokens.css (§34, #658). The merged Pill retains the transparent action border and shared focus behavior.

These assertions are retained under the owner rule that jobs must not change existing test expectations to make gates pass. The merge round must decide and update the expected source label and focus-rule ownership, then rerun the focused tests. This affects verification, not a demonstrated runtime defect. A separate GridColumn merge conflict restored a deleted pileWidth reference; that compile defect was removed in 7bfix-photos.

The required production dev (6074f71d1) merge into merge round 7b2 (0c4fd513e) adds tests with two stale contracts: * apps/web/src/lib/calendar/MonthGrid.svelte.test.ts selects `Log: Journal move` in three tests. The round's MonthGrid uses `Journal: Journal move`. CONTEXT.md explicitly requires Journal as the UI source label. * apps/web/src/lib/components/Pill.svelte.test.ts requires the literal `outline: var(--focus-ring);` inside Pill.svelte. The round centralizes that rule in packages/ui/src/tokens.css (§34, #658). The merged Pill retains the transparent action border and shared focus behavior. These assertions are retained under the owner rule that jobs must not change existing test expectations to make gates pass. The merge round must decide and update the expected source label and focus-rule ownership, then rerun the focused tests. This affects verification, not a demonstrated runtime defect. A separate GridColumn merge conflict restored a deleted pileWidth reference; that compile defect was removed in 7bfix-photos.

kayg referenced this issue from a commit

2026-10-04 09:34:03 +00:00

merge: retain production dev changes alongside round 7b fixes

kayg referenced this issue

2026-10-04 09:57:16 +00:00

Plan: merge order and conflicts for merge round 7b #867

kayg referenced this issue from a commit

2026-10-04 10:00:54 +00:00

fix(calendar): retain Task title focus and shared-read movement guards

kayg referenced this issue

2026-10-04 10:26:17 +00:00

Plan: merge order and conflicts for merge round 7b #867

kayg commented

2026-10-04 10:26:18 +00:00

Author

Owner

The full web suite also reproduced the known #1046 Pill source-ownership failure. The old test requires the focus outline literal inside Pill.svelte, while #658 centralizes it in tokens.css. The round keeps the transparent border assertion and all button/link/tone/material cases. It now asserts the exact shared focus rule and offset and rejects a local outline. Updated the stale Pill comments in the same change. This is a test ownership correction; it changes no runtime Pill style.

Focused validation, verbatim:

 Test Files  2 passed (2)
      Tests  7 passed (7)

The full suite is still running. No full-suite pass is claimed yet.

The shared focus guard found two imported production Retry rules in NoteEditorSurface.svelte and NoteImageView.svelte. Both copied outline: var(--focus-ring) with a 2px offset. Removing them lets the existing shared token rule retain the same ring and avoids a second owner (#658). The full web suite also reproduced the known #1046 Pill source-ownership failure. The old test requires the focus outline literal inside Pill.svelte, while #658 centralizes it in tokens.css. The round keeps the transparent border assertion and all button/link/tone/material cases. It now asserts the exact shared focus rule and offset and rejects a local outline. Updated the stale Pill comments in the same change. This is a test ownership correction; it changes no runtime Pill style. Focused validation, verbatim: ```text Test Files 2 passed (2) Tests 7 passed (7) ``` The full suite is still running. No full-suite pass is claimed yet.

kayg referenced this issue

2026-10-04 10:28:32 +00:00

Plan: merge order and conflicts for merge round 7b #867

kayg referenced this issue

2026-10-04 11:00:12 +00:00

Plan: merge order and conflicts for merge round 7b #867

kayg referenced this issue

2026-10-04 11:55:47 +00:00

Plan: merge order and conflicts for merge round 7b #867

kayg referenced this issue from a commit

2026-10-04 12:02:20 +00:00

fix(calendar): retain Task title focus and shared-read movement guards