Theme menu: family submenus hidden in Auto/System during daytime (dark variants only offered while dark)

kayg commented

2026-09-30 09:43:30 +00:00

Owner

Owner report (2026-09-30, screenshot): "the subdropdowns are gone?"

The Theme menu shows a flat list with no family submenus. Cause: familyVariants(family, scheme) in packages/ui/src/themes.ts returns variants only when the CURRENT scheme is dark. The owner uses Auto (light by day), so in daytime the dark-variant submenus (Catppuccin Mocha/Frappé/Macchiato, Rosé Pine Main/Moon, ...) are never offered, even though Auto WILL switch to dark at night.
Fix:

When the colour scheme is Auto or System, always show each family's submenu with its dark-variant choice (labelled, for example "At night: Mocha"), because the variant will apply later.
Light families with more than one light variant (if any) show those too.
In Light only: hide the dark variants. In Dark only: current behaviour.
Keyboard: → opens the submenu, and the diagonal pointer path keeps it open (existing behaviour, keep it).
Tests: the ThemePicker unit tests for Auto, System, Light and Dark, and the e2e opening a submenu in Auto during the day.
Screenshots at 1440 and 390 in both themes.

## Owner report (2026-09-30, screenshot): "the subdropdowns are gone?" The Theme menu shows a flat list with no family submenus. **Cause:** `familyVariants(family, scheme)` in `packages/ui/src/themes.ts` returns variants only when the CURRENT scheme is dark. The owner uses **Auto** (light by day), so in daytime the dark-variant submenus (Catppuccin Mocha/Frappé/Macchiato, Rosé Pine Main/Moon, ...) are never offered, even though Auto WILL switch to dark at night. **Fix:** - When the colour scheme is Auto or System, always show each family's submenu with its dark-variant choice (labelled, for example "At night: Mocha"), because the variant will apply later. - Light families with more than one light variant (if any) show those too. - In Light only: hide the dark variants. In Dark only: current behaviour. - Keyboard: → opens the submenu, and the diagonal pointer path keeps it open (existing behaviour, keep it). - Tests: the ThemePicker unit tests for Auto, System, Light and Dark, and the e2e opening a submenu in Auto during the day. - Screenshots at 1440 and 390 in both themes.

dark-390.png

81 KiB

dark-1440.png

233 KiB

auto-day-light-820.png

163 KiB

dark-820.png

164 KiB

auto-day-light-1440.png

235 KiB

auto-day-light-390.png

76 KiB

auto-day-light-390.png

98 KiB

dark-1440.png

234 KiB

dark-390.png

111 KiB

auto-day-light-820.png

210 KiB

dark-820.png

190 KiB

auto-day-light-1440.png

234 KiB

kayg commented

2026-09-30 09:45:29 +00:00

Author

Owner

Started work on branch job/theme-variants-506, based on origin/dev at 3c172f73d99eb2a803132af8c6878b8f6a51f7a4.

Started work on branch `job/theme-variants-506`, based on `origin/dev` at `3c172f73d99eb2a803132af8c6878b8f6a51f7a4`.

kayg commented

2026-09-30 09:48:26 +00:00

Author

Owner

Root cause confirmed in the current code: AppearanceSection.svelte resolves both auto and system to the active light/dark palette before it renders ThemePicker (lines 14–20). ThemePicker.svelte passes that resolved scheme to familyVariants (line 45), and themes.ts returns no variants for light (lines 215–217). This removes all family submenus during daytime even though Auto/System will use a dark palette later. The picker needs the saved colour-scheme choice as well as the currently active palette scheme.

Root cause confirmed in the current code: `AppearanceSection.svelte` resolves both `auto` and `system` to the active `light`/`dark` palette before it renders `ThemePicker` (lines 14–20). `ThemePicker.svelte` passes that resolved scheme to `familyVariants` (line 45), and `themes.ts` returns no variants for `light` (lines 215–217). This removes all family submenus during daytime even though Auto/System will use a dark palette later. The picker needs the saved colour-scheme choice as well as the currently active palette scheme.

kayg commented

2026-09-30 10:44:02 +00:00

Author

Owner

Review finding: the new Dark e2e assertion initially shortened every Catppuccin variant label, while the existing Dark menu keeps the family prefix on non-selected variants. I updated the assertion to preserve the current labels; the picker behavior stays unchanged.

kayg commented

2026-09-30 11:20:24 +00:00

Author

Owner

E2E finding: the Dark settings page had not finished hydrating when a body-text check ran, so it saw the route's temporary Loading state. I replaced that brittle text check with an accessibility wait for the real Theme control before opening the submenu.

kayg commented

2026-09-30 11:22:05 +00:00

Author

Owner

Correction to my earlier label note: I rechecked the curated theme definitions. Catppuccin already uses the short names Frappé, Macchiato, and Mocha, so the original Dark assertion was right; I restored it. No picker behavior changed.

kayg commented

2026-09-30 11:29:25 +00:00

Author

Owner

Performance-profile finding: at 4× CPU throttling, the submenu surface became visible before its radio rows mounted, so the benchmark's immediate row count saw zero. I added a wait for the first visible radio row before counting and measuring the submenu.

kayg commented

2026-09-30 11:31:19 +00:00

Author

Owner

Performance-profile finding: its setup left Catppuccin open, then tried to focus the parent row while keyboard focus remained in the submenu. The profile now uses ArrowLeft to return to the parent menu before timing repeated ArrowRight opens.

kayg commented

2026-09-30 11:35:51 +00:00

Author

Owner

Benchmark adjustment: the 4× browser throttle left the submenu radio rows unavailable for 30 seconds in the profile run. I removed emulated throttling and record native 1× CPU conditions for the local profile; the run still captures browser CPU, RSS, latency, and the largest family menu burst.

kayg commented

2026-09-30 11:44:21 +00:00

Author

Owner

Correction: shell quoting stripped the command names from my previous gate note. The results were:

bun run check output:

$ node scripts/check-type-tokens.mjs && svelte-kit sync && svelte-check --tsconfig ./tsconfig.json
Text sizes and UI shape values use shared role tokens.
Loading svelte-check in workspace: /home/kayg/Developer/calternal-wt/theme-variants-506/apps/web
Getting Svelte diagnostics...
svelte-check found 0 errors and 0 warnings

bun run test summary:

Test Files  4 failed | 133 passed (137)
Tests  4 failed | 887 passed (891)
Duration  189.10s
error: script "test" exited with code 1

The four failures were 5-second timeouts in existing agenda, composer, analytics RangeBar, and analytics StatRow tests. The five ThemePicker tests passed. No existing expectation was changed.

Correction: shell quoting stripped the command names from my previous gate note. The results were: `bun run check` output: ```text $ node scripts/check-type-tokens.mjs && svelte-kit sync && svelte-check --tsconfig ./tsconfig.json Text sizes and UI shape values use shared role tokens. Loading svelte-check in workspace: /home/kayg/Developer/calternal-wt/theme-variants-506/apps/web Getting Svelte diagnostics... svelte-check found 0 errors and 0 warnings ``` `bun run test` summary: ```text Test Files 4 failed | 133 passed (137) Tests 4 failed | 887 passed (891) Duration 189.10s error: script "test" exited with code 1 ``` The four failures were 5-second timeouts in existing agenda, composer, analytics RangeBar, and analytics StatRow tests. The five ThemePicker tests passed. No existing expectation was changed.

kayg commented

2026-09-30 11:51:26 +00:00

Author

Owner

#506 complete

The Theme menu now keeps saved dark variants available in Auto and System while the active palette is light. Auto options use “At night: …”; System options use “When dark: …”. Light hides dark variants. Dark keeps its existing labels and selected state. The shared Menu still handles ArrowRight and the existing diagonal pointer path.

Auto preserves and checks the saved dark variant while Latte is active. The production e2e opened the Catppuccin submenu in Auto daylight and Dark at phone, tablet, and desktop widths.

Files

packages/ui/src/themes.ts
packages/ui/src/components/ThemePicker.svelte
packages/ui/src/index.ts
apps/web/src/routes/settings/appearance/AppearanceSection.svelte
apps/web/src/lib/components/ThemePicker.svelte.test.ts
apps/web/e2e/theme-variants-506.mjs
apps/web/package.json
bench/theme-picker-506.mjs
bench/run.sh
bench/record.py
bench/test_record.py

The required origin/dev merge also brought in updates to app-sidebar.svelte, themes.test.ts, FloatingSidebar.svelte, TooltipLayer.svelte, and tokens.css. No lockfile changed.

Verification

Production build passed:

✓ built in 1m 1s
  Wrote site to "build"
  ✔ done

Production e2e output:

PASS Theme submenu regression and 6 production screenshots (390, 820, 1440; Auto daylight and Dark)

The screenshots are attached below. The local profile completed with 15 average opens and a 30-open burst at 390 and 1440 px. Its measurements are in the profile section below.

bun run check output:

$ node scripts/check-type-tokens.mjs && svelte-kit sync && svelte-check --tsconfig ./tsconfig.json
Text sizes and UI shape values use shared role tokens.
Loading svelte-check in workspace: /home/kayg/Developer/calternal-wt/theme-variants-506/apps/web
Getting Svelte diagnostics...
svelte-check found 0 errors and 0 warnings

bun run test summary:

Test Files  4 failed | 133 passed (137)
Tests  4 failed | 887 passed (891)
Start at  13:40:54
Duration  189.10s (transform 44%, environment 20%, import 15%, tests 12%, setup 8%)
error: script "test" exited with code 1

The four failures were existing 5-second timeouts in Agenda, Composer, Analytics RangeBar, and Analytics StatRow. All five ThemePicker tests passed. No existing expectation changed. python3 -m unittest bench.test_record passed all 3 tests.

Rust source did not change, so Rust clippy/test gates were not run. cargo build -p calternal-server completed for the browser run. Cleanup output:

Removed 7067 files, 4.4GiB total

Performance profile

The perf VM lock was busy, so this is a local run on calternal-dev at native 1× CPU. Load average before the run was 33.96, 36.44, 35.50. docs/perf/baseline.json has no Theme menu scenario for a direct comparison. CPU percentages sum Chromium processes and can exceed 100%.

Viewport	Average p50 / p95	Average browser CPU / RSS	30-open burst p50 / p95	Burst CPU / peak RSS
390 × 844	40.0 / 62.1 ms	219.6% / 492,675,072 B	27.3 / 181.8 ms	167.8% / 497,115,136 B
1440 × 900	25.1 / 715.2 ms	158.3% / 608,985,088 B	16.2 / 370.5 ms	188.4% / 619,159,552 B

Decisions

Auto uses “At night” and System uses “When dark” because System follows the device scheme, not the solar clock.
The current catalogue has no family with alternate light palettes, so Light has no variant submenu.

The build also reported existing use client module-directive warnings in analytics vendor files.

Head: 36615b8b6d82307ec7a9875b21a252bc36b30e08.

Screenshots

Auto daylight — 390 px

Dark — 390 px

Auto daylight — 820 px

Dark — 820 px

Auto daylight — 1440 px

Dark — 1440 px

## #506 complete The Theme menu now keeps saved dark variants available in Auto and System while the active palette is light. Auto options use “At night: …”; System options use “When dark: …”. Light hides dark variants. Dark keeps its existing labels and selected state. The shared Menu still handles ArrowRight and the existing diagonal pointer path. Auto preserves and checks the saved dark variant while Latte is active. The production e2e opened the Catppuccin submenu in Auto daylight and Dark at phone, tablet, and desktop widths. ## Files - `packages/ui/src/themes.ts` - `packages/ui/src/components/ThemePicker.svelte` - `packages/ui/src/index.ts` - `apps/web/src/routes/settings/appearance/AppearanceSection.svelte` - `apps/web/src/lib/components/ThemePicker.svelte.test.ts` - `apps/web/e2e/theme-variants-506.mjs` - `apps/web/package.json` - `bench/theme-picker-506.mjs` - `bench/run.sh` - `bench/record.py` - `bench/test_record.py` The required `origin/dev` merge also brought in updates to `app-sidebar.svelte`, `themes.test.ts`, `FloatingSidebar.svelte`, `TooltipLayer.svelte`, and `tokens.css`. No lockfile changed. ## Verification Production build passed: ```text ✓ built in 1m 1s Wrote site to "build" ✔ done ``` Production e2e output: ```text PASS Theme submenu regression and 6 production screenshots (390, 820, 1440; Auto daylight and Dark) ``` The screenshots are attached below. The local profile completed with 15 average opens and a 30-open burst at 390 and 1440 px. Its measurements are in the profile section below. `bun run check` output: ```text $ node scripts/check-type-tokens.mjs && svelte-kit sync && svelte-check --tsconfig ./tsconfig.json Text sizes and UI shape values use shared role tokens. Loading svelte-check in workspace: /home/kayg/Developer/calternal-wt/theme-variants-506/apps/web Getting Svelte diagnostics... svelte-check found 0 errors and 0 warnings ``` `bun run test` summary: ```text Test Files 4 failed | 133 passed (137) Tests 4 failed | 887 passed (891) Start at 13:40:54 Duration 189.10s (transform 44%, environment 20%, import 15%, tests 12%, setup 8%) error: script "test" exited with code 1 ``` The four failures were existing 5-second timeouts in Agenda, Composer, Analytics RangeBar, and Analytics StatRow. All five ThemePicker tests passed. No existing expectation changed. `python3 -m unittest bench.test_record` passed all 3 tests. Rust source did not change, so Rust clippy/test gates were not run. `cargo build -p calternal-server` completed for the browser run. Cleanup output: ```text Removed 7067 files, 4.4GiB total ``` ## Performance profile The perf VM lock was busy, so this is a local run on `calternal-dev` at native 1× CPU. Load average before the run was `33.96, 36.44, 35.50`. `docs/perf/baseline.json` has no Theme menu scenario for a direct comparison. CPU percentages sum Chromium processes and can exceed 100%. | Viewport | Average p50 / p95 | Average browser CPU / RSS | 30-open burst p50 / p95 | Burst CPU / peak RSS | |---|---:|---:|---:|---:| | 390 × 844 | 40.0 / 62.1 ms | 219.6% / 492,675,072 B | 27.3 / 181.8 ms | 167.8% / 497,115,136 B | | 1440 × 900 | 25.1 / 715.2 ms | 158.3% / 608,985,088 B | 16.2 / 370.5 ms | 188.4% / 619,159,552 B | ## Decisions - Auto uses “At night” and System uses “When dark” because System follows the device scheme, not the solar clock. - The current catalogue has no family with alternate light palettes, so Light has no variant submenu. The build also reported existing `use client` module-directive warnings in analytics vendor files. Head: `36615b8b6d82307ec7a9875b21a252bc36b30e08`. ### Screenshots **Auto daylight — 390 px** ![Auto daylight at 390 px](https://git.kayg.org/attachments/727a5e2a-de64-4b00-a8a6-255d59f8153d) **Dark — 390 px** ![Dark at 390 px](https://git.kayg.org/attachments/25c15d26-a49a-4cdc-b289-1d0946062727) **Auto daylight — 820 px** ![Auto daylight at 820 px](https://git.kayg.org/attachments/bf146501-ab65-4a12-a6f0-0abe5831aaf0) **Dark — 820 px** ![Dark at 820 px](https://git.kayg.org/attachments/fac63259-484d-47f8-a5dd-9d2804e55fdf) **Auto daylight — 1440 px** ![Auto daylight at 1440 px](https://git.kayg.org/attachments/41989296-995e-461a-a711-cf23ee0ea477) **Dark — 1440 px** ![Dark at 1440 px](https://git.kayg.org/attachments/e7652694-c4f2-4798-9583-97c34c5f133d)

kayg commented

2026-09-30 11:56:30 +00:00

Author

Owner

Starting the phone round for #506 on job/theme-variants-506.

Base SHA: 558457cf32e1d429da3834a05ff2720d11284302 (origin/dev at start). Current head: 36615b8b6d82307ec7a9875b21a252bc36b30e08.

Starting the phone round for #506 on `job/theme-variants-506`. Base SHA: `558457cf32e1d429da3834a05ff2720d11284302` (`origin/dev` at start). Current head: `36615b8b6d82307ec7a9875b21a252bc36b30e08`.

kayg referenced this issue from a commit

2026-09-30 12:29:13 +00:00

fix(ui): drill menu submenus on phones (#506)

kayg commented

2026-09-30 12:31:09 +00:00

Author

Owner

Finding during the first focused test run: the standalone jsdom ThemePicker tests had no viewport media profile, so the new shared-menu gate correctly chose drill-in and an existing desktop-flyout assertion used a detached parent row after navigating back. I set an explicit fine-pointer desktop profile in that component suite and added separate coarse-pointer and narrow-viewport tests. The rerun passed: 2 test files, 12 tests.

kayg referenced this issue from a commit

2026-09-30 12:39:33 +00:00

test(web): tap theme menu variants on touch (#506)

kayg referenced this issue from a commit

2026-09-30 12:39:33 +00:00

test(web): route theme benchmark through current SPA (#506)

kayg commented

2026-09-30 12:48:08 +00:00

Author

Owner

The six 390/820/1440 screenshots now complete, and the desktop checked-row assertions pass. The browser run still exits on font decode warnings: the compatible shared server serves an HTML 404 body for /fonts/google-sans-latin-wght-normal.woff2 (Chromium reports invalid sfntVersion: 1008821359). These files exist in the current production build at apps/web/build/fonts/; the E2E asset override routed /_app/ files but omitted /fonts/. I am extending that test-only route and will rerun the production browser check.

The six 390/820/1440 screenshots now complete, and the desktop checked-row assertions pass. The browser run still exits on font decode warnings: the compatible shared server serves an HTML 404 body for `/fonts/google-sans-latin-wght-normal.woff2` (Chromium reports `invalid sfntVersion: 1008821359`). These files exist in the current production build at `apps/web/build/fonts/`; the E2E asset override routed `/_app/` files but omitted `/fonts/`. I am extending that test-only route and will rerun the production browser check.

kayg referenced this issue from a commit

2026-09-30 12:50:41 +00:00

docs(ui): clarify theme menu drill invariants (#506)

kayg referenced this issue from a commit

2026-09-30 12:50:41 +00:00

test(web): serve current fonts in theme browser run (#506)

kayg commented

2026-09-30 12:52:20 +00:00

Author

Owner

The first profile run exposed a mobile-only benchmark setup bug: after the measured setup, the repeat loop used keyboard ArrowRight to reopen the menu and timed out waiting for Catppuccin submenu. The UI browser coverage itself passed. I am changing the profile loop to use tap/back-row tap on drill-in layouts and keep ArrowRight/Escape on desktop, so the measurements exercise each layout's real input path.

kayg referenced this issue from a commit

2026-09-30 13:01:05 +00:00

perf(web): profile native theme menu input (#506)

kayg commented

2026-09-30 13:18:36 +00:00

Author

Owner

Completed Forgejo #506 on job/theme-variants-506.

Head SHA: 8c5d0706fffd1e7b09331d2942b3700cf1d14c6b (includes one merge of origin/dev).

Built: The shared Menu now drills into submenus on coarse pointers and narrow viewports. It shows a back row and restores focus on return. Fine-pointer desktop keeps its side flyout. The family row keeps its title and shows a short scheme detail. Only the open child menu owns the active row. The E2E run checks all three widths in Auto daylight and Dark.

Files:

Shared UI: packages/ui/src/components/menu/Menu.svelte, MenuItem.svelte, types.ts, packages/ui/src/components/ThemePicker.svelte, packages/ui/src/themes.ts, packages/ui/src/index.ts, apps/web/src/routes/settings/appearance/AppearanceSection.svelte.
Tests and browser checks: apps/web/src/lib/components/ThemePicker.svelte.test.ts, apps/web/src/lib/themePicker.svelte.test.ts, apps/web/e2e/theme-variants-506.mjs, apps/web/e2e/harness.mjs, apps/web/package.json.
Performance profile: bench/theme-picker-506.mjs, bench/record.py, bench/run.sh, bench/test_record.py.

Gate output (verbatim):

$ node scripts/check-type-tokens.mjs && svelte-kit sync && svelte-check --tsconfig ./tsconfig.json
Text sizes and UI shape values use shared role tokens.
Loading svelte-check in workspace: /home/kayg/Developer/calternal-wt/theme-variants-506/apps/web
Getting Svelte diagnostics...

svelte-check found 0 errors and 0 warnings

$ vitest run "--maxWorkers=1"

 RUN  v5.0.1 /home/kayg/Developer/calternal-wt/theme-variants-506/apps/web

 Test Files  137 passed (137)
      Tests  897 passed (897)
   Start at  14:58:34
   Duration  226.67s (transform 29%, environment 25%, import 22%, tests 18%, setup 5%)

$ bun e2e/theme-variants-506.mjs
SCREENSHOT /home/kayg/Developer/calternal-wt/theme-variants-506/artifacts/theme-variants-506/auto-day-light-390.png
SCREENSHOT /home/kayg/Developer/calternal-wt/theme-variants-506/artifacts/theme-variants-506/dark-390.png
SCREENSHOT /home/kayg/Developer/calternal-wt/theme-variants-506/artifacts/theme-variants-506/auto-day-light-820.png
SCREENSHOT /home/kayg/Developer/calternal-wt/theme-variants-506/artifacts/theme-variants-506/dark-820.png
SCREENSHOT /home/kayg/Developer/calternal-wt/theme-variants-506/artifacts/theme-variants-506/auto-day-light-1440.png
SCREENSHOT /home/kayg/Developer/calternal-wt/theme-variants-506/artifacts/theme-variants-506/dark-1440.png
PASS Theme submenu regression and 6 production screenshots (390, 820, 1440; Auto daylight and Dark)

bun run build also passed: ✓ built in 1m 38s; the static adapter wrote apps/web/build. cargo clean removed 4074 files (1.8 GiB). Build output is deleted. No Rust source changed, so Rust crate gates did not run.

Screenshots: Each attachment returned HTTP 200 with image/png.

Viewport	Auto daylight	Dark
390 px	auto-day-light-390.png	dark-390.png
820 px	auto-day-light-820.png	dark-820.png
1440 px	auto-day-light-1440.png	dark-1440.png

Performance: The perf VM had no browser tooling, so this is a local first measurement. No Theme menu profile exists in docs/perf/baseline.json. The local load average at profile start was 25.92, 27.45, 30.32, so these numbers are noisy.

Width	Average p50/p95; CPU; RSS	30-open burst p50/p95; CPU; peak RSS
390 px	199.9 / 617.6 ms; 6.940 s (177.7%); 492,072,960 B	218.7 / 425.0 ms; 12.570 s (166.8%); 514,981,888 B
1440 px	33.6 / 302.8 ms; 2.210 s (287.4%); 612,192,256 B	37.0 / 217.1 ms; 3.340 s (157.1%); 626,515,968 B

Decisions not stated in DESIGN: Use the shared pointerCoarse state or the existing fine-pointer SurfaceViewport rule (min-width: 768px) to choose the drill-in. Use Night: <variant> for Auto and Dark: <variant> for System in the family summary; keep the longer At night: and When dark: labels on variant rows.

Known gaps: The full web test run printed jsdom Window.scrollTo() and CSS parse warnings, but all 897 tests passed. The build printed Vite module-level use client warnings and completed. No API endpoint or server behavior changed in this branch, so no endpoint adversarial round was needed. The attached production screenshots are ready for visual review.

Completed Forgejo #506 on `job/theme-variants-506`. **Head SHA:** `8c5d0706fffd1e7b09331d2942b3700cf1d14c6b` (includes one merge of `origin/dev`). **Built:** The shared `Menu` now drills into submenus on coarse pointers and narrow viewports. It shows a back row and restores focus on return. Fine-pointer desktop keeps its side flyout. The family row keeps its title and shows a short scheme detail. Only the open child menu owns the active row. The E2E run checks all three widths in Auto daylight and Dark. **Files:** - Shared UI: `packages/ui/src/components/menu/Menu.svelte`, `MenuItem.svelte`, `types.ts`, `packages/ui/src/components/ThemePicker.svelte`, `packages/ui/src/themes.ts`, `packages/ui/src/index.ts`, `apps/web/src/routes/settings/appearance/AppearanceSection.svelte`. - Tests and browser checks: `apps/web/src/lib/components/ThemePicker.svelte.test.ts`, `apps/web/src/lib/themePicker.svelte.test.ts`, `apps/web/e2e/theme-variants-506.mjs`, `apps/web/e2e/harness.mjs`, `apps/web/package.json`. - Performance profile: `bench/theme-picker-506.mjs`, `bench/record.py`, `bench/run.sh`, `bench/test_record.py`. **Gate output (verbatim):** ```text $ node scripts/check-type-tokens.mjs && svelte-kit sync && svelte-check --tsconfig ./tsconfig.json Text sizes and UI shape values use shared role tokens. Loading svelte-check in workspace: /home/kayg/Developer/calternal-wt/theme-variants-506/apps/web Getting Svelte diagnostics... svelte-check found 0 errors and 0 warnings ``` ```text $ vitest run "--maxWorkers=1" RUN v5.0.1 /home/kayg/Developer/calternal-wt/theme-variants-506/apps/web Test Files 137 passed (137) Tests 897 passed (897) Start at 14:58:34 Duration 226.67s (transform 29%, environment 25%, import 22%, tests 18%, setup 5%) ``` ```text $ bun e2e/theme-variants-506.mjs SCREENSHOT /home/kayg/Developer/calternal-wt/theme-variants-506/artifacts/theme-variants-506/auto-day-light-390.png SCREENSHOT /home/kayg/Developer/calternal-wt/theme-variants-506/artifacts/theme-variants-506/dark-390.png SCREENSHOT /home/kayg/Developer/calternal-wt/theme-variants-506/artifacts/theme-variants-506/auto-day-light-820.png SCREENSHOT /home/kayg/Developer/calternal-wt/theme-variants-506/artifacts/theme-variants-506/dark-820.png SCREENSHOT /home/kayg/Developer/calternal-wt/theme-variants-506/artifacts/theme-variants-506/auto-day-light-1440.png SCREENSHOT /home/kayg/Developer/calternal-wt/theme-variants-506/artifacts/theme-variants-506/dark-1440.png PASS Theme submenu regression and 6 production screenshots (390, 820, 1440; Auto daylight and Dark) ``` `bun run build` also passed: `✓ built in 1m 38s`; the static adapter wrote `apps/web/build`. `cargo clean` removed 4074 files (1.8 GiB). Build output is deleted. No Rust source changed, so Rust crate gates did not run. **Screenshots:** Each attachment returned HTTP 200 with `image/png`. | Viewport | Auto daylight | Dark | | --- | --- | --- | | 390 px | [auto-day-light-390.png](https://git.kayg.org/attachments/634c284f-2fa1-4c74-b483-202b0e66e056) | [dark-390.png](https://git.kayg.org/attachments/04d5cbf2-2237-4949-b3e6-5b0f80d5a506) | | 820 px | [auto-day-light-820.png](https://git.kayg.org/attachments/c908a406-b59d-4988-8958-57ec5d08ec98) | [dark-820.png](https://git.kayg.org/attachments/7909c00e-12d9-4dbc-bdf5-955f7b6d538a) | | 1440 px | [auto-day-light-1440.png](https://git.kayg.org/attachments/05a0911f-2c0c-4398-986f-7335d6a2747a) | [dark-1440.png](https://git.kayg.org/attachments/25de7fb7-f2d9-4f3b-aa88-640e8d95d662) | **Performance:** The perf VM had no browser tooling, so this is a local first measurement. No Theme menu profile exists in `docs/perf/baseline.json`. The local load average at profile start was `25.92, 27.45, 30.32`, so these numbers are noisy. | Width | Average p50/p95; CPU; RSS | 30-open burst p50/p95; CPU; peak RSS | | --- | --- | --- | | 390 px | 199.9 / 617.6 ms; 6.940 s (177.7%); 492,072,960 B | 218.7 / 425.0 ms; 12.570 s (166.8%); 514,981,888 B | | 1440 px | 33.6 / 302.8 ms; 2.210 s (287.4%); 612,192,256 B | 37.0 / 217.1 ms; 3.340 s (157.1%); 626,515,968 B | **Decisions not stated in DESIGN:** Use the shared `pointerCoarse` state or the existing fine-pointer `SurfaceViewport` rule (`min-width: 768px`) to choose the drill-in. Use `Night: <variant>` for Auto and `Dark: <variant>` for System in the family summary; keep the longer `At night:` and `When dark:` labels on variant rows. **Known gaps:** The full web test run printed jsdom `Window.scrollTo()` and CSS parse warnings, but all 897 tests passed. The build printed Vite module-level `use client` warnings and completed. No API endpoint or server behavior changed in this branch, so no endpoint adversarial round was needed. The attached production screenshots are ready for visual review.

kayg referenced this issue from a commit

2026-09-30 13:25:32 +00:00

Merge job/theme-variants-506 (#506: theme family submenus in Auto/System by day; phone drill-in for shared menu submenus)

kayg commented

2026-09-30 13:25:33 +00:00

Author

Owner

Merged into dev at cd3cea757.

Merged into dev at cd3cea757.

kayg closed this issue

2026-09-30 13:25:34 +00:00

kayg referenced this issue