P2: Complete Markdown folder intake byte and checklist evidence #893

Open
opened 2026-10-02 17:36:03 +00:00 by kayg · 0 comments
Owner

Independent audit of #719

Target: ee959b533. Review branch: job/rev2-dropmd-719.
Base: 440e19dce23040ac8ebaae88f0469b6535b1afcb.
Method: read code and Git history only. No build, test, server or browser ran.

P2: Intake evidence does not check source bytes

Evidence: tests/dropmd_719/run_intake.mjs:383 reports paths, sizes and MIME
types. It does not download content or compare it with the fixture bytes.
Lines 524–529 open only wiki-links/Guide.md. Lines 446–447 compare its
parsed Note body and ETag, not the complete file. These observations cannot
detect a same-size content change during intake, or a change to the BOM,
CRLF or frontmatter of another imported file.

Rule: #719 checks 6 and 7; DESIGN §2 and §9; #661 says opening never writes.

Fix: compare each file's complete bytes after intake and after read-only
opens. Allow only the documented identity-key insertion when that action is
part of intake. Record that exception separately. Make a changed file an
explicit failure. Keep a machine-readable checklist result.

Test idea: use a focused regression with BOM, CRLF, frontmatter and an
attachment. A same-length byte change must fail the check. Opening the Note
must leave the complete file unchanged.

P3: Several checklist results are inferred or absent

Evidence: tests/dropmd_719/run_intake.mjs:404 identifies Daily notes with a
filename regular expression. It never reads Calendar Journal or Log entries.
Lines 376–380 count backlinks but do not open link destinations, headings or
blocks. Lines 428–434 inspect images and PDF link elements only in Guide.
The database-export heading link and outliner block reference are not opened.
The report therefore has no result for several checks that #719 requires.

Fix: add explicit observations for Calendar Journal, Log entries, link
navigation and destination anchors. Use pass, fail or not checked for each
corpus and check. Do not infer successful navigation from backlink counts.
Keep unsupported source conventions visible as deliberate limits.

Test idea: use the generated database-export and Daily-note fixtures to
assert the destination heading and the expected Journal rows. A broken
destination must produce a failure, not a backlink count.

These findings share one fix: complete the intake evidence runner. Search
for existing issues found #719 as the intake owner. A follow-up issue will
hold the concrete evidence changes. No product defect is claimed here.

# Independent audit of #719 Target: `ee959b533`. Review branch: `job/rev2-dropmd-719`. Base: `440e19dce23040ac8ebaae88f0469b6535b1afcb`. Method: read code and Git history only. No build, test, server or browser ran. ## P2: Intake evidence does not check source bytes Evidence: `tests/dropmd_719/run_intake.mjs:383` reports paths, sizes and MIME types. It does not download content or compare it with the fixture bytes. Lines 524–529 open only `wiki-links/Guide.md`. Lines 446–447 compare its parsed Note body and ETag, not the complete file. These observations cannot detect a same-size content change during intake, or a change to the BOM, CRLF or frontmatter of another imported file. Rule: #719 checks 6 and 7; DESIGN §2 and §9; #661 says opening never writes. Fix: compare each file's complete bytes after intake and after read-only opens. Allow only the documented identity-key insertion when that action is part of intake. Record that exception separately. Make a changed file an explicit failure. Keep a machine-readable checklist result. Test idea: use a focused regression with BOM, CRLF, frontmatter and an attachment. A same-length byte change must fail the check. Opening the Note must leave the complete file unchanged. ## P3: Several checklist results are inferred or absent Evidence: `tests/dropmd_719/run_intake.mjs:404` identifies Daily notes with a filename regular expression. It never reads Calendar Journal or Log entries. Lines 376–380 count backlinks but do not open link destinations, headings or blocks. Lines 428–434 inspect images and PDF link elements only in Guide. The database-export heading link and outliner block reference are not opened. The report therefore has no result for several checks that #719 requires. Fix: add explicit observations for Calendar Journal, Log entries, link navigation and destination anchors. Use pass, fail or not checked for each corpus and check. Do not infer successful navigation from backlink counts. Keep unsupported source conventions visible as deliberate limits. Test idea: use the generated database-export and Daily-note fixtures to assert the destination heading and the expected Journal rows. A broken destination must produce a failure, not a backlink count. These findings share one fix: complete the intake evidence runner. Search for existing issues found #719 as the intake owner. A follow-up issue will hold the concrete evidence changes. No product defect is claimed here.
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kayg/calternal#893
No description provided.