kayg/calternal
Watch
1
0
Fork
You've already forked calternal
 0
Code Issues 191 Pull requests 61 Projects Releases Packages Wiki Activity Actions 20

Fix link state visibility after note delete #519

Closed
kayg wants to merge 0 commits from issue/448-missing-flake into dev
pull from: issue/448-missing-flake
merge into: kayg:dev
Conversation 1 Commits - Files changed -
kayg commented 2026-10-17 03:34:04 +00:00
Owner
Copy link

The link state after delete could briefly be New because the departed-path row was queued to history without waiting. The delete operation now waits for that history write before returning, so the immediate link-state read can return Trash.

References #448. Stress repro: 195 of 200 passed before the fix, with 5 failures returning New; 200 of 200 passed after the fix.

The link state after delete could briefly be New because the departed-path row was queued to history without waiting. The delete operation now waits for that history write before returning, so the immediate link-state read can return Trash. References #448. Stress repro: 195 of 200 passed before the fix, with 5 failures returning New; 200 of 200 passed after the fix.
fix notes delete link state visibility
Some checks failed
CI / server (pull_request) Successful in 36s
Details
CI / rust (pull_request) Successful in 2m50s
Details
CI / web (pull_request) Failing after 53m48s
Details
7db5ab0533
kayg commented 2026-10-17 07:06:42 +00:00
Author
Owner
Copy link

Landed in train v, #525.

Train v ran the full suite per project (11 projects), plus fmt, clippy, workspace tests and the build. fmt, clippy and the workspace tests are all green.

  • Passed: chromium-1440, throttled-390, throttled-1440, flow, passkeys, prefs-chromium, prefs-webkit and contrast.
  • First-run failures, all green on a 3x rerun:
    • missing-links:379 on chromium-390: 54 of 54;
    • tooltips on webkit-390: 9 of 9;
    • tree:176 on webkit-1440: 21 of 21.

Contents:

  • #518: web speed. The 100k cold TBT drops from 22.5 s to about 0.4 s on an idle host, with the stale-list guard kept;
  • #519: delete waits for the history writer, so a link read right after a delete never says New.

Merging.

Landed in train v, #525. Train v ran the full suite per project (11 projects), plus fmt, clippy, workspace tests and the build. fmt, clippy and the workspace tests are all green. - **Passed:** chromium-1440, throttled-390, throttled-1440, flow, passkeys, prefs-chromium, prefs-webkit and contrast. - **First-run failures, all green on a 3x rerun:** - `missing-links:379` on chromium-390: 54 of 54; - `tooltips` on webkit-390: 9 of 9; - `tree:176` on webkit-1440: 21 of 21. Contents: - #518: web speed. The 100k cold TBT drops from 22.5 s to about 0.4 s on an idle host, with the stale-list guard kept; - #519: delete waits for the history writer, so a link read right after a delete never says New. Merging.
kayg closed this pull request 2026-10-17 07:06:43 +00:00
Some checks failed
CI / server (pull_request) Successful in 36s
Details
CI / rust (pull_request) Successful in 2m50s
Details
CI / web (pull_request) Failing after 53m48s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backend
Rust server

  
design
Mockups, UI and TASTE

  
docs
ADRs, CONTEXT, TASTE

  
idea
Parked idea, never worked until promoted

  
infra
Deploy, CI, VMs

  
perf
Performance and budgets

  
reliability
Data integrity, corruption traps

  
web
Web client

No labels
backend
design
docs
idea
infra
perf
reliability
web
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kayg/calternal!519
No description provided.