kayg/calternal
Watch
1
0
Fork
You've already forked calternal
 0
Code Issues 191 Pull requests 61 Projects Releases Packages Wiki Activity Actions 20

Tag picker matches nested tags (#449) #555

Closed
kayg wants to merge 0 commits from issue/449-nested-tags into dev
pull from: issue/449-nested-tags
merge into: kayg:dev
Conversation 1 Commits - Files changed -
kayg commented 2026-10-17 17:20:34 +00:00
Owner
Copy link

Typing #fitness now also suggests nested tags such as #area/fitness and #goals/fitness/strength.

Match: the path starts with the query, or any path segment starts with it, or (query holds /) the path holds it starting at a segment.
Order: exact, path prefix, exact last segment, other segment, then note count, then A to Z. Full path shown, matched letters bold, count on the right.

  • One matcher (matchTags in packages/editor/src/transforms/tag-rank.ts) serves the # list and the + picker. The sidebar tag list and note search do not match tags by name, so they have nothing to share.
  • Tags are split and lowercased once per tag list; a keystroke keeps only the best 7 rows. Perf test: 10k tags, about 1 ms per keystroke (limit 2 ms).
  • Parents count as tags, so #fitness also lists goals/fitness when goals/fitness/strength exists.
  • Dropped: the old "letters in order" loose match, which the rule does not include.

Tests: editor vitest 139 passed (incl. ranking + 10k perf); e2e tag-picker + tags on chromium-390 and webkit-1440, 13 passed each; svelte-check 0 errors.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WCcFhwwgMK66k9LMVqogNJ

Typing `#fitness` now also suggests nested tags such as `#area/fitness` and `#goals/fitness/strength`. **Match:** the path starts with the query, or any path segment starts with it, or (query holds `/`) the path holds it starting at a segment. **Order:** exact, path prefix, exact last segment, other segment, then note count, then A to Z. Full path shown, matched letters bold, count on the right. - One matcher (`matchTags` in `packages/editor/src/transforms/tag-rank.ts`) serves the `#` list and the `+` picker. The sidebar tag list and note search do not match tags by name, so they have nothing to share. - Tags are split and lowercased once per tag list; a keystroke keeps only the best 7 rows. Perf test: 10k tags, about 1 ms per keystroke (limit 2 ms). - Parents count as tags, so `#fitness` also lists `goals/fitness` when `goals/fitness/strength` exists. - Dropped: the old "letters in order" loose match, which the rule does not include. Tests: editor vitest 139 passed (incl. ranking + 10k perf); e2e `tag-picker` + `tags` on chromium-390 and webkit-1440, 13 passed each; svelte-check 0 errors. 🤖 Generated with [Claude Code](https://claude.ai/code) https://claude.ai/code/session_01WCcFhwwgMK66k9LMVqogNJ
Tag picker matches nested tags (#449)
Some checks failed
CI / server (pull_request) Successful in 32s
Details
CI / rust (pull_request) Successful in 2m33s
Details
CI / web (pull_request) Failing after 29s
Details
3c2eda4556 
Typing #fitness now also offers area/fitness and goals/fitness/strength.
A tag matches when its path starts with the query, any path segment
starts with it, or (for a query with a slash) the path holds it starting
at a segment. Order: exact, path prefix, exact last segment, other
segment, then note count, then A to Z. The matched letters are drawn
stronger.

One matcher (matchTags) now serves the # list and the + picker. Tags are
split and lowercased once per tag list; 10k tags take about 1 ms a key.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
kayg commented 2026-10-17 20:10:21 +00:00
Author
Owner
Copy link

Landed in train y, #565.

Landed in train y, #565.
kayg closed this pull request 2026-10-17 20:10:22 +00:00
Some checks failed
CI / server (pull_request) Successful in 32s
Details
CI / rust (pull_request) Successful in 2m33s
Details
CI / web (pull_request) Failing after 29s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backend
Rust server

  
design
Mockups, UI and TASTE

  
docs
ADRs, CONTEXT, TASTE

  
idea
Parked idea, never worked until promoted

  
infra
Deploy, CI, VMs

  
perf
Performance and budgets

  
reliability
Data integrity, corruption traps

  
web
Web client

No labels
backend
design
docs
idea
infra
perf
reliability
web
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kayg/calternal!555
No description provided.