kayg/calternal
Watch
1
0
Fork
You've already forked calternal
 0
Code Issues 190 Pull requests 61 Projects Releases Packages Wiki Activity Actions 20

test(auth): observe idle upload completion before checking workers #857

Closed
kayg wants to merge 0 commits from test/attachment-idle-completion into dev
pull from: test/attachment-idle-completion
merge into: kayg:dev
Conversation 2 Commits - Files changed -
kayg commented 2026-11-02 12:11:53 +00:00
Owner
Copy link

The slow-attachment worker test observes only two pending files, sleeps 31 seconds, then assumes all four admitted uploads have reached their independent idle deadlines. A BM8 full workspace run found four still pending at that instant. The test body is unchanged on dev.

Wait for every upload task to finish, with a 90-second failure cap, before the existing status and cleanup checks. Keep the unrelated-worker probe as a functional liveness check with a 30-second cap, rather than a 100 ms speed assertion. All per-person admission, response-status, temporary-file cleanup, sign-in and worker assertions remain. Product timeouts and upload code are unchanged.

Validation on dev-02 in the standard Nix shell through slot: cargo fmt --all -- --check; cargo test -p calternal-auth --test reliability_round3 -j4 attachment_slow_bodies_must_not_hold_all_general_blocking_workers -- --nocapture passed, 1/1, 32.52 s.

BM8 validation at scratch b9dac07806a398f53f8a9acaf1506d4b6f718a30: cargo fmt --all -- --check and cargo test --workspace -j4 passed on dev-01 in the standard Nix/slot shell, 1,483 passed and 22 ignored, with no skips or test-thread override. Four report selectors passed 22/22 on Chromium/WebKit, zero retries. Final production code passed 30 fresh Chromium composer invocations (90 tests, zero retries) during one ordinary slot build. Exact commands, head provenance, append samples, retained failures and attached raw evidence: #844 (comment). No merge or train change; owned jobs finished and VM targets/temp Homes cleaned.

The slow-attachment worker test observes only two pending files, sleeps 31 seconds, then assumes all four admitted uploads have reached their independent idle deadlines. A BM8 full workspace run found four still pending at that instant. The test body is unchanged on dev. Wait for every upload task to finish, with a 90-second failure cap, before the existing status and cleanup checks. Keep the unrelated-worker probe as a functional liveness check with a 30-second cap, rather than a 100 ms speed assertion. All per-person admission, response-status, temporary-file cleanup, sign-in and worker assertions remain. Product timeouts and upload code are unchanged. Validation on dev-02 in the standard Nix shell through slot: `cargo fmt --all -- --check`; `cargo test -p calternal-auth --test reliability_round3 -j4 attachment_slow_bodies_must_not_hold_all_general_blocking_workers -- --nocapture` passed, 1/1, 32.52 s. BM8 validation at scratch `b9dac07806a398f53f8a9acaf1506d4b6f718a30`: `cargo fmt --all -- --check` and `cargo test --workspace -j4` passed on dev-01 in the standard Nix/slot shell, 1,483 passed and 22 ignored, with no skips or test-thread override. Four report selectors passed 22/22 on Chromium/WebKit, zero retries. Final production code passed 30 fresh Chromium composer invocations (90 tests, zero retries) during one ordinary slot build. Exact commands, head provenance, append samples, retained failures and attached raw evidence: https://git.kayg.org/kayg/calternal/pulls/844#issuecomment-74911. No merge or train change; owned jobs finished and VM targets/temp Homes cleaned.
test(auth): observe idle upload completion before checking workers
Some checks failed
CI / server (pull_request) Has been cancelled
Details
CI / rust (pull_request) Has been cancelled
Details
CI / web (pull_request) Has been cancelled
Details
Markdown extraction contract / markdown-native-contract (pull_request) Has been cancelled
Details
Markdown extraction contract / markdown-editor-contract (pull_request) Has been cancelled
Details
144e717145
kayg commented 2026-11-02 13:21:22 +00:00
Author
Owner
Copy link

BM8 validation at scratch b9dac07806a398f53f8a9acaf1506d4b6f718a30: cargo fmt --all -- --check and cargo test --workspace -j4 passed on dev-01 in the standard Nix/slot shell, 1,483 passed and 22 ignored, with no skips or test-thread override. Four report selectors passed 22/22 on Chromium/WebKit, zero retries. Final production code passed 30 fresh Chromium composer invocations (90 tests, zero retries) during one ordinary slot build. Exact commands, head provenance, append samples, retained failures and attached raw evidence: #844 (comment). No merge or train change; owned jobs finished and VM targets/temp Homes cleaned.

BM8 validation at scratch `b9dac07806a398f53f8a9acaf1506d4b6f718a30`: `cargo fmt --all -- --check` and `cargo test --workspace -j4` passed on dev-01 in the standard Nix/slot shell, 1,483 passed and 22 ignored, with no skips or test-thread override. Four report selectors passed 22/22 on Chromium/WebKit, zero retries. Final production code passed 30 fresh Chromium composer invocations (90 tests, zero retries) during one ordinary slot build. Exact commands, head provenance, append samples, retained failures and attached raw evidence: https://git.kayg.org/kayg/calternal/pulls/844#issuecomment-74911. No merge or train change; owned jobs finished and VM targets/temp Homes cleaned.
kayg commented 2026-11-04 13:05:00 +00:00
Author
Owner
Copy link

Closing: head 144e7171 is already in dev (reached via 42e14e8b); nothing left to merge. Branch kept.

Closing: head 144e7171 is already in dev (reached via 42e14e8b); nothing left to merge. Branch kept.
kayg closed this pull request 2026-11-04 13:05:00 +00:00
Some checks failed
CI / server (pull_request) Has been cancelled
Details
CI / rust (pull_request) Has been cancelled
Details
CI / web (pull_request) Has been cancelled
Details
Markdown extraction contract / markdown-native-contract (pull_request) Has been cancelled
Details
Markdown extraction contract / markdown-editor-contract (pull_request) Has been cancelled
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backend
Rust server

  
design
Mockups, UI and TASTE

  
docs
ADRs, CONTEXT, TASTE

  
idea
Parked idea, never worked until promoted

  
infra
Deploy, CI, VMs

  
perf
Performance and budgets

  
reliability
Data integrity, corruption traps

  
web
Web client

No labels
backend
design
docs
idea
infra
perf
reliability
web
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kayg/calternal!857
No description provided.