docs: in-code documentation, batch 1 #929
Closed
kayg
wants to merge 0 commits from
docs/in-code-batch-1 into dev
pull from: docs/in-code-batch-1
merge into: kayg:dev
kayg:main
kayg:feat/style-sheet-fixes
kayg:storage/wal-checkpoint-off-save-1051
kayg:t3/paged-search-reconcile-final
kayg:feat/pass8
kayg:review/calendar-2
kayg:fix/shared-row-swipes
kayg:feat/contrast
kayg:dev
kayg:feat/collections-db
kayg:fix/instant-keys-1056
kayg:feat/money-round
kayg:perf/stalls-1054
kayg:wip/tiering-v3-cold4
kayg:wip/tiering-v3-cold5
kayg:port/rows-actions
kayg:port/rows-drop
kayg:port/hidden-blocks
kayg:port/rows
kayg:port/port-tables
kayg:port/port-tables-2
kayg:t3/mail-1011-liveness
kayg:port/devices
kayg:port/port-attachments
kayg:port/port-attachments-2
kayg:port/port-attachments-3
kayg:docs/design-consistency
kayg:docs/engineering-standards
kayg:fix/rusqlite-0.41-rustsec-2026-0459
kayg:feat/iphone-fixes
kayg:shared/restore-and-stale-918-919
kayg:fix/phone-top-band-contrast
kayg:feat/notes-approve
kayg:perf/soak-max-gate
kayg:feat/files-s1-identity
kayg:fix/lifecycle-event-id
kayg:feat/quickfix
kayg:wip/tiering-v3-cold
kayg:perf/web-mockup-frame-fixes
kayg:port/contacts-merge
kayg:port/contacts-edit
kayg:test/shared-room-no-deleted-text
kayg:perf/first-paint-credits
kayg:fix/shared-history-after-grant
kayg:fix/phone-swipe-regressions
kayg:feat/contrast-r1
kayg:review/sharing-pr3-review
kayg:feat/tiering-v3-s2-tags
kayg:feat/folder-drop
kayg:fix/deskpills-lazy-share
kayg:feat/sharing-s1-pr3
kayg:tmp/money-round-before
kayg:fix/phone-pane-backdrop-roots
kayg:fix/palette-preload-chips
kayg:fix/invite-defaults
kayg:port/tasks-matrix
kayg:fix/restore-green-gates
kayg:fix/sharing-fast-path-hardening
kayg:t3/photos-s1
kayg:feat/tiering-v3-s1-namespace
kayg:notes-archive-hide
kayg:feat/tasks-actions
kayg:t3/photos-plan-slice-one
kayg:feat/whiteboard-s1
kayg:t3/paged-search-reconcile
kayg:t3/smooth-pane-transitions
kayg:t3/index-position-startup-scan
kayg:fix/private-staging-759b-r2
kayg:feat/dav-transport
kayg:feat/imap-notes-fetch
kayg:feat/imap-notes-projection
kayg:feat/imap-notes-readonly
kayg:feat/imap-notes-auth
kayg:feat/imap-notes-server-foundation
kayg:docs/undo-block-ids-plan
kayg:fix/undo-768
kayg:proto/block-identity-v7d
kayg:issue/carddav-read-perf-fix-r2
kayg:issue/carddav-read-r2
kayg:docs/imap-766-plan-v2
kayg:docs/imap-notes-plan
kayg:docs/quota-plan-2
kayg:fix/parallel-test-flakes
kayg:feat/contacts-companion-pure
kayg:docs/calendar-backend-v2-plan
kayg:feat/calendar-ical-converter
kayg:docs/tasks-writes-v2-plan
kayg:docs/carddav-writes-v2-plan
kayg:docs/contacts-import-v2-plan
kayg:issue/610-pm-midnight
kayg:feat/calendar-v2-s1-containment
kayg:docs/dav-recorder-v2-plan
kayg:plan/previews-865
kayg:plan/save-log-durable-entry
kayg:fix/e2e-data-on-ram
kayg:feat/appwindow3
kayg:feat/appwindow2
kayg:feat/appwindow
kayg:feat/money-p1
kayg:feat/keys-sheet
kayg:review/calendar-2-themes
kayg:feat/smooth-cursor
kayg:fix/float-style
kayg:review/calendar-2-float
kayg:release/2026-11-06-hotfix
kayg:archive/port/rows-drop-code
kayg:archive/port/rows-actions
kayg:archive/port/rows
kayg:scratch/tasks-894-ui-gates
kayg:review/calendar-2-night-wip
kayg:release/2026-11-05
kayg:archive/feat/tiering-v3-s1-namespace
kayg:archive/flaky/rows-drop-fixed
kayg:archive/flaky/rows-actions
kayg:archive/feat/tiering-v3-reader
kayg:archive/feat/tiering-v3-roots
kayg:archive/flaky/rows
kayg:sim/bm15-final
kayg:sim/bm15-fix
kayg:sim/bm15-bis-932
kayg:sim/bm15-bis-909
kayg:sim/bm15
kayg:sim/bm15-bis-887
kayg:perf/tiering-option-b
kayg:port/style-3
kayg:port/style-2
kayg:port/style
kayg:fix/sw-lazy-precache
kayg:fix/vim-w-waits-for-save
kayg:fix/signout-test-races
kayg:fp-scratch/all
kayg:sim/bm15-first-paint
kayg:archive/bm15/rows-drop
kayg:archive/bm15/rows-actions
kayg:fix/palette-snippet-contrast
kayg:archive/bm15/rows
kayg:archive/bm15/hidden
kayg:archive/plan/save-log-durable-entry
kayg:mock/money-fix2
kayg:archive/fix/e2e-data-on-ram
kayg:mock/appearance-all
kayg:mock/pill-press
kayg:archive/docs/design-consistency
kayg:mock/auto-swipes
kayg:mock/mail-actions
kayg:archive/feat/mail-p1
kayg:mock/money-static
kayg:archive/review/standards-917
kayg:archive/docs/engineering-standards
kayg:perf/tiering-761-fix
kayg:mock/type-audit
kayg:mock/third-pane
kayg:feat/contacts-import-v2-s1
kayg:perf/executor-hot-path
kayg:archive/port/hidden-blocks
kayg:archive/port/devices
kayg:scratch/executor-on-894
kayg:scratch/executor-spans2
kayg:scratch/executor-spans
kayg:train/2026-11-03-bm14c
kayg:archive/port/rows-drop
kayg:feat/tiering-761-d-scale
kayg:feat/tiering-761-c-index
kayg:feat/tiering-761-b-reader
kayg:archive/review/sharing-pr3-review-9fec3d1f
kayg:train/2026-11-03-bm14b
kayg:perf/ports-lazy-budgets
kayg:feat/tiering-761-a-migration
kayg:train/2026-11-03-bm14
kayg:train/2026-11-03-bm12
kayg:archive/review/sharing-pr3-review
kayg:archive/feat/sharing-s1-pr3
kayg:train/2026-11-03-bm11
kayg:archive/feat/imap-notes-fetch
kayg:train/2026-11-03-bm10
kayg:archive/review/sharing-pr3-review-code
kayg:archive/plan/previews-865
kayg:train/2026-11-02-bm9
kayg:archive/port/port-attachments-3
kayg:archive/port/contacts-merge
kayg:fix/motion-audit-859
kayg:train/2026-11-02-bm8
kayg:archive/scratch/bm8-prep
kayg:archive/port/port-pickers
kayg:archive/port/port-tables-2
kayg:archive/port/port-tables
kayg:archive/feat/sharing-s1-pr3-code
kayg:archive/scratch/bm7-fixed
kayg:train/2026-11-02-bm7
kayg:archive/fix/parallel-test-flakes-code-minipc01
kayg:train/2026-11-02-bm6
kayg:docs/imap-766-readonly-slice
kayg:feat/dav-recorder-v3
kayg:research/788-diagnosis
kayg:archive/fix/parallel-test-flakes
kayg:archive/perf/pr792-cold-index-edit
kayg:docs/sharing-slice-1
kayg:archive/docs/imap-766-plan-v2
kayg:feat/dav-recorder-v2
kayg:archive/docs/dav-recorder-v2-plan
kayg:spike/imap-766-s0-cases
kayg:archive/fix/undo-768
kayg:feat/dav-recorder
kayg:archive/docs/contacts-import-v2-plan
kayg:archive/feat/calendar-ical-converter
kayg:feat/contacts-import
kayg:perf/cold-growth-on-764
kayg:perf/cold-growth-on-tiering
kayg:archive/docs/tasks-writes-v2-plan
kayg:archive/docs/calendar-backend-v2-plan
kayg:archive/feat/contacts-companion-pure
kayg:feat/tasks-set-status
kayg:feat/tasks-move-reorder
kayg:archive/docs/carddav-writes-v2-plan
kayg:archive/feat/calendar-v2-s1-containment
kayg:feat/tasks-delete-promote-duplicate
kayg:archive/feat/dav-transport
kayg:archive/fix/carddav-rebuild-r1
kayg:archive/fix/carddav-retention-r1
kayg:feat/carddav-writes
kayg:perf/quota-on-tiering
kayg:perf/quota-simple
kayg:perf/cold-growth-on-quota-stack
kayg:feat/calendar-identity
kayg:feat/calendar-event-parser
kayg:feat/calendar-props-maps
kayg:port/glass-when-ring
kayg:feat/tiering-761-s1
kayg:wip/10by32-01-impl-759b-scratch-20261030
kayg:wip/6by32-01-bm3-webkit-pause-20261030
kayg:wip/10by32-01-bm3-chromium-pause-20261030
kayg:wip/6by32-01-tier-761-s1-pause-20261030
kayg:spike/imap-766-s0
kayg:wip/6by32-02-calternal-pause-20261030
kayg:wip/8by64-01-review-688-pause-20261030
kayg:wip/6by32-01-verify-744-pause-20261030
kayg:wip/6by32-01-verify-742-pause-20261030
kayg:fix/private-staging-759b
kayg:wip/6by32-01-review-748-pause-20261030
kayg:wip/6by32-01-review-733c-pause-20261030
kayg:wip/6by32-01-review-733b-pause-20261030
kayg:wip/6by32-01-perf-idle-8-pause-20261030
kayg:wip/6by32-01-perf767-base-pause-20261030
kayg:wip/6by32-01-perf767b-767-pause-20261030
kayg:wip/6by32-01-perf767b-764-pause-20261030
kayg:wip/6by32-01-perf767-767-pause-20261030
kayg:wip/6by32-01-perf767-764-pause-20261030
kayg:wip/6by32-01-lists-b-pause-20261030
kayg:wip/6by32-01-ids-verify5-pause-20261030
kayg:wip/6by32-01-ids-verify4-pause-20261030
kayg:review/calendar-month
kayg:wip/10by32-02-undo-768-20261030
kayg:test/ids-verify3
kayg:wip/10by32-02-bm3-chromium-20261030
kayg:wip/10by32-01-review-753-20261030
kayg:wip/10by32-01-perf-idle-2-20261030
kayg:wip/10by32-01-bm2-webkit2-20261030
kayg:plan/759b-staging
kayg:train/2026-10-30-bm2
kayg:review/758b-tests
kayg:review/758-tests
kayg:review/764d-tests
kayg:review/767b-tests
kayg:review/preview-2026-10-29
kayg:review/767-tests
kayg:docs/tiering-731-plan
kayg:wip/c6b02-when2
kayg:wip/c6b02-tasks-create-fix5
kayg:wip/c6b02-settings-frost-mock
kayg:wip/c6b02-settings-frost-base
kayg:wip/c6b02-settings-frost
kayg:wip/c6b02-ring
kayg:wip/c6b02-review-733d
kayg:wip/c6b02-bm1-full-a
kayg:wip/compute02-when-field
kayg:wip/compute02-webkit-lists-repro
kayg:wip/compute02-train-bl2-dev
kayg:wip/compute02-dev-green-pw164
kayg:docs/deploy-plan
kayg:review/764c-tests
kayg:review/764b-tests
kayg:review/748g-tests
kayg:review/764-tests
kayg:review/759b-tests
kayg:fix/storage-owner-liveness-642
kayg:fix/storage-fix-7
kayg:wip/compute02-storage-fix-7
kayg:review/759-tests
kayg:feat/tiering-731
kayg:wip/tiering-731-first-attempt
kayg:wip/compute02-storage-fix-1
kayg:review/754g-tests
kayg:perf/idle-honest-2
kayg:review/754f-tests
kayg:review/754e-tests
kayg:review/755-tests
kayg:review/754d-tests
kayg:review/754c-tests
kayg:review/754b-tests
kayg:review/754-tests
kayg:fix/storage-private-tmp-642-dev
kayg:wip/compute02-verify-750
kayg:test/ids-verify5
kayg:test/ids-verify4
kayg:fix/storage-exact-file-quarantine-642
kayg:wip/compute02-verify-740
kayg:perf/one-flush-save
kayg:review/calendar-static
kayg:wip/compute02-verify-737
kayg:review/indexing-ring
kayg:review/when-field-2
kayg:wip/compute02-review-733
kayg:proto/block-identity-2-review
kayg:proto/block-identity-review
kayg:wip/c6b02-tc-design
kayg:review/when-field
kayg:issue/tasks-create-ids
kayg:issue/tasks-create
kayg:review/combined
kayg:wip/compute02-review-combined
kayg:review/task-polish
kayg:review/top-buttons
kayg:review/q1-q5
kayg:train/2026-10-26-bl2
kayg:archive/wt-398h
kayg:archive/train-bm-proptest-seed
kayg:archive/integ325-293
kayg:archive/integ325-ci
kayg:archive/client-auth-review-baseline
kayg:archive/wt-sim-4853
kayg:archive/wt-sim-4811
kayg:archive/wt-448m
kayg:archive/wt-398a-allocator
kayg:issue/calendar-adr
kayg:archive/old/train/2026-10-23bk2
kayg:archive/old/train/2026-10-23bk
kayg:issue/469-mockup-9a
kayg:issue/smart-tasks-mockup
kayg:issue/469-menus
kayg:issue/652-signout-flake
kayg:issue/652-history-fix7
kayg:issue/652-history-fix6
kayg:archive/old/issue/spring-check-perf
kayg:issue/spring-check-perf
kayg:issue/659-rename-fast
kayg:archive/old/train/2026-10-21ar
kayg:issue/search-hardening-3
kayg:issue/652-history-fix5
kayg:issue/660-port-sheets-glass
kayg:issue/652-history-fix4
kayg:issue/652-history-fix3
kayg:issue/652-history-fix2
kayg:issue/652-history-flake
kayg:train/2026-10-21an
kayg:issue/settings-admin-port
kayg:issue/search-port
kayg:train/2026-10-20am
kayg:issue/storage-split-fix2
kayg:issue/storage-split
kayg:archive/old/issue/folder-ids-fix
kayg:train/2026-10-20al
kayg:archive/old/issue/folder-ids
kayg:train/2026-10-20ak
kayg:issue/tables-mockup
kayg:train/2026-10-19aj
kayg:train/2026-10-19ai
kayg:issue/469-merge-fixes
kayg:issue/sidebar-band
kayg:archive/old/issue/608-settings-spec
kayg:train/2026-10-19ah
kayg:issue/swipe-offscreen
kayg:train/2026-10-19ag
kayg:archive/old/issue/590-nlp-adr
kayg:archive/old/issue/587-event-after-write-2
kayg:train/2026-10-19af
kayg:archive/old/issue/587-event-after-write
kayg:issue/469-pill-room-c
kayg:issue/469-pill-room
kayg:train/2026-10-19ae
kayg:issue/469-narrow-handle
kayg:issue/397-ios-swipe-2
kayg:archive/old/issue/adrs-photos-files-tasks
kayg:issue/469-desk-fixes
kayg:archive/old/issue/auto-update-adr
kayg:issue/469-filter-gap
kayg:issue/469-port-1b
kayg:issue/442-opacity-flake
kayg:archive/397-ios-swipe-2
kayg:issue/327-web-fast-3
kayg:archive/old/issue/469-port-1
kayg:issue/469-port-1
kayg:issue/327-web-fast-2
kayg:archive/old/issue/327-web-fast
kayg:archive/old/issue/425-stt-bench-vq1
kayg:archive/old/issue/445-no-bleed
kayg:archive/old/issue/400-swipe-mockup-2
kayg:issue/426-client-review
kayg:issue/426-client-2
kayg:issue/426-client
kayg:archive/old/issue/476-safe-area-lab
kayg:archive/445-top-light-2
kayg:archive/old/issue/445-top-light
kayg:issue/471-blocks-mockup
kayg:archive/old/issue/448-links-app-2
kayg:archive/old/issue/448-links-app
kayg:archive/old/issue/398-cold-links
kayg:issue/434-442-small-2
kayg:issue/434-442-small
kayg:archive/old/issue/398-unload
kayg:archive/old/issue/445-bottom-band
kayg:issue/445-bottom-band
kayg:issue/351-rem-3
kayg:archive/312-views-mockup
kayg:issue/351-rem-2
kayg:issue/351-rem
kayg:archive/old/issue/327-first-note
kayg:issue/395-width-phone
kayg:archive/old/issue/327-typing
kayg:issue/396-ios-edges
kayg:issue/397-ios-swipe
kayg:archive/398-allocator
kayg:archive/old/issue/327-notes-index
kayg:issue/345-347-contrast-empty-2
kayg:archive/old/issue/44-arenas
kayg:issue/44-arenas
kayg:archive/integ325
kayg:archive/old/issue/327-perf-harness
kayg:archive/old/issue/44-thp
kayg:issue/44-thp
kayg:archive/old/issue/285-sticky-pills
kayg:archive/old/issue/44-trim-3
kayg:issue/44-trim-3
kayg:archive/old/issue/165-cards
kayg:archive/old/issue/165-picker-2
kayg:archive/old/issue/212-multi-select
No reviewers
Labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set
Reference
kayg/calternal!929
Loading…
Reference in a new issue
No description provided.
Delete branch "docs/in-code-batch-1"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Adds in-code documentation to
markdown-view,imap-uid,prefs,migrate-v0,plugin-hello,testkitandfixtures. The final diff changes comments and whitespace only; added lint attributes were removed. New prefs input explanations stay in module docs so JSON Schema and the action contract keep their existing descriptions.The requested workspace rustdoc gate also required 15 one-line documentation corrections in 14 files under notes, contacts, tasks, contacts-actions and auth: private/ambiguous/unresolved links and unescaped placeholder paths. These are link repairs, not full documentation batches for those crates.
Final head:
35e233dda853836d2922cde00c4d017465eb1628, current with dev9377d711217532a44973edcf63c2af0b7f7969d8. A string-aware non-comment token comparison covers all 35 changed Rust files with zero differences.Final gate table, exact commands and evidence: fmt, clippy, workspace tests and warning-denied rustdoc pass. The first crash-test failure did not reproduce in ten candidate plus ten dev repeats; the subsequent full workspace run passed. Stability follow-up: #955.
Perf is not green. Stripped binaries differ from dev only in source-location line numbers, so the binary-identity exemption was not taken. Both perf locks were held for dev-vs-dev control and candidate ABAB. Every run completed all scenarios but exceeded the same existing page-tag and idle-CPU budgets; five metrics have slower candidate quantiles beyond the observed control range. All 51 deltas and raw reports. No flat-or-better claim or merge recommendation.
The other crates and web/packages still need their later documentation batches. No merge performed.
resumed validation at head
7c886f30daagainst dev9377d71121.#![warn(missing_docs)]attributes in atomic commit47c106c3and pushed immediately.7c886f30and pushed; no conflicts.git diff origin/dev...HEADtouches 21 Rust files only. a string-aware lexer, including raw strings, character literals and nested block comments, compared non-comment tokens with the merge base: zero differences. token digest:53aff8eac970013ddebfb4975bd1a75a426cbb32acff6020d9705528a4298505.no merge will be performed.
validation update: the first
cargo test --workspacestopped atplugins::tests::contract_matches_the_server(34 passed, 1 failed, 1 ignored in that binary). The new///comments onprefs::Setand its fields feedschemars::JsonSchema, so comments can change the action contract even when non-comment tokens match.Commit
d5222549moves that input explanation into module docs and restores the type/field docs to dev's state. It changes comments only; the token comparison still reports zero differences. No contract JSON or implementation code was changed. A contract-generation probe on the original head is queued to capture the exact difference, followed by fresh gates on the corrected head.fmt and clippy passed on
7c886f30. rustdoc, the probe and the final release build are currently queued behind the dev-01 train lock through ~/bin/slot. Baseline dev release binaries have been built and saved. Final results will supersede this intermediate status.head
38d99d2d5dfixes two rustdoc links in comments only: privateRelationshipbecame plain prose, and the unresolvedLimitslink is nowcrate::Limits. Full workspace tests, including the contract test and doctests, passed ond5222549; fresh gates and release binaries are rebuilding for38d99d2d.The release comparison against dev
9377d711differs afterstrip --strip-debug, so the perf exemption is NOT taken. ELF inspection explains every difference: only.data.rel.rodiffers;.text,.rodata, symbol tables and all other sections are byte-identical. Decoding relocations identifies only source-location line numbers: 119 incalternal, 4 incalternal-perf, and 85 inmarkdown-worker. Every referenced old/new source line is byte-identical, with the same column. For example,crates/markdown-view/src/lines.rs:287:26moves to:372:26.Perf-01's shared lock was acquired first, then perf-02's; both are held together. Measuring on perf-01, with SHA256 verified after relay through the control host. Dev-vs-dev ABAB control is running first with the same dev harness and server in both roles. Candidate ABAB follows on the final head. Command per invocation:
calternal-perf --bin <server> --work <owned-work> --sizes 100k --runs 3 --cold-runs 1 --idle-secs 300 --budgets <pinned-perf/budgets.json> --gate --json <report.json> --md <report.md>. The 100k Home exercises the full server scenario set at the largest standard size; two candidate invocations yield six warm runs per revision. Both locks will be released and generated Homes/targets removed before handback.git diff origin/dev...HEAD: 21 Rust files, zero non-comment token differences, same token digest as the prior note. No merge performed.perf control update (unchanged dev
9377d711, both shared perf locks held, perf-01): the first two dev-vs-dev invocations completed every scenario without failures. Both exited 1 because existing budgets are exceeded:The remaining two controls and candidate ABAB are still running/queued. These are baseline budget failures; they are not evidence of a candidate regression. Final reporting will include every metric's candidate delta and the control spread.
Final head
38d99d2dis pinned in both dev-01 worktrees. Its gate rerun and release rebuild are waiting through ~/bin/slot behind the renewed train; the earlier complete workspace test passed ond5222549, and the two rustdoc link errors from that run are fixed in38d99d2d. No implementation changes or merge performed.perf results for head
38d99d2d5d3a0102f457d2e8547faa7f510d3445versus dev9377d711217532a44973edcf63c2af0b7f7969d8.perf is not green. all eight invocations completed every scenario without failures, but all exited 1 on the existing
home.page_tagandidle.cpu_pctbudgets, including every unchanged-dev control. Five metrics also have at least one slower candidate quantile beyond the full observed dev-control range:home.pagep95 (+71.74%),mem.after_opensp95 (+5.17%),shutdownp50 (+0.40%),sync.round_tripp50/p95 (+18.85%/+8.10%), andsync.save_ackp50 (+3.80%). The control range is descriptive, not a statistical confidence bound. These results do not establish flat-or-better performance, so no perf pass or merge recommendation is claimed.Measurements ran on perf-01 with the shared
~/bin/perf-lockacquired on perf-01 first, then perf-02, held together for the entire control and candidate session. Dev-vs-dev ABAB (c1-devA,c2-devB,c3-devA,c4-devB) preceded dev/head/dev/head (a1-dev,a2-head,a3-dev,a4-head). The same pinned dev harness and budget file were used throughout. Two invocations per candidate role give six warm runs, two cold runs, and two 300-second idle samples per revision at 100k notes. No frame timing was measured. SHA256 values were checked after relaying the dev-01 builds through the control host.Exact command per invocation, from
~/perf/pr929on perf-01:Both holder units are now stopped and verified inactive; the 100k fixture/work directories were removed before releasing the locks. Raw JSON/Markdown, logs, before/after machine snapshots, scripts, hashes, budgets and the derived comparison are attached: perf results ZIP. Final workspace gate table follows when the queued test/doc run completes.
PR 929 perf comparison
median of each role's two invocation summaries; each invocation has 3 warm runs and 1 cold run; control spread is the full min-to-max range of four dev-control invocation summaries, not a confidence interval.
51 metrics; all eight invocations completed without scenario failures.
Budget failures
Deltas for every metric
head
199f1c13ea282d353d81f100b9a5306cfd3129ccfixes seven existing dev rustdoc diagnostics in comments only (notes: private links and ambiguousformat; contacts: unescaped<calternal-id>placeholders). This adds seven one-line comment edits outside the original seven crates because the requested workspace-wide warning-denied doc gate encounters them. No implementation or visibility change. Pushed atomically.On
38d99d2d, the final pinned fmt, clippy and full workspace test gates all passed; doc exited 101 on those pre-existing diagnostics. The comments-only token check now covers 28 Rust files with zero differences. Rustdoc is rerunning first, followed by final-head gates and a release hash check. The final release hash check will determine whether the completed perf measurements cover the updated head byte-for-byte. No merge performed.final gate table for
35e233dda8, against dev9377d71121. PR remains open and unmerged; no reviews are posted. Overall status: perf is not green.git diff origin/dev...HEADpluspython3 /tmp/pr929-tokens.pygit merge origin/dev7c886f30, pushed; final fetch reportsgit rev-list --left-right --count origin/dev...HEAD=0 13cargo fmt --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspaceRUSTDOCFLAGS="-D warnings" cargo doc --workspace --no-depscargo build --release --locked --bin calternal --bin calternal-perf --bin markdown-workerstrip --strip-debug <binary>;sha256sum <binary>;cmp -s <dev-binary> <head-binary>./dev/calternal-perf --bin "$PWD/$label/calternal" --work "$PWD/work" --sizes 100k --runs 3 --cold-runs 1 --idle-secs 300 --budgets "$PWD/budgets.json" --gate --json "$PWD/reports/$run.json" --md "$PWD/reports/$run.md"All Cargo commands ran on dev-01 in owned VM worktrees with Nix,
CARGO_BUILD_JOBS=4and~/bin/slot. The gate batch usednix develop -c bash -c '~/bin/slot bash ~/pr929-final-inner.sh'; the release build usednix develop -c bash -c 'export CARGO_BUILD_JOBS=4; ~/bin/slot cargo build --release --locked --bin calternal --bin calternal-perf --bin markdown-worker'. No build/test ran on the control host.The first test attempt on this head exited 101 in
kill_nine_mid_append_on_a_long_note:std::fs::read(path)returned NotFound after an existence check. Ten separate candidate invocations and ten dev invocations ofcargo test -p calternal --test notes_crash kill_nine_mid_append_on_a_long_note -- --exact --nocaptureall passed; then the full candidate workspace rerun passed. Stability follow-up: #955. The initial failure remains in the attached logs; it is not hidden by the final passing result.Corrections are pushed atomically: removed the seven added lint attributes (
47c106c3); kept new prefs explanations out of schema-derived type/field docs to preserve the action contract (d5222549); fixed two batch rustdoc links (38d99d2d); fixed 15 existing workspace documentation diagnostics in notes, contacts, tasks, contacts-actions and auth (199f1c13,0579688e,35e233dd). Those last changes are 15 one-line comment corrections in 14 additional files. No code, visibility, contract fixture or warning suppression changed. Final token digest:cda90d75c05d76f24b6616fd3a7d609aeb7128ead6ae5c8e0bf02856b73cd83f.Stripped release SHA256 values:
b79f4a0d60f9cc3ae6b72866b3d9aab86966c1085c238ad8267521efc0e98e680dca9a8510027589e1297b92407f87083e62c7d976c2f8383e1818b727c760e5677df49109343d668111b4debe086ba0db89428b9268ed09fa4f9433fa424bb130b897e5ee40391ac34b55c263d0ea10d147116389e85fda23e3b2837f34d4115db4a8f048ca957b398cf78ca3ee6fad963769c403501cbe9be331e661344f5962afb986bea1522ded7d3706085cc8a5cb6980d9020bd94751d4af42c82dbb48ELF validation against the final source finds only
.data.rel.rochanged: 119 source line numbers in calternal, 4 in calternal-perf and 85 in markdown-worker..text,.rodata, symbols and all other sections are byte-identical. Every decoded old/new source line and column matches. The final-head binaries are byte-identical to the measured38d99d2dcandidate, so the completed ABAB report, all 51 deltas and raw perf artifacts apply to this head without another measurement. Both shared perf locks were held throughout the dev-vs-dev control and candidate ABAB, then stopped and verified inactive. No flat-or-better claim is made: existing page-tag/idle budgets fail on dev and candidate, and home.page, mem.after_opens, shutdown, sync.round_trip and sync.save_ack have the slower quantiles listed in that report.Gate evidence ZIP contains complete Cargo logs, the first failure, repeat logs, scripts, final summary, lexer/proof and ELF analysis. All owned jobs are finished; both perf locks are released; seeded perf Homes and both throwaway VM target directories (about 12.8 GiB) are removed. Working trees are clean. Remaining risks are the non-green perf evidence and the intermittent test tracked in #955. Never merged.
Orchestrator decision: no perf change, by proof.
.text,.rodataand the symbols are byte-identical to dev. Only the panic-location line numbers in.data.rel.rodiffer, and the section sizes are equal.I'll merge this after BM14e (#914) lands, so that BM14e's green run stays on the dev it was tested against. The crash-test flake is tracked in #955.
kayg referenced this pull request2026-11-05 23:21:11 +00:00
Landed in dev via
ca7dead12c— closing.Pull request closed