kayg/calternal
Watch
1
0
Fork
You've already forked calternal
 0
Code Issues 190 Pull requests 61 Projects Releases Packages Wiki Activity Actions 26

fix(ui): palette snippet contrast on light glass; deterministic contrast spec #944

Closed
kayg wants to merge 1 commit from fix/palette-snippet-contrast into dev
pull from: fix/palette-snippet-contrast
merge into: kayg:dev
Conversation 1 Commits 1 Files changed 2 +9 -4
kayg commented 2026-11-04 20:26:24 +00:00
Owner
Copy link

Fixes the intermittent contrast.spec.ts:174 failure found on train BM14e (#914, comment 78900).

Cause. The failing glyph is the note snippet (.sn, --ink-3) in the palette, light look, over a page of huge black words. Its ratio was 4.23 to 4.40 (needs 4.5). It was intermittent because the spec seeded notes with random titles (Kept-xxxxxx), so the width of the huge words behind the palette changed each run and fell on different pixels. 4 of 6 runs passed on dev-01 with the old code; failures were all at 1440.

Fix (product). --glass-ink-3 (light) is now #403a34, as deep as ink 2, so every quiet label on any glass follows. One glass, no local override. Worst measured backdrop gives about 4.8.

Fix (test). Note titles are fixed (Kept, Gone 1..3); ids stay random. The backdrop is now the same every run, and the product fix covers any other layout.

Evidence for the repeat runs is posted on #914.

🤖 Generated with Claude Code

Fixes the intermittent `contrast.spec.ts:174` failure found on train BM14e (#914, comment 78900). **Cause.** The failing glyph is the note snippet (`.sn`, `--ink-3`) in the palette, light look, over a page of huge black words. Its ratio was 4.23 to 4.40 (needs 4.5). It was intermittent because the spec seeded notes with random titles (`Kept-xxxxxx`), so the width of the huge words behind the palette changed each run and fell on different pixels. 4 of 6 runs passed on dev-01 with the old code; failures were all at 1440. **Fix (product).** `--glass-ink-3` (light) is now `#403a34`, as deep as ink 2, so every quiet label on any glass follows. One glass, no local override. Worst measured backdrop gives about 4.8. **Fix (test).** Note titles are fixed (`Kept`, `Gone 1..3`); ids stay random. The backdrop is now the same every run, and the product fix covers any other layout. Evidence for the repeat runs is posted on #914. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
fix(ui): quiet inks on light glass keep 4.5:1 over huge words; contrast spec uses fixed titles
Some checks failed
CI / server (pull_request) Has been cancelled
Details
CI / rust (pull_request) Has been cancelled
Details
CI / web (pull_request) Has been cancelled
Details
Markdown extraction contract / markdown-native-contract (pull_request) Has been cancelled
Details
Markdown extraction contract / markdown-editor-contract (pull_request) Has been cancelled
Details
6fa8c53a37 
The palette's note snippets (--ink-3 on glass) measured 4.2 to 4.4 over a page of huge black
words. The glass ink 3 is now as deep as ink 2. The spec's random note titles moved the words
behind the palette from run to run, which is why it failed only sometimes; titles are fixed.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
kayg commented 2026-11-07 18:11:57 +00:00
Author
Owner
Copy link

Content landed in dev via 12103f1c97 — closing.

Content landed in dev via 12103f1c973f1e810dd4a9a3bff5a705514d70b0 — closing.
kayg closed this pull request 2026-11-07 18:11:57 +00:00
Some checks failed
CI / server (pull_request) Has been cancelled
Details
CI / rust (pull_request) Has been cancelled
Details
CI / web (pull_request) Has been cancelled
Details
Markdown extraction contract / markdown-native-contract (pull_request) Has been cancelled
Details
Markdown extraction contract / markdown-editor-contract (pull_request) Has been cancelled
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backend
Rust server

  
design
Mockups, UI and TASTE

  
docs
ADRs, CONTEXT, TASTE

  
idea
Parked idea, never worked until promoted

  
infra
Deploy, CI, VMs

  
perf
Performance and budgets

  
reliability
Data integrity, corruption traps

  
web
Web client

No labels
backend
design
docs
idea
infra
perf
reliability
web
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kayg/calternal!944
No description provided.