kayg/calternal
Watch
1
0
Fork
You've already forked calternal
 0
Code Issues 190 Pull requests 61 Projects Releases Packages Wiki Activity Actions 26

test(web): vim :w waits for the note to be saved (fixes BM14e flake) #954

Closed
kayg wants to merge 1 commit from fix/vim-w-waits-for-save into dev
pull from: fix/vim-w-waits-for-save
merge into: kayg:dev
Conversation 1 Commits 1 Files changed 1 +3 -1
kayg commented 2026-11-05 07:07:15 +00:00
Owner
Copy link

Fixes a flake that blocked train BM14e (#914): vim.spec.ts ": commands in the bar" failed 3/10 on dev and 5/10 on the train (chromium-1440).

:w answers "Saved" only once the server's receipt covers the edits, and "Not saved yet" before that (packages/editor/test/vim.test.ts, ":w reports Saved only after the authority has a covering receipt"). The spec typed :s and :%s and sent :w at once, so on a busy host it got the second answer. It now waits for the page's own save state (article.page[data-save=saved]) first. No timeout changed; the expected text is unchanged.

Test only: apps/web/e2e/vim.spec.ts. Evidence on #914.

Fixes a flake that blocked train BM14e (#914): `vim.spec.ts` ": commands in the bar" failed 3/10 on dev and 5/10 on the train (chromium-1440). `:w` answers "Saved" only once the server's receipt covers the edits, and "Not saved yet" before that (`packages/editor/test/vim.test.ts`, ":w reports Saved only after the authority has a covering receipt"). The spec typed `:s` and `:%s` and sent `:w` at once, so on a busy host it got the second answer. It now waits for the page's own save state (`article.page[data-save=saved]`) first. No timeout changed; the expected text is unchanged. Test only: `apps/web/e2e/vim.spec.ts`. Evidence on #914.
test(web): vim :w waits for the note to be saved before it expects "Saved"
Some checks failed
CI / server (pull_request) Has been cancelled
Details
CI / rust (pull_request) Has been cancelled
Details
CI / web (pull_request) Has been cancelled
Details
Markdown extraction contract / markdown-native-contract (pull_request) Has been cancelled
Details
Markdown extraction contract / markdown-editor-contract (pull_request) Has been cancelled
Details
3966b7f217 
:w answers "Saved" only once the server's receipt covers the edits, and "Not saved yet" before
that (packages/editor vim.test.ts). The spec typed :s and :%s and sent :w at once, so on a busy
host it got the second answer (3/10 on dev, 5/10 on the BM14e train).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
kayg commented 2026-11-07 18:11:54 +00:00
Author
Owner
Copy link

Content landed in dev via 12103f1c97 — closing.

Content landed in dev via 12103f1c973f1e810dd4a9a3bff5a705514d70b0 — closing.
kayg closed this pull request 2026-11-07 18:11:54 +00:00
Some checks failed
CI / server (pull_request) Has been cancelled
Details
CI / rust (pull_request) Has been cancelled
Details
CI / web (pull_request) Has been cancelled
Details
Markdown extraction contract / markdown-native-contract (pull_request) Has been cancelled
Details
Markdown extraction contract / markdown-editor-contract (pull_request) Has been cancelled
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backend
Rust server

  
design
Mockups, UI and TASTE

  
docs
ADRs, CONTEXT, TASTE

  
idea
Parked idea, never worked until promoted

  
infra
Deploy, CI, VMs

  
perf
Performance and budgets

  
reliability
Data integrity, corruption traps

  
web
Web client

No labels
backend
design
docs
idea
infra
perf
reliability
web
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kayg/calternal!954
No description provided.