kayg/infraternal
Watch
1
0
Fork
You've already forked infraternal
 0
Code Issues 356 Pull requests Projects Releases Packages Wiki Activity Actions

S1 lane: protocol codec (Rust + TS), fuzzing, golden vectors #15

New issue
Closed
opened 2026-10-06 10:10:48 +00:00 by kayg · 19 comments
kayg commented 2026-10-06 10:10:48 +00:00
Owner
Copy link

Implement contracts/wire.md §2–§4 in infraternal-protocol (Rust) and packages/protocol (TS), with shared golden test vectors, the fuzz target wire_frame_decode, and Criterion and JS benchmarks against the #12 numbers. Base: s1-base 386acfd. Part of #9.

Implement `contracts/wire.md` §2–§4 in `infraternal-protocol` (Rust) and `packages/protocol` (TS), with shared golden test vectors, the fuzz target `wire_frame_decode`, and Criterion and JS benchmarks against the #12 numbers. Base: `s1-base` `386acfd`. Part of #9.
kayg commented 2026-10-06 10:11:57 +00:00
Author
Owner
Copy link

Starting protocol codec work on branch lane-protocol, based on 386acfd3dc. Finding: contracts/wire.md §2-§3 says LEB128 varint but does not define maximum width or whether non-minimal encodings are valid. Proposed implementation profile: unsigned u32 LEB128, shortest-form only; frame lengths are bounded to 4 MiB before any allocation, and stream IDs / nested string lengths use the same u32 representation. I will implement this consistently in Rust and TypeScript and flag the added constraint in the result.

Starting protocol codec work on branch lane-protocol, based on 386acfd3dc6255c7f58f98b4f114d5d7326292ad. Finding: contracts/wire.md §2-§3 says LEB128 varint but does not define maximum width or whether non-minimal encodings are valid. Proposed implementation profile: unsigned u32 LEB128, shortest-form only; frame lengths are bounded to 4 MiB before any allocation, and stream IDs / nested string lengths use the same u32 representation. I will implement this consistently in Rust and TypeScript and flag the added constraint in the result.
kayg commented 2026-10-06 10:37:26 +00:00
Author
Owner
Copy link

Finding: while implementing vectors, the initial Close encoder incorrectly added a varint reason length. contracts/wire.md §4 specifies u16 code followed by UTF-8 reason to the end of the body; the §2 length-prefixed string rule applies only where the table says varint+utf8. The shared golden test exposed the extra 0x04 byte in close.bin. Fixed Rust and TypeScript encoders and regenerated contracts/vectors/wire/close.bin; bun test and the Rust protocol tests now pass all 17 frame vectors.

Finding: while implementing vectors, the initial Close encoder incorrectly added a varint reason length. contracts/wire.md §4 specifies u16 code followed by UTF-8 reason to the end of the body; the §2 length-prefixed string rule applies only where the table says varint+utf8. The shared golden test exposed the extra 0x04 byte in close.bin. Fixed Rust and TypeScript encoders and regenerated contracts/vectors/wire/close.bin; bun test and the Rust protocol tests now pass all 17 frame vectors.
kayg commented 2026-10-06 10:47:45 +00:00
Author
Owner
Copy link

Performance finding (measured in crates/infraternal-protocol/benches/wire_codec.rs): Criterion used the spike's 20 samples, 200 ms warmup and 500 ms measurement. Sequence/payload summary medians were 10.635 ns for 1-byte Input and 10.952 ns for 64-byte Output; full typed-frame medians were 14.378 ns and 15.275 ns. The #12 spike reported 4.63 ns and 4.95 ns for its simpler four-frame decoder with fixed-width length framing. The full §4 typed decoder is slower, and I'm recording both summary and full-path results while completing the requested fuzz and checks.

Performance finding (measured in crates/infraternal-protocol/benches/wire_codec.rs): Criterion used the spike's 20 samples, 200 ms warmup and 500 ms measurement. Sequence/payload summary medians were 10.635 ns for 1-byte Input and 10.952 ns for 64-byte Output; full typed-frame medians were 14.378 ns and 15.275 ns. The #12 spike reported 4.63 ns and 4.95 ns for its simpler four-frame decoder with fixed-width length framing. The full §4 typed decoder is slower, and I'm recording both summary and full-path results while completing the requested fuzz and checks.
kayg commented 2026-10-06 10:59:24 +00:00
Author
Owner
Copy link

Finding from review: crates/infraternal-protocol/src/lib.rs::StreamDecoder::buffer_bytes currently uses try_reserve_exact for each received chunk. The streaming harness feeds 3-byte chunks (fuzz/fuzz_targets/wire_stream_decode.rs); for a 4 KiB partial frame, exact growth can request about 1,365 reallocations and copy roughly 2.8 MiB cumulatively. I am changing growth to geometric capacity bounded by the validated frame length, then restarting the streaming fuzz run against that implementation.

Finding from review: crates/infraternal-protocol/src/lib.rs::StreamDecoder::buffer_bytes currently uses try_reserve_exact for each received chunk. The streaming harness feeds 3-byte chunks (fuzz/fuzz_targets/wire_stream_decode.rs); for a 4 KiB partial frame, exact growth can request about 1,365 reallocations and copy roughly 2.8 MiB cumulatively. I am changing growth to geometric capacity bounded by the validated frame length, then restarting the streaming fuzz run against that implementation.
kayg commented 2026-10-06 11:04:37 +00:00
Author
Owner
Copy link

Finding: Bun 1.4.2's default TextDecoder strips an initial UTF-8 BOM () and returns , while Rust std::str::from_utf8 preserves it as U+FEFF. That would make the same Hello.client_info bytes decode differently across clients. I will set ignoreBOM: true in packages/protocol/src/codec.ts and change the shared Hello vector to begin with U+FEFF so both implementations prove parity.

Finding: Bun 1.4.2's default TextDecoder strips an initial UTF-8 BOM () and returns , while Rust std::str::from_utf8 preserves it as U+FEFF. That would make the same Hello.client_info bytes decode differently across clients. I will set ignoreBOM: true in packages/protocol/src/codec.ts and change the shared Hello vector to begin with U+FEFF so both implementations prove parity.
kayg commented 2026-10-06 11:04:48 +00:00
Author
Owner
Copy link

Finding: Bun 1.4.2 default TextDecoder strips the initial UTF-8 BOM bytes EF BB BF and returns only the following A, while Rust std::str::from_utf8 preserves U+FEFF. The same Hello.client_info bytes would decode differently across clients. I will set ignoreBOM true in packages/protocol/src/codec.ts and change the shared Hello vector to begin with U+FEFF so both implementations prove parity.

Finding: Bun 1.4.2 default TextDecoder strips the initial UTF-8 BOM bytes EF BB BF and returns only the following A, while Rust std::str::from_utf8 preserves U+FEFF. The same Hello.client_info bytes would decode differently across clients. I will set ignoreBOM true in packages/protocol/src/codec.ts and change the shared Hello vector to begin with U+FEFF so both implementations prove parity.
kayg commented 2026-10-06 11:15:36 +00:00
Author
Owner
Copy link

Fuzz evidence on final Rust source: wire_frame_decode completed 601 s with 323,552,539 executions (538,356 exec/s average, 535 MiB peak RSS); wire_stream_decode completed 601 s with 13,342,465 executions (22,200 exec/s average, 510 MiB peak RSS). Neither target found a crash. The streaming run exercised the geometric bounded-growth buffer implementation.

Fuzz evidence on final Rust source: wire_frame_decode completed 601 s with 323,552,539 executions (538,356 exec/s average, 535 MiB peak RSS); wire_stream_decode completed 601 s with 13,342,465 executions (22,200 exec/s average, 510 MiB peak RSS). Neither target found a crash. The streaming run exercised the geometric bounded-growth buffer implementation.
kayg commented 2026-10-06 11:18:09 +00:00
Author
Owner
Copy link

Benchmark evidence: the lower-contention Criterion run (same 20 samples, 200 ms warmup, 500 ms measure as #12 on the i9-9900K) measured Rust sequence/payload decode at 10.635 ns for Input/1 B and 10.952 ns for Output/64 B; full typed decode at 14.378 ns and 15.275 ns; reusable encode at 14.972 ns and 10.043 ns. Compared with #12 specialized decode at 4.63 ns and 4.95 ns, the new full codec costs about 3.1x and 3.1x (summary-only decode about 2.3x and 2.2x), while remaining about 5x faster than the #12 prost comparison. Bun medians were 232.8 ns and 237.5 ns (about 4.04M exec/s), versus #12 Chrome 153 at 287.1 ns and 283.3 ns; runtime comparison is not apples-to-apples. A later retry was discarded as host-contended: mpstat showed 89% average CPU busy across all cores during concurrent OpenSSL builds, and Criterion intervals widened to 24.7–47.3 ns for Input encode and 35.8–46.0 ns for Input summary decode.

Benchmark evidence: the lower-contention Criterion run (same 20 samples, 200 ms warmup, 500 ms measure as #12 on the i9-9900K) measured Rust sequence/payload decode at 10.635 ns for Input/1 B and 10.952 ns for Output/64 B; full typed decode at 14.378 ns and 15.275 ns; reusable encode at 14.972 ns and 10.043 ns. Compared with #12 specialized decode at 4.63 ns and 4.95 ns, the new full codec costs about 3.1x and 3.1x (summary-only decode about 2.3x and 2.2x), while remaining about 5x faster than the #12 prost comparison. Bun medians were 232.8 ns and 237.5 ns (about 4.04M exec/s), versus #12 Chrome 153 at 287.1 ns and 283.3 ns; runtime comparison is not apples-to-apples. A later retry was discarded as host-contended: mpstat showed 89% average CPU busy across all cores during concurrent OpenSSL builds, and Criterion intervals widened to 24.7–47.3 ns for Input encode and 35.8–46.0 ns for Input summary decode.
kayg commented 2026-10-06 11:20:18 +00:00
Author
Owner
Copy link

Finished S1 lane protocol codec on branch lane-protocol. Head: 407057272ce0e33c8b9e6dfed10a03c719887e77.

Both final-source cargo-fuzz runs completed 601 seconds without crashes: wire_frame_decode 323,552,539 executions (538,356/s average, 535 MiB peak RSS); wire_stream_decode 13,342,465 executions (22,200/s average, 510 MiB peak RSS).

Benchmark results and the host-contention caveat are in the preceding issue comment. Bun and Rust golden tests pass against the same 17-frame manifest. The contract clarifies the previously unspecified varint rule as shortest-form unsigned u32 LEB128.

Required gate command exited 0. Gate output (verbatim):


==> fmt

==> clippy
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.06s

==> test
    Finished `test` profile [unoptimized + debuginfo] target(s) in 0.06s
     Running unittests src/main.rs (target/debug/deps/infraternal-239f4951fa340219)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src/lib.rs (target/debug/deps/infraternal_agent-eadaa10b8c42bfd9)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src/lib.rs (target/debug/deps/infraternal_plugin_api-4480fd7032f11ca2)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src/lib.rs (target/debug/deps/infraternal_plugin_ssh-22a9a893799c7f17)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src/lib.rs (target/debug/deps/infraternal_protocol-6aec3e05ca065f96)

running 4 tests
test tests::mux_round_trip_and_incremental_decoders_preserve_frame_order ... ok
test tests::rejects_oversized_noncanonical_and_malformed_frames_before_buffering_body ... ok
test tests::oversized_encode_keeps_the_reusable_output_unchanged ... ok
test tests::golden_vectors_encode_and_decode_every_contract_frame ... ok

test result: ok. 4 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src/lib.rs (target/debug/deps/infraternal_server-3a7dcd467cd5ddf2)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src/lib.rs (target/debug/deps/infraternal_shim-2036f3f8f778c3eb)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests infraternal_agent

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests infraternal_plugin_api

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests infraternal_plugin_ssh

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests infraternal_protocol

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests infraternal_server

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests infraternal_shim

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s


==> cargo-deny
advisories ok, bans ok, licenses ok, sources ok

==> static builds
    Finished `release` profile [optimized] target(s) in 0.04s
target/x86_64-unknown-linux-musl/release/infraternal: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), static-pie linked, stripped
PT_INTERP: absent; size: 705624 bytes
    Finished `release` profile [optimized] target(s) in 0.03s
target/aarch64-unknown-linux-musl/release/infraternal: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), statically linked, stripped
PT_INTERP: absent; size: 607880 bytes
server subcommand: exit 2, not implemented
agent subcommand: exit 2, not implemented

+---------------------------+--------------+
| Rust gate                 | Result       |
+---------------------------+--------------+
| fmt                       | PASS         |
| clippy                    | PASS         |
| test                      | PASS         |
| cargo-deny                | PASS         |
| static builds             | PASS         |
+---------------------------+--------------+

==> TypeScript protocol tests
bun test v1.4.2 (744846f84)

src/codec.test.ts:
(pass) wire protocol golden vectors > encodes and decodes each frame exactly as the shared manifest describes [5.22ms]
(pass) wire protocol golden vectors > returns borrowed payload views and writes into reusable buffers [0.18ms]
(pass) wire protocol golden vectors > decodes muxed messages split across WebSocket messages [0.76ms]
(pass) wire protocol golden vectors > rejects oversized, non-canonical, unknown, and malformed frame bytes [0.18ms]

 4 pass
 0 fail
 63 expect() calls
Ran 4 tests across 1 file. [10.00ms]
Finished S1 lane protocol codec on branch lane-protocol. Head: 407057272ce0e33c8b9e6dfed10a03c719887e77. Both final-source cargo-fuzz runs completed 601 seconds without crashes: wire_frame_decode 323,552,539 executions (538,356/s average, 535 MiB peak RSS); wire_stream_decode 13,342,465 executions (22,200/s average, 510 MiB peak RSS). Benchmark results and the host-contention caveat are in the preceding issue comment. Bun and Rust golden tests pass against the same 17-frame manifest. The contract clarifies the previously unspecified varint rule as shortest-form unsigned u32 LEB128. Required gate command exited 0. Gate output (verbatim): ```text ==> fmt ==> clippy Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.06s ==> test Finished `test` profile [unoptimized + debuginfo] target(s) in 0.06s Running unittests src/main.rs (target/debug/deps/infraternal-239f4951fa340219) running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Running unittests src/lib.rs (target/debug/deps/infraternal_agent-eadaa10b8c42bfd9) running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Running unittests src/lib.rs (target/debug/deps/infraternal_plugin_api-4480fd7032f11ca2) running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Running unittests src/lib.rs (target/debug/deps/infraternal_plugin_ssh-22a9a893799c7f17) running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Running unittests src/lib.rs (target/debug/deps/infraternal_protocol-6aec3e05ca065f96) running 4 tests test tests::mux_round_trip_and_incremental_decoders_preserve_frame_order ... ok test tests::rejects_oversized_noncanonical_and_malformed_frames_before_buffering_body ... ok test tests::oversized_encode_keeps_the_reusable_output_unchanged ... ok test tests::golden_vectors_encode_and_decode_every_contract_frame ... ok test result: ok. 4 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Running unittests src/lib.rs (target/debug/deps/infraternal_server-3a7dcd467cd5ddf2) running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Running unittests src/lib.rs (target/debug/deps/infraternal_shim-2036f3f8f778c3eb) running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Doc-tests infraternal_agent running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Doc-tests infraternal_plugin_api running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Doc-tests infraternal_plugin_ssh running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Doc-tests infraternal_protocol running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Doc-tests infraternal_server running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Doc-tests infraternal_shim running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s ==> cargo-deny advisories ok, bans ok, licenses ok, sources ok ==> static builds Finished `release` profile [optimized] target(s) in 0.04s target/x86_64-unknown-linux-musl/release/infraternal: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), static-pie linked, stripped PT_INTERP: absent; size: 705624 bytes Finished `release` profile [optimized] target(s) in 0.03s target/aarch64-unknown-linux-musl/release/infraternal: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), statically linked, stripped PT_INTERP: absent; size: 607880 bytes server subcommand: exit 2, not implemented agent subcommand: exit 2, not implemented +---------------------------+--------------+ | Rust gate | Result | +---------------------------+--------------+ | fmt | PASS | | clippy | PASS | | test | PASS | | cargo-deny | PASS | | static builds | PASS | +---------------------------+--------------+ ==> TypeScript protocol tests bun test v1.4.2 (744846f84) src/codec.test.ts: (pass) wire protocol golden vectors > encodes and decodes each frame exactly as the shared manifest describes [5.22ms] (pass) wire protocol golden vectors > returns borrowed payload views and writes into reusable buffers [0.18ms] (pass) wire protocol golden vectors > decodes muxed messages split across WebSocket messages [0.76ms] (pass) wire protocol golden vectors > rejects oversized, non-canonical, unknown, and malformed frame bytes [0.18ms] 4 pass 0 fail 63 expect() calls Ran 4 tests across 1 file. [10.00ms] ```
kayg commented 2026-10-06 11:23:12 +00:00
Author
Owner
Copy link

Independent read-only review started on lane-protocol, base 386acfd3dc, head 407057272ce0e33c8b9e6dfed10a03c719887e77. Reviewing safety, Rust/TypeScript parity, fuzzing, performance, API and history.

Independent read-only review started on lane-protocol, base 386acfd3dc6255c7f58f98b4f114d5d7326292ad, head 407057272ce0e33c8b9e6dfed10a03c719887e77. Reviewing safety, Rust/TypeScript parity, fuzzing, performance, API and history.
kayg commented 2026-10-06 11:24:25 +00:00
Author
Owner
Copy link

P1 blocker reproduced in both runtimes: incremental mux header refill copies up to 10 bytes without respecting the newly completed frame boundary, then clears the entire buffer (Rust src/lib.rs around 489-531; TS src/codec.ts around 213-242). Feed hex 0005140100000000030f0000 in chunks [first byte, remainder]: only Credit is delivered, then Rust EmptyFrame / TS empty-frame. Two valid Close envelopes 00030f000000030f0000 split after byte 1 silently deliver only one callback. Add all-split multi-frame equivalence tests; consume only the header or preserve buffered surplus.

P1 blocker reproduced in both runtimes: incremental mux header refill copies up to 10 bytes without respecting the newly completed frame boundary, then clears the entire buffer (Rust src/lib.rs around 489-531; TS src/codec.ts around 213-242). Feed hex 0005140100000000030f0000 in chunks [first byte, remainder]: only Credit is delivered, then Rust EmptyFrame / TS empty-frame. Two valid Close envelopes 00030f000000030f0000 split after byte 1 silently deliver only one callback. Add all-split multi-frame equivalence tests; consume only the header or preserve buffered surplus.
kayg commented 2026-10-06 11:26:43 +00:00
Author
Owner
Copy link

Review evidence: both Rust and TS fail 2/769 split-position cases over repeated golden vectors (close.bin split 1: one callback and 8 retained bytes; credit.bin split 1: one callback then EmptyFrame). Rust checks all 359 golden-vector truncations as Incomplete. Direct decoder differential: 24,504 deterministic mutated/golden/varint/mux cases + 3,450 cases from 119 frame and 1,606 stream corpus files, zero divergences (accepted 9,126 and 2,002 respectively); outputs and consumed lengths compared via re-encoding. Replay fuzz coverage: frame cov 280 / 963 counters, stream cov 472 / 1347 counters; no crash, but no semantic oracle and fixed 3-byte chunks do not exercise the found refill over-read. Evidence target/review--summary.json and target/review-fuzz-.log. History blocker: git log s1-base..lane-protocol contains only 4070572, violating the requested logical-step commit split. Fast gate passes; review verdict pending final report.

Review evidence: both Rust and TS fail 2/769 split-position cases over repeated golden vectors (close.bin split 1: one callback and 8 retained bytes; credit.bin split 1: one callback then EmptyFrame). Rust checks all 359 golden-vector truncations as Incomplete. Direct decoder differential: 24,504 deterministic mutated/golden/varint/mux cases + 3,450 cases from 119 frame and 1,606 stream corpus files, zero divergences (accepted 9,126 and 2,002 respectively); outputs and consumed lengths compared via re-encoding. Replay fuzz coverage: frame cov 280 / 963 counters, stream cov 472 / 1347 counters; no crash, but no semantic oracle and fixed 3-byte chunks do not exercise the found refill over-read. Evidence target/review-*-summary.json and target/review-fuzz-*.log. History blocker: git log s1-base..lane-protocol contains only 4070572, violating the requested logical-step commit split. Fast gate passes; review verdict pending final report.
kayg commented 2026-10-06 11:29:36 +00:00
Author
Owner
Copy link

Independent read-only review finished. Verdict: MERGE AFTER FIXES.
Head: 407057272ce0e33c8b9e6dfed10a03c719887e77

Blockers:

  • P1: Rust MuxStreamDecoder (src/lib.rs:485-520) and TS WebSocketFrameDecoder (codec.ts:188-214) lose trailing frame bytes during incomplete-header refill. Two valid muxed Close frames, hex 00030f000000030f0000, fed as first byte then remainder, silently emit only one callback in BOTH runtimes with no error. Fix frame-boundary consumption and add exhaustive multi-frame split regressions and a stream-equivalence fuzz oracle. Both runtimes fail 2/769 golden-vector split cases.
  • P2: one commit 4070572 for the entire lane violates the explicit owner rule. Split by contract, dependencies, Rust/TS codec modules, incremental modules, vectors/tests, fuzzing, benches and gate integration. Full proposed split is in the findings report. No history rewritten by this review.

Evidence: direct differential 24,504 generated cases plus 3,450 existing fuzz-corpus mode/case pairs, zero Rust/TS divergences; all 359 golden-vector truncations incomplete. Fuzz replay frame cov 280/963 counters and stream cov 472/1347, no crash; fixed 3-byte chunks and absent semantic assertions miss the data-loss bug. Full Rust decode central 12.040 ns input / 11.668 ns 64B output, approximately 0.18% one-core CPU at 10 MB/s with 64B chunks, not an end-to-end latency result. Borrowed direct decode works over Bytes, but internal-Vec streaming callbacks cannot transfer retained payload ownership zero-copy to async tasks. Strict TS compilation separately passed; add it to fast gate.

Findings appended to /home/kayg/.local/state/codex-jobs/infraternal/review-protocol/findings.md. Repro/data/bench/fuzz/gate artifacts are under the lane worktree target/review-*. Tracked worktree remains clean. No code edits, commits, pushes or issue closure.

scripts/verify fast exited 0; complete output verbatim:


==> fmt

==> clippy
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.06s

==> test
    Finished `test` profile [unoptimized + debuginfo] target(s) in 0.06s
     Running unittests src/main.rs (target/debug/deps/infraternal-239f4951fa340219)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src/lib.rs (target/debug/deps/infraternal_agent-eadaa10b8c42bfd9)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src/lib.rs (target/debug/deps/infraternal_plugin_api-4480fd7032f11ca2)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src/lib.rs (target/debug/deps/infraternal_plugin_ssh-22a9a893799c7f17)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src/lib.rs (target/debug/deps/infraternal_protocol-6aec3e05ca065f96)

running 4 tests
test tests::rejects_oversized_noncanonical_and_malformed_frames_before_buffering_body ... ok
test tests::mux_round_trip_and_incremental_decoders_preserve_frame_order ... ok
test tests::oversized_encode_keeps_the_reusable_output_unchanged ... ok
test tests::golden_vectors_encode_and_decode_every_contract_frame ... ok

test result: ok. 4 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src/lib.rs (target/debug/deps/infraternal_server-3a7dcd467cd5ddf2)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src/lib.rs (target/debug/deps/infraternal_shim-2036f3f8f778c3eb)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests infraternal_agent

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests infraternal_plugin_api

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests infraternal_plugin_ssh

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests infraternal_protocol

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests infraternal_server

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests infraternal_shim

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s


==> cargo-deny
advisories ok, bans ok, licenses ok, sources ok

==> static builds
    Finished `release` profile [optimized] target(s) in 0.04s
target/x86_64-unknown-linux-musl/release/infraternal: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), static-pie linked, stripped
PT_INTERP: absent; size: 705624 bytes
    Finished `release` profile [optimized] target(s) in 0.04s
target/aarch64-unknown-linux-musl/release/infraternal: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), statically linked, stripped
PT_INTERP: absent; size: 607880 bytes
server subcommand: exit 2, not implemented
agent subcommand: exit 2, not implemented

+---------------------------+--------------+
| Rust gate                 | Result       |
+---------------------------+--------------+
| fmt                       | PASS         |
| clippy                    | PASS         |
| test                      | PASS         |
| cargo-deny                | PASS         |
| static builds             | PASS         |
+---------------------------+--------------+

==> TypeScript protocol tests
bun test v1.4.2 (744846f84)

src/codec.test.ts:
(pass) wire protocol golden vectors > encodes and decodes each frame exactly as the shared manifest describes [5.00ms]
(pass) wire protocol golden vectors > returns borrowed payload views and writes into reusable buffers [0.24ms]
(pass) wire protocol golden vectors > decodes muxed messages split across WebSocket messages [0.98ms]
(pass) wire protocol golden vectors > rejects oversized, non-canonical, unknown, and malformed frame bytes [0.20ms]

 4 pass
 0 fail
 63 expect() calls
Ran 4 tests across 1 file. [12.00ms]
Independent read-only review finished. Verdict: MERGE AFTER FIXES. Head: 407057272ce0e33c8b9e6dfed10a03c719887e77 Blockers: - P1: Rust MuxStreamDecoder (src/lib.rs:485-520) and TS WebSocketFrameDecoder (codec.ts:188-214) lose trailing frame bytes during incomplete-header refill. Two valid muxed Close frames, hex 00030f000000030f0000, fed as first byte then remainder, silently emit only one callback in BOTH runtimes with no error. Fix frame-boundary consumption and add exhaustive multi-frame split regressions and a stream-equivalence fuzz oracle. Both runtimes fail 2/769 golden-vector split cases. - P2: one commit 4070572 for the entire lane violates the explicit owner rule. Split by contract, dependencies, Rust/TS codec modules, incremental modules, vectors/tests, fuzzing, benches and gate integration. Full proposed split is in the findings report. No history rewritten by this review. Evidence: direct differential 24,504 generated cases plus 3,450 existing fuzz-corpus mode/case pairs, zero Rust/TS divergences; all 359 golden-vector truncations incomplete. Fuzz replay frame cov 280/963 counters and stream cov 472/1347, no crash; fixed 3-byte chunks and absent semantic assertions miss the data-loss bug. Full Rust decode central 12.040 ns input / 11.668 ns 64B output, approximately 0.18% one-core CPU at 10 MB/s with 64B chunks, not an end-to-end latency result. Borrowed direct decode works over Bytes, but internal-Vec streaming callbacks cannot transfer retained payload ownership zero-copy to async tasks. Strict TS compilation separately passed; add it to fast gate. Findings appended to /home/kayg/.local/state/codex-jobs/infraternal/review-protocol/findings.md. Repro/data/bench/fuzz/gate artifacts are under the lane worktree target/review-*. Tracked worktree remains clean. No code edits, commits, pushes or issue closure. scripts/verify fast exited 0; complete output verbatim: ``` ==> fmt ==> clippy Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.06s ==> test Finished `test` profile [unoptimized + debuginfo] target(s) in 0.06s Running unittests src/main.rs (target/debug/deps/infraternal-239f4951fa340219) running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Running unittests src/lib.rs (target/debug/deps/infraternal_agent-eadaa10b8c42bfd9) running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Running unittests src/lib.rs (target/debug/deps/infraternal_plugin_api-4480fd7032f11ca2) running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Running unittests src/lib.rs (target/debug/deps/infraternal_plugin_ssh-22a9a893799c7f17) running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Running unittests src/lib.rs (target/debug/deps/infraternal_protocol-6aec3e05ca065f96) running 4 tests test tests::rejects_oversized_noncanonical_and_malformed_frames_before_buffering_body ... ok test tests::mux_round_trip_and_incremental_decoders_preserve_frame_order ... ok test tests::oversized_encode_keeps_the_reusable_output_unchanged ... ok test tests::golden_vectors_encode_and_decode_every_contract_frame ... ok test result: ok. 4 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Running unittests src/lib.rs (target/debug/deps/infraternal_server-3a7dcd467cd5ddf2) running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Running unittests src/lib.rs (target/debug/deps/infraternal_shim-2036f3f8f778c3eb) running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Doc-tests infraternal_agent running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Doc-tests infraternal_plugin_api running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Doc-tests infraternal_plugin_ssh running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Doc-tests infraternal_protocol running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Doc-tests infraternal_server running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Doc-tests infraternal_shim running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s ==> cargo-deny advisories ok, bans ok, licenses ok, sources ok ==> static builds Finished `release` profile [optimized] target(s) in 0.04s target/x86_64-unknown-linux-musl/release/infraternal: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), static-pie linked, stripped PT_INTERP: absent; size: 705624 bytes Finished `release` profile [optimized] target(s) in 0.04s target/aarch64-unknown-linux-musl/release/infraternal: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), statically linked, stripped PT_INTERP: absent; size: 607880 bytes server subcommand: exit 2, not implemented agent subcommand: exit 2, not implemented +---------------------------+--------------+ | Rust gate | Result | +---------------------------+--------------+ | fmt | PASS | | clippy | PASS | | test | PASS | | cargo-deny | PASS | | static builds | PASS | +---------------------------+--------------+ ==> TypeScript protocol tests bun test v1.4.2 (744846f84) src/codec.test.ts: (pass) wire protocol golden vectors > encodes and decodes each frame exactly as the shared manifest describes [5.00ms] (pass) wire protocol golden vectors > returns borrowed payload views and writes into reusable buffers [0.24ms] (pass) wire protocol golden vectors > decodes muxed messages split across WebSocket messages [0.98ms] (pass) wire protocol golden vectors > rejects oversized, non-canonical, unknown, and malformed frame bytes [0.20ms] 4 pass 0 fail 63 expect() calls Ran 4 tests across 1 file. [12.00ms] ```
kayg commented 2026-10-06 11:31:25 +00:00
Author
Owner
Copy link

Starting independent-review fixes on lane-protocol, original head 407057272ce0e33c8b9e6dfed10a03c719887e77, base s1-base 386acfd3dc. Read CLAUDE.md, DECISIONS.md, docs/ARCHITECTURE.md and all findings. Will first demonstrate split-header data loss in both runtimes, add stream differential/oracle coverage, strengthen fuzzing, and tag/rewrite the lane as gated atomic steps. No push.

Starting independent-review fixes on lane-protocol, original head 407057272ce0e33c8b9e6dfed10a03c719887e77, base s1-base 386acfd3dc6255c7f58f98b4f114d5d7326292ad. Read CLAUDE.md, DECISIONS.md, docs/ARCHITECTURE.md and all findings. Will first demonstrate split-header data loss in both runtimes, add stream differential/oracle coverage, strengthen fuzzing, and tag/rewrite the lane as gated atomic steps. No push.
kayg commented 2026-10-06 11:34:11 +00:00
Author
Owner
Copy link

Confirmed P1 with failing tests before edits: target/regression-rust-before.log reports left 1/right 2 callbacks; target/regression-ts-before.log reports the missing second Close. Fixed both header refill paths to recheck length after each header byte, retaining the direct fast path. packages/protocol/src/stream.test.ts plus crates/infraternal-protocol/examples/stream_oracle.rs compare scalar fields, payloads, order, re-encoding and final buffered state: 134 streams, 11,439 identical schedules, zero divergences. Every boundary, empty chunks, all 1–5-byte mux widths, all 17 vectors, minimum Close/Credit and seeded random multi-splits included. Added deterministic 4 MiB/oversized tests; strengthening fuzz oracles before timed runs.

Confirmed P1 with failing tests before edits: target/regression-rust-before.log reports left 1/right 2 callbacks; target/regression-ts-before.log reports the missing second Close. Fixed both header refill paths to recheck length after each header byte, retaining the direct fast path. packages/protocol/src/stream.test.ts plus crates/infraternal-protocol/examples/stream_oracle.rs compare scalar fields, payloads, order, re-encoding and final buffered state: 134 streams, 11,439 identical schedules, zero divergences. Every boundary, empty chunks, all 1–5-byte mux widths, all 17 vectors, minimum Close/Credit and seeded random multi-splits included. Added deterministic 4 MiB/oversized tests; strengthening fuzz oracles before timed runs.
kayg commented 2026-10-06 11:38:45 +00:00
Author
Owner
Copy link

Review follow-ups: added strict TypeScript@5.9.3 compiler invocation to scripts/verify.d/ts.sh (Bun transpilation alone did not enforce decision 40). Documented incremental callback/copy/async retention limitations in both decoder APIs; borrowed direct decoders remain available for owning transport buffers. contracts/wire.md now gives redundant/overflow varint examples and requires consumer checked u64 exclusive sequence ends; Snapshot length does not advance out_seq. Connection integration must still enforce Hello ordering, stream ownership, direction/version/caps, JSON authorization, admission/reclamation and frozen upgrade layouts before implementation; this lane makes no auth or end-to-end budget claim. Benchmark evidence target/bench-before.log and target/bench-after.log: mux split_header id=0 central 66.419 -> 64.585 ns (overlapping intervals); id=u32::MAX 75.747 -> 108.05 ns (~32.3 ns for repeated header checks). Correctness justifies that bounded fragmented-path cost; direct full typed Output 12.294 -> 12.936 ns with overlapping intervals. Benchmarks ran locally alongside fuzzing, not on the pinned perf VM. Added mux/fragmentation cases to the Rust benchmark rather than weakening strict validation or refactoring enums without end-to-end evidence.

Review follow-ups: added strict TypeScript@5.9.3 compiler invocation to scripts/verify.d/ts.sh (Bun transpilation alone did not enforce decision 40). Documented incremental callback/copy/async retention limitations in both decoder APIs; borrowed direct decoders remain available for owning transport buffers. contracts/wire.md now gives redundant/overflow varint examples and requires consumer checked u64 exclusive sequence ends; Snapshot length does not advance out_seq. Connection integration must still enforce Hello ordering, stream ownership, direction/version/caps, JSON authorization, admission/reclamation and frozen upgrade layouts before implementation; this lane makes no auth or end-to-end budget claim. Benchmark evidence target/bench-before.log and target/bench-after.log: mux split_header id=0 central 66.419 -> 64.585 ns (overlapping intervals); id=u32::MAX 75.747 -> 108.05 ns (~32.3 ns for repeated header checks). Correctness justifies that bounded fragmented-path cost; direct full typed Output 12.294 -> 12.936 ns with overlapping intervals. Benchmarks ran locally alongside fuzzing, not on the pinned perf VM. Added mux/fragmentation cases to the Rust benchmark rather than weakening strict validation or refactoring enums without end-to-end evidence.
kayg commented 2026-10-06 11:44:55 +00:00
Author
Owner
Copy link

Implementation complete on lane-protocol, head 6ac06c7f75; base s1-base 386acfd3dc. Original reviewed head preserved as lane-protocol-v1 (407057272ce0e33c8b9e6dfed10a03c719887e77). No push/deploy; issue remains open.

Review disposition:

  • P1 data loss fixed in Rust and TypeScript. Failing-first logs: target/regression-rust-before.log and target/regression-ts-before.log. Header refill reads one byte before rechecking the validated length; subsequent envelopes remain in the input. Rust regression module: crates/infraternal-protocol/src/stream_tests.rs.
  • Durable cross-runtime oracle: packages/protocol/src/stream.test.ts and crates/infraternal-protocol/examples/stream_oracle.rs. 134 streams / 11,439 identical chunk schedules / zero divergences. Includes every two-chunk boundary, empty chunks, all mux-id widths, 17 golden types, minimum Close/Credit, multiple trailing frames and seeded random multi-splits. Each decoder also matches direct decoded scalar fields, payloads, order, exact re-encoding and zero final retained bytes, preventing shared-bug parity from passing. Rust and TS deterministic tests cover full 4 MiB frames; oversized prefixes are rejected before body buffering.
  • P2 repaired by reconstructing 11 atomic steps on s1-base; every commit passed nix shell nixpkgs#binutils nixpkgs#file -c scripts/verify fast on its own tree. Logs target/atomic-gate-01.log through target/atomic-gate-11.log. Before TS integration, relevant TS steps additionally ran compiler/tests. Every commit body records choice/rejected alternatives/decisions and ends Refs: #15.
  • Fuzz quality strengthened: raw+direct mux round trips; selected chunk sizes including tiny and large refills and empty feeds; generated valid concatenations; stream/direct callback, terminal-error and incomplete-byte oracles. fuzz/seed.py reproducibly seeds all types and mux widths; fuzz/README.md records commands and oracle limits.
  • Compiler should-fix resolved: scripts/verify.d/ts.sh invokes pinned TypeScript 5.9.3 strict checking before Bun tests.
  • Ownership should-fix resolved: both incremental API docs disclose copies and callback-only payload lifetime. Owning Bytes/BytesMut adapters and scatter/gather encoding remain integration work; borrowed direct APIs already work without adding a bytes dependency.
  • Varint examples added in contracts/wire.md. Checked u64 exclusive ends and Snapshot non-advancement are now explicit consumer invariants; codec performs no sequence addition. Connection integration must test these along with Hello order/control stream, version/direction/caps, mux ownership, JSON schema/auth and admission/reclamation. Upgrade byte layouts/cap assignments must be specified before those frames are implemented; the current codec intentionally rejects unknown types. These are integration follow-ups, not claims of codec/session authorization or completed upgrade support.
  • Performance: target/bench-before.log / target/bench-after.log. Split-header id=0 central 66.419 -> 64.585 ns (overlapping intervals), u32::MAX 75.747 -> 108.05 ns (bounded ~32.3 ns for repeated header checks, required to prevent silent loss). Direct full typed Output central 12.294 -> 12.936 ns with overlapping intervals. Strict validation retained; no speculative enum refactor. Bun direct decode medians: Input 252.1 ns, Output 285.5 ns (target/bench-ts-fixed.log). Measurements ran locally alongside fuzzing, not on the pinned perf VM; they do not establish keystroke p99/end-to-end decisions 12/41. No UI/browser screenshot gate applies to this codec-only change.

Atomic commits:

4a616df clarify canonical varints and session sequence bounds #15
2bded22 add codec test and benchmark dependencies #15
df190dd implement borrowed Rust frames and direct mux codec #15
f09ee3e decode fragmented Rust frames without swallowing mux successors #15
91c4007 share golden wire vectors and verify Rust frame layouts #15
b2e3842 implement strict TypeScript direct wire codec and vector tests #15
947404e preserve TypeScript mux boundaries and compare both stream codecs #15
d548d33 fuzz raw and mux round trips with chunk-equivalence oracles #15
dbc98e0 benchmark typed decoding and fragmented mux reception #15
6d240ca add browser codec latency benchmark entry point #15
6ac06c7 enforce strict TypeScript compilation and codec parity in fast gate #15

Final-tree fast gate (exit 0), verbatim:


==> fmt

==> clippy
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.10s

==> test
    Finished `test` profile [unoptimized + debuginfo] target(s) in 0.07s
     Running unittests src/main.rs (target/debug/deps/infraternal-239f4951fa340219)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src/lib.rs (target/debug/deps/infraternal_agent-eadaa10b8c42bfd9)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src/lib.rs (target/debug/deps/infraternal_plugin_api-4480fd7032f11ca2)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src/lib.rs (target/debug/deps/infraternal_plugin_ssh-22a9a893799c7f17)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src/lib.rs (target/debug/deps/infraternal_protocol-6aec3e05ca065f96)

running 7 tests
test stream_tests::split_mux_header_preserves_trailing_close ... ok
test tests::mux_round_trip_and_incremental_decoders_preserve_frame_order ... ok
test tests::rejects_oversized_noncanonical_and_malformed_frames_before_buffering_body ... ok
test tests::oversized_encode_keeps_the_reusable_output_unchanged ... ok
test stream_tests::all_short_frame_splits_match_direct_decoding ... ok
test tests::golden_vectors_encode_and_decode_every_contract_frame ... ok
test stream_tests::maximum_sized_fragmented_frame_is_not_rejected ... ok

test result: ok. 7 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src/lib.rs (target/debug/deps/infraternal_server-3a7dcd467cd5ddf2)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src/lib.rs (target/debug/deps/infraternal_shim-2036f3f8f778c3eb)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests infraternal_agent

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests infraternal_plugin_api

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests infraternal_plugin_ssh

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests infraternal_protocol

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests infraternal_server

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests infraternal_shim

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s


==> cargo-deny
advisories ok, bans ok, licenses ok, sources ok

==> static builds
    Finished `release` profile [optimized] target(s) in 0.04s
target/x86_64-unknown-linux-musl/release/infraternal: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), static-pie linked, stripped
PT_INTERP: absent; size: 705624 bytes
    Finished `release` profile [optimized] target(s) in 0.04s
target/aarch64-unknown-linux-musl/release/infraternal: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), statically linked, stripped
PT_INTERP: absent; size: 607880 bytes
server subcommand: exit 2, not implemented
agent subcommand: exit 2, not implemented

+---------------------------+--------------+
| Rust gate                 | Result       |
+---------------------------+--------------+
| fmt                       | PASS         |
| clippy                    | PASS         |
| test                      | PASS         |
| cargo-deny                | PASS         |
| static builds             | PASS         |
+---------------------------+--------------+

==> TypeScript protocol compiler

==> TypeScript protocol tests
bun test v1.4.2 (744846f84)

src/codec.test.ts:
(pass) wire protocol golden vectors > encodes and decodes each frame exactly as the shared manifest describes [5.69ms]
(pass) wire protocol golden vectors > returns borrowed payload views and writes into reusable buffers [0.26ms]
(pass) wire protocol golden vectors > decodes muxed messages split across WebSocket messages [1.10ms]
(pass) wire protocol golden vectors > rejects oversized, non-canonical, unknown, and malformed frame bytes [0.32ms]
(pass) split mux header preserves trailing Close [0.21ms]

src/stream.test.ts:
stream differential: 134 streams, 11439 schedules, zero divergences
(pass) Rust and TypeScript preserve every frame at all boundaries and random multi-splits [2236.77ms]
(pass) maximum frame size and fragmented oversized prefix obey the allocation boundary [6.78ms]

 7 pass
 0 fail
 34390 expect() calls
Ran 7 tests across 2 files. [2.26s]

Timed post-fix fuzz results (both exit 0, max_len=65536):

  • wire_frame_decode: 159,503,182 executions in 601 seconds, zero crashes or oracle failures, cov 649, ft 876. Log: target/fuzz-frame-fixed.log.
  • wire_stream_decode: 1,933,060 executions in 601 seconds, zero crashes or oracle failures, cov 912, ft 4107. Log: target/fuzz-stream-fixed.log.
    These are libFuzzer edge/feature counts, not source-coverage percentages. Summary: target/fuzz-fixed-summary.json. Worktree clean at final head; generated corpora/artifacts are ignored. All review findings answered above; no issue closure.
Implementation complete on lane-protocol, head 6ac06c7f75713feb2c5ce0f26e32712c9bf64b0e; base s1-base 386acfd3dc6255c7f58f98b4f114d5d7326292ad. Original reviewed head preserved as lane-protocol-v1 (407057272ce0e33c8b9e6dfed10a03c719887e77). No push/deploy; issue remains open. Review disposition: - P1 data loss fixed in Rust and TypeScript. Failing-first logs: target/regression-rust-before.log and target/regression-ts-before.log. Header refill reads one byte before rechecking the validated length; subsequent envelopes remain in the input. Rust regression module: crates/infraternal-protocol/src/stream_tests.rs. - Durable cross-runtime oracle: packages/protocol/src/stream.test.ts and crates/infraternal-protocol/examples/stream_oracle.rs. 134 streams / 11,439 identical chunk schedules / zero divergences. Includes every two-chunk boundary, empty chunks, all mux-id widths, 17 golden types, minimum Close/Credit, multiple trailing frames and seeded random multi-splits. Each decoder also matches direct decoded scalar fields, payloads, order, exact re-encoding and zero final retained bytes, preventing shared-bug parity from passing. Rust and TS deterministic tests cover full 4 MiB frames; oversized prefixes are rejected before body buffering. - P2 repaired by reconstructing 11 atomic steps on s1-base; every commit passed `nix shell nixpkgs#binutils nixpkgs#file -c scripts/verify fast` on its own tree. Logs target/atomic-gate-01.log through target/atomic-gate-11.log. Before TS integration, relevant TS steps additionally ran compiler/tests. Every commit body records choice/rejected alternatives/decisions and ends Refs: #15. - Fuzz quality strengthened: raw+direct mux round trips; selected chunk sizes including tiny and large refills and empty feeds; generated valid concatenations; stream/direct callback, terminal-error and incomplete-byte oracles. fuzz/seed.py reproducibly seeds all types and mux widths; fuzz/README.md records commands and oracle limits. - Compiler should-fix resolved: scripts/verify.d/ts.sh invokes pinned TypeScript 5.9.3 strict checking before Bun tests. - Ownership should-fix resolved: both incremental API docs disclose copies and callback-only payload lifetime. Owning Bytes/BytesMut adapters and scatter/gather encoding remain integration work; borrowed direct APIs already work without adding a bytes dependency. - Varint examples added in contracts/wire.md. Checked u64 exclusive ends and Snapshot non-advancement are now explicit consumer invariants; codec performs no sequence addition. Connection integration must test these along with Hello order/control stream, version/direction/caps, mux ownership, JSON schema/auth and admission/reclamation. Upgrade byte layouts/cap assignments must be specified before those frames are implemented; the current codec intentionally rejects unknown types. These are integration follow-ups, not claims of codec/session authorization or completed upgrade support. - Performance: target/bench-before.log / target/bench-after.log. Split-header id=0 central 66.419 -> 64.585 ns (overlapping intervals), u32::MAX 75.747 -> 108.05 ns (bounded ~32.3 ns for repeated header checks, required to prevent silent loss). Direct full typed Output central 12.294 -> 12.936 ns with overlapping intervals. Strict validation retained; no speculative enum refactor. Bun direct decode medians: Input 252.1 ns, Output 285.5 ns (target/bench-ts-fixed.log). Measurements ran locally alongside fuzzing, not on the pinned perf VM; they do not establish keystroke p99/end-to-end decisions 12/41. No UI/browser screenshot gate applies to this codec-only change. Atomic commits: ``` 4a616df clarify canonical varints and session sequence bounds #15 2bded22 add codec test and benchmark dependencies #15 df190dd implement borrowed Rust frames and direct mux codec #15 f09ee3e decode fragmented Rust frames without swallowing mux successors #15 91c4007 share golden wire vectors and verify Rust frame layouts #15 b2e3842 implement strict TypeScript direct wire codec and vector tests #15 947404e preserve TypeScript mux boundaries and compare both stream codecs #15 d548d33 fuzz raw and mux round trips with chunk-equivalence oracles #15 dbc98e0 benchmark typed decoding and fragmented mux reception #15 6d240ca add browser codec latency benchmark entry point #15 6ac06c7 enforce strict TypeScript compilation and codec parity in fast gate #15 ``` Final-tree fast gate (exit 0), verbatim: ```text ==> fmt ==> clippy Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.10s ==> test Finished `test` profile [unoptimized + debuginfo] target(s) in 0.07s Running unittests src/main.rs (target/debug/deps/infraternal-239f4951fa340219) running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Running unittests src/lib.rs (target/debug/deps/infraternal_agent-eadaa10b8c42bfd9) running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Running unittests src/lib.rs (target/debug/deps/infraternal_plugin_api-4480fd7032f11ca2) running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Running unittests src/lib.rs (target/debug/deps/infraternal_plugin_ssh-22a9a893799c7f17) running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Running unittests src/lib.rs (target/debug/deps/infraternal_protocol-6aec3e05ca065f96) running 7 tests test stream_tests::split_mux_header_preserves_trailing_close ... ok test tests::mux_round_trip_and_incremental_decoders_preserve_frame_order ... ok test tests::rejects_oversized_noncanonical_and_malformed_frames_before_buffering_body ... ok test tests::oversized_encode_keeps_the_reusable_output_unchanged ... ok test stream_tests::all_short_frame_splits_match_direct_decoding ... ok test tests::golden_vectors_encode_and_decode_every_contract_frame ... ok test stream_tests::maximum_sized_fragmented_frame_is_not_rejected ... ok test result: ok. 7 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Running unittests src/lib.rs (target/debug/deps/infraternal_server-3a7dcd467cd5ddf2) running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Running unittests src/lib.rs (target/debug/deps/infraternal_shim-2036f3f8f778c3eb) running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Doc-tests infraternal_agent running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Doc-tests infraternal_plugin_api running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Doc-tests infraternal_plugin_ssh running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Doc-tests infraternal_protocol running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Doc-tests infraternal_server running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Doc-tests infraternal_shim running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s ==> cargo-deny advisories ok, bans ok, licenses ok, sources ok ==> static builds Finished `release` profile [optimized] target(s) in 0.04s target/x86_64-unknown-linux-musl/release/infraternal: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), static-pie linked, stripped PT_INTERP: absent; size: 705624 bytes Finished `release` profile [optimized] target(s) in 0.04s target/aarch64-unknown-linux-musl/release/infraternal: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), statically linked, stripped PT_INTERP: absent; size: 607880 bytes server subcommand: exit 2, not implemented agent subcommand: exit 2, not implemented +---------------------------+--------------+ | Rust gate | Result | +---------------------------+--------------+ | fmt | PASS | | clippy | PASS | | test | PASS | | cargo-deny | PASS | | static builds | PASS | +---------------------------+--------------+ ==> TypeScript protocol compiler ==> TypeScript protocol tests bun test v1.4.2 (744846f84) src/codec.test.ts: (pass) wire protocol golden vectors > encodes and decodes each frame exactly as the shared manifest describes [5.69ms] (pass) wire protocol golden vectors > returns borrowed payload views and writes into reusable buffers [0.26ms] (pass) wire protocol golden vectors > decodes muxed messages split across WebSocket messages [1.10ms] (pass) wire protocol golden vectors > rejects oversized, non-canonical, unknown, and malformed frame bytes [0.32ms] (pass) split mux header preserves trailing Close [0.21ms] src/stream.test.ts: stream differential: 134 streams, 11439 schedules, zero divergences (pass) Rust and TypeScript preserve every frame at all boundaries and random multi-splits [2236.77ms] (pass) maximum frame size and fragmented oversized prefix obey the allocation boundary [6.78ms] 7 pass 0 fail 34390 expect() calls Ran 7 tests across 2 files. [2.26s] ``` Timed post-fix fuzz results (both exit 0, max_len=65536): - wire_frame_decode: 159,503,182 executions in 601 seconds, zero crashes or oracle failures, cov 649, ft 876. Log: target/fuzz-frame-fixed.log. - wire_stream_decode: 1,933,060 executions in 601 seconds, zero crashes or oracle failures, cov 912, ft 4107. Log: target/fuzz-stream-fixed.log. These are libFuzzer edge/feature counts, not source-coverage percentages. Summary: target/fuzz-fixed-summary.json. Worktree clean at final head; generated corpora/artifacts are ignored. All review findings answered above; no issue closure.
kayg commented 2026-10-06 11:48:00 +00:00
Author
Owner
Copy link

Merged into dev as 7174d6b. Gate on the merge result: all PASS, TS 7/7.

Merged into `dev` as `7174d6b`. Gate on the merge result: all PASS, TS 7/7.
kayg commented 2026-10-28 17:52:08 +00:00
Author
Owner
Copy link

Closed by the orchestrator during the 2026-10-28 handover (#254), on the owner's request to close finished issues. Evidence: Codec lane merged to dev as 7174d6b (verified ancestor of dev); P1 split-header finding fixed and fuzz clean. Reopen if anything is still missing.

Closed by the orchestrator during the 2026-10-28 handover (#254), on the owner's request to close finished issues. Evidence: Codec lane merged to dev as 7174d6b (verified ancestor of dev); P1 split-header finding fixed and fuzz clean. Reopen if anything is still missing.
kayg closed this issue 2026-10-28 17:52:08 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
j470b-server-mesh-rejoin
mesh-compat-382
j444b-d381-key-wins-flood
j461b-macos-utun-reader-thread
j475b-remove-host-motion
fix-reconnect-new-link
j481-d380
dev
j479-mesh-soak
fix/j476-host-facts
j475-motion-pill-split
j470-mac-node-join
root-upgrade-d376
j474-review-merge
latency-targets-120hz
nightly-suite-shards
gotatun-pin-j469
macos-utun-reader-thread
fix-flood-echo-stall
wip/j416
motion-fast-ease-out
mesh-addhost-j259
takeover-close-terminals-d368
kbd-instant-followups
fix-trust-key-double-click
nightly-suite-partial-report
appwin-icons-j207
rusqlite-slice1
swipe-content-first-d374
mesh-mtu-381
addhost-instant-open
glass-contrast-d365-mock
glass-contrast-d365
signout-followups-442
fix-startup-toast-red
research-gotatun-matrix-j317
themes-sync-j304
fix-load-flakes
fix-nix-zig-patch
fix-compute01-browser-baseline
ratchet-size-baseline-419
predict-auto-d130
revoke-coverage-d367
nightly-suite-queue-timeout
nightly-browser-suite
fix-rustsec-2026-0459
fonts-ioskeley-obel
log-retention-d375
fix-kbd-no-anim-427
fix-dev-red-specs-2
takeover-proof-305-j205
wip/j410-server-pump
ui-consistency-d372
fix-osc52-clipboard
libghostty-vt-1.0
forget-retired-host-d369
j404-merge-426
fix-setup-lock-race
fix-touch-select-426
revoke-access-report-ui
fix-predictive-echo-specs
fix-selinux-agent-exec
wip/j395-checkpoint2
wip/j395
j391-review-scratch
ui-consistency-j195-deferred-rebased
fix-rustc-paths-421
decisions-wording-341
fix-install-suite-red
fix-dev-rtt-specs
fix-pending-removal-align
fix-privileged-skip
fix-install-suite-404
review-j368
mesh-dns-j254
revoke-access-report-d356b
revoke-privilege-round5
fix-removal-confirm
review-j360
gotatun-rotation-367
deps-refresh-340
review-j354
review-J351
review-j350
addhost-takeover-d359
revoke-report-items-347
revoke-end-sessions-d362
review-j348
size-mesh-ssh-346
size-trim-337
revoke-access-diff-d356
j259-pre-rebase-b06c5a6
j305-ended-at-start-spec
addhost-sudo-consent
fix-layout-real-specs-411
fix-shell-open-411
fix-console-hosts-373
fix-shell-exit
fuzz-host-name-353
fix-host-details-410
macos-filter-j197
research-gotatun-tricks
revoke-p3-j216l
stale-state-pill
revoke-followups-j216k
revoke-progress-j216e
backup/macos01-20261106/lume/j197
backup/macos01-20261106/lume/appwin-icons-j207-stash0
backup/macos01-20261106/claude/stash-0
backup/macos01-20261106/claude/stash-1
backup/macos01-20261106/claude/J80-macos-s1
backup/macos01-20261106/claude/J80
backup/macos01-20261106/claude/J80-slice1-20261102
backup/macos01-20261106/claude/J16b-appwin-on-dev
backup/macos01-20261106/claude/appwin-launch-idle-146
backup/macos01-20261106/claude/J80-s1-run
wip/j259
trust-285-p3c
runtime-lock-j216f
mesh-ssh-p3-j175
tun-proof-p3b
trust-285-p3
terminal-polish-j271
tun-proof-p3
ssh-install-flakes-j216i
fuzz-fixes-j264
trust-285-a
trust-285-b
restart-oversized-fixture-j198
backup/macos01-20261106/lume/appwin-icons-j207
restart-bound-j216h
up-preflight-p3-j198
backup/macos01-20261106/lume/j251
up-preflight-j198
wip/up-preflight-j198-j245-p2
wip/up-preflight-j198-j245-p1
agent-fsync-offloop-j196
wip/up-preflight-j198-j245
settings-offscreen-j231
wip/up-preflight-j198-j226-inspection
wip/j103f
themes-j206
wip/up-preflight-j198-j226
flakes-j216c
backup/macos01-20261106/claude/j197
flakes-j216b
backup/macos01-20261106/claude/j197-red
wip/up-preflight-j198-review
flakes-j216
backup/macos01-20261106/claude/appwin-icons-j207
engineering-j208b
appwin-mock-j209
toast-stack-j165
engineering-j208
decisions-d351
decisions-d350
decisions-d349
appearance-presets-mock-j129
decisions-d348
docs-audit-spec
doc-coverage-baseline-raise
decisions-d347
decisions-d346b
decisions-d346
j88h-profile
ui-consistency-j195-deferred
ui-consistency-j195
engineering-practices-j194
preferred-login-ui-j166
signin-pools-263-j174
macos-node-265-s1
decisions-d345
decisions-d344
proxy-cgroup-j164
verify-quick-fuzz-329
proxy-start-io-j168
timing-flakes-j163
up-263-s1
mcp-events-j147
verify-quick-fuzz-j158
proxy-p3-j159
agent-resource-j157-detect
wip/j103d-final
remote-cancel-hang-j155
proxy-traefik-281-j62d
j149-verify-quick
proxy-traefik-281-j62b
j150-drop-unnamed
wip/j79d-red-r4
wip/j103d-d332
rootless-toast-j142
wip/j103d-head
wip/j103d
j125c-mcp
macos-build-j136
backup/macos01-20261106/claude/j136
wip/j79d-red-cli
wip/j79d-red-server
j121-link-liveness
j118c-tracer-failures
wip/j79c-head
release-desktop-j131
j124c-signed-macos
wip/j79c-red-p3
wip/j79c-red-p23
wip/j79c-red-p22
merge-j128-check
perf-deferred-j128
sidebar-toggle-260
j127-shortcut-changed-dot
j125-mcp
j118-tracer-failures
j126-account-summary
settings-sections-mock-j92
j120-pinch-lock
sidebar-292
backup/macos01-20261106/claude/j120
taste-2026-11-03
row-actions-242-215
backup/macos01-20261106/claude/stash-0-untracked
backup/macos01-20261106/claude/J80-265-s1-run
backup/macos01-20261106/claude/J80-macos-s1-20261102
j112-canvas-commands
ui-no-overshoot-scroll
fix-recovery-restart
backup/macos01-20261106/claude/stash-1-untracked
taste-2026-11-02
size-baseline-ratchet
machine-cards-structure-j108
j109-boot-copy-mockups
fix-dev-red
wip/up-263-s1
j95b-settings-rows
proxy-traefik-281
j95-option-rows
docs-human-j91
docs-keys-palette
fix-flood-1013-270-j38d
mesh-ssh-s1
mesh-ssh-s0
addhost-d291-tunnel
test-stability-load
mesh-relay-220
repro-296
shim-thp-off-24
mesh-pins-258-v2
mesh-dns
signin-d311-merged
docs-pages
ui-size-283
fix-ui-batch-specs
wip/j12b-edge-update
gate-on-arm
fix-rename-sync-293
trust-285-j60b
fix-focus-ring-clip
integ-ui-1101
edge-update-v2
signin-d311
taste-2026-11-01
layout-per-tab-250
ui-approved-splitopt-224
ui-approved-splitopt-224-on-dev
icon-text-centre-282
ui-approved-189-212-216
research-reverse-proxy
transfer-budget-320
review-mesh-pins-258-r2
sidebar-pill-259
review-mesh-relay-220
wip/j12-edge-update-v2
nix-package
status-crash-loop-237
fix-dev-test-failures
fix-fixture-socket-path
wip/mesh-relay-220-pre-dev-advance-rebase
fix-canvas-side-clip
research-head-to-head
frosted-real-256
review-mesh-pins-258
wip/mesh-relay-220-pre-final-rebase
review-layout-per-tab-250-r2
broad-suite-triage
nix-devshell
review-status-crash-loop-237-r3
wip/nix-devshell-pre-p3
taste-frosted-real
wip/code-serve-demo-2026-10-30
wip/code-serve-glass-2026-10-30
wip/code-serve-clusters-2026-10-30
wip/code-merge-release94-dev-2026-10-30
wip/rproxy-delta-scratch-2026-10-30
wip/stale-note-257-staged-2026-10-30
wip/d241-size-staged-2026-10-30
review-broad-suite-207
wip/mesh-pins-258-pre-split
wip/mesh-relay-220-pre-rebase
mesh-measure-220
plan-211-update
review-edge-autoupdate-r3
perf24-reconnect
review-stale-note-r2
release-prod-live
d241-shell-marker
review-mesh-pins-server-258
review-revocation-r3
review-setup-token-r2
review-sync-journal-r3
wip/review-mesh-pins-258-prune-review-1995fee46
frosted-scroll-256
sync-journal-r3
revocation-per-account-wip
review-tokio-asyncfd-0386
review-sync-p3s
wip/stash-8by64-stash0-2026-10-30
mesh-drag-r2
setup-token-data-wip
release-9-4
auth-busy-1013
mesh-view-overlap
sync-p3s
review-auth-busy-wake
review-readd-r8-wip
mesh-drag-bounds
audit-auth-93
app-windows-stream-start
review-authority-cap-r3
app-windows-r7-measure
readd-minimal-r6
readd-minimal-r5
app-windows-r7-soak
readd-minimal-r4
app-windows-r7
app-windows-r6
readd-minimal-r3
readd-minimal-r2
readd-minimal
merge-release8-dev
review-busy-page-liveness-r2
review-busy-page-liveness
mesh-view-trim
review-authority-read-retry-r2
review-remove-uninstall-r2
release-retry-reattach
release-retry
review-remove-uninstall
review-authority-read-retry
app-windows-ship
mesh-autoswitch-p2
mesh-ssh
mesh-relay
mesh-macos-node
screen-and-control
session-labels
review-real-logins-r5
review-real-logins-r4
review-real-logins-r3
shim-memory-r2
review-real-logins-r2
shim-memory
shadow-addhost-instant
shadow-real-logins
shadow-same-session-flood
shadow-prod-perf-fix
hosts-from-server
app-windows-real
app-windows-transport
release-prod-6w
mesh-policy-verify
quiet-close-toast
dev-merge-r4
review-mesh-agent-transport
review-app-windows-transport
settings-roundtrip
review-release-pipeline-r4
mesh-agent-transport
ended-strip-fix
review-audit-ca-update-d244
settings-rows
phone-width
signout-clear
fix-restart-tests
dev-merge-rp
signer-hardening
review-audit-ca-update
terminal-fidelity
review-audit-ca-update-wip
mesh-integrate
review-mesh-agent-transport-515d3712
review-mesh-dataplane-feec1988
mesh-dataplane
signout
research-canvas-node
wip/review-renderer-cost
wip/review-terminal-fidelity
padlock-glyph
review-release-pipeline-2e95b689
phone-polish
sidebar-polish
inbox-generic
review-mesh-dataplane-378d4055
prod-batch
ui-inbox
ui-ca-unlock
ui-machine-sections
review-mesh-dataplane-a5f744fb
tls-session-prod
session-bounds-prod
fix-dead-session
session-bounds
tls-session
palette-polish
shortcuts-d222
research-appmeta
phone-gutter
ui-centre-button
wip/ui-centre-button
wip/tls-session
review-addhost-breakit
ui-platform
renderer-cost
remote-agents
mesh-api
ssh-bootstrap
prod-hotfix2
prod-fixes
review-remote-agents
review-mesh-dataplane
session-life
research-browser
review-mesh-api
research-capture
review-mesh-api-round3
review-mesh-api-round1
gate-stability
review-gate-stability
review-relay-direct
review-mesh-api-findings
proto-sessions
font-picker
proto-addhost
proto-windows
mesh-core
latency-gate
research-bsd
research-discovery
keytray-mods
mock-core
ui-tweaks
fix-motion-sel
fix-motion
integrate2
fix-robust
t-web
t-server
vt-ghostty
fix-snap-echo
t-web-auth
review-vt2
t-agent
lane-protocol
lane-shim
lane-auth
s1-base
s1-contracts
s1-workspace
No results found.
Labels
Clear labels   
launch-qa
Findings from launch QA.

No labels
launch-qa
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kayg/infraternal#15
No description provided.