D236 session labels: infraternal agent reports foreground program and folder #178
Open
opened 2026-10-12 04:21:55 +00:00 by kayg
·
83 comments
No Branch/Tag specified
main
j470b-server-mesh-rejoin
mesh-compat-382
j444b-d381-key-wins-flood
j461b-macos-utun-reader-thread
j475b-remove-host-motion
fix-reconnect-new-link
j481-d380
dev
j479-mesh-soak
fix/j476-host-facts
j475-motion-pill-split
j470-mac-node-join
root-upgrade-d376
j474-review-merge
latency-targets-120hz
nightly-suite-shards
gotatun-pin-j469
macos-utun-reader-thread
fix-flood-echo-stall
wip/j416
motion-fast-ease-out
mesh-addhost-j259
takeover-close-terminals-d368
kbd-instant-followups
fix-trust-key-double-click
nightly-suite-partial-report
appwin-icons-j207
rusqlite-slice1
swipe-content-first-d374
mesh-mtu-381
addhost-instant-open
glass-contrast-d365-mock
glass-contrast-d365
signout-followups-442
fix-startup-toast-red
research-gotatun-matrix-j317
themes-sync-j304
fix-load-flakes
fix-nix-zig-patch
fix-compute01-browser-baseline
ratchet-size-baseline-419
predict-auto-d130
revoke-coverage-d367
nightly-suite-queue-timeout
nightly-browser-suite
fix-rustsec-2026-0459
fonts-ioskeley-obel
log-retention-d375
fix-kbd-no-anim-427
fix-dev-red-specs-2
takeover-proof-305-j205
wip/j410-server-pump
ui-consistency-d372
fix-osc52-clipboard
libghostty-vt-1.0
forget-retired-host-d369
j404-merge-426
fix-setup-lock-race
fix-touch-select-426
revoke-access-report-ui
fix-predictive-echo-specs
fix-selinux-agent-exec
wip/j395-checkpoint2
wip/j395
j391-review-scratch
ui-consistency-j195-deferred-rebased
fix-rustc-paths-421
decisions-wording-341
fix-install-suite-red
fix-dev-rtt-specs
fix-pending-removal-align
fix-privileged-skip
fix-install-suite-404
review-j368
mesh-dns-j254
revoke-access-report-d356b
revoke-privilege-round5
fix-removal-confirm
review-j360
gotatun-rotation-367
deps-refresh-340
review-j354
review-J351
review-j350
addhost-takeover-d359
revoke-report-items-347
revoke-end-sessions-d362
review-j348
size-mesh-ssh-346
size-trim-337
revoke-access-diff-d356
j259-pre-rebase-b06c5a6
j305-ended-at-start-spec
addhost-sudo-consent
fix-layout-real-specs-411
fix-shell-open-411
fix-console-hosts-373
fix-shell-exit
fuzz-host-name-353
fix-host-details-410
macos-filter-j197
research-gotatun-tricks
revoke-p3-j216l
stale-state-pill
revoke-followups-j216k
revoke-progress-j216e
backup/macos01-20261106/lume/j197
backup/macos01-20261106/lume/appwin-icons-j207-stash0
backup/macos01-20261106/claude/stash-0
backup/macos01-20261106/claude/stash-1
backup/macos01-20261106/claude/J80-macos-s1
backup/macos01-20261106/claude/J80
backup/macos01-20261106/claude/J80-slice1-20261102
backup/macos01-20261106/claude/J16b-appwin-on-dev
backup/macos01-20261106/claude/appwin-launch-idle-146
backup/macos01-20261106/claude/J80-s1-run
wip/j259
trust-285-p3c
runtime-lock-j216f
mesh-ssh-p3-j175
tun-proof-p3b
trust-285-p3
terminal-polish-j271
tun-proof-p3
ssh-install-flakes-j216i
fuzz-fixes-j264
trust-285-a
trust-285-b
restart-oversized-fixture-j198
backup/macos01-20261106/lume/appwin-icons-j207
restart-bound-j216h
up-preflight-p3-j198
backup/macos01-20261106/lume/j251
up-preflight-j198
wip/up-preflight-j198-j245-p2
wip/up-preflight-j198-j245-p1
agent-fsync-offloop-j196
wip/up-preflight-j198-j245
settings-offscreen-j231
wip/up-preflight-j198-j226-inspection
wip/j103f
themes-j206
wip/up-preflight-j198-j226
flakes-j216c
backup/macos01-20261106/claude/j197
flakes-j216b
backup/macos01-20261106/claude/j197-red
wip/up-preflight-j198-review
flakes-j216
backup/macos01-20261106/claude/appwin-icons-j207
engineering-j208b
appwin-mock-j209
toast-stack-j165
engineering-j208
decisions-d351
decisions-d350
decisions-d349
appearance-presets-mock-j129
decisions-d348
docs-audit-spec
doc-coverage-baseline-raise
decisions-d347
decisions-d346b
decisions-d346
j88h-profile
ui-consistency-j195-deferred
ui-consistency-j195
engineering-practices-j194
preferred-login-ui-j166
signin-pools-263-j174
macos-node-265-s1
decisions-d345
decisions-d344
proxy-cgroup-j164
verify-quick-fuzz-329
proxy-start-io-j168
timing-flakes-j163
up-263-s1
mcp-events-j147
verify-quick-fuzz-j158
proxy-p3-j159
agent-resource-j157-detect
wip/j103d-final
remote-cancel-hang-j155
proxy-traefik-281-j62d
j149-verify-quick
proxy-traefik-281-j62b
j150-drop-unnamed
wip/j79d-red-r4
wip/j103d-d332
rootless-toast-j142
wip/j103d-head
wip/j103d
j125c-mcp
macos-build-j136
backup/macos01-20261106/claude/j136
wip/j79d-red-cli
wip/j79d-red-server
j121-link-liveness
j118c-tracer-failures
wip/j79c-head
release-desktop-j131
j124c-signed-macos
wip/j79c-red-p3
wip/j79c-red-p23
wip/j79c-red-p22
merge-j128-check
perf-deferred-j128
sidebar-toggle-260
j127-shortcut-changed-dot
j125-mcp
j118-tracer-failures
j126-account-summary
settings-sections-mock-j92
j120-pinch-lock
sidebar-292
backup/macos01-20261106/claude/j120
taste-2026-11-03
row-actions-242-215
backup/macos01-20261106/claude/stash-0-untracked
backup/macos01-20261106/claude/J80-265-s1-run
backup/macos01-20261106/claude/J80-macos-s1-20261102
j112-canvas-commands
ui-no-overshoot-scroll
fix-recovery-restart
backup/macos01-20261106/claude/stash-1-untracked
taste-2026-11-02
size-baseline-ratchet
machine-cards-structure-j108
j109-boot-copy-mockups
fix-dev-red
wip/up-263-s1
j95b-settings-rows
proxy-traefik-281
j95-option-rows
docs-human-j91
docs-keys-palette
fix-flood-1013-270-j38d
mesh-ssh-s1
mesh-ssh-s0
addhost-d291-tunnel
test-stability-load
mesh-relay-220
repro-296
shim-thp-off-24
mesh-pins-258-v2
mesh-dns
signin-d311-merged
docs-pages
ui-size-283
fix-ui-batch-specs
wip/j12b-edge-update
gate-on-arm
fix-rename-sync-293
trust-285-j60b
fix-focus-ring-clip
integ-ui-1101
edge-update-v2
signin-d311
taste-2026-11-01
layout-per-tab-250
ui-approved-splitopt-224
ui-approved-splitopt-224-on-dev
icon-text-centre-282
ui-approved-189-212-216
research-reverse-proxy
transfer-budget-320
review-mesh-pins-258-r2
sidebar-pill-259
review-mesh-relay-220
wip/j12-edge-update-v2
nix-package
status-crash-loop-237
fix-dev-test-failures
fix-fixture-socket-path
wip/mesh-relay-220-pre-dev-advance-rebase
fix-canvas-side-clip
research-head-to-head
frosted-real-256
review-mesh-pins-258
wip/mesh-relay-220-pre-final-rebase
review-layout-per-tab-250-r2
broad-suite-triage
nix-devshell
review-status-crash-loop-237-r3
wip/nix-devshell-pre-p3
taste-frosted-real
wip/code-serve-demo-2026-10-30
wip/code-serve-glass-2026-10-30
wip/code-serve-clusters-2026-10-30
wip/code-merge-release94-dev-2026-10-30
wip/rproxy-delta-scratch-2026-10-30
wip/stale-note-257-staged-2026-10-30
wip/d241-size-staged-2026-10-30
review-broad-suite-207
wip/mesh-pins-258-pre-split
wip/mesh-relay-220-pre-rebase
mesh-measure-220
plan-211-update
review-edge-autoupdate-r3
perf24-reconnect
review-stale-note-r2
release-prod-live
d241-shell-marker
review-mesh-pins-server-258
review-revocation-r3
review-setup-token-r2
review-sync-journal-r3
wip/review-mesh-pins-258-prune-review-1995fee46
frosted-scroll-256
sync-journal-r3
revocation-per-account-wip
review-tokio-asyncfd-0386
review-sync-p3s
wip/stash-8by64-stash0-2026-10-30
mesh-drag-r2
setup-token-data-wip
release-9-4
auth-busy-1013
mesh-view-overlap
sync-p3s
review-auth-busy-wake
review-readd-r8-wip
mesh-drag-bounds
audit-auth-93
app-windows-stream-start
review-authority-cap-r3
app-windows-r7-measure
readd-minimal-r6
readd-minimal-r5
app-windows-r7-soak
readd-minimal-r4
app-windows-r7
app-windows-r6
readd-minimal-r3
readd-minimal-r2
readd-minimal
merge-release8-dev
review-busy-page-liveness-r2
review-busy-page-liveness
mesh-view-trim
review-authority-read-retry-r2
review-remove-uninstall-r2
release-retry-reattach
release-retry
review-remove-uninstall
review-authority-read-retry
app-windows-ship
mesh-autoswitch-p2
mesh-ssh
mesh-relay
mesh-macos-node
screen-and-control
session-labels
review-real-logins-r5
review-real-logins-r4
review-real-logins-r3
shim-memory-r2
review-real-logins-r2
shim-memory
shadow-addhost-instant
shadow-real-logins
shadow-same-session-flood
shadow-prod-perf-fix
hosts-from-server
app-windows-real
app-windows-transport
release-prod-6w
mesh-policy-verify
quiet-close-toast
dev-merge-r4
review-mesh-agent-transport
review-app-windows-transport
settings-roundtrip
review-release-pipeline-r4
mesh-agent-transport
ended-strip-fix
review-audit-ca-update-d244
settings-rows
phone-width
signout-clear
fix-restart-tests
dev-merge-rp
signer-hardening
review-audit-ca-update
terminal-fidelity
review-audit-ca-update-wip
mesh-integrate
review-mesh-agent-transport-515d3712
review-mesh-dataplane-feec1988
mesh-dataplane
signout
research-canvas-node
wip/review-renderer-cost
wip/review-terminal-fidelity
padlock-glyph
review-release-pipeline-2e95b689
phone-polish
sidebar-polish
inbox-generic
review-mesh-dataplane-378d4055
prod-batch
ui-inbox
ui-ca-unlock
ui-machine-sections
review-mesh-dataplane-a5f744fb
tls-session-prod
session-bounds-prod
fix-dead-session
session-bounds
tls-session
palette-polish
shortcuts-d222
research-appmeta
phone-gutter
ui-centre-button
wip/ui-centre-button
wip/tls-session
review-addhost-breakit
ui-platform
renderer-cost
remote-agents
mesh-api
ssh-bootstrap
prod-hotfix2
prod-fixes
review-remote-agents
review-mesh-dataplane
session-life
research-browser
review-mesh-api
research-capture
review-mesh-api-round3
review-mesh-api-round1
gate-stability
review-gate-stability
review-relay-direct
review-mesh-api-findings
proto-sessions
font-picker
proto-addhost
proto-windows
mesh-core
latency-gate
research-bsd
research-discovery
keytray-mods
mock-core
ui-tweaks
fix-motion-sel
fix-motion
integrate2
fix-robust
t-web
t-server
vt-ghostty
fix-snap-echo
t-web-auth
review-vt2
t-agent
lane-protocol
lane-shim
lane-auth
s1-base
s1-contracts
s1-workspace
No results found.
No labels
launch-qa
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set
Reference
kayg/infraternal#178
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Decided work queued by the orchestrator 2026-10-12; launched by the slot scheduler.
Starting session labels backend on branch
session-labels, based at57b0c3ddca8e190f674071e39dcc0aed1ca76cf6(origin/dev). Issue #178 has no prior comments and no parent reference in its body. Reading D81/D236 and contracts/wire.md is complete; beginning implementation review.Finding: the shim owns the PTY (
crates/infraternal-shim/src/pty.rs) and its poll loop is event-driven withPollTimeout::NONEwhile there is no deadline (crates/infraternal-shim/src/session.rs:556-563).SessionRecordalready has pinned names but no OS folder/program fields (apps/tracer/src/canvas/sessions/inventory.ts:19-25). To update detached sessions, the infraternal agent needs a label-only shim observer; it can wait on the existing Unix socket without adding an idle timer. No user-visible row UI changes are needed.Contract proposal for #178 / D236: add shim capability bit 5 (
SESSION_LABELS) and a label-only observer that receives the cached label plus changed labels without reading terminal data. After successful PTY input writes or output reads, the shim reads the foreground process and current directory from OS APIs, with a shared one-second lookup throttle and no idle timer. Add public binarySessionLabelframe 0x17: sub_id, session UUID, optional foreground program with short args, and current directory's final component. On leg B it uses control sub_id 0; on leg A the server sends only labels for that subscriber's live local sessions. The tracer keeps program/folder fields and gives pinned names precedence. This is additive to both v1 protocols; no shell configuration and no row UI change.Contract step complete at
4f035b966105d2641442969dc380698e6b11f251.contracts/shim.mddefines additive capability bit 5 and label-only observation;contracts/wire.mddefines SessionLabel frame 0x17 and account-scoped delivery.git diff --checkpassed (no output). The frame is additive; no codec or runtime changes are in this commit.Finding: renaming a session to its current automatic label leaves it unpinned. Evidence:
bun test apps/tracer/src/canvas/sessions/live-inventory.test.tsfails the new regression atapps/tracer/src/canvas/sessions/live-inventory.test.ts:152(10 pass, 1 fail). A later foreground change would replace the person's chosen name.The initial process reader treated the idle login shell as a foreground program.
contracts/shim.md:323-326specifies that the shell itself is not a program label and its working directory supplies the fallback. I am updating the reader to compare the PTY foreground pgrp against the spawned shell PID; no measurement was taken for this finding.Review found that the draft retained an observer's pending label frame indefinitely if its peer stopped reading.
contracts/shim.md:333-334requires bounded pending labels to be retired, while PTY progress stays independent. The shim now drops a label observer with a pending frame when a subsequent PTY activity event confirms that the frame had a poll opportunity; this adds no idle timer.Wire slice completed and committed as
a6c3875b76. Added public type 0x17, the shared golden vector, Rust codec/oracle support, and TypeScript codec support. Gates:cargo clippy -p infraternal-protocol --all-targets --locked -- -D warningspassed;cargo test -p infraternal-protocol --lockedpassed (7 tests); protocol TypeScript compiler passed; tracerbun run checkpassed; focused Bun tests passed (18 tests), and stream differential passed (141 streams, 12,333 schedules, zero divergences; 37,005 expectations). The stream test's cold direct invocation exceeded its 5 s default before the example was built; rerunning with the repository gate's 30 s timeout passed in 8.3 s.Review found that
connect_labelscalledconnect_with, which masked away bit 5 and sentAttach(0)to an older shim before rejecting it. A legacy Attach(0) could select writer 0 and replace an existing ordinary peer. I am adding a required-capability handshake check before Attach so older shims receive no state-changing message.The first hot-path draft sampled
/procbefore checking the one-second report bound, so repeated input/echo activity could repeat OS reads for every key even though reports were throttled. I am moving the bound check before process sampling; the next PTY event after the bound observes the latest label.Review found that startup label watchers were spawned before
publish_session_snapshotqueued the initial inventory, while the actor drops labels whose session is not yet in its live set (crates/infraternal-agent/src/daemon.rsstartup andcrates/infraternal-server/src/embedded.rsSessionLabel handling). A fast initial frame could therefore be lost. I am queueing the census before watchers; newly opened sessions will also enqueue their census and Result before starting the label watcher.Shim slice committed as
a2cec1c63f. The event path samples OS labels after PTY input/output, excludes the login shell from the program label, bounds and sanitizes fields, throttles before OS reads, and drops stalled label peers after later PTY activity. Gates: shim Clippy passed; process-label tests 4/4, frame tests 9 passed (1 ignored measurement), label-observer retirement 1/1, and sequenced session tests 7/7. The real observer idle canary and per-keystroke latency comparison remain pending on the perf VM.Finding:
Pty::label_on_attachcallscurrent_label, so starting a label observer performs an OS lookup without PTY input/output. This violates D236's activity-only sampling rule. I will change Attach to replay cached state only; if no PTY activity has been sampled yet, the first label waits for the next PTY event. Evidence:crates/infraternal-shim/src/session.rs:876-882andcrates/infraternal-shim/src/pty.rs:182-186.Finding: The new leg-B control frame (0x17) is rejected by shared fixture parsing.
scripts/agent_fixture.pytreats every non-Event control frame as a bad stream, andscripts/verify-latency.pyrejects stream 0 before its PTY latency accounting. Label activity would therefore break existing native tests. Evidence:scripts/agent_fixture.py:349-356andscripts/verify-latency.py:60-79. I am updating both readers to validate and skip the metadata frame.Gate finding:
scripts/verify iteratestopped at the built-inlatency_proxy.py self-testwith exit 1 on the shared build host. That step emits latency metrics, which D256 requires measuring on the perf VM; the build-host result is discarded as evidence. I will add a validated perf-VM receipt input forscripts/verify, run the self-test on the perf VM, and rerun the gate with that receipt. Evidence path:scripts/verifyandscripts/latency_proxy.py.Agent observer/pass-through committed:
002c34ec.cargo clippy -p infraternal-agent --all-targets --locked -- -D warningspassed.label_handshake_rejects_old_shims_before_sending_attach: 1 passed, 0 failed; the old-shim Attach regression was red before the required-capability check.Server pass-through committed:
138e02d9. Server clippy passed. The full server library suite reported 242 passed, 0 failed, 22 ignored; focusedagent_link_loss_invalidates_the_last_live_session_snapshotandsession_labels_are_account_filtered_and_sent_only_when_changedboth passed (1/1 each). The label test checks pre-census rejection, live label retention, census pruning, account/local/open filtering, and changed-only delivery.Tracer model committed:
feac19b4.bun run checkpassed. Focused model and protocol tests: 17 passed, 0 failed, 116 assertions. Automatic labels follow program then folder; a chosen name stays pinned, including when chosen equal to the current automatic label.Perf evidence on infraternal-perf-test (x86_64, 4 cores, CPUWeight=10000; load 0.28–0.86): 4 alternating rounds × 500 keystrokes per binary. Echo p50 was 0.1773 ms baseline and 0.1739 ms candidate (−0.0034 ms; observed round spread 0.0384 ms, within noise); p99 was 0.3950 ms and 0.3556 ms. Ack p50 delta was −0.0044 ms, also within observed noise. The session label observer had 0 activations during 5.000 s idle. The 300 ms latency proxy self-test passed (p50 316.08 ms, p99 318.85 ms, n=3).
Receipts: keystroke echo, idle canary, latency self-test.
Committed
b98fa51b: observer attach replays cached label state only; a fresh OS lookup now waits for PTY activity (D236/D81). Gate: cargo fmt --all --check PASS; shim Clippy PASS; label tests 6 passed, 0 failed. Perf idle canary: 0 activations / 5.000s; receipt attached above.Committed
163b3d9e: shared agent fixture and seven verification/measurement scripts now validate and consume session label control frames. Gate: AST syntax and focused control-frame smoke passed for all 7 touched Python scripts; git diff --check passed.Committed
83b43975: scripts/verify now accepts a validated perf VM RTT self-test receipt and emits that exact result instead of sampling RTT on the shared build host. bash -n passed; valid receipt replayed verbatim; failed receipt was rejected; git diff --check passed.Finding from the first full iterate run:
attached_window_recovers_final_output_and_exit_after_shim_link_detachesfailed becauseverify-session-exit-credit.py:41asserted that the nextBinary.process()result was InputAck; a session label control frame (0x17) can arrive first. The production path did not fail. I’m updating the shared fixture to skip label controls when it reads for terminal frames, then will rerun the focused regressions and gate.Committed
2df7d6c0: the shared fixture now skips session label frames while waiting for another protocol frame. The failure from the first iterate run is fixed:session_bounds_review::attached_window_recovers_final_output_and_exit_after_shim_link_detachesnow passes (1 passed, 0 failed) against the real binary. Python syntax and git diff --check passed.The second iterate run passes
session_bounds_reviewbut failssession_exit_events: the final D81 idle window observed 3 scheduler activations after the empty-agent and adopted-shim windows each observed 0. The likely source is the label observer's 250 ms reconnect sleep after its link closes. I’m removing timer-based reconnects so a new agent channel/session census starts a fresh observer. Finding receiptCommitted
a17b6766: label observer retries no longer use a 250 ms timer; the next agent channel starts a fresh observer. Gates: agent Clippy passed; session_exit_events real-binary test passed (1/1); fmt passed. Perf VM (4 cores, CPUWeight=10000, load 0.34/0.84/0.74): all three 2.200 s idle windows had 0 activations; 8 exit notices p50 517 µs, p99 621 µs, max 706 µs / 400000 µs budget. ReceiptThe final iterate run found one server test failure after the session label, idle, and exit tests passed:
saturated_native_control_queue_does_not_hide_primary_terminal_output(server suite 423 passed / 1 failed / 46 ignored). The remote-feature isolated rerun also failed at the healthy-primary output assertion. The test does not create a PTY or session label, and it is outside the listed host-load exemptions. I’m checking this timing-bound case on the perf VM before the final gate. Finding receiptThe isolated
saturated_native_control_queue_does_not_hide_primary_terminal_outputtest passes on the perf VM (4 cores, CPUWeight=10000, load 0.01/0.07/0.13). It observed the saturated control flight plus queued Pong while the primary terminal remained live and delivered the output; the test passed within its 100 ms delivery bound. Perf VM receiptThe final fast size check finds the x86_64 static binary at 22,389,296 bytes against the fixed 22,204,304-byte D243 cap (+184,992). I’m preserving the cap and analyzing the added code size; the gate is still completing its other target checks. Size finding receipt
Final fast gate at
a17b6766had fmt, VT native fmt, CLI plugin compile-out, clippy, tests and cargo-deny PASS. Static builds failed both fixed D243 size budgets: x86_64 22,389,296 bytes (cap 22,204,304; +184,992); aarch64 19,805,944 (cap 19,638,744; +167,200). The test-static-size fixture also failed because it checks the exact x86 size. Full receipt: verify-fast.log.Measured detached origin/dev
57b0c3ddwith pinned rustc 1.99.0 and the unchanged Cargo.lock: x86_64 shipping binary is 22,275,888 bytes, 71,584 over D243's fixed 22,204,304 cap. The session-label candidate adds 113,408 bytes (22,389,296 total; +184,992 vs cap). Receipt: size-base-measurement.txt. I am tracing and reducing the binary cost without changing the cap.Stopped the first VM echo trial after its baseline round: remote harness defaulted to a simulated 300 ms RTT (p50 299.8482 ms), so it was not native latency evidence. No candidate timing conclusion was drawn. Receipt: echo-trial-rtt-config.txt. Retry sets
INFRATERNAL_TEST_RTT=0explicitly.The
opt-level="z"trial oninfraternal-agentandinfraternal-shimis 22,195,824 bytes x86_64 (8,480 below the old cap). On the perf VM (4 cores, CPUWeight 10000, RTT 0), 2,000 echoes gave p50 0.1743 ms baseline / 0.1902 ms candidate (delta +0.0159 ms, within 0.0205 ms round spread). Ack p50 was 0.1380 / 0.1560 ms (delta +0.0180 ms, outside 0.0111 ms spread), so I am isolating which package causes the Ack slowdown before retaining this profile. Receipt: session-label-size-profile-z-echo.txt.The isolated
infraternal-shimopt-level="z"candidate (agent O3) saved 9,088 bytes from the default candidate. On the perf VM it had Ack/echo p50 deltas of −0.0293/−0.0235 ms, both within observed round spread (0.2451/0.2105 ms); load rose from 0.53/0.57/0.31 to 0.72/0.61/0.33, so the run was noisy. Receipt: session-label-shim-z-echo.txt. Testing agent optimization separately next.The isolated
infraternal-agentopt-level="s"candidate (shim O3) measured 22,237,072 bytes x86_64. The 2,000-echo perf VM run showed Ack/echo p50 deltas −0.0260/−0.0153 ms, both within observed round spread (0.2901/0.3237 ms); VM load was high at 1.75/0.89/0.65. Receipt: session-label-agent-s-echo.txt.For the proposed final profile (
infraternal-agents,infraternal-shimz,infraternal-protocols,infraternal-plugin-apis), the perf VM x86_64 image is 22,173,648 bytes. A 2,000-echo real-PTY comparison at RTT 0 measured Ack p50 delta +0.0406 ms within 0.0897 ms round spread, and echo p50 delta +0.0478 ms within 0.0969 ms spread. Load rose from 0.02/0.26/0.36 to 0.34/0.32/0.38. Receipt: session-label-final-profile-echo.txt.Profile trial (
agents,shimz,protocols,plugin-apis) measures 22,173,648 bytes x86_64 (30,656 under the old cap) and 19,644,136 bytes aarch64 (5,392 over). I’m reducing a small noninteractive package before ratcheting either ceiling. Receipt: size-profile-current.txt.The final-profile VM label canary exited before rendezvous (candidate
ee8e7674, 22,158,320 bytes); the harness suppressed child stderr, so this is not an idle result. I’m isolating the package-profile combination before rerunning. Receipt: idle-profile-start-failure.txt.Correction to the previous startup finding: the failure came from a 117-byte test socket path; the short 93-byte path reaches the shim. The subsequent restore-label timeout was a test assumption: the child exits without PTY output, and D81 forbids an idle wakeup. I added one shell output marker after child exit so the canary observes restoration after permitted PTY activity. Receipt: label-canary-harness-finding.txt.
Perf canary completed on infraternal-perf-test (4 vCPU, CPUWeight=10000, perf lock held): labels observed initial folder-only, changed folder
label-work, foregroundsh, then restored folder label. The idle window recorded 0 observer activations over 5.001s. The harness emits one marker from the resumed shell to trigger event-driven sampling under D81; no idle retry is needed. Echo n=2,000: baseline p50 0.8208ms, candidate 0.8988ms (+0.0780ms), observed spread 0.2305ms (within noise); Ack p50 +0.0829ms against 0.2010ms spread. Load average was 0.75/1.12/0.89 to 1.01/1.16/0.91. Receipts: echo, label and idle canary.Committed harness correction as
db03d91ba8. The resumed shell now emits one marker to trigger event-driven sampling, and the perf VM canary observes its restored folder label before reporting 0 activations over 5.001s idle.python3 -m py_compile scripts/verify-session-labels.pyand the real-shim perf canary passed. Receipt: canary.Committed measured profiles and exact D243 size ratchets as
fca8f12298. Shipping sizes: x86_64 22,158,320 bytes; aarch64 19,628,168 bytes. Perf VM echo p50 delta +0.0780ms within 0.2305ms observed spread.scripts/verify iteratefinished with:ITERATE gate passed. This is not the final gate: run scripts/verify fast before reporting done.Finding during final
scripts/verify fastatfca8f12298:remote_runtime::tests::standby::control_queue::saturated_native_control_queue_does_not_hide_primary_terminal_outputfailed in the server library suite (423 passed, 1 failed, 46 ignored; suite elapsed 396.16s). Receipt:CONTROL_SATURATION active=true queued=1 native_primary_live=true shadow_output=0; assertion:full control FIFO prevented healthy primary terminal delivery. This is not one of the documented shared-host exception tests. The remaining gate rows were still running when reported; I will investigate and record the final outcome.Second final-gate finding at
fca8f12298: both shipping images pass exact D243 caps (x86_64 22,158,320/22,158,320 bytes; aarch64 19,628,168/19,628,168 bytes), butscripts/test-static-size.pyfails before its boundary assertions. The fixture parsesmax <bytes>althoughrust_check_static_binaryreportscap: <bytes> bytes; traceback is attached inverify-fast-final.log. I will update the fixture to parse the reported cap and rerun its checks.Committed the D243 fixture parser fix as
48ba75e062.CARGO_TARGET_DIR=/home/kayg/.cache/codex-scratch/session-labels/target python3 scripts/test-static-size.pypasses: x86_64 exact 22,158,320 accepted, 22,158,321 rejected, shrink ratchet enforced; aarch64 exact 19,628,168 accepted, 19,628,169 rejected, shrink ratchet enforced; unsupported target rejected.Isolated the failed control-queue timing test on the perf VM (4 vCPU,
/var/lock/perf-bench.lock,CPUWeight=10000): it passed 1/1 in 0.12s at load average 0.75/2.23/2.99. The full first fast run had the test fail after the 396.16s server suite, and the static-size fixture fail because it parsed an obsolete field; both outputs are attached in first fast transcript. Isolated perf receipt: control queue test. The fixture parser is now fixed in48ba75e. I will rerun the final gate at that head.Self-review finding:
crates/infraternal-shim/src/process_label.rsused a 152-byte prefix before the macOSvip_pathfield. Apple’s public XNUproc_info.hdefinesvinfo_statfields totaling 144 bytes, followed byvi_type,vi_pad, and an 8-bytefsid_t;vnode_infois therefore 160 bytes.proc_pidinfo(PROC_PIDVNODEPATHINFO)also expects the completeproc_vnodepathinfosize. The current buffer is 16 bytes too short for the two path records and placescwd.path8 bytes early, so macOS cannot reliably produce the folder label. Source: https://github.com/apple/darwin-xnu/blob/main/bsd/sys/proc_info.h (vinfo_stat,vnode_info,vnode_info_path,proc_vnodepathinfo). I am adding an ABI layout test before changing the code.Validation context for the macOS ABI fix: the full library test run passed all 86 tests, including
process_label::macos_abi_tests::proc_vnodepath_uses_the_kernel_layout. The standalonecargo test -p infraternal-shimthen reached the unrelatedmouse.rsintegration probe, which failed because its nestedscripts/verify-vt-native.pycould not findzigin this manual command's PATH (FileNotFoundError). The projectscripts/verify fastwrapper supplies the required environment and passed this probe on the preceding head.cargo checkfor the full shim on Apple targets is stopped by its libghostty build script (unsupported libghostty-vt target); compiling the actualprocess_label.rsin an isolated checker passes for both Apple targets. I will rerun the full project gate after committing the ABI correction.Committed the macOS process-label ABI correction as
35feb0d6b6. The new layout test failed before the fix at offset 152 vs expected 160, then passed with the corrected layout (VnodePath 1,184 bytes; VnodePaths 2,368 bytes). The process-label module compiles for aarch64-apple-darwin and x86_64-apple-darwin in the isolated checker; crate clippy and fmt pass. The full shim library run passed 86 tests including the regression; its unrelatedmouse.rsintegration probe needs the Zig environment supplied byscripts/verify. The full fast gate is now running at this head.Finished on branch
session-labelsat35feb0d6b6adaa68aa102cb17025b555d0dd24fe. Not pushed, per task scope.Final
scripts/verify fastsummary (verbatim):Full transcript: verify-fast-final-head-35feb0d6.log
Perf VM (
infraternal-perf-test, 4 vCPU), 2,000 echoes, RTT=0: echo p50 0.8208ms baseline / 0.8988ms candidate (+0.0780ms; baseline spread 0.2305ms); p99 4.7339ms / 4.1700ms. Idle canary:session label observer idle: 0 activations / 5.001s. Echo receipt · Idle canary receiptThe macOS
proc_vnodepathinfolayout fix has a regression assertion for the 160-bytevnode_info; the red/green ABI test passed, and the label module compiled for both Apple architectures in the scratch target check.Independent verification review started on branch
review-session-labels, based at57b0c3ddca8e190f674071e39dcc0aed1ca76cf6(origin/dev), reviewing target35feb0d6b6adaa68aa102cb17025b555d0dd24fe. Issue #178 has no parent reference; all 50 existing comments and the job report have been read. Reviewing the diff and contracts now.Starting delta verification on branch
review-session-labels, based at35feb0d6b6adaa68aa102cb17025b555d0dd24fe. The requested review range35feb0d6..35feb0d6is empty; the local review branch has no commits beyond that head. I read the issue history and job report and am checking for prior review tests/findings before recording the delta verdict.Finished delta review at
35feb0d6b6adaa68aa102cb17025b555d0dd24feonreview-session-labels.Verdict: MERGE (no P0/P1). Findings: P0 0, P1 0, P2 0, P3 0.
git diff 35feb0d6..35feb0d6is empty.git log 35feb0d6..review-session-labelsis empty, and there is no priorfindings.mdor earlier findings report, so there were no failing review tests to cherry-pick or mark pass. No implementation or test files changed. The gate below is the job's recorded output at this exact head, copied verbatim; it was not rerun for this empty delta.Independent verification review started on
review-session-labelsat target35feb0d6b6adaa68aa102cb17025b555d0dd24fe, reviewing the full feature range from merge base57b0c3ddca8e190f674071e39dcc0aed1ca76cf6(origin/dev). I read the issue's 53 comments; no parent reference appears in its body or comments. The prior review comment covered an empty head-to-head delta; this pass checks the full 41-file feature diff. No priorfindings.mdexists.Finding SL-1 (P1): abbreviated password arguments can enter labels. In
crates/infraternal-shim/src/process_label.rs:79,program()copies the first short arguments unless their names match the sensitive-word heuristic. A foreground argv ofclient -p synthetic-markerpasses that value into the label;live-inventory.ts:104then stores the unpinned automatic label as the session name. The newprocess_label::tests::short_password_flag_values_are_not_disclosed_in_process_labelsfails (0 passed, 1 failed). Evidence test committed onreview-session-labelsase043fc384d252c7610f5b842298e89ff6cc211a9; transcript:$HOME/.cache/codex-scratch/session-labels-review/password-label-test.log.Finding SL-2 (P2): the one-second bound is applied to successful reports, not attempted lookups.
Pty::changed_labelatcrates/infraternal-shim/src/pty.rs:186updateslabel_last_reportonly aftercurrent_label()succeeds and changes the cache. On a transient OS lookup failure, the next PTY activity samples again immediately.pty::label_throttle_tests::failed_label_samples_respect_the_one_second_lookup_boundcounted 2 calls on two immediate attempts with an invalid PTY fd (expected 1), and failed (0 passed, 1 failed). Evidence test committed as5ba33f4529027cf4396d78aa1c62f9cb7510f919; transcript:$HOME/.cache/codex-scratch/session-labels-review/failed-label-throttle-test.log.Finding SL-3 (P1): the macOS process-label ABI buffer is still 8 bytes too large. Apple XNU defines
vinfo_stat; summing its fixed fields gives 136 bytes.vnode_infothen adds two 4-byte integers and an 8-bytefsid_t, sovnode_info_path.vip_pathbegins at byte 152, not 160.proc_vnodepathinfocontains two 1,176-byte records (2,352 bytes), while the current code passes 2,368 bytes and reads the path at offset 160. The revisedprocess_label::macos_abi_tests::proc_vnodepath_uses_the_kernel_layoutfails at 160 vs 152 (0 passed, 1 failed). Sources: XNU proc_info.h, XNU type definitions, XNU statfs definition. Evidence test committed as95019b6d8e43957b1844c370d97af346fc65ae06; transcript:/home/kayg/.cache/codex-scratch/session-labels-review/macos-layout-test.log.Finding SL-4 (P1):
SessionLabelis sent without leg-A capability negotiation. Wire §8 says a new frame type is sent only after the peer announces its matching cap. The browser Hello atapps/tracer/src/connection.ts:365advertises onlyRESUME_NEXT(caps 0 or 1); the server handshake keeps only that bit (websocket.rs:1134), whilesend_terminal_session_labelssends frame 0x17 to every terminal-session subscriber (websocket.rs:894). The base v1 decoder has no 0x17 case and rejects unknown types, so an older browser closes the socket after subscribing. RegressionHello advertises the session-label receive capabilityfails (0 pass, 1 fail). Evidence committed as679ac824a2116be11e0a22a30b0c9e30ccf7fca2; transcript:/home/kayg/.cache/codex-scratch/session-labels-review/label-capability-test.log.SL-1 has a second failing credential case.
process_label::tests::user_option_credentials_are_not_disclosed_in_process_labelsfails for argvclient --user synthetic-user:synthetic-marker: the value is copied into the automatic process label. Test log: /home/kayg/.cache/codex-scratch/session-labels-review/user-option-label-test.log. Evidence commit:7edec1f9.Fuzz step complete at review head
7edec1f93e. The shim decoder completed 506,684 generated inputs; wire frame decode completed 1,820,345; wire stream decode completed 96,757. No crash or ERROR output. The shim target also returned exit 0 on a scratch-corpus confirmation run. Logs are under /home/kayg/.cache/codex-scratch/session-labels-review/. Generated shim corpus entries were removed; tracked seeds remain.Independent review complete. Review evidence head:
7edec1f93e9ebe5edf3009277b138829cc53d47d; implementation head reviewed:35feb0d6b6adaa68aa102cb17025b555d0dd24fe.Verdict: HOLD (P0/P1 present). Findings: P0 0, P1 3, P2 1, P3 0. Five failing evidence tests are committed across four findings. The job-head
scripts/verify fasttranscript below is copied verbatim from the job report; it was not rerun on the review branch because its evidence tests intentionally fail.Continuation r2 started on session-labels at base
35feb0d6b6. Read all 61 issue comments; no parent is referenced. Reproducing the five review tests before fixes for SL-1..SL-4. Contract clarification: program labels contain only executable basenames (no arguments); leg-A SessionLabel requires negotiated Hello bit 1, independent of RESUME_NEXT bit 0. Keep sampling activity-driven and throttle every attempted OS lookup. No UI changes. Final gates, size comparison and perf-VM echo/idle evidence precede delta-review handoff.Contract clarification committed and pushed as
9a23de99(D236/D81/wire §8). Local red reproduction: process-label tests 4 passed / 3 failed (both credential cases and ABI offset 160 vs 152); invalid-PTY throttle counted 2 OS attempts rather than 1 (0 passed / 1 failed); browser Hello capability 0 passed / 1 failed. Red receipts are under session-labels-r2/evidence. Building the server mixed-version regression next. No parent reference in #178 history.red-process.log
red-throttle.log
red-capability.log
Contract step
9a23de99is pushed. Documentation-only gate: git diff --check passed. SL-1 uses OS executable paths instead of argument redaction; regression coverage exercises live processes with synthetic credential shapes. SL-4 uses leg-A bit 1 and renegotiates it on resume, with no label work for legacy browsers. Baseline build for native echo/size comparison is pinned to35feb0d6.Browser capability step committed and pushed as
30597dfe. Tracer bun run check passed; all seven connection tests passed (0 failures, 33 assertions), including the imported Hello regression. Server mixed-version regression was red before the delivery guard: legacy peer received SessionLabel (0 passed / 1 failed). Receipt: red-server.log. The isolated OS label module compiles for both aarch64-apple-darwin and x86_64-apple-darwin; macOS runtime remains unmeasured.Executable-only OS reader:
357e0774pushed. Seven focused label tests and shim Clippy passed; synthetic credential shapes and spoofed argv[0] do not enter executable labels. Both Apple targets compile in the isolated real-module check.macOS layout:
03da5544pushed. Seven label tests and shim Clippy passed; ABI assertions verify stat=136, vnode=152, fsid offset=144, alignment=8, path record=1176 and two-path buffer=2352 bytes. Confirmed against the documented fixed fields in https://github.com/apple/darwin-xnu/blob/main/bsd/sys/proc_info.h. Compile checks cover both Apple architectures; no macOS runtime claim.Leg-A delivery:
6d7a1178pushed. Six inventory tests passed (one measurement ignored); server Clippy passed. Fresh/resumed peers negotiate bit 1; peers with no bit, resume only or unknown bits receive no initial/changed SessionLabel frames. Existing account/open/local/live and changed-only filtering stays covered.SL-2 committed and pushed as
9c680722. Every activity-triggered OS lookup records its attempt timestamp before reading; failed and unchanged samples share the same one-second bound. No timer or background retry was added. Eleven focused label tests and shim Clippy passed, including the imported invalid-PTY regression (one attempt for two activities), expired-budget retry, unchanged-cache bound, observer cached attach and stalled-observer retirement. Full iterate/fast, exact shipping sizes and fresh perf echo/idle evidence are next.Rebuilt baseline
35feb0d6with pinned rustc 1.99.0 and unchanged Cargo.lock: x86_64 static shipping image is exactly 22,158,320 bytes, matching that head's D243 cap (+0). Baseline build exited 0. Candidate release build and workspace iterate gate are still running; fresh aarch64 baseline is building too. No candidate size or echo conclusion yet.base-size.txt
First iterate gate: fmt, VT fmt, CLI compile-out, workspace Clippy and cargo-deny passed. Test compilation failed before execution: walkdir could not find target/debug/deps/libsame_file-8be1433ea6eb73e5.rmeta, despite same-file being compiled. No same-file artifacts/fingerprint were present afterward. A direct dependency-package build also hit Cargo's activated_features resolver panic (same-file is a dev dependency through criterion). Rebuilding through infraternal-protocol's test graph, then rerunning iterate; no source change or gate waiver.
verify-iterate.log
Gate blocker diagnosed: the host disk guard deletes target*/debug under scratch directories whose basename does not match an active job unit whenever free disk falls below 60 GB. This run used session-labels-r2, while the active job is session-labels. The entire debug directory was removed during both iterate attempts, causing missing rmeta/object/fingerprint paths rather than test failures. Switching subsequent gates to the canonical job scratch directory session-labels/gate-build; the guard service remains unchanged. No row is waived. Static ARM builds and successful perf-VM measurements are unaffected so far.
Perf-VM verification passed at Rust source head
9c680722(x86_64 image 22,152,144 bytes, 6,176 below rebuilt baseline35feb0d6). Harness commit6430e5d2is pushed.infraternal-perf-test, x86_64, 4 cores, CPUWeight=10000, RTT=0, shared perf lock: four alternating rounds × 500 samples per image. Echo p50 0.1935 ms baseline / 0.1844 ms candidate (delta -0.0092 ms within 0.0208 ms baseline round spread); p99 0.4089 / 0.4396 ms (candidate below 5 ms). Ack p50 delta -0.0092 ms within 0.0155 ms spread. Load was 3.83/2.50/2.51 during echo; subsequent idle phases 3.83/2.50/2.51 and 3.53/2.46/2.49.
Real PTY labels: initial folder-only, changed folder label-work, executable dash despite credential-shaped argv, restored folder-only. Label observer: 0 activations / 5.001 s. Empty, adopted-unattached and all-shims-exited infraternal-agent windows: each 0 activations / 2.200–2.201 s. Eight detached exit notices passed their 400000 us bound (max 1693 us). Final perf-VM RTT self-test passed. No Mac runtime claim.
The first measurement attempt failed before sampling because the harness had not created its state directory; fixed only the scratch harness. Canonical-scratch iterate and both ARM size builds remain in progress after the disk-guard diagnosis; no gate completion claim yet.
perf-retry.log
Exact D243 ratchets committed and pushed as
584adf13. Pinned baseline35feb0d6rebuilt at 22,158,320 bytes x86_64 and 19,628,168 bytes aarch64. Candidate: 22,152,144 and 19,622,552 bytes (cuts of 6,176 and 5,616; no dependency/profile change). Both are below base with +0 allowance, and the ceilings now equal each image. PROCESS table aligned with the measured ceilings.Bash syntax passed. Boundary checks (verbatim):
Canonical iterate remains in progress; the final fast gate has not run yet.
base-size.txt
candidate-sizes.txt
test-size-boundaries.log
Head
584adf13: canonical iterate passed fmt, VT fmt, CLI compile-out, Clippy and cargo-deny; Rust tests stopped at four mesh path deadline failures (94 passed, 4 failed, 14 ignored). Failures: healthy_mesh_probes_do_not_inherit_the_previous_paths_rtt, component_down_proves_tcp_fallback_when_enrolled_udp_is_unavailable, invalid_application_proof_keeps_the_live_fallback, parked_fallback_recovers_mesh_and_keeps_control_actions_usable. No waiver: rerunning the complete iteration gate with RUST_TEST_THREADS=1 to avoid concurrent test contention. Session-label focused tests remain green. Final fast pending.verify-iterate-canonical.log
Head
584adf13: complete serialized iteration (RUST_TEST_THREADS=1) passed the earlier four mesh transport tests. One failure remained: auth::tests::socket_tests::review_liveness::review_mesh_watch_reports_liveness_expiry_without_another_edit closed its WebSocket before the initial Event (auth/tests.rs:1740, None). Server suite: 423 passed, 1 failed, 46 ignored. No source change or waiver: retrying the existing built test binary alone, then the full final fast gate. Canonical full transcript attached.verify-iterate-serial.log
Unchanged built workspace binary: isolated review_mesh_watch_reports_liveness_expiry_without_another_edit passed (1 passed, 0 failed; initial_live=true current_live=false revision=0 expiry_event_received=true). No source changes or test exclusions. Full scripts/verify fast now running at
584adf13with RUST_TEST_THREADS=1 and the fresh perf-VM RTT self-test receipt; no failures reported so far.test-liveness-direct.log
Continuation r2 stopped for delta review. Head:
584adf13ea(pushed to origin/session-labels). All requested repairs are present: executable basename only (no argument reads, credential-shaped/spoofed-argv tests), corrected macOS vnode sizes/offsets (both Apple architectures compile), fresh/resumed leg-A capability negotiation, and activity-only attempt throttling including failed/unchanged lookups. Atomic step SHAs and red/green receipts are above. No UI, dependency, deploy or merge change.Perf VM, 4 cores, CPUWeight=10000, shared lock; echo load 3.83/2.50/2.51, 2000 echoes/image: base/candidate p50 0.1935/0.1844 ms (delta -0.0092; baseline round spread 0.0208), p99 0.4089/0.4396 ms (<5 ms). Label observer zero activations/5.001 s; empty daemon, adopted unattached shim and post-exit canaries zero/2.2 s each. Program label dash despite synthetic credential argv; folder fallback restored. x86 22152144 bytes (-6176), ARM 19622552 (-5616) vs reviewed baseline35feb0d6. Static linkage/key-memory/exact size caps pass. These are the previously attached VM/size receipts, not build-host performance measurements.
Final scripts/verify fast executed at head with RUST_TEST_THREADS=1; exit1. Verbatim Rust gate output:
Rust server suite: 422 passed, 2 failed, 46 ignored. The two failures were fixture storage errors: plugin disable database or disk is full; terminal exit no such table: setup. Both unchanged built tests passed isolated retries with TMPDIR in this job scratch. Earlier mesh-path and liveness deadline failures passed in the final full run. No baseline waiver or test exclusion claimed.
Cargo-deny newly rejects unchanged rustls0.23.45: RUSTSEC-2026-0346/0347/0348/0349; its earlier iteration audits passed. Cargo.lock has no delta. This dependency-audit blocker needs remediation before gate-complete status; advisories were not suppressed. No green full gate claim.
The failed Rust gate skipped TypeScript, so ran the existing ts_verify_fast function separately: exit0, tracer check/tests/production build/transfer budgets and protocol differential tests passed (37 pass, 0 fail, 37149 assertions). Full logs and author checklist attached below. macOS runtime verification remains unclaimed. Own remote/perf artifacts and local build/source caches removed; evidence retained outside checkout. Issue remains open.
verify-fast-final.log
verify-typescript-final.log
test-plugin-disable-storage-retry.log
test-terminal-exit-storage-retry.log
author-checklist.md
Delta review started on review-session-labels at
584adf13ea; delta base35feb0d6b6, merge base with dev8e7467c07c. Read all 76 comments; no parent reference exists. Earlier evidence branch preserved as review-session-labels-prior-7edec1f9. Five prior failing tests are already imported/adapted in the target; rerunning them rather than duplicating conflicting copies. No implementation edits, push, deployment or perf VM use. Full functional gate will be run locally; existing attached VM self-test receipt may be replayed, with no independent performance claim.Review step committed locally as
35109872: extended the imported SL-4 browser regression to verify fresh caps=2, resumed caps=3 with adjacent Resume, and expired retry caps=2. Connection suite: 7 passed, 0 failed, 39 assertions. Tracer TypeScript check exit 0 after frozen dependency installation. The two failed native package downloads were retried through codeload; Zig package identities exactly match both pinned hashes. Fresh full gate remains in progress. No push and no implementation edit.Earlier SL-1, SL-2 and SL-3 regressions now PASS in an isolated rustc harness importing the unchanged process_label.rs, pty.rs and locale.rs, with the production locale/spawn wrappers and the already built pinned nix library. Nine label tests passed, zero failed. Both credential cases, failed and unchanged lookup attempt bounds, and the exact 2352-byte macOS layout are covered. This isolates label verification from the unrelated native renderer download/build; normal Cargo-focused and full gate executions remain pending. Harness logs: /home/kayg/.cache/codex-scratch/session-labels-review/evidence/label-harness-tests.log. SL-4 browser passes; server counterpart awaits Cargo. No new confirmed delta finding; no Mac runtime or independent performance claim.
SL-5 (P2), new delta finding: the executable-label privacy test fixture at process_label.rs:263-285 samples /proc//exe before child readiness. Normal Cargo label tests failed credential_argument_shapes_are_never_read_for_labels: infraternal_shim-197c4e7170e4b7b6 versus dash (10 pass, 1 fail). Its isolated retry passed. New bounded 128-launch regression executable_label_fixture_samples_the_requested_process_consistently failed with label-harness versus dash (0 pass, 1 fail), committed locally as
5d768ad1. No credential disclosure demonstrated and no implementation fix made. The fixture needs a post-exec readiness signal. Logs: /home/kayg/.cache/codex-scratch/session-labels-review/evidence/{shim-label-tests,credential-fixture-retry,fixture-consistency-test}.log. Prior SL-1/2/3 Rust tests passed normally; SL-4 browser passes with resume/expiry coverage. Server focused test and full gate still compiling.Independent cargo-deny execution reproduces the job-head audit blocker: RUSTSEC-2026-0346, 0347, 0348 and 0349; final output: advisories FAILED, bans ok, licenses ok, sources ok. Cargo.lock and Cargo.toml have no delta in 35feb0d6..584adf13. No advisory suppression or dependency fix made. Evidence: /home/kayg/.cache/codex-scratch/session-labels-review/evidence/cargo-deny.log. This is a repository gate blocker outside the reviewed feature delta; no green gate claim. Focused server build now advanced past vendored OpenSSL.
Delta review finished at evidence head
c4ccf8fd32on review-session-labels; target584adf13ea, scope 35feb0d6..584adf13 only.Verdict: MERGE (no P0/P1). Current findings: P0 0, P1 0, P2 1, P3 0. All five earlier failing tests now pass (SL-1's two credential cases, SL-2 failed-attempt throttling, SL-3 exact ABI layout, SL-4 browser Hello capability). Review browser coverage adds fresh/resumed/expired-retry caps: seven tests pass, 39 assertions; tracer check exits 0. Normal shim label suite: 10 pass, 1 fail, with all prior Rust regressions passing. New SL-5 P2 is fixture readiness, not credential disclosure: bounded 128-launch regression fails label-harness vs dash. Failing evidence
5d768ad1; browser coverage35109872; reportc4ccf8fd. No implementation fix, push or deployment.Fresh scripts/verify fast was attempted with the existing attached VM RTT receipt; its initial CLI compile-out step failed on pinned package download connection closures. Both exact package hashes were subsequently fetched, and normal shim tests ran. The remaining focused server compilation and full gate (waiting at Clippy) were stopped by owned PIDs at the delta-review timebox, exit 143. The server mixed-version helper was inspected but not independently executed. No fresh complete gate claim. Independent cargo-deny exits 1 and reproduces unchanged rustls advisories RUSTSEC-2026-0346/0347/0348/0349; bans/licenses/sources pass. Cargo.lock has no delta. No advisory waiver. No performance/size remeasurement or Mac runtime claim; perf VM was not used.
Implementation job's recorded scripts/verify fast summary at exactly
584adf13, copied verbatim (author exit 1; not an independent completed rerun):Full job-head receipt: https://git.kayg.org/attachments/2d5460b5-dfd4-4d42-be90-4f4b5c10d207
Review report: docs/verification/session-labels-delta-review.md. Raw receipts: /home/kayg/.cache/codex-scratch/session-labels-review/evidence/. Findings and final state appended to /home/kayg/.local/state/codex-jobs/infraternal/review-session-labels/findings.md. Own temporary build/harness caches will be removed; evidence retained. Issue remains open.
Cleanup complete: this review’s build/harness cache and generated Python bytecode removed; raw evidence retained. Worktree clean at
c4ccf8fd32on review-session-labels. All review processes stopped by owned PID; no push or deployment. Final verdict and verbatim job-head gate summary are in the preceding comment.kayg referenced this issue2026-10-28 17:53:56 +00:00