S1 web: port the approved onboarding and sign-in into apps/tracer #32
Closed
opened 2026-10-06 15:42:34 +00:00 by kayg
·
53 comments
No Branch/Tag specified
main
j470b-server-mesh-rejoin
mesh-compat-382
j444b-d381-key-wins-flood
j461b-macos-utun-reader-thread
j475b-remove-host-motion
fix-reconnect-new-link
j481-d380
dev
j479-mesh-soak
fix/j476-host-facts
j475-motion-pill-split
j470-mac-node-join
root-upgrade-d376
j474-review-merge
latency-targets-120hz
nightly-suite-shards
gotatun-pin-j469
macos-utun-reader-thread
fix-flood-echo-stall
wip/j416
motion-fast-ease-out
mesh-addhost-j259
takeover-close-terminals-d368
kbd-instant-followups
fix-trust-key-double-click
nightly-suite-partial-report
appwin-icons-j207
rusqlite-slice1
swipe-content-first-d374
mesh-mtu-381
addhost-instant-open
glass-contrast-d365-mock
glass-contrast-d365
signout-followups-442
fix-startup-toast-red
research-gotatun-matrix-j317
themes-sync-j304
fix-load-flakes
fix-nix-zig-patch
fix-compute01-browser-baseline
ratchet-size-baseline-419
predict-auto-d130
revoke-coverage-d367
nightly-suite-queue-timeout
nightly-browser-suite
fix-rustsec-2026-0459
fonts-ioskeley-obel
log-retention-d375
fix-kbd-no-anim-427
fix-dev-red-specs-2
takeover-proof-305-j205
wip/j410-server-pump
ui-consistency-d372
fix-osc52-clipboard
libghostty-vt-1.0
forget-retired-host-d369
j404-merge-426
fix-setup-lock-race
fix-touch-select-426
revoke-access-report-ui
fix-predictive-echo-specs
fix-selinux-agent-exec
wip/j395-checkpoint2
wip/j395
j391-review-scratch
ui-consistency-j195-deferred-rebased
fix-rustc-paths-421
decisions-wording-341
fix-install-suite-red
fix-dev-rtt-specs
fix-pending-removal-align
fix-privileged-skip
fix-install-suite-404
review-j368
mesh-dns-j254
revoke-access-report-d356b
revoke-privilege-round5
fix-removal-confirm
review-j360
gotatun-rotation-367
deps-refresh-340
review-j354
review-J351
review-j350
addhost-takeover-d359
revoke-report-items-347
revoke-end-sessions-d362
review-j348
size-mesh-ssh-346
size-trim-337
revoke-access-diff-d356
j259-pre-rebase-b06c5a6
j305-ended-at-start-spec
addhost-sudo-consent
fix-layout-real-specs-411
fix-shell-open-411
fix-console-hosts-373
fix-shell-exit
fuzz-host-name-353
fix-host-details-410
macos-filter-j197
research-gotatun-tricks
revoke-p3-j216l
stale-state-pill
revoke-followups-j216k
revoke-progress-j216e
backup/macos01-20261106/lume/j197
backup/macos01-20261106/lume/appwin-icons-j207-stash0
backup/macos01-20261106/claude/stash-0
backup/macos01-20261106/claude/stash-1
backup/macos01-20261106/claude/J80-macos-s1
backup/macos01-20261106/claude/J80
backup/macos01-20261106/claude/J80-slice1-20261102
backup/macos01-20261106/claude/J16b-appwin-on-dev
backup/macos01-20261106/claude/appwin-launch-idle-146
backup/macos01-20261106/claude/J80-s1-run
wip/j259
trust-285-p3c
runtime-lock-j216f
mesh-ssh-p3-j175
tun-proof-p3b
trust-285-p3
terminal-polish-j271
tun-proof-p3
ssh-install-flakes-j216i
fuzz-fixes-j264
trust-285-a
trust-285-b
restart-oversized-fixture-j198
backup/macos01-20261106/lume/appwin-icons-j207
restart-bound-j216h
up-preflight-p3-j198
backup/macos01-20261106/lume/j251
up-preflight-j198
wip/up-preflight-j198-j245-p2
wip/up-preflight-j198-j245-p1
agent-fsync-offloop-j196
wip/up-preflight-j198-j245
settings-offscreen-j231
wip/up-preflight-j198-j226-inspection
wip/j103f
themes-j206
wip/up-preflight-j198-j226
flakes-j216c
backup/macos01-20261106/claude/j197
flakes-j216b
backup/macos01-20261106/claude/j197-red
wip/up-preflight-j198-review
flakes-j216
backup/macos01-20261106/claude/appwin-icons-j207
engineering-j208b
appwin-mock-j209
toast-stack-j165
engineering-j208
decisions-d351
decisions-d350
decisions-d349
appearance-presets-mock-j129
decisions-d348
docs-audit-spec
doc-coverage-baseline-raise
decisions-d347
decisions-d346b
decisions-d346
j88h-profile
ui-consistency-j195-deferred
ui-consistency-j195
engineering-practices-j194
preferred-login-ui-j166
signin-pools-263-j174
macos-node-265-s1
decisions-d345
decisions-d344
proxy-cgroup-j164
verify-quick-fuzz-329
proxy-start-io-j168
timing-flakes-j163
up-263-s1
mcp-events-j147
verify-quick-fuzz-j158
proxy-p3-j159
agent-resource-j157-detect
wip/j103d-final
remote-cancel-hang-j155
proxy-traefik-281-j62d
j149-verify-quick
proxy-traefik-281-j62b
j150-drop-unnamed
wip/j79d-red-r4
wip/j103d-d332
rootless-toast-j142
wip/j103d-head
wip/j103d
j125c-mcp
macos-build-j136
backup/macos01-20261106/claude/j136
wip/j79d-red-cli
wip/j79d-red-server
j121-link-liveness
j118c-tracer-failures
wip/j79c-head
release-desktop-j131
j124c-signed-macos
wip/j79c-red-p3
wip/j79c-red-p23
wip/j79c-red-p22
merge-j128-check
perf-deferred-j128
sidebar-toggle-260
j127-shortcut-changed-dot
j125-mcp
j118-tracer-failures
j126-account-summary
settings-sections-mock-j92
j120-pinch-lock
sidebar-292
backup/macos01-20261106/claude/j120
taste-2026-11-03
row-actions-242-215
backup/macos01-20261106/claude/stash-0-untracked
backup/macos01-20261106/claude/J80-265-s1-run
backup/macos01-20261106/claude/J80-macos-s1-20261102
j112-canvas-commands
ui-no-overshoot-scroll
fix-recovery-restart
backup/macos01-20261106/claude/stash-1-untracked
taste-2026-11-02
size-baseline-ratchet
machine-cards-structure-j108
j109-boot-copy-mockups
fix-dev-red
wip/up-263-s1
j95b-settings-rows
proxy-traefik-281
j95-option-rows
docs-human-j91
docs-keys-palette
fix-flood-1013-270-j38d
mesh-ssh-s1
mesh-ssh-s0
addhost-d291-tunnel
test-stability-load
mesh-relay-220
repro-296
shim-thp-off-24
mesh-pins-258-v2
mesh-dns
signin-d311-merged
docs-pages
ui-size-283
fix-ui-batch-specs
wip/j12b-edge-update
gate-on-arm
fix-rename-sync-293
trust-285-j60b
fix-focus-ring-clip
integ-ui-1101
edge-update-v2
signin-d311
taste-2026-11-01
layout-per-tab-250
ui-approved-splitopt-224
ui-approved-splitopt-224-on-dev
icon-text-centre-282
ui-approved-189-212-216
research-reverse-proxy
transfer-budget-320
review-mesh-pins-258-r2
sidebar-pill-259
review-mesh-relay-220
wip/j12-edge-update-v2
nix-package
status-crash-loop-237
fix-dev-test-failures
fix-fixture-socket-path
wip/mesh-relay-220-pre-dev-advance-rebase
fix-canvas-side-clip
research-head-to-head
frosted-real-256
review-mesh-pins-258
wip/mesh-relay-220-pre-final-rebase
review-layout-per-tab-250-r2
broad-suite-triage
nix-devshell
review-status-crash-loop-237-r3
wip/nix-devshell-pre-p3
taste-frosted-real
wip/code-serve-demo-2026-10-30
wip/code-serve-glass-2026-10-30
wip/code-serve-clusters-2026-10-30
wip/code-merge-release94-dev-2026-10-30
wip/rproxy-delta-scratch-2026-10-30
wip/stale-note-257-staged-2026-10-30
wip/d241-size-staged-2026-10-30
review-broad-suite-207
wip/mesh-pins-258-pre-split
wip/mesh-relay-220-pre-rebase
mesh-measure-220
plan-211-update
review-edge-autoupdate-r3
perf24-reconnect
review-stale-note-r2
release-prod-live
d241-shell-marker
review-mesh-pins-server-258
review-revocation-r3
review-setup-token-r2
review-sync-journal-r3
wip/review-mesh-pins-258-prune-review-1995fee46
frosted-scroll-256
sync-journal-r3
revocation-per-account-wip
review-tokio-asyncfd-0386
review-sync-p3s
wip/stash-8by64-stash0-2026-10-30
mesh-drag-r2
setup-token-data-wip
release-9-4
auth-busy-1013
mesh-view-overlap
sync-p3s
review-auth-busy-wake
review-readd-r8-wip
mesh-drag-bounds
audit-auth-93
app-windows-stream-start
review-authority-cap-r3
app-windows-r7-measure
readd-minimal-r6
readd-minimal-r5
app-windows-r7-soak
readd-minimal-r4
app-windows-r7
app-windows-r6
readd-minimal-r3
readd-minimal-r2
readd-minimal
merge-release8-dev
review-busy-page-liveness-r2
review-busy-page-liveness
mesh-view-trim
review-authority-read-retry-r2
review-remove-uninstall-r2
release-retry-reattach
release-retry
review-remove-uninstall
review-authority-read-retry
app-windows-ship
mesh-autoswitch-p2
mesh-ssh
mesh-relay
mesh-macos-node
screen-and-control
session-labels
review-real-logins-r5
review-real-logins-r4
review-real-logins-r3
shim-memory-r2
review-real-logins-r2
shim-memory
shadow-addhost-instant
shadow-real-logins
shadow-same-session-flood
shadow-prod-perf-fix
hosts-from-server
app-windows-real
app-windows-transport
release-prod-6w
mesh-policy-verify
quiet-close-toast
dev-merge-r4
review-mesh-agent-transport
review-app-windows-transport
settings-roundtrip
review-release-pipeline-r4
mesh-agent-transport
ended-strip-fix
review-audit-ca-update-d244
settings-rows
phone-width
signout-clear
fix-restart-tests
dev-merge-rp
signer-hardening
review-audit-ca-update
terminal-fidelity
review-audit-ca-update-wip
mesh-integrate
review-mesh-agent-transport-515d3712
review-mesh-dataplane-feec1988
mesh-dataplane
signout
research-canvas-node
wip/review-renderer-cost
wip/review-terminal-fidelity
padlock-glyph
review-release-pipeline-2e95b689
phone-polish
sidebar-polish
inbox-generic
review-mesh-dataplane-378d4055
prod-batch
ui-inbox
ui-ca-unlock
ui-machine-sections
review-mesh-dataplane-a5f744fb
tls-session-prod
session-bounds-prod
fix-dead-session
session-bounds
tls-session
palette-polish
shortcuts-d222
research-appmeta
phone-gutter
ui-centre-button
wip/ui-centre-button
wip/tls-session
review-addhost-breakit
ui-platform
renderer-cost
remote-agents
mesh-api
ssh-bootstrap
prod-hotfix2
prod-fixes
review-remote-agents
review-mesh-dataplane
session-life
research-browser
review-mesh-api
research-capture
review-mesh-api-round3
review-mesh-api-round1
gate-stability
review-gate-stability
review-relay-direct
review-mesh-api-findings
proto-sessions
font-picker
proto-addhost
proto-windows
mesh-core
latency-gate
research-bsd
research-discovery
keytray-mods
mock-core
ui-tweaks
fix-motion-sel
fix-motion
integrate2
fix-robust
t-web
t-server
vt-ghostty
fix-snap-echo
t-web-auth
review-vt2
t-agent
lane-protocol
lane-shim
lane-auth
s1-base
s1-contracts
s1-workspace
No results found.
No labels
launch-qa
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set
Reference
kayg/infraternal#32
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Port the approved onboarding and sign-in mockup (branch mock-core,
mockups/core/onboarding.*) intoapps/tracer, after the auth review lands.Includes:
UI primitives go into
packages/ui(reuse rule). Review from screenshots of a production build on a phone.Starting auth onboarding port on t-web at
639ac27684and t-server at7948ff00fb. Both worktrees are clean; #32 has no comments. Read parent #21 history and the approved mockup modules; current DECISIONS.md ends at 86, so D96–103 are carried by those owner-approved module comments and #21 history. No edits yet.Contract proposal before edits: keep setup-start legacy accepted; add with username unique, display name ≤64 Unicode characters defaulting to username, reject ambiguous mixed forms. Store both account fields, use username/display_name for WebAuthn user.name/displayName, and add both to authenticated session (public status remains only). This preserves existing setup/status callers while making the new enrollment path explicit. This follows the job's stricter username rule over #21's older regex note.
Proposal clarification: preserve legacy setup-start with token and name. Add setup-start with token, username, and optional display_name. Require username to match [a-z0-9_-]{2,32} and be unique; cap display_name at 64 Unicode characters and default it to username. Reject requests mixing legacy and new fields. Store both account fields, pass username/display_name as WebAuthn user.name/displayName, and add both fields to the authenticated session; public status stays setup_required only. This preserves existing callers and follows the job rule over #21 older regex note.
Findings before implementation: packages/ui is absent (ls packages shows only protocol), so I will create it for shared auth primitives. docs/PROCESS.md is absent from t-web (sed returns no such file), so I will follow the supplied Definition of Done text directly. D108 is still conditional/blocked on #30; the UI will use the current two-stage PRF unwrap contract.
Server regression test added first and reproduced the gap: account_identity_schema_has_unique_usernames_and_display_names fails because users has no username column (crates/infraternal-server/src/auth/tests.rs:1896). The failure is isolated to schema coverage; I am adding the migration next.
Server schema step committed as
95fd00a. Migration 0006 adds username/display_name, backfills four legacy-name cases, and creates a unique username index. Evidence: infraternal-server library tests 24 passed, 0 failed, 1 ignored; focused migration backfill test passed. Existing name/setup callers remain accepted pending the next auth API step.Auth API regression test is red before implementation: setup_start_accepts_username_and_display_name gets HTTP 400 for the proposed additive request (crates/infraternal-server/src/auth/tests.rs:1893). The current Setup deserializer only accepts token/name; I am extending it while retaining that form.
Server auth step committed as
2884249. setup-start now accepts both the additive username/display_name body and legacy name; registration persists the fields, WebAuthn labels use each field, duplicate usernames map to 409, and authenticated session returns both names. Evidence: infraternal-server library tests 26 passed, 0 failed, 1 ignored; production HTTP setup and session-response test passed.Server auth contract committed as
a74eae5. contracts/keywrap.md now documents 2–32 ASCII usernames, 64 Unicode-scalar display labels, the legacy setup body, authenticated session fields, migration backfill, and 409 duplicate handling. Public status remains setup_required only.Finding: the first browser run recorded non-input layout shifts during step 1 → 2 (5 entries; largest 0.0818). The approved height animation changed the centered card footprint in Layout Instability. Reserving the maximum measured step pane before first paint so the card and footer stay fixed while step contents animate.
Client shared-primitives step: added packages/ui at
4f140e4b37(seven approved browser modules plus shared styles, AGPL-3.0-only). Tracer production build: built main.js, chunk-sxzajhbf.js, chunk-k5nvdjvh.js.Performance finding: on the same Linux 6.12 x86_64, 8-vCPU host, 30 fresh production pages measured the supplied client at setup p50/p99 105.4/148 ms and sign-in 101.9/135.3 ms; the new flow measured 247.2/504.1 ms and 185.7/223.6 ms. The screenshot upper bound included deferred WebGL shader compilation (load averages were about 1.7–1.8 / 3.1–3.4 / 3.0–3.1). I am moving that decorative work behind a short post-paint delay and will rerun the comparison.
Finding: the new desktop anchor check failed after the production Playwright run: #setup-card center moved 127 px between setup steps (apps/tracer/test/onboarding.spec.ts:115). Non-input LayoutShift entries remained empty, so CLS alone missed the card movement. Investigating per-step bounds before changing the reservation.
Finding: clipboard rejection still displayed the copied tick. The production browser regression test failed against the previous helper at apps/tracer/test/onboarding.spec.ts:81 (data-done was present immediately after rejected writeText). Updating the shared primitive to confirm only after writeText resolves.
Client core step:
4844069ports setup identity, passkey, recovery acknowledgement, welcome, discoverable sign-in, shared motion modules and delayed canvas lifecycle. TypeScript check and production build pass; the current dist also passes the real Rust-router setup/login/PRF check. Final browser suite then reported first-paint p50/p99 66.8/279.5 ms setup and 66.2/93.7 ms sign-in (30 fresh surfaces, Linux 6.12.111 x86_64, 8 vCPUs; post-run load 3.56/1.94/1.99).Client browser evidence step:
828c592passes all four Playwright tests. The onboarding test covers the 400 ms count-up threshold, copy rejection/no tick, successful copy/download tick, welcome center ≤1 px, stable reserved card height, no non-input layout shifts, terminal handoff and canvas removal. Terminal probe: 500/500 keys, p50/p99 15.1/16.7 ms; resume 79.5 ms. Twelve production-build dark screenshots (393×852 and 1440×900) are in /home/kayg/Developer/infraternal/.worktrees/t-web/apps/tracer/test-results/onboarding-setup-recovery--906cd--match-the-browser-contract/: step-1-token-iphone-15.png, step-1-token-desktop.png, step-2-identity-iphone-15.png, step-2-identity-desktop.png, step-3-passkey-iphone-15.png, step-3-passkey-desktop.png, step-4-recovery-iphone-15.png, step-4-recovery-desktop.png, welcome-iphone-15.png, welcome-desktop.png, returning-sign-in-iphone-15.png, returning-sign-in-desktop.png.Server browser-integration step:
cab5c55updates the paired production browser check for username/display-name enrollment, recovery confirmation and authenticated session labels. Re-ran against t-web/apps/tracer/dist with the scratch-built Rust fixture: PASS (resident PRF setup, empty-storage discoverable login, DEK unwrap; Chromium 149.0.7827.55). The browser test verifies username=production_integration and display_name=Production integration in /auth/session.Finding: the required t-server fast gate stopped clippy on crates/infraternal-server/src/auth/http.rs::execute (109/100 lines) and src/auth/webauthn.rs::registration_finish (104/100 lines). The auth additions pushed both over the configured pedantic limit; splitting the added branches/helpers before retrying the gate.
Server lint follow-up:
6e5d956extracts the legacy/additive setup wire dispatch and proof/envelope validation before the existing writer-locked transaction. cargo fmt --all --check and cargo clippy --workspace --all-targets --locked -- -D warnings both pass. The disabled lint approach was rejected; uniqueness remains checked under the SQLite writer lock.Final t-server scripts/verify fast at
6e5d956passed. Rust summary output:\n+---------------------------+--------------+\n| Rust gate | Result |\n+---------------------------+--------------+\n| fmt | PASS |\n| clippy | PASS |\n| test | PASS |\n| cargo-deny | PASS |\n| static builds | PASS |\n+---------------------------+--------------+\n\nThe TypeScript protocol compiler passed, the Rust stream oracle built, and bun test reported 7 pass, 0 fail, 34,390 expectations across 2 files.Correction to the preceding gate note: its line breaks were escaped. Here is the exact t-server Rust summary from scripts/verify fast at
6e5d956:+---------------------------+--------------+
| Rust gate | Result |
+---------------------------+--------------+
| fmt | PASS |
| clippy | PASS |
| test | PASS |
| cargo-deny | PASS |
| static builds | PASS |
+---------------------------+--------------+
The TypeScript protocol compiler passed, the Rust stream oracle built, and bun test reported 7 pass, 0 fail, 34,390 expectations across 2 files.
Finished issue #32. Final heads:
75ffa9376e6e5d9563f3The required scripts/verify fast command passed in both worktrees. Verbatim t-web Rust summary:
+---------------------------+--------------+
| Rust gate | Result |
+---------------------------+--------------+
| fmt | PASS |
| clippy | PASS |
| test | PASS |
| cargo-deny | PASS |
| static builds | PASS |
+---------------------------+--------------+
Verbatim t-server Rust summary:
+---------------------------+--------------+
| Rust gate | Result |
+---------------------------+--------------+
| fmt | PASS |
| clippy | PASS |
| test | PASS |
| cargo-deny | PASS |
| static builds | PASS |
+---------------------------+--------------+
Both TypeScript fast subgates passed: 7 pass, 0 fail, 34,390 expectations across 2 files; differential coverage was 134 streams / 11,439 schedules with zero divergences. Tracer Playwright: 4 passed. Final real Rust-router browser check: PASS (resident PRF enrollment, recovery confirmation, discoverable login and DEK unwrap; Chromium 149.0.7827.55). The 12 dark viewport screenshots and their paths are recorded in the prior evidence comment.
Performance follow-up on Linux 6.12.111 x86_64, 8 vCPUs, post-run load 3.56/1.94/1.99: 30 fresh surfaces measured setup FCP p50/p99 66.8/279.5 ms and sign-in 66.2/93.7 ms. Against the
639ac27baseline, FCP medians rose 9.7/10.2 ms; setup p99 rose 191.7 ms. Screenshot upper bounds were 151.1/367.2 ms setup and 123/162 ms sign-in, below the existing 1,000 ms p99 gate. These are local desktop measurements, not phone, network or concurrent-user results.Starting the two setup-screen bug fixes after reading #32 and parent #21 history. Fast-forwarded t-web (
795acbba) and t-server (3721631) to deployed local dev base0c47cd42e6. Both worktrees are clean; no fix edits yet.Finding: the server exposes setup-start but no setup-check action. The new real HTTP route test is red on t-server at crates/infraternal-server/src/auth/tests.rs:2041: POST /auth/setup-check with a wrong token returns 400 (unknown action), expected 401. The test also covers valid 204 without consuming enrollment and 404 after owner creation.
Server endpoint step committed as
87f11da. The new real-router test passes (1 passed, 0 failed): wrong token → 401; valid token → 204 with no Set-Cookie, then real software-authenticator enrollment succeeds; after owner creation → 404. The initial red run returned 400 for the missing action.Auth contract step committed as
36b3c92. contracts/keywrap.md now documents additive POST /auth/setup-check, constant-time validation, 204/401/404, inherited admissions and no state/cookie/ceremony changes; existing setup-start and one-shot enrollment remain unchanged. Diff check passed.Finding: the new production-browser regression fails on deployed-base t-web. apps/tracer/test/onboarding.spec.ts:25 expects the step-1 heading after Continue with an invalid token; it is gone because the UI has advanced. The run used the production build and test double at TRACER_TEST_PORT=4432.
Finding: the production-browser alignment assertion is red at apps/tracer/test/onboarding.spec.ts:70. On the 393×852 viewport the primary button is 167 px from the card content edge (required ≤1 px); the test saved test-results/onboarding-setup-primary-b-f436d-t-edge-on-phone-and-desktop/attachments/step-1-button-iphone-15-51007fd88e55c51e42681be886cd31d380f68dd0.png. Cause: auth.css declares margin-left:auto before its later margin:0 shorthand, and the hidden back button is removed by the global hidden rule, leaving the footer’s sole item at flex start.
The red alignment regression now lives in its own module, apps/tracer/test/setup-layout.spec.ts:26. Re-running the deployed-base production build at 393×852 again measured a 167 px content-edge gap (limit 1 px); failure artifact: test-results/setup-layout-setup-primary-a4143-t-edge-on-phone-and-desktop/attachments/step-1-button-iphone-15-579aac54113a17d2486c32038382b3616ce2e632.png.
Client token-validation step committed as
7fe608f. TypeScript check passed; production-build Playwright passed (1/1) at port 4434. Wrong token stayed on step 1, count-up was hidden at 180 ms and visible after 480 ms, inline guidance appeared and focus returned to the token field; a correct token advanced to step 2. Screenshots: apps/tracer/test-results/onboarding-invalid-setup-t-ae0f0-tep-1-with-focused-guidance/step-1-wrong-token-iphone-15.png and step-1-wrong-token-desktop.png.Button alignment step committed as
1b737d7. The production-browser assertion passes at 393×852 and 1440×900: measured right inset is 0.000 px at each viewport (limit ≤1 px), 1 test passed. Screenshots: apps/tracer/test-results/setup-layout-setup-primary-a4143-t-edge-on-phone-and-desktop/step-1-button-iphone-15.png and step-1-button-desktop.png.Gate finding: first t-server scripts/verify fast stopped clippy on infraternal-server/src/auth/setup.rs:44 (pedantic items-after-statements) because the dummy digest const followed executable statements. The focused route test passed; I am moving the constant to module scope before rerunning the gate.
Clippy follow-up committed as
7918537. The dummy digest is at module scope; cargo fmt --all --check and cargo clippy --locked -p infraternal-server --all-targets -- -D warnings both pass. The full t-server gate will be rerun before completion.Server gate finding at
7918537: the second full scripts/verify fast run reached 60 passed, 1 failed, 4 ignored. Unrelated timing-sensitive test review3_backend_reply_has_a_deadline failed at crates/infraternal-server/src/auth/tests.rs:1503 with 'server closed websocket unexpectedly'; it passed in the earlier full run. Clippy and fmt passed; investigating the isolated test while static builds finish.Follow-up: the deadline case passed isolated (1/1, 60.45s): failure response at 60003ms, late backend success ignored, next Ping succeeded, terminal rows=0. This supports a parallel-suite timing interaction; rerunning the full server gate.
t-server gate passed at
7918537. Verbatim summary:\n| Rust gate | Result |\n|---------------------------|--------------|\n| fmt | PASS |\n| clippy | PASS |\n| test | PASS |\n| cargo-deny | PASS |\n| static builds | PASS |\nThe server library suite reported: test result: 61 passed; 0 failed; 4 ignored; 0 measured; 0 filtered out; finished in 151.81s. Static artifacts: x86_64 15071488 bytes, aarch64 12636216 bytes, PT_INTERP absent for both. TypeScript protocol tests: 7 pass, 0 fail; differential run: 134 streams, 11439 schedules, zero divergences.t-web gate passed at
1b737d7. Verbatim summary:\n| Rust gate | Result |\n|---------------------------|--------------|\n| fmt | PASS |\n| clippy | PASS |\n| test | PASS |\n| cargo-deny | PASS |\n| static builds | PASS |\nServer library: test result: 60 passed; 0 failed; 4 ignored; 0 measured; 0 filtered out; finished in 163.75s. Static artifacts: x86_64 15068128 bytes, aarch64 12632736 bytes, PT_INTERP absent for both. TypeScript protocol tests: 7 pass, 0 fail; differential run: 134 streams, 11439 schedules, zero divergences.Playwright finding at
1b737d7: required port-4421 full run completed 17/18 tests; terminal.spec.ts:264 still expected invalid setup token to advance to #setup-username and timed out at line 274 (30s). The new step-1 validation correctly prevented advancement. Updating the stale assertion to check the inline error and distinct passkey-cancel guidance, then rerunning the full suite on a fresh port.Client production-browser evidence at d51337b:
Wrong-token error state:
Step-1 primary button alignment:
Commit body formatting correction: the test-only change is now
56c3162(full SHA available in branch history); code is unchanged from the 18/18 Playwright run. This replaces the temporary d51337b hash in the screenshot evidence comment.Finished #32. No push or deploy.
Branch heads:
56c3162b4079185377b9nix shell nixpkgs#binutils nixpkgs#file nixpkgs#gnumake nixpkgs#perl -c scripts/verify fastpassed in both worktrees. Verbatim Rust gate summary:test result: ok. 61 passed; 0 failed; 4 ignored; 0 measured; 0 filtered out; finished in 151.81s; static x86_64 15071488 bytes and aarch64 12636216 bytes, PT_INTERP absent.test result: ok. 60 passed; 0 failed; 4 ignored; 0 measured; 0 filtered out; finished in 163.75s; static x86_64 15068128 bytes and aarch64 12632736 bytes, PT_INTERP absent.stream differential: 134 streams, 11439 schedules, zero divergences; 7 TypeScript protocol tests passed, 0 failed.The full Playwright run at port 4421 found one stale assertion expecting rejection at the passkey step. After updating that assertion, the complete suite passed at fresh port 4422:
18 passed (2.1m). Step-1 button inset was 0.000 px at both iPhone 15 (393×852) and desktop (1440×900). The wrong-token error and button screenshots are attached in the preceding evidence comment.Production-browser measurements: Linux 6.12.111 amd64, 8 vCPUs; load average at final review 1.76/4.58/8.68. The 500-key probe painted 500/500 echoes at p50/p99 15.40/16.10 ms (under the 20 ms gate), with 78.10 ms resume. Access render upper-bound p99 was 355.8 ms for setup and 144.2 ms for sign-in (under the 1,000 ms gate). The count-up test kept the indicator hidden at 180 ms and visible after 480 ms.
Reviewer checklist checked: status routing, owner identity and recovery acknowledgement, resident passkey/PRF flow, accessible icon controls, secret handling, and the attached phone/desktop screenshots.
Starting the sign-in cleanup and UI font switch on branch ui-tweaks at base
4daf8c0. The worktree is clean; changes stay in this worktree. I read #32 and parent #21 history.Test setup finding: the focused Playwright command could not start because apps/tracer has no installed playwright package (ERR_MODULE_NOT_FOUND at playwright.config.ts). Installing the checked-in frozen Bun dependencies before rerunning.
Baseline regression reproduced in the production browser: apps/tracer/test/onboarding.spec.ts fails because .auth-signin contains 2 buttons (expected 1); the second is #login-other, “use a different passkey…”. The failing check is at line 182 on port 4531. Removing that secondary path and rebalance styling next.
Fast-gate finding:
scripts/verify fastreached the Rust mouse integration test andfaithful_snapshot_preserves_public_mouse_encoder_reportsfailed at crates/infraternal-shim/tests/mouse.rs:18 (public mouse encoder probe failed; see t2-gate-public). The failure is outside the three UI files changed here; static builds are still running.Follow-up on the fast-gate failure: the native mouse test searches the workspace path target/debug/build for libghostty-vt.a, while this run correctly put Cargo output in the job cache. Its diagnostic is ValueError: no matching native archive. I will expose the cached target at the expected ignored target path for the retry; no source change is implicated.
Decision record proposal per owner request: update D98 so sign-in has one usernameless “Continue with passkey” button; its discoverable platform chooser lists every passkey for this site, so the separate “use a different passkey…” link is unnecessary. This supersedes D98’s earlier secondary-action sentence. I will record the owner change with today’s date.
Decision documentation committed:
d2ce17aupdates D98 per the owner request. Discoverable platform chooser lists every site passkey; the secondary link is removed from the decision. Fast gate has passed for the current code/test tree.Completed the sign-in source step:
84a3733removes the second passkey action and its duplicate ceremony state in apps/tracer/src/onboarding.ts. Fast gate exited 0; Rust server 66 passed, shim 61 passed, protocol 7 passed, static builds and cargo-deny passed.Completed the sign-in presentation step:
575eaecremoves the redundant link styling and rebalances the card at desktop and phone breakpoints. The fast gate above ran against this tree and exited 0.Completed the sign-in test step:
4892902asserts the four required welcome-card elements, exactly one button, and no #login-other. The focused production test passed earlier (1 passed, 15.4 s); the fast gate also passed on this tree.Finished on branch ui-tweaks at
ff505cb. D98 now matches the discoverable passkey flow; sign-in shows the mark, welcome, lede, and one passkey button. The full production Playwright suite passed (23 passed, 3.2m). No merge or deploy was performed.Final
scripts/verify fastoutput (verbatim summary):Closed by the orchestrator during the 2026-10-28 handover (#254), on the owner's request to close finished issues. Evidence: Sign-in/onboarding port merged as
56bb6f51d(in dev) with D98 updated ind2ce17a; tests and screenshots posted. Reopen if anything is still missing.kayg referenced this issue2026-10-28 17:53:54 +00:00