fuzz: host_name_parse found a failing input #353
Open
opened 2026-11-04 19:32:21 +00:00 by kayg
·
25 comments
No Branch/Tag specified
main
mesh-compat-382
j444b-d381-key-wins-flood
j470b-server-mesh-rejoin
j461b-macos-utun-reader-thread
j475b-remove-host-motion
fix-reconnect-new-link
j481-d380
dev
j479-mesh-soak
fix/j476-host-facts
j475-motion-pill-split
j470-mac-node-join
root-upgrade-d376
j474-review-merge
latency-targets-120hz
nightly-suite-shards
gotatun-pin-j469
macos-utun-reader-thread
fix-flood-echo-stall
wip/j416
motion-fast-ease-out
mesh-addhost-j259
takeover-close-terminals-d368
kbd-instant-followups
fix-trust-key-double-click
nightly-suite-partial-report
appwin-icons-j207
rusqlite-slice1
swipe-content-first-d374
mesh-mtu-381
addhost-instant-open
glass-contrast-d365-mock
glass-contrast-d365
signout-followups-442
fix-startup-toast-red
research-gotatun-matrix-j317
themes-sync-j304
fix-load-flakes
fix-nix-zig-patch
fix-compute01-browser-baseline
ratchet-size-baseline-419
predict-auto-d130
revoke-coverage-d367
nightly-suite-queue-timeout
nightly-browser-suite
fix-rustsec-2026-0459
fonts-ioskeley-obel
log-retention-d375
fix-kbd-no-anim-427
fix-dev-red-specs-2
takeover-proof-305-j205
wip/j410-server-pump
ui-consistency-d372
fix-osc52-clipboard
libghostty-vt-1.0
forget-retired-host-d369
j404-merge-426
fix-setup-lock-race
fix-touch-select-426
revoke-access-report-ui
fix-predictive-echo-specs
fix-selinux-agent-exec
wip/j395-checkpoint2
wip/j395
j391-review-scratch
ui-consistency-j195-deferred-rebased
fix-rustc-paths-421
decisions-wording-341
fix-install-suite-red
fix-dev-rtt-specs
fix-pending-removal-align
fix-privileged-skip
fix-install-suite-404
review-j368
mesh-dns-j254
revoke-access-report-d356b
revoke-privilege-round5
fix-removal-confirm
review-j360
gotatun-rotation-367
deps-refresh-340
review-j354
review-J351
review-j350
addhost-takeover-d359
revoke-report-items-347
revoke-end-sessions-d362
review-j348
size-mesh-ssh-346
size-trim-337
revoke-access-diff-d356
j259-pre-rebase-b06c5a6
j305-ended-at-start-spec
addhost-sudo-consent
fix-layout-real-specs-411
fix-shell-open-411
fix-console-hosts-373
fix-shell-exit
fuzz-host-name-353
fix-host-details-410
macos-filter-j197
research-gotatun-tricks
revoke-p3-j216l
stale-state-pill
revoke-followups-j216k
revoke-progress-j216e
backup/macos01-20261106/lume/j197
backup/macos01-20261106/lume/appwin-icons-j207-stash0
backup/macos01-20261106/claude/stash-0
backup/macos01-20261106/claude/stash-1
backup/macos01-20261106/claude/J80-macos-s1
backup/macos01-20261106/claude/J80
backup/macos01-20261106/claude/J80-slice1-20261102
backup/macos01-20261106/claude/J16b-appwin-on-dev
backup/macos01-20261106/claude/appwin-launch-idle-146
backup/macos01-20261106/claude/J80-s1-run
wip/j259
trust-285-p3c
runtime-lock-j216f
mesh-ssh-p3-j175
tun-proof-p3b
trust-285-p3
terminal-polish-j271
tun-proof-p3
ssh-install-flakes-j216i
fuzz-fixes-j264
trust-285-a
trust-285-b
restart-oversized-fixture-j198
backup/macos01-20261106/lume/appwin-icons-j207
restart-bound-j216h
up-preflight-p3-j198
backup/macos01-20261106/lume/j251
up-preflight-j198
wip/up-preflight-j198-j245-p2
wip/up-preflight-j198-j245-p1
agent-fsync-offloop-j196
wip/up-preflight-j198-j245
settings-offscreen-j231
wip/up-preflight-j198-j226-inspection
wip/j103f
themes-j206
wip/up-preflight-j198-j226
flakes-j216c
backup/macos01-20261106/claude/j197
flakes-j216b
backup/macos01-20261106/claude/j197-red
wip/up-preflight-j198-review
flakes-j216
backup/macos01-20261106/claude/appwin-icons-j207
engineering-j208b
appwin-mock-j209
toast-stack-j165
engineering-j208
decisions-d351
decisions-d350
decisions-d349
appearance-presets-mock-j129
decisions-d348
docs-audit-spec
doc-coverage-baseline-raise
decisions-d347
decisions-d346b
decisions-d346
j88h-profile
ui-consistency-j195-deferred
ui-consistency-j195
engineering-practices-j194
preferred-login-ui-j166
signin-pools-263-j174
macos-node-265-s1
decisions-d345
decisions-d344
proxy-cgroup-j164
verify-quick-fuzz-329
proxy-start-io-j168
timing-flakes-j163
up-263-s1
mcp-events-j147
verify-quick-fuzz-j158
proxy-p3-j159
agent-resource-j157-detect
wip/j103d-final
remote-cancel-hang-j155
proxy-traefik-281-j62d
j149-verify-quick
proxy-traefik-281-j62b
j150-drop-unnamed
wip/j79d-red-r4
wip/j103d-d332
rootless-toast-j142
wip/j103d-head
wip/j103d
j125c-mcp
macos-build-j136
backup/macos01-20261106/claude/j136
wip/j79d-red-cli
wip/j79d-red-server
j121-link-liveness
j118c-tracer-failures
wip/j79c-head
release-desktop-j131
j124c-signed-macos
wip/j79c-red-p3
wip/j79c-red-p23
wip/j79c-red-p22
merge-j128-check
perf-deferred-j128
sidebar-toggle-260
j127-shortcut-changed-dot
j125-mcp
j118-tracer-failures
j126-account-summary
settings-sections-mock-j92
j120-pinch-lock
sidebar-292
backup/macos01-20261106/claude/j120
taste-2026-11-03
row-actions-242-215
backup/macos01-20261106/claude/stash-0-untracked
backup/macos01-20261106/claude/J80-265-s1-run
backup/macos01-20261106/claude/J80-macos-s1-20261102
j112-canvas-commands
ui-no-overshoot-scroll
fix-recovery-restart
backup/macos01-20261106/claude/stash-1-untracked
taste-2026-11-02
size-baseline-ratchet
machine-cards-structure-j108
j109-boot-copy-mockups
fix-dev-red
wip/up-263-s1
j95b-settings-rows
proxy-traefik-281
j95-option-rows
docs-human-j91
docs-keys-palette
fix-flood-1013-270-j38d
mesh-ssh-s1
mesh-ssh-s0
addhost-d291-tunnel
test-stability-load
mesh-relay-220
repro-296
shim-thp-off-24
mesh-pins-258-v2
mesh-dns
signin-d311-merged
docs-pages
ui-size-283
fix-ui-batch-specs
wip/j12b-edge-update
gate-on-arm
fix-rename-sync-293
trust-285-j60b
fix-focus-ring-clip
integ-ui-1101
edge-update-v2
signin-d311
taste-2026-11-01
layout-per-tab-250
ui-approved-splitopt-224
ui-approved-splitopt-224-on-dev
icon-text-centre-282
ui-approved-189-212-216
research-reverse-proxy
transfer-budget-320
review-mesh-pins-258-r2
sidebar-pill-259
review-mesh-relay-220
wip/j12-edge-update-v2
nix-package
status-crash-loop-237
fix-dev-test-failures
fix-fixture-socket-path
wip/mesh-relay-220-pre-dev-advance-rebase
fix-canvas-side-clip
research-head-to-head
frosted-real-256
review-mesh-pins-258
wip/mesh-relay-220-pre-final-rebase
review-layout-per-tab-250-r2
broad-suite-triage
nix-devshell
review-status-crash-loop-237-r3
wip/nix-devshell-pre-p3
taste-frosted-real
wip/code-serve-demo-2026-10-30
wip/code-serve-glass-2026-10-30
wip/code-serve-clusters-2026-10-30
wip/code-merge-release94-dev-2026-10-30
wip/rproxy-delta-scratch-2026-10-30
wip/stale-note-257-staged-2026-10-30
wip/d241-size-staged-2026-10-30
review-broad-suite-207
wip/mesh-pins-258-pre-split
wip/mesh-relay-220-pre-rebase
mesh-measure-220
plan-211-update
review-edge-autoupdate-r3
perf24-reconnect
review-stale-note-r2
release-prod-live
d241-shell-marker
review-mesh-pins-server-258
review-revocation-r3
review-setup-token-r2
review-sync-journal-r3
wip/review-mesh-pins-258-prune-review-1995fee46
frosted-scroll-256
sync-journal-r3
revocation-per-account-wip
review-tokio-asyncfd-0386
review-sync-p3s
wip/stash-8by64-stash0-2026-10-30
mesh-drag-r2
setup-token-data-wip
release-9-4
auth-busy-1013
mesh-view-overlap
sync-p3s
review-auth-busy-wake
review-readd-r8-wip
mesh-drag-bounds
audit-auth-93
app-windows-stream-start
review-authority-cap-r3
app-windows-r7-measure
readd-minimal-r6
readd-minimal-r5
app-windows-r7-soak
readd-minimal-r4
app-windows-r7
app-windows-r6
readd-minimal-r3
readd-minimal-r2
readd-minimal
merge-release8-dev
review-busy-page-liveness-r2
review-busy-page-liveness
mesh-view-trim
review-authority-read-retry-r2
review-remove-uninstall-r2
release-retry-reattach
release-retry
review-remove-uninstall
review-authority-read-retry
app-windows-ship
mesh-autoswitch-p2
mesh-ssh
mesh-relay
mesh-macos-node
screen-and-control
session-labels
review-real-logins-r5
review-real-logins-r4
review-real-logins-r3
shim-memory-r2
review-real-logins-r2
shim-memory
shadow-addhost-instant
shadow-real-logins
shadow-same-session-flood
shadow-prod-perf-fix
hosts-from-server
app-windows-real
app-windows-transport
release-prod-6w
mesh-policy-verify
quiet-close-toast
dev-merge-r4
review-mesh-agent-transport
review-app-windows-transport
settings-roundtrip
review-release-pipeline-r4
mesh-agent-transport
ended-strip-fix
review-audit-ca-update-d244
settings-rows
phone-width
signout-clear
fix-restart-tests
dev-merge-rp
signer-hardening
review-audit-ca-update
terminal-fidelity
review-audit-ca-update-wip
mesh-integrate
review-mesh-agent-transport-515d3712
review-mesh-dataplane-feec1988
mesh-dataplane
signout
research-canvas-node
wip/review-renderer-cost
wip/review-terminal-fidelity
padlock-glyph
review-release-pipeline-2e95b689
phone-polish
sidebar-polish
inbox-generic
review-mesh-dataplane-378d4055
prod-batch
ui-inbox
ui-ca-unlock
ui-machine-sections
review-mesh-dataplane-a5f744fb
tls-session-prod
session-bounds-prod
fix-dead-session
session-bounds
tls-session
palette-polish
shortcuts-d222
research-appmeta
phone-gutter
ui-centre-button
wip/ui-centre-button
wip/tls-session
review-addhost-breakit
ui-platform
renderer-cost
remote-agents
mesh-api
ssh-bootstrap
prod-hotfix2
prod-fixes
review-remote-agents
review-mesh-dataplane
session-life
research-browser
review-mesh-api
research-capture
review-mesh-api-round3
review-mesh-api-round1
gate-stability
review-gate-stability
review-relay-direct
review-mesh-api-findings
proto-sessions
font-picker
proto-addhost
proto-windows
mesh-core
latency-gate
research-bsd
research-discovery
keytray-mods
mock-core
ui-tweaks
fix-motion-sel
fix-motion
integrate2
fix-robust
t-web
t-server
vt-ghostty
fix-snap-echo
t-web-auth
review-vt2
t-agent
lane-protocol
lane-shim
lane-auth
s1-base
s1-contracts
s1-workspace
No results found.
No labels
launch-qa
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set
Reference
kayg/infraternal#353
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Nightly parser fuzzing (D351, #344).
Target:
host_name_parseSource:
6ee12794de510c62907d1615bcdb935e0e364464Input SHA-256:
456fa477dd35a89e1bf6af9a8b7090428306c5b88df0a0abbe2b890548463445Reproduce with
cargo +nightly fuzz run host_name_parse <attached-input>. The exact failing input is attached to the report comment.Failing input for
host_name_parse, SHA-256456fa477dd35a89e1bf6af9a8b7090428306c5b88df0a0abbe2b890548463445.Context from J208c (#344): this is the first issue filed by the D351 nightly fuzz runner, during its install smoke run on dev-02 (36 s budget). The harness's idempotence assertion fails:
machine_name("0X.A-1")returnsSome("0x"), butmachine_name("0x")returnsNone(fuzz/fuzz_targets/host_name_parse.rs:24). The zip on comment 78870 holds the exact 6 bytes (0X.A-1). Reproduce: unzip it, thencargo +nightly fuzz run host_name_parse <file>. Not fixed in J208c.Failing input for
host_name_parsefrom source100bd91f6dd966b55409f0dd53dd9b3d468c359b, SHA-2562a8e8b6f0945d597d1c4fccce4bce1aa4f9353ab34b9a9b212a78b1545318641.Input (base64):
MFg0MC4yLhI=Failing input for
host_name_parsefrom source521cb8990b720ce751466d2eb81e5881b496bfda, SHA-256a16a2869969aeaa8f67d32acd6c12fb7eaa406ea55b6452a4054d30c00663a5b.Input (base64):
MFguADAxTi4SFailing input for
host_name_parsefrom source521cb8990b720ce751466d2eb81e5881b496bfda, SHA-256db0284ab184f9bcb70a9be0c4ae9fd821b49e761a42f012f13ee96ec69079f6f.Input (base64):
MFgyMjIyMi4SMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjI=J264 starting on branch
fuzz-fixes-j264, base159edcedc9978f0370ea8cb02a937082d631c9b6(origin/dev). Plan: reproduce every reported input on a build VM, add failing regression coverage, fix the demonstrated cause, run each target for 600 seconds, runscripts/verify quickthrough build-slot in the foreground, and push one atomic commit per issue. Estimate: 90 minutes including compilation/slot queues; no merge, deploy, or issue closure.J264b (taking over from J264): finding, reproduced, fix pushed.
Failure type: the target's oracle disagrees. The idempotence assertion
machine_name(name) == Some(name)atfuzz/fuzz_targets/host_name_parse.rs:24panics. There's no overflow and no timeout. All four filed inputs reproduce against the nightly's ownhost_name_parsebinary on dev-02, built from521cb8990:0X.A-1Some("0x")None0X40.2.\x12Some("0x40")None0X.\x0001N.\x12Some("0x")None0X22222.\x12+ 29×2Some("0x22222")NoneThere are two causes in
crates/infraternal-plugin-api/src/host_name.rs:is_ipv4_spellingcounts a bare0x/0X(no digits) as a hex number. glibc'sinet_atonrejects it. On dev-02, Python'ssocket.inet_atonrejects'0x','0X'and'0x.1', and accepts'0x40'→00000040and'0x22222'→00022222.0x40) is returned from a multi-label host, but on its own it's an address.Fix (
f839112baonfuzz-fixes-j264):is_ipv4_spelling(label)holds, which also covers the old digits-only rule.After this, a returned label passes every check the second call makes, so idempotence holds by construction. One side effect for callers (mesh store, remote inventory): a host such as
0x40.lannow gets the D339 fallback name instead of "0x40".Regression:
host_name_tests::fuzz_inputs_from_353_are_idempotentholds the exact bytes (hashes checked against the table above), next tonumeric_first_labels_give_no_name_but_a_bare_hex_prefix_does. On compute01,cargo test -p infraternal-plugin-api --lib host_name:test result: FAILED. 7 passed; 2 failed(left: None, right: Some("0x")andleft: Some("0x40"), right: None)test result: ok. 9 passed; 0 failedLogs: compute01
~/.cache/codex-scratch/j264b/353-red.logand353-green.log. Nightly-binary replay: dev-02/tmp/j264b-353/. The 600 s fuzz run follows.J264b progress:
fuzz-fixes-j264now hasf839112ba(#353 parser fix) andb1e8d164e(#370 runner fix), both pushed.FAILED (errors=2)withAttributeError: ... no attribute 'confirmed_inputs'. After,Ran 13 tests ... OK(~/.cache/codex-scratch/j264b/370-{red,green}.log).host_name_parseand 600 s ofssh_auth_once_decode, seeded from copies of the nightly corpora (~/.cache/codex-scratch/j264b/fuzz-run1.log).scripts/verify quick(~/.cache/codex-scratch/j264b/verify-quick.log).J264b finish.
Branch
fuzz-fixes-j264, headd1450e1a0b. It has two commits on base159edcedc:271913dc0fix(plugin-api): machine_name refuses numeric first labels, accepts bare 0x (#353)d1450e1a0fix(fuzz): re-check timeouts in isolation before filing them (#370). This also covers #374 and #358.I have not merged, deployed or closed anything.
Gate:
scripts/verify quickthrough build-slot on compute01 atd1450e1a0(~/.cache/codex-scratch/j264b/verify-quick2.log), verbatim:b1e8d164efailed only onfmt(oneassert_eq!in the #353 test). I folded the fix into the #353 commit and force-with-lease pushed the branch, so each commit passes the gate.quickscoped onlyinfraternal-plugin-api. The runner's Python tests (thenightly fuzz reporterrow, infast) passed separately on compute01:Ran 13 tests ... OK(370-green.log). The scripts are byte-identical betweenb1e8d164eandd1450e1a0.scripts/verify fast.Fuzz runs: one batched build on dev-02, with the nightly's own toolchain (rustc 1.101.0-nightly 708c94ef0, cargo-fuzz 0.13.2, ASan) and its flags (
-timeout=10 -rss_limit_mb=2048 -max_len=1048580), seeded from copies of the nightly corpora. 600 s per target:Logs on dev-02:
~/.cache/codex-scratch/j264b/fuzz-run1.log,fuzz-run2.logandfuzz-<target>.log.Runner re-check, per input (
fuzz-run2.log). I called the runner's ownconfirmed_inputs()with the exactcargo fuzz run <target> <input> -- -timeout=10 -rss_limit_mb=2048 -artifact_prefix=...command thatmain()builds, on copies of the nightly's four timeout artifacts:On the fixed build, the four #353 inputs replay with rc=0 (
Executed … in 31/5/1/5 ms).Once this merges and the nightly checkout moves to it, its first run re-checks the four timeout artifacts still in the nightly's artifact directory and moves them to
unconfirmed/. These issues can then be closed by the owner.J274 review of
fuzz-fixes-j264@d1450e1a0(base159edcedc): in progress.271913dc0): differential check against glibcinet_atonover all 5 229 071 strings up to 6 chars from0189xXafg.-@:, plus 28 hand cases. 0 failures. Log: dev-02~/.cache/codex-scratch/j274/hn_check.log.d1450e1a0): mutation check ofscripts/test-nightly-fuzz.py. Summary: compute01~/.cache/codex-scratch/j274/mut/summary.txt.host_name_parserun from an empty corpus. It's queued in build-slot on dev-02 (~/.cache/codex-scratch/j274/fuzz-run.log). The verdict follows.J274 review of
fuzz-fixes-j264@d1450e1a0b(base159edcedc). This covers #353, #370, #374 and #358.Verdict: REQUEST CHANGES
The parser commit
271913dc0is approved as is. The changes requested are only in the runner commitd1450e1a0: two P2s.I did not run
verify fastorverify quick(reviewer rule). I read the author's quick output in 81353.1.
271913dc0, the host-name parser (#353): approveAgainst
inet_aton. I included the branch'shost_name.rsbyte for byte in a harness and compared it with glibcinet_atonthrough FFI. It enumerated all 5 229 071 strings up to 6 chars over0189xXafg.-@:, which covers decimal, octal, hex, 1 to 5 parts, empty parts, trailing dots, users, ports and IPv6-style colons. It also ran 28 hand cases (0x100000000,1.2.3.256,089.1.2.3,1.2.3.4 junk,0xdeadbeef.lan,a-0x40.lan,deadbeef, and so on). Three properties were checked on every string:machine_name(s)=Some(n)⇒machine_name(n)=Some(n)inet_atonon its owninet_atonaccepts never gives a nameLog: dev-02
~/.cache/codex-scratch/j274/hn_check.log. The harness ishn_check.rsnext to it.@,:,[,%,.or whitespace. On the second call it is therefore the whole host, andis_ipv4_spelling(host)andis_ipv4_spelling(label)are the same check the first call already passed. Every other check is idempotent on[a-z0-9-].inet_atonaddress is numeric, so its first label is refused (third row above).0x<hex digits>.0x40were returned,ssh 0x40would go to 0.0.0.64.08,0009), which the old rule already refused. The other is hex labels too large for 32 bits (0x100000000), which is new and harmless.0xygen,0x1g,deadbeefanda-0x40stay names.0x40.langetting the D339 fallback is acceptable. The function also takes addresses (root@0x40is an address), so the bare label must be refused, and then idempotence forces refusing it as a first label.10.lanalready worked this way.localhostfall back. Refusing numeric first labels predates this branch, so I'm only mentioning it.0xnow being a name follows glibc, musl and BSDinet_aton. The WHATWG URL parser is the exception: it readshttp://0x/as 0.0.0.0. Callers (remote_inventory.rs:173,mesh/src/store.rs:288) use the name as a label, not as a bare URL host, so this is not a finding.-timeout=10 -rss_limit_mb=2048 -max_len=1048580):Done 578382211 runs in 601 second(s), rc=0, 0 artifacts, peak RSS 29 MB, corpus 281 units / cov 136.host_name.rsandfuzz_targets/host_name_parse.rsbody in a standalone crate (libfuzzer-sys =0.4.13). It used cargo-fuzz's-s nonesancov flags plus debug assertions and overflow checks, without ASan. ASan adds nothing for this safe-Rust assertion oracle.~/.cache/codex-scratch/j274/fuzz-host_name_parse.logandfuzz-run.log.0xand0x40cases) are good.2.
d1450e1a0, the nightly runner (#370, #374, #358): request changesWhat's right:
confirmed_inputstouches only names starting withtimeout-. The order (sorted) andreport_crashare unchanged.P2-1: the tests don't cover the code that can drop a real hang
I mutated
nightly-fuzz.pyatd1450e1a0and rantest-nightly-fuzz.pyagainst each version (compute01~/.cache/codex-scratch/j274/mut/summary.txt, one log per mutant). The one error that appears in every run, baseline included (test_existing_targets_and_budget, needsfuzz/Cargo.toml), comes from my scratch layout, not the branch.returncode == 0), so every real hang is set aside-timeoutremoved from the re-check commandconfirmed_inputsnot wired intomain()(crashes = before)The two new tests check
confirmed_inputswith a stubbedreproduces. Their red was "the function doesn't exist", which proves little. The rule "non-zero counts as reproduced" is the part whose failure loses real hangs, and it sits in an untested closure insidemain().Requested:
reproducesto module level, taking the runner as a parameter (defaultsubprocess.run).-timeout={TIMEOUT_SECONDS}and the input path, and must not carry-max_total_time.P2-2: a slow but real input under the bar is set aside permanently
The re-check uses the same 10 s bar and runs once.
Take an input that runs in about 7–9 s alone, for example quadratic work on a near-1 MiB input. Under load it trips 10 s and gets written as
timeout-*. On its own it passes, so it moves tounconfirmed/and is never re-checked. Before this commit it was filed.That's a real performance bug (CLAUDE.md priority 1), and its only trace is a log line. libFuzzer already prints
Executed <input> in N msfor the re-check, into the same log.Requested: count the re-check as reproduced when it fails or when it ran for at least
TIMEOUT_SECONDS/2. One option is to parseExecuted … in N ms; another is to re-check with-timeout={TIMEOUT_SECONDS//2}.On intermittent hangs: this runner's targets are deterministic for a given input. A timeout that needs state built up by earlier inputs in the same process can't be reproduced from the filed input anyway. Keeping it in
unconfirmed/is a reasonable outcome, as long as P2-2 stops the slow-input case from going there.P3 (do now or in a follow-up)
foundis computed before the re-check, so a set-aside timeout still counts innew_inputsand inFUZZ_DONE new_inputs=. A libFuzzer timeout also ends that target's run, so with #370's opening-call stall the target fuzzed for about 10 s instead of its budget, and the night now reportsfailed=Falsewith no issue filed. Subtract the unconfirmed inputs fromfound, and flagcut_short(secondswell under the budget) inlast-run.jsonso lost coverage shows up.state/recheck/<target>/keeps growing. It collects the re-check's own artifacts and is never cleaned. Clear it before each re-check.slow-unit-*artifact (libFuzzer writes one when a unit runs ≥10 s but the alarm hasn't fired yet) is just as load-dependent and still goes straight to filing. It's outside this slice.Evidence: dev-02
~/.cache/codex-scratch/j274/(hn_check.log,hn_check.rs,fuzz-host_name_parse.log,fuzz-run.log) and compute01~/.cache/codex-scratch/j274/mut/(summary.txt, per-mutant logs). Build targets deleted. Nothing merged, pushed or closed.J264b round 2 finish: J274's runner findings (81439) are addressed on the new branch
fuzz-runner-recheck, head0fc6934ede, based on origin/dev431441d53. The parser fix is already merged as431441d53. Nothing merged, deployed or closed.Commits, one per item, each pushed as it was made:
e57e2fb4f:d1450e1a0carried over unchanged ("re-check timeouts in isolation before filing them").bab8e2f94(P2-1):Fuzzer(injectablerun),recheck_flags,reproducesandrun_targetare now module level, andmain()callsrun_targetper harness. AFakeLibFuzzerplays cargo-fuzz in the tests. It covers:-timeout=TIMEOUT_SECONDSand the input, and no-max_total_time;run_targetend to end, in both directions.b124595aa(P2-2):reproducesreads libFuzzer'sExecuted <input> in N msfrom its own part of the log. It files the input on a non-zero exit, on ≥ 5000 ms (TIMEOUT_SECONDS*1000//2), or when no time was reported. I did not use-timeout=5: libFuzzer's alarm only checks every timeout/2+1 s, so a unit just over 5 s could pass unflagged.0fc6934ed(P3):new_inputsorFUZZ_DONE new_inputs=;cut_short_by_timeoutin last-run.json, the per-target line saysCUT_SHORT_BY_TIMEOUT after Ns, and FUZZ_DONE gainscut_short=N;recheck/<target>/is cleared before each re-check and removed after it.J274's mutants (M1–M3), red on every commit from 2 onward (compute01
~/.cache/codex-scratch/j264b/mut-c2,mut-c3,mut-c4; runnermutants.sh):bab8e2f94)b124595aa)0fc6934ed)-timeoutcrashes = before)Reds before each fix come from behaviour, not missing names:
FAILED (failures=3):False != True : 5000and[] != ['timeout-slow'](the 6 s input not filed).FAILED (failures=2, errors=2):2 != 1(new_inputs);['timeout-old'] != [](stale recheck/);cut_short_by_timeoutfield.Real-environment proof (dev-02, one slot run,
~/.cache/codex-scratch/j264b/prove-r2.log):reproduces()with a realFuzzer, i.e. realcargo fuzz runwith the nightly toolchain and ASan.slow6.Python tests at head (compute01,
py-r2-head.log):Ran 22 tests in 9.695s/OK.Gate:
scripts/verify quickthrough build-slot on compute01 at0fc6934ed(verify-quick-r2.log), verbatim:Only scripts changed, so quick scoped no Rust package; the Python suite above is the relevant test. As tasked,
verify fastwas not run.Out of scope (J274's note):
slow-unit-*artifacts are still filed without a re-check.J283 review of
fuzz-runner-recheck@0fc6934ede(base dev431441d53). Scope: the runner changes for #370, #374 and #358 that answer J274 (81439), as reported by J264b (81484).Verdict: APPROVE
No P0, P1 or P2 findings. There are three P3 notes below; none blocks the merge. As the reviewer rule says, I did not run
verify fastorverify quick. I read J264b's quick output in 81484.1. Mutations: every mutant fails the suite
My own mutants, applied to a detached worktree at
0fc6934edon compute01, each run withpython3 scripts/test-nightly-fuzz.py. Evidence is in compute01~/.cache/codex-scratch/j283/mut/(summary.txt, plus one.pyand one.logper mutant).returncode == 0-timeoutin the re-checkcrashes = beforereturncode != 0only)>=changed to>at 5000 msrecheck/not cleared firstThe tests now fail on wrong behaviour, not on a missing name.
2. Can a real hang be dropped?
I called the branch's real
reproduces()with a runner that writes chosen libFuzzer output and exit codes. Evidence: compute01~/.cache/codex-scratch/j283/edge-cases.log.Executedline missing or malformed: the input is filed, becauseexecuted_msreturns None. The regex needs this exact input path and an integer count of ms. Only the re-check's own part of the log is read, from the recorded offset, so a line from the fuzz run or from an earlier re-check can't match.!= 0. That holds even when theExecutedline came first.in, so ASan text can't produce a false "fast" reading.unconfirmed/and logged, and it shows inunconfirmedandcut_short_by_timeoutin last-run.json. If fuzzing finds it again on a later loaded night, it is re-checked again, because its name is a content hash.prove-r2.log) shows realcargo fuzzoutput in the form the parser expects: the four nightly artifacts ran in 0–4 ms and were set aside, and the 6001 ms input was filed. That is the real-binary half of the claim.3. Crash inputs and
slow-unit-*report_crashandwritten_inputsare untouched in the diff.confirmed_inputsonly acts on names that start withtimeout-, and it keeps the sorted order. Crash inputs are therefore filed exactly as before.test_timeout_that_does_not_recur_is_not_filedasserts that crashes skip the re-check.slow-unit-*doesn't matchtimeout-, so it is still filed directly, with no re-check. That is unchanged and out of scope, as J274 noted.4. Python suite at head
compute01,
~/.cache/codex-scratch/j283/py-suite-head.log:P3 notes (none blocks the merge; a follow-up is fine)
report_crashreturns early onattachedand leaves the artifact inartifacts/<target>/. Each filed real hang therefore costs a cargo-fuzz start plus about 10 s every night until someone removes it. That is bounded and small next to a 3600 s budget, but it grows with the number of open hangs. One fix is to skip the re-check when the report record already hasattached.unconfirmed/and the upload doesn't resume. Inputs up to 1 KiB are inline in the comment, so this only matters for larger ones. Rare.confirmed_inputssays "a re-check that cannot run at all counts as reproduced". That holds for a non-zero exit. AnOSErrorraised bysubprocess.runitself, for example a missingrustup, propagates and stops the night. The input stays inartifacts/, so nothing is dropped, but the sentence should say "exits non-zero".Evidence: compute01
~/.cache/codex-scratch/j283/(mut/summary.txt, the per-mutant.pyand.logfiles,edge-cases.log,py-suite-head.log). The VM worktree has been removed, and no build target was created. Nothing was merged, pushed or closed.Orchestrator: both #353 fixes are on dev.
271913dc0is merged as431441d53.fuzz-runner-recheck0fc6934ed) is merged as864e66cd1, after J283 approved it (81499).#370, #374 and #358 stay open until the first nightly run on
864e66cd1or later sets their four inputs aside. I'll close them then, citing the run.J283's three P3s are not done yet:
confirmed_inputsdocstring overstates what happens on an OSError.Failing input for
host_name_parsefrom source521cb8990b720ce751466d2eb81e5881b496bfda, SHA-256346a490816e47e98ecf15a08234e806fbf057650c406096089ebde756fec4342.Input (base64):
MFguLi4uLi4uLi4uLi4uLi4uLgAAAAAwLTAwLTA=J333 start: branch
fuzz-host-name-353, basefba745051(origin/dev). Plan: replay comment 82929 exact bytes with the real cargo-fuzz harness on current dev and521cb8990via compute01 build-slot; retain a unit regression and corpus seed; audit nightly source selection and fix stale selection separately; run quick and fast, push atomic commits. Estimate: 90 minutes including shared slot queues. No merge, deployment, or issue closure.J333b start, taking over from J333 (83059). J333 pushed nothing. Its worktree is clean at origin/dev, so I continue on the same branch.
fuzz-host-name-353, basefba745051(origin/dev)0X+ 17×.+ 4×NUL +0-00-0. SHA-256346a4908…4342checked.Plan (about 90 min):
cargo fuzz run host_name_parse <file>on compute01 through build-slot, both onfba745051and on521cb8990.0xclass that48d2388a7fixed (merged as431441d53). If so, add the input to afuzz/corpus/host_name_parseseed and add a unit regression. If dev still fails, write a red test and then fix the parser.verify quick, thenverify fast, on compute01.Finding 1, already confirmed: the nightly fuzzes a stale head. dev-02
/var/lib/infraternal-fuzz/checkoutis at521cb8990(2026-11-05 10:45 UTC). The run that filed 82929 loggedFUZZ_DONE targets=36 new_inputs=1 failed=False head=521cb8990…at 2026-11-06 21:31 UTC (journal). The cause:install-nightly-fuzzpins the checkout to--ref, and nothing moves it after install. So neither431441d53(parser) nor864e66cd1(runner re-check) has been fuzzed yet. #370, #374 and #358 can't be closed from a nightly run until this changes.J333b, finding 1 fixed (stale nightly source):
661a4eb2donfuzz-host-name-353, pushed.Cause:
install-nightly-fuzzdetaches the fuzz account's checkout at--ref, and only a reinstall moves it (PROCESS §12). Nobody reinstalled after431441d53or864e66cd1merged, so dev-02 kept fuzzing521cb8990.Fix:
scripts/nightly-fuzz-service, the root helper, takes its slot as before. Then it runs these steps as the fuzz account, through setpriv:git -C checkout fetch --quiet origin devgit -C checkout checkout --quiet --force --detach FETCH_HEADIf step 1 or 2 fails, the night exits 1 and fuzzes nothing, so no report can carry an old head. No repository code runs as root. The token still meets only reviewed code, because only the orchestrator merges into dev. The installer docstring and PROCESS §12 now say this.
Rejected:
nightly-fuzz.pyupdate its own checkout. The running code would update itself.Red/green (compute01, plain
python3 scripts/test-nightly-fuzz.py):evidence/py-red.log).661a4eb2d(evidence/py-green.log).Logs are under compute01
~/.cache/codex-scratch/j333b/evidence/.Needed after merge (orchestrator, not done by me): the root helper is a fixed copy, so this takes effect only after one reinstall on dev-02:
The token is already in place. After that, every night fuzzes the current dev head.
J333b progress: both commits are pushed (head
661a4eb2d).Two runs are waiting in compute01's build-slot queue: 5 slots busy, 20 runs queued.
fba745051and on521cb8990: queue position 12, script~/j333b/replay.sh, log~/.cache/codex-scratch/j333b/evidence/replay.log;verify quick, thenverify fast. Queue position 16, script~/j333b/gate.sh, logevidence/gate.log.I'm polling in the foreground. The results follow.
J333b, finding 2: 82929 is already fixed on dev, by
48d2388a7(merged as431441d53). It was filed only because the nightly's checkout was stale (finding 1).Replay with the real harness. compute01, one build-slot run (
~/j333b/replay.sh). It uses the runner's own command shape:rustup run nightly cargo fuzz run --fuzz-dir fuzz --features <union of required-features> host_name_parse <input> -- -timeout=10 -rss_limit_mb=2048;CARGO_PROFILE_RELEASE_LTO=false, in the flake dev shell;The input file's SHA-256 is
346a4908…4342, as filed. Key lines fromevidence/replay.log:Cause on
521cb8990:0X+ 17×.+ 4×NUL +0-00-0.0xis returned.is_ipv4_spellingaccepted a bare0xas a hex number, somachine_name("0x")returnedNone.0xclass from J264b's 80602, cause 1.48d2388a7requires a hex part to have at least one digit.Which commit fixed it:
git log 521cb8990..fba745051 -- host_name.rs fuzz_targets/host_name_parse.rslists only48d2388a7.host_name.rsis unchanged from48d2388a7to dev.Kept as a regression (
7fea2187b):fuzz_input_82929_from_353_is_idempotent, with the exact 29 bytes;fuzz/corpus/host_name_parse/issue-353-82929, which the nightly copies into its corpus.Next: the unit red/green against the pre-48d2388a7 parser, then
verify quickandverify fast. They're queued in one slot run (evidence/gate.log).J333b, gate progress at head
661a4eb2d. Everything ran on compute01 in one build-slot run (~/j333b/gate.sh, logs in~/.cache/codex-scratch/j333b/evidence/).Unit red/green for the 82929 test:
unit-red.log): this branch's tests againsthost_name.rsfrom48d2388a7^, the parser before the bare-0xfix:unit-green.log,cargo test -p infraternal-plugin-api --lib host_name):test result: ok. 10 passed; 0 failed.verify quick(verify-quick.log): passed, all 10 rows PASS.verify fast(verify-fast.log): exit 1, with two rows failing, verbatim:Neither failure involves this diff. The diff is one plugin-api unit test, a seed file,
.gitattributes, the fuzz scripts and docs.probe release exclusion: the shim's native build hit the disk limit:compute01 then had about 45G free under heavy shared load.
test: one test failed,agent_daemon::real_binary_rootless_cleanup_survives_sender_disconnect_before_readiness; the other 10 in that file passed.terminal.login.revokereturnedresource_unavailable(agent_fixture.py:702). No Rust code that test builds differs from origin/dev: the only Rust change is a#[cfg(test)]test in plugin-api.Rerun queued (position 24,
~/j333b/rerun.sh,evidence/rerun.log), in the same target dir:agent_daemon;scripts/test-runtime-probe-gating.py.Static builds PASS. No shipped code changed, so the delta against origin/dev is 0 by construction. The row's own figures are against the old D243 baseline:
J333b finish. Branch
fuzz-host-name-353, head661a4eb2d208299052dfac2abff98abd3816ea3f, base origin/devfba745051, which hasn't moved since. I have not merged, deployed or closed anything.Commits:
7fea2187btest(plugin-api): keeps 82929 as a unit test and a seed infuzz/corpus/host_name_parse/.661a4eb2dfix(fuzz): every night fuzzes the current dev head, not the install's pinned commit.Outcome:
521cb8990and passes on dev under the real cargo-fuzz harness (83216). It was fixed by48d2388a7, merged as431441d53.661a4eb2d(83087). It takes effect after one reinstall on dev-02, see below.Gate,
scripts/verify quick, compute01 through build-slot (evidence/verify-quick.log), verbatim:Gate,
scripts/verify fast, compute01 through build-slot (evidence/verify-fast.log), verbatim:The two FAIL rows don't come from this branch. I reran them in the same target dir, at the same head, one slot run (
evidence/rerun.log), verbatim:probe release exclusion: the first run hitNo space left on devicein the shim's native build. The rerun printsruntime_probe import rejected (E0432)andprobe consumer compiled(rerun-probe.log).test: the failure was a one-offresource_unavailableinreal_binary_rootless_cleanup_survives_sender_disconnect_before_readiness, while compute01 was heavily loaded. On rerun it passed 3 of 3, and all 11agent_daemontests passed. That binary contains no code from this branch.Static size: no shipped code changed, so the binary is unchanged from origin/dev. The row's own report-only figures are against the old D243 baseline:
Real-environment evidence:
cargo fuzz run host_name_parsewith ASan and the runner's flags. Onfba745051:Executed … in 1 ms, rc 0. On521cb8990: thehost_name_parse.rs:24panic,left: None, right: Some("0x"), rc 1.521cb8990, and the 20:32 UTC night's journal loggedhead=521cb8990….Evidence is on compute01 under
~/.cache/codex-scratch/j333b/evidence/:replay.log, inputinput-346a4908;unit-red.log,unit-green.log;py-red.log,py-green.log;verify-quick.log,verify-fast.log;rerun*.log.The target dirs and the scratch toolchain are deleted, and the VM worktrees are removed.
For the orchestrator after merge:
sudo scripts/install-nightly-fuzz --ref <merged dev head>from the meshtest account. The token is already there. Until then, every night still fuzzes521cb8990and keeps refiling inputs that are already fixed.For kayg:
661a4eb2dchanges PROCESS §12. Before, moving the checkout needed an explicit reinstall. Now it followsdev. The token still meets only reviewed code, because only the orchestrator merges into dev. It's reversible: revert the commit and reinstall.Failing input for
host_name_parsefrom source521cb8990b720ce751466d2eb81e5881b496bfda, SHA-256015944122b528c26764dea3d7064192557fdba221a381309c3afc49cf98c715e.Input (base64):
MFgwLgEOMC03Nzc3Nzc3Nzc3Nzc3Nzc3Nzc3Nzc3Nzc3Failing input for
host_name_parsefrom source521cb8990b720ce751466d2eb81e5881b496bfda, SHA-2565f9c779661bee94681587b03132268287f3291a7baacc55280f2a045ca94a4e1.Input (base64):
MFguMVg=Failing input for
host_name_parsefrom source521cb8990b720ce751466d2eb81e5881b496bfda, SHA-25644753430920fe8f545d4814cabaab724f2add90547a0bf788b3d8758361b2114.Input (base64):
MFguWA==