Terminal text squished vertically: renderer cell metrics #84
Closed
opened 2026-10-07 14:19:24 +00:00 by kayg
·
17 comments
No Branch/Tag specified
main
j470b-server-mesh-rejoin
mesh-compat-382
j444b-d381-key-wins-flood
j461b-macos-utun-reader-thread
j475b-remove-host-motion
fix-reconnect-new-link
j481-d380
dev
j479-mesh-soak
fix/j476-host-facts
j475-motion-pill-split
j470-mac-node-join
root-upgrade-d376
j474-review-merge
latency-targets-120hz
nightly-suite-shards
gotatun-pin-j469
macos-utun-reader-thread
fix-flood-echo-stall
wip/j416
motion-fast-ease-out
mesh-addhost-j259
takeover-close-terminals-d368
kbd-instant-followups
fix-trust-key-double-click
nightly-suite-partial-report
appwin-icons-j207
rusqlite-slice1
swipe-content-first-d374
mesh-mtu-381
addhost-instant-open
glass-contrast-d365-mock
glass-contrast-d365
signout-followups-442
fix-startup-toast-red
research-gotatun-matrix-j317
themes-sync-j304
fix-load-flakes
fix-nix-zig-patch
fix-compute01-browser-baseline
ratchet-size-baseline-419
predict-auto-d130
revoke-coverage-d367
nightly-suite-queue-timeout
nightly-browser-suite
fix-rustsec-2026-0459
fonts-ioskeley-obel
log-retention-d375
fix-kbd-no-anim-427
fix-dev-red-specs-2
takeover-proof-305-j205
wip/j410-server-pump
ui-consistency-d372
fix-osc52-clipboard
libghostty-vt-1.0
forget-retired-host-d369
j404-merge-426
fix-setup-lock-race
fix-touch-select-426
revoke-access-report-ui
fix-predictive-echo-specs
fix-selinux-agent-exec
wip/j395-checkpoint2
wip/j395
j391-review-scratch
ui-consistency-j195-deferred-rebased
fix-rustc-paths-421
decisions-wording-341
fix-install-suite-red
fix-dev-rtt-specs
fix-pending-removal-align
fix-privileged-skip
fix-install-suite-404
review-j368
mesh-dns-j254
revoke-access-report-d356b
revoke-privilege-round5
fix-removal-confirm
review-j360
gotatun-rotation-367
deps-refresh-340
review-j354
review-J351
review-j350
addhost-takeover-d359
revoke-report-items-347
revoke-end-sessions-d362
review-j348
size-mesh-ssh-346
size-trim-337
revoke-access-diff-d356
j259-pre-rebase-b06c5a6
j305-ended-at-start-spec
addhost-sudo-consent
fix-layout-real-specs-411
fix-shell-open-411
fix-console-hosts-373
fix-shell-exit
fuzz-host-name-353
fix-host-details-410
macos-filter-j197
research-gotatun-tricks
revoke-p3-j216l
stale-state-pill
revoke-followups-j216k
revoke-progress-j216e
backup/macos01-20261106/lume/j197
backup/macos01-20261106/lume/appwin-icons-j207-stash0
backup/macos01-20261106/claude/stash-0
backup/macos01-20261106/claude/stash-1
backup/macos01-20261106/claude/J80-macos-s1
backup/macos01-20261106/claude/J80
backup/macos01-20261106/claude/J80-slice1-20261102
backup/macos01-20261106/claude/J16b-appwin-on-dev
backup/macos01-20261106/claude/appwin-launch-idle-146
backup/macos01-20261106/claude/J80-s1-run
wip/j259
trust-285-p3c
runtime-lock-j216f
mesh-ssh-p3-j175
tun-proof-p3b
trust-285-p3
terminal-polish-j271
tun-proof-p3
ssh-install-flakes-j216i
fuzz-fixes-j264
trust-285-a
trust-285-b
restart-oversized-fixture-j198
backup/macos01-20261106/lume/appwin-icons-j207
restart-bound-j216h
up-preflight-p3-j198
backup/macos01-20261106/lume/j251
up-preflight-j198
wip/up-preflight-j198-j245-p2
wip/up-preflight-j198-j245-p1
agent-fsync-offloop-j196
wip/up-preflight-j198-j245
settings-offscreen-j231
wip/up-preflight-j198-j226-inspection
wip/j103f
themes-j206
wip/up-preflight-j198-j226
flakes-j216c
backup/macos01-20261106/claude/j197
flakes-j216b
backup/macos01-20261106/claude/j197-red
wip/up-preflight-j198-review
flakes-j216
backup/macos01-20261106/claude/appwin-icons-j207
engineering-j208b
appwin-mock-j209
toast-stack-j165
engineering-j208
decisions-d351
decisions-d350
decisions-d349
appearance-presets-mock-j129
decisions-d348
docs-audit-spec
doc-coverage-baseline-raise
decisions-d347
decisions-d346b
decisions-d346
j88h-profile
ui-consistency-j195-deferred
ui-consistency-j195
engineering-practices-j194
preferred-login-ui-j166
signin-pools-263-j174
macos-node-265-s1
decisions-d345
decisions-d344
proxy-cgroup-j164
verify-quick-fuzz-329
proxy-start-io-j168
timing-flakes-j163
up-263-s1
mcp-events-j147
verify-quick-fuzz-j158
proxy-p3-j159
agent-resource-j157-detect
wip/j103d-final
remote-cancel-hang-j155
proxy-traefik-281-j62d
j149-verify-quick
proxy-traefik-281-j62b
j150-drop-unnamed
wip/j79d-red-r4
wip/j103d-d332
rootless-toast-j142
wip/j103d-head
wip/j103d
j125c-mcp
macos-build-j136
backup/macos01-20261106/claude/j136
wip/j79d-red-cli
wip/j79d-red-server
j121-link-liveness
j118c-tracer-failures
wip/j79c-head
release-desktop-j131
j124c-signed-macos
wip/j79c-red-p3
wip/j79c-red-p23
wip/j79c-red-p22
merge-j128-check
perf-deferred-j128
sidebar-toggle-260
j127-shortcut-changed-dot
j125-mcp
j118-tracer-failures
j126-account-summary
settings-sections-mock-j92
j120-pinch-lock
sidebar-292
backup/macos01-20261106/claude/j120
taste-2026-11-03
row-actions-242-215
backup/macos01-20261106/claude/stash-0-untracked
backup/macos01-20261106/claude/J80-265-s1-run
backup/macos01-20261106/claude/J80-macos-s1-20261102
j112-canvas-commands
ui-no-overshoot-scroll
fix-recovery-restart
backup/macos01-20261106/claude/stash-1-untracked
taste-2026-11-02
size-baseline-ratchet
machine-cards-structure-j108
j109-boot-copy-mockups
fix-dev-red
wip/up-263-s1
j95b-settings-rows
proxy-traefik-281
j95-option-rows
docs-human-j91
docs-keys-palette
fix-flood-1013-270-j38d
mesh-ssh-s1
mesh-ssh-s0
addhost-d291-tunnel
test-stability-load
mesh-relay-220
repro-296
shim-thp-off-24
mesh-pins-258-v2
mesh-dns
signin-d311-merged
docs-pages
ui-size-283
fix-ui-batch-specs
wip/j12b-edge-update
gate-on-arm
fix-rename-sync-293
trust-285-j60b
fix-focus-ring-clip
integ-ui-1101
edge-update-v2
signin-d311
taste-2026-11-01
layout-per-tab-250
ui-approved-splitopt-224
ui-approved-splitopt-224-on-dev
icon-text-centre-282
ui-approved-189-212-216
research-reverse-proxy
transfer-budget-320
review-mesh-pins-258-r2
sidebar-pill-259
review-mesh-relay-220
wip/j12-edge-update-v2
nix-package
status-crash-loop-237
fix-dev-test-failures
fix-fixture-socket-path
wip/mesh-relay-220-pre-dev-advance-rebase
fix-canvas-side-clip
research-head-to-head
frosted-real-256
review-mesh-pins-258
wip/mesh-relay-220-pre-final-rebase
review-layout-per-tab-250-r2
broad-suite-triage
nix-devshell
review-status-crash-loop-237-r3
wip/nix-devshell-pre-p3
taste-frosted-real
wip/code-serve-demo-2026-10-30
wip/code-serve-glass-2026-10-30
wip/code-serve-clusters-2026-10-30
wip/code-merge-release94-dev-2026-10-30
wip/rproxy-delta-scratch-2026-10-30
wip/stale-note-257-staged-2026-10-30
wip/d241-size-staged-2026-10-30
review-broad-suite-207
wip/mesh-pins-258-pre-split
wip/mesh-relay-220-pre-rebase
mesh-measure-220
plan-211-update
review-edge-autoupdate-r3
perf24-reconnect
review-stale-note-r2
release-prod-live
d241-shell-marker
review-mesh-pins-server-258
review-revocation-r3
review-setup-token-r2
review-sync-journal-r3
wip/review-mesh-pins-258-prune-review-1995fee46
frosted-scroll-256
sync-journal-r3
revocation-per-account-wip
review-tokio-asyncfd-0386
review-sync-p3s
wip/stash-8by64-stash0-2026-10-30
mesh-drag-r2
setup-token-data-wip
release-9-4
auth-busy-1013
mesh-view-overlap
sync-p3s
review-auth-busy-wake
review-readd-r8-wip
mesh-drag-bounds
audit-auth-93
app-windows-stream-start
review-authority-cap-r3
app-windows-r7-measure
readd-minimal-r6
readd-minimal-r5
app-windows-r7-soak
readd-minimal-r4
app-windows-r7
app-windows-r6
readd-minimal-r3
readd-minimal-r2
readd-minimal
merge-release8-dev
review-busy-page-liveness-r2
review-busy-page-liveness
mesh-view-trim
review-authority-read-retry-r2
review-remove-uninstall-r2
release-retry-reattach
release-retry
review-remove-uninstall
review-authority-read-retry
app-windows-ship
mesh-autoswitch-p2
mesh-ssh
mesh-relay
mesh-macos-node
screen-and-control
session-labels
review-real-logins-r5
review-real-logins-r4
review-real-logins-r3
shim-memory-r2
review-real-logins-r2
shim-memory
shadow-addhost-instant
shadow-real-logins
shadow-same-session-flood
shadow-prod-perf-fix
hosts-from-server
app-windows-real
app-windows-transport
release-prod-6w
mesh-policy-verify
quiet-close-toast
dev-merge-r4
review-mesh-agent-transport
review-app-windows-transport
settings-roundtrip
review-release-pipeline-r4
mesh-agent-transport
ended-strip-fix
review-audit-ca-update-d244
settings-rows
phone-width
signout-clear
fix-restart-tests
dev-merge-rp
signer-hardening
review-audit-ca-update
terminal-fidelity
review-audit-ca-update-wip
mesh-integrate
review-mesh-agent-transport-515d3712
review-mesh-dataplane-feec1988
mesh-dataplane
signout
research-canvas-node
wip/review-renderer-cost
wip/review-terminal-fidelity
padlock-glyph
review-release-pipeline-2e95b689
phone-polish
sidebar-polish
inbox-generic
review-mesh-dataplane-378d4055
prod-batch
ui-inbox
ui-ca-unlock
ui-machine-sections
review-mesh-dataplane-a5f744fb
tls-session-prod
session-bounds-prod
fix-dead-session
session-bounds
tls-session
palette-polish
shortcuts-d222
research-appmeta
phone-gutter
ui-centre-button
wip/ui-centre-button
wip/tls-session
review-addhost-breakit
ui-platform
renderer-cost
remote-agents
mesh-api
ssh-bootstrap
prod-hotfix2
prod-fixes
review-remote-agents
review-mesh-dataplane
session-life
research-browser
review-mesh-api
research-capture
review-mesh-api-round3
review-mesh-api-round1
gate-stability
review-gate-stability
review-relay-direct
review-mesh-api-findings
proto-sessions
font-picker
proto-addhost
proto-windows
mesh-core
latency-gate
research-bsd
research-discovery
keytray-mods
mock-core
ui-tweaks
fix-motion-sel
fix-motion
integrate2
fix-robust
t-web
t-server
vt-ghostty
fix-snap-echo
t-web-auth
review-vt2
t-agent
lane-protocol
lane-shim
lane-auth
s1-base
s1-contracts
s1-workspace
No results found.
No labels
launch-qa
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set
Reference
kayg/infraternal#84
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Owner (2026-10-07, screenshot from the root deploy): terminal text looks squished vertically. Root cause (orchestrator): the pinned ghostty-web renderer measures the cell height as ceil(actualBoundingBoxAscent + actualBoundingBoxDescent of "M") + 2. "M" has no descender, so a 14 px font gets about a 12 px line (0.86x font size; terminals normally use about 1.2x), and the width is ceil()-rounded in CSS pixels, which widens cells about 7%. Fix in the pinned build.
Started on branch fix-cell-metrics from base
ac03b1913b.Finding: the new production Chromium probe at apps/tracer/test/cell-metrics.spec.ts fails at DPR 1, 2 and 3 before changes. Geist Mono 14 px reports fontBoundingBoxAscent=14 and fontBoundingBoxDescent=4 (18 px box); renderer cellHeight=15 px (1.0714×). M advance=7.916 px; cellWidth=8 px. Box-line seam probe currently sees ink at all sampled boundaries. Baseline screenshots: apps/tracer/test-results/cell-metrics-Geist-cell-metrics-and-box-joins-at-DPR-2/attachments/terminal-desktop-dpr2-ced6d3ec55514bd658b955b346c80d0e254e321c.png and ...DPR-3.../terminal-mobile-dpr3-cb7d8d7bf403ed280ccd1d1b16911f9ae95f1fa6.png.
Blocked for the prescribed perf-VM benchmark: SSH to perf-test-69-63 fails host-key verification and ssh-keygen -F finds no trusted known-host entry. No host-key bypass used. Need the owner to provide a verified host key/fingerprint before running the perf-VM measurement; local browser verification continues.
Finding: production Chromium cell-metrics tests pass at DPR 1/2/3. Geist Mono 14 px: font box 18 px, renderer row 18 px (1.2857×); 7/9/9 ink pixels at the sampled box joins; backing canvas dimensions match the device-pixel grid. Rows: 1440×900 52→44; 393×852 DPR3 49→41. Latest local paired DPR2 probe: full redraw p50/p95 58.5/109.5 ms before, 19.3/33.6 ms after; paced 10 MB output 6.10/9.71 MB/s; WASM 13.76/13.50 MB. DPR3: redraw p50/p95 8.1/28.8→4.7/24.6 ms; output 9.12→9.65 MB/s; WASM 12.78/12.71 MB. These workstation measurements vary materially between runs and are exploratory; the pinned perf VM remains blocked on a verified SSH key. Production screenshots are emitted by test/cell-metrics.spec.ts for the requested viewports.
Correction: the workstation before/after samples were sequential but not isolated or paired; use the figures as exploratory only, not evidence that the perf budget passed. The canonical comparison is still pending a verified perf-VM SSH key.
Confirmed against the production Chromium build: the unpatched renderer measures 15 px / 14 px = 1.0714 and fits 52 rows at 1440×900 DPR 2, and 49 rows at 393×852 DPR 3. The patched renderer measures 18 px / 14 px = 1.2857, fits 44 and 41 rows, and reports Geist Mono font box ascent 14 px + descent 4 px. DPR 1/2/3 pixel checks pass; the first combined run had one DPR 2 fixture-request socket hang-up under host load, and the isolated DPR 2 rerun passed. Before/after captures are staged for issue attachment after the remaining checks.
REGRESSION found by the owner on monitor01 after deploying
9e09924: the cursor sits about 2 cells right of the text, and the drift grows along the line. Cause: local-theme-api.patch draws text runs with fillText at runStart * metrics.width, so glyphs inside a run advance at the font natural width (~8.4 px) while the grid and cursor use the ceil width (9 px). Web bundle rolled back on monitor01 (server binary kept). The fix goes into #84 (fix-cell-metrics, run 2) with pixel tests. dev is not deployable until #84 merges.Continuation run 2 starting on branch fix-cell-metrics at WIP head 5e24d4d; original base
ac03b1913b. Reviewed all #84 comments and #75 regression history. Merging latest dev before further changes.Finding: the required theme-first, cell-metrics-second build stopped before artifacts: reports after . I am rebasing the cell source patch on the themed renderer before rebuilding.
Finding: the required theme-first, cell-metrics-second build stopped before artifacts:
git apply cell-metrics.patchreportserror: patch failed: lib/renderer.ts:100afterlocal-theme-api.patch. I am rebasing the cell source patch on the themed renderer before rebuilding.Finding (red regression test): apps/tracer/test/terminal-cell-position.spec.ts reproduces drift in production Chromium before the correction. With 14 px Geist Mono and DPR 2, a 200-column run leaves its final M 33 device pixels short of the cursor cell edge; the pipe column is also 33 pixels short. The measured run gap is 17 px at DPR 1 and 50 device pixels at DPR 3. The dpr2 run used the i9-9900K host (8 CPUs), load average 12.85/10.83/11.14.
Finding: desktop Geist Mono measures 14px ascent + 4px descent = 18px (1.286x); iPhone touch emulation at 13px measures 13px + 4px = 17px (1.308x). The renderer uses factor 1.0 of the font box; the touch ratio is 0.008 above the requested 1.30 ceiling because its reported font box is 17px. Cell geometry, line joins, and pixel alignment pass in test/cell-metrics.spec.ts and test/terminal-cell-position.spec.ts at DPR 1, 2, and 3.
Fast gate finding: with CARGO_TARGET_DIR under scratch,
agent_review::initial_attach_requires_explicit_credit_before_replayfailed becausescripts/verify-agent-attach-credit.pycallsstate.mkdir()for relativetarget/ac<PID>but the checkout had notarget/parent (FileNotFoundError, line 54). I stopped that run before static builds. Rerunning with the ignored checkouttarget/symlinked to scratch keeps artifacts in scratch and satisfies the fixture's path assumption.Finished at HEAD
fe12576954ec30e88a1ef2cdab345de27fc3d65e.The branch is split into atomic renderer rebuild, loaded-font metrics, and pixel regression-test commits. Both vendor patches are applied in build order (theme, then cell metrics); the pinned build regenerated
ghostty-web.js, declarations, andSHA256SUMS.letterSpacingkeeps each batched run on the grid exactly.letterSpacingis supported by Safari 18.4 per WebKit’s release notes.apps/tracer/vendor/ghostty-web/build.sh --checkreproduced ghostty-web 5f0c6b7 with Ghostty 5714ed0;sha256sum -c SHA256SUMSpassed.bun run check,bun run build, and the DPR, exact-position, and theme Playwright suites passed.The final
scripts/verify fastrun usedTRACER_TEST_PORT=4784, ran undersystemd-run --user --scope -p CPUWeight=10000, and exited 0. Full stdout/stderr from the script is quoted verbatim below.Verbatim scripts/verify fast output
Deployed dev
7eca507to monitor01 (~19:00): font-height terminal lines and on-grid glyphs (#84), local lossless themes (#75) back in. Before deploying, the orchestrator checked a 86-character line on a local production build at DPR 2: renderer cursorX=86 right after the last glyph, the same relative position as on a 2-character line (no drift). Gate: scripts/verify fast exit 0. Rollback: web.prev and infraternal.prev on the server.Hotfix
bd12725deployed (web) to monitor01 ~21:30: the terminal host resets letter-spacing/word-spacing so the mono UI tracking no longer shrinks the renderer cell (owner saw the cursor drift again). Verified on the production build: cell 8, cursorX 86 on an 86-char line at DPR 1/2. Post-deploy gate: scripts/verify fast exit 0 (Rust 6/6, browser 20/20, TS 7/7).Closed by the orchestrator during the 2026-10-28 handover (#254), on the owner's request to close finished issues. Evidence: Cell metrics and on-grid glyphs deployed (
7eca507) and the letter-spacing hotfixbd12725fedeployed; both verified in dev and prod with cursor position checks at DPR 1/2. Reopen if anything is still missing.kayg referenced this issue2026-10-28 17:53:54 +00:00