Palette: keyboard selection scrolls out of view #85
Closed
opened 2026-10-07 14:57:19 +00:00 by kayg
·
17 comments
No Branch/Tag specified
main
j470b-server-mesh-rejoin
mesh-compat-382
j444b-d381-key-wins-flood
j461b-macos-utun-reader-thread
j475b-remove-host-motion
fix-reconnect-new-link
j481-d380
dev
j479-mesh-soak
fix/j476-host-facts
j475-motion-pill-split
j470-mac-node-join
root-upgrade-d376
j474-review-merge
latency-targets-120hz
nightly-suite-shards
gotatun-pin-j469
macos-utun-reader-thread
fix-flood-echo-stall
wip/j416
motion-fast-ease-out
mesh-addhost-j259
takeover-close-terminals-d368
kbd-instant-followups
fix-trust-key-double-click
nightly-suite-partial-report
appwin-icons-j207
rusqlite-slice1
swipe-content-first-d374
mesh-mtu-381
addhost-instant-open
glass-contrast-d365-mock
glass-contrast-d365
signout-followups-442
fix-startup-toast-red
research-gotatun-matrix-j317
themes-sync-j304
fix-load-flakes
fix-nix-zig-patch
fix-compute01-browser-baseline
ratchet-size-baseline-419
predict-auto-d130
revoke-coverage-d367
nightly-suite-queue-timeout
nightly-browser-suite
fix-rustsec-2026-0459
fonts-ioskeley-obel
log-retention-d375
fix-kbd-no-anim-427
fix-dev-red-specs-2
takeover-proof-305-j205
wip/j410-server-pump
ui-consistency-d372
fix-osc52-clipboard
libghostty-vt-1.0
forget-retired-host-d369
j404-merge-426
fix-setup-lock-race
fix-touch-select-426
revoke-access-report-ui
fix-predictive-echo-specs
fix-selinux-agent-exec
wip/j395-checkpoint2
wip/j395
j391-review-scratch
ui-consistency-j195-deferred-rebased
fix-rustc-paths-421
decisions-wording-341
fix-install-suite-red
fix-dev-rtt-specs
fix-pending-removal-align
fix-privileged-skip
fix-install-suite-404
review-j368
mesh-dns-j254
revoke-access-report-d356b
revoke-privilege-round5
fix-removal-confirm
review-j360
gotatun-rotation-367
deps-refresh-340
review-j354
review-J351
review-j350
addhost-takeover-d359
revoke-report-items-347
revoke-end-sessions-d362
review-j348
size-mesh-ssh-346
size-trim-337
revoke-access-diff-d356
j259-pre-rebase-b06c5a6
j305-ended-at-start-spec
addhost-sudo-consent
fix-layout-real-specs-411
fix-shell-open-411
fix-console-hosts-373
fix-shell-exit
fuzz-host-name-353
fix-host-details-410
macos-filter-j197
research-gotatun-tricks
revoke-p3-j216l
stale-state-pill
revoke-followups-j216k
revoke-progress-j216e
backup/macos01-20261106/lume/j197
backup/macos01-20261106/lume/appwin-icons-j207-stash0
backup/macos01-20261106/claude/stash-0
backup/macos01-20261106/claude/stash-1
backup/macos01-20261106/claude/J80-macos-s1
backup/macos01-20261106/claude/J80
backup/macos01-20261106/claude/J80-slice1-20261102
backup/macos01-20261106/claude/J16b-appwin-on-dev
backup/macos01-20261106/claude/appwin-launch-idle-146
backup/macos01-20261106/claude/J80-s1-run
wip/j259
trust-285-p3c
runtime-lock-j216f
mesh-ssh-p3-j175
tun-proof-p3b
trust-285-p3
terminal-polish-j271
tun-proof-p3
ssh-install-flakes-j216i
fuzz-fixes-j264
trust-285-a
trust-285-b
restart-oversized-fixture-j198
backup/macos01-20261106/lume/appwin-icons-j207
restart-bound-j216h
up-preflight-p3-j198
backup/macos01-20261106/lume/j251
up-preflight-j198
wip/up-preflight-j198-j245-p2
wip/up-preflight-j198-j245-p1
agent-fsync-offloop-j196
wip/up-preflight-j198-j245
settings-offscreen-j231
wip/up-preflight-j198-j226-inspection
wip/j103f
themes-j206
wip/up-preflight-j198-j226
flakes-j216c
backup/macos01-20261106/claude/j197
flakes-j216b
backup/macos01-20261106/claude/j197-red
wip/up-preflight-j198-review
flakes-j216
backup/macos01-20261106/claude/appwin-icons-j207
engineering-j208b
appwin-mock-j209
toast-stack-j165
engineering-j208
decisions-d351
decisions-d350
decisions-d349
appearance-presets-mock-j129
decisions-d348
docs-audit-spec
doc-coverage-baseline-raise
decisions-d347
decisions-d346b
decisions-d346
j88h-profile
ui-consistency-j195-deferred
ui-consistency-j195
engineering-practices-j194
preferred-login-ui-j166
signin-pools-263-j174
macos-node-265-s1
decisions-d345
decisions-d344
proxy-cgroup-j164
verify-quick-fuzz-329
proxy-start-io-j168
timing-flakes-j163
up-263-s1
mcp-events-j147
verify-quick-fuzz-j158
proxy-p3-j159
agent-resource-j157-detect
wip/j103d-final
remote-cancel-hang-j155
proxy-traefik-281-j62d
j149-verify-quick
proxy-traefik-281-j62b
j150-drop-unnamed
wip/j79d-red-r4
wip/j103d-d332
rootless-toast-j142
wip/j103d-head
wip/j103d
j125c-mcp
macos-build-j136
backup/macos01-20261106/claude/j136
wip/j79d-red-cli
wip/j79d-red-server
j121-link-liveness
j118c-tracer-failures
wip/j79c-head
release-desktop-j131
j124c-signed-macos
wip/j79c-red-p3
wip/j79c-red-p23
wip/j79c-red-p22
merge-j128-check
perf-deferred-j128
sidebar-toggle-260
j127-shortcut-changed-dot
j125-mcp
j118-tracer-failures
j126-account-summary
settings-sections-mock-j92
j120-pinch-lock
sidebar-292
backup/macos01-20261106/claude/j120
taste-2026-11-03
row-actions-242-215
backup/macos01-20261106/claude/stash-0-untracked
backup/macos01-20261106/claude/J80-265-s1-run
backup/macos01-20261106/claude/J80-macos-s1-20261102
j112-canvas-commands
ui-no-overshoot-scroll
fix-recovery-restart
backup/macos01-20261106/claude/stash-1-untracked
taste-2026-11-02
size-baseline-ratchet
machine-cards-structure-j108
j109-boot-copy-mockups
fix-dev-red
wip/up-263-s1
j95b-settings-rows
proxy-traefik-281
j95-option-rows
docs-human-j91
docs-keys-palette
fix-flood-1013-270-j38d
mesh-ssh-s1
mesh-ssh-s0
addhost-d291-tunnel
test-stability-load
mesh-relay-220
repro-296
shim-thp-off-24
mesh-pins-258-v2
mesh-dns
signin-d311-merged
docs-pages
ui-size-283
fix-ui-batch-specs
wip/j12b-edge-update
gate-on-arm
fix-rename-sync-293
trust-285-j60b
fix-focus-ring-clip
integ-ui-1101
edge-update-v2
signin-d311
taste-2026-11-01
layout-per-tab-250
ui-approved-splitopt-224
ui-approved-splitopt-224-on-dev
icon-text-centre-282
ui-approved-189-212-216
research-reverse-proxy
transfer-budget-320
review-mesh-pins-258-r2
sidebar-pill-259
review-mesh-relay-220
wip/j12-edge-update-v2
nix-package
status-crash-loop-237
fix-dev-test-failures
fix-fixture-socket-path
wip/mesh-relay-220-pre-dev-advance-rebase
fix-canvas-side-clip
research-head-to-head
frosted-real-256
review-mesh-pins-258
wip/mesh-relay-220-pre-final-rebase
review-layout-per-tab-250-r2
broad-suite-triage
nix-devshell
review-status-crash-loop-237-r3
wip/nix-devshell-pre-p3
taste-frosted-real
wip/code-serve-demo-2026-10-30
wip/code-serve-glass-2026-10-30
wip/code-serve-clusters-2026-10-30
wip/code-merge-release94-dev-2026-10-30
wip/rproxy-delta-scratch-2026-10-30
wip/stale-note-257-staged-2026-10-30
wip/d241-size-staged-2026-10-30
review-broad-suite-207
wip/mesh-pins-258-pre-split
wip/mesh-relay-220-pre-rebase
mesh-measure-220
plan-211-update
review-edge-autoupdate-r3
perf24-reconnect
review-stale-note-r2
release-prod-live
d241-shell-marker
review-mesh-pins-server-258
review-revocation-r3
review-setup-token-r2
review-sync-journal-r3
wip/review-mesh-pins-258-prune-review-1995fee46
frosted-scroll-256
sync-journal-r3
revocation-per-account-wip
review-tokio-asyncfd-0386
review-sync-p3s
wip/stash-8by64-stash0-2026-10-30
mesh-drag-r2
setup-token-data-wip
release-9-4
auth-busy-1013
mesh-view-overlap
sync-p3s
review-auth-busy-wake
review-readd-r8-wip
mesh-drag-bounds
audit-auth-93
app-windows-stream-start
review-authority-cap-r3
app-windows-r7-measure
readd-minimal-r6
readd-minimal-r5
app-windows-r7-soak
readd-minimal-r4
app-windows-r7
app-windows-r6
readd-minimal-r3
readd-minimal-r2
readd-minimal
merge-release8-dev
review-busy-page-liveness-r2
review-busy-page-liveness
mesh-view-trim
review-authority-read-retry-r2
review-remove-uninstall-r2
release-retry-reattach
release-retry
review-remove-uninstall
review-authority-read-retry
app-windows-ship
mesh-autoswitch-p2
mesh-ssh
mesh-relay
mesh-macos-node
screen-and-control
session-labels
review-real-logins-r5
review-real-logins-r4
review-real-logins-r3
shim-memory-r2
review-real-logins-r2
shim-memory
shadow-addhost-instant
shadow-real-logins
shadow-same-session-flood
shadow-prod-perf-fix
hosts-from-server
app-windows-real
app-windows-transport
release-prod-6w
mesh-policy-verify
quiet-close-toast
dev-merge-r4
review-mesh-agent-transport
review-app-windows-transport
settings-roundtrip
review-release-pipeline-r4
mesh-agent-transport
ended-strip-fix
review-audit-ca-update-d244
settings-rows
phone-width
signout-clear
fix-restart-tests
dev-merge-rp
signer-hardening
review-audit-ca-update
terminal-fidelity
review-audit-ca-update-wip
mesh-integrate
review-mesh-agent-transport-515d3712
review-mesh-dataplane-feec1988
mesh-dataplane
signout
research-canvas-node
wip/review-renderer-cost
wip/review-terminal-fidelity
padlock-glyph
review-release-pipeline-2e95b689
phone-polish
sidebar-polish
inbox-generic
review-mesh-dataplane-378d4055
prod-batch
ui-inbox
ui-ca-unlock
ui-machine-sections
review-mesh-dataplane-a5f744fb
tls-session-prod
session-bounds-prod
fix-dead-session
session-bounds
tls-session
palette-polish
shortcuts-d222
research-appmeta
phone-gutter
ui-centre-button
wip/ui-centre-button
wip/tls-session
review-addhost-breakit
ui-platform
renderer-cost
remote-agents
mesh-api
ssh-bootstrap
prod-hotfix2
prod-fixes
review-remote-agents
review-mesh-dataplane
session-life
research-browser
review-mesh-api
research-capture
review-mesh-api-round3
review-mesh-api-round1
gate-stability
review-gate-stability
review-relay-direct
review-mesh-api-findings
proto-sessions
font-picker
proto-addhost
proto-windows
mesh-core
latency-gate
research-bsd
research-discovery
keytray-mods
mock-core
ui-tweaks
fix-motion-sel
fix-motion
integrate2
fix-robust
t-web
t-server
vt-ghostty
fix-snap-echo
t-web-auth
review-vt2
t-agent
lane-protocol
lane-shim
lane-auth
s1-base
s1-contracts
s1-workspace
No results found.
No labels
launch-qa
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set
Reference
kayg/infraternal#85
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Owner (2026-10-07, screenshot): in the Cmd+K palette, pressing Down repeatedly moves the selection out of view; the list does not scroll with the keyboard selection. Also each arrow press re-renders the whole list (replaceChildren in core-screen.ts renderPalette), which is wasteful.
Starting on branch fix-palette-nav from dev at
9c62448a32.Finding: the production Playwright regression fails at 1440x900 on ArrowDown to option 10; its row is outside #palette-results (test/palette-navigation.spec.ts). The current handler replaces all option nodes each press. Baseline handler cost: 0.3200 ms/press over 100 alternating moves, measured with performance.now around dispatched key handlers.
Finding: after the first post-fix run, port 4785 was held by a tracer server with cwd /home/kayg/Developer/infraternal/.worktrees/fix-cell-metrics/apps/tracer (verified via /proc); I left it untouched and am isolating the final rerun on port 4285.
Finding: controlled 100-event measurement on infraternal-dev showed filtering at 0.728 ms/input after the fix vs 0.111 ms/input on the original handler. renderPalette was also calling scrollIntoView for every typed filter; I’m replacing that with a scrollTop reset. Arrow handler measured 0.040 ms/press after vs 0.209 ms/press before.
Finding: with stable option IDs, the integrated production test measured 2.779 ms/filter input while aria-activedescendant follows changes between different first results. I’m measuring cached option nodes with the same stable IDs to reduce input rebuild work without weakening that relationship.
Finding: the stable-ID cached-node variant measured 1.147 ms/filter input at load 22.81/11.78/10.60, with no demonstrated advantage over the detached small-list rebuild. I’m keeping the simpler rebuild for typing; arrow navigation retains nodes and measured 0.065 ms/press over 100 moves.
Finding: scripts/verify fast stopped in the native VT build because Zig could not fetch two GitHub dependencies (HttpConnectionClosing); no code failure was reported. I’m letting the current gate exit and will retry the fast gate.
Finding: the workspace test gate also hit an existing fixture path assumption: agent_review creates target/ without creating target/, while CARGO_TARGET_DIR is in the job cache. I’ll point the ignored repo target path at the same scratch target and retry; the failure was FileNotFoundError in verify-agent-attach-credit.py.
Finished at
c59f9a2bb2; worktree clean.Keyboard navigation updates the old and new option selection in place, keeps the active descendant in sync, scrolls instantly, and adds clamped Home/End plus visible-page movement. Filtering still rebuilds on input. The Playwright regression passed at 1440×900 and 393×852, walking Down to the last row and Up to the first while checking row and group-heading visibility, active descendant, and stable option nodes; Home/End/PageUp/PageDown also passed. TRACER_TEST_PORT=4385 because the requested 4785 was occupied by another worktree.
Measured on infraternal-dev, 8 cores. Baseline load 1/5/15: 21.91,12.88,11.52; final: 21.23,13.09,11.11. With performance.now around 100 dispatched key handlers at 1440×900, arrow time was 0.3250 ms/press before and 0.0390 ms/press after. Filter time was 0.1300 ms/input before and 1.2940 ms/input after.
Production screenshot captures:
apps/tracer/test-results/core-screen/tracer-core-1440x900-paper-palette-open.png
apps/tracer/test-results/core-screen/tracer-core-1440x900-ink-palette-open.png
apps/tracer/test-results/core-screen/tracer-core-393x852-paper-palette-open.png
apps/tracer/test-results/core-screen/tracer-core-393x852-ink-palette-open.png
scripts/verify fast exited 0. Verbatim gate output summary:
Continuation run 2 starting on branch fix-palette-nav at
c59f9a2bb2; base dev:9c62448a32. I’m profiling filter phases and will preserve the navigation regression coverage while bringing the 100-input filter measurement back to the original 0.13 ms/input.Finding: the production Playwright harness reproduced the filter regression under systemd-run CPUWeight=10000: current
c59f9a2measured 0.7220 ms/input (load 1.82,8.76,14.02); original dev handler measured 0.1120 ms/input (load 17.08,11.63,14.30). The original run had higher load, so the regression is attributable to added handler work; I’m profiling its phases next. Arrow was 0.0370 ms/press on current and 0.2420 ms/press on original.Finding: phase instrumentation on one filter input at 1440x900 reported filter 0.000 ms, DOM build 0.200 ms, attribute/id assignment 0.000 ms, replaceChildren 0.200 ms, active-descendant 0.000 ms, scroll reset 0.200 ms, handler 0.700 ms, then a forced layout read 0.400 ms (timer resolution ~0.1 ms). No geometry read occurs in renderPalette; the filter rebuild and scroll reset are the handler work to remove. Added the 0.13 ms/input regression assertion first; it fails on current code at 1.213 ms/input (load 16.32,14.58,14.64).
Finding: the first node-reuse attempt that toggled hidden rows still measured 0.5470 ms/input (load 1.03,5.60,10.57), so it does not meet the 0.13 ms target. A one-input phase sample measured 0.500 ms total: 0.300 ms in the scroll reset, 0.100 ms filtering/row work, and 0.100 ms selection/ARIA (timer granularity ~0.1 ms); a post-handler layout read took 0.300 ms. I’m switching to cached nodes assembled into the filtered fragment and will measure again.
Finding: the first fast-gate run also failed static builds because .cargo/musl-cc.sh expects target/auth-tools/zig/zig while auth-toolchain staged Zig in the scratch CARGO_TARGET_DIR; the test fixture likewise expects target/. I’m using the already ignored worktree target path as a symlink to the scratch target for the retry. Rust fmt/clippy passed; the failing test was the known fixture path assumption.
Finished at
9c3781cca7on fix-palette-nav.Filtering now precomputes row/group IDs and uses the direct rebuild path without an extra scrollTop read/write. The regression test enforces the 0.13 ms/input ceiling. The production browser test passed at 1440x900 and 393x852, including Down to the final row, Up to the first, group heading visibility, active descendant, and Home/End/Page navigation.
Performance on infraternal-dev (8 cores;
systemd-run --user --scope -p CPUWeight=10000): startc59f9a2measured 0.7220 ms/filter input and 0.0370 ms/arrow press at load 1.82,8.76,14.02; final measured 0.1050 ms/filter input and 0.0350 ms/arrow press at load 0.92,3.20,8.32. The originaldevhandler measured 0.1120 ms/filter input and 0.2420 ms/arrow press at load 17.08,11.63,14.30. The c59 phase profile identified 0.2000 ms for DOM build, 0.2000 ms for replaceChildren, 0.2000 ms for scroll reset, and 0.4000 ms for a forced post-handler layout read; performance.now resolution was about 0.1 ms. Hidden-row reuse and cached-node fragment attempts measured 0.5470 and 0.6900 ms/input, so the faster rebuild path remains.Production screenshots:
apps/tracer/test-results/core-screen/tracer-core-1440x900-paper-palette-open.png
apps/tracer/test-results/core-screen/tracer-core-393x852-paper-palette-open.png
scripts/verify fastpassed on this commit. Verbatim gate summary:Deployed dev
5ed4f29to monitor01: reviewed recovery backend with the recovery UI held (live sign-in verified: no recovery entry, text "Welcome back / Your passkey is all you need / Continue with passkey"), palette keyboard selection stays in view (#85), deterministic recovery expiry tests (#65). Gate: scripts/verify fast exit 0. Rollback: web.prev / infraternal.prev.Closed by the orchestrator during the 2026-10-28 handover (#254), on the owner's request to close finished issues. Evidence: Palette keyboard selection fix merged (
e3e00eaeain dev) and deployed to prod in5ed4f29(ancestor of release-prod-live), owner-visible deploy comment, no open findings. Reopen if anything is still missing.kayg referenced this issue2026-10-28 17:53:54 +00:00