SHARING: one Share dialog everywhere + share Notes, Canvases and folders #1034
Closed
opened 2026-10-04 06:23:46 +00:00 by kayg
·
24 comments
No Branch/Tag specified
dev
wip/restyle-mailmoney
wip/restyle-files
wip/previewcard-1098
wip/palette2-1123
wip/palette-1093
wip/onboard2-1141
wip/onboard-1141.aborted-early
wip/onboard-1141
wip/nlpchip-1127
wip/morph-1104
wip/merge-round-7c5
wip/merge-round-7c4
wip/merge-round-7c3
wip/merge-round-7c2
wip/merge-round-7c
wip/mchrome-1084
wip/mailghost2-1094
wip/mailghost-1094
wip/kbpreview2-1118
wip/kbpreview-1118
wip/kanban-1092
wip/importhang-1121
wip/hiderev-1153
wip/hide4-1153
wip/hide3-1153
wip/hide2-1153
wip/hide-1153
wip/editreg-1132
wip/editorrail3-1113
wip/editorrail2-1113
wip/editorrail-1113
wip/e2e-b2-1071
wip/e2e-b-1071
wip/draw4-1101
wip/draw3-1101
wip/draw2-1101
wip/draw-1101
wip/directory-1199-r
wip/directory-1199
wip/delete-1119
job/merge30
wip/collabrev-1197
wip/collabloss2-1197
wip/collabloss-1197
wip/cards2-1083
wip/cards-1083
wip/canvas-visual
wip/canvasvis2-976
wip/calhdr-1112
wip/calcards-1115
wip/browserfix
wip/blocks-1125
wip/allday-1107
wip/agenda-decks
wip/agenda-1086
wip/adv7c-1105
wip/txentry-1198
wip/trayicons2-1095
wip/trayicons-1095
wip/tagperf-1186
wip/sidebar3-1094
wip/rev2-webperf
wip/rev2-money-ident
job/restyle-notes
job/tagperf-1186
job/adv-1202
job/notifloop-1194
job/restyle-mailmoney
job/onboard-1141
wip/restyle-notes
job/segmented-1200
job/hide-1153
wip/notifloop-1194
job/txentry-1198
job/collabloss-1197
job/perf-1124
job/perf2-1124
job/tocrail-1191
job/restyle-settings
wip/restyle-settings
wip/segmented-1200
job/restyle-files
job/tagdnd-1187
job/cards-1179
wip/cards2-1179
wip/cards-1179
wip/tocrail-1191
wip/tagdnd-1187
wip/perf-1124
wip/merge30j
job/wizchoices-1140
wip/wizchoices-1140
wip/restyle-1190
job/moneyfmt-1180
wip/moneyfmt2-1180
wip/moneyfmt-1180-r
wip/moneyfmt-1180
job/pillglass-1189
job/flags-1181
wip/flags-1181
job/restyle-1190
job/restyle-search
job/settingsreg-1195
job/wizard-1140
site/website
wip/wizardrev2-1140
wip/wizardrev-1140
wip/wizard5-1140
wip/wizard4-1140
wip/wizard3-1140
wip/wizard2-1140
wip/wizard-1140
wip/pillglass-1189
wip/settingsreg-1195
job/merge29
job/fu-1171
wip/merge29j
wip/fu-1171
job/fu-1166
job/directory-1199
job/proflog-1204
job/txresearch-1188
wip/fu-1166
job/merge28
job/search-1066
wip/search-1066
wip/merge28j
job/gateslot-1182
job/bulkimport-1157
job/mailnet-1160
wip/mailnetrev-1160
wip/mailnet-1160
wip/bulkrev-1157
wip/bulkimport-1157
job/startup-1161
wip/startup-1161
job/merge27
job/linkcards-1151
wip/linkcards3-1151
wip/linkcards2-1151
wip/linkcards-1151
job/traydate-1144
wip/traydate3-1144
wip/traydate2-1144
wip/traydate-1144
job/draw-1101
wip/merge27j
job/blockpill-1152
wip/blockpill3-1152
wip/blockpill2-1152
wip/blockpill-1152
job/minihover-1149
wip/minihover2-1149
wip/minihover-1149
job/merge25
wip/merge25-r
wip/merge25b
wip/merge25
job/inspector-1129
job/tags-1110
wip/inspector3-1129
wip/inspector2-1129
wip/inspector-1129
wip/tagsrev-1110
wip/tags2-1110
wip/tags-1110
job/dates-1148
wip/datesrev-1148
wip/dates2-1148
wip/dates-1148
job/licence-1145
wip/licence2-1145
wip/licence-1145
job/selfhost-1156
job/merge23
wip/merge23
job/tagfilter-1109
wip/tagfilter2-1109
wip/tagfilter-1109
job/kbd-1134
wip/kbd2-1134
wip/kbd-1134
job/palfoot-1137
wip/selfhost-1156
wip/palfoot2-1137
wip/palfoot-1137
job/toggle-1158
wip/toggle-1158
job/kbpreview-1118
job/docratchet-1155
job/perflint-1133
job/devtests-1159
wip/docratchet-1155
wip/devtests-1159
job/segv-1136
wip/toast-1142
wip/segv-1136
job/toast-1142
job/blockreload-1147
wip/blockreload-1147
job/font-1150
wip/font-1150
job/importui-1120
job/minimonth-1149
wip/importui-1120
wip/minimonth-1149
job/depcheck-1146
wip/perflint-1133
wip/depcheck-1146
job/calcards-1115
job/blocks-1125
job/plus-1128
job/shift-1138
wip/plus2-1128
wip/plus-1128
wip/shift-1138
job/moneyfid-1130
job/editorrail-1113
wip/moneyrev-1130
wip/moneyfid-1130
job/noext-851
wip/noext-851
wip/noext3-851
wip/noext2-851
job/week-1135
wip/week-1135
job/editreg-1132
job/smoke-1122
wip/smoke-1122
job/docs-1143
job/palette2-1123
job/calhdr-1112
job/nlpchip-1127
job/mailghost-1094
job/reconnect-1131
wip/reconnect-1131
job/trayicons-1095
job/delete-1119
job/importhang-1121
job/cards-1083
job/palette-1093
job/mchrome-1084
job/e2e-a-1071
job/canvas-visual
job/previewcard-1098
job/allday-1107
wip/e2e-a2-1071
wip/e2e-a-1071
job/e2e-b-1071
job/adv7c-1105
job/kanban-1092
job/agenda-1086
job/merge-round-7c
job/morph-1104
wip/surfaces-p2
job/merge-round-9
wip/merge-round-9
job/7cfix-small
wip/7cfix-small
job/mailui-1078
job/merge-round-8
wip/merge-round-8
wip/mailui-1078
job/mailround-1038
job/applemail-accept
wip/settitle-1068
wip/mailround2-1038
wip/mailround-1038
wip/e2e-7b
job/crash-1069
wip/crash-1069
job/searchlost-1066
wip/searchlost-1066
job/7b-reconcile
job/flake-1065
wip/flake-1065
wip/merge-round-7b7
wip/merge-round-7b6
wip/merge-round-7b5
wip/merge-round-7b4
wip/7b-reconcile
job/appupdate-1059
job/nfd-1044
wip/appupdate-1059
job/e2e-7b
job/loop-1062
wip/loop-1062
job/pdfprev-1045
job/invtoggle-1053
wip/pdfprev-1045
wip/nfd-1044
wip/invtoggle-1053
job/7bfix-e2e
job/mailstress-b
wip/7bfix-e2e
wip/mailstress-b
job/7bfix-adv
wip/7bfix-adv
job/mailstress-a
job/stack-1054
wip/stack-1054
wip/mailstress-a
job/mailstress-1038
wip/mailstress-1038
job/upload500-1051
wip/upload500-1051
job/share-1034
wip/share-1034
job/syncerr-1037
job/7bfix-photos
wip/7bfix-photos
job/paste-1036
job/setside-1039
wip/setside-1039
wip/paste-1036
job/lease-1042
wip/syncerr-1037
wip/lease-1042
job/7bfix-data
job/passkeybind-1043
wip/apprevoke-1041
job/invite-1035
wip/invite-1035
job/merge-round-7b2
wip/merge-round-7b2
job/mailproxy-486
job/apprevoke-1041
job/rebuild-1033
job/pillborder-1029
wip/pillborder-1029
wip/mailproxy-486
wip/applemail-486
job/headless-998
wip/headless-998
job/groups-1028
wip/groups-1028
job/rebuildwarn-1016
wip/rebuildwarn-1016
job/startup-1011
wip/startup-1011
job/monthpill-1009
job/bgthumb-1025
job/sharetitle-1012
wip/monthpill-1009
wip/bgthumb-1025
wip/sharetitle-1012
job/canvas-cards-977
wip/canvas-cards-977
job/canvas-pencil-978
job/canvas-sketch-990
wip/canvas-sketch-990
wip/canvas-pencil-978
job/canvas-files-989
wip/canvas-files-989
job/canvas-collab-991
wip/canvas-collab-991
job/weekscroll-1018
wip/weekscroll-1018
wip/canvas-core-976
job/canvas-core-976
job/round-drag
wip/round-drag
job/round-settings
job/browserfix
wip/oapi-974
job/oapi-974
job/hist2-integrate
job/mailhtml-726
wip/mailhtml-726
wip/hist2-integrate
job/moneyfu-984
job/drag-1015
wip/drag-1015
job/rename-1017
wip/rename-1017
job/hist2-api
wip/hist2-api
job/oneacct-1014
wip/oneacct-1014
wip/moneyfu-984
job/hist2-bench
job/hist2-restore
wip/hist2-bench
job/hist2-write
job/hotfix-724
wip/hotfix-724
wip/hist2-write
wip/hist2-restore
job/hist2-store
job/hist2-ui
wip/hist2-ui
wip/hist2-store
job/searchstarve-965
job/shutdown-963
wip/shutdown-963
wip/pubedit-981
job/pubedit-981
job/analytics-973
wip/searchstarve-965
job/authflash-850
job/weeklane-969
job/pvtitle-1004
job/hist-975
wip/authflash-850
job/voicepill-617
wip/pvtitle-1004
job/headring-1003
wip/weeklane-969
wip/voicepill-617
wip/headring-1003
wip/analytics-973
job/agentscope-980
wip/thumbsandbox-988
job/thumbsandbox-988
wip/hist-975
job/links-856
wip/links-856
job/davetag-966
wip/davetag-966
job/filesstorm-1000
job/hoverpad-725
wip/filesstorm-1000
job/ffmpegblas-993
job/merge-round-7a
wip/hoverpad-725
wip/ffmpegblas-993
job/nowdot-1002
wip/verify-7a
job/noteid-857
wip/nowdot-1002
wip/noteid-857
wip/merge-round-7a
wip/agentscope-980
job/imapedge
job/a11yfix2
wip/imapedge-941
wip/imapedge
wip/a11yfix2
job/notetask-986
job/logheading
wip/logheading-998
job/textthumb-652
job/photolive-987
wip/photolive-987
job/davactive-983
job/savefix-985
job/tabicons-607
wip/davactive-983
wip/tabicons-607
wip/notetask-986
wip/savefix-985
job/dirid-627
job/buildspeed-1007
wip/dirid-627
job/agenda-decks
job/perfguards-impl
job/undo-a11y
wip/undo-a11y
job/mailperf
job/wal-824
wip/settings-50
job/settings-50
job/notesfilter-606
wip/notesfilter-606
job/surfaces-p2
wip/wal-824
job/maillayouts
wip/mailperf
wip/maillayouts
job/taskmeta-659
job/money-ident
wip/money-ident
wip/taskmeta-659
job/errstates
wip/perfguards-impl
job/headings-881
wip/headings-881
wip/errstates
job/voice-619
job/gaps-827
job/notesperf
wip/notesperf
wip/voice-619
job/hddsql-549
job/perf-stream-668
wip/perf-stream-668
wip/deeplinks-fix
job/deeplinks-fix
job/authfix
job/docsfix-rust
wip/docsfix-rust
job/webperf
job/docsfix-web
job/datafix2
job/webdav-lock-476
job/copyfix
wip/copyfix
wip/webperf
job/focus-658
wip/protofix
job/mediafix
job/protofix
wip/mediafix
job/agentfix
job/hhmm-724
wip/agentfix
job/undo-722
job/reuse
wip/webdav-lock-476
wip/reuse
job/scopefix
job/datafix
wip/hhmm-724
wip/undo-722
job/surfaces-p1
wip/hddsql-549
job/voicememos-618
wip/datafix2
wip/surfaces-p1
job/fix-940
wip/fix-940
job/blaze-surfaces
wip/datafix
wip/blaze-surfaces
job/taskday-655
job/linknav-639
wip/linknav-639
wip/gaps-827
job/isolation-707
job/audiophotos-720
wip/audiophotos-720
job/advfind-664
wip/voicememos-618
wip/taskday-655
wip/isolation-707
wip/advfind-664
wip/scopefix
wip/focus-658
job/testgaps
wip/testgaps
job/overscroll-718
wip/authfix
job/deps
wip/overscroll-718
job/rev2-agentfix
job/rev2-money-ident
job/rev2-mailperf
wip/deps
job/hardening-728
wip/hardening-728
job/searchgen-832
wip/searchgen-832
job/photopw-849
job/mailsql-825
wip/photopw-849
job/sharefix
wip/sharefix
job/rev2-mailhtml-726
job/rev2-perfguards
job/copyval-723
job/lightglass-r2
wip/lightglass-r2
wip/docsfix-web
job/copy-audit
job/macinterop-staging-r2
job/design-sync
job/rev2-taskmeta-659
job/rev2-webperf
job/docs-audit
job/rev2-advfind-664
job/rev2-mailproxy-486
job/states-audit
job/rev2-datafix
job/design-drift
job/test-gaps
job/rev2-voicememos-618
job/rev2-mediafix
job/rev2-deps
job/rev2-datafix2
job/licence-audit
job/issue-hygiene
job/rev2-protofix
job/rev2-voice-619
job/rev2-isolation-707
job/rev2-surfaces-p1
job/deeplink-audit2
job/rev2-audiophotos-720
wip/test-gaps
job/rev2-overscroll-718
job/rev2-undo-722
wip/states-audit
job/rev2-dropmd-719
job/rev2-linknav-639
job/merge-7b-plan
wip/merge-7b-plan
job/rev2-taskday-655
wip/mailsql-825
job/rev2-webdav-lock-476
job/rev2-browserfix
wip/design-drift
job/rev2-hddsql-549
wip/deeplink-audit2
job/rev2-scopefix
job/rev2-authfix
job/rev2-hardening-728
job/rev2-wal-824
job/rev2-sharefix
job/calsidebar-638
job/chrome-audit
job/ioperf
wip/ioperf
wip/chrome-audit
wip/calsidebar-638
job/dropmd-719
wip/dropmd-719
job/ocr-build
wip/ocr-build
job/blaze-settings
wip/copyval-723
job/toastring-721
wip/toastring-721
job/deployfix-732
wip/deployfix-732
wip/blaze-settings
job/money-import-recheck
job/rev-a11y
job/perf-arch-db
job/rev-7b-data
wip/textthumb-652
wip/perf-arch-db
job/sec-protocols
job/sidehdr-660
job/rev-7b-security
job/research-surfaces
job/rev-design-gaps
job/rev-mcp-api
wip/sidehdr-660
job/perf-arch-memory
wip/sec-protocols
job/perf-arch-bundle
job/snapedge-714
wip/rev-mcp-api
job/sec-supplychain
wip/research-surfaces
job/perf-arch-sync
job/rev-consistency
job/perf-arch-server
wip/perf-arch-server
wip/perf-arch-memory
job/perf-arch-io
job/perf-arch-client
job/sec-fs
job/sec-mcp-scopes
job/sec-sharing
job/perf-guards
job/sec-browser
job/sec-admin-deploy
job/sec-auth
wip/snapedge-714
job/bgpicker-717
wip/perf-arch-bundle
wip/money-import-recheck
job/advsetup-654
wip/bgpicker-717
wip/advsetup-654
job/burst-709
job/kbdcaps-710
job/app-pw-chooser
wip/burst-709
wip/app-pw-chooser
job/imaptest-625
wip/kbdcaps-710
job/fix-499
wip/fix-499
job/perf-mut-667
job/calimg-589
job/perf-snap-666
wip/calimg-589
wip/perf-snap-666
wip/perf-mut-667
job/perf-cache-665
wip/perf-cache-665
job/voicefiles-620
wip/voicefiles-620
job/admin-burst-705
wip/admin-burst-705
job/voicememos-review
wip/voicememos-review
wip/ryw-653
job/ryw-653
job/writeonopen-661
job/instant-663
wip/writeonopen-661
job/money-import-review
wip/money-import-review
wip/importjs-610
review/integrations-407-round6
wip/integrations-review
job/dragghost-612
wip/dragghost-612
job/integrations
wip/integrations
job/decider-656
job/merge-round-6
job/perf-rerun
wip/merge-round-6
job/integrations-review-round5
job/selalign-576
wip/selalign-576
job/mcp-events-491
job/files-631
job/cal-e2e-569
wip/cal-e2e-569
job/reload-423
wip/reload-423
wip/mcp-events-491
wip/files-631
job/notesbridge-644
wip/notesbridge-644
job/editor-series
job/calcard-series
wip/calcard-series
job/mcp-events-review-491
wip/mcp-events-review
wip/editor-series
job/quirks-546
job/integrations-recheck
job/tocrail-636
wip/tocrail-636
wip/quirks-546
wip/reminders-643
job/reminders-643
wip/davscale-573
job/davscale-573
job/integrations-review
wip/ocr-eval-584
job/ocr-eval-584
job/esc-537
wip/esc-537
job/toastname-586
wip/toastname-586
job/submenu-579
wip/submenu-579
job/tasks-mode
wip/tasks-mode
job/agentdocs-630
job/dupwrite-634
wip/agentdocs-630
wip/dupwrite-634
job/lightglass-588
wip/lightglass-588
job/tabswitch-549
job/ghosttask-623
wip/ghosttask-623
job/toaststack-616
job/weekstate-609
job/mailsync-613
wip/mailsync-613
wip/weekstate-609
job/maildup-626
wip/tabswitch-549
wip/maildup-626
wip/toaststack-616
job/motion-611
wip/motion-611
job/tlstest-601
wip/tlstest-601
job/perf-495
job/floating-sheet
wip/floating-sheet
job/remdup-585
wip/remdup-585
job/fix-502
wip/fix-502
job/attachplay-622
job/perf-batch
wip/perf-batch-563
wip/perf-495
hotfix/mail-sync-diag
job/mail-m3
wip/mail-m3
job/attach-poof-603
job/calhover-608
job/editorbar-604
job/mentions-605
job/merge-round-4
job/allday-514
wip/merge-round-4
wip/allday-514
job/merge-round-4a
wip/merge-round-4a
job/sharestack-580
job/fix-501
wip/sharestack-580
wip/fix-501
job/perf-batch-563
job/apw-cache-review
wip/apw-cache-review
job/probe-520
wip/probe-520
job/mac-393
wip/mac-393
job/header-571
job/flake-513
wip/flake-513
job/docs-thumb-547
wip/header-571
job/webcal-572
wip/webcal-572
wip/shortcuts-542
job/shortcuts-542
wip/docs-thumb-547
job/caldav-stress
wip/caldav-stress
wip/sweep-478
job/apw-cache-512
wip/apw-cache-512
job/money-empty-540
wip/restart-505
wip/money-empty-540
wip/fix-510
job/restart-505
job/fix-503
job/perf-496
wip/perf-496
job/fix-498
wip/fix-498
job/info-inspector-465
wip/info-inspector-465
job/fix-510
job/fix-507
wip/fix-507
wip/fix-503
job/fix-493
job/money-kinds
wip/money-kinds
job/hygiene-548
job/merge-round-3
wip/fix-493
job/drag-snap-536
wip/merge-round-3
wip/merge-round-0930
wip/drag-snap-536
job/align-538
wip/align-538
job/bg-flash
wip/bg-flash
job/money-import
job/search-count-544
wip/search-count-544
wip/money-import
job/settings-key-541
wip/settings-key-541
job/toast-539
job/preview-421
wip/preview-421
wip/toast-539
job/tasks-500-531
job/title-plain-526
wip/title-plain-526
wip/tasks-500-531
job/notes-bridge
wip/parity-484
job/parity-484
job/files-slow
job/crash-525
wip/notes-bridge
wip/files-slow
wip/crash-525
job/kbd-motion-527
wip/bg-422
job/analytics-504
wip/analytics-504
wip/kbd-motion-527
job/upload-pill-523
wip/upload-pill-523
wip/tray-order
job/tray-order
wip/overflow-mid
wip/merge-round-2
job/perf-494
wip/perf-494
wip/mcp-fast-492
wip/motion-477
wip/asr-ab-489
wip/theme-variants-506
wip/overflow-511
wip/week-header-508
wip/attach-427
job/dav-delete-471
job/iso-435
wip/iso-435
wip/files-sel-keys
wip/dav-delete-471
job/align-253
job/siwc-490
wip/siwc-490
job/money-kinds-review
wip/align-253
wip/money-kinds-review
job/small-bugs-3
wip/overlay-title-487
wip/multiget-500
wip/hidden-420
wip/webcal-ui
wip/webcal-431
job/perf-367
job/location
wip/small-bugs-3
wip/location
wip/perf-367
wip/admin-deny-483
job/tag-unicode-473
wip/tag-unicode-473
job/blur-436
wip/photos-470
wip/blur-436
wip/small-bugs-4
wip/hunt-20260930
wip/settings-hdr-482
wip/chips-416
job/dedup-375
wip/dedup-375
job/doc-stack
wip/doc-stack
job/tokens-literals
wip/tokens-literals
job/jobs-leftovers
wip/send-fast
wip/paste-467
wip/money-numbers
job/money-plugin
wip/money-plugin
job/break-dav
wip/merge-batch
wip/crossday-469
wip/mac-verify
wip/mail-m2
wip/break-dav
wip/money-review2
job/money-md
job/modes-424
wip/money-md
wip/jobs-leftovers
job/agenda-413
wip/agenda-413
wip/modes-424
job/recog-417
wip/recog-417
wip/bounce-425
wip/ab-384-luna
job/webdav-perf
wip/webdav-perf
job/toast-ring
wip/toast-ring
job/money-review
wip/money-review
wip/micro-motion
wip/settings-card
wip/minical
job/notes-imap-428
job/least-priv
wip/ui-small-2
wip/flaky-426
wip/drag-end-418
job/jank
wip/jank
wip/least-priv
wip/docs-site
job/agenda
job/sec-batch
wip/sec-batch
wip/per-user-index
job/area-calendars
wip/area-calendars
job/parity
wip/parity
job/documents-research
wip/documents-research
job/test-infra
job/reminders-sync
wip/small-bugs-2
wip/reminders-sync
wip/gestures
job/google-oauth
wip/tags-merge
wip/tags
job/e2e-theme
wip/e2e-theme
job/icon-align
wip/test-infra
wip/select-align
wip/editor-385
job/voice
wip/webdav
job/webdav
job/app-pw-ui
job/editor-integrity
wip/editor-integrity
wip/voice
wip/quota
wip/cal-followups
wip/icon-align
job/composer-scale
wip/composer-scale
job/jobs-page
wip/jobs-page
job/hig-type
wip/hig-type
wip/app-pw-ui
job/motion-spring
job/mcp
wip/motion-spring
wip/mcp
job/small-bugs
wip/push-hosts
job/profile-sign
wip/touch-369
wip/profile-sign
job/mobile-focus
wip/mobile-focus
wip/ui-polish-354
wip/small-bugs
wip/dup-task
job/toast-polish
job/app-pw-scopes
wip/toast-polish
wip/app-pw-scopes
wip/cli-agent
wip/selection-pills
job/preview-attach
wip/preview-attach
job/dav-proppatch
wip/dav-proppatch
wip/cal-switcher
job/atomic-race
wip/atomic-race
job/photos-shared
wip/photos-shared
wip/cal-grid
wip/note-rewrite
wip/search-rebuild
job/mail-m1
job/paperless-import
wip/paperless-import
wip/mail-m1
wip/hidden-activity
wip/search-d
wip/pricing-research
wip/cursors
wip/auto-scheme
job/single-pills
wip/single-pills
wip/xuser-matrix
wip/money-format
wip/app-pw-setup
wip/purge-dos
wip/vault-health
wip/caldav-apple
wip/xuser-audit
wip/e2e-green
wip/tabbar
wip/adv-harness
wip/maple-mono
job/search-fix
wip/search-fix
wip/search-perf-c
job/adv-harness
wip/sidebar-headers
job/glass
wip/temp-index
job/polish
wip/polish
wip/file-protocols
wip/money-research
wip/glass
wip/voice-models
wip/collab-redo
job/voice-research
wip/hunt-20260928
wip/notes-actions-research
wip/search-pad
wip/search-perf
wip/search-sticky
wip/editor-undo
wip/chrome-rules
wip/motion
wip/appearance-research
wip/appearance
wip/audit-bugs
wip/cal-glass
wip/block-actions
wip/authz-order
wip/event-stripes
wip/chrome-sidebar
wip/auth-flaky
wip/robust-2
wip/gate-fix
wip/menu-blur
wip/import-calternaljs
wip/tray-fix
job/import-calternaljs
wip/index-order
wip/audit-fixes
wip/search-chevrons
research/mail
wip/phone-chrome
wip/dedup-break
wip/csp
wip/ui-audit
wip/select-toast
wip/perf
wip/flat-layout
wip/fonts
wip/event-tint
wip/sync-converge
wip/data-split
wip/glass-audit
wip/robustness
wip/sync-chaos
wip/search-thumbs
wip/fuzz
wip/menu-icons
wip/search-pill
wip/sync-changing
wip/heading-links
wip/date-formats
wip/a11y
wip/break-editor
wip/e2e-fix
wip/settings-sections
wip/sync-root-guard
wip/search-palette
wip/share-edit
job/toasts
wip/toasts
wip/cont-analytics
wip/authz-review
wip/popovers
wip/overlay-glass
wip/change-feed
wip/editor-modes
wip/composer-align
wip/cont-agenda
wip/agenda-merge
job/agent-conventions
wip/agent-conventions
wip/backend-misc
job/route-audit
wip/route-audit
wip/ui-batch
wip/heif-hardening
wip/grid-resize
wip/ask-page
wip/webmcp
job/deeplink-audit
wip/deeplinks
wip/shortcuts
wip/cont-tz-days
main
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set
Reference
kayg/calternal#1034
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Owner (2026-10-04): "Somehow I am not able to share notes? Sharing is fundamental to the app."
Contract: DESIGN §54, including the new "Rollout and dialog" table (read it). Today only Files and Photos have a Share dialog ("Can view / Can edit"); Notes has no Share action at all; Notes → Shared does not exist.
Scope
apps/web/src/lib/files/ShareDialog.svelte; reuse gate: no second dialog) with §54 wording (Share / Collaborate), the per-item option table from §54 (show only options that make sense), people + Groups (Groups land in round 7c, job/groups-1028 — build against the shared grant model; if the Group picker is not on your base yet, leave the seam), public link section, and the invite-link tick (implemented in the separate invite-link issue; leave its seam).Out of scope: Daily notes, tag/saved-search sharing, Calendar/Tasks/Money sharing, federation.
Verification
Two-User e2e: owner shares a note (Share), recipient sees it in Notes → Shared read-only; switch to Collaborate, both edit live; revoke, recipient gets 404; folder share includes a new note added later; public note page renders. Screenshots 390/820/1440 light/dark of the dialog on a note, a file, a folder, a photo.
Started on
job/share-1034, base85294fc72cf76a707ef30b2ba38d9c9da75afc57. The supplied worktree has an unfinished merge of job/pubedit-981 (six conflicts); Groups is not yet integrated. I will resolve the prerequisite merge, integrate Groups, and build #1034 against both. No push or deployment.Started #1034 on job/share-1034, base
85294fc72c. Merging approved job/pubedit-981, then job/groups-1028 as requested. Generated contracts will be regenerated from code.Prerequisite integration commits:
c7179979f(public links),eb2584324(Groups). Files migrations were renumbered to 0021_public_links_view_only and 0022_group_grants because origin/dev already used 0019 and 0020. The migration-count assertion follows the merged migration history; no behavioral expectation was relaxed. Both harness tests were retained and the theme fixture now uses the existing User storage seam. Contracts were generated from the merged Rust code, not hand-merged.Decisions for #1034: reuse Files Security state for Notes grants and recursive folders; add bounded shared-Note projections on the Files API, so Notes does not acquire a second permission model. #1035 seam: ShareDialog accepts inviteSection: Snippet<[{ path: string; name: string; dir: boolean }]>. Read-only Note projections and public previews use the existing private Reference redactor. No new dependencies.
Focused web verification: 4 files, 43 tests passed. The #1034 Share shortcut is explicitly required by DESIGN §54 and overlaps a Firefox browser binding in the existing reserved list. Added a narrow owner-selected exception, with assertions for the exact requested chord and registry-backed handler; no reserved binding was removed. bun run check reports: svelte-check found 0 errors and 0 warnings.
Two-User production e2e passed Share → read-only, switch → live edits in both directions, and revoke → immediate missing state/404. It then exposed a recursive grant defect: POST /notes changed the Notes directory fingerprint, but the Root change bridge only indexed the child. GET /files/shared-notes therefore omitted the later Note even after 15 s. Files adopt_change now refreshes the existing directory chain after the child change. The regression uses this production bridge rather than manually refreshing the directory fixture.
The final origin/dev merge is
b5608f149. Files migrations 21 (approved #981) and 22 (approved #1028) remain free on origin/dev.The longer production flow found a second directory continuity defect: after live edits, creating a recursive Notes grant and then writing unrelated Files could leave the recipient's existing Note at 404. The directory Index rule uses both the directory token and its parent's token (#627). Two legitimate writes can change both before the asynchronous Root bridge reads them.
Minimal public addition in calternal-fs: FsChange now has an optional DirectoryWriteProof. Atomic file writes capture the full parent token before temporary entries and hold that directory handle until event consumers finish. Files preserves a directory ID only when the Index matches that full pre-write token and the current path still names the pinned inode. Outside watcher hints keep the conservative rule. The handle prevents inode reuse; the existing bounded change bus bounds retained handles.
Regressions passed: calternal-fs proves sibling writes preserve the proof and replacing the directory rejects it; Files delays Note adoption until a sibling write changes the parent's token and still reads both recursively granted Notes. No existing status expectation was changed. The production e2e now also asserts the recursive grant survives the unrelated Files workload.
The earlier remote-edit timeouts were in the browser fixture, not transport. The failure snapshot proves the owner inserted "Owner edit." inside the private link label: the saved Note contained
[PRIVATE_LABEL Owner edit.](<../../Private.md>), and the recipient received the same source but correctly rendered[Private item]. The fixture selected the first paragraph, which can be a blank spacer. It now double-clicks the visible "Starting text." paragraph for both Users. All live-edit, revocation and isolation assertions remain.The body editor consumed Cmd/Ctrl+Shift+S as Strikethrough before the Share handler ran. #1034 assigns that chord to Share. The root now handles it before editor keymaps. Strikethrough uses Cmd/Ctrl+Shift+X through the existing shortcut binder. A real editor key event test passes. Two old browser-conflict expectations were removed because the Strike default changed as required by #1034; no API status or security assertion changed. File QuickLook routes Share to its current item.
The production keyboard probe found that Share opened from the body editor kept focus in that editor. The existing focus trap treated the captured opener as a new outside focus claim. The trap now ignores only that original opener during its two opening frames. It still respects a different element that claims focus. Both cases have focused regression tests. Focused Notes sidebar rows and folders now own their Share shortcut before the page handler; editable keymaps still use capture for the fixed Share chord.
The production phone probe found that a Notes-folder Share dialog was visible but its controls were blocked by the sidebar modal. Share state now lives in the stable sidebar host. A Share action releases the old Bits UI modal at once, while force-mounted sidebar content keeps the same spring exit. The Share dialog accepts input without waiting for motion. It restores focus to the stable sidebar toggle on phone and to the original row on desktop. This uses the existing ShareDialog; no second dialog was added. The production screenshot probe now checks that the real dialog remains visible before and after each capture.
The production browser error guard found two state_unsafe_mutation errors on the recipient during revocation. The stack points to the editor blur and surface focusout handlers. DOM removal dispatches those native events inside Svelte rendering. Their immediate focus bookkeeping now runs through the existing untrack boundary, which keeps the writes outside that rendering reaction. The browser assertion remains strict and will run again. The separate phone handoff passed pointer capture at all three widths and both themes.
#1034 sharing report
READY FOR MERGE: yes.
Branch: job/share-1034
Head:
7b563395cbBuilt
Merged approved public-link and Group branches in the required order. Resolved the Files migrations as 21 and 22. Regenerated contracts from Rust. Merged origin/dev once before gates.
Extended the existing ShareDialog for Notes, Notes folders, Files, folders and Photos. Added Share / Collaborate wording, item options, public-link defaults, Users and Groups, and the invite section seam. Added owner entry points and fixed shortcuts. Notes → Shared uses the normal Note editor and stable Note IDs. Viewer content uses a redacted HTTP projection. Collaborate uses the existing owner room. Live access changes and revocation refresh the recipient view. Public Notes render as formatted pages.
Root write events now carry a pinned parent proof. It preserves recursive grant identities through overlapping saves and rejects a replacement directory. This is a small public addition in calternal-fs, consumed by Files and the server. Filesystem access remains inside calternal-fs.
UX gaps closed
Decisions
Known gaps / UX gaps left
For the merge round
Run full bun run test --maxWorkers=2 from apps/web. Run bun apps/web/e2e/share.mjs, bun apps/web/e2e/share-1034.mjs, bun apps/web/e2e/notes.mjs and bun apps/web/e2e/groups-1028.mjs against the combined production build. These must prove existing public-link behavior, the new sharing flow, Notes editing and Group access.
Run bash tests/adversarial/run.sh once. The route matrices must prove cross-User isolation, guessed IDs, revoke mid-edit, malformed cursors, public-link password rate limits and cross-plugin directory replacement. No full matrix was run in this job under the latest policy.
The orchestrator reviews the attached production screenshots. Real Mac interop and staging checks stay in the merge round. Future perf phase: on the perf VM, from the checkout, run flock /root/perf.lock bash -c 'cat /proc/loadavg; bun bench/groups-grants.mjs --shared-notes'. Compare p50/p95, CPU and RSS with docs/perf/baseline.json and add a baseline when accepted.
Files
Feature commits changed these files. The approved prerequisite branches also bring their Group and public-link files.
Gate output (verbatim)
cargo fmt --check: exit 0, no output.
cargo clippy -p calternal-notes-core --all-targets -- -D warnings. Full output.
cargo test -p calternal-notes-core.
cargo clippy -p calternal-fs --all-targets -- -D warnings.
cargo test -p calternal-fs.
cargo clippy -p calternal-plugin-files --all-targets -- -D warnings.
cargo test -p calternal-plugin-files.
cargo clippy -p calternal-collab --all-targets -- -D warnings.
cargo test -p calternal-collab.
cargo clippy -p calternal-server --all-targets -- -D warnings.
cargo test -p calternal-server.
Focused retry: cargo test -p calternal-server wire::tests::live_apps_run_in_separate_processes -- --test-threads=4. Full output.
apps/web: bun run check. Full output.
Focused Notes and shortcut Vitest files (--maxWorkers=2). Full output.
Files collection and Notes API Vitest files (--maxWorkers=2). Full output.
Focus and shortcut regressions (--maxWorkers=2). Full output.
Sidebar and focus regressions (--maxWorkers=2). Full output.
Editor and formatting regressions (--maxWorkers=2). Full output.
packages/editor: bun run check. Full output.
node --test apps/web/e2e/harness.test.mjs. Full output.
Offline cross-User / generated-entry-point classification.
bun apps/web/e2e/share-1034.mjs. Full output.
Production web build: exit 0. Full output.
The server suite failure above is the unchanged five-second archive-job timeout at wire.rs:8184. The focused live-app wrapper passed. This is recorded as SLOW host load; no assertion or timeout was changed.
Production screenshot evidence
60 images. macOS platform. Phone 390 px, tablet 820 px and desktop 1440 px. Light (paper) and dark (tokyo-night). Each dialog was visible before and after its capture. Screenshots are not committed. Claude reviews visual quality.
Some text-log uploads returned HTTP 500 from Forgejo. All 60 screenshots are attached. Gate results are quoted above; full logs remain in artifacts/.
Cleanup
cargo clean and deletion of web build output completed. No push, deploy or unrequested merge was run. The issue stays open.
Started send-back on job/share-1034, base
7b563395c. Merging origin/dev and approved job/invite-1035 first. Preserve shared Home image uploads and incoming privacy rendering. Then correct formatted public Notes, recipient search, Shared list metadata and responsive header padding; run acceptance and all requested gates. No push or deploy.Merged origin/dev (
a2eea1b6e) and job/invite-1035 (7cd8d8c64), keeping #1036 Home uploads, pending decorations and image fallback with #1034 private labels. Final fetch/merge found origin/dev already up to date; Auth migration 0013 remains free there.Finding: public preview already removes frontmatter and private references. The web page was passing its Markdown to TextView, which is a source viewer.
b78d503e9reuses the read-only Note renderer and removes file thumbnails, byte sizes and Preview from Notes.f1f36613cadds explicit User/Group search, one access choice and Add access; mounts #1035; aligns phone header padding; removes Settings invitation copy; keeps Revoke compact. No new dependencies.Web check (verbatim):
Focused picker/upload/invite tests (verbatim):
Merged Auth test suite (verbatim):
The previously reported app-password failure is no longer present on this combined base. Files/server gates and production acceptance evidence are in progress.
Integration finding: #1035's unchanged --notes fixture uses the imported calternal-id
invite-note-1035. Notes path_for_id accepts that exact ID, and invite_links correctly returns its stable /n/ destination. #1034 shared_note alone required Uuid::parse_str, so that valid imported Note could not open for its recipient. Removed the UUID-only subset: the parameter remains a bound SQL identity lookup, with unchanged live grant and filesystem identity checks. Added shared_imported_note_identity_opens_and_revokes to prove authorized imported content, unknown-ID 404 and revoke 404. No existing assertion or fixture was changed. Gates and acceptance are running against the combined implementation.READY FOR MERGE: yes (SLOW-only gate exception below; screenshots attached for Claude's visual review).
Head:
9016bfae6631d5dc9f382c2c2ac0910bb8a9589eonjob/share-1034. No push, deploy or merge to dev/main.Built:
invite-note-1035were rejected as non-UUID. Bound identity lookup and live grant checks remain the authority. Added a read/revoke regression; unknown identities stay 404.Files:
apps/web/src/lib/files/{ShareDialog,RecipientPicker,InviteLinkSection,PublicLinkPage}.svelte,RecipientPicker.svelte.test.ts,api.ts,api.test.ts,sharing.svelte.ts;apps/web/src/lib/notes/{NoteEditorSurface.svelte,noteProse.css,api.ts};apps/web/src/lib/components/NoteList.svelte;apps/web/src/routes/notes/+page.svelte;apps/web/e2e/share-1034.mjs;crates/plugins/files/src/{lib.rs,shares.rs};contracts/openapi.json;packages/api-client/src/generated.ts. Merge resolution also retained both behaviors inNoteImageView.svelteandeditorHost.tsand the approved Auth/invite flow.Evidence:
bun e2e/share-1034.mjsandbun e2e/invite-1035.mjs --notesagainst the production web build. Acceptance checked read-only access, denied raw collaboration socket, live edits, revocation, folder inheritance, private-reference redaction, invite exhaustion, recipient persistence, policy and Undo. No requested acceptance checks deferred.Gate output (verbatim summaries; complete output in the archives):
cargo fmt --check: exit 0, no output.cargo clippy -p calternal-auth --all-targets -- -D warningscargo test -p calternal-authcargo clippy -p calternal-plugin-files --all-targets -- -D warningscargo test -p calternal-plugin-filescargo test -p calternal-plugin-files internal_temp_paths_never_enter_index_during_atomic_write_reconcile_stormcargo test -p calternal-plugin-files shared_imported_note_identity_opens_and_revokescargo clippy -p calternal-server --all-targets -- -D warningscargo test -p calternal-serverbun run checkbun run test -- --maxWorkers=2focused Files API / recipient picker Vitestbun e2e/share-1034.mjsbun e2e/invite-1035.mjs --notesThe Share script's printed count was stale (60); the archive contains 66 PNGs. Corrected the count in the final test commit without rerunning acceptance for a log-only edit. The final commit after that adds a module doc comment only.
Known gaps:
writes, reconcile scans, and watcher adoption complete within five minutes: Elapsed(()). The subsequentatomic write 692 failed: entry not foundoccurred after the timeout removed the temporary test directory. The unchanged focused test passed in 112.15s. No timeout, fixture or assertion was weakened. Treat this as SLOW-only under the job rule; the full suite is not reported green.UX gaps closed: formatted public reading; searchable recipients; duplicate Share controls; empty-instance invite route; stale joined names; inline access/Undo; path-free Shared metadata; phone header inset; file suffixes in dialog titles; imported-identity join/editor persistence; duplicate public title; list markers and long-Note clipping.
UX gaps left: none found in the requested send-back flow.
Decisions:
For the merge round: no requested acceptance work deferred. Run the combined branch gates and visual review under the normal merge-round policy. Performance measurements were not run: this is not a performance issue, as required by the latest verification policy. Existing shared-notes-1034 and invite-1035 bench profiles remain available.
Re-read touched module comments.
cargo cleanremoved 9.4 GiB; deleted production web build output after acceptance. Working tree clean. Atomic code/test commits are in branch history.Merge round 7b5 starts on
job/7b-reconcile, basea1f3a0797. Assemble the requested Photo probe fixes and Month Task guards, upload recovery #1051, and Share/Groups/invite links. Preserve the 7b migrations and move new sharing migrations after them. Regenerate contracts, run per-crate gates for all crates and the requested web/editor/share/invite flows. No adversarial matrix, push or deploy.7b5 integration findings (#867, #1034, #1035):
6074f71d1andc39ffe5d9have no migration-file differences. The upgrade test pins both 7b and sharing versions and keeps all prior receipts.No adversarial matrix, push or deploy. Gates remain in progress.
#867 integration finding: fresh sharing server startup fails with
cannot create AFTER trigger on view: files_shares. The schema upgrade alone passed because it did not install the app change bridge. The fix attaches grant triggers tofiles_grants, expands Group members, refreshes pre-sharing trigger definitions on startup, and invalidates User epochs when Group membership or active state changes. The production upgrade regression now installs the bridge twice and checks a Group grant revoke/member removal without a Group-keyed journal head. Focused gates are compiling.Generated OpenAPI/actions/client and seven new Group admin-denial fixtures are committed as
58d1951ae. Action-registry unit tests:Ran 27 tests in 1.966s/OK.Decision for review: sharing has no performance adoption metadata. The initial combined-release coverage ledger records 19,340 exact, expiring sites (previous 19,139: 451 removed, 652 new). Absent budgets, bounds, readiness and tests remain absent, not invented passing contracts. No access/session/accessibility waiver is added. origin/dev has no ratchet; this is the initial release baseline. This is a net increase of 201 adoption gaps and remains an explicit known gap; future ratchet checks retain their existing non-growth rule. Perf measurement is not run because this issue is release verification, not a performance issue.
The final schema + bridge regression passes:
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 217 filtered out; finished in 1.19s. Commit33855fd58also closes the shared-reading accessibility and shared focus-token gaps. The full web suite passes:Test Files 222 passed (222)/Tests 1510 passed (1510); Svelte reportssvelte-check found 0 errors and 4 warnings in 3 files.Browser findings to retain for review (no existing assertion changed):
bun e2e/share-1034.mjspasses its two-User share/collaborate/revoke and recursive-grant assertions, then stops during File inspector screenshots. It expects the dialog nameInfo; the existing 7b FilesBrowser uses the selected item's name (Review.txt) for its Inspector. Changing the existing title to satisfy the older expectation would undo 7b's Inspector contract.bun e2e/invite-1035.mjs --notescreates and enrols the invite recipient, then expects**/notes/invite-note-1035. The actual navigation ishttps://localhost:<port>/n/invite-note-1035, the canonical stable Note route in DESIGN §33. The owner rule forbids changing a wrong existing expectation without an explicit behavior change. Both expectations remain for the orchestrator's decision. These failures stop the remaining requested acceptance steps and screenshot sets; they are not claimed as passed.Per-crate Rust gates continue. No adversarial matrix ran. Current staging readiness remains no until the full acceptance flows complete.
Fixed a real UX consistency gap in incoming Notes: a revoked route removed its body and its Files subscription, so a later restored grant left that open view missing. The view now retains only its route/owner identity after revoke. A later Files event performs another authorized read and restores the current access mode. Session end clears that identity. The new #1034 browser assertion restores a folder grant and requires the existing recipient view to return without navigation/reload; it passes in the current real-server run.
The diagnostic invite run completed its requested scenarios: five Guest signups, sixth refusal, recipient editing, revocation/policy checks, Chromium and WebKit. It exits with failure because the five unchanged legacy
/notes/<id>expectations remain. 72 macOS screenshots are attached: https://git.kayg.org/attachments/77818983-5d8e-4bd9-98f9-6440cc2f65f9 .Sharing diagnostic continuation retains the Info/Close Info failures. Its admin-only fixture creation now precedes the long screenshot phase, preserving the same fixture values and expected statuses within the real owner confirmation lifetime. No security check was relaxed.
The parity audit now reports
Parity matrix: 389 API actions, 422 bound UI intents, 0 actions with adapter gaps;Ran 11 tests in 0.186s/OK. Reviewed transport exclusions are displayed as reasons, not reported as adapter coverage; declared eligible adapters still require dispatch hooks.Per-crate gates found two integration defects:
Analytics: 14 tests failed at Files migration setup with
no such table: main.user_groups. Its existingusersstub was insufficient after Group grants. Core migrations now precede Files in Analytics and Calendar publication fixture setup; the same prerequisite was added to a server Files-scope fixture. Fixture values and assertions stay unchanged. Analytics retry:test result: ok. 34 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 5.27s. Calendar's full test gate passes.Files all-target compilation: retained password/identity response regressions need
axum::response::IntoResponseandaxum::body::to_bytes. Public edit retirement removed their production imports. Test-only imports are restored; the Files retry is running. No security assertion changed.Both acceptance diagnostic runs completed every requested scenario and capture. Sharing finished with exactly the twelve retained Info/Close Info failures; invite finished with exactly the five retained legacy Note-route failures. They remain failing receipts, not passes. Sharing's new grant-restoration regression passes without a recipient reload.
Review artifacts, all masked and from production builds with macOS rendering:
Strict acceptance and staging readiness remain no while the old assertions are unresolved under the owner's expectation rule.
Finished merge-round-7b5.
Branch:
job/7b-reconcile. Head:4082669f718487c727bb7beba5ecd6468064a5e2. Base:a1f3a0797.READY FOR STAGING: no. All Rust, web and editor gates pass. Original sharing and invite expectations remain failed; diagnostics completed every requested scenario without converting them to passes. No push, staging deployment or adversarial matrix ran.
Committed audit:
docs/audits/merge-round-7b5.md. Full report and gate output follow.Merge round 7b, round 5
Issue: #867. Branch:
job/7b-reconcile.Base:
a1f3a0797. Production dev:c39ffe5d90126527d7aacf2d8b79507929c80616.Assembly
The ten requested photo probe and Month Task commits are present as non-merge cherry-picks. The photos branch itself was not merged. Upload recovery takes the shared upload lock and reads the intent again (#1051). The sharing branch supplies the unified Share dialog, Groups, view-only Public links and Invite links.
The merge keeps 7b Task focus, Journal labels, mutation receipts, file receipts, DirectoryWriteProof, temporary file guards and current Public link identity/password/address checks. Security writes use the authority pool. Stored grants use
files_grants;files_sharesexpands current Group membership for reads.Sharing migrations follow the 7b migrations: db
0015_groups, Files0023_public_links_view_onlyand0024_group_grants; auth0013_share_invitesis free. Production dev has the same migration SQL as the existing production schema fixture. The upgrade regression pins both branches, checks receipts, installs the app change bridge twice and starts a second migration pass without another backup. The runner uses namespace/version plus the SQL checksum. Description is operator text. Deployed migrations were not changed.git fetch originandgit merge origin/devran once before the final gates. Output:Already up to date.No push or deployment ran. The adversarial matrix is reserved for the orchestrator, as requested.UX gaps closed
Incoming Notes bypass both revision and transport caches. A permission downgrade or revoke takes effect on the next read. Late Files events cannot replace a different Note route. A revoked incoming route keeps its identity subscription, so a restored grant can restore the view after another authorized read. Incoming viewers get a read-only editor with heading links and a screen-reader name. Owner-only actions remain restricted to owned Notes. Focus rings use the shared root rules and the existing field proxy. Screenshot evidence masks capability inputs.
Fresh startup failed because the app change bridge tried to attach table triggers to the new
files_sharesview. The bridge now attaches to stored grants and invalidates the User epochs for Group grant, membership and active-state revokes. It refreshes pre-sharing grant trigger definitions on upgrade.Decisions
No new dependency version was assumed.
cargo search tower --limit 1verified tower 0.5.3 for the auth test dependency.The sharing branch had no performance adoption metadata. Its exact missing bounds, tests, readiness predicates and profiles remain explicit in the initial combined-release ledger. The ledger has 19,340 sites, compared with 19,139 in round 4: 451 removed and 652 added, a net increase of 201. The new sites point to #867 and expire on 2026-11-16. They do not claim measured budgets or implemented bounds. No access, session or accessibility check is waived. origin/dev has no ratchet; the combined release starts it. Future non-growth checks are unchanged. The owner must review this initial coverage increase. No performance measurement ran, under the verification policy for issues that are not about performance.
Acceptance contract drift
The original sharing flow expects a Files inspector named
Infoand aClose Infobutton. The 7b Inspector uses the selected item name. The invite flow already asserts that its finish API returns/n/invite-note-1035, but later expects navigation to/notes/invite-note-1035. The browser goes to the canonical/n/route. No original expected value was changed. Diagnostic continuation checks the current contract, completes the remaining steps, and still fails at finish if any original expectation failed. Four helper tests prove that diagnostics cannot report a false pass.The invite diagnostic completed five Guest signups, refusal of the sixth, Note editing, revoke and policy checks, and 72 Chromium/WebKit screenshots. Its final failure contains only the five original route expectations. Sharing's privileged fixture setup runs before screenshots because its real owner assertion expires after five minutes. The fixture values and status assertions are unchanged.
Known gaps
Performance adoption remains incomplete as the ledger states. The orchestrator must run the adversarial matrix and review the production screenshots. No staging, o2 or real Apple-client check ran in this job.
UX gaps left
The original acceptance expectations remain unresolved: Files inspector names and the invite Note route. Diagnostic runs finish the scenarios and retain these failures. The visual reviewer must review the attached images.
Review artifacts
Images cover 390, 820 and 1440 px in both themes. They are masked, attached to #867, and excluded from git.
Cross-Plugin test prerequisites
Analytics initially failed 14 tests because the Files Group migrations had no
user_groupstable. Analytics, Calendar publication and a server Files-scope test now install core migrations before Files. Fixture values and assertions stay unchanged. Analytics passes all 34 tests on retry. Retained Files password/identity tests also needed their response imports restored after Public edit removal. These are test-only imports; no security check changed.Gate receipts
All 29 workspace crates and the vendored async-imap crate were checked separately. Commands used
OPENSSL_NO_VENDOR=1,CARGO_PROFILE_DEV_DEBUG=line-tables-only,CARGO_INCREMENTAL=0,CARGO_BUILD_JOBS=4and the worktreetarget/tmp. The web production build preceded the Rust gates. No workspace clippy or test command ran.Initial Analytics test and Files compile failures are retained in the logs. The receipts below use their passing retries. Files then gained one address-header test and a grant-list assertion; both focused tests and final all-target clippy passed. The full Files retry has 233 passing tests; the additional focused test is listed separately.
cargo fmt --check: exit 0, no output.calternal-api
cargo clippy -p calternal-api --all-targets -- -D warningsandcargo test -p calternal-api -- --test-threads=4:calternal-auth
cargo clippy -p calternal-auth --all-targets -- -D warningsandcargo test -p calternal-auth -- --test-threads=4:calternal-cli
cargo clippy -p calternal-cli --all-targets -- -D warningsandcargo test -p calternal-cli -- --test-threads=4:calternal-collab
cargo clippy -p calternal-collab --all-targets -- -D warningsandcargo test -p calternal-collab -- --test-threads=4:calternal-dav
cargo clippy -p calternal-dav --all-targets -- -D warningsandcargo test -p calternal-dav -- --test-threads=4:calternal-db
cargo clippy -p calternal-db --all-targets -- -D warningsandcargo test -p calternal-db -- --test-threads=4:calternal-embed
cargo clippy -p calternal-embed --all-targets -- -D warningsandcargo test -p calternal-embed -- --test-threads=4:calternal-fs
cargo clippy -p calternal-fs --all-targets -- -D warningsandcargo test -p calternal-fs -- --test-threads=4:calternal-imap
cargo clippy -p calternal-imap --all-targets -- -D warningsandcargo test -p calternal-imap -- --test-threads=4:calternal-location
cargo clippy -p calternal-location --all-targets -- -D warningsandcargo test -p calternal-location -- --test-threads=4:calternal-media
cargo clippy -p calternal-media --all-targets -- -D warningsandcargo test -p calternal-media -- --test-threads=4:calternal-money
cargo clippy -p calternal-money --all-targets -- -D warningsandcargo test -p calternal-money -- --test-threads=4:calternal-notes-core
cargo clippy -p calternal-notes-core --all-targets -- -D warningsandcargo test -p calternal-notes-core -- --test-threads=4:calternal-path
cargo clippy -p calternal-path --all-targets -- -D warningsandcargo test -p calternal-path -- --test-threads=4:calternal-plugin
cargo clippy -p calternal-plugin --all-targets -- -D warningsandcargo test -p calternal-plugin -- --test-threads=4:calternal-plugin-ai
cargo clippy -p calternal-plugin-ai --all-targets -- -D warningsandcargo test -p calternal-plugin-ai -- --test-threads=4:calternal-plugin-analytics
cargo clippy -p calternal-plugin-analytics --all-targets -- -D warningsandcargo test -p calternal-plugin-analytics -- --test-threads=4:calternal-plugin-calendar
cargo clippy -p calternal-plugin-calendar --all-targets -- -D warningsandcargo test -p calternal-plugin-calendar -- --test-threads=4:calternal-plugin-files
cargo clippy -p calternal-plugin-files --all-targets -- -D warningsandcargo test -p calternal-plugin-files -- --test-threads=4:calternal-plugin-mail
cargo clippy -p calternal-plugin-mail --all-targets -- -D warningsandcargo test -p calternal-plugin-mail -- --test-threads=4:calternal-plugin-money
cargo clippy -p calternal-plugin-money --all-targets -- -D warningsandcargo test -p calternal-plugin-money -- --test-threads=4:calternal-plugin-notes
cargo clippy -p calternal-plugin-notes --all-targets -- -D warningsandcargo test -p calternal-plugin-notes -- --test-threads=4:calternal-plugin-notifications
cargo clippy -p calternal-plugin-notifications --all-targets -- -D warningsandcargo test -p calternal-plugin-notifications -- --test-threads=4:calternal-plugin-photos
cargo clippy -p calternal-plugin-photos --all-targets -- -D warningsandcargo test -p calternal-plugin-photos -- --test-threads=4:calternal-plugin-video
cargo clippy -p calternal-plugin-video --all-targets -- -D warningsandcargo test -p calternal-plugin-video -- --test-threads=4:calternal-search
cargo clippy -p calternal-search --all-targets -- -D warningsandcargo test -p calternal-search -- --test-threads=4:calternal-server
cargo clippy -p calternal-server --all-targets -- -D warningsandcargo test -p calternal-server -- --test-threads=4:calternal-sync
cargo clippy -p calternal-sync --all-targets -- -D warningsandcargo test -p calternal-sync -- --test-threads=4:calternal-tags
cargo clippy -p calternal-tags --all-targets -- -D warningsandcargo test -p calternal-tags -- --test-threads=4:async-imap
cargo clippy -p async-imap --all-targets -- -D warningsandcargo test -p async-imap -- --test-threads=4:Web, editor and focused regressions
web-check-proof-final.log:web-test-restore.log:editor-tests.log:test-verified-ip.log:test-group-listing.log:parity-check-final-4.log:parity-tests-final-4.log:registry-final-2.log:reconcile-checks-final.log:Web commands:
bun run check;bun run test --maxWorkers=2. Editor command:bunx vitest run --maxWorkers=2inpackages/editor. Browser commands:bun e2e/share-1034.mjsandbun e2e/invite-1035.mjs --notesinapps/web. The full diagnostic runs setCALTERNAL_E2E_CONTINUE_KNOWN_MISMATCHES=1; their final exit remains nonzero.Browser acceptance: retained failures
share-e2e-restored.log:invite-e2e-diagnostic.log:Files
Paths changed since the job base, including the merged feature code:
Cleanup
cargo cleancompleted. The web build and SvelteKit output were deleted. Review images remain ignored.Completion
Module comments were read again after integration. No screenshot or build output is committed. The original acceptance assertions still fail; the job cannot mark them green.
READY FOR STAGING: no.
Deployed to production (2026-10-04 ~20:45 CEST,
9fb9a4bfb)Round 7b + sharing (#1034 #1035 #1028 #981) + upload recovery (#1051) + startup stacks (#1054) + Calendar photo probe fixes + hotfix #1062 + the Cross-User files/open parity fix.
Gates on the final branch:
Tests 1510 passed (1510)web,Tests 433 passed (433)editor;Production: healthy in 21 s, no errors. Migration heads auth 13, db 15, files 24 (no 0021 exists in code), mail 11, notes 32. Daily Log rows 7,806. No expired leases. Change events 0/30 s.