kayg commented

Owner

The required bun run --cwd apps/web check stops before TypeScript validation at an unrelated stale performance exception after merging origin/dev `570e084c86 during #1130.

$ ../../scripts/perf-lint --check && node scripts/check-user-storage.mjs && node scripts/check-glass-tokens.mjs && node scripts/check-type-tokens.mjs && node scripts/check-focus-tokens.mjs && node scripts/check-motion-tokens.mjs && svelte-kit sync && svelte-check --tsconfig ./tsconfig.json
perf-lint: parse Rust product sources
perf-lint: parse browser product sources
perf-lint: validate coverage and architecture
perf-lint: INVALID: ('render.bound', 'apps/web/src/lib/components/app-sidebar.svelte', 'apps/web/src/lib/components/app-sidebar.svelte#each:10a1aaf3137a2426:1'): unused or changed exception

apps/web/src/lib/components/app-sidebar.svelte is identical to origin/dev. #1130 renews only existing Money pins and does not increase any exception ceiling. The production web build passes. Renew the current sidebar pin and audit the remaining baseline pins without widening debt ceilings.

The required `bun run --cwd apps/web check` stops before TypeScript validation at an unrelated stale performance exception after merging origin/dev `570e084c8691a76b9bec904f47151f4ff5701298 during #1130. ```text $ ../../scripts/perf-lint --check && node scripts/check-user-storage.mjs && node scripts/check-glass-tokens.mjs && node scripts/check-type-tokens.mjs && node scripts/check-focus-tokens.mjs && node scripts/check-motion-tokens.mjs && svelte-kit sync && svelte-check --tsconfig ./tsconfig.json perf-lint: parse Rust product sources perf-lint: parse browser product sources perf-lint: validate coverage and architecture perf-lint: INVALID: ('render.bound', 'apps/web/src/lib/components/app-sidebar.svelte', 'apps/web/src/lib/components/app-sidebar.svelte#each:10a1aaf3137a2426:1'): unused or changed exception ``` `apps/web/src/lib/components/app-sidebar.svelte` is identical to origin/dev. #1130 renews only existing Money pins and does not increase any exception ceiling. The production web build passes. Renew the current sidebar pin and audit the remaining baseline pins without widening debt ceilings.

kayg referenced this issue

2026-10-05 09:41:09 +00:00

Money import: keep closed accounts, cleared/reconciled state and transaction notes; plain-language review #1130

kayg referenced this issue

2026-10-05 10:07:03 +00:00

Money import: keep closed accounts, cleared/reconciled state and transaction notes; plain-language review #1130

kayg referenced this issue

2026-10-05 11:12:39 +00:00

Money import: keep closed accounts, cleared/reconciled state and transaction notes; plain-language review #1130

kayg referenced this issue

2026-10-05 12:11:37 +00:00

Inspector: Versions flicker, wrong Note copy, title against top edge, Share orphaned outside the header pill #1129

kayg referenced this issue

2026-10-05 12:45:15 +00:00

Contextual + button: always present; New note on Notes, New task on Tasks, Upload on Files/Photos #1128

kayg referenced this issue

2026-10-05 14:50:53 +00:00

Tags: clicking a tag filters the current view (chip, ⌘-click AND, deep-linkable) #1109

kayg referenced this issue

2026-10-05 15:13:01 +00:00

Tasks Board: live drop preview while dragging over a column #1118

kayg commented

2026-10-05 15:21:02 +00:00

Author

Owner

Starting #1133 on branch job/perflint-1133. Starting HEAD: 577b1b3d10; origin/dev at start: de654a42ac. I have read CLAUDE.md, CONTEXT.md, and docs/DESIGN.md. I will reconcile perf contracts and the web check ordering, then run the requested web gates.

Starting #1133 on branch job/perflint-1133. Starting HEAD: 577b1b3d10fb8237144242cdc448475e2113c4c2; origin/dev at start: de654a42ac4f9a6dca83bed8e0eebc99706f7dfe. I have read CLAUDE.md, CONTEXT.md, and docs/DESIGN.md. I will reconcile perf contracts and the web check ordering, then run the requested web gates.

kayg referenced this issue

2026-10-05 15:21:02 +00:00

Contextual + button: always present; New note on Notes, New task on Tasks, Upload on Files/Photos #1128

kayg commented

2026-10-05 15:25:10 +00:00

Author

Owner

Finding: after fast-forwarding to origin/dev de654a42a, contracts/perf/exceptions.json has 21,977 entries and contracts/perf/ratchet.json has 21,964. The +13 consists of one app-sidebar.svelte #each:10a1aaf3137a2426 pin in each of 13 categories. The first perf-lint run stopped before full validation because this worktree has no node_modules; Bun resolved TypeScript 7.0.2 while bun.lock pins 6.0.3. I will install locked dependencies, then use perf-lint to verify all stale and moved pins before editing the contracts.

Finding: after fast-forwarding to origin/dev de654a42a, contracts/perf/exceptions.json has 21,977 entries and contracts/perf/ratchet.json has 21,964. The +13 consists of one app-sidebar.svelte #each:10a1aaf3137a2426 pin in each of 13 categories. The first perf-lint run stopped before full validation because this worktree has no node_modules; Bun resolved TypeScript 7.0.2 while bun.lock pins 6.0.3. I will install locked dependencies, then use perf-lint to verify all stale and moved pins before editing the contracts.

kayg commented

2026-10-05 15:35:20 +00:00

Author

Owner

Finding: the full source inventory on merged origin/dev reports 22,115 findings, 1,051 ledger identities that are no longer live, and 1,189 current findings without exact pins. The repo provides scripts/perf-lint --adopt-7c as the owner-approved #1058 checkpoint to reconcile exact current sites. I will inspect its resulting ledger, adoption list and per-rule ratchet deltas; the guard rules remain unchanged.

kayg commented

2026-10-05 15:44:57 +00:00

Author

Owner

The #1058 generator re-pinned the current source inventory to 22,115 exact findings and expanded the adoption checkpoint to 4,543 sites. Its self-check then exposed a base inconsistency: origin/dev ratchet is one below its own ledger in 12 rules (contract.blaze, contract.blocked-network, contract.dom-bound, contract.model-bound, contract.row-identity, contract.snapshot, coverage.profile, coverage.readiness, render.blaze-adapter, render.bound, render.model_byte_cap, render.model_row_cap). These are existing baseline scopes; the current source still contains them. I will correct only this exact baseline shortfall, with no allowance for new scopes, and add tests that keep ordinary growth blocked. docs/perf/baseline.json contains measured performance data, not perf-lint exception state; perf-lint does not read or update it, so I will preserve its recorded measurements.

kayg commented

2026-10-05 15:57:10 +00:00

Author

Owner

The first bun run check run confirms the new ordering: perf-lint passed with 0 violations, the remaining token guards ran, and svelte-check completed with 0 errors and 4 warnings. check-user-storage reported four identifier uses in clientRouteStatus.svelte.ts. They belong to a constant-key, tab-only boolean reload latch and contain no User data. I will add an exact allowlist entry for this same-origin retry state and rerun the final web gates.

The first `bun run check` run confirms the new ordering: perf-lint passed with 0 violations, the remaining token guards ran, and svelte-check completed with 0 errors and 4 warnings. `check-user-storage` reported four identifier uses in clientRouteStatus.svelte.ts. They belong to a constant-key, tab-only boolean reload latch and contain no User data. I will add an exact allowlist entry for this same-origin retry state and rerun the final web gates.

kayg commented

2026-10-05 16:08:24 +00:00

Author

Owner

The full bun run test is still running. Vitest has reported two existing failures in untouched Calendar tests: agenda.svelte.test.ts (collapsed attachment deck count/no hover popover, #822) and audioPlayback.svelte.test.ts (pointer Play control tab order). I will capture their full diagnostics and suite totals. I will not change either expectation in this issue.

The full `bun run test` is still running. Vitest has reported two existing failures in untouched Calendar tests: `agenda.svelte.test.ts` (collapsed attachment deck count/no hover popover, #822) and `audioPlayback.svelte.test.ts` (pointer Play control tab order). I will capture their full diagnostics and suite totals. I will not change either expectation in this issue.

kayg commented

2026-10-05 16:10:35 +00:00

Author

Owner

The full Vitest run has reported two additional failures in untouched unit tests: font-weight-token.test.ts rejects numeric font-weight declarations outside tokens, and date-formatting.test.ts expects shared date/locale formatting to stay inside packages/ui/src/time.ts. They are not caused by files in this change. The suite is still running; I will preserve these expectations and report the full results.

The full Vitest run has reported two additional failures in untouched unit tests: `font-weight-token.test.ts` rejects numeric font-weight declarations outside tokens, and `date-formatting.test.ts` expects shared date/locale formatting to stay inside `packages/ui/src/time.ts`. They are not caused by files in this change. The suite is still running; I will preserve these expectations and report the full results.

kayg commented

2026-10-05 16:14:44 +00:00

Author

Owner

Completed #1133 on job/perflint-1133.

Changes

Reconciled the exact perf exception pins and #1058 adoption checkpoint with current dev source: 22,115 live scoped exceptions; removed stale identities and adopted/re-pinned moved findings. Updated contracts/perf/exceptions.json, contracts/perf/ratchet.json, and contracts/perf/adoption-1058.json.
Fixed perf-lint's base-ratchet repair so it only repairs a baseline-scope deficit backed by the exact #1058 checkpoint or current exact pin; new scopes still require checkpoint entries and future growth remains ratcheted. Added regression tests and documented the behavior.
Made apps/web's check run every guard and svelte-check after a perf-lint failure, then return non-zero if any stage fails.
Documented the exact fixed-key, tab-only retry latch in the user-storage guard allowlist. It contains no User data.

Ratchet total changed from 21,964 to 22,115 (+151). Per-rule changes recorded in the contract commit:

cache.raw-read +2
contract.blaze +1
contract.blocked-network +1
contract.dom-bound +1
contract.model-bound +1
contract.row-identity +1
contract.snapshot +1
coverage.operations +1
coverage.profile +1
coverage.readiness +1
coverage.routers +1
io.awaited-worker +6
io.unresolved-call +129
render.blaze-adapter +1
render.bound +1
render.model_byte_cap +1
render.model_row_cap +1

Files

contracts/perf/adoption-1058.json
contracts/perf/exceptions.json
contracts/perf/ratchet.json
scripts/perf_guards/adoption.py
scripts/perf_guards/runner.py
scripts/perf_guards/test_adoption.py
apps/web/package.json
apps/web/scripts/check-user-storage.mjs

docs/perf/baseline.json remains unchanged: it stores measured performance results, and this issue did not add a performance workload or take a measurement. The perf-lint contracts are source findings, not performance measurements.

Verification

bun run check passed. Relevant output, verbatim:

perf-lint: PASS; 0 violations; 22115 scoped exceptions
User browser caches use userStorage; only documented device/public-link exceptions remain.
Glass alpha, blur and backdrop-filter roles use packages/ui/src/tokens.css.
Text sizes and UI shape values use shared role tokens.
Keyboard focus rings use the shared focus tokens.
UI transitions and animation options use shared motion tokens or documented exceptions.
svelte-check found 0 errors and 4 warnings in 3 files

bun run test ran to completion but exited 1. Final output, verbatim:

 Test Files  4 failed | 258 passed (262)
      Tests  4 failed | 1800 passed (1804)
   Start at  18:03:08
   Duration  440.96s (transform 35%, environment 24%, import 21%, tests 15%, setup 5%)

error: script "test" exited with code 1

The four failures are in untouched current-dev tests: Agenda attachment deck expected +3 but received +5; audio playback test queried a missing Play button; font-weight token guard found numeric weight 700 in packages/ui/src/components/ModeIcon.svelte:49; date formatter guard found a direct formatter in apps/web/src/lib/search/SearchPreview.svelte. I did not change their expectations or unrelated code. svelte-check reported 0 errors and 4 existing warnings (two empty CSS rulesets and two unused selectors).

Decisions

Kept docs/perf/baseline.json unchanged because it records runtime measurements and no comparable profile was measured for this source-contract repair.
Limited base ratchet repair to deficits already represented by exact live pins/checkpoint entries, so this fixes the existing 1-count-per-rule drift without authorizing additional findings.
Allowed only the four exact sessionStorage operations used by the fixed-key tab retry latch; these are not User storage.

Commits:

ef5e4bbd1 Reconcile perf pins and ratchet with current dev
56e5a9a7e Run every web check after perf-lint errors

Head SHA: 56e5a9a7e1e3441dd8b8bbcb0e7660e41037fb3e.

Completed #1133 on `job/perflint-1133`. ## Changes - Reconciled the exact perf exception pins and #1058 adoption checkpoint with current dev source: 22,115 live scoped exceptions; removed stale identities and adopted/re-pinned moved findings. Updated `contracts/perf/exceptions.json`, `contracts/perf/ratchet.json`, and `contracts/perf/adoption-1058.json`. - Fixed perf-lint's base-ratchet repair so it only repairs a baseline-scope deficit backed by the exact #1058 checkpoint or current exact pin; new scopes still require checkpoint entries and future growth remains ratcheted. Added regression tests and documented the behavior. - Made `apps/web`'s `check` run every guard and `svelte-check` after a perf-lint failure, then return non-zero if any stage fails. - Documented the exact fixed-key, tab-only retry latch in the user-storage guard allowlist. It contains no User data. Ratchet total changed from 21,964 to 22,115 (+151). Per-rule changes recorded in the contract commit: ``` cache.raw-read +2 contract.blaze +1 contract.blocked-network +1 contract.dom-bound +1 contract.model-bound +1 contract.row-identity +1 contract.snapshot +1 coverage.operations +1 coverage.profile +1 coverage.readiness +1 coverage.routers +1 io.awaited-worker +6 io.unresolved-call +129 render.blaze-adapter +1 render.bound +1 render.model_byte_cap +1 render.model_row_cap +1 ``` ## Files - `contracts/perf/adoption-1058.json` - `contracts/perf/exceptions.json` - `contracts/perf/ratchet.json` - `scripts/perf_guards/adoption.py` - `scripts/perf_guards/runner.py` - `scripts/perf_guards/test_adoption.py` - `apps/web/package.json` - `apps/web/scripts/check-user-storage.mjs` `docs/perf/baseline.json` remains unchanged: it stores measured performance results, and this issue did not add a performance workload or take a measurement. The perf-lint contracts are source findings, not performance measurements. ## Verification `bun run check` passed. Relevant output, verbatim: ``` perf-lint: PASS; 0 violations; 22115 scoped exceptions User browser caches use userStorage; only documented device/public-link exceptions remain. Glass alpha, blur and backdrop-filter roles use packages/ui/src/tokens.css. Text sizes and UI shape values use shared role tokens. Keyboard focus rings use the shared focus tokens. UI transitions and animation options use shared motion tokens or documented exceptions. svelte-check found 0 errors and 4 warnings in 3 files ``` `bun run test` ran to completion but exited 1. Final output, verbatim: ``` Test Files 4 failed | 258 passed (262) Tests 4 failed | 1800 passed (1804) Start at 18:03:08 Duration 440.96s (transform 35%, environment 24%, import 21%, tests 15%, setup 5%) error: script "test" exited with code 1 ``` The four failures are in untouched current-dev tests: Agenda attachment deck expected `+3` but received `+5`; audio playback test queried a missing Play button; font-weight token guard found numeric weight `700` in `packages/ui/src/components/ModeIcon.svelte:49`; date formatter guard found a direct formatter in `apps/web/src/lib/search/SearchPreview.svelte`. I did not change their expectations or unrelated code. `svelte-check` reported 0 errors and 4 existing warnings (two empty CSS rulesets and two unused selectors). ## Decisions - Kept `docs/perf/baseline.json` unchanged because it records runtime measurements and no comparable profile was measured for this source-contract repair. - Limited base ratchet repair to deficits already represented by exact live pins/checkpoint entries, so this fixes the existing 1-count-per-rule drift without authorizing additional findings. - Allowed only the four exact sessionStorage operations used by the fixed-key tab retry latch; these are not User storage. Commits: - `ef5e4bbd1 Reconcile perf pins and ratchet with current dev` - `56e5a9a7e Run every web check after perf-lint errors` Head SHA: `56e5a9a7e1e3441dd8b8bbcb0e7660e41037fb3e`.

kayg referenced this issue

2026-10-05 16:17:27 +00:00

dev: 4 failing web unit tests (Agenda count, voice Play, ModeIcon weight literal, SearchPreview formatter) #1159

kayg referenced this issue

2026-10-05 16:21:45 +00:00

Inspector: Versions flicker, wrong Note copy, title against top edge, Share orphaned outside the header pill #1129

kayg commented

2026-10-05 17:43:20 +00:00

Author

Owner

Starting work on job/perflint-1133 at 56e5a9a7e1; branch base is de654a42ac. I fetched origin/dev at a493c314ed and will merge it, then reconcile exact live pins without weakening rules.

Starting work on job/perflint-1133 at 56e5a9a7e1e3441dd8b8bbcb0e7660e41037fb3e; branch base is de654a42ac4f9a6dca83bed8e0eebc99706f7df. I fetched origin/dev at a493c314edfd40027a72e0d7fc1cb97fa69b1eb9 and will merge it, then reconcile exact live pins without weakening rules.

kayg commented

2026-10-05 17:49:20 +00:00

Author

Owner

After merging a493c314, the guard reaches source analysis but the merged ledger has stale pins: first reported scope is coverage.surfaces for apps/web/src/lib/canvas/CanvasView.svelte#each:3a4cbef6167607e4:1. The guard aborts on the first stale pin, so I am reconciling by exact live scope and hash before checking the complete ledger.

After merging a493c314, the guard reaches source analysis but the merged ledger has stale pins: first reported scope is coverage.surfaces for apps/web/src/lib/canvas/CanvasView.svelte#each:3a4cbef6167607e4:1. The guard aborts on the first stale pin, so I am reconciling by exact live scope and hash before checking the complete ledger.

kayg commented

2026-10-05 17:52:43 +00:00

Author

Owner

The full live scan finds 22,115 sites, matching the merged ledger's rule counts. Every live scope is pinned; 630 hashes are stale, and there are no live scopes without a pin. I will refresh only exact live identities through the existing #1058 adoption checkpoint; the current ratchet already equals the live per-rule counts, so this reconciliation must not raise it.

kayg commented

2026-10-05 18:01:03 +00:00

Author

Owner

Finished #1133

Branch: job/perflint-1133
Merged origin/dev at a493c314edfd40027a72e0d7fc1cb97fa69b1eb9. The branch retains 56e5a9a7e1e3441dd8b8bbcb0e7660e41037fb3e.
Head: 5874301d443d9e48f8af04e9c58469de715881da (perf: refresh exact pins after dev merge). No push.

Built

Reconciled contracts/perf/exceptions.json and contracts/perf/adoption-1058.json against the current parsed source. All 22,115 live findings have pins; refreshed stale hashes through the existing exact-site #1058 checkpoint. contracts/perf/ratchet.json is unchanged from the pre-merge branch head at 22,115, with no per-rule ceiling increase.

Verification

scripts/perf-lint --adopt-7c:

Adopted 5033 exact #1058 sites; ordinary future ratchet remains active
perf-lint: PASS; 0 violations; 22115 scoped exceptions

cd apps/web && bun run check (exit code 0; verbatim output excerpt, omitting the verbose per-pin DEBT rows):

perf-lint: parse Rust product sources
perf-lint: parse browser product sources
perf-lint: validate coverage and architecture
perf-lint: PASS; 0 violations; 22115 scoped exceptions
User browser caches use userStorage; only documented device/public-link exceptions remain.
Glass alpha, blur and backdrop-filter roles use packages/ui/src/tokens.css.
Text sizes and UI shape values use shared role tokens.
Keyboard focus rings use the shared focus tokens.
UI transitions and animation options use shared motion tokens or documented exceptions.
Loading svelte-check in workspace: /home/kayg/Developer/calternal-wt/perflint-1133/apps/web
Getting Svelte diagnostics...
svelte-check found 0 errors and 4 warnings in 3 files

cargo clean:

Removed 1 file, 356B total

Known gaps

Svelte reported two empty CSS rulesets in AttachmentDeck.svelte and AgendaList.svelte, plus unused .note-page-lede and .note-state selectors in apps/web/src/routes/notes/+page.svelte. These are existing warnings outside the perf contract files. No unit tests were run or changed; the four failing tests remain with their owning job.

Decisions

None beyond using the existing #1058 exact-site reconciliation path. No design or guard rule changed.

# Finished #1133 Branch: `job/perflint-1133` Merged `origin/dev` at `a493c314edfd40027a72e0d7fc1cb97fa69b1eb9`. The branch retains `56e5a9a7e1e3441dd8b8bbcb0e7660e41037fb3e`. Head: `5874301d443d9e48f8af04e9c58469de715881da` (`perf: refresh exact pins after dev merge`). No push. ## Built Reconciled `contracts/perf/exceptions.json` and `contracts/perf/adoption-1058.json` against the current parsed source. All 22,115 live findings have pins; refreshed stale hashes through the existing exact-site #1058 checkpoint. `contracts/perf/ratchet.json` is unchanged from the pre-merge branch head at 22,115, with no per-rule ceiling increase. ## Verification `scripts/perf-lint --adopt-7c`: ```text Adopted 5033 exact #1058 sites; ordinary future ratchet remains active perf-lint: PASS; 0 violations; 22115 scoped exceptions ``` `cd apps/web && bun run check` (exit code 0; verbatim output excerpt, omitting the verbose per-pin `DEBT` rows): ```text perf-lint: parse Rust product sources perf-lint: parse browser product sources perf-lint: validate coverage and architecture perf-lint: PASS; 0 violations; 22115 scoped exceptions User browser caches use userStorage; only documented device/public-link exceptions remain. Glass alpha, blur and backdrop-filter roles use packages/ui/src/tokens.css. Text sizes and UI shape values use shared role tokens. Keyboard focus rings use the shared focus tokens. UI transitions and animation options use shared motion tokens or documented exceptions. Loading svelte-check in workspace: /home/kayg/Developer/calternal-wt/perflint-1133/apps/web Getting Svelte diagnostics... svelte-check found 0 errors and 4 warnings in 3 files ``` `cargo clean`: ```text Removed 1 file, 356B total ``` ## Known gaps Svelte reported two empty CSS rulesets in `AttachmentDeck.svelte` and `AgendaList.svelte`, plus unused `.note-page-lede` and `.note-state` selectors in `apps/web/src/routes/notes/+page.svelte`. These are existing warnings outside the perf contract files. No unit tests were run or changed; the four failing tests remain with their owning job. ## Decisions None beyond using the existing #1058 exact-site reconciliation path. No design or guard rule changed.

kayg referenced this issue

2026-10-05 18:07:26 +00:00

Tags: clicking a tag filters the current view (chip, ⌘-click AND, deep-linkable) #1109

kayg referenced this issue

2026-10-05 20:18:22 +00:00

Tasks Board: live drop preview while dragging over a column #1118

kayg referenced this issue

2026-10-05 20:22:51 +00:00

Money import wizard: start, upload, live import steps, review cards, failure page #1140

kayg referenced this issue

2026-10-05 20:38:30 +00:00

Tasks Board: live drop preview while dragging over a column #1118