Audit: remove local restyling of shared components and hand-rolled controls app-wide #1190
Open
opened 2026-10-06 08:07:40 +00:00 by kayg
·
44 comments
No Branch/Tag specified
dev
wip/tagperf-1186
wip/sidebar3-1094
wip/segmented-1200
job/tagperf-1186
wip/rev2-webperf
wip/rev2-money-ident
wip/restyle-mailmoney
wip/restyle-files
wip/previewcard-1098
wip/palette2-1123
wip/palette-1093
wip/onboard2-1141
wip/onboard-1141.aborted-early
wip/onboard-1141
wip/nlpchip-1127
wip/morph-1104
wip/merge-round-7c5
wip/merge-round-7c4
wip/merge-round-7c3
wip/merge-round-7c2
wip/merge-round-7c
wip/mchrome-1084
wip/mailghost2-1094
wip/mailghost-1094
wip/kbpreview2-1118
wip/kbpreview-1118
wip/kanban-1092
wip/importhang-1121
wip/hiderev-1153
wip/hide4-1153
wip/hide3-1153
wip/hide2-1153
wip/hide-1153
wip/editreg-1132
wip/editorrail3-1113
wip/editorrail2-1113
wip/editorrail-1113
wip/e2e-b2-1071
wip/e2e-b-1071
wip/draw4-1101
wip/draw3-1101
wip/draw2-1101
wip/draw-1101
wip/directory-1199-r
wip/directory-1199
wip/delete-1119
wip/cards2-1083
wip/cards-1083
wip/canvas-visual
wip/canvasvis2-976
wip/calhdr-1112
wip/calcards-1115
wip/browserfix
wip/blocks-1125
job/collabloss-1197
wip/allday-1107
wip/agenda-decks
wip/agenda-1086
wip/adv7c-1105
wip/txentry-1198
wip/trayicons2-1095
wip/trayicons-1095
wip/collabrev-1197
wip/collabloss2-1197
wip/collabloss-1197
job/merge30
job/restyle-notes
job/adv-1202
job/notifloop-1194
job/restyle-mailmoney
job/onboard-1141
wip/restyle-notes
job/segmented-1200
job/hide-1153
wip/notifloop-1194
job/txentry-1198
job/perf-1124
job/perf2-1124
job/tocrail-1191
job/restyle-settings
wip/restyle-settings
job/restyle-files
job/tagdnd-1187
job/cards-1179
wip/cards2-1179
wip/cards-1179
wip/tocrail-1191
wip/tagdnd-1187
wip/perf-1124
wip/merge30j
job/wizchoices-1140
wip/wizchoices-1140
wip/restyle-1190
job/moneyfmt-1180
wip/moneyfmt2-1180
wip/moneyfmt-1180-r
wip/moneyfmt-1180
job/pillglass-1189
job/flags-1181
wip/flags-1181
job/restyle-1190
job/restyle-search
job/settingsreg-1195
job/wizard-1140
site/website
wip/wizardrev2-1140
wip/wizardrev-1140
wip/wizard5-1140
wip/wizard4-1140
wip/wizard3-1140
wip/wizard2-1140
wip/wizard-1140
wip/pillglass-1189
wip/settingsreg-1195
job/merge29
job/fu-1171
wip/merge29j
wip/fu-1171
job/fu-1166
job/directory-1199
job/proflog-1204
job/txresearch-1188
wip/fu-1166
job/merge28
job/search-1066
wip/search-1066
wip/merge28j
job/gateslot-1182
job/bulkimport-1157
job/mailnet-1160
wip/mailnetrev-1160
wip/mailnet-1160
wip/bulkrev-1157
wip/bulkimport-1157
job/startup-1161
wip/startup-1161
job/merge27
job/linkcards-1151
wip/linkcards3-1151
wip/linkcards2-1151
wip/linkcards-1151
job/traydate-1144
wip/traydate3-1144
wip/traydate2-1144
wip/traydate-1144
job/draw-1101
wip/merge27j
job/blockpill-1152
wip/blockpill3-1152
wip/blockpill2-1152
wip/blockpill-1152
job/minihover-1149
wip/minihover2-1149
wip/minihover-1149
job/merge25
wip/merge25-r
wip/merge25b
wip/merge25
job/inspector-1129
job/tags-1110
wip/inspector3-1129
wip/inspector2-1129
wip/inspector-1129
wip/tagsrev-1110
wip/tags2-1110
wip/tags-1110
job/dates-1148
wip/datesrev-1148
wip/dates2-1148
wip/dates-1148
job/licence-1145
wip/licence2-1145
wip/licence-1145
job/selfhost-1156
job/merge23
wip/merge23
job/tagfilter-1109
wip/tagfilter2-1109
wip/tagfilter-1109
job/kbd-1134
wip/kbd2-1134
wip/kbd-1134
job/palfoot-1137
wip/selfhost-1156
wip/palfoot2-1137
wip/palfoot-1137
job/toggle-1158
wip/toggle-1158
job/kbpreview-1118
job/docratchet-1155
job/perflint-1133
job/devtests-1159
wip/docratchet-1155
wip/devtests-1159
job/segv-1136
wip/toast-1142
wip/segv-1136
job/toast-1142
job/blockreload-1147
wip/blockreload-1147
job/font-1150
wip/font-1150
job/importui-1120
job/minimonth-1149
wip/importui-1120
wip/minimonth-1149
job/depcheck-1146
wip/perflint-1133
wip/depcheck-1146
job/calcards-1115
job/blocks-1125
job/plus-1128
job/shift-1138
wip/plus2-1128
wip/plus-1128
wip/shift-1138
job/moneyfid-1130
job/editorrail-1113
wip/moneyrev-1130
wip/moneyfid-1130
job/noext-851
wip/noext-851
wip/noext3-851
wip/noext2-851
job/week-1135
wip/week-1135
job/editreg-1132
job/smoke-1122
wip/smoke-1122
job/docs-1143
job/palette2-1123
job/calhdr-1112
job/nlpchip-1127
job/mailghost-1094
job/reconnect-1131
wip/reconnect-1131
job/trayicons-1095
job/delete-1119
job/importhang-1121
job/cards-1083
job/palette-1093
job/mchrome-1084
job/e2e-a-1071
job/canvas-visual
job/previewcard-1098
job/allday-1107
wip/e2e-a2-1071
wip/e2e-a-1071
job/e2e-b-1071
job/adv7c-1105
job/kanban-1092
job/agenda-1086
job/merge-round-7c
job/morph-1104
wip/surfaces-p2
job/merge-round-9
wip/merge-round-9
job/7cfix-small
wip/7cfix-small
job/mailui-1078
job/merge-round-8
wip/merge-round-8
wip/mailui-1078
job/mailround-1038
job/applemail-accept
wip/settitle-1068
wip/mailround2-1038
wip/mailround-1038
wip/e2e-7b
job/crash-1069
wip/crash-1069
job/searchlost-1066
wip/searchlost-1066
job/7b-reconcile
job/flake-1065
wip/flake-1065
wip/merge-round-7b7
wip/merge-round-7b6
wip/merge-round-7b5
wip/merge-round-7b4
wip/7b-reconcile
job/appupdate-1059
job/nfd-1044
wip/appupdate-1059
job/e2e-7b
job/loop-1062
wip/loop-1062
job/pdfprev-1045
job/invtoggle-1053
wip/pdfprev-1045
wip/nfd-1044
wip/invtoggle-1053
job/7bfix-e2e
job/mailstress-b
wip/7bfix-e2e
wip/mailstress-b
job/7bfix-adv
wip/7bfix-adv
job/mailstress-a
job/stack-1054
wip/stack-1054
wip/mailstress-a
job/mailstress-1038
wip/mailstress-1038
job/upload500-1051
wip/upload500-1051
job/share-1034
wip/share-1034
job/syncerr-1037
job/7bfix-photos
wip/7bfix-photos
job/paste-1036
job/setside-1039
wip/setside-1039
wip/paste-1036
job/lease-1042
wip/syncerr-1037
wip/lease-1042
job/7bfix-data
job/passkeybind-1043
wip/apprevoke-1041
job/invite-1035
wip/invite-1035
job/merge-round-7b2
wip/merge-round-7b2
job/mailproxy-486
job/apprevoke-1041
job/rebuild-1033
job/pillborder-1029
wip/pillborder-1029
wip/mailproxy-486
wip/applemail-486
job/headless-998
wip/headless-998
job/groups-1028
wip/groups-1028
job/rebuildwarn-1016
wip/rebuildwarn-1016
job/startup-1011
wip/startup-1011
job/monthpill-1009
job/bgthumb-1025
job/sharetitle-1012
wip/monthpill-1009
wip/bgthumb-1025
wip/sharetitle-1012
job/canvas-cards-977
wip/canvas-cards-977
job/canvas-pencil-978
job/canvas-sketch-990
wip/canvas-sketch-990
wip/canvas-pencil-978
job/canvas-files-989
wip/canvas-files-989
job/canvas-collab-991
wip/canvas-collab-991
job/weekscroll-1018
wip/weekscroll-1018
wip/canvas-core-976
job/canvas-core-976
job/round-drag
wip/round-drag
job/round-settings
job/browserfix
wip/oapi-974
job/oapi-974
job/hist2-integrate
job/mailhtml-726
wip/mailhtml-726
wip/hist2-integrate
job/moneyfu-984
job/drag-1015
wip/drag-1015
job/rename-1017
wip/rename-1017
job/hist2-api
wip/hist2-api
job/oneacct-1014
wip/oneacct-1014
wip/moneyfu-984
job/hist2-bench
job/hist2-restore
wip/hist2-bench
job/hist2-write
job/hotfix-724
wip/hotfix-724
wip/hist2-write
wip/hist2-restore
job/hist2-store
job/hist2-ui
wip/hist2-ui
wip/hist2-store
job/searchstarve-965
job/shutdown-963
wip/shutdown-963
wip/pubedit-981
job/pubedit-981
job/analytics-973
wip/searchstarve-965
job/authflash-850
job/weeklane-969
job/pvtitle-1004
job/hist-975
wip/authflash-850
job/voicepill-617
wip/pvtitle-1004
job/headring-1003
wip/weeklane-969
wip/voicepill-617
wip/headring-1003
wip/analytics-973
job/agentscope-980
wip/thumbsandbox-988
job/thumbsandbox-988
wip/hist-975
job/links-856
wip/links-856
job/davetag-966
wip/davetag-966
job/filesstorm-1000
job/hoverpad-725
wip/filesstorm-1000
job/ffmpegblas-993
job/merge-round-7a
wip/hoverpad-725
wip/ffmpegblas-993
job/nowdot-1002
wip/verify-7a
job/noteid-857
wip/nowdot-1002
wip/noteid-857
wip/merge-round-7a
wip/agentscope-980
job/imapedge
job/a11yfix2
wip/imapedge-941
wip/imapedge
wip/a11yfix2
job/notetask-986
job/logheading
wip/logheading-998
job/textthumb-652
job/photolive-987
wip/photolive-987
job/davactive-983
job/savefix-985
job/tabicons-607
wip/davactive-983
wip/tabicons-607
wip/notetask-986
wip/savefix-985
job/dirid-627
job/buildspeed-1007
wip/dirid-627
job/agenda-decks
job/perfguards-impl
job/undo-a11y
wip/undo-a11y
job/mailperf
job/wal-824
wip/settings-50
job/settings-50
job/notesfilter-606
wip/notesfilter-606
job/surfaces-p2
wip/wal-824
job/maillayouts
wip/mailperf
wip/maillayouts
job/taskmeta-659
job/money-ident
wip/money-ident
wip/taskmeta-659
job/errstates
wip/perfguards-impl
job/headings-881
wip/headings-881
wip/errstates
job/voice-619
job/gaps-827
job/notesperf
wip/notesperf
wip/voice-619
job/hddsql-549
job/perf-stream-668
wip/perf-stream-668
wip/deeplinks-fix
job/deeplinks-fix
job/authfix
job/docsfix-rust
wip/docsfix-rust
job/webperf
job/docsfix-web
job/datafix2
job/webdav-lock-476
job/copyfix
wip/copyfix
wip/webperf
job/focus-658
wip/protofix
job/mediafix
job/protofix
wip/mediafix
job/agentfix
job/hhmm-724
wip/agentfix
job/undo-722
job/reuse
wip/webdav-lock-476
wip/reuse
job/scopefix
job/datafix
wip/hhmm-724
wip/undo-722
job/surfaces-p1
wip/hddsql-549
job/voicememos-618
wip/datafix2
wip/surfaces-p1
job/fix-940
wip/fix-940
job/blaze-surfaces
wip/datafix
wip/blaze-surfaces
job/taskday-655
job/linknav-639
wip/linknav-639
wip/gaps-827
job/isolation-707
job/audiophotos-720
wip/audiophotos-720
job/advfind-664
wip/voicememos-618
wip/taskday-655
wip/isolation-707
wip/advfind-664
wip/scopefix
wip/focus-658
job/testgaps
wip/testgaps
job/overscroll-718
wip/authfix
job/deps
wip/overscroll-718
job/rev2-agentfix
job/rev2-money-ident
job/rev2-mailperf
wip/deps
job/hardening-728
wip/hardening-728
job/searchgen-832
wip/searchgen-832
job/photopw-849
job/mailsql-825
wip/photopw-849
job/sharefix
wip/sharefix
job/rev2-mailhtml-726
job/rev2-perfguards
job/copyval-723
job/lightglass-r2
wip/lightglass-r2
wip/docsfix-web
job/copy-audit
job/macinterop-staging-r2
job/design-sync
job/rev2-taskmeta-659
job/rev2-webperf
job/docs-audit
job/rev2-advfind-664
job/rev2-mailproxy-486
job/states-audit
job/rev2-datafix
job/design-drift
job/test-gaps
job/rev2-voicememos-618
job/rev2-mediafix
job/rev2-deps
job/rev2-datafix2
job/licence-audit
job/issue-hygiene
job/rev2-protofix
job/rev2-voice-619
job/rev2-isolation-707
job/rev2-surfaces-p1
job/deeplink-audit2
job/rev2-audiophotos-720
wip/test-gaps
job/rev2-overscroll-718
job/rev2-undo-722
wip/states-audit
job/rev2-dropmd-719
job/rev2-linknav-639
job/merge-7b-plan
wip/merge-7b-plan
job/rev2-taskday-655
wip/mailsql-825
job/rev2-webdav-lock-476
job/rev2-browserfix
wip/design-drift
job/rev2-hddsql-549
wip/deeplink-audit2
job/rev2-scopefix
job/rev2-authfix
job/rev2-hardening-728
job/rev2-wal-824
job/rev2-sharefix
job/calsidebar-638
job/chrome-audit
job/ioperf
wip/ioperf
wip/chrome-audit
wip/calsidebar-638
job/dropmd-719
wip/dropmd-719
job/ocr-build
wip/ocr-build
job/blaze-settings
wip/copyval-723
job/toastring-721
wip/toastring-721
job/deployfix-732
wip/deployfix-732
wip/blaze-settings
job/money-import-recheck
job/rev-a11y
job/perf-arch-db
job/rev-7b-data
wip/textthumb-652
wip/perf-arch-db
job/sec-protocols
job/sidehdr-660
job/rev-7b-security
job/research-surfaces
job/rev-design-gaps
job/rev-mcp-api
wip/sidehdr-660
job/perf-arch-memory
wip/sec-protocols
job/perf-arch-bundle
job/snapedge-714
wip/rev-mcp-api
job/sec-supplychain
wip/research-surfaces
job/perf-arch-sync
job/rev-consistency
job/perf-arch-server
wip/perf-arch-server
wip/perf-arch-memory
job/perf-arch-io
job/perf-arch-client
job/sec-fs
job/sec-mcp-scopes
job/sec-sharing
job/perf-guards
job/sec-browser
job/sec-admin-deploy
job/sec-auth
wip/snapedge-714
job/bgpicker-717
wip/perf-arch-bundle
wip/money-import-recheck
job/advsetup-654
wip/bgpicker-717
wip/advsetup-654
job/burst-709
job/kbdcaps-710
job/app-pw-chooser
wip/burst-709
wip/app-pw-chooser
job/imaptest-625
wip/kbdcaps-710
job/fix-499
wip/fix-499
job/perf-mut-667
job/calimg-589
job/perf-snap-666
wip/calimg-589
wip/perf-snap-666
wip/perf-mut-667
job/perf-cache-665
wip/perf-cache-665
job/voicefiles-620
wip/voicefiles-620
job/admin-burst-705
wip/admin-burst-705
job/voicememos-review
wip/voicememos-review
wip/ryw-653
job/ryw-653
job/writeonopen-661
job/instant-663
wip/writeonopen-661
job/money-import-review
wip/money-import-review
wip/importjs-610
review/integrations-407-round6
wip/integrations-review
job/dragghost-612
wip/dragghost-612
job/integrations
wip/integrations
job/decider-656
job/merge-round-6
job/perf-rerun
wip/merge-round-6
job/integrations-review-round5
job/selalign-576
wip/selalign-576
job/mcp-events-491
job/files-631
job/cal-e2e-569
wip/cal-e2e-569
job/reload-423
wip/reload-423
wip/mcp-events-491
wip/files-631
job/notesbridge-644
wip/notesbridge-644
job/editor-series
job/calcard-series
wip/calcard-series
job/mcp-events-review-491
wip/mcp-events-review
wip/editor-series
job/quirks-546
job/integrations-recheck
job/tocrail-636
wip/tocrail-636
wip/quirks-546
wip/reminders-643
job/reminders-643
wip/davscale-573
job/davscale-573
job/integrations-review
wip/ocr-eval-584
job/ocr-eval-584
job/esc-537
wip/esc-537
job/toastname-586
wip/toastname-586
job/submenu-579
wip/submenu-579
job/tasks-mode
wip/tasks-mode
job/agentdocs-630
job/dupwrite-634
wip/agentdocs-630
wip/dupwrite-634
job/lightglass-588
wip/lightglass-588
job/tabswitch-549
job/ghosttask-623
wip/ghosttask-623
job/toaststack-616
job/weekstate-609
job/mailsync-613
wip/mailsync-613
wip/weekstate-609
job/maildup-626
wip/tabswitch-549
wip/maildup-626
wip/toaststack-616
job/motion-611
wip/motion-611
job/tlstest-601
wip/tlstest-601
job/perf-495
job/floating-sheet
wip/floating-sheet
job/remdup-585
wip/remdup-585
job/fix-502
wip/fix-502
job/attachplay-622
job/perf-batch
wip/perf-batch-563
wip/perf-495
hotfix/mail-sync-diag
job/mail-m3
wip/mail-m3
job/attach-poof-603
job/calhover-608
job/editorbar-604
job/mentions-605
job/merge-round-4
job/allday-514
wip/merge-round-4
wip/allday-514
job/merge-round-4a
wip/merge-round-4a
job/sharestack-580
job/fix-501
wip/sharestack-580
wip/fix-501
job/perf-batch-563
job/apw-cache-review
wip/apw-cache-review
job/probe-520
wip/probe-520
job/mac-393
wip/mac-393
job/header-571
job/flake-513
wip/flake-513
job/docs-thumb-547
wip/header-571
job/webcal-572
wip/webcal-572
wip/shortcuts-542
job/shortcuts-542
wip/docs-thumb-547
job/caldav-stress
wip/caldav-stress
wip/sweep-478
job/apw-cache-512
wip/apw-cache-512
job/money-empty-540
wip/restart-505
wip/money-empty-540
wip/fix-510
job/restart-505
job/fix-503
job/perf-496
wip/perf-496
job/fix-498
wip/fix-498
job/info-inspector-465
wip/info-inspector-465
job/fix-510
job/fix-507
wip/fix-507
wip/fix-503
job/fix-493
job/money-kinds
wip/money-kinds
job/hygiene-548
job/merge-round-3
wip/fix-493
job/drag-snap-536
wip/merge-round-3
wip/merge-round-0930
wip/drag-snap-536
job/align-538
wip/align-538
job/bg-flash
wip/bg-flash
job/money-import
job/search-count-544
wip/search-count-544
wip/money-import
job/settings-key-541
wip/settings-key-541
job/toast-539
job/preview-421
wip/preview-421
wip/toast-539
job/tasks-500-531
job/title-plain-526
wip/title-plain-526
wip/tasks-500-531
job/notes-bridge
wip/parity-484
job/parity-484
job/files-slow
job/crash-525
wip/notes-bridge
wip/files-slow
wip/crash-525
job/kbd-motion-527
wip/bg-422
job/analytics-504
wip/analytics-504
wip/kbd-motion-527
job/upload-pill-523
wip/upload-pill-523
wip/tray-order
job/tray-order
wip/overflow-mid
wip/merge-round-2
job/perf-494
wip/perf-494
wip/mcp-fast-492
wip/motion-477
wip/asr-ab-489
wip/theme-variants-506
wip/overflow-511
wip/week-header-508
wip/attach-427
job/dav-delete-471
job/iso-435
wip/iso-435
wip/files-sel-keys
wip/dav-delete-471
job/align-253
job/siwc-490
wip/siwc-490
job/money-kinds-review
wip/align-253
wip/money-kinds-review
job/small-bugs-3
wip/overlay-title-487
wip/multiget-500
wip/hidden-420
wip/webcal-ui
wip/webcal-431
job/perf-367
job/location
wip/small-bugs-3
wip/location
wip/perf-367
wip/admin-deny-483
job/tag-unicode-473
wip/tag-unicode-473
job/blur-436
wip/photos-470
wip/blur-436
wip/small-bugs-4
wip/hunt-20260930
wip/settings-hdr-482
wip/chips-416
job/dedup-375
wip/dedup-375
job/doc-stack
wip/doc-stack
job/tokens-literals
wip/tokens-literals
job/jobs-leftovers
wip/send-fast
wip/paste-467
wip/money-numbers
job/money-plugin
wip/money-plugin
job/break-dav
wip/merge-batch
wip/crossday-469
wip/mac-verify
wip/mail-m2
wip/break-dav
wip/money-review2
job/money-md
job/modes-424
wip/money-md
wip/jobs-leftovers
job/agenda-413
wip/agenda-413
wip/modes-424
job/recog-417
wip/recog-417
wip/bounce-425
wip/ab-384-luna
job/webdav-perf
wip/webdav-perf
job/toast-ring
wip/toast-ring
job/money-review
wip/money-review
wip/micro-motion
wip/settings-card
wip/minical
job/notes-imap-428
job/least-priv
wip/ui-small-2
wip/flaky-426
wip/drag-end-418
job/jank
wip/jank
wip/least-priv
wip/docs-site
job/agenda
job/sec-batch
wip/sec-batch
wip/per-user-index
job/area-calendars
wip/area-calendars
job/parity
wip/parity
job/documents-research
wip/documents-research
job/test-infra
job/reminders-sync
wip/small-bugs-2
wip/reminders-sync
wip/gestures
job/google-oauth
wip/tags-merge
wip/tags
job/e2e-theme
wip/e2e-theme
job/icon-align
wip/test-infra
wip/select-align
wip/editor-385
job/voice
wip/webdav
job/webdav
job/app-pw-ui
job/editor-integrity
wip/editor-integrity
wip/voice
wip/quota
wip/cal-followups
wip/icon-align
job/composer-scale
wip/composer-scale
job/jobs-page
wip/jobs-page
job/hig-type
wip/hig-type
wip/app-pw-ui
job/motion-spring
job/mcp
wip/motion-spring
wip/mcp
job/small-bugs
wip/push-hosts
job/profile-sign
wip/touch-369
wip/profile-sign
job/mobile-focus
wip/mobile-focus
wip/ui-polish-354
wip/small-bugs
wip/dup-task
job/toast-polish
job/app-pw-scopes
wip/toast-polish
wip/app-pw-scopes
wip/cli-agent
wip/selection-pills
job/preview-attach
wip/preview-attach
job/dav-proppatch
wip/dav-proppatch
wip/cal-switcher
job/atomic-race
wip/atomic-race
job/photos-shared
wip/photos-shared
wip/cal-grid
wip/note-rewrite
wip/search-rebuild
job/mail-m1
job/paperless-import
wip/paperless-import
wip/mail-m1
wip/hidden-activity
wip/search-d
wip/pricing-research
wip/cursors
wip/auto-scheme
job/single-pills
wip/single-pills
wip/xuser-matrix
wip/money-format
wip/app-pw-setup
wip/purge-dos
wip/vault-health
wip/caldav-apple
wip/xuser-audit
wip/e2e-green
wip/tabbar
wip/adv-harness
wip/maple-mono
job/search-fix
wip/search-fix
wip/search-perf-c
job/adv-harness
wip/sidebar-headers
job/glass
wip/temp-index
job/polish
wip/polish
wip/file-protocols
wip/money-research
wip/glass
wip/voice-models
wip/collab-redo
job/voice-research
wip/hunt-20260928
wip/notes-actions-research
wip/search-pad
wip/search-perf
wip/search-sticky
wip/editor-undo
wip/chrome-rules
wip/motion
wip/appearance-research
wip/appearance
wip/audit-bugs
wip/cal-glass
wip/block-actions
wip/authz-order
wip/event-stripes
wip/chrome-sidebar
wip/auth-flaky
wip/robust-2
wip/gate-fix
wip/menu-blur
wip/import-calternaljs
wip/tray-fix
job/import-calternaljs
wip/index-order
wip/audit-fixes
wip/search-chevrons
research/mail
wip/phone-chrome
wip/dedup-break
wip/csp
wip/ui-audit
wip/select-toast
wip/perf
wip/flat-layout
wip/fonts
wip/event-tint
wip/sync-converge
wip/data-split
wip/glass-audit
wip/robustness
wip/sync-chaos
wip/search-thumbs
wip/fuzz
wip/menu-icons
wip/search-pill
wip/sync-changing
wip/heading-links
wip/date-formats
wip/a11y
wip/break-editor
wip/e2e-fix
wip/settings-sections
wip/sync-root-guard
wip/search-palette
wip/share-edit
job/toasts
wip/toasts
wip/cont-analytics
wip/authz-review
wip/popovers
wip/overlay-glass
wip/change-feed
wip/editor-modes
wip/composer-align
wip/cont-agenda
wip/agenda-merge
job/agent-conventions
wip/agent-conventions
wip/backend-misc
job/route-audit
wip/route-audit
wip/ui-batch
wip/heif-hardening
wip/grid-resize
wip/ask-page
wip/webmcp
job/deeplink-audit
wip/deeplinks
wip/shortcuts
wip/cont-tz-days
main
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set
Reference
kayg/calternal#1190
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Audit: local restyling and hand-rolled controls (owner, 2026-10-06: "why so many instances of custom components again?")
Example found: apps/web/src/lib/editor/format/BlockHoverActions.svelte wraps the shared
PillGroup frostedbut adds its own ProgressiveBlur+wash slab and a hand-styled ⋯ button with px literals (#1189 fixes that file).Do (whole repo, apps/web + packages):
:global(...)selectors into it, extra background/backdrop-filter/border/shadow/radius/hover colours, wrapper overlays); (b) draws its own button/pill/chip/menu/card/toggle instead of the shared one; (c) uses size/colour/radius/duration literals outside token files.artifacts/restyle-audit.mdand post it on this issue, grouped by Tab.:globaloverrides into shared primitive classes and on new hand-rolled<button class=…>controls in feature folders (with an allow-list for justified exceptions, each with a comment and issue link).Screenshots before/after of each changed surface at ACTUAL size (1x/2x), light + dark. Gates:
bun run check+bun run testquoted. Commit; comment with head SHA. Do not push.Starting #1190 in
job/restyle-1190, based onorigin/devat5301e020859c1d61b4a7f812a5049a64241203e8. I have readCLAUDE.md,docs/DESIGN.md, andCONTEXT.md. I am mapping shared primitive overrides, hand-rolled controls, and non-token visual literals acrossapps/webandpackagesbefore making small area commits.Initial full inventory from
5301e020859c1d61b4a7f812a5049a64241203e8. It groups findings by Tab and lists file, line, category, and the shared primitive or token family. The BlockHoverActions wash slab is assigned to #1189.Restyle audit — Forgejo #1190
Inventory from 2026-10-06 in apps/web and packages. Each entry has a file and line. Category (a) is a local style override of a shared primitive class or an extra surface around one. Category (b) is app-owned button, pill, chip, menu, card, or toggle markup and names the shared control to use. Category (c) is a literal control size, colour, radius, or duration outside token files and names the shared primitive.
Calendar (0 a, 1 b, 7 c)
(b)
(c)
Tasks (6 a, 10 b, 3 c)
(a)
(b)
(c)
Notes (8 a, 27 b, 11 c)
(a)
(b)
(c)
Files (6 a, 58 b, 1 c)
(a)
(b)
(c)
Photos (0 a, 7 b, 1 c)
(b)
(c)
Mail (2 a, 8 b, 0 c)
(a)
(b)
Money (0 a, 7 b, 0 c)
(b)
Search (9 a, 20 b, 14 c)
(a)
(b)
(c)
Settings (18 a, 34 b, 10 c)
(a)
(b)
(c)
Analytics (2 a, 5 b, 2 c)
(a)
(b)
(c)
Notifications (5 a, 3 b, 0 c)
(a)
(b)
Shared UI (16 a, 40 b, 53 c)
(a)
(b)
(c)
Tasks audit finding fixed at
d15075e81: TaskCard and TaskList styled shared Card/StatusPill internals through :global selectors, and TaskColumn hand-drew Add task. Card now owns compact padding, clipping, and DnD outline; StatusPill owns compact sizing; Pill owns the muted Add task control. Focused primitive and Tasks component tests passed. Exact #1058 hashes were refreshed for changed Task list sites; the ratchet did not change.Tasks workspace finding fixed at
cf1775319: List/Matrix Add task and the Task index Retry action used local button CSS. Both now use the shared muted Pill; the parent keeps only layout. TaskBoard/TaskList tests passed (7 tests), and the design-rule test passed against origin/dev.Finding: Task Inspector values and Task card overflow counts had local button/chip treatments instead of shared primitives. Replaced Inspector value buttons with
Pill shape="text"and shared semantic tones, and replaced the+Ncount span withPill shape="chip" tone="inset". Extended Pill with these shared variants, tests, and docs; local value paint and chip CSS are removed.Evidence:
bun run checkpassed (performance/token/type checks and Svelte check); focused Pill, Card, StatusPill, TaskBoard and TaskList tests passed: 5 files, 16 tests.node scripts/design-rules.test.mjspassed.Commit:
b95e6c04a6.Finding: Task List repeated the same local status sizing already represented by
StatusPill size="compact"and drew the hidden-tag count as a custom span. Removed the override and now render the count with the shared insetPillused by Task cards.Evidence:
TaskList.svelte.test.ts: 1 file, 4 tests passed;node scripts/design-rules.test.mjspassed; exact performance contract pins refreshed, without raising the ratchet. Commit:c74086679b.The design-rule regression test now scans changed Svelte/CSS in
apps/web/src/lib,apps/web/src/routes,packages/editor/src, andpackages/ui/src. It rejects new local primitive overrides in feature consumers and new hand-rolled classed buttons across those roots.packages/uiis excluded from the override check because a shared primitive must style its own composed internals; its native control markup remains guarded.node scripts/design-rules.test.mjspasses.Commit:
2b27975324.Coordination: #1200 owns SegmentedControl and all single-choice selector call sites; this audit leaves them alone and lists findings for them.
Final report — Forgejo #1190
Head SHA:
2b27975324bb1df94103b37cf8f90562390483e2Branch:
job/restyle-1190Status: The Tasks area and regression guard are implemented. The wider repo audit is not complete, so this branch is not ready to merge.
What changed
artifacts/restyle-audit.mdand posted the full inventory in the earlier issue comment.Card,Checkbox,Pill,StatusPillandTagPillcontrols.TasksWorkspacealso usesPillfor its Add and Retry actions. Existing action callbacks, task writes, tag filters and drag/drop behavior stay in place.CardwithoverflowanddropPreview;Pillwith the Inspectortextshape, shared hit floor andmuted,dangerandinsettones; andStatusPillwith acompactsize. Added component tests and package documentation.apps/web/scripts/design-rules.test.mjsto reject new shared-primitive:globaloverrides in web and Editor feature code, and new classed native buttons across web, Editor and shared UI source. A local exception needs an adjacent comment with an issue number and reason. The rule compares changes withorigin/devso the existing inventory does not fail the gate.Files
apps/web/scripts/design-rules.test.mjs,apps/web/package.jsonapps/web/src/lib/tasks/TaskCard.svelte,TaskColumn.svelte,TaskList.svelte,TaskList.svelte.test.ts,TaskSection.svelte,TasksWorkspace.svelteapps/web/src/lib/components/Card.svelte.test.ts,Pill.svelte.test.ts,StatusPill.svelte.test.tspackages/ui/src/components/Card.svelte,Pill.svelte,StatusPill.svelte,packages/ui/src/tokens.css,packages/ui/README.mdcontracts/perf/adoption-1058.json,contracts/perf/exceptions.jsonThe six commits are
aef181c,d15075e,cf17753,b95e6c0,c740866and2b27975. The worktree is clean. No Rust source changed.cargo cleancompleted at the end and the web build output was removed.UX gaps closed
UX gaps left
BlockHoverActions.svelteitem remains with #1189.Decisions not stated in DESIGN.md
Cardowns clipping and drag preview;Pillowns compact Inspector text actions and semantic tones;StatusPillowns compact status sizing.origin/devtree as its baseline and only rejects new signatures. Existing inventory entries remain visible for follow-up instead of being silently grandfathered as individual exceptions.Web gate output
bun run check:The two warnings are existing empty CSS rulesets in
packages/ui/src/components/calendar/AttachmentDeck.svelteandAgendaList.svelte.bun run test:Production screenshots
72 PNGs are attached to this issue: before and after for Tasks Board, Tasks List and Calendar Task Inspector at 390, 820 and 1440 px, in Paper light and Tokyo Night dark, at 1× and 2×. The production app used real server data and macOS platform emulation.
Open the 72-image screenshot index
Before
Tasks Board
Tasks List
Calendar Task Inspector
After
Tasks Board
Tasks List
Calendar Task Inspector
Starting Notes restyle audit on branch job/restyle-notes, base
2b27975324. I’m locating the Notes inventory and surfaces now.Starting Files+Photos pass on job/restyle-files, based on
2b27975324. I am locating the audit inventory and mapping its findings to the shared UI primitives before editing.Starting Calendar + Mail + Money findings for #1190.
Branch: job/restyle-mailmoney
Base SHA:
2b27975324I have read CLAUDE.md, CONTEXT.md, and the relevant Calendar, Mail, Money, Chrome, and Connected Account decisions in docs/DESIGN.md.
Starting Search-area restyle in job/restyle-search, based at
2b27975324.Starting #1190 Settings area in
job/restyle-settings, based at2b27975324bb1df94103b37cf8f90562390483e2.The prompt references
artifacts/restyle-audit.md, but that file is not present in the worktree or HEAD. I am checking the issue's recorded inventory and the Settings-specific design guard to recover the exact findings before editing.Evidence: test -f artifacts/restyle-audit.md returns false, and git ls-tree -r HEAD -- artifacts/restyle-audit.md returns no path. The initial inventory is present in the #1190 issue comments, so I am using it as the checklist for this pass.
Finding: artifacts/restyle-audit.md and the claimed top-level copy are absent from this worktree (git ls-tree and rg --files show no match). The issue's inventory comment contains the full Notes section, so I’m using that as the source list.
The first web check surfaced one stale exact performance pin:
coverage.surfacesforapps/web/src/lib/canvas/CanvasView.svelte#each:3a4cbef6167607e4:1reports “unused or changed exception.” This surface's action controls changed from native buttons to shared Pills and the local 44 px sizing rule was removed. I will refresh only the live syntax hash for the changed scope, keeping its owner, reason, replacement test, expiry, and limit unchanged, then rerun the guard.Inventory finding for Settings:
artifacts/restyle-audit.mdis absent from HEAD and the file history, but the #1190 audit comment records 18 shared-style overrides, 34 hand-rolled controls/cards, and 10 literal sizing/layout findings under Settings. I will use that posted inventory as the source.Scope boundary: the listed BackgroundGroup swatches and Unsplash photo choices are single-choice selectors. I will leave those controls to #1200 as requested, while fixing the ordinary action controls and shared surfaces in the same files.
Notes implementation decisions where DESIGN was silent:
material="clear",edge="none",shadow="none", andradius="control"props. This lets the Note editor keep its existing host geometry and lets embedded Canvas cards use Card without consumer selectors on.card.shape="row"for full-width label/value actions andtone="accent-soft"for the parsed reminder status. Pressed and expanded action Pills use their real ARIA state for the shared selected tint.sheetHeaderLayout="centered-leading"so the phone Contents control stays centered while the changing sheet title remains in the accessibility tree.origin/dev.The selector-owned surfaces stayed with their owners: Callout's kind selector and reminder audience selectors remain unchanged; PillGroup and BlockHoverActions remain untouched for #1189. No single-choice selector was changed.
Source review findings from the posted Settings inventory:
Cardresolve to.card-footerlayout wrappers inside existingSettingsCardgroups. They are not private card shells; wrapping each footer in another Card would add nested surfaces. App Passwords also already uses the sharedCardfor its instruction sub-cards.UnsplashSheetphoto choice button andConnectedAccountsSectionprovider choice buttons select a single option/provider. I will leave them to #1200, along with the BackgroundGroup swatches and SegmentedControl.Finding during the Files restyle:
bun run checkreported an unused or changed exactrender.boundpin forFilesBrowser.svelte#each:c469e9f9e005d61c:1. The Files menu row now uses the shared Pill, which changed the pinned loop syntax. I will refresh only this exact live pin and keep the existing performance rule and ratchet.Correction: the menu loop hash is shared by 12 exact performance-contract entries, not one. The source parser reports the live syntax digest as
93ca91d2cd4239a4edfab625a6074dfa70cba3907da5a7be04a94a8b455e6aa6. I will update those 12 existing entries to that digest only; their rules, limits, owners, and ratchet counts stay unchanged.The initial
bun run checkthen reported two implicit-anyevent parameters in the shared Files pinned-row Pill, one in the shared Card form on PublicLinkPage, and an unused.drop-namerule after replacing that local control. I addedDragEvent,KeyboardEvent, andSubmitEventannotations and removed the dead selector. The full check will run again after the requiredorigin/devmerge.Finding and fix: the focused Card/Pill tests first failed because the shared primitives did not expose the Settings variants. I added status tones, shared sizing flags, solid Card material, sheet flattening, and a semantic drop-target Card mode, with component tests and prop documentation. Focused result:
Test Files 2 passed (2); Tests 10 passed (10). The initial test invocation also found missing worktree dependencies;bun install --frozen-lockfilerestored them without a lockfile change. Commit:3b412851c.Finding and fix: Settings
StateChipandRowActionhad feature-scoped global rules that painted generic Pill tones and disabled state. They now select sharedPilltones; Jobs detail actions use the sharedflushStartprop. Focused result:Test Files 2 passed (2); Tests 9 passed (9). Commit:7438aa832.Finding and fix: Recovery Key, Unsplash and Calendar Feeds had local solid overlay paint; Recovery Key, Unsplash and Connected Accounts also carried local dialog sizes, and provider setup repeated the Settings sheet inset. OverlaySurface now owns
solid, compact/standard/wide dialog sizes and the Settings chrome option. Focused result:Test Files 1 passed (1); Tests 24 passed (24). Commit:f169d5716.Finding: the App Password expiry trigger is a date-popover button with the same field material as a text input, but the shared Select owns a single-choice menu and is outside this issue's scope. I added the additive
Pillfield shape for anchored form triggers; it does not alter Select. The focused Card/Pill tests pass:Test Files 2 passed (2); Tests 11 passed (11). Commit:be81f469b.Finding and fix: Plugins used a native button with a local 44px shell and local grab/touch styles. The handle now uses shared
Pillicon geometry and shared drag affordance while retaining the existing feature-owned drag action on the primitive root. Focused result:Test Files 2 passed (2); Tests 12 passed (12). Commit:4bd206287.Finding and fix: App Passwords had a sheet-only local Card override and a hand-built expiry button.
SettingsCardnow forwardsflatOnSheetto shared Card, and the expiry date popover uses shared Pill field geometry. The new forwarding regression test passes:Test Files 1 passed (1); Tests 4 passed (4). Commit:111b59bf6.Finding and fix: the shared AuthCard hand-built its shell, and auth flows styled native
.btncontrols around it. AuthCard now delegates surface, dimensions, padding and stack gap to shared Card; the flow actions use shared Pills and auth-ui.css excludes Pills from its native-button recipe. Commit:9b7717808.Finding and fix: Background picture upload used a feature-local dashed button, and its error retry used a hand-styled native button. The upload now uses shared Card
dropTarget, and Retry uses the shared text Pill; file selection and drag-and-drop handlers are unchanged. Commit:6df41be2a.Finding and fix: the Settings route's account, Admin-data, Plugin-catalog and Shortcuts retry actions used a locally styled native button. They now use the shared text Pill with its shared focus and touch behavior. Commit:
a303750dd.Settings follow-up findings: Admin Sign-in and Calendar Feeds had local toggle row spacing; they now use the shared Settings gap and hit-area tokens. Notifications and Voice wrapped shared Toggles in extra 34 px wrappers; those wrappers are removed because Toggle owns the target. Settings form footers now use the shared toolbar gap while Money retains its own existing footer gap.
Commits:
57776d5e9,1849d5c68,f1b077cfa,a84fbaf3d.git diff --checkpassed. The final web gates and production screenshots are still in progress.Build finding: the local calternal-server target embeds apps/web/build, which was absent from this worktree. The server compile stopped at that embed step after dependency compilation. I am building this branch’s production web assets and will rerun cargo build -p calternal-server; no Rust source change is needed.
Evidence finding: the first baseline screenshot runner exited before browser launch because Bun sharp could not resolve libstdc++.so.6. The Nix runtime library at /nix/store/z0n70pxyzi87why1bcq81zgd7b924nfj-gcc-15.2.0-lib/lib resolves it, and a sharp import check passes with that LD_LIBRARY_PATH. I am retrying the captures with this runtime path.
Evidence finding: the existing Contents rail runner reached the baseline production page but failed its unchanged geometry assertion at 1440 px light: the hover title pill intersects Note body text (pill x=292.80–526.39 px). I am preserving the test expectation and checking the after build for this overlap; I will capture the full viewport/theme matrix with a capture-only fallback if the assertion aborts early.
After-build finding: the Contents tick's offset parent is a zero-sized .pill-content; the shared magnetic action creates that positioning context, so the tick starts 15 px from the rail origin and the 1440 px hover pill begins 3 px before the tick ends. The preview container was also 233.6 px wide while Note text starts 182.8 px after its left edge. I am adding a Pill magnetic opt-out for positional markers and including both route paddings in the preview offset; the existing geometry assertions stay unchanged.
Baseline evidence before code changes:
CALTERNAL_SERVER_BIN=/home/kayg/build/targets/restyle-mailmoney/debug/calternal-server CALTERNAL_E2E_MAC=1 bun e2e/agenda-decks-822.mjsbuilt the local production route and passed the media contract checks, then timed out after 90 seconds waiting for the Week/Day attachment list to become visible. The captured DOM showed.attachment-list.is-fanwitharia-hidden="true"and theis-stack is-fanclasses. The script emitted partial Agenda screenshots, then exited 1. I did not change the existing assertion; I am keeping this restyle scoped to #1190 and will capture the affected Calendar surfaces with a focused screenshot flow.Screenshot evidence finding: the after build's real Settings theme-save API returned HTTP 507 with
Home storage quota or server free-space reserve reached.df -hshowed 23 GB available on/dev/sdb1. The screenshot fixture stopped before the after matrix completed. I am freeing this job's Rust build output, then I will rerun the production captures.After-fix finding: magnetic opt-out and padded route offset now pass the horizontal and prose-overlap assertions. The remaining centering assertion showed the rail's one-class placement selector losing to shared positioning, leaving the root 7 px above its row center. I strengthened the layout selector to target the rail row; the existing centering expectation is unchanged.
Clarification: after the prior fix, the remaining Contents tick centering issue came from selector specificity. The shared icon pill rule uses two classes, so the rail's one-class position rule did not win. I strengthened the Notes rail selector; the test expectation remains unchanged.
After-fix finding: the 1440 px hover geometry now passes, including tick clearance and no prose overlap. The next assertion found the visible tick extends 1 px into the editor Card at 820 px because the shared Pill border moves its child marker inward. I am offsetting the decorative tick by the shared hairline token so it aligns with the rail's outer edge; assertions remain unchanged.
Notes Contents follow-up: the real-server tablet geometry assertion measured the visible tick 0.078 px inside the editor Card after the shared Pill border inset. I increased the decorative marker offset by one shared hairline. The unchanged tocrail-636 assertion now passes across desktop, tablet, and phone in light and dark at 1x; committing this Contents surface fix.
Resuming #1190 in job/restyle-search. Base/head at resume:
2b27975324. Working tree is clean; I am locating the Search audit inventory and continuing the Search-only fixes.